Page MenuHomePhabricator

xingxue (Xing Xue)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 14 2019, 10:47 AM (176 w, 6 d)

Recent Activity

Yesterday

xingxue requested review of D129229: [libc++] reference_wrapper does not define nested types as described in C++11/14.
Wed, Jul 6, 2:39 PM · Restricted Project, Restricted Project, Restricted Project

Tue, Jul 5

xingxue accepted D129165: [AIX][clang/test] Set/propagate AIXTHREAD_STK for AIX.

LGTM; thanks! The IBM OpenMP runtime sets the default thread stack size to 4MiB on AIX as well.

Tue, Jul 5, 5:14 PM · Restricted Project, Restricted Project

Mon, Jun 27

xingxue committed rG339e824bcae0: [libc++][lit][AIX] Port tests for getting time to AIX (authored by xingxue).
[libc++][lit][AIX] Port tests for getting time to AIX
Mon, Jun 27, 1:08 PM · Restricted Project, Restricted Project
xingxue closed D128087: [libc++][lit][AIX] Port tests for getting time to AIX.
Mon, Jun 27, 1:08 PM · Restricted Project, Restricted Project, Restricted Project
xingxue committed rG80baa56c467a: [libc++][lit][AIX] Port tests for money format to AIX (authored by xingxue).
[libc++][lit][AIX] Port tests for money format to AIX
Mon, Jun 27, 12:59 PM · Restricted Project, Restricted Project
xingxue closed D128220: [libc++][lit][AIX] Port tests for money format to AIX.
Mon, Jun 27, 12:58 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Jun 24

xingxue committed rG60f7bdfd0317: [libc++][AIX] Make basic_string layout compatible with earlier version (authored by xingxue).
[libc++][AIX] Make basic_string layout compatible with earlier version
Fri, Jun 24, 2:27 PM · Restricted Project, Restricted Project
xingxue closed D128285: [libc++][AIX] Make basic_string layout compatible with earlier version.
Fri, Jun 24, 2:26 PM · Restricted Project, Restricted Project, Restricted Project
xingxue added inline comments to D128285: [libc++][AIX] Make basic_string layout compatible with earlier version.
Fri, Jun 24, 2:02 PM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D128285: [libc++][AIX] Make basic_string layout compatible with earlier version.

Dropped the static_assert on the size of struct __long.

Fri, Jun 24, 1:02 PM · Restricted Project, Restricted Project, Restricted Project
xingxue added inline comments to D128285: [libc++][AIX] Make basic_string layout compatible with earlier version.
Fri, Jun 24, 12:39 PM · Restricted Project, Restricted Project, Restricted Project
xingxue added inline comments to D128285: [libc++][AIX] Make basic_string layout compatible with earlier version.
Fri, Jun 24, 11:11 AM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D128285: [libc++][AIX] Make basic_string layout compatible with earlier version.

Addressed the comment to consider potential padding in the assert added for struct __long.

Fri, Jun 24, 11:09 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Jun 22

xingxue added a reviewer for D128087: [libc++][lit][AIX] Port tests for getting time to AIX: daltenty.
Wed, Jun 22, 11:57 AM · Restricted Project, Restricted Project, Restricted Project
xingxue added a reviewer for D128220: [libc++][lit][AIX] Port tests for money format to AIX: daltenty.
Wed, Jun 22, 11:56 AM · Restricted Project, Restricted Project, Restricted Project
xingxue added a comment to D128285: [libc++][AIX] Make basic_string layout compatible with earlier version.

The build failure is unrelated, can you rebase before reuploading this patch?

Wed, Jun 22, 11:17 AM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D128285: [libc++][AIX] Make basic_string layout compatible with earlier version.

Addressed comments.

  • add comments explaining why attribute __packed__ is used;
  • add static_assert for struct __long.
Wed, Jun 22, 11:12 AM · Restricted Project, Restricted Project, Restricted Project
xingxue added inline comments to D128285: [libc++][AIX] Make basic_string layout compatible with earlier version.
Wed, Jun 22, 7:33 AM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D128285: [libc++][AIX] Make basic_string layout compatible with earlier version.

Include context.

Wed, Jun 22, 7:31 AM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D128285: [libc++][AIX] Make basic_string layout compatible with earlier version.

Changed to use anonymous struct and __attribute__((__packed__)) as suggested.

Wed, Jun 22, 7:28 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 21

xingxue committed rG8da20096080b: [libc++abi][AIX] Use _LIBCXXABI_FUNC_VIS for exported routines (authored by xingxue).
[libc++abi][AIX] Use _LIBCXXABI_FUNC_VIS for exported routines
Tue, Jun 21, 1:19 PM · Restricted Project
xingxue closed D126915: [libc++abi][AIX] Use _LIBCXXABI_FUNC_VIS for exported routines.
Tue, Jun 21, 1:19 PM · Restricted Project, Restricted Project, Restricted Project
xingxue added a comment to D128087: [libc++][lit][AIX] Port tests for getting time to AIX.

Thanks very much, @Mordante and @philnik! There isn't an AIX maintainer IIUC but I will wait a couple of days to see if other reviewers have any comments. Thanks again!

You've added some of the people regularly working on AIX and @daltenty also works on AIX.

Tue, Jun 21, 9:37 AM · Restricted Project, Restricted Project, Restricted Project
xingxue requested review of D128285: [libc++][AIX] Make basic_string layout compatible with earlier version.
Tue, Jun 21, 9:00 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Jun 20

xingxue updated the diff for D128220: [libc++][lit][AIX] Port tests for money format to AIX.

Add one more test case thousands_sep.pass.cpp.

Mon, Jun 20, 2:24 PM · Restricted Project, Restricted Project, Restricted Project
xingxue requested review of D128220: [libc++][lit][AIX] Port tests for money format to AIX.
Mon, Jun 20, 12:51 PM · Restricted Project, Restricted Project, Restricted Project

Sun, Jun 19

xingxue added a comment to D128087: [libc++][lit][AIX] Port tests for getting time to AIX.

Thanks very much, @Mordante and @philnik! There isn't an AIX maintainer IIUC but I will wait a couple of days to see if other reviewers have any comments. Thanks again!

Sun, Jun 19, 7:07 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Jun 17

xingxue updated the diff for D128087: [libc++][lit][AIX] Port tests for getting time to AIX.

Added missing "of" in the comment.

Fri, Jun 17, 1:05 PM · Restricted Project, Restricted Project, Restricted Project
xingxue added inline comments to D128087: [libc++][lit][AIX] Port tests for getting time to AIX.
Fri, Jun 17, 1:00 PM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D128087: [libc++][lit][AIX] Port tests for getting time to AIX.

Added a comment in test case get_one.pass.cpp to explain the reason why the time field is omitted in the const definition for locale zh_CN.UTF-8.

Fri, Jun 17, 12:58 PM · Restricted Project, Restricted Project, Restricted Project
xingxue requested review of D128087: [libc++][lit][AIX] Port tests for getting time to AIX.
Fri, Jun 17, 12:02 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Jun 13

xingxue added a comment to D126915: [libc++abi][AIX] Use _LIBCXXABI_FUNC_VIS for exported routines.

Hi @ldionne, Would you please take a look and if no further comments, accept for #libc_abi? Thanks!

Mon, Jun 13, 6:48 AM · Restricted Project, Restricted Project, Restricted Project

Jun 5 2022

xingxue accepted D127002: [NFC][libcxx] Check def of __LONG_DOUBLE_128__ .
Jun 5 2022, 1:28 PM · Restricted Project, Restricted Project
xingxue retitled D127002: [NFC][libcxx] Check def of __LONG_DOUBLE_128__ from [NFC][libcxx] Check def of __LONG_DOUBLE_IEEE128__ to [NFC][libcxx] Check def of __LONG_DOUBLE_128__ .
Jun 5 2022, 1:07 PM · Restricted Project, Restricted Project
xingxue updated the summary of D126915: [libc++abi][AIX] Use _LIBCXXABI_FUNC_VIS for exported routines.
Jun 5 2022, 12:24 PM · Restricted Project, Restricted Project, Restricted Project
xingxue retitled D126915: [libc++abi][AIX] Use _LIBCXXABI_FUNC_VIS for exported routines from [libc++abi][AIX][NFC] Use _LIBCXXABI_FUNC_VIS for exported routines to [libc++abi][AIX] Use _LIBCXXABI_FUNC_VIS for exported routines.
Jun 5 2022, 12:17 PM · Restricted Project, Restricted Project, Restricted Project
xingxue added a comment to D126915: [libc++abi][AIX] Use _LIBCXXABI_FUNC_VIS for exported routines.

I see that https://discourse.llvm.org/t/rfc-adding-exported-visibility-style-to-the-ir-to-model-xcoff-exported-visibility/61853 says if no visibility bit (I assume n_type & SYM_V_MASK == 0) is set, the symbols need an export list.
I don't see how you use an export list for the libc++abi code, perhaps you maintain a down stream patch.

Thanks for your comments! Yes, export lists are currently used on AIX for libc++abi as well as other libraries downstream in the absence of attribute visibility.

Jun 5 2022, 12:17 PM · Restricted Project, Restricted Project, Restricted Project

Jun 2 2022

xingxue requested review of D126915: [libc++abi][AIX] Use _LIBCXXABI_FUNC_VIS for exported routines.
Jun 2 2022, 1:31 PM · Restricted Project, Restricted Project, Restricted Project
xingxue committed rGdfaee3c9cfa1: [libunwind][ci][AIX] Add libunwind to buildbot CI (authored by xingxue).
[libunwind][ci][AIX] Add libunwind to buildbot CI
Jun 2 2022, 6:04 AM · Restricted Project, Restricted Project
xingxue closed D126017: [libunwind][ci][AIX] Add libunwind to buildbot CI.
Jun 2 2022, 6:04 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jun 1 2022

xingxue added inline comments to D126017: [libunwind][ci][AIX] Add libunwind to buildbot CI.
Jun 1 2022, 11:56 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D126017: [libunwind][ci][AIX] Add libunwind to buildbot CI.

Addressed comment - changed as per suggestion.

Jun 1 2022, 11:55 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 31 2022

xingxue updated subscribers of D100504: [libc++abi][AIX] add personality and helper functions for the state table EH.

@MaskRay, @cebowleratibm, @ldionne, @hubert.reinterpretcast, @jasonliu: Thank you so much for your help, time and effort in reviewing, and constructive suggestions. All of these make the patch much better than it was. Thanks again!

May 31 2022, 6:44 AM · Restricted Project, Restricted Project, Restricted Project
xingxue committed rGb8f5732634fe: [libc++abi][AIX] add personality and helper functions for the state table EH (authored by xingxue).
[libc++abi][AIX] add personality and helper functions for the state table EH
May 31 2022, 6:23 AM · Restricted Project
xingxue closed D100504: [libc++abi][AIX] add personality and helper functions for the state table EH.
May 31 2022, 6:23 AM · Restricted Project, Restricted Project, Restricted Project

May 25 2022

xingxue added a comment to D100504: [libc++abi][AIX] add personality and helper functions for the state table EH.

Thanks very much, @MaskRay!
@ldionne Do you have further comments? If not, would you be able to approve for #libc_abi?

May 25 2022, 7:45 AM · Restricted Project, Restricted Project, Restricted Project

May 24 2022

xingxue added a comment to D100504: [libc++abi][AIX] add personality and helper functions for the state table EH.

Hi @MaskRay, Do you have further comments? If not, would you be able to approve this patch? My colleague @cebowleratibm, who is an AIX compiler and runtime expert, has done a thorough review of AIX specific contents and approved it (see comment https://reviews.llvm.org/D100504#3414984). This implementation has been run through the proprietary test coverage and included in the IBM Open XL C/C++ for AIX V17.1 compiler released in Sept. 2021.

May 24 2022, 7:10 AM · Restricted Project, Restricted Project, Restricted Project

May 20 2022

xingxue added inline comments to D126017: [libunwind][ci][AIX] Add libunwind to buildbot CI.
May 20 2022, 11:04 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D126017: [libunwind][ci][AIX] Add libunwind to buildbot CI.

Deleted an empty line with a leading # sign as suggested.

May 20 2022, 10:58 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D126017: [libunwind][ci][AIX] Add libunwind to buildbot CI.

Rebased and picked up the change in D125981 which introduces the cmake-bridge.cfg.in file to reduce the libunwind test config duplication. Thanks, @ldionne!

May 20 2022, 9:16 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
xingxue added inline comments to D100504: [libc++abi][AIX] add personality and helper functions for the state table EH.
May 20 2022, 7:53 AM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D100504: [libc++abi][AIX] add personality and helper functions for the state table EH.

Addressed comments:

  • Fixed formatting.
May 20 2022, 7:51 AM · Restricted Project, Restricted Project, Restricted Project

May 19 2022

xingxue added a comment to D100504: [libc++abi][AIX] add personality and helper functions for the state table EH.

Hi @MaskRay, Do you have further comments?

May 19 2022, 2:38 PM · Restricted Project, Restricted Project, Restricted Project
xingxue added inline comments to D126017: [libunwind][ci][AIX] Add libunwind to buildbot CI.
May 19 2022, 2:24 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D126017: [libunwind][ci][AIX] Add libunwind to buildbot CI.

Deleted a trailing empty line in file ibm-libunwind-shared.cfg.in.

May 19 2022, 2:24 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
xingxue requested review of D126017: [libunwind][ci][AIX] Add libunwind to buildbot CI.
May 19 2022, 1:49 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 13 2022

xingxue updated the diff for D100504: [libc++abi][AIX] add personality and helper functions for the state table EH.

Fixed problems in pre-merg check.

  • Avoid using GCC extension named variadic macros;
  • Avoid using C99 feature flexible array members.
May 13 2022, 12:17 PM · Restricted Project, Restricted Project, Restricted Project

May 6 2022

xingxue added inline comments to D100504: [libc++abi][AIX] add personality and helper functions for the state table EH.
May 6 2022, 7:13 AM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D100504: [libc++abi][AIX] add personality and helper functions for the state table EH.

Addressed comments. Moved the implementation for AIX state table based EH into a separate file aix_state_tab_eh.inc as suggested.

May 6 2022, 7:11 AM · Restricted Project, Restricted Project, Restricted Project

May 5 2022

xingxue accepted D124555: [libcxx] basic_ios<wchar_t> cannot store fill character WCHAR_MAX.

LGTM; however, will need the review from the libc++ group.

May 5 2022, 9:13 AM · Restricted Project, Restricted Project
xingxue committed rGe5926906eb1a: [XCOFF][AIX] Use unique section names for LSDA and EH info sections with… (authored by xingxue).
[XCOFF][AIX] Use unique section names for LSDA and EH info sections with…
May 5 2022, 6:03 AM · Restricted Project, Restricted Project
xingxue closed D124855: [XCOFF][AIX] Use unique section names for LSDA and EH info sections with -ffunction-sections.
May 5 2022, 6:03 AM · Restricted Project, Restricted Project

May 3 2022

xingxue added inline comments to D124855: [XCOFF][AIX] Use unique section names for LSDA and EH info sections with -ffunction-sections.
May 3 2022, 12:57 PM · Restricted Project, Restricted Project
xingxue updated the diff for D124855: [XCOFF][AIX] Use unique section names for LSDA and EH info sections with -ffunction-sections.

Addressed comments:

  • Fixed typos in comments;
  • Removed unnecessary cast.
May 3 2022, 12:56 PM · Restricted Project, Restricted Project
xingxue updated the summary of D124855: [XCOFF][AIX] Use unique section names for LSDA and EH info sections with -ffunction-sections.
May 3 2022, 7:46 AM · Restricted Project, Restricted Project
xingxue requested review of D124855: [XCOFF][AIX] Use unique section names for LSDA and EH info sections with -ffunction-sections.
May 3 2022, 7:45 AM · Restricted Project, Restricted Project

Apr 13 2022

xingxue committed rG7165edcad76f: [libunwind][AIX] implementation of the unwinder for AIX (authored by xingxue).
[libunwind][AIX] implementation of the unwinder for AIX
Apr 13 2022, 10:19 AM · Restricted Project
xingxue added a comment to D100132: [libunwind][AIX] implementation of the unwinder for AIX.

@MaskRay @compnerd @cebowleratibm @sfertile Thanks so much for your time and effort in reviewing this patch and providing constructive suggestions to make it better! Much appreciated!

Apr 13 2022, 8:53 AM · Restricted Project, Restricted Project, Restricted Project
xingxue committed rG9c0152cda35f: [libunwind][AIX] implementation of the unwinder for AIX (authored by xingxue).
[libunwind][AIX] implementation of the unwinder for AIX
Apr 13 2022, 8:35 AM · Restricted Project
xingxue committed rGa85da649b9ac: [libunwind][AIX] implementation of the unwinder for AIX (authored by xingxue).
[libunwind][AIX] implementation of the unwinder for AIX
Apr 13 2022, 8:05 AM · Restricted Project
xingxue closed D100132: [libunwind][AIX] implementation of the unwinder for AIX.
Apr 13 2022, 8:04 AM · Restricted Project, Restricted Project, Restricted Project

Mar 29 2022

xingxue added a comment to D100132: [libunwind][AIX] implementation of the unwinder for AIX.

Gentle ping.

Mar 29 2022, 2:56 PM · Restricted Project, Restricted Project, Restricted Project

Mar 21 2022

Herald added a project to D100132: [libunwind][AIX] implementation of the unwinder for AIX: Restricted Project.

Gentle ping.

Mar 21 2022, 12:53 PM · Restricted Project, Restricted Project, Restricted Project

Mar 2 2022

xingxue updated the diff for D100504: [libc++abi][AIX] add personality and helper functions for the state table EH.

Fixed format according to git-clang-format.

Mar 2 2022, 7:08 AM · Restricted Project, Restricted Project, Restricted Project

Mar 1 2022

xingxue added inline comments to D100504: [libc++abi][AIX] add personality and helper functions for the state table EH.
Mar 1 2022, 7:54 AM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D100504: [libc++abi][AIX] add personality and helper functions for the state table EH.

Addressed comments.

  • Updated code comments;
  • Renamed variable inlineDestructor to cleanupLabel. Replaced the term "inline destructor" with "cleanup code";
  • Renamed function compute_obj_addr to compute_addr_from_table.
Mar 1 2022, 7:53 AM · Restricted Project, Restricted Project, Restricted Project

Feb 16 2022

xingxue added a comment to D100132: [libunwind][AIX] implementation of the unwinder for AIX.

Ping... This patch failed the pre-merge check because the formatting in lines 611-612 and 1179-1180 of file Registers.hpp follows the surrounding code rather than git-clang-format.

Feb 16 2022, 9:07 AM · Restricted Project, Restricted Project, Restricted Project

Feb 15 2022

xingxue committed rG16667362d0d1: [libc++][AIX] Remove "pragma priority" from locale.cpp (authored by xingxue).
[libc++][AIX] Remove "pragma priority" from locale.cpp
Feb 15 2022, 5:38 AM
xingxue closed D119765: [libc++][AIX] Remove "pragma priority" from locale.cpp.
Feb 15 2022, 5:37 AM · Restricted Project

Feb 14 2022

xingxue added inline comments to D119765: [libc++][AIX] Remove "pragma priority" from locale.cpp.
Feb 14 2022, 1:28 PM · Restricted Project
xingxue requested review of D119765: [libc++][AIX] Remove "pragma priority" from locale.cpp.
Feb 14 2022, 12:30 PM · Restricted Project

Feb 7 2022

xingxue added inline comments to D100504: [libc++abi][AIX] add personality and helper functions for the state table EH.
Feb 7 2022, 1:12 PM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D100504: [libc++abi][AIX] add personality and helper functions for the state table EH.

Addressed comments.

  • Used unions where the same memory is used for different purposes to make overlapping use of the memory more clear.
  • Renamed variables to be more descriptive.
  • Added a high level description of the state table based EH.
  • Added comments in various locations.
  • Fixed a problem where the frame pointer is needed to calculate the address.
  • Fixed the address calculation of virtual base object for calling destructor or deletor to be based on the IBM object model used by the proprietary xlC compiler because these paths are only used for xlC generated code.
  • Commoned up some code to reduce redundancy.
Feb 7 2022, 1:11 PM · Restricted Project, Restricted Project, Restricted Project

Feb 2 2022

xingxue added inline comments to D100132: [libunwind][AIX] implementation of the unwinder for AIX.
Feb 2 2022, 2:30 PM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D100132: [libunwind][AIX] implementation of the unwinder for AIX.

Addressed comments:

  • Remove the cursor size definition for building with AIX GCC for now because it is not enabled yet;
  • Use the C++ style cast rather than C style cast;
  • Be consistent with the surrounding area's formatting.
Feb 2 2022, 2:29 PM · Restricted Project, Restricted Project, Restricted Project

Jan 24 2022

xingxue accepted D117040: [PowerPC][AIX] Override markFunctionEnd().

LGTM; thanks!

Jan 24 2022, 10:42 AM · Restricted Project, Restricted Project

Jan 12 2022

xingxue updated the diff for D100132: [libunwind][AIX] implementation of the unwinder for AIX.

Addressed comments.

  • fix errors in comments.
Jan 12 2022, 12:48 PM · Restricted Project, Restricted Project, Restricted Project
xingxue added inline comments to D100132: [libunwind][AIX] implementation of the unwinder for AIX.
Jan 12 2022, 12:34 PM · Restricted Project, Restricted Project, Restricted Project

Jan 11 2022

xingxue updated the diff for D100132: [libunwind][AIX] implementation of the unwinder for AIX.

Addressed comments.

  • allow the declaration of _Unwind_GetTextRelBase() on AIX.
  • rename getFuncName to getFuncNameFromTBTable.
  • rename clangFrame to frameWithEHInfo and rename classicFrame to frameWithXLEHStateTable.
  • add comments to describe the code looking for eh_info and dealing with the complexity arising from some XL compiler versions use the wrong ordering of flag bits.
Jan 11 2022, 9:27 AM · Restricted Project, Restricted Project, Restricted Project
xingxue added inline comments to D100132: [libunwind][AIX] implementation of the unwinder for AIX.
Jan 11 2022, 9:08 AM · Restricted Project, Restricted Project, Restricted Project

Jan 7 2022

xingxue updated the diff for D100132: [libunwind][AIX] implementation of the unwinder for AIX.

Addressed comment:

  • Use the same logic for skipping the name_len and name fields.
Jan 7 2022, 10:39 AM · Restricted Project, Restricted Project, Restricted Project
xingxue added inline comments to D100132: [libunwind][AIX] implementation of the unwinder for AIX.
Jan 7 2022, 10:27 AM · Restricted Project, Restricted Project, Restricted Project

Jan 6 2022

xingxue updated the diff for D100132: [libunwind][AIX] implementation of the unwinder for AIX.

Addressed comments:

  • Make the declaration of _Unwind_GetDataRelBase cleaner in unwind.h.
  • Rename enum member oldFrame to classicXLFrame.
  • Use typedef of xlcxx_personality_v0_t in the declaration of __xlcxx_personality_v0().
  • Rename variable stateOffset to stateTableOffset.
  • Add commet to explain why dynamically resolving the personality for the state table.
Jan 6 2022, 11:26 AM · Restricted Project, Restricted Project, Restricted Project
xingxue added inline comments to D100132: [libunwind][AIX] implementation of the unwinder for AIX.
Jan 6 2022, 10:59 AM · Restricted Project, Restricted Project, Restricted Project

Dec 9 2021

xingxue added a comment to D114445: [libc++abi][AIX] Add 2 LIT tests for the AIX unwinder.

Hi @compnerd, Thanks very much for your comments! I've made changes accordingly. Please let me know if you have further comments!

Dec 9 2021, 1:50 PM · Restricted Project, Restricted Project
xingxue committed rGbc7f0fb5ea74: [libc++abi][AIX] Add 2 LIT tests for the AIX unwinder (authored by xingxue).
[libc++abi][AIX] Add 2 LIT tests for the AIX unwinder
Dec 9 2021, 1:46 PM
xingxue closed D114445: [libc++abi][AIX] Add 2 LIT tests for the AIX unwinder.
Dec 9 2021, 1:46 PM · Restricted Project, Restricted Project

Nov 23 2021

xingxue requested review of D114445: [libc++abi][AIX] Add 2 LIT tests for the AIX unwinder.
Nov 23 2021, 8:17 AM · Restricted Project, Restricted Project

Nov 18 2021

xingxue added a comment to D113607: [libunwind][AIX] Mark signal_frame.pass.cpp UNSUPPORTED on AIX.

Thanks for reviewing this patch, @danielkiss, @MaskRay, @ldionne! Yes, target=powerpc-ibm-aix (32-bit) and target=powerpc64-ibm-aix (64-bit) are LIT features. Updated the patch as suggested. Thanks, @ldionne!

Nov 18 2021, 7:43 AM · Restricted Project, Restricted Project
xingxue committed rG11982eed2bc8: [libunwind][AIX] Mark signal_frame.pass.cpp UNSUPPORTED on AIX (authored by xingxue).
[libunwind][AIX] Mark signal_frame.pass.cpp UNSUPPORTED on AIX
Nov 18 2021, 7:31 AM