Page MenuHomePhabricator

xingxue (Xing Xue)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 14 2019, 10:47 AM (121 w, 2 d)

Recent Activity

Yesterday

xingxue closed D101545: [libc++abi] NFC: adding a new parameter base to functions for calculating addresses with relative encodings.

Commit: rG7f0244afa828: [libc++abi] NFC: adding a new parameter base to functions for calculating… (authored by xingxue). Closing.

Fri, Jun 11, 9:22 AM · Restricted Project, Restricted Project
xingxue added a comment to D101545: [libc++abi] NFC: adding a new parameter base to functions for calculating addresses with relative encodings.

TBH, cxa_personality is somewhat below what I usually touch, so I don't really have a concern here.

I'd like to note that this patch does trigger -Wunused-parameter, though - would it be possible to fix those, or are those seemingly unused parameters actually necessary to reduce the diff between upstream and a downstream fork?

Fri, Jun 11, 9:13 AM · Restricted Project, Restricted Project

Thu, Jun 10

xingxue updated the diff for D101298: [libc++abi][AIX] Enable calculating addresses with DW_EH_PE_datarel.

Removed the dependent patch which has landed. Try to trigger the pre-merge check.

Thu, Jun 10, 11:17 AM · Restricted Project, Restricted Project
xingxue added inline comments to D101298: [libc++abi][AIX] Enable calculating addresses with DW_EH_PE_datarel.
Thu, Jun 10, 11:00 AM · Restricted Project, Restricted Project
xingxue updated the diff for D101298: [libc++abi][AIX] Enable calculating addresses with DW_EH_PE_datarel.

Addressed comments:

  • Added parameter base to readEncodedPointer() calls.
Thu, Jun 10, 10:23 AM · Restricted Project, Restricted Project
xingxue committed rG7f0244afa828: [libc++abi] NFC: adding a new parameter base to functions for calculating… (authored by xingxue).
[libc++abi] NFC: adding a new parameter base to functions for calculating…
Thu, Jun 10, 7:46 AM

Wed, Jun 2

xingxue added a comment to D101545: [libc++abi] NFC: adding a new parameter base to functions for calculating addresses with relative encodings.

Ping.

Wed, Jun 2, 8:02 AM · Restricted Project, Restricted Project

Tue, May 25

xingxue updated subscribers of D101545: [libc++abi] NFC: adding a new parameter base to functions for calculating addresses with relative encodings.

@libc++abi, @mclow.lists Hi, This NFC patch has been reviewed and approved by @sfertile but it needs the approval from blocking reviewer the libc++abi group before it can be landed. We are working on the Clang compiler for the AIX platform and libunwind/libc++abi are used for EH. For AIX, the DW_EH_PE_datarel encoding is used for calculating relative addresses in the range table. Therefore, the code for scanning the range table is extended to have one more parameter base. This NFC patch and the follow-on patch https://reviews.llvm.org/D101298 are the changes needed to process the range table for Clang on AIX. It is important to us to get the changes reviewed and landed to unblock the buildbot. It would be greatly appreciated if the group can take a look and let us know if there are any concerns.

Tue, May 25, 10:28 AM · Restricted Project, Restricted Project

Mon, May 17

xingxue updated the diff for D100132: [libunwind][AIX] Initial patch of the unwinder on AIX.

Changes:

  • Dynamically resolve symbol __xlcxx_personality_v0 that is the personality for the state table so that libunwind does not have hard dependency on libc++abi on AIX.
Mon, May 17, 2:07 PM · Restricted Project, Restricted Project
xingxue added a comment to D101545: [libc++abi] NFC: adding a new parameter base to functions for calculating addresses with relative encodings.

Hi @MaskRay, Do you have any further comments/concerns? Thanks!

Mon, May 17, 12:11 PM · Restricted Project, Restricted Project
xingxue added a comment to D101298: [libc++abi][AIX] Enable calculating addresses with DW_EH_PE_datarel.

Hi @MaskRay, Do you have any further comments/concerns? Thanks!

Mon, May 17, 12:10 PM · Restricted Project, Restricted Project

May 13 2021

xingxue added inline comments to D101298: [libc++abi][AIX] Enable calculating addresses with DW_EH_PE_datarel.
May 13 2021, 1:36 PM · Restricted Project, Restricted Project

May 10 2021

xingxue added a reviewer for D101545: [libc++abi] NFC: adding a new parameter base to functions for calculating addresses with relative encodings: compnerd.
May 10 2021, 2:41 PM · Restricted Project, Restricted Project
xingxue updated the summary of D101545: [libc++abi] NFC: adding a new parameter base to functions for calculating addresses with relative encodings.
May 10 2021, 2:36 PM · Restricted Project, Restricted Project

May 6 2021

xingxue committed rG8408d3f2d814: [libunwind] NFC: Use macros to accommodate differences in representation of… (authored by xingxue).
[libunwind] NFC: Use macros to accommodate differences in representation of…
May 6 2021, 11:41 AM
xingxue closed D101179: [libunwind] NFC: Use macros to accommodate differences in representation of PowerPC assemblers.
May 6 2021, 11:40 AM · Restricted Project, Restricted Project

May 5 2021

xingxue updated the diff for D100132: [libunwind][AIX] Initial patch of the unwinder on AIX.

Changes from clang-format.

May 5 2021, 8:43 AM · Restricted Project, Restricted Project
xingxue updated the diff for D100132: [libunwind][AIX] Initial patch of the unwinder on AIX.

Rebased after changes for PowerPC assembly code in NFC patch (https://reviews.llvm.org/D101179).

May 5 2021, 7:01 AM · Restricted Project, Restricted Project
xingxue updated the diff for D101179: [libunwind] NFC: Use macros to accommodate differences in representation of PowerPC assemblers.

Minor change from clang-format.

May 5 2021, 6:30 AM · Restricted Project, Restricted Project
xingxue added a comment to D101179: [libunwind] NFC: Use macros to accommodate differences in representation of PowerPC assemblers.

Do we need GPR? ld 0, 4(3) works as ld r0, 4(r3) in GNU flavored assembly. Other macros may be similar.

May 5 2021, 4:20 AM · Restricted Project, Restricted Project
xingxue updated the diff for D101179: [libunwind] NFC: Use macros to accommodate differences in representation of PowerPC assemblers.

Addressed comments:

  • Changed the representation of PowperPC registers from %rn, %fn, %vsn, and %vrn to the register number alone. The GNU flavored assembler and the AIX assembler can determine the register kind based on the context of the instruction in which the register is used.
May 5 2021, 4:17 AM · Restricted Project, Restricted Project

May 4 2021

xingxue added a comment to D101179: [libunwind] NFC: Use macros to accommodate differences in representation of PowerPC assemblers.

Hi @MaskRay @compnerd, Do you have any further comments?

May 4 2021, 11:36 AM · Restricted Project, Restricted Project

May 3 2021

xingxue updated the diff for D101298: [libc++abi][AIX] Enable calculating addresses with DW_EH_PE_datarel.

Refreshed after changes in the base NFC patch https://reviews.llvm.org/D101545.

May 3 2021, 10:20 AM · Restricted Project, Restricted Project
xingxue added inline comments to D101545: [libc++abi] NFC: adding a new parameter base to functions for calculating addresses with relative encodings.
May 3 2021, 10:09 AM · Restricted Project, Restricted Project
xingxue added a comment to D101545: [libc++abi] NFC: adding a new parameter base to functions for calculating addresses with relative encodings.
May 3 2021, 9:33 AM · Restricted Project, Restricted Project
xingxue updated the diff for D101545: [libc++abi] NFC: adding a new parameter base to functions for calculating addresses with relative encodings.

Addressed comment:

May 3 2021, 9:31 AM · Restricted Project, Restricted Project
xingxue updated the summary of D101179: [libunwind] NFC: Use macros to accommodate differences in representation of PowerPC assemblers.
May 3 2021, 7:48 AM · Restricted Project, Restricted Project

Apr 29 2021

xingxue added a comment to D101545: [libc++abi] NFC: adding a new parameter base to functions for calculating addresses with relative encodings.

I keep feeling that the AIX implementation probably needs its own file. Making Itanium/ARM/SEH share some functions actually make generic code improvement harder.

Apr 29 2021, 11:44 AM · Restricted Project, Restricted Project
xingxue updated the diff for D101298: [libc++abi][AIX] Enable calculating addresses with DW_EH_PE_datarel.

Refreshed to base on the split out NFC patch https://reviews.llvm.org/D101545.

Apr 29 2021, 10:52 AM · Restricted Project, Restricted Project
xingxue added a reviewer for D101545: [libc++abi] NFC: adding a new parameter base to functions for calculating addresses with relative encodings: hubert.reinterpretcast.
Apr 29 2021, 9:48 AM · Restricted Project, Restricted Project
xingxue requested review of D101545: [libc++abi] NFC: adding a new parameter base to functions for calculating addresses with relative encodings.
Apr 29 2021, 9:47 AM · Restricted Project, Restricted Project

Apr 28 2021

xingxue updated the diff for D101298: [libc++abi][AIX] Enable calculating addresses with DW_EH_PE_datarel.

This version is clean of format changes made by clang-format.

Apr 28 2021, 8:48 AM · Restricted Project, Restricted Project
xingxue added a comment to D101179: [libunwind] NFC: Use macros to accommodate differences in representation of PowerPC assemblers.

While I think that this is fine in general, I'm not sure why the shift operator needs to be replaced. Could you shed some light on that?

Apr 28 2021, 6:53 AM · Restricted Project, Restricted Project

Apr 26 2021

xingxue updated the diff for D101298: [libc++abi][AIX] Enable calculating addresses with DW_EH_PE_datarel.

Removed the incorrect setting of parent revision. Reload the patch to trigger the pre-merge check. Sorry for the noise.

Apr 26 2021, 1:19 PM · Restricted Project, Restricted Project
xingxue added inline comments to D100504: [libc++abi][AIX] initial patch for EH on AIX.
Apr 26 2021, 8:36 AM · Restricted Project, Restricted Project
xingxue updated the diff for D100504: [libc++abi][AIX] initial patch for EH on AIX.

Changes:

  • Split off changes for enabling calculating relative addresses with the DW_EH_PE_datarel encoding using a base (https://reviews.llvm.org/D101298).
  • Reverted to making __xlcxx_personality_v1 an alias of __gxx_personality_v0.
Apr 26 2021, 8:33 AM · Restricted Project, Restricted Project
xingxue requested review of D101298: [libc++abi][AIX] Enable calculating addresses with DW_EH_PE_datarel.
Apr 26 2021, 7:57 AM · Restricted Project, Restricted Project

Apr 23 2021

xingxue added a comment to D100504: [libc++abi][AIX] initial patch for EH on AIX.

In sanitizer runtime, we create separate files and duplicate some needed functions when a platform has sufficient different implementation. See compiler-rt/lib/sanitizer_common/*.cpp and compiler-lib/lib/lsan/lsan_*.cpp for examples.

I have simplified the Itanium LSDA a lot. From my experience the code sharing with arm EHABI actually made it really different to refactor.

Apr 23 2021, 12:43 PM · Restricted Project, Restricted Project
xingxue updated the diff for D100132: [libunwind][AIX] Initial patch of the unwinder on AIX.

Addressed comment:

Apr 23 2021, 12:20 PM · Restricted Project, Restricted Project
xingxue requested review of D101179: [libunwind] NFC: Use macros to accommodate differences in representation of PowerPC assemblers.
Apr 23 2021, 9:33 AM · Restricted Project, Restricted Project

Apr 21 2021

xingxue updated the diff for D100504: [libc++abi][AIX] initial patch for EH on AIX.

Changes:

  • Added #include <stdio.h> for fprintf() as suggested.
  • Make __xlcxx_personality_v1 a wrapper of __gxx_personality_v0.
Apr 21 2021, 10:21 AM · Restricted Project, Restricted Project

Apr 15 2021

xingxue updated the diff for D100504: [libc++abi][AIX] initial patch for EH on AIX.

Fixed pre-merge issues for Arm.

Apr 15 2021, 8:17 AM · Restricted Project, Restricted Project

Apr 14 2021

xingxue updated the summary of D100132: [libunwind][AIX] Initial patch of the unwinder on AIX.
Apr 14 2021, 12:54 PM · Restricted Project, Restricted Project
xingxue requested review of D100504: [libc++abi][AIX] initial patch for EH on AIX.
Apr 14 2021, 12:52 PM · Restricted Project, Restricted Project

Apr 13 2021

xingxue updated the diff for D100132: [libunwind][AIX] Initial patch of the unwinder on AIX.

Fixed some more assembly issues from the formatter.

Apr 13 2021, 12:51 PM · Restricted Project, Restricted Project

Apr 12 2021

xingxue added a comment to D100132: [libunwind][AIX] Initial patch of the unwinder on AIX.

Dear Reviewers.

Apr 12 2021, 12:16 PM · Restricted Project, Restricted Project

Apr 9 2021

xingxue updated the diff for D100132: [libunwind][AIX] Initial patch of the unwinder on AIX.

Fixed the issue caused by git-clang-format in file assembly.h.

Apr 9 2021, 2:50 PM · Restricted Project, Restricted Project

Apr 8 2021

xingxue updated the diff for D100132: [libunwind][AIX] Initial patch of the unwinder on AIX.

Renamed variables in Unwind_AIXExtras.cpp.

Apr 8 2021, 1:55 PM · Restricted Project, Restricted Project
xingxue updated the diff for D100132: [libunwind][AIX] Initial patch of the unwinder on AIX.

Updated after running git-clang-format.

Apr 8 2021, 12:43 PM · Restricted Project, Restricted Project
xingxue requested review of D100132: [libunwind][AIX] Initial patch of the unwinder on AIX.
Apr 8 2021, 11:48 AM · Restricted Project, Restricted Project

Apr 15 2020

xingxue committed rG4578fa8a1cc3: [demangler] PPC and S390: Fix parsing of e-prefixed long double literals (authored by xingxue).
[demangler] PPC and S390: Fix parsing of e-prefixed long double literals
Apr 15 2020, 7:07 AM
xingxue closed D74163: [demangler] PPC and S390: Fix parsing of e-prefixed long double literals.
Apr 15 2020, 7:07 AM · Restricted Project, Restricted Project, Restricted Project

Apr 13 2020

xingxue updated the diff for D74163: [demangler] PPC and S390: Fix parsing of e-prefixed long double literals.

Addressed comments:

  • Added a comment as suggested.
Apr 13 2020, 2:41 PM · Restricted Project, Restricted Project, Restricted Project
xingxue added inline comments to D74163: [demangler] PPC and S390: Fix parsing of e-prefixed long double literals.
Apr 13 2020, 12:25 PM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D74163: [demangler] PPC and S390: Fix parsing of e-prefixed long double literals.

Addressed comments:

  • Leave the existing handling of type code g unchanged as suggested.
Apr 13 2020, 12:25 PM · Restricted Project, Restricted Project, Restricted Project

Feb 25 2020

xingxue abandoned D75060: [test][go]Use -stdlib=libc++ to build GO binding test if LLVM is built with libc++.

Revision no longer needed now that the GO binding test code has been reverted. Thanks!

Feb 25 2020, 10:37 AM · Restricted Project
xingxue updated the diff for D74163: [demangler] PPC and S390: Fix parsing of e-prefixed long double literals.

Addressed comments:

Feb 25 2020, 8:44 AM · Restricted Project, Restricted Project, Restricted Project
xingxue added a comment to D74163: [demangler] PPC and S390: Fix parsing of e-prefixed long double literals.

I'm still wondering about Intel. Can there ever be a literal encoded using 'g' on Intel? If yes, then treating it as "long double" would still be wrong, because 'g' encodes IEEE128 (__float128), while "long double" is the Intel extended (80-bit) format, right?

On the other hand, if 'g' encoded literals can never happen on Intel (or other platforms), maybe it would be better to have the code handling 'g' within a #ifdef section only active on powerpc and s390?

For X86, 'e' is used for 80-bit long double and 'g' is used for 128-bit long double. The following is the code in Clang.

clang/lib/Basic/Targets/X86.h
....
const char *getLongDoubleMangling() const override {
  return LongDoubleFormat == &llvm::APFloat::IEEEquad() ? "g" : "e";
}
...

But then this patch must be incorrect, given that it does

return getDerived().template parseFloatingLiteral<long double>();

for both the 'e' and 'g' cases on Intel. Now I guess it depends on how the file is compiled (with -mlong-double-80 or -mlong-double-128), but either way, one of the cases will be handled incorrectly.

Feb 25 2020, 8:26 AM · Restricted Project, Restricted Project, Restricted Project
xingxue added a comment to D74163: [demangler] PPC and S390: Fix parsing of e-prefixed long double literals.

I'm still wondering about Intel. Can there ever be a literal encoded using 'g' on Intel? If yes, then treating it as "long double" would still be wrong, because 'g' encodes IEEE128 (__float128), while "long double" is the Intel extended (80-bit) format, right?

On the other hand, if 'g' encoded literals can never happen on Intel (or other platforms), maybe it would be better to have the code handling 'g' within a #ifdef section only active on powerpc and s390?

For X86, 'e' is used for 80-bit long double and 'g' is used for 128-bit long double. The following is the code in Clang.

clang/lib/Basic/Targets/X86.h
....
const char *getLongDoubleMangling() const override {
  return LongDoubleFormat == &llvm::APFloat::IEEEquad() ? "g" : "e";
}
...
Feb 25 2020, 7:42 AM · Restricted Project, Restricted Project, Restricted Project

Feb 24 2020

xingxue added a comment to D74163: [demangler] PPC and S390: Fix parsing of e-prefixed long double literals.

Hi @uweigand, Thanks for your comments. Please see my explanations below.

Feb 24 2020, 2:20 PM · Restricted Project, Restricted Project, Restricted Project
xingxue created D75060: [test][go]Use -stdlib=libc++ to build GO binding test if LLVM is built with libc++.
Feb 24 2020, 9:08 AM · Restricted Project

Feb 21 2020

xingxue added a comment to D74163: [demangler] PPC and S390: Fix parsing of e-prefixed long double literals.

@uweigand, Hi, I've addressed your comments. Any further comments?

Feb 21 2020, 1:16 PM · Restricted Project, Restricted Project, Restricted Project

Feb 13 2020

xingxue accepted D72736: [AIX] Add improved interface for retrieving load module paths.

LGTM.

Feb 13 2020, 1:01 PM · Restricted Project, Restricted Project

Feb 7 2020

xingxue updated the diff for D74163: [demangler] PPC and S390: Fix parsing of e-prefixed long double literals.

Addressed comments:

Feb 7 2020, 10:44 AM · Restricted Project, Restricted Project, Restricted Project

Feb 6 2020

xingxue created D74163: [demangler] PPC and S390: Fix parsing of e-prefixed long double literals.
Feb 6 2020, 1:38 PM · Restricted Project, Restricted Project, Restricted Project

Nov 20 2019

xingxue committed rG5665fc91fe93: [AIX][XCOFF] Add support for generating assembly code for one-byte mergable… (authored by xingxue).
[AIX][XCOFF] Add support for generating assembly code for one-byte mergable…
Nov 20 2019, 8:34 AM
xingxue closed D70310: [AIX][XCOFF] Add support for generating assembly code for one-byte mergable strings.
Nov 20 2019, 8:34 AM · Restricted Project

Nov 15 2019

xingxue created D70310: [AIX][XCOFF] Add support for generating assembly code for one-byte mergable strings.
Nov 15 2019, 6:58 AM · Restricted Project

Nov 8 2019

xingxue added a comment to D69528: [PowerPC][XCOFF] Add assembly support for zero initalized global values..

Test file aix-xcoff-data.ll needs a rebase.

Nov 8 2019, 9:12 AM · Restricted Project

Oct 28 2019

xingxue added inline comments to D67125: [PowerPC][AIX] Adds support for writing the data section in object files.
Oct 28 2019, 9:52 AM · Restricted Project
xingxue accepted D69447: [NFCI][XCOFF][AIX] Skip empty Section during object file generation.

LGTM.

Oct 28 2019, 7:12 AM · Restricted Project

Oct 25 2019

xingxue updated the diff for D67125: [PowerPC][AIX] Adds support for writing the data section in object files.

Revised based on changes in patch https://reviews.llvm.org/D69112.

Oct 25 2019, 8:52 AM · Restricted Project

Oct 2 2019

xingxue updated the diff for D67125: [PowerPC][AIX] Adds support for writing the data section in object files.

Addressed comments:

  • Changed variable name CSection -> Csect;
  • Added the checking of section headers in the object file.
Oct 2 2019, 2:29 AM · Restricted Project

Sep 30 2019

xingxue added inline comments to D67125: [PowerPC][AIX] Adds support for writing the data section in object files.
Sep 30 2019, 9:56 AM · Restricted Project

Sep 20 2019

xingxue added inline comments to D66969: Output XCOFF object text section header and symbol entry for program code.
Sep 20 2019, 1:56 PM · Restricted Project

Sep 11 2019

xingxue updated the diff for D67125: [PowerPC][AIX] Adds support for writing the data section in object files.

Changed from Data to Data.Index.

Sep 11 2019, 2:02 PM · Restricted Project

Sep 9 2019

xingxue added inline comments to D67125: [PowerPC][AIX] Adds support for writing the data section in object files.
Sep 9 2019, 2:14 PM · Restricted Project
xingxue updated the diff for D67125: [PowerPC][AIX] Adds support for writing the data section in object files.

Addressed comments:

  • use csects in comment.
  • use section storage class from CSection.
  • set the section start address as the address after the previous section.
Sep 9 2019, 2:13 PM · Restricted Project

Sep 3 2019

xingxue created D67125: [PowerPC][AIX] Adds support for writing the data section in object files.
Sep 3 2019, 12:58 PM · Restricted Project

Aug 30 2019

xingxue committed rL370539: Request commit access for xingxue.
Request commit access for xingxue
Aug 30 2019, 3:22 PM

Aug 27 2019

xingxue added inline comments to D66724: [AIX]Emit function descriptor csect in assembly.
Aug 27 2019, 5:59 AM · Restricted Project

Aug 26 2019

xingxue added a comment to D66724: [AIX]Emit function descriptor csect in assembly.

This patch needs a rebase.

Aug 26 2019, 4:05 AM · Restricted Project

Aug 25 2019

xingxue updated the diff for D66154: [PowerPC][AIX] Adds support for writing the .data section in assembly files.

Merged with the master and fixed a typo.

Aug 25 2019, 8:44 AM · Restricted Project
xingxue committed rGef039a3ccdcd: [PowerPC][AIX] Adds support for writing the .data section in assembly files (authored by xingxue).
[PowerPC][AIX] Adds support for writing the .data section in assembly files
Aug 25 2019, 8:17 AM
xingxue committed rL369869: [PowerPC][AIX] Adds support for writing the .data section in assembly files.
[PowerPC][AIX] Adds support for writing the .data section in assembly files
Aug 25 2019, 8:17 AM
xingxue closed D66154: [PowerPC][AIX] Adds support for writing the .data section in assembly files.
Aug 25 2019, 8:17 AM · Restricted Project

Aug 22 2019

xingxue updated the diff for D66154: [PowerPC][AIX] Adds support for writing the .data section in assembly files.

Addressed comments:

Aug 22 2019, 6:29 PM · Restricted Project
xingxue added inline comments to D66154: [PowerPC][AIX] Adds support for writing the .data section in assembly files.
Aug 22 2019, 12:31 PM · Restricted Project
xingxue updated the diff for D66154: [PowerPC][AIX] Adds support for writing the .data section in assembly files.

Addressed comments:

Aug 22 2019, 12:31 PM · Restricted Project

Aug 21 2019

xingxue updated the diff for D66154: [PowerPC][AIX] Adds support for writing the .data section in assembly files.
Aug 21 2019, 8:02 AM · Restricted Project

Aug 19 2019

xingxue added inline comments to D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..
Aug 19 2019, 8:03 AM · Restricted Project

Aug 15 2019

xingxue accepted D66256: [AIX] For XL, pick GCC-compatible std & default warning options.

LGTM.

Aug 15 2019, 6:04 AM · Restricted Project

Aug 13 2019

xingxue added a reviewer for D66154: [PowerPC][AIX] Adds support for writing the .data section in assembly files: Xiangling_L.
Aug 13 2019, 10:42 AM · Restricted Project
xingxue created D66154: [PowerPC][AIX] Adds support for writing the .data section in assembly files.
Aug 13 2019, 10:42 AM · Restricted Project

Aug 12 2019

xingxue accepted D65159: [PowerPC][XCOFF] Adds support for writing the .bss section for object files..

LGTM.

Aug 12 2019, 12:28 PM · Restricted Project

Jun 26 2019

xingxue committed rG600941e34fed: Print NULL as "(null)" in diagnostic message (authored by xingxue).
Print NULL as "(null)" in diagnostic message
Jun 26 2019, 12:29 PM
xingxue committed rL364462: Print NULL as "(null)" in diagnostic message.
Print NULL as "(null)" in diagnostic message
Jun 26 2019, 12:27 PM
xingxue closed D63786: Print NULL as "(null)" in diagnostic message.
Jun 26 2019, 12:27 PM · Restricted Project, Restricted Project

Jun 25 2019

xingxue committed rL364322: Improve zero-size allocation with safe_malloc, etc..
Improve zero-size allocation with safe_malloc, etc.
Jun 25 2019, 8:21 AM
xingxue committed rGece53d0ae50a: Improve zero-size allocation with safe_malloc, etc. (authored by xingxue).
Improve zero-size allocation with safe_malloc, etc.
Jun 25 2019, 8:15 AM