Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

xingxue (Xing Xue)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 14 2019, 10:47 AM (241 w, 2 d)

Recent Activity

Wed, Sep 27

xingxue added a comment to D124555: [libcxx] basic_ios<wchar_t> cannot store fill character WCHAR_MAX.

From the AIX and z/OS perspective, the replacement of the two members with a member having two fields is not 100% binary compatible for all usage. At least if the basic_ios specialization is used as a non-virtual base class, any derived class members that could be allocated in the padding following the bool would now move. This could be preemptively avoided if the new class type is given a user-provided copy constructor or destructor and the new member made [[no_unique_address]]. I don't know if [[no_unique_address]] is usable is some form under C++98/03 though.

We may be able to use some form of packed too.

Wed, Sep 27, 12:08 PM · Restricted Project, Restricted Project
xingxue added a comment to D124555: [libcxx] basic_ios<wchar_t> cannot store fill character WCHAR_MAX.

Hi @ldionne, It would be appreciated if you could take a look at this patch and provide guidance on how to proceed.

Wed, Sep 27, 7:02 AM · Restricted Project, Restricted Project

Tue, Sep 26

xingxue commandeered D124555: [libcxx] basic_ios<wchar_t> cannot store fill character WCHAR_MAX.

I am taking over this revision because @cebowleratibm is working on a different project.

Tue, Sep 26, 8:36 AM · Restricted Project, Restricted Project

Sat, Sep 16

xingxue edited reviewers for D129229: [libc++] reference_wrapper does not define nested types as described in C++11/14, added: EricWF; removed: cebowleratibm.
Sat, Sep 16, 4:48 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Sep 15

xingxue added a comment to D129229: [libc++] reference_wrapper does not define nested types as described in C++11/14.

@xingxue I apologize on behalf of the project for dropping this? Are you still willing to land it. If so, we can have it reviewed and completed this week.

Fri, Sep 15, 6:28 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Sep 7

xingxue added a comment to D158215: [libc++][NFC] Remove __has_keyword.

I've reverted this patch to unblock the internal AIX buildbot.

Thu, Sep 7, 11:59 AM · Restricted Project, Restricted Project
xingxue added a reverting change for rGcd34e89cfabb: [libc++][NFC] Remove __has_keyword: rG7f302f220e7b: Revert "[libc++][NFC] Remove __has_keyword".
Thu, Sep 7, 11:56 AM · Restricted Project, Restricted Project
xingxue committed rG7f302f220e7b: Revert "[libc++][NFC] Remove __has_keyword" (authored by xingxue).
Revert "[libc++][NFC] Remove __has_keyword"
Thu, Sep 7, 11:56 AM · Restricted Project, Restricted Project
xingxue added a reverting change for D158215: [libc++][NFC] Remove __has_keyword: rG7f302f220e7b: Revert "[libc++][NFC] Remove __has_keyword".
Thu, Sep 7, 11:56 AM · Restricted Project, Restricted Project
xingxue accepted D159319: [AIX] Add threadId and use nanosecond timestamp in sinit/sterm symbols.

Confirm LGTM.

Thu, Sep 7, 9:01 AM · Restricted Project, Restricted Project

Sat, Sep 2

xingxue accepted D159319: [AIX] Add threadId and use nanosecond timestamp in sinit/sterm symbols.

LGTM, provided the CI is clean.

Sat, Sep 2, 8:38 AM · Restricted Project, Restricted Project

Aug 31 2023

xingxue added inline comments to D158655: [libunwind][AIX] Fix problem with stepping up from a leaf function when unwinding started in a signal handler.
Aug 31 2023, 8:03 AM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D158655: [libunwind][AIX] Fix problem with stepping up from a leaf function when unwinding started in a signal handler.

Addressed comments:

  • add instruction bl $+4 in the assembly code of the test case
Aug 31 2023, 8:01 AM · Restricted Project, Restricted Project, Restricted Project

Aug 30 2023

xingxue added inline comments to D158655: [libunwind][AIX] Fix problem with stepping up from a leaf function when unwinding started in a signal handler.
Aug 30 2023, 11:13 AM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D158655: [libunwind][AIX] Fix problem with stepping up from a leaf function when unwinding started in a signal handler.

Addressed comments.

  • add code to handle the case where a function does not store the back chain (stores_bc is 0)
  • swap the order of getting sigcontext from a signal trampoline frame, now trying stack + STKMINALIGN first and then stack + STKMIN
  • remove the condition check when restoring the SP
  • add the test case for the case where a function does not store the back chain
Aug 30 2023, 11:11 AM · Restricted Project, Restricted Project, Restricted Project

Aug 25 2023

xingxue added inline comments to D158655: [libunwind][AIX] Fix problem with stepping up from a leaf function when unwinding started in a signal handler.
Aug 25 2023, 1:30 PM · Restricted Project, Restricted Project, Restricted Project
xingxue added inline comments to D158655: [libunwind][AIX] Fix problem with stepping up from a leaf function when unwinding started in a signal handler.
Aug 25 2023, 1:22 PM · Restricted Project, Restricted Project, Restricted Project
xingxue added inline comments to D158655: [libunwind][AIX] Fix problem with stepping up from a leaf function when unwinding started in a signal handler.
Aug 25 2023, 10:56 AM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D158655: [libunwind][AIX] Fix problem with stepping up from a leaf function when unwinding started in a signal handler.

Addressed comments:

  • removed mentioning of buying stack frame in a code comment
  • added if (!lastStack) and under the condition, set returnAddress to NULL
  • removed condition TBTable->tb.saves_lr || !lastStack when restoring SP
  • added code to initialize the LR value in context to 0
Aug 25 2023, 10:56 AM · Restricted Project, Restricted Project, Restricted Project

Aug 24 2023

xingxue added inline comments to D158655: [libunwind][AIX] Fix problem with stepping up from a leaf function when unwinding started in a signal handler.
Aug 24 2023, 4:20 AM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D158655: [libunwind][AIX] Fix problem with stepping up from a leaf function when unwinding started in a signal handler.

Addressed a comment:

  • fix the comment - not all branches change LR.
Aug 24 2023, 4:18 AM · Restricted Project, Restricted Project, Restricted Project

Aug 23 2023

xingxue updated the summary of D158655: [libunwind][AIX] Fix problem with stepping up from a leaf function when unwinding started in a signal handler.
Aug 23 2023, 12:39 PM · Restricted Project, Restricted Project, Restricted Project
xingxue requested review of D158655: [libunwind][AIX] Fix problem with stepping up from a leaf function when unwinding started in a signal handler.
Aug 23 2023, 11:49 AM · Restricted Project, Restricted Project, Restricted Project

Aug 21 2023

xingxue added a comment to D158011: Make _LIBUNWIND_SUPPORT_FRAME_APIS not conditional on target architecure..

GCC uses __register_frame_info and friends on platforms where the eh_frame_hdr/eh_frame sections are not supported such as AIX. But we can turn the macro on if GCC compat is needed on those OSs.

Aug 21 2023, 3:30 PM · Restricted Project, Restricted Project, Restricted Project

May 16 2023

xingxue accepted D89049: [AIX][XCOFF] print out the traceback info .

Thanks for working on this feature! LGTM once CI is fixed, which is a clang-format issue.

May 16 2023, 1:53 PM · Restricted Project, Restricted Project

May 3 2023

xingxue added inline comments to D89049: [AIX][XCOFF] print out the traceback info .
May 3 2023, 8:22 AM · Restricted Project, Restricted Project

May 1 2023

xingxue added inline comments to D89049: [AIX][XCOFF] print out the traceback info .
May 1 2023, 12:36 PM · Restricted Project, Restricted Project

Feb 15 2023

xingxue committed rGb413b84a704e: [libc++abi][AIX] Skip non-C++ EH aware frames when retrieving exception object (authored by xingxue).
[libc++abi][AIX] Skip non-C++ EH aware frames when retrieving exception object
Feb 15 2023, 8:15 AM · Restricted Project
xingxue closed D143010: [libc++abi][AIX] Skip non-C++ EH aware frames when retrieving exception object.
Feb 15 2023, 8:15 AM · Restricted Project, Restricted Project, Restricted Project

Feb 14 2023

xingxue added a comment to D143010: [libc++abi][AIX] Skip non-C++ EH aware frames when retrieving exception object.

This patch is specific to the support for AIX legacy xlclang++ compiler generated code. It has been reviewed and approved by AIX compiler/runtime experts. If there are no objections, I will commit it tomorrow.

Feb 14 2023, 12:11 PM · Restricted Project, Restricted Project, Restricted Project

Feb 2 2023

xingxue updated the diff for D143010: [libc++abi][AIX] Skip non-C++ EH aware frames when retrieving exception object.

Diff with context.

Feb 2 2023, 9:17 AM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D143010: [libc++abi][AIX] Skip non-C++ EH aware frames when retrieving exception object.

Addressed comment:

  • Call abort() instead of std::abort().
Feb 2 2023, 9:07 AM · Restricted Project, Restricted Project, Restricted Project
xingxue added inline comments to D143010: [libc++abi][AIX] Skip non-C++ EH aware frames when retrieving exception object.
Feb 2 2023, 9:05 AM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D143010: [libc++abi][AIX] Skip non-C++ EH aware frames when retrieving exception object.

Changed function name from skipNonCxxEHAwareFrames to skip_non_cxx_eh_aware_frames to be consistent with function naming in snake_case in this file.

Feb 2 2023, 8:22 AM · Restricted Project, Restricted Project, Restricted Project
xingxue added inline comments to D143010: [libc++abi][AIX] Skip non-C++ EH aware frames when retrieving exception object.
Feb 2 2023, 6:35 AM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D143010: [libc++abi][AIX] Skip non-C++ EH aware frames when retrieving exception object.

Addressed comments:

  • changed a comment as suggested to be more descriptive
  • fixed the text of a trace print
Feb 2 2023, 6:34 AM · Restricted Project, Restricted Project, Restricted Project

Feb 1 2023

xingxue added a comment to D143010: [libc++abi][AIX] Skip non-C++ EH aware frames when retrieving exception object.

I made changes to the patch description (which I expect we will be using for the commit message).

Feb 1 2023, 4:31 PM · Restricted Project, Restricted Project, Restricted Project
xingxue added inline comments to D143010: [libc++abi][AIX] Skip non-C++ EH aware frames when retrieving exception object.
Feb 1 2023, 1:26 PM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D143010: [libc++abi][AIX] Skip non-C++ EH aware frames when retrieving exception object.

Addressed comments:

  • removed an unnecessary cast
  • call std::abort() instead of std::terminate() when unwinding reaches the end of stack frames
  • update callerStack instead of using another variable callerStack2
  • added missing reference to t2.cpp source in the 32-bit test case
Feb 1 2023, 1:17 PM · Restricted Project, Restricted Project, Restricted Project
xingxue added inline comments to D143010: [libc++abi][AIX] Skip non-C++ EH aware frames when retrieving exception object.
Feb 1 2023, 1:13 PM · Restricted Project, Restricted Project, Restricted Project

Jan 31 2023

xingxue requested review of D143010: [libc++abi][AIX] Skip non-C++ EH aware frames when retrieving exception object.
Jan 31 2023, 1:25 PM · Restricted Project, Restricted Project, Restricted Project

Jan 19 2023

xingxue committed rGb05fa4faf64d: [clang][driver][AIX] Add OpenMP runtime if -fopenmp specified (authored by xingxue).
[clang][driver][AIX] Add OpenMP runtime if -fopenmp specified
Jan 19 2023, 9:48 AM · Restricted Project, Restricted Project
xingxue closed D141862: [clang][driver][AIX] Add OpenMP runtime if -fopenmp specified.
Jan 19 2023, 9:47 AM · Restricted Project, Restricted Project, Restricted Project
xingxue added inline comments to D141862: [clang][driver][AIX] Add OpenMP runtime if -fopenmp specified.
Jan 19 2023, 9:31 AM · Restricted Project, Restricted Project, Restricted Project

Jan 18 2023

xingxue updated the diff for D141862: [clang][driver][AIX] Add OpenMP runtime if -fopenmp specified.

Addressed comments.

  • added test scenarios for option fopenmp in clang/test/Driver/aix-ld.c
Jan 18 2023, 8:01 AM · Restricted Project, Restricted Project, Restricted Project

Jan 16 2023

xingxue requested review of D141862: [clang][driver][AIX] Add OpenMP runtime if -fopenmp specified.
Jan 16 2023, 9:24 AM · Restricted Project, Restricted Project, Restricted Project

Jan 9 2023

xingxue accepted D137599: [libunwind][PowerPC] Fix saving/restoring VSX registers on LE systems.

LGTM; thanks!

Jan 9 2023, 12:12 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Dec 15 2022

xingxue added a comment to D139368: [libunwind] Use .irp directives. NFC.

This broke the AIX CI: https://buildkite.com/llvm-project/libcxx-ci/builds/15656#0184eac6-521b-4d1e-8502-c226673e0ece. Unfortunately it seems the .irp directive isn't supported by the AIX assembler.

What chunks of code do AIX use? All __powerpc__ and __powerpc64__ with all variants including __VSX__?

Dec 15 2022, 8:29 AM · Restricted Project, Restricted Project, Restricted Project

Nov 29 2022

xingxue committed rG1e3e3e28a624: [libc++abi][LIT][AIX] Use Vector instructions available on Power7 in… (authored by xingxue).
[libc++abi][LIT][AIX] Use Vector instructions available on Power7 in…
Nov 29 2022, 11:09 AM · Restricted Project
xingxue closed D138667: [libc++abi][LIT][AIX] Use Vector instructions available on Power7 in vec_reg_restore.pass.cpp.
Nov 29 2022, 11:09 AM · Restricted Project, Restricted Project, Restricted Project

Nov 25 2022

xingxue added inline comments to D138667: [libc++abi][LIT][AIX] Use Vector instructions available on Power7 in vec_reg_restore.pass.cpp.
Nov 25 2022, 10:47 AM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D138667: [libc++abi][LIT][AIX] Use Vector instructions available on Power7 in vec_reg_restore.pass.cpp.

Addressed comments:

  • use instruction vspltisb to initialize RS63, RS62
  • set RS63, RS62 to 16 bytes each with value 0x01 and 0x02 respectively
  • compare RS63/RS62 against expected values using instruction vcmpequb
Nov 25 2022, 10:43 AM · Restricted Project, Restricted Project, Restricted Project

Nov 24 2022

xingxue added a comment to D138667: [libc++abi][LIT][AIX] Use Vector instructions available on Power7 in vec_reg_restore.pass.cpp.

Getting libc++ out of the way. If it looks good to AIX folks, feel free to ship it.

Thanks!

Nov 24 2022, 11:00 AM · Restricted Project, Restricted Project, Restricted Project
xingxue added inline comments to D136393: [libc++][math.h] Use builtins for all the functions.
Nov 24 2022, 8:16 AM · Restricted Project, Restricted Project
xingxue requested review of D138667: [libc++abi][LIT][AIX] Use Vector instructions available on Power7 in vec_reg_restore.pass.cpp.
Nov 24 2022, 6:43 AM · Restricted Project, Restricted Project, Restricted Project

Nov 21 2022

xingxue added reviewers for D137599: [libunwind][PowerPC] Fix saving/restoring VSX registers on LE systems: MaskRay, compnerd.
Nov 21 2022, 9:14 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
xingxue added a comment to D137599: [libunwind][PowerPC] Fix saving/restoring VSX registers on LE systems.

The compiler generated prologue/epilogue uses instructions stvx/lvx to save/restore vector registers onto/from the stack. On the other hand, libunwind currently uses stxvd2x/lxvd2x to save/restore VSX vector to/from unwinder's context. Since stxvd2x/lxvd2x stores/loads VSX vector as 2 double words into/from memory, these instructions essentially change the byte orders of the contents if the machine is in little-endian mode. As a result, VSX vectors saved by prologues are not correctly represented in the unwinder context. PowerPC ISA 3.0 (Power9) has added instructions stxv/lxv that stores/loads VSX vectors and matches the behavior of stvx/lvx. Unfortunately, since supporting of older PowerPCs such as Power8 and earlier are still needed, we cannot replace stxvd2x/lxvd2x with stxv/lxv yet. Checking if the build system has the GLIBC facility for detecting the CPU architecture, and detecting at run time and going a different path add a lot of complicity to the code base. IMHO, we can simply add instruction xxswapd to before stxvd2x and after lxvd2x for little-endian like in your patch as a workaround for now. xxswapd is not an expensive instruction so it is unlikely to affect the performance in a significant way, noting that saving and restoring context are only executed when raising an exception and jumping to the landing pad. It will be good though to have a comment stating that we should replace them with stxv/lxv once only Power9 and higher are supported for little-endian PowerPC (RHEL 9.0 already supports minimum Power9). Thanks very much for working on this issue!

Nov 21 2022, 9:13 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 18 2022

xingxue added a comment to D136770: [libc++abi][CMake] Handle build type RelWithDebInfo or MinSizeRel configuration similarly to Release.

@ldionne, can you please take a look for #libc_abi? Thanks!

Nov 18 2022, 9:26 AM · Restricted Project, Restricted Project, Restricted Project
xingxue committed rGfa7477eb87fd: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and… (authored by xingxue).
[Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and…
Nov 18 2022, 8:38 AM · Restricted Project, Restricted Project
xingxue closed D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode.
Nov 18 2022, 8:37 AM · Restricted Project, Restricted Project, Restricted Project

Nov 16 2022

xingxue added inline comments to D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode.
Nov 16 2022, 10:46 AM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode.

Addressed comments:

  • rename AIXLongDoubleBuiltins to AIXLongDouble64Builtins
  • test IR output instead of assembly output
  • fix a typo in a comment
  • mention frexpl(), ldexpl(), and modfl() are for 128-bit IBM long double, i.e. __ibm128
Nov 16 2022, 9:52 AM · Restricted Project, Restricted Project, Restricted Project

Nov 14 2022

xingxue added inline comments to D136393: [libc++][math.h] Use builtins for all the functions.
Nov 14 2022, 2:56 PM · Restricted Project, Restricted Project
xingxue requested review of D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode.
Nov 14 2022, 2:32 PM · Restricted Project, Restricted Project, Restricted Project

Nov 10 2022

xingxue added inline comments to D136393: [libc++][math.h] Use builtins for all the functions.
Nov 10 2022, 8:32 AM · Restricted Project, Restricted Project

Oct 27 2022

xingxue added a comment to D136257: [libc++abi][AIX] Use reserved slot in stack to pass the address of exception object.

Thanks, @ldionne!

Oct 27 2022, 2:43 PM · Restricted Project, Restricted Project, Restricted Project
xingxue added a comment to D136257: [libc++abi][AIX] Use reserved slot in stack to pass the address of exception object.

This patch is AIX specific and it has been thoroughly reviewed and approved by AIX compiler experts @hubert.reinterpretcast, @cebowleratibm (Thank you!). Since we need to have the patch in the coming service pack, I've committed it in rGa499051f10a2d0150b60c14493558476039f701a. Commit rGfb391e45e9cc35429f077413ca660f4f5f5212c1 modified a comment.

Oct 27 2022, 2:12 PM · Restricted Project, Restricted Project, Restricted Project
xingxue committed rGfb391e45e9cc: [libc++abi][AIX] Use reserved slot in stack to pass the address of exception… (authored by xingxue).
[libc++abi][AIX] Use reserved slot in stack to pass the address of exception…
Oct 27 2022, 2:07 PM · Restricted Project
xingxue closed D136257: [libc++abi][AIX] Use reserved slot in stack to pass the address of exception object.
Oct 27 2022, 2:07 PM · Restricted Project, Restricted Project, Restricted Project
xingxue committed rGa499051f10a2: [libc++abi][AIX] Use reserved slot in stack to pass the address of exception… (authored by xingxue).
[libc++abi][AIX] Use reserved slot in stack to pass the address of exception…
Oct 27 2022, 12:12 PM · Restricted Project

Oct 26 2022

xingxue added a comment to D136770: [libc++abi][CMake] Handle build type RelWithDebInfo or MinSizeRel configuration similarly to Release.

[libc++abi][CMake] Handle build type RelWithDebInfo configuration similarly to Release

Mention MINSIZEREL as well.

From reading https://github.com/Kitware/CMake/blob/master/Modules/Compiler/GNU.cmake#L58 , I think this makes sense.

Oct 26 2022, 3:05 PM · Restricted Project, Restricted Project, Restricted Project
xingxue retitled D136770: [libc++abi][CMake] Handle build type RelWithDebInfo or MinSizeRel configuration similarly to Release from [libc++abi][CMake] Handle build type RelWithDebInfo configuration similarly to Release to [libc++abi][CMake] Handle build type RelWithDebInfo or MinSizeRel configuration similarly to Release.
Oct 26 2022, 3:03 PM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D136770: [libc++abi][CMake] Handle build type RelWithDebInfo or MinSizeRel configuration similarly to Release.

Refreshed the patch with context.

Oct 26 2022, 11:42 AM · Restricted Project, Restricted Project, Restricted Project
xingxue requested review of D136770: [libc++abi][CMake] Handle build type RelWithDebInfo or MinSizeRel configuration similarly to Release.
Oct 26 2022, 9:02 AM · Restricted Project, Restricted Project, Restricted Project

Oct 21 2022

xingxue added inline comments to D136257: [libc++abi][AIX] Use reserved slot in stack to pass the address of exception object.
Oct 21 2022, 12:54 PM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D136257: [libc++abi][AIX] Use reserved slot in stack to pass the address of exception object.

Changes in the update:

  • addressed comment: rename dummy() to force_a_stackframe();
  • added attribute optnone to force_a_stackframe();
  • use assembly for IBM legacy compiler xlclang++ generated test cases instead of binary object files.
Oct 21 2022, 12:53 PM · Restricted Project, Restricted Project, Restricted Project

Oct 20 2022

xingxue updated the diff for D136257: [libc++abi][AIX] Use reserved slot in stack to pass the address of exception object.

Updated diff to include binary files.

Oct 20 2022, 6:59 AM · Restricted Project, Restricted Project, Restricted Project

Oct 19 2022

xingxue updated the summary of D136257: [libc++abi][AIX] Use reserved slot in stack to pass the address of exception object.
Oct 19 2022, 8:49 AM · Restricted Project, Restricted Project, Restricted Project
xingxue requested review of D136257: [libc++abi][AIX] Use reserved slot in stack to pass the address of exception object.
Oct 19 2022, 7:23 AM · Restricted Project, Restricted Project, Restricted Project

Sep 16 2022

xingxue committed rG8ace9ea258c9: [libc++][lit][AIX] Enable test case last_write_time.pass.cpp for AIX (authored by xingxue).
[libc++][lit][AIX] Enable test case last_write_time.pass.cpp for AIX
Sep 16 2022, 1:10 PM · Restricted Project, Restricted Project
xingxue closed D133124: [libc++][lit][AIX] Enable test case last_write_time.pass.cpp for AIX.
Sep 16 2022, 1:09 PM · Restricted Project, Restricted Project, Restricted Project
xingxue added inline comments to D133124: [libc++][lit][AIX] Enable test case last_write_time.pass.cpp for AIX.
Sep 16 2022, 12:26 PM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D133124: [libc++][lit][AIX] Enable test case last_write_time.pass.cpp for AIX.

Addressed comments:

  • always define before_epoch_time & friends to reduce the scope of the workaround.
Sep 16 2022, 12:23 PM · Restricted Project, Restricted Project, Restricted Project

Sep 9 2022

xingxue added inline comments to D133124: [libc++][lit][AIX] Enable test case last_write_time.pass.cpp for AIX.
Sep 9 2022, 7:40 AM · Restricted Project, Restricted Project, Restricted Project

Sep 8 2022

xingxue added a reviewer for D133124: [libc++][lit][AIX] Enable test case last_write_time.pass.cpp for AIX: EricWF.
Sep 8 2022, 2:25 PM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the summary of D133124: [libc++][lit][AIX] Enable test case last_write_time.pass.cpp for AIX.
Sep 8 2022, 2:16 PM · Restricted Project, Restricted Project, Restricted Project

Sep 1 2022

xingxue requested review of D133124: [libc++][lit][AIX] Enable test case last_write_time.pass.cpp for AIX.
Sep 1 2022, 10:17 AM · Restricted Project, Restricted Project, Restricted Project

Aug 12 2022

xingxue added inline comments to D131709: [libunwind][AIX] Implement _Unwind_FindEnclosingFunction() using traceback table on AIX.
Aug 12 2022, 3:13 PM · Restricted Project, Restricted Project, Restricted Project
xingxue committed rG2366c6adfc95: [libunwind][AIX] Implement _Unwind_FindEnclosingFunction() using traceback… (authored by xingxue).
[libunwind][AIX] Implement _Unwind_FindEnclosingFunction() using traceback…
Aug 12 2022, 3:09 PM · Restricted Project
xingxue closed D131709: [libunwind][AIX] Implement _Unwind_FindEnclosingFunction() using traceback table on AIX.
Aug 12 2022, 3:09 PM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the summary of D131709: [libunwind][AIX] Implement _Unwind_FindEnclosingFunction() using traceback table on AIX.
Aug 12 2022, 11:24 AM · Restricted Project, Restricted Project, Restricted Project
xingxue added inline comments to D131709: [libunwind][AIX] Implement _Unwind_FindEnclosingFunction() using traceback table on AIX.
Aug 12 2022, 10:50 AM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D131709: [libunwind][AIX] Implement _Unwind_FindEnclosingFunction() using traceback table on AIX.

Addressed comment.

  • _Unwind_FindEnclosingFunction() returns NULL if argument pc is NULL;
  • dropped else for returning NULL as suggested.
Aug 12 2022, 10:31 AM · Restricted Project, Restricted Project, Restricted Project
xingxue added a comment to D130283: [libc++] Allow assigning std::rethrow_if_nested() to a function pointer.

Hi @ldionne, What do you think about this? The affected test case works with GCC.

Aug 12 2022, 7:21 AM · Restricted Project, Restricted Project, Restricted Project
xingxue added a comment to D129229: [libc++] reference_wrapper does not define nested types as described in C++11/14.

Gentle ping.

Aug 12 2022, 6:58 AM · Restricted Project, Restricted Project, Restricted Project

Aug 11 2022

xingxue requested review of D131709: [libunwind][AIX] Implement _Unwind_FindEnclosingFunction() using traceback table on AIX.
Aug 11 2022, 12:03 PM · Restricted Project, Restricted Project, Restricted Project

Aug 8 2022

xingxue committed rGcc8edbea7a5f: [libunwind][AIX] Save/restore errno before/after system calls… (authored by xingxue).
[libunwind][AIX] Save/restore errno before/after system calls…
Aug 8 2022, 2:22 PM · Restricted Project
xingxue closed D131292: [libunwind][AIX] Save/restore errno before/after system calls dlopen/dlsym/dlclose.
Aug 8 2022, 2:22 PM · Restricted Project, Restricted Project, Restricted Project
xingxue updated the diff for D131292: [libunwind][AIX] Save/restore errno before/after system calls dlopen/dlsym/dlclose.

I'm not opposed to the change, but I wonder if we should consider placing this in an #if defined(_AIX) guard. This would avoid touching errno on other platforms, which would likely > be a TLS access. It would also make it more obvious that this is a workaround for AIX. At the very least, I think that we should add some comments to explain the issue so that it is > obvious at the site rather than having to go through the change log.

Aug 8 2022, 10:05 AM · Restricted Project, Restricted Project, Restricted Project

Aug 5 2022

xingxue updated the summary of D131292: [libunwind][AIX] Save/restore errno before/after system calls dlopen/dlsym/dlclose.
Aug 5 2022, 3:11 PM · Restricted Project, Restricted Project, Restricted Project