User Details
- User Since
- Feb 14 2019, 10:47 AM (101 w, 4 d)
Apr 15 2020
Apr 13 2020
Addressed comments:
- Added a comment as suggested.
Addressed comments:
- Leave the existing handling of type code g unchanged as suggested.
Feb 25 2020
Revision no longer needed now that the GO binding test code has been reverted. Thanks!
Addressed comments:
I'm still wondering about Intel. Can there ever be a literal encoded using 'g' on Intel? If yes, then treating it as "long double" would still be wrong, because 'g' encodes IEEE128 (__float128), while "long double" is the Intel extended (80-bit) format, right?
On the other hand, if 'g' encoded literals can never happen on Intel (or other platforms), maybe it would be better to have the code handling 'g' within a #ifdef section only active on powerpc and s390?
For X86, 'e' is used for 80-bit long double and 'g' is used for 128-bit long double. The following is the code in Clang.
clang/lib/Basic/Targets/X86.h .... const char *getLongDoubleMangling() const override { return LongDoubleFormat == &llvm::APFloat::IEEEquad() ? "g" : "e"; } ...
Feb 24 2020
Hi @uweigand, Thanks for your comments. Please see my explanations below.
Feb 21 2020
@uweigand, Hi, I've addressed your comments. Any further comments?
Feb 13 2020
LGTM.
Feb 7 2020
Addressed comments:
Feb 6 2020
Nov 20 2019
Nov 15 2019
Nov 8 2019
Test file aix-xcoff-data.ll needs a rebase.
Oct 28 2019
LGTM.
Oct 25 2019
Revised based on changes in patch https://reviews.llvm.org/D69112.
Oct 2 2019
Addressed comments:
- Changed variable name CSection -> Csect;
- Added the checking of section headers in the object file.
Sep 30 2019
Sep 20 2019
Sep 11 2019
Changed from Data to Data.Index.
Sep 9 2019
Addressed comments:
- use csects in comment.
- use section storage class from CSection.
- set the section start address as the address after the previous section.
Sep 3 2019
Aug 30 2019
Aug 27 2019
Aug 26 2019
This patch needs a rebase.
Aug 25 2019
Merged with the master and fixed a typo.
Aug 22 2019
Addressed comments:
Addressed comments:
Aug 21 2019
Aug 19 2019
Aug 15 2019
LGTM.
Aug 13 2019
Aug 12 2019
LGTM.
Jun 26 2019
Jun 25 2019
Jun 24 2019
LGTM.
malloc(0) can be used to allocate a zero-sized object. To avoid having a null pointer to the zero-sized object, implementations often change to allocate 1 byte instead. So this patch makes sense to me.
Jun 20 2019
Jun 19 2019
Thanks to Marshall for committing the patch. Closing this revision.
Jun 11 2019
Hi @mclow.lists, Do you have any further comments?
Hi @mclow.lists, Do you have any further comments?
Jun 10 2019
LGTM.
Jun 6 2019
Thanks Marshall and Hubert for your comments!
Addressed comments:
- Skip the test of midpoint of adjacent values for PPC double-double based on compile-time checking;
- Use #if defined(__PPC__) instead of #if __PPC__ ;
- Removed output to std::cerr.
Jun 3 2019
Addressed comments:
- Fixed typo _XOPEN_SOUECE->_XOPEN_SOURCE
May 28 2019
Updated comments explaining the scenario of the changes.
May 27 2019
May 24 2019
May 23 2019
Added test case stdint_h.sh.cpp.
May 22 2019
LGTM.
May 16 2019
May 14 2019
May 6 2019
Apr 29 2019
Apr 26 2019
@hubert.reinterpretcast, @dberris, thanks for the review! I will commit once I get the permission.
Apr 23 2019
Apr 11 2019
LGTM.