Page MenuHomePhabricator
Differential D143494

[RFC][libc++]] Adds _LIBCPP_HIDE_FROM_ABI_TYPE.
DraftPublic
Actions

Authored by Mordante on Feb 7 2023, 6:04 AM.
This is a draft revision that has not yet been submitted for review.

Details

Reviewers
ldionne
Summary

As discussed in D136775.

Diff Detail

Unit TestsFailed
View All

TimeTest
1,500,090 mslibcxx CI Apple back-deployment macosx11.0 arm64 > apple-libc++-backdeployment-cfg-in.std/thread/thread_condition::notify_all_at_thread_exit_lwg3343.pass.cpp
Script: -- : 'COMPILED WITH'; /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/w4-4macminivaultcom-local/llvm-project/libcxx-ci/libcxx/test/std/thread/thread.condition/notify_all_at_thread_exit_lwg3343.pass.cpp -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk --target=arm64-apple-macosx11.0 -nostdinc++ -I /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/w4-4macminivaultcom-local/llvm-project/libcxx-ci/build/apple-system-backdeployment-11.0/include/c++/v1 -I /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/w4-4macminivaultcom-local/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -Werror=thread-safety -Wuser-defined-warnings -nostdlib++ -L /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/w4-4macminivaultcom-local/llvm-project/libcxx-ci/build/apple-system-backdeployment-11.0/lib -lc++ -o /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/w4-4macminivaultcom-local/llvm-project/libcxx-ci/build/apple-system-backdeployment-11.0/test/std/thread/thread.condition/Output/notify_all_at_thread_exit_lwg3343.pass.cpp.dir/t.tmp.exe

Event Timeline

Mordante created this revision.Feb 7 2023, 6:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 7 2023, 6:04 AM
Mordante added inline comments.Feb 7 2023, 6:08 AM
libcxx/include/__format/parser_std_format_spec.h
126

I think it would be good to document what should and what should not be hidden from the ABI.
For example should this implementation field use an ABI tag or not.
Then we probably should update https://libcxx.llvm.org/DesignDocs/VisibilityMacros.html too and if possible have some more clang-tidy validations.

Harbormaster completed remote builds in B212366: Diff 495499.Feb 7 2023, 8:28 AM

Revision Contents
Changeset List

PathSize
libcxx/
include/
4 lines
__format/
3 lines

Diff 495499

View Options

libcxx/include/__config

Loading...
View Options

libcxx/include/__format/parser_std_format_spec.h

Loading...