This is an archive of the discontinued LLVM Phabricator instance.

[nfc][codegen] Move RegisterBank[Info].h under CodeGen
ClosedPublic

Authored by mtrofin on Feb 15 2022, 11:58 AM.

Details

Summary

This wraps up from D119053. The 2 headers are moved as described,
fixed file headers and include guards, updated all files where the old
paths were detected (simple grep through the repo), and clang-format-ed it all.

Diff Detail

Event Timeline

mtrofin created this revision.Feb 15 2022, 11:58 AM
mtrofin requested review of this revision.Feb 15 2022, 11:58 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 15 2022, 11:58 AM
mtrofin added inline comments.Feb 15 2022, 12:01 PM
llvm/include/llvm/CodeGen/RegisterBankInfo.h
220

ah - clang-format handled the moved file as a new file; but I'd say let's let it make these changes, they are goodness anyway (and small)

As this is a follow-up of a refactoring, I assume I can just land it (short of file header comments, there was nothing really this patch did more intelligently)

myhsu accepted this revision.Mar 1 2022, 9:25 AM
myhsu added a subscriber: myhsu.

since D119053 was accepted, I don't see any reason why this patch shouldn't be :-)

This revision is now accepted and ready to land.Mar 1 2022, 9:25 AM
myhsu added inline comments.Mar 1 2022, 9:28 AM
llvm/lib/Target/ARM/ARMTargetMachine.cpp
43

Hmm...did you use clang-format-diff.py? I wonder why this was changed (although it's a legit one)

mtrofin marked an inline comment as done.Mar 1 2022, 10:40 AM
mtrofin added inline comments.
llvm/lib/Target/ARM/ARMTargetMachine.cpp
43

did git clang-format, and since that had to re-sort the includes due to my change, it affected incorrectly placed lines.

This revision was landed with ongoing or failed builds.Mar 1 2022, 9:53 PM
This revision was automatically updated to reflect the committed changes.
mtrofin marked an inline comment as done.
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2022, 9:53 PM