This patch completely removes the old OpenMP device runtime. Previously,
the old runtime had the prefix libomptarget-new- and the old runtime
was simply called libomptarget-. This patch makes the formerly new
runtime the only runtime available. The entire project has been deleted,
and all references to the libomptarget-new runtime has been replaced
with libomptarget-.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang/include/clang/Driver/Options.td | ||
---|---|---|
2470 ↗ | (On Diff #405731) | Since LLVM 14 has this flags, we probably want to keep this argument, mark it as deprecated, and emit a warning saying there is no old runtime anymore. |
I've read this closely and can't think of anywhere else that needs to be patched. Thanks!
clang/include/clang/Driver/Options.td | ||
---|---|---|
2470 ↗ | (On Diff #405731) | What's LLVM's policy on deprecating flags? I would prefer to remove it but keeping it as a no-op would be fine. |
clang/include/clang/Driver/Options.td | ||
---|---|---|
2470 ↗ | (On Diff #405731) | Or port this to 14 |
Fixing some duplicate lit lines and keeping the flag. Whenever it's used a
warning will tell the user it was unused because it's not implemented anywhere.
If this patch can be back ported to 14, then it's totally fine to remove the argument. Otherwise keeping it sounds more reasonable. If we keep it, we'd better to emit a warning and then we could remove it in 15 or other version w/o any concern that we don't tell users this flag is deprecated.