This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Completely remove old device runtime
ClosedPublic

Authored by jhuber6 on Feb 3 2022, 11:46 AM.

Details

Summary

This patch completely removes the old OpenMP device runtime. Previously,
the old runtime had the prefix libomptarget-new- and the old runtime
was simply called libomptarget-. This patch makes the formerly new
runtime the only runtime available. The entire project has been deleted,
and all references to the libomptarget-new runtime has been replaced
with libomptarget-.

Diff Detail

Event Timeline

jhuber6 created this revision.Feb 3 2022, 11:46 AM
jhuber6 requested review of this revision.Feb 3 2022, 11:46 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 3 2022, 11:46 AM
jhuber6 updated this revision to Diff 405731.Feb 3 2022, 11:50 AM

Clang format

tianshilei1992 added inline comments.Feb 3 2022, 11:54 AM
clang/include/clang/Driver/Options.td
2470

Since LLVM 14 has this flags, we probably want to keep this argument, mark it as deprecated, and emit a warning saying there is no old runtime anymore.

JonChesterfield accepted this revision.Feb 3 2022, 11:56 AM

I've read this closely and can't think of anywhere else that needs to be patched. Thanks!

This revision is now accepted and ready to land.Feb 3 2022, 11:56 AM
JonChesterfield edited the summary of this revision. (Show Details)Feb 3 2022, 11:56 AM
jhuber6 added inline comments.Feb 3 2022, 11:58 AM
clang/include/clang/Driver/Options.td
2470

What's LLVM's policy on deprecating flags? I would prefer to remove it but keeping it as a no-op would be fine.

clang/include/clang/Driver/Options.td
2470

Or port this to 14

jhuber6 updated this revision to Diff 405737.Feb 3 2022, 12:04 PM

Fixing some duplicate lit lines and keeping the flag. Whenever it's used a
warning will tell the user it was unused because it's not implemented anywhere.

If this patch can be back ported to 14, then it's totally fine to remove the argument. Otherwise keeping it sounds more reasonable. If we keep it, we'd better to emit a warning and then we could remove it in 15 or other version w/o any concern that we don't tell users this flag is deprecated.

Don't backport. Deprecate the flag and that's fine.

This revision was landed with ongoing or failed builds.Feb 4 2022, 12:31 PM
This revision was automatically updated to reflect the committed changes.
openmp/libomptarget/deviceRTLs/nvptx/test/parallel/spmd_parallel_regions.cpp