This is an archive of the discontinued LLVM Phabricator instance.

[mlir][vector][NFC] Split into IR, Transforms and Utils
ClosedPublic

Authored by springerm on Jan 29 2022, 3:13 AM.

Details

Summary

This reduces the dependencies of the MLIRVector target and makes the dialect consistent with other dialects.

Diff Detail

Event Timeline

springerm created this revision.Jan 29 2022, 3:13 AM
springerm requested review of this revision.Jan 29 2022, 3:13 AM
bondhugula added inline comments.Jan 29 2022, 6:30 AM
mlir/lib/Dialect/Vector/IR/CMakeLists.txt
4

Normally, utils isn't part of the dialect AFAIK and I think not nested in IR/. Check other dialects for consistency.

mlir/lib/Dialect/Vector/Utils/VectorUtils.cpp
13–20

Please leave a blank line after the first (main) include.

springerm updated this revision to Diff 404267.Jan 29 2022, 7:41 AM

address comments

springerm marked 2 inline comments as done.Jan 29 2022, 7:44 AM
springerm added inline comments.
mlir/lib/Dialect/Vector/IR/CMakeLists.txt
4

Done. I moved some functions VectorOps.cpp or to a new build target IndexUtils.cpp due to circular dependencies.

springerm retitled this revision from [mlir][vector] Split into IR and Transforms to [mlir][vector] Split into IR, Transforms and Utils.Jan 29 2022, 7:45 AM
springerm marked an inline comment as done.

update

springerm retitled this revision from [mlir][vector] Split into IR, Transforms and Utils to [mlir][vector][NFC] Split into IR, Transforms and Utils.Jan 29 2022, 10:52 AM
ftynse accepted this revision.Jan 31 2022, 1:36 AM
This revision is now accepted and ready to land.Jan 31 2022, 1:36 AM
nicolasvasilache accepted this revision.Jan 31 2022, 1:41 AM

Thanks!

mlir/include/mlir/Dialect/Utils/IndexUtils.h
2

Can you please rename to IndexingUtils before landing?
IndexUtils seems like they would be related to the index type, this is not the case here.

This revision was automatically updated to reflect the committed changes.
springerm marked an inline comment as done.
mlir/include/mlir/Dialect/Vector/IR/VectorOps.h