This reduces the dependencies of the MLIRVector target and makes the dialect consistent with other dialects.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/lib/Dialect/Vector/IR/CMakeLists.txt | ||
---|---|---|
4 | Done. I moved some functions VectorOps.cpp or to a new build target IndexUtils.cpp due to circular dependencies. |
Comment Actions
Thanks!
mlir/include/mlir/Dialect/Utils/IndexUtils.h | ||
---|---|---|
1 ↗ | (On Diff #404290) | Can you please rename to IndexingUtils before landing? |
Normally, utils isn't part of the dialect AFAIK and I think not nested in IR/. Check other dialects for consistency.