Paths

Table of Contentst

Differential D118210

[mlir][ods] Attribute and type formats: support whitespaces
ClosedPublic
Actions

Authored by Mogball on Jan 25 2022, 6:48 PM.

Details

Reviewers

mehdi_amini
rriddle

Commits

rG740e8326444d: [mlir][ods] Attribute and type formats: support whitespaces

Summary

Supports whitespace elements: and \\n as well as the "empty" whitespace `` that removes an otherwise printed space.

Depends on D118208

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

Mogball created this revision.Jan 25 2022, 6:48 PM

Herald added subscribers: sdasgup3, wenzhicui, wrengr and 19 others. · View Herald TranscriptJan 25 2022, 6:48 PM

Mogball requested review of this revision.Jan 25 2022, 6:48 PM

Herald added a project: Restricted Project. · View Herald TranscriptJan 25 2022, 6:48 PM

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

Harbormaster completed remote builds in B145656: Diff 403108.Jan 25 2022, 6:49 PM

Mogball added a child revision: D118544: [mlir][ods] Default-valued parameters in attribute or type defs.Jan 29 2022, 3:38 PM

rriddle accepted this revision.Jan 31 2022, 1:13 AM

rriddle added inline comments.

mlir/tools/mlir-tblgen/AttrOrTypeFormatGen.cpp
767–773
768	This should require `$_printer.printNewline()` just like operation formats, though I think that requires me to finish my patch for removing the nested printing awkwardness. Would be good to add a FIXME here that this should be driven by the printer.

This revision is now accepted and ready to land.Jan 31 2022, 1:13 AM

Mogball marked 2 inline comments as done.Jan 31 2022, 9:46 PM

review comments

Harbormaster completed remote builds in B146828: Diff 404820.Jan 31 2022, 11:18 PM

rebase

rebase again

This revision was landed with ongoing or failed builds.Feb 8 2022, 3:27 PM

Closed by commit rG740e8326444d: [mlir][ods] Attribute and type formats: support whitespaces (authored by Mogball). · Explain Why

This revision was automatically updated to reflect the committed changes.

Mogball added a commit: rG740e8326444d: [mlir][ods] Attribute and type formats: support whitespaces.

Harbormaster completed remote builds in B148378: Diff 406996.Feb 8 2022, 6:24 PM

Revision Contents
Changeset List

Path

Size

mlir/

test/

lib/

Dialect/

Test/

TestTypeDefs.td

6 lines

mlir-tblgen/

attr-or-type-format-roundtrip.mlir

5 lines

tools/

mlir-tblgen/

AttrOrTypeFormatGen.cpp

21 lines

Diff 404820

mlir/test/lib/Dialect/Test/TestTypeDefs.td

Loading...

mlir/test/mlir-tblgen/attr-or-type-format-roundtrip.mlir

Loading...

mlir/tools/mlir-tblgen/AttrOrTypeFormatGen.cpp

Loading...