Page MenuHomePhabricator

[RISCV] Remove experimental prefix from rvv-related extensions.
ClosedPublic

Authored by eopXD on Jan 21 2022, 12:40 AM.

Diff Detail

Event Timeline

eopXD created this revision.Jan 21 2022, 12:40 AM
eopXD requested review of this revision.Jan 21 2022, 12:40 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJan 21 2022, 12:40 AM

Thanks for the patch! Not sure the best way to review this. The tests are passing, which is a good sign. One option could be to split the "meaningful" changes into a separate diff for easier viewing? We probably don't need to see all the test RUN line changes, for example.

craig.topper added inline comments.Jan 21 2022, 10:19 AM
llvm/lib/Support/RISCVISAInfo.cpp
430

Drop this? Or wrap it in LLVM_DEBUG

eopXD updated this revision to Diff 402034.Jan 21 2022, 10:25 AM

Cleanup redundant code.

Thanks for the patch! Not sure the best way to review this. The tests are passing, which is a good sign. One option could be to split the "meaningful" changes into a separate diff for easier viewing? We probably don't need to see all the test RUN line changes, for example.

Non-testcase file changes are:

M       clang/utils/TableGen/RISCVVEmitter.cpp
M       llvm/lib/Support/RISCVISAInfo.cpp
M       llvm/lib/Target/RISCV/RISCV.td

Do you mean creating separate this patch into two? Won't that cause build failure?

eopXD updated this revision to Diff 402192.Jan 22 2022, 12:57 AM

Rebase.
Resolve conflict due to addition of zbkc.

This revision is now accepted and ready to land.Jan 22 2022, 1:09 PM
fhahn added a subscriber: fhahn.Mar 3 2022, 1:00 AM

Unfortunately some of the intrinsics tests have grown so large the the consistently hit the 10 minute timeout in the Phabricator precommit tests, e.g. see https://reviews.llvm.org/harbormaster/unit/152224/

Some of those files need to be split up, as those test failures in the pre-commit tests impact everyone.

Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2022, 1:00 AM