Extensions affected: +v, +zve*, +zvl*
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Thanks for the patch! Not sure the best way to review this. The tests are passing, which is a good sign. One option could be to split the "meaningful" changes into a separate diff for easier viewing? We probably don't need to see all the test RUN line changes, for example.
llvm/lib/Support/RISCVISAInfo.cpp | ||
---|---|---|
430 | Drop this? Or wrap it in LLVM_DEBUG |
Comment Actions
Non-testcase file changes are:
M clang/utils/TableGen/RISCVVEmitter.cpp M llvm/lib/Support/RISCVISAInfo.cpp M llvm/lib/Target/RISCV/RISCV.td
Do you mean creating separate this patch into two? Won't that cause build failure?
Comment Actions
Unfortunately some of the intrinsics tests have grown so large the the consistently hit the 10 minute timeout in the Phabricator precommit tests, e.g. see https://reviews.llvm.org/harbormaster/unit/152224/
Some of those files need to be split up, as those test failures in the pre-commit tests impact everyone.