Revert "[ELF] Simplify elf::link exit. NFC"

[fhahn]

Summary

Attempt track down cause for failing libomp tests.

[fhahn]

Try to run all tests

[fhahn]

Not causing the OpenMP failures.

lld/ELF/Driver.cpp

bool elf::link(ArrayRef<const char *> args, bool canExitEarly,
 
   config->progName = args[0];
 
   driver->linkerMain(args);
 
   // Exit immediately if we don't need to return to the caller.
   // This saves time because the overhead of calling destructors
   // for all globally-allocated objects is not negligible.
-  int hasError = errorCount() ? 1 : 0;
   if (canExitEarly)
-    exitLld(hasError);
-  else
+    exitLld(errorCount() ? 1 : 0);
+
+  bool ret = errorCount() == 0;
+  if (!canExitEarly)
     errorHandler().reset();
-  return !hasError;
+  return ret;
 }
 
 // Parses a linker -m option.
 static std::tuple<ELFKind, uint16_t, uint8_t> parseEmulation(StringRef emul) {
   uint8_t osabi = 0;
   StringRef s = emul;
   if (s.endswith("_fbsd")) {
     s = s.drop_back(5);

openmp/libomptarget/test/offloading/bug50022.cpp

#pragma omp task depend(inout : a) shared(a)
     std::cout << "a = " << a << " addr " << &a << std::endl;
     if (a != 2)
       throw std::runtime_error("wrong result!");
     a = 3;
   }
 
 #pragma omp taskwait
 
-  assert(a == 3 && "wrong result!");
+  assert(a == 3 && "wrong result2!");
 
   return 0;
 }