This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Modification of RVV CSR test file
Needs ReviewPublic

Authored by nannan1025 on Dec 28 2021, 6:27 PM.

Download Raw Diff

Details

Reviewers

01169957911
kito-cheng
khchen
monkchiang
Nelson1225

Summary

The RVV CSR test file can be tested successfully without the mattr attribute

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed

	Time	Test
	70 ms	x64 debian > LLVM.Bindings/Go::go.test

Event Timeline

nannan1025 created this revision.Dec 28 2021, 6:27 PM

Herald added subscribers: luke957, frasercrmck, luismarques and 19 others. · View Herald TranscriptDec 28 2021, 6:27 PM

nannan1025 requested review of this revision.Dec 28 2021, 6:27 PM

Herald added a project: Restricted Project. · View Herald TranscriptDec 28 2021, 6:27 PM

Herald added subscribers: llvm-commits, MaskRay. · View Herald Transcript

craig.topper retitled this revision from Modification of RVV CSR test file to [RISCV] Modification of RVV CSR test file.Dec 28 2021, 6:44 PM

Herald added subscribers: VincentWu, achieveartificialintelligence, vkmr and 4 others. · View Herald TranscriptDec 28 2021, 6:44 PM

craig.topper added reviewers: kito-cheng, khchen.Dec 28 2021, 6:45 PM

Harbormaster completed remote builds in B140830: Diff 396450.Dec 28 2021, 7:12 PM

Whether Vector CSRs should be allowed to be accessed when V extensions are not enabled？

I mean, is there a wrong implementation or a wrong test case?

craig.topper added reviewers: monkchiang, Nelson1225.Dec 28 2021, 8:38 PM

In D116350#3212010, @VincentWu wrote:

Whether Vector CSRs should be allowed to be accessed when V extensions are not enabled？

I mean, is there a wrong implementation or a wrong test case?

I found this patch where the F extension check was removed from fcsr, fflags, and frm based on binutils not checking. https://reviews.llvm.org/D58932 But it looks like binutils may have implemented checking after that patch https://sourceware.org/legacy-ml/binutils/2019-12/msg00222.html

But it looks like binutils may have implemented checking after that patch https://sourceware.org/legacy-ml/binutils/2019-12/msg00222.html

Yes, if you enable GNU assembler -mcsr-check option, then you probably will see some CSR warnings for checking the march, rv32-only and read-only. But I forgot why we chosen to report warnings rather than errors...

In D116350#3212017, @craig.topper wrote:

In D116350#3212010, @VincentWu wrote:

Whether Vector CSRs should be allowed to be accessed when V extensions are not enabled？

I mean, is there a wrong implementation or a wrong test case?

I found this patch where the F extension check was removed from fcsr, fflags, and frm based on binutils not checking. https://reviews.llvm.org/D58932 But it looks like binutils may have implemented checking after that patch https://sourceware.org/legacy-ml/binutils/2019-12/msg00222.html

I think we should make Vector ext same as F extensions.
make CSRs can be accessed without V ext.

So I think this patch is make sense now.

Revision Contents

Path

Size

llvm/

test/

MC/

RISCV/

rvv-user-csr-names.s

8 lines

Diff 396450

llvm/test/MC/RISCV/rvv-user-csr-names.s

	# RUN: llvm-mc %s -triple=riscv32 -riscv-no-aliases -mattr=+f -show-encoding \			# RUN: llvm-mc %s -triple=riscv32 -riscv-no-aliases -mattr=+f -show-encoding \
	# RUN: \| FileCheck -check-prefixes=CHECK-INST,CHECK-ENC %s			# RUN: \| FileCheck -check-prefixes=CHECK-INST,CHECK-ENC %s
	# RUN: llvm-mc -filetype=obj -triple riscv32 -mattr=+v < %s \			# RUN: llvm-mc -filetype=obj -triple riscv32 < %s \
	# RUN: \| llvm-objdump -d --mattr=+v - \			# RUN: \| llvm-objdump -d - \
	# RUN: \| FileCheck -check-prefix=CHECK-INST-ALIAS %s			# RUN: \| FileCheck -check-prefix=CHECK-INST-ALIAS %s
	#			#
	# RUN: llvm-mc %s -triple=riscv64 -riscv-no-aliases -mattr=+f -show-encoding \			# RUN: llvm-mc %s -triple=riscv64 -riscv-no-aliases -mattr=+f -show-encoding \
	# RUN: \| FileCheck -check-prefixes=CHECK-INST,CHECK-ENC %s			# RUN: \| FileCheck -check-prefixes=CHECK-INST,CHECK-ENC %s
	# RUN: llvm-mc -filetype=obj -triple riscv64 -mattr=+v < %s \			# RUN: llvm-mc -filetype=obj -triple riscv64 < %s \
	# RUN: \| llvm-objdump -d --mattr=+v - \			# RUN: \| llvm-objdump -d - \
	# RUN: \| FileCheck -check-prefix=CHECK-INST-ALIAS %s			# RUN: \| FileCheck -check-prefix=CHECK-INST-ALIAS %s

	##################################			##################################