Page MenuHomePhabricator
Differential D113956

[mlir] Convert NamedAttribute to be a class
ClosedPublic
Actions

Authored by rriddle on Nov 15 2021, 5:23 PM.

Details

Reviewers
mehdi_amini
jpienaar
antiagainst
aartbik
ftynse
nicolasvasilache
herhut
Commits
rG0c7890c844fd: [mlir] Convert NamedAttribute to be a class
Summary

NamedAttribute is currently represented as an std::pair, but this
creates an extremely clunky .first/.second API. This commit
converts it to a class, with better accessors (getName/getValue)
and also opens the door for more convenient API in the future.

Diff Detail

Event Timeline

rriddle created this revision.Nov 15 2021, 5:23 PM
Herald added a reviewer: antiagainst. · View Herald TranscriptNov 15 2021, 5:23 PM
Herald added a reviewer: aartbik. · View Herald Transcript
Herald added a reviewer: ftynse. · View Herald Transcript
Herald added a reviewer: aartbik. · View Herald Transcript
Herald added subscribers: sdasgup3, wenzhicui, wrengr and 28 others. · View Herald Transcript
rriddle requested review of this revision.Nov 15 2021, 5:23 PM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptNov 15 2021, 5:23 PM
Herald added a reviewer: herhut. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B134397: Diff 387452.Nov 15 2021, 5:42 PM
mehdi_amini added a comment.Nov 15 2021, 5:44 PM

Nice! This std::pair was fairly annoying to me :)

rriddle updated this revision to Diff 387666.Nov 16 2021, 8:49 AM

fix flang

Herald added a project: Restricted Project. · View Herald TranscriptNov 16 2021, 8:49 AM
Harbormaster completed remote builds in B134543: Diff 387666.Nov 16 2021, 9:06 AM
aartbik accepted this revision.Nov 16 2021, 1:03 PM

LGTM sparse/vector

This revision is now accepted and ready to land.Nov 16 2021, 1:03 PM
mehdi_amini accepted this revision.Nov 17 2021, 4:01 PM
jpienaar accepted this revision.Nov 17 2021, 4:26 PM
Closed by commit rG0c7890c844fd: [mlir] Convert NamedAttribute to be a class (authored by rriddle). · Explain WhyNov 17 2021, 9:40 PM
This revision was automatically updated to reflect the committed changes.
rriddle added a commit: rG0c7890c844fd: [mlir] Convert NamedAttribute to be a class.

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Dialect/
LLVMIR/
10 lines
IR/
77 lines
8 lines
4 lines
4 lines
Target/
LLVMIR/
2 lines
lib/
CAPI/
IR/
2 lines
2 lines
Conversion/
GPUCommon/
6 lines
GPUToSPIRV/
6 lines
SCFToGPU/
6 lines
StandardToLLVM/
14 lines
Dialect/
Affine/
Transforms/
8 lines
DLTI/
6 lines
GPU/
IR/
4 lines
LLVMIR/
IR/
30 lines
4 lines
2 lines
Linalg/
IR/
8 lines
16 lines
SPIRV/
IR/
8 lines
Linking/
ModuleCombiner/
2 lines
Transforms/
3 lines
6 lines
Shape/
IR/
10 lines
SparseTensor/
IR/
18 lines
Vector/
2 lines
IR/
18 lines
26 lines
32 lines
30 lines
36 lines
2 lines
Parser/
2 lines
Target/
Cpp/
8 lines
LLVMIR/
Dialect/
LLVMIR/
6 lines
NVVM/
2 lines
ROCDL/
2 lines
SPIRV/
Deserialization/
7 lines
Serialization/
10 lines
8 lines
Transforms/
Utils/
6 lines
4 lines
test/
lib/
Dialect/
Test/
8 lines
2 lines
IR/
2 lines
4 lines
mlir-tblgen/
4 lines
tools/
mlir-tblgen/
6 lines
3 lines
unittests/
IR/
16 lines
TableGen/
3 lines
6 lines

Diff 387452

View Options

mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td

Loading...
View Options

mlir/include/mlir/IR/Attributes.h

Loading...
View Options

mlir/include/mlir/IR/FunctionSupport.h

Loading...
View Options

mlir/include/mlir/IR/Operation.h

Loading...
View Options

mlir/include/mlir/IR/OperationSupport.h

Loading...
View Options

mlir/include/mlir/Target/LLVMIR/LLVMTranslationInterface.h

Loading...
View Options

mlir/lib/CAPI/IR/BuiltinAttributes.cpp

Loading...
View Options

mlir/lib/CAPI/IR/IR.cpp

Loading...
View Options

mlir/lib/Conversion/GPUCommon/GPUOpsLowering.cpp

Loading...
View Options

mlir/lib/Conversion/GPUToSPIRV/GPUToSPIRV.cpp

Loading...
View Options

mlir/lib/Conversion/SCFToGPU/SCFToGPU.cpp

Loading...
View Options

mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp

Loading...
View Options

mlir/lib/Dialect/Affine/Transforms/SimplifyAffineStructures.cpp

Loading...
View Options

mlir/lib/Dialect/DLTI/DLTI.cpp

Loading...
View Options

mlir/lib/Dialect/GPU/IR/GPUDialect.cpp

Loading...
View Options

mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp

Loading...
View Options

mlir/lib/Dialect/LLVMIR/IR/NVVMDialect.cpp

Loading...
View Options

mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp

Loading...
View Options

mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp

Loading...
View Options

mlir/lib/Dialect/Linalg/IR/LinalgTypes.cpp

Loading...
View Options

mlir/lib/Dialect/SPIRV/IR/SPIRVDialect.cpp

Loading...
View Options

mlir/lib/Dialect/SPIRV/Linking/ModuleCombiner/ModuleCombiner.cpp

Loading...
View Options

mlir/lib/Dialect/SPIRV/Transforms/DecorateCompositeTypeLayoutPass.cpp

Loading...
View Options

mlir/lib/Dialect/SPIRV/Transforms/SPIRVConversion.cpp

Loading...
View Options

mlir/lib/Dialect/Shape/IR/Shape.cpp

Loading...
View Options

mlir/lib/Dialect/SparseTensor/IR/SparseTensorDialect.cpp

Loading...
View Options

mlir/lib/Dialect/Vector/VectorOps.cpp

Loading...
View Options

mlir/lib/IR/AsmPrinter.cpp

Loading...
View Options

mlir/lib/IR/Attributes.cpp

Loading...
View Options

mlir/lib/IR/BuiltinAttributes.cpp

Loading...
View Options

mlir/lib/IR/BuiltinDialect.cpp

Loading...
View Options

mlir/lib/IR/OperationSupport.cpp

Loading...
View Options

mlir/lib/IR/Verifier.cpp

Loading...
View Options

mlir/lib/Parser/Parser.cpp

Loading...
View Options

mlir/lib/Target/Cpp/TranslateToCpp.cpp

Loading...
View Options

mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp

Loading...
View Options

mlir/lib/Target/LLVMIR/Dialect/NVVM/NVVMToLLVMIRTranslation.cpp

Loading...
View Options

mlir/lib/Target/LLVMIR/Dialect/ROCDL/ROCDLToLLVMIRTranslation.cpp

Loading...
View Options

mlir/lib/Target/SPIRV/Deserialization/Deserializer.cpp

Loading...
View Options

mlir/lib/Target/SPIRV/Serialization/SerializeOps.cpp

Loading...
View Options

mlir/lib/Target/SPIRV/Serialization/Serializer.cpp

Loading...
View Options

mlir/lib/Transforms/Utils/Utils.cpp

Loading...
View Options

mlir/lib/Transforms/ViewOpGraph.cpp

Loading...
View Options

mlir/test/lib/Dialect/Test/TestDialect.cpp

Loading...
View Options

mlir/test/lib/Dialect/Test/TestPatterns.cpp

Loading...
View Options

mlir/test/lib/IR/TestBuiltinAttributeInterfaces.cpp

Loading...
View Options

mlir/test/lib/IR/TestPrintNesting.cpp

Loading...
View Options

mlir/test/mlir-tblgen/op-result.td

Loading...
View Options

mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

Loading...
View Options

mlir/tools/mlir-tblgen/SPIRVUtilsGen.cpp

Loading...
View Options

mlir/unittests/IR/OperationSupportTest.cpp

Loading...
View Options

mlir/unittests/TableGen/OpBuildGen.cpp

Loading...
View Options

mlir/unittests/TableGen/StructsGenTest.cpp

Loading...