Add an AtomicScopeModel for HIP and support for OpenCL builtins
that are missing in HIP.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
- removed debug code
- some macro definitions need to be defined for HIP-only compilation
@yaxunl thanks for the review! My Github account is locked unfortunately so I will have to ask you to push this commit to the main branch. Thank you!
clang/lib/Sema/SemaChecking.cpp | ||
---|---|---|
5587 | I'm confused about what's happening here. You're editing comments to make more tendentious claims, and then adding FIXMEs to make charged questions about your own claims? Did you consider just not editing the comments? |
clang/lib/Sema/SemaChecking.cpp | ||
---|---|---|
5587 | Ahh I totally missed this, my apologies. I will revert this patch and get rid of this comment. Thanks for pointing it out. |
clang/lib/Sema/SemaChecking.cpp | ||
---|---|---|
5587 | Actually, this comes from a different patch: https://reviews.llvm.org/D114025#change-dkrDg1ZRTmhm |
clang/lib/Sema/SemaChecking.cpp | ||
---|---|---|
5587 | Ah, Phabricator is just being weird, then; sorry for the noise. |
debugging code should be removed