Page MenuHomePhabricator

gandhi21299 (Anshil Gandhi)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 31 2020, 12:34 PM (46 w, 2 h)

Recent Activity

Today

gandhi21299 committed rG2e5dc4a1efe1: [AMDGPU] [CodeGen] Fold negate llvm.amdgcn.class into test mask (authored by gandhi21299).
[AMDGPU] [CodeGen] Fold negate llvm.amdgcn.class into test mask
Fri, Jun 18, 12:05 PM
gandhi21299 closed D104049: [AMDGPU] [CodeGen] Fold negate llvm.amdgcn.class into test mask.
Fri, Jun 18, 12:04 PM · Restricted Project
gandhi21299 added a comment to D104049: [AMDGPU] [CodeGen] Fold negate llvm.amdgcn.class into test mask.

Thanks for the review process, I will merge this patch in

Fri, Jun 18, 11:56 AM · Restricted Project
gandhi21299 updated the diff for D104049: [AMDGPU] [CodeGen] Fold negate llvm.amdgcn.class into test mask.
  • added checks on operands for the class intrinsic
Fri, Jun 18, 11:37 AM · Restricted Project
gandhi21299 updated the diff for D104049: [AMDGPU] [CodeGen] Fold negate llvm.amdgcn.class into test mask.
  • eliminated RHS IntegerTy check since it is already declared as a ConstantInt
Fri, Jun 18, 9:22 AM · Restricted Project
gandhi21299 updated the diff for D104049: [AMDGPU] [CodeGen] Fold negate llvm.amdgcn.class into test mask.
  • now passes all tests, thanks @foad for the fix
Fri, Jun 18, 8:36 AM · Restricted Project

Yesterday

gandhi21299 added a comment to D104049: [AMDGPU] [CodeGen] Fold negate llvm.amdgcn.class into test mask.

I am not too sure what is causing the test CodeGen/AMDGPU/amdgpu-codegenprepare-i16-to-i32.ll to fail. There is no amdgcn class intrinsic being used anywhere in this test case so there should not be any transformation happening. @arsenm

Thu, Jun 17, 5:57 PM · Restricted Project
gandhi21299 updated the diff for D104049: [AMDGPU] [CodeGen] Fold negate llvm.amdgcn.class into test mask.
  • get lower 10 bits of the test mask by xor-ing with 0x3ff
  • updated tests accordingly
  • refactoring
  • 2 tests still fail from the AMDGPU codegen test suite
Thu, Jun 17, 11:52 AM · Restricted Project
gandhi21299 added inline comments to D104049: [AMDGPU] [CodeGen] Fold negate llvm.amdgcn.class into test mask.
Thu, Jun 17, 9:10 AM · Restricted Project

Wed, Jun 16

gandhi21299 added inline comments to D104049: [AMDGPU] [CodeGen] Fold negate llvm.amdgcn.class into test mask.
Wed, Jun 16, 2:50 PM · Restricted Project
gandhi21299 updated the diff for D104049: [AMDGPU] [CodeGen] Fold negate llvm.amdgcn.class into test mask.
  • requested changes
  • @foad two tests fail after running ninja check-llvm-codegen-amdgpu
Wed, Jun 16, 2:48 PM · Restricted Project
gandhi21299 committed rG2193347e72fa: [M68k][GloballSel] Adding initial GlobalISel infrastructure (authored by sushmaunnibhavi).
[M68k][GloballSel] Adding initial GlobalISel infrastructure
Wed, Jun 16, 9:49 AM
gandhi21299 closed D101819: [M68k][GloballSel] Adding initial GlobalISel infrastructure.
Wed, Jun 16, 9:48 AM · Restricted Project
gandhi21299 accepted D101819: [M68k][GloballSel] Adding initial GlobalISel infrastructure.

LGTM I can merge this patch in.

Wed, Jun 16, 9:22 AM · Restricted Project

Tue, Jun 15

gandhi21299 updated the diff for D104049: [AMDGPU] [CodeGen] Fold negate llvm.amdgcn.class into test mask.
  • refreshing diff, only 2 tests should be failing instead of 4
Tue, Jun 15, 3:00 PM · Restricted Project
gandhi21299 added inline comments to D104049: [AMDGPU] [CodeGen] Fold negate llvm.amdgcn.class into test mask.
Tue, Jun 15, 1:11 PM · Restricted Project
gandhi21299 updated the diff for D104049: [AMDGPU] [CodeGen] Fold negate llvm.amdgcn.class into test mask.
  • changes as requested by Matt
Tue, Jun 15, 11:49 AM · Restricted Project
gandhi21299 updated the diff for D104049: [AMDGPU] [CodeGen] Fold negate llvm.amdgcn.class into test mask.
Tue, Jun 15, 11:46 AM · Restricted Project

Sun, Jun 13

gandhi21299 updated the diff for D104049: [AMDGPU] [CodeGen] Fold negate llvm.amdgcn.class into test mask.
  • check if one of the operands of the xor instruction is a ConstantInt, fixes two of the tests
Sun, Jun 13, 10:09 PM · Restricted Project

Sat, Jun 12

gandhi21299 accepted D101819: [M68k][GloballSel] Adding initial GlobalISel infrastructure.

Please excuse my previous comment, this patch LGTM

Sat, Jun 12, 9:31 AM · Restricted Project
gandhi21299 added a comment to D101819: [M68k][GloballSel] Adding initial GlobalISel infrastructure.

@sushmaunnibhavi There is still a clang-tidy error : 'M68kGenRegisterBank.inc' file not found

Sat, Jun 12, 9:21 AM · Restricted Project

Fri, Jun 11

gandhi21299 updated the diff for D104049: [AMDGPU] [CodeGen] Fold negate llvm.amdgcn.class into test mask.
Fri, Jun 11, 1:45 PM · Restricted Project
gandhi21299 added inline comments to D104049: [AMDGPU] [CodeGen] Fold negate llvm.amdgcn.class into test mask.
Fri, Jun 11, 12:46 PM · Restricted Project
gandhi21299 added inline comments to D104049: [AMDGPU] [CodeGen] Fold negate llvm.amdgcn.class into test mask.
Fri, Jun 11, 9:09 AM · Restricted Project

Thu, Jun 10

gandhi21299 requested review of D104049: [AMDGPU] [CodeGen] Fold negate llvm.amdgcn.class into test mask.
Thu, Jun 10, 11:01 AM · Restricted Project

Wed, Jun 2

gandhi21299 committed rG1c5ff0b03f4e: [PowerPC] [GlobalISel] Implementation of formal arguments lowering in the… (authored by gandhi21299).
[PowerPC] [GlobalISel] Implementation of formal arguments lowering in the…
Wed, Jun 2, 3:47 PM
gandhi21299 added a reverting change for rGc729f2a48a6e: Differential Revision: https://reviews.llvm.org/D99812: rG3e5ddb83e387: Revert "Differential Revision: https://reviews.llvm.org/D99812".
Wed, Jun 2, 3:36 PM
gandhi21299 committed rG3e5ddb83e387: Revert "Differential Revision: https://reviews.llvm.org/D99812" (authored by gandhi21299).
Revert "Differential Revision: https://reviews.llvm.org/D99812"
Wed, Jun 2, 3:36 PM
gandhi21299 committed rGc729f2a48a6e: Differential Revision: https://reviews.llvm.org/D99812 (authored by gandhi21299).
Differential Revision: https://reviews.llvm.org/D99812
Wed, Jun 2, 1:11 PM

Apr 28 2021

gandhi21299 accepted D101295: [docs]Added llvm/bindings section.

LGTM

Apr 28 2021, 12:34 PM · Restricted Project

Mar 17 2021

gandhi21299 added a comment to D98674: [NFC] [PowerPC] Determine Endianness in PPCTargetMachine.

Can someone who has commit access, commit this patch? Thanks

Mar 17 2021, 9:23 AM · Restricted Project

Mar 15 2021

gandhi21299 added a comment to D98674: [NFC] [PowerPC] Determine Endianness in PPCTargetMachine.

Please commit this patch at your convenience, thank you. @nemanjai

Mar 15 2021, 9:05 PM · Restricted Project
gandhi21299 updated the diff for D98674: [NFC] [PowerPC] Determine Endianness in PPCTargetMachine.

applying clang-format

Mar 15 2021, 8:57 PM · Restricted Project
gandhi21299 retitled D98674: [NFC] [PowerPC] Determine Endianness in PPCTargetMachine from Resolved a FIXME in PowerPC SubTarget to [NFC] [PowerPC] Determine Endianness in PPCTargetMachine.
Mar 15 2021, 8:41 PM · Restricted Project
gandhi21299 added a comment to D98674: [NFC] [PowerPC] Determine Endianness in PPCTargetMachine.

Sounds good! Thanks for reviewing @nemanjai

Mar 15 2021, 8:38 PM · Restricted Project
gandhi21299 requested review of D98674: [NFC] [PowerPC] Determine Endianness in PPCTargetMachine.
Mar 15 2021, 5:53 PM · Restricted Project

Feb 25 2021

gandhi21299 added a comment to D92956: Fix range-loop-analysis checks for trivial copyability.

I tried to implement a fix by using the hasCopyAssignmentWithConstParam() method (instead of hasNonTrivialCopyConstructor()), the test trivially-copyable.cc fails due to a missing warning.

Feb 25 2021, 9:52 PM · Restricted Project