Page MenuHomePhabricator

gandhi21299 (Anshil Gandhi)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 31 2020, 12:34 PM (106 w, 3 d)

Recent Activity

Thu, Jul 28

gandhi21299 committed rG5c380564317c: [AMDGPU][Scheduler] Avoid initializing Register pressure tracker when tracking… (authored by gandhi21299).
[AMDGPU][Scheduler] Avoid initializing Register pressure tracker when tracking…
Thu, Jul 28, 2:40 PM · Restricted Project, Restricted Project
gandhi21299 closed D129322: [AMDGPU][Scheduler] Avoid initializing Register pressure tracker when tracking is disabled.
Thu, Jul 28, 2:40 PM · Restricted Project, Restricted Project
gandhi21299 updated the summary of D129322: [AMDGPU][Scheduler] Avoid initializing Register pressure tracker when tracking is disabled.
Thu, Jul 28, 1:26 PM · Restricted Project, Restricted Project
gandhi21299 added a comment to D129322: [AMDGPU][Scheduler] Avoid initializing Register pressure tracker when tracking is disabled.

@rampitec I was loading the pressure values at every candidate. initCandidate clears the values in Pressure so the array becomes empty for the next iteration.

Thu, Jul 28, 12:56 PM · Restricted Project, Restricted Project
gandhi21299 updated the diff for D129322: [AMDGPU][Scheduler] Avoid initializing Register pressure tracker when tracking is disabled.
  • Use DAG to check if RPTracking is enabled.
  • Eliminate diffs in extract-element.ll as this patch should not have altered that test.
Thu, Jul 28, 12:39 PM · Restricted Project, Restricted Project

Jul 11 2022

gandhi21299 added a comment to D129322: [AMDGPU][Scheduler] Avoid initializing Register pressure tracker when tracking is disabled.

@rampitec Agreed, I have been examining the code around the changes I have made. I am not sure why that test was affected.

Jul 11 2022, 2:19 PM · Restricted Project, Restricted Project
gandhi21299 updated the diff for D129322: [AMDGPU][Scheduler] Avoid initializing Register pressure tracker when tracking is disabled.
  • reverted the function name back to initCandidate
  • added testing for the option -misched-regpressure=false
Jul 11 2022, 2:13 PM · Restricted Project, Restricted Project

Jul 7 2022

gandhi21299 added reviewers for D129322: [AMDGPU][Scheduler] Avoid initializing Register pressure tracker when tracking is disabled: arsenm, rampitec, kerbowa.
Jul 7 2022, 12:54 PM · Restricted Project, Restricted Project
gandhi21299 requested review of D129322: [AMDGPU][Scheduler] Avoid initializing Register pressure tracker when tracking is disabled.
Jul 7 2022, 12:53 PM · Restricted Project, Restricted Project

Apr 12 2022

gandhi21299 committed rG528aa090104a: [AMDGPU][Codegen] Unsupported image sample texture map instructions (authored by gandhi21299).
[AMDGPU][Codegen] Unsupported image sample texture map instructions
Apr 12 2022, 9:39 AM · Restricted Project, Restricted Project
gandhi21299 closed D123461: [AMDGPU][Codegen] Unsupported image sample texture map instructions.
Apr 12 2022, 9:39 AM · Restricted Project, Restricted Project
gandhi21299 updated the diff for D123461: [AMDGPU][Codegen] Unsupported image sample texture map instructions.

Thanks for the review.

Apr 12 2022, 9:35 AM · Restricted Project, Restricted Project
gandhi21299 updated the diff for D123461: [AMDGPU][Codegen] Unsupported image sample texture map instructions.
  • replaced the feature to HasG16
  • added missing test cases
Apr 12 2022, 9:05 AM · Restricted Project, Restricted Project
gandhi21299 retitled D123461: [AMDGPU][Codegen] Unsupported image sample texture map instructions from [AMDGPU][Codegen] Unsupported image sample texture map instructions on gfx6-gfx9 to [AMDGPU][Codegen] Unsupported image sample texture map instructions.
Apr 12 2022, 8:49 AM · Restricted Project, Restricted Project

Apr 9 2022

gandhi21299 requested review of D123461: [AMDGPU][Codegen] Unsupported image sample texture map instructions.
Apr 9 2022, 9:36 PM · Restricted Project, Restricted Project

Apr 7 2022

gandhi21299 added a comment to D92956: Fix range-loop-analysis checks for trivial copyability.

Perhaps, a description could be added to this patch before committing.

Apr 7 2022, 9:51 AM · Restricted Project, Unknown Object (Project)
Herald added a project to D92956: Fix range-loop-analysis checks for trivial copyability: Restricted Project.

@Quuxplusone I can commit this patch on behalf of @fanfuqiang.

Apr 7 2022, 9:42 AM · Restricted Project, Unknown Object (Project)

Nov 29 2021

gandhi21299 committed rGdf0560ca0018: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in… (authored by gandhi21299).
[HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in…
Nov 29 2021, 11:08 AM
gandhi21299 closed D114553: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in HIP-clang.
Nov 29 2021, 11:07 AM · Unknown Object (Project)
gandhi21299 added a comment to D114553: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in HIP-clang.

Thanks for the review, I will merge this patch in.

Nov 29 2021, 11:05 AM · Unknown Object (Project)
gandhi21299 updated the diff for D114553: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in HIP-clang.
  • replaced integers with memory order macros in SemaCUDA/atomic-ops.cu
Nov 29 2021, 8:23 AM · Unknown Object (Project)

Nov 26 2021

gandhi21299 updated the diff for D114553: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in HIP-clang.

applied clang-format

Nov 26 2021, 10:26 AM · Unknown Object (Project)
gandhi21299 updated the diff for D114553: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in HIP-clang.

addressed feedback including

  • correction of function signatures
  • checking for order combinations
  • correcting expected store atomic instruction
  • using predefined macros for memory order
Nov 26 2021, 10:25 AM · Unknown Object (Project)

Nov 25 2021

gandhi21299 added a comment to D114553: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in HIP-clang.

Passed internal CI

Nov 25 2021, 10:13 AM · Unknown Object (Project)
gandhi21299 updated the diff for D114553: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in HIP-clang.
  • applied clang-format
Nov 25 2021, 10:12 AM · Unknown Object (Project)
gandhi21299 updated the diff for D114553: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in HIP-clang.
  • added order argument in the builtins and changed the tests accordingly
  • adding Sema test
Nov 25 2021, 10:11 AM · Unknown Object (Project)

Nov 24 2021

gandhi21299 added inline comments to D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang.
Nov 24 2021, 4:13 PM · Unknown Object (Project)
gandhi21299 added inline comments to D113925: [HIP] Add HIP scope atomic operations.
Nov 24 2021, 4:07 PM · Unknown Object (Project)
gandhi21299 added inline comments to D113925: [HIP] Add HIP scope atomic operations.
Nov 24 2021, 3:11 PM · Unknown Object (Project)
gandhi21299 updated the summary of D114553: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in HIP-clang.
Nov 24 2021, 12:06 PM · Unknown Object (Project)
gandhi21299 updated the diff for D114553: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in HIP-clang.

removed changes in atomic-ops.cl, CUDA test may be sufficient.

Nov 24 2021, 11:24 AM · Unknown Object (Project)
gandhi21299 requested review of D114553: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in HIP-clang.
Nov 24 2021, 11:18 AM · Unknown Object (Project)

Nov 21 2021

gandhi21299 added a comment to D55570: [AMDGPU] Improve SDWA generation for V_OR_B32_E32..

This patch needs a rebase.

Nov 21 2021, 2:52 PM
gandhi21299 accepted D92956: Fix range-loop-analysis checks for trivial copyability.

LGTM, thanks for the bug fix!

Nov 21 2021, 2:39 PM · Restricted Project, Unknown Object (Project)
gandhi21299 added a reviewer for D92956: Fix range-loop-analysis checks for trivial copyability: gandhi21299.
Nov 21 2021, 12:27 PM · Restricted Project, Unknown Object (Project)

Nov 18 2021

gandhi21299 added a comment to D113925: [HIP] Add HIP scope atomic operations.

@yaxunl thanks for the review! My Github account is locked unfortunately so I will have to ask you to push this commit to the main branch. Thank you!

Nov 18 2021, 12:37 PM · Unknown Object (Project)

Nov 16 2021

gandhi21299 updated the diff for D113925: [HIP] Add HIP scope atomic operations.
  • removed debug code
  • some macro definitions need to be defined for HIP-only compilation
Nov 16 2021, 8:52 AM · Unknown Object (Project)

Nov 15 2021

gandhi21299 updated the diff for D113925: [HIP] Add HIP scope atomic operations.

reapplied clang-format

Nov 15 2021, 1:52 PM · Unknown Object (Project)
gandhi21299 updated the diff for D113925: [HIP] Add HIP scope atomic operations.

clang-formatted code

Nov 15 2021, 1:51 PM · Unknown Object (Project)
gandhi21299 requested review of D113925: [HIP] Add HIP scope atomic operations.
Nov 15 2021, 11:15 AM · Unknown Object (Project)
gandhi21299 added a comment to D112635: [AMDGPU] Disable d16 loads/stores to high halves on gfx90a.

Typo in the summary: "D16PreservesUnesedBits" -> "D16PreservesUnusedBits"

Nov 15 2021, 9:04 AM · Restricted Project

Oct 20 2021

gandhi21299 added inline comments to D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols.
Oct 20 2021, 11:31 AM · Restricted Project, Unknown Object (Project)
gandhi21299 added inline comments to D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols.
Oct 20 2021, 10:59 AM · Restricted Project, Unknown Object (Project)

Oct 19 2021

gandhi21299 accepted D108319: [doc][GlobalISel]Improving generic opcodes for memory operations.
Oct 19 2021, 9:47 AM · Restricted Project
gandhi21299 added a comment to D108319: [doc][GlobalISel]Improving generic opcodes for memory operations.

LGTM, appreciate your efforts!

Oct 19 2021, 9:46 AM · Restricted Project
gandhi21299 added a comment to D108319: [doc][GlobalISel]Improving generic opcodes for memory operations.

ping

Oct 19 2021, 9:16 AM · Restricted Project

Oct 18 2021

gandhi21299 committed rG0567f0333176: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols (authored by gandhi21299).
[HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols
Oct 18 2021, 3:54 PM
gandhi21299 closed D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols.
Oct 18 2021, 3:53 PM · Restricted Project, Unknown Object (Project)

Oct 16 2021

gandhi21299 added inline comments to D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols.
Oct 16 2021, 12:33 PM · Restricted Project, Unknown Object (Project)

Oct 15 2021

gandhi21299 added a comment to D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols.

@thakis can you please check if this solution is sufficient? Thanks for bringing it up

Oct 15 2021, 3:35 PM · Restricted Project, Unknown Object (Project)
gandhi21299 updated the diff for D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols.

added -target option in the test amdgpu-alias-undef-symbols.cu

Oct 15 2021, 3:31 PM · Restricted Project, Unknown Object (Project)
gandhi21299 reopened D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols.
Oct 15 2021, 3:25 PM · Restricted Project, Unknown Object (Project)
gandhi21299 added a reverting change for rG03375a3fb33b: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols: rG1830ec94ac02: Revert "[HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined….
Oct 15 2021, 3:16 PM
gandhi21299 committed rG1830ec94ac02: Revert "[HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined… (authored by gandhi21299).
Revert "[HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined…
Oct 15 2021, 3:16 PM
gandhi21299 added a reverting change for D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols: rG1830ec94ac02: Revert "[HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined….
Oct 15 2021, 3:16 PM · Restricted Project, Unknown Object (Project)
gandhi21299 committed rGf92db6d3fff1: [HIP] Relax conditions for address space cast in builtin args (authored by gandhi21299).
[HIP] Relax conditions for address space cast in builtin args
Oct 15 2021, 2:36 PM
gandhi21299 closed D111734: [HIP] Relax conditions for address space cast in builtin args.
Oct 15 2021, 2:36 PM · Unknown Object (Project)
gandhi21299 updated the diff for D111734: [HIP] Relax conditions for address space cast in builtin args.

cleaned up code for readability

Oct 15 2021, 2:12 PM · Unknown Object (Project)
gandhi21299 reopened D111734: [HIP] Relax conditions for address space cast in builtin args.
Oct 15 2021, 1:44 PM · Unknown Object (Project)
gandhi21299 added a reverting change for rG3b48e1170dc6: [HIP] Relax conditions for address space cast in builtin args: rG53fc5100e07a: Revert "[HIP] Relax conditions for address space cast in builtin args".
Oct 15 2021, 1:42 PM
gandhi21299 committed rG53fc5100e07a: Revert "[HIP] Relax conditions for address space cast in builtin args" (authored by gandhi21299).
Revert "[HIP] Relax conditions for address space cast in builtin args"
Oct 15 2021, 1:42 PM
gandhi21299 added a reverting change for D111734: [HIP] Relax conditions for address space cast in builtin args: rG53fc5100e07a: Revert "[HIP] Relax conditions for address space cast in builtin args".
Oct 15 2021, 1:42 PM · Unknown Object (Project)
gandhi21299 added a comment to D111734: [HIP] Relax conditions for address space cast in builtin args.

@tra I see, we sure can rewrite that segment for readability.

Oct 15 2021, 1:41 PM · Unknown Object (Project)
gandhi21299 committed rG3b48e1170dc6: [HIP] Relax conditions for address space cast in builtin args (authored by gandhi21299).
[HIP] Relax conditions for address space cast in builtin args
Oct 15 2021, 1:07 PM
gandhi21299 closed D111734: [HIP] Relax conditions for address space cast in builtin args.
Oct 15 2021, 1:07 PM · Unknown Object (Project)
gandhi21299 added a comment to D111734: [HIP] Relax conditions for address space cast in builtin args.

Thanks for the review!

Oct 15 2021, 12:43 PM · Unknown Object (Project)
gandhi21299 updated the diff for D111734: [HIP] Relax conditions for address space cast in builtin args.

corrected sema test, as requested

Oct 15 2021, 11:14 AM · Unknown Object (Project)
gandhi21299 committed rG03375a3fb33b: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols (authored by gandhi21299).
[HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols
Oct 15 2021, 10:39 AM
gandhi21299 closed D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols.
Oct 15 2021, 10:39 AM · Restricted Project, Unknown Object (Project)
gandhi21299 updated the diff for D111734: [HIP] Relax conditions for address space cast in builtin args.

removed unused diagnostic sema note

Oct 15 2021, 9:59 AM · Unknown Object (Project)
gandhi21299 updated the diff for D111734: [HIP] Relax conditions for address space cast in builtin args.

installed clang-format, refreshing patch

Oct 15 2021, 9:57 AM · Unknown Object (Project)
gandhi21299 updated the diff for D111734: [HIP] Relax conditions for address space cast in builtin args.

adding sema test

Oct 15 2021, 9:55 AM · Unknown Object (Project)
gandhi21299 added a comment to D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols.

ping

Oct 15 2021, 8:24 AM · Restricted Project, Unknown Object (Project)

Oct 14 2021

gandhi21299 added a comment to D111734: [HIP] Relax conditions for address space cast in builtin args.

Passed internal CI, still working on a Sema test.

Oct 14 2021, 8:10 AM · Unknown Object (Project)

Oct 13 2021

gandhi21299 added a comment to D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols.

Passed ePSDB

Oct 13 2021, 10:19 PM · Restricted Project, Unknown Object (Project)
gandhi21299 updated the diff for D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols.

add a restrictions to what architecture AlwaysInliner should run on, updated the inline-calls.ll test.

Oct 13 2021, 3:12 PM · Restricted Project, Unknown Object (Project)
gandhi21299 added a reviewer for D111734: [HIP] Relax conditions for address space cast in builtin args: bcahoon.
Oct 13 2021, 11:31 AM · Unknown Object (Project)
gandhi21299 updated the diff for D111734: [HIP] Relax conditions for address space cast in builtin args.

adding codegen test

Oct 13 2021, 9:55 AM · Unknown Object (Project)
gandhi21299 updated the diff for D111734: [HIP] Relax conditions for address space cast in builtin args.

removed irrelevant lines in the test

Oct 13 2021, 8:42 AM · Unknown Object (Project)
gandhi21299 requested review of D111734: [HIP] Relax conditions for address space cast in builtin args.
Oct 13 2021, 8:40 AM · Unknown Object (Project)

Oct 12 2021

gandhi21299 added inline comments to D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols.
Oct 12 2021, 1:16 PM · Restricted Project, Unknown Object (Project)

Oct 8 2021

gandhi21299 added a comment to D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols.

Passed internal CI

Oct 8 2021, 1:48 PM · Restricted Project, Unknown Object (Project)
gandhi21299 added a comment to D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols.

ping

Oct 8 2021, 9:27 AM · Restricted Project, Unknown Object (Project)
gandhi21299 updated the diff for D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols.

added -nogpulib and -nogpuinc flags to amdgpu-alias-undef-symbols.cu

Oct 8 2021, 8:04 AM · Restricted Project, Unknown Object (Project)

Oct 7 2021

gandhi21299 updated the diff for D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols.

refreshing patch

Oct 7 2021, 11:28 AM · Restricted Project, Unknown Object (Project)
gandhi21299 added a reviewer for D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols: Restricted Project.
Oct 7 2021, 8:09 AM · Restricted Project, Unknown Object (Project)

Oct 4 2021

gandhi21299 added a comment to D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols.

ping

Oct 4 2021, 2:11 PM · Restricted Project, Unknown Object (Project)

Oct 1 2021

gandhi21299 updated the summary of D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols.
Oct 1 2021, 1:00 PM · Restricted Project, Unknown Object (Project)
gandhi21299 updated the diff for D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols.
  • eliminated changes in SIISelLowering
Oct 1 2021, 10:06 AM · Restricted Project, Unknown Object (Project)
gandhi21299 updated the diff for D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols.
  • Since callees may alias to a function pointer, it makes sense for getCalleeFunction(...) to return a Function which is a cast of the operand of a GlobalAlias.
Oct 1 2021, 9:41 AM · Restricted Project, Unknown Object (Project)

Sep 30 2021

gandhi21299 added a comment to D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols.

inline-calls.ll failed on gfx908 due to the change in SIISelLowering.cpp, line 3015. Without the change, there is a failure in AMDGPUResourceAnalysis.cpp, line 65 because Op.getGlobal() is not a Function.

Sep 30 2021, 10:07 AM · Restricted Project, Unknown Object (Project)
gandhi21299 abandoned D110772: [clang] Allow pointers from any address space to gfx90a builtins.
Sep 30 2021, 10:01 AM · Unknown Object (Project)
gandhi21299 reclaimed D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols.

Sorry, that was a mistake.

Sep 30 2021, 10:00 AM · Restricted Project, Unknown Object (Project)
gandhi21299 abandoned D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols.
Sep 30 2021, 9:59 AM · Restricted Project, Unknown Object (Project)

Sep 29 2021

gandhi21299 updated the diff for D110772: [clang] Allow pointers from any address space to gfx90a builtins.
  • corrected test, address space cast should go under unsafeAtomicAdd(...) codegen
Sep 29 2021, 8:08 PM · Unknown Object (Project)
gandhi21299 requested review of D110772: [clang] Allow pointers from any address space to gfx90a builtins.
Sep 29 2021, 1:21 PM · Unknown Object (Project)

Sep 28 2021

gandhi21299 added inline comments to D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols.
Sep 28 2021, 12:01 PM · Restricted Project, Restricted Project
gandhi21299 updated the diff for D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols.
  • declare failure when lowering an accessor of a callee which is not a function, in GlobalISel
Sep 28 2021, 11:39 AM · Restricted Project, Restricted Project
gandhi21299 added a reviewer for D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols: tstellar.
Sep 28 2021, 7:57 AM · Restricted Project, Restricted Project
gandhi21299 added a reviewer for D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols: nhaustov.
Sep 28 2021, 7:55 AM · Restricted Project, Restricted Project