This patch adds conversion for basic box operations that extract
information from the box.
This patch is part of the upstreaming effort from fir-dev branch.
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
Paths
| Differential D113551
[fir] Add fir.box_rank, fir.box_addr, fir.box_dims and fir.box_elesize conversion ClosedPublic Authored by clementval on Nov 10 2021, 1:18 AM.
Details Summary This patch adds conversion for basic box operations that extract This patch is part of the upstreaming effort from fir-dev branch. Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
Diff Detail
Event Timelineawarzynski added inline comments.
clementval added a parent revision: D113553: [fir] Use contralized values for indexing box.Nov 10 2021, 2:24 AM Comment Actions Thanks for the updates, Makes sense. The remaining comments are mostly nits, so I'm accepting as is.
This revision is now accepted and ready to land.Nov 10 2021, 5:12 AM This revision was landed with ongoing or failed builds.Nov 10 2021, 6:35 AM Closed by commit rGdf3b9810c790: [fir] Add fir.box_rank, fir.box_addr, fir.box_dims and fir.box_elesize… (authored by clementval). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 386104 flang/lib/Optimizer/CodeGen/CodeGen.cpp
flang/lib/Optimizer/CodeGen/TypeConverter.h
flang/test/Fir/convert-to-llvm.fir
|
It's great to see some non-magic values used here! Do these numbers correspond to https://github.com/llvm/llvm-project/blob/99ad2079d452f587be050b3867e0ed4856335fb2/flang/lib/Optimizer/CodeGen/TypeConverter.h#L105-L116? If yes, could these be used for the type converter too? Also, could you add a comment here that would explain the origins of these indices? Ta!