Page MenuHomePhabricator

initial attempt to move TCPSocket from LLDB to LLVM
DraftPublic

Authored by noajshu on Thu, Sep 23, 1:38 PM.
This is a draft revision that has not yet been submitted for review.

Details

Reviewers
None
Summary

We would like to move the IOObject hierarchy from LLDB into LLVM so that we can use it (especially TCPSocket) in other projects. There are several details to be sorted out. We need to pick a different namespace for the IOObjects. We need to select which of the dependencies of the TCPSocket (e.g. Status.h, Log.h) we wish to move over into LLVM, and which ones we should replace.

Diff Detail

Unit TestsFailed

TimeTest
80 msx64 debian > ORC-x86_64-linux.TestCases/Linux/x86-64::trivial-cxa-atexit.S
Script: -- : 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang -m64 -c -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/orc/X86_64LinuxConfig/TestCases/Linux/x86-64/Output/trivial-cxa-atexit.S.tmp /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/orc/TestCases/Linux/x86-64/trivial-cxa-atexit.S
70 msx64 debian > ORC-x86_64-linux.TestCases/Linux/x86-64::trivial-static-initializer.S
Script: -- : 'RUN: at line 7'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang -m64 -c -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/orc/X86_64LinuxConfig/TestCases/Linux/x86-64/Output/trivial-static-initializer.S.tmp /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/orc/TestCases/Linux/x86-64/trivial-static-initializer.S
100 msx64 debian > ORC-x86_64-linux.TestCases/Linux/x86-64::trivial-tls.S
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang -m64 -c -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/orc/X86_64LinuxConfig/TestCases/Linux/x86-64/Output/trivial-tls.S.tmp /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/orc/TestCases/Linux/x86-64/trivial-tls.S

Event Timeline

noajshu created this revision.Thu, Sep 23, 1:38 PM
phosek added a subscriber: phosek.Thu, Sep 23, 5:35 PM

Rather than introducing llvm/lib/Host and llvm/lib/Utility, I'd prefer moving the classes to llvm/lib/Support which already contains the existing LLVM platform abstractions.