Page MenuHomePhabricator

noajshu (Noah Shutty)
User

Projects

User does not belong to any projects.

User Details

User Since
Fri, Sep 17, 11:45 AM (4 w, 12 h)

Recent Activity

Today

noajshu added inline comments to D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool.
Fri, Oct 15, 1:12 PM · Restricted Project
noajshu updated the diff for D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool.

Cherry-pick to fix extraneous delete in patch, minor style / formatting changes.

Fri, Oct 15, 12:58 PM · Restricted Project
noajshu updated the diff for D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool.

Parse Content-Length header to avoid HTTP response buffer reallocations, convert HTTP Body to MemoryBuffer.

Fri, Oct 15, 11:57 AM · Restricted Project
noajshu updated the diff for D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library..

rebase against main

Fri, Oct 15, 9:34 AM · Restricted Project, Restricted Project, Restricted Project

Yesterday

noajshu added inline comments to D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library..
Thu, Oct 14, 8:56 PM · Restricted Project, Restricted Project, Restricted Project
noajshu updated the diff for D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library..

Add *- C++ -*- header indicator to Caching.h

Thu, Oct 14, 8:56 PM · Restricted Project, Restricted Project, Restricted Project
noajshu added inline comments to D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool.
Thu, Oct 14, 4:13 PM · Restricted Project
noajshu updated the diff for D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool.

Replaced lit.util.pythonize_bool with llvm_canonicalize_cmake_booleans in lit.site.cfg.py.in.

Thu, Oct 14, 2:48 PM · Restricted Project
noajshu updated the diff for D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library..

rebase against main

Thu, Oct 14, 11:21 AM · Restricted Project, Restricted Project, Restricted Project
noajshu updated the diff for D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool.

rebase against main

Thu, Oct 14, 11:20 AM · Restricted Project
noajshu added inline comments to D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool.
Thu, Oct 14, 11:18 AM · Restricted Project
noajshu updated the diff for D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool.

Refactor HTTP Client to use std::vector & improve code formatting.

Thu, Oct 14, 11:10 AM · Restricted Project

Wed, Oct 13

noajshu updated the diff for D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool.

Rebase against latest diff D111371.

Wed, Oct 13, 8:31 PM · Restricted Project
noajshu updated the diff for D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library..

Rebase against main.

Wed, Oct 13, 8:17 PM · Restricted Project, Restricted Project, Restricted Project
noajshu updated the diff for D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool.

Replace bash-based lit tests with python subprocess based tests.

Wed, Oct 13, 8:16 PM · Restricted Project
noajshu updated the diff for D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool.

Add debuginfod client tests to unit test suite.

Wed, Oct 13, 12:30 PM · Restricted Project
noajshu updated the diff for D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool.

Remove .123 file added inadvertently.

Wed, Oct 13, 11:20 AM · Restricted Project
noajshu updated the diff for D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool.

Replace caching with LTO's localCache and refactor.
Expose an optional callback function parameter of fetchInfo to process debugging assets in memory. Update code and documentation for llvm style guidelines. Replace the hex encoding of asset keys with xxhash.

Wed, Oct 13, 10:52 AM · Restricted Project

Tue, Oct 12

noajshu added a comment to D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library..

@tejohnson Thanks for your comments! From my perspective this patch is done. Please let me know if you have any further changes to suggest before accepting. Thanks!

Tue, Oct 12, 11:47 AM · Restricted Project, Restricted Project, Restricted Project
noajshu updated the diff for D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library..

Make cache dir parameter a Twine and avoid unnecessary copy in conversion to SmallString.

Tue, Oct 12, 10:34 AM · Restricted Project, Restricted Project, Restricted Project
noajshu updated the diff for D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library..

rebase against main

Tue, Oct 12, 10:08 AM · Restricted Project, Restricted Project, Restricted Project
noajshu updated the diff for D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool.

Remove unnecessary use of \#ifdef LLVM_ENABLE...

Tue, Oct 12, 10:07 AM · Restricted Project
noajshu updated the diff for D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool.

rebase against D111238

Tue, Oct 12, 9:29 AM · Restricted Project
noajshu updated the diff for D111238: [Support][llvm] Add optional libCURL dependency to llvm build configuration.

rebase against D111238

Tue, Oct 12, 9:27 AM · Restricted Project
noajshu updated the diff for D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool.

Improve conformance to llvm coding standards.
Use namespace qualifiers in debuginfod library implementation. Replace LLVM_ENABLE_DEBUGINFOD_CLIENT with LLVM_ENABLE_CURL.

Tue, Oct 12, 9:26 AM · Restricted Project

Mon, Oct 11

noajshu updated the summary of D111238: [Support][llvm] Add optional libCURL dependency to llvm build configuration.
Mon, Oct 11, 4:59 PM · Restricted Project
noajshu added a comment to D111238: [Support][llvm] Add optional libCURL dependency to llvm build configuration.

Thanks @phosek. I don’t have commit access, could you land this patch for me? Please use “Noah Shutty <shutty@google.com>” to commit the change.

Mon, Oct 11, 4:59 PM · Restricted Project
noajshu updated the diff for D111238: [Support][llvm] Add optional libCURL dependency to llvm build configuration.

rebase against main

Mon, Oct 11, 4:57 PM · Restricted Project
noajshu updated the diff for D111238: [Support][llvm] Add optional libCURL dependency to llvm build configuration.

changed header file from curl.h to curl/curl.h to pass check_symbol_exists test

Mon, Oct 11, 4:00 PM · Restricted Project
noajshu updated the diff for D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool.

Update to reflect modified Debuginfod / Curl Cmake vars

Mon, Oct 11, 3:21 PM · Restricted Project
noajshu updated the diff for D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool.

Remove extraneous llvm/CMakeLists.txt changes per adjustments to D111238

Mon, Oct 11, 2:43 PM · Restricted Project
noajshu updated the diff for D111238: [Support][llvm] Add optional libCURL dependency to llvm build configuration.

Remove extraneous change to llvm/CMakeLists.txt

Mon, Oct 11, 2:17 PM · Restricted Project
noajshu updated the diff for D111238: [Support][llvm] Add optional libCURL dependency to llvm build configuration.

Move CURL dependency logic to config-ix.cmake.
Also update to the same model used for zlib as suggested by phosek.

Mon, Oct 11, 2:13 PM · Restricted Project
noajshu updated the diff for D111238: [Support][llvm] Add optional libCURL dependency to llvm build configuration.

rebase against main

Mon, Oct 11, 1:57 PM · Restricted Project
noajshu updated the diff for D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library..

rebase against main

Mon, Oct 11, 1:56 PM · Restricted Project, Restricted Project, Restricted Project
noajshu added inline comments to D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library..
Mon, Oct 11, 1:52 PM · Restricted Project, Restricted Project, Restricted Project
noajshu updated the diff for D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library..

Make copies of string reference parameters outside the returned lambda.

Mon, Oct 11, 1:45 PM · Restricted Project, Restricted Project, Restricted Project
noajshu updated the diff for D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool.

Move Debuginfod client library out of Support.
Moved into separate library folder.

Mon, Oct 11, 1:08 PM · Restricted Project

Fri, Oct 8

noajshu added inline comments to D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library..
Fri, Oct 8, 1:50 PM · Restricted Project, Restricted Project, Restricted Project
noajshu updated the diff for D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library..

Add documentation for new parameters to localCache.

Fri, Oct 8, 11:55 AM · Restricted Project, Restricted Project, Restricted Project
noajshu added inline comments to D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library..
Fri, Oct 8, 11:30 AM · Restricted Project, Restricted Project, Restricted Project
noajshu updated the diff for D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library..

Adjust cache name/prefix customization.
Move customization arguments to be first. Convert to twines, remove unnecessary copy. Separate customized file prefix from customized cache name (to avoid chaning any behavior from existing ThinLTO cache).

Fri, Oct 8, 11:28 AM · Restricted Project, Restricted Project, Restricted Project
noajshu updated the diff for D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool.

Remove debuginfod namespace use from llvm-debuginfod-find.

Fri, Oct 8, 10:58 AM · Restricted Project
noajshu updated the diff for D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool.

Rebased following D111371.

Fri, Oct 8, 10:39 AM · Restricted Project
noajshu updated the diff for D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library..

Rebase against main.

Fri, Oct 8, 10:35 AM · Restricted Project, Restricted Project, Restricted Project
noajshu updated the diff for D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library..

Make file prefix and error prefix configurable.
This sets the prefix for existing use to "Thin" to avoid chaning the behavior.

Fri, Oct 8, 10:23 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Oct 7

noajshu removed a reviewer for D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.: chandlerc.
Thu, Oct 7, 8:19 PM · Restricted Project, Restricted Project, Restricted Project
noajshu added a comment to D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library..

@MaskRay Thank you for pointing this out. I just added this!
The use case is a Debuginfod client implementation.
The AssetCache in the debuginfod client revision will be replaced by the localCache that was implemented for ThinLTO, after this revision to move the caching to Support.
ThinLTO's caching code has advantages over our own, such as the tweaks for Windows compatibility (example).

Thu, Oct 7, 6:47 PM · Restricted Project, Restricted Project, Restricted Project
noajshu added reviewers for D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.: phosek, pcc, tejohnson, chandlerc.
Thu, Oct 7, 5:45 PM · Restricted Project, Restricted Project, Restricted Project
noajshu requested review of D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library..
Thu, Oct 7, 5:43 PM · Restricted Project, Restricted Project, Restricted Project
noajshu updated the diff for D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool.

eliminate http and debuginfod namespaces
put everything in llvm:: namespace and rename symbols (e.g. get -> httpGet) for clarity. A few miscellaneous style updates.

Thu, Oct 7, 1:04 PM · Restricted Project
noajshu added inline comments to D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool.
Thu, Oct 7, 10:23 AM · Restricted Project
noajshu updated the diff for D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool.

Updating to meet conventions
Added license + descriptive headers to new source files, replaced enum with enum class, remove namespace nesting.

Thu, Oct 7, 10:16 AM · Restricted Project

Wed, Oct 6

noajshu updated the diff for D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool.

Add missing newlines
Added needed newlines at end of files

Wed, Oct 6, 3:15 PM · Restricted Project
noajshu updated the diff for D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool.

Add lit test requirement
Add REQUIRES: debuginfod_client so that llvm-debuginfod-find only runs when client is built.

Wed, Oct 6, 3:10 PM · Restricted Project
noajshu added reviewers for D111238: [Support][llvm] Add optional libCURL dependency to llvm build configuration: haowei, leonardchan, gulfem.
Wed, Oct 6, 1:50 PM · Restricted Project
noajshu added reviewers for D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool: haowei, leonardchan, gulfem.
Wed, Oct 6, 1:50 PM · Restricted Project
noajshu added a reviewer for D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool: phosek.
Wed, Oct 6, 1:39 PM · Restricted Project
noajshu added a reviewer for D111238: [Support][llvm] Add optional libCURL dependency to llvm build configuration: phosek.
Wed, Oct 6, 1:38 PM · Restricted Project
noajshu requested review of D111252: [llvm] [Support] [Debuginfo] Add http and debuginfod client libraries and llvm-debuginfod-find tool.
Wed, Oct 6, 11:27 AM · Restricted Project
noajshu added inline comments to D111238: [Support][llvm] Add optional libCURL dependency to llvm build configuration.
Wed, Oct 6, 10:12 AM · Restricted Project
noajshu abandoned D111189: Debuginfod Client library based on libcurl.
Wed, Oct 6, 9:46 AM · debug-info, Restricted Project
noajshu requested review of D111238: [Support][llvm] Add optional libCURL dependency to llvm build configuration.
Wed, Oct 6, 9:23 AM · Restricted Project

Tue, Oct 5

noajshu requested review of D111189: Debuginfod Client library based on libcurl.
Tue, Oct 5, 3:26 PM · debug-info, Restricted Project