Fixed the vector type issue that where we used getVectorNumElements() should be replaced by getVectorElementCount() when lowering these intrinsics. This is similar to D94149
Signed-off-by: Eric Tang <tangxingxin1008@gmail.com>
Paths
| Differential D109809
[TargetLowering][RISCV] Fixed a scalable vector issue when lowering [s|u]mul.overflow intrinsics ClosedPublic Authored by tangxingxin1008 on Sep 15 2021, 12:19 AM.
Details Summary Fixed the vector type issue that where we used getVectorNumElements() should be replaced by getVectorElementCount() when lowering these intrinsics. This is similar to D94149 Signed-off-by: Eric Tang <tangxingxin1008@gmail.com>
Diff Detail
Event TimelineHerald added subscribers: vkmr, evandro, luismarques and 24 others. · View Herald TranscriptSep 15 2021, 12:19 AM This revision is now accepted and ready to land.Sep 16 2021, 1:12 AM craig.topper retitled this revision from [RISCV] Fixed a scalable vector issue when lowering [s|u]mul.overflow intrinsics to [TargetLowering][RISCV] Fixed a scalable vector issue when lowering [s|u]mul.overflow intrinsics.Sep 18 2021, 4:11 PM Comment Actions
Yes, I test it on AArch64 sve. Comment Actions LGTM. Would be nice if you added AArch64 test cases that would fail without this patch as well. Herald added a subscriber: achieveartificialintelligence. · View Herald TranscriptSep 23 2021, 12:14 AM Comment Actions Sorry, I don't know how to merged this patch, and get a wrong way to close this revision. Please forgive me for my mistake. This revision is now accepted and ready to land.Nov 16 2021, 2:47 AM Comment Actions Hi @craig.topper @frasercrmck , I don’t have commit access, can you land this patch for me? Thanks. This revision was landed with ongoing or failed builds.Nov 18 2021, 2:25 AM Closed by commit rG9fe6b9e80254: [TargetLowering][RISCV] Fixed a scalable vector issue when lowering [s|u]mul. (authored by tangxingxin1008, committed by frasercrmck). · Explain Why This revision was automatically updated to reflect the committed changes. Comment Actions
Sure, no problem. I even got to learn how to check out and land other people's patches using arcanist, so that was helpful. Thanks for the patch @tangxingxin1008! Comment Actions Hi, the tests added in this commit seem to be failing on some buildbots. E.g. https://lab.llvm.org/buildbot/#/builders/109/builds/26584 Comment Actions
Hey. Sorry! Thanks for reporting this. I did check out, build & test this patch locally before pushing so I'm not sure what I did wrong. I'll see if it's as simple as re-running the update_llc_test_checks.py script. Comment Actions
Just pushed https://reviews.llvm.org/rGe1acbda158b3 which should sort the issue out. Sorry again. Comment Actions
No problem. The tests pass for me locally now, thanks!
Revision Contents
Diff 388137 llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
llvm/test/CodeGen/AArch64/sve-smulo-sdnode.ll
llvm/test/CodeGen/AArch64/sve-umulo-sdnode.ll
llvm/test/CodeGen/RISCV/rvv/smulo-sdnode.ll
llvm/test/CodeGen/RISCV/rvv/umulo-sdnode.ll
|