This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC] Enable track-subreg-liveness by default
ClosedPublic

Authored by qiucf on Aug 29 2021, 7:31 PM.

Details

Summary

Enabling this option helps some MMA related cases to reduce unnecessary copies.

For ppc64-acc-regalloc-bugfix.ll, enabling this option causes failure. D108691 tries to fix it.

For pr45709.ll, the function has attribute optnone, the extra dead lfs was not moved to the bottom block. Dead machine instruction eliminator removes it when optnone disabled.

Diff Detail

Event Timeline

qiucf created this revision.Aug 29 2021, 7:31 PM
qiucf requested review of this revision.Aug 29 2021, 7:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2021, 7:31 PM
jsji resigned from this revision.Jun 2 2022, 7:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 2 2022, 7:48 AM
qiucf updated this revision to Diff 482388.Dec 13 2022, 1:14 AM
qiucf edited the summary of this revision. (Show Details)
qiucf removed a reviewer: jsji.

Thanks for doing this. Could you please show some data about the performance and compile time? Hope they are both good.

Thanks for doing this. Could you please show some data about the performance and compile time? Hope they are both good.

I have not observed build/run performance changes through test suite. Since ISA 3.1 functionalities enhanced by this are not available through optimization, this is expected.

shchenz accepted this revision as: shchenz.Dec 22 2022, 6:27 PM

OK. Thanks for testing. Even though there is no improvement in the test suite, the LIT case changes show good improvement about COPY removal and register allocation. So this makes sense to me.

Please wait for some days in case @nemanjai has comments.

llvm/test/CodeGen/PowerPC/pr45709.ll
43

This may be caused by undef, I can not see any store to the same stack slot before? And the f0 is a dead def, so I think this patch just exposes some dead def removal opportunity after eliminating some copy? It is good if we can improve this in following patch.

This revision is now accepted and ready to land.Dec 22 2022, 6:27 PM
This revision was landed with ongoing or failed builds.Dec 27 2022, 10:09 PM
This revision was automatically updated to reflect the committed changes.