Differential D108459

[clang][CodeGen] Rely on implicitly invalid Address. NFC.
AbandonedPublic
Actions

Authored by wingo on Aug 20 2021, 5:24 AM.

Details

Reviewers

jdoerfert

Summary

Remove explicit uses of Address::invalid in initializers; the default
constructor makes an invalid address.

Depends on D108458.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

wingo created this revision.Aug 20 2021, 5:24 AM

Herald added a subscriber: lxfind. · View Herald TranscriptAug 20 2021, 5:24 AM

wingo requested review of this revision.Aug 20 2021, 5:24 AM

Herald added a reviewer: jdoerfert. · View Herald TranscriptAug 20 2021, 5:24 AM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: cfe-commits, sstefan1. · View Herald Transcript

wingo added a child revision: D108464: [clang][CodeGen] Refactor CreateTempAlloca function nest. NFC..Aug 20 2021, 6:01 AM

Harbormaster completed remote builds in B120537: Diff 367766.Aug 20 2021, 6:39 AM

wingo removed a child revision: D108464: [clang][CodeGen] Refactor CreateTempAlloca function nest. NFC..Aug 23 2021, 7:22 AM

Closing PR as it turns out that I don't need the Address() change for my work; no need to churn here.

Revision Contents
Changeset List

Path

Size

clang/

lib/

CodeGen/

10 lines

9 lines

8 lines

2 lines

20 lines

2 lines

8 lines

2 lines

12 lines

8 lines

8 lines

2 lines

4 lines

2 lines

4 lines

8 lines

38 lines

2 lines

CGOpenMPRuntimeGPU.cpp

10 lines

2 lines

12 lines

35 lines

20 lines

Diff 367766

View Options

clang/lib/CodeGen/CGAtomic.cpp

View Options

clang/lib/CodeGen/CGBlocks.cpp

View Options

clang/lib/CodeGen/CGBuiltin.cpp

View Options

clang/lib/CodeGen/CGCall.h

View Options

clang/lib/CodeGen/CGCall.cpp

View Options

clang/lib/CodeGen/CGCoroutine.cpp

View Options

clang/lib/CodeGen/CGDecl.cpp

View Options

clang/lib/CodeGen/CGException.cpp

View Options

clang/lib/CodeGen/CGExpr.cpp

View Options

clang/lib/CodeGen/CGExprAgg.cpp

View Options

clang/lib/CodeGen/CGExprCXX.cpp

View Options

clang/lib/CodeGen/CGExprComplex.cpp

View Options

clang/lib/CodeGen/CGExprScalar.cpp

View Options

clang/lib/CodeGen/CGObjC.cpp

View Options

clang/lib/CodeGen/CGObjCMac.cpp

View Options

clang/lib/CodeGen/CGOpenMPRuntime.h

View Options

clang/lib/CodeGen/CGOpenMPRuntime.cpp

View Options

clang/lib/CodeGen/CGOpenMPRuntimeGPU.h

View Options

clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp

View Options

clang/lib/CodeGen/CGStmt.cpp

View Options

clang/lib/CodeGen/CGStmtOpenMP.cpp

View Options

clang/lib/CodeGen/CodeGenFunction.h

View Options

clang/lib/CodeGen/TargetInfo.cpp

[clang][CodeGen] Rely on implicitly invalid Address. NFC.AbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 367766

clang/lib/CodeGen/CGAtomic.cpp

clang/lib/CodeGen/CGBlocks.cpp

clang/lib/CodeGen/CGBuiltin.cpp

clang/lib/CodeGen/CGCall.h

clang/lib/CodeGen/CGCall.cpp

clang/lib/CodeGen/CGCoroutine.cpp

clang/lib/CodeGen/CGDecl.cpp

clang/lib/CodeGen/CGException.cpp

clang/lib/CodeGen/CGExpr.cpp

clang/lib/CodeGen/CGExprAgg.cpp

clang/lib/CodeGen/CGExprCXX.cpp

clang/lib/CodeGen/CGExprComplex.cpp

clang/lib/CodeGen/CGExprScalar.cpp

clang/lib/CodeGen/CGObjC.cpp

clang/lib/CodeGen/CGObjCMac.cpp

clang/lib/CodeGen/CGOpenMPRuntime.h

clang/lib/CodeGen/CGOpenMPRuntime.cpp

clang/lib/CodeGen/CGOpenMPRuntimeGPU.h

clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp

clang/lib/CodeGen/CGStmt.cpp

clang/lib/CodeGen/CGStmtOpenMP.cpp

clang/lib/CodeGen/CodeGenFunction.h

clang/lib/CodeGen/TargetInfo.cpp

[clang][CodeGen] Rely on implicitly invalid Address. NFC.
AbandonedPublic
Actions

Revision Contents
Changeset List