This is an archive of the discontinued LLVM Phabricator instance.

Differential D106890

[z/OS] Make MinGlobalAlign consistent with SystemZ
ClosedPublic

Authored by fanbo-meng on Jul 27 2021, 9:47 AM.

Details

Reviewers
abhina.sreeskantharajan
muiez
Jonathan.Crowther
SeanP
Commits
rGa2d4b064644b: [z/OS] Make MinGlobalAlign consistent with SystemZ
Summary

Remove overriding MinGlobalAlign to 0 for z/OS target to be consistent with SystemZ.

Diff Detail

Event Timeline

fanbo-meng requested review of this revision.Jul 27 2021, 9:47 AM
fanbo-meng created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJul 27 2021, 9:47 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
fanbo-meng added reviewers: abhina.sreeskantharajan, muiez, Jonathan.Crowther, SeanP.Jul 27 2021, 9:48 AM
abhina.sreeskantharajan accepted this revision.Jul 27 2021, 10:01 AM

LGTM

This revision is now accepted and ready to land.Jul 27 2021, 10:01 AM
Harbormaster completed remote builds in B116465: Diff 362075.Jul 27 2021, 11:43 AM
Closed by commit rGa2d4b064644b: [z/OS] Make MinGlobalAlign consistent with SystemZ (authored by fanbo-meng). · Explain WhyJul 27 2021, 12:39 PM
This revision was automatically updated to reflect the committed changes.
fanbo-meng added a commit: rGa2d4b064644b: [z/OS] Make MinGlobalAlign consistent with SystemZ.

Revision Contents

PathSize
clang/
lib/
Basic/
Targets/
1 line

Diff 362139

clang/lib/Basic/Targets/OSTargets.h

Show First 20 Lines • Show All 790 Lines • ▼ Show 20 Linespublic:
ZOSTargetInfo(const llvm::Triple &Triple, const TargetOptions &Opts) ZOSTargetInfo(const llvm::Triple &Triple, const TargetOptions &Opts)
: OSTargetInfo<Target>(Triple, Opts) { : OSTargetInfo<Target>(Triple, Opts) {
this->WCharType = TargetInfo::UnsignedInt; this->WCharType = TargetInfo::UnsignedInt;
this->MaxAlignedAttribute = 128; this->MaxAlignedAttribute = 128;
this->UseBitFieldTypeAlignment = false; this->UseBitFieldTypeAlignment = false;
this->UseZeroLengthBitfieldAlignment = true; this->UseZeroLengthBitfieldAlignment = true;
this->UseLeadingZeroLengthBitfield = false; this->UseLeadingZeroLengthBitfield = false;
this->ZeroLengthBitfieldBoundary = 32; this->ZeroLengthBitfieldBoundary = 32;
this->MinGlobalAlign = 0;
this->DefaultAlignForAttributeAligned = 128; this->DefaultAlignForAttributeAligned = 128;
} }
}; };
void addWindowsDefines(const llvm::Triple &Triple, const LangOptions &Opts, void addWindowsDefines(const llvm::Triple &Triple, const LangOptions &Opts,
MacroBuilder &Builder); MacroBuilder &Builder);
// Windows target // Windows target
▲ Show 20 Lines • Show All 160 Lines • Show Last 20 Lines