User Details
User Details
- User Since
- Nov 21 2019, 1:10 PM (211 w, 33 m)
Jun 23 2021
Jun 23 2021
Jonathan.Crowther requested review of D104814: [libc++] Remove unnecessary reinterpret_cast from typeinfo.
Jun 23 2021, 1:38 PM · Restricted Project
May 19 2021
May 19 2021
Jonathan.Crowther added a comment to D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime.
If you are going to implement these, I highly recommend that you split the implementation from the main Itanium implementaion.
An ARM contributor has signed up the work to extract the ARM EH impl since it is so different.
I am feeling similarly for z/OS. Coupling z/OS specific logic makes the generic Itanium implementation much more difficult.
May 12 2021
May 12 2021
Jonathan.Crowther updated the diff for D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime.
Addressed comments
May 5 2021
May 5 2021
Jonathan.Crowther added a comment to D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime.
Ping
Jonathan.Crowther added reviewers for D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime: abhina.sreeskantharajan, anirudhp. Jonathan.Crowther removed 1 blocking reviewer(s) for D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime: Restricted Project.
LGTM
May 5 2021, 6:20 AM · Restricted Project
Apr 19 2021
Apr 19 2021
LGTM
Apr 16 2021
Apr 16 2021
LGTM
Apr 16 2021, 12:08 PM · Restricted Project
Jonathan.Crowther accepted D99889: [AsmParser][ms][X86] Fix possible misbehaviour in parsing of special tokens at start of string..
LGTM
Apr 16 2021, 11:47 AM · Restricted Project
Apr 15 2021
Apr 15 2021
Jonathan.Crowther updated the diff for D100488: [SystemZ][z/OS] Add IsText Argument to GetFile and GetFileOrSTDIN.
No updates, just want to kick off the CI again.
Apr 14 2021
Apr 14 2021
Apr 13 2021
Apr 13 2021
Jonathan.Crowther added inline comments to D99889: [AsmParser][ms][X86] Fix possible misbehaviour in parsing of special tokens at start of string..
Apr 13 2021, 12:10 PM · Restricted Project
Jonathan.Crowther added inline comments to D100130: [SystemZ][z/OS][Windows] Add new functions that set Text/Binary mode for Stdin and Stdout based on OpenFlags.
Apr 13 2021, 11:37 AM · Restricted Project
Apr 5 2021
Apr 5 2021
Oct 22 2020
Oct 22 2020
Jonathan.Crowther updated the diff for D89801: [SystemZ][z/OS] Set short-enums as the default for z/OS.
Forgot to set the repository for my last patch. No code changes.
Oct 22 2020, 11:10 AM · Restricted Project
Oct 21 2020
Oct 21 2020
Jonathan.Crowther updated the diff for D89801: [SystemZ][z/OS] Set short-enums as the default for z/OS.
Added a test for -fno-short-enums
Oct 21 2020, 12:28 PM · Restricted Project
Oct 20 2020
Oct 20 2020
Jonathan.Crowther retitled D89801: [SystemZ][z/OS] Set short-enums as the default for z/OS from [SystemZ][ZOS] Set short-enums as the default for z/OS to [SystemZ][z/OS] Set short-enums as the default for z/OS.
Oct 20 2020, 8:50 AM · Restricted Project
Jonathan.Crowther requested review of D89801: [SystemZ][z/OS] Set short-enums as the default for z/OS.
Oct 20 2020, 8:48 AM · Restricted Project
Jan 20 2020
Jan 20 2020
Jonathan.Crowther updated the diff for D72736: [AIX] Add improved interface for retrieving load module paths.
Addressed comments by moving getLoadModuleFilnameForFunction to llvm/lib/Support/SystemUtils.cpp
Jan 14 2020
Jan 14 2020