This patch allows MMA built-ins on PowerPC to accept restrict
and volatile qualified pointers.
Details
- Reviewers
nemanjai stefanp - Group Reviewers
Restricted Project - Commits
- rG564e082d0954: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Event Timeline
clang/lib/Sema/SemaChecking.cpp | ||
---|---|---|
7444–7447 | Parentheses here seem superfluous. Also, am I reading this correctly? Does this mean that if the argument type is __restrict anything, we are accepting it? That is not the intent here. We don't want to accept just ANY restrict qualified type. We want to accept either: ExpectedType or ExpectedType __restrict. |
clang/lib/Sema/SemaChecking.cpp | ||
---|---|---|
7446 | I am not in favour of the "single use lambda" idiom. We don't really need a lambda here. Also, this will handle restrict, but it won't handle const/volatile which also shouldn't be a problem for the loads. I think we should do the following:
|
I am not in favour of the "single use lambda" idiom. We don't really need a lambda here. Also, this will handle restrict, but it won't handle const/volatile which also shouldn't be a problem for the loads.
I think we should do the following: