This feature requires support of __opencl_c_images, so diagnostics for that is provided as well.
Also, ensure that cl_khr_3d_image_writes feature macro is set to the same value.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Event Timeline
clang/lib/Sema/SemaType.cpp | ||
---|---|---|
1734–1736 | Note this. Is it OK to refer to API spec here? |
clang/include/clang/Basic/DiagnosticSemaKinds.td | ||
---|---|---|
10090 | it seems like we keep expanding similar diagnostics which flows against the design policy. Could you try to unify with err_opencl_double_requires_extension or even with err_opencl_requires_extension? Perhaps we could create a mechanism to print custom strings for extensions that alias features or it can be done in the follow-up patches too? | |
clang/lib/Sema/SemaType.cpp | ||
1734–1736 | I am guessing you want to explain that corresponding features and extensions must be in sync? It makes sense, but it feels like we are missing something in the kernel language spec then... |
Unify with err_opencl_requires_extension. Infrastructure for getting aliased extensions seems to messy and doesn't seem worth it yet since there are only two cases of such functionality (fp64 and 3d image writes) :(
it seems like we keep expanding similar diagnostics which flows against the design policy. Could you try to unify with err_opencl_double_requires_extension or even with err_opencl_requires_extension?
Perhaps we could create a mechanism to print custom strings for extensions that alias features or it can be done in the follow-up patches too?