Page MenuHomePhabricator

svenvh (Sven van Haastregt)
GPU Compiler Engineer at ARM

Projects

User does not belong to any projects.

User Details

User Since
Sep 28 2016, 4:40 AM (146 w, 5 d)

Recent Activity

Fri, Jul 19

svenvh committed rGe9e59ad79ffd: [OpenCL] Define CLK_NULL_EVENT without cast (authored by svenvh).
[OpenCL] Define CLK_NULL_EVENT without cast
Fri, Jul 19, 2:14 AM
svenvh committed rL366546: [OpenCL] Define CLK_NULL_EVENT without cast.
[OpenCL] Define CLK_NULL_EVENT without cast
Fri, Jul 19, 2:11 AM
svenvh closed D63876: [OpenCL] Define CLK_NULL_EVENT without cast.
Fri, Jul 19, 2:11 AM · Restricted Project, Restricted Project

Thu, Jul 18

svenvh added a comment to D63434: [OpenCL] Add generic type handling for builtin functions.

It seems Phabricator got a bit confused as the latest diff did not include full context (use git diff -U999999).

Thu, Jul 18, 6:52 AM · Restricted Project, Restricted Project
svenvh accepted D64867: [OpenCL] Update comments/diagnostics to refer to C++ for OpenCL mode.

LGTM

Thu, Jul 18, 1:42 AM · Restricted Project

Wed, Jul 17

svenvh added a comment to D64867: [OpenCL] Update comments/diagnostics to refer to C++ for OpenCL mode.

It would be good if you could provide some motivation for this change in the description of this review.

Wed, Jul 17, 10:33 AM · Restricted Project

Wed, Jul 3

svenvh added a comment to D63876: [OpenCL] Define CLK_NULL_EVENT without cast.

btw, there seems to be the same issue with reserve_id_t?

Wed, Jul 3, 3:33 AM · Restricted Project, Restricted Project
svenvh committed rG1bc2cccf18be: Remove some autoconf references from docs and comments (authored by svenvh).
Remove some autoconf references from docs and comments
Wed, Jul 3, 3:04 AM
svenvh committed rL365013: Remove some autoconf references from docs and comments.
Remove some autoconf references from docs and comments
Wed, Jul 3, 2:58 AM
svenvh closed D63608: Remove some autoconf references from docs and comments.
Wed, Jul 3, 2:58 AM · Restricted Project

Thu, Jun 27

svenvh created D63876: [OpenCL] Define CLK_NULL_EVENT without cast.
Thu, Jun 27, 6:41 AM · Restricted Project, Restricted Project
svenvh updated the diff for D63608: Remove some autoconf references from docs and comments.

Dropping changes to Triple.h.

Thu, Jun 27, 3:10 AM · Restricted Project

Wed, Jun 26

svenvh committed rG1006a068c63f: [OpenCL] Improve diagnostic for placement new (authored by svenvh).
[OpenCL] Improve diagnostic for placement new
Wed, Jun 26, 6:34 AM
svenvh committed rL364423: [OpenCL] Improve diagnostic for placement new.
[OpenCL] Improve diagnostic for placement new
Wed, Jun 26, 6:33 AM
svenvh closed D63561: [OpenCL] Improve diagnostic for placement new.
Wed, Jun 26, 6:33 AM · Restricted Project, Restricted Project

Mon, Jun 24

svenvh added inline comments to D63256: [OpenCL] Split type and macro definitions into opencl-c-base.h.
Mon, Jun 24, 3:10 AM · Restricted Project, Restricted Project
svenvh committed rGb502a44110ff: [OpenCL] Restore ATOMIC_VAR_INIT (authored by svenvh).
[OpenCL] Restore ATOMIC_VAR_INIT
Mon, Jun 24, 3:08 AM
svenvh committed rG853dfab799f1: [OpenCL] Remove more duplicates from opencl-c.h (authored by svenvh).
[OpenCL] Remove more duplicates from opencl-c.h
Mon, Jun 24, 3:07 AM
svenvh committed rL364174: [OpenCL] Restore ATOMIC_VAR_INIT.
[OpenCL] Restore ATOMIC_VAR_INIT
Mon, Jun 24, 3:07 AM
svenvh committed rL364173: [OpenCL] Remove more duplicates from opencl-c.h.
[OpenCL] Remove more duplicates from opencl-c.h
Mon, Jun 24, 3:07 AM

Jun 21 2019

svenvh added a comment to D59673: [Clang] Harmonize Split DWARF options with llc.

As a followup to r363496, I've added llvm-dwarfdump as a clang test dependency in r364021.

Jun 21 2019, 3:33 AM · Restricted Project, Restricted Project
svenvh committed rGe65fa21cf01c: [cmake] Add llvm-dwarfdump to clang test dependencies (authored by svenvh).
[cmake] Add llvm-dwarfdump to clang test dependencies
Jun 21 2019, 3:25 AM
svenvh committed rG772a7a7680df: [OpenCL] Remove duplicate read_image declarations (authored by svenvh).
[OpenCL] Remove duplicate read_image declarations
Jun 21 2019, 3:25 AM
svenvh committed rL364021: [cmake] Add llvm-dwarfdump to clang test dependencies.
[cmake] Add llvm-dwarfdump to clang test dependencies
Jun 21 2019, 3:25 AM
svenvh committed rL364020: [OpenCL] Remove duplicate read_image declarations.
[OpenCL] Remove duplicate read_image declarations
Jun 21 2019, 3:25 AM

Jun 20 2019

svenvh added inline comments to D63608: Remove some autoconf references from docs and comments.
Jun 20 2019, 9:47 AM · Restricted Project
svenvh created D63608: Remove some autoconf references from docs and comments.
Jun 20 2019, 9:30 AM · Restricted Project

Jun 19 2019

svenvh created D63561: [OpenCL] Improve diagnostic for placement new.
Jun 19 2019, 8:47 AM · Restricted Project, Restricted Project
svenvh committed rGaf1c230e70ae: [OpenCL] Split type and macro definitions into opencl-c-base.h (authored by svenvh).
[OpenCL] Split type and macro definitions into opencl-c-base.h
Jun 19 2019, 5:46 AM
svenvh committed rL363794: [OpenCL] Split type and macro definitions into opencl-c-base.h.
[OpenCL] Split type and macro definitions into opencl-c-base.h
Jun 19 2019, 5:45 AM
svenvh closed D63256: [OpenCL] Split type and macro definitions into opencl-c-base.h.
Jun 19 2019, 5:45 AM · Restricted Project, Restricted Project

Jun 17 2019

svenvh added a comment to D62849: Moving OpenCLBuiltins.td and remove unused include.

Recommitted in r363541.

Jun 17 2019, 3:06 AM · Restricted Project
svenvh committed rG9d81915fcaab: Recommit [OpenCL] Move OpenCLBuiltins.td and remove unused include (authored by svenvh).
Recommit [OpenCL] Move OpenCLBuiltins.td and remove unused include
Jun 17 2019, 3:04 AM
svenvh committed rL363541: Recommit [OpenCL] Move OpenCLBuiltins.td and remove unused include.
Recommit [OpenCL] Move OpenCLBuiltins.td and remove unused include
Jun 17 2019, 3:04 AM

Jun 14 2019

svenvh updated the diff for D63256: [OpenCL] Split type and macro definitions into opencl-c-base.h.

Change IncludeDefaultHeader and DeclareOpenCLBuiltins logic as per @asavonic's comments. Also extend test/SemaOpenCL/fdeclare-opencl-builtins.cl to test the interplay of both options.

Jun 14 2019, 9:48 AM · Restricted Project, Restricted Project
svenvh committed rGe5bd808c3e25: Revert "[OpenCL] Move OpenCLBuiltins.td and remove unused include" (authored by svenvh).
Revert "[OpenCL] Move OpenCLBuiltins.td and remove unused include"
Jun 14 2019, 5:14 AM
svenvh committed rL363376: Revert "[OpenCL] Move OpenCLBuiltins.td and remove unused include".
Revert "[OpenCL] Move OpenCLBuiltins.td and remove unused include"
Jun 14 2019, 5:14 AM
svenvh added a comment to D62849: Moving OpenCLBuiltins.td and remove unused include.

Sorry for the breakage and thanks for reporting!

Jun 14 2019, 5:14 AM · Restricted Project

Jun 13 2019

svenvh created D63256: [OpenCL] Split type and macro definitions into opencl-c-base.h.
Jun 13 2019, 5:39 AM · Restricted Project, Restricted Project
svenvh committed rG95a9ee5e2f25: [OpenCL] Move OpenCLBuiltins.td and remove unused include (authored by svenvh).
[OpenCL] Move OpenCLBuiltins.td and remove unused include
Jun 13 2019, 2:52 AM
svenvh committed rL363242: [OpenCL] Move OpenCLBuiltins.td and remove unused include.
[OpenCL] Move OpenCLBuiltins.td and remove unused include
Jun 13 2019, 2:52 AM
svenvh closed D62849: Moving OpenCLBuiltins.td and remove unused include.
Jun 13 2019, 2:52 AM · Restricted Project
svenvh accepted D62849: Moving OpenCLBuiltins.td and remove unused include.

LGTM.

Jun 13 2019, 2:45 AM · Restricted Project

Jun 11 2019

svenvh added inline comments to D62849: Moving OpenCLBuiltins.td and remove unused include.
Jun 11 2019, 7:14 AM · Restricted Project

Jun 3 2019

svenvh committed rG79a222fcf8c4: [OpenCL] Declare builtin functions using TableGen (authored by svenvh).
[OpenCL] Declare builtin functions using TableGen
Jun 3 2019, 2:38 AM
svenvh committed rL362371: [OpenCL] Declare builtin functions using TableGen.
[OpenCL] Declare builtin functions using TableGen
Jun 3 2019, 2:38 AM
svenvh closed D60763: Prototype OpenCL BIFs using Tablegen.
Jun 3 2019, 2:38 AM · Restricted Project, Restricted Project

May 31 2019

svenvh added a comment to D60763: Prototype OpenCL BIFs using Tablegen.

Looks good overall, I'd like to propose a few more minor changes to this patch before landing:

  • isPointer can be a bit / bool instead of an int / unsigned.
  • Renaming the command line option from -fadd-declare-builtins to -fdeclare-opencl-builtins should hopefully convey the meaning of the option a bit better.
  • Drop the spurious ; in OCL2Qual.
  • Emit spaces instead of tabs for OCL2Qual, like the rest of the generated file.
  • Bring the format of OpenCL spec references into alignment with the rest of clang (e.g. OpenCL v2.0 s9.17.3).
  • Adding (experimental) to the help text of -fdeclare-opencl-builtins.
May 31 2019, 6:24 AM · Restricted Project, Restricted Project

May 30 2019

svenvh added inline comments to D60763: Prototype OpenCL BIFs using Tablegen.
May 30 2019, 9:35 AM · Restricted Project, Restricted Project
svenvh accepted D62657: [OpenCL] Fix OpenCL/SPIR version metadata.

LGTM!

May 30 2019, 6:55 AM · Restricted Project
svenvh committed rGce127bb60ea1: [OpenCL] Support logical vector operators in C++ mode (authored by svenvh).
[OpenCL] Support logical vector operators in C++ mode
May 30 2019, 5:37 AM
svenvh committed rC362087: [OpenCL] Support logical vector operators in C++ mode.
[OpenCL] Support logical vector operators in C++ mode
May 30 2019, 5:36 AM
svenvh committed rL362087: [OpenCL] Support logical vector operators in C++ mode.
[OpenCL] Support logical vector operators in C++ mode
May 30 2019, 5:36 AM
svenvh closed D62588: [OpenCL] Support logical vector operators in C++ mode.
May 30 2019, 5:36 AM · Restricted Project, Restricted Project

May 29 2019

svenvh accepted D62335: [OpenCL][PR41963] Add overloads of old atomics with generic pointer type in C++ mode .

LGTM, please address style issue before committing.

May 29 2019, 8:44 AM · Restricted Project
svenvh created D62588: [OpenCL] Support logical vector operators in C++ mode.
May 29 2019, 6:47 AM · Restricted Project, Restricted Project

May 23 2019

svenvh committed rG50434e8df0a3: Enable queue_t and clk_event_t comparisons in C++ mode (authored by svenvh).
Enable queue_t and clk_event_t comparisons in C++ mode
May 23 2019, 2:18 AM
svenvh committed rC361467: Enable queue_t and clk_event_t comparisons in C++ mode.
Enable queue_t and clk_event_t comparisons in C++ mode
May 23 2019, 2:17 AM
svenvh committed rL361467: Enable queue_t and clk_event_t comparisons in C++ mode.
Enable queue_t and clk_event_t comparisons in C++ mode
May 23 2019, 2:17 AM
svenvh closed D62208: [OpenCL] Enable queue_t and clk_event_t comparisons in C++ mode.
May 23 2019, 2:17 AM · Restricted Project, Restricted Project

May 22 2019

svenvh committed rGe518bb43119b: [OpenCL] Support pipe keyword in C++ mode (authored by svenvh).
[OpenCL] Support pipe keyword in C++ mode
May 22 2019, 6:13 AM
svenvh committed rC361382: [OpenCL] Support pipe keyword in C++ mode.
[OpenCL] Support pipe keyword in C++ mode
May 22 2019, 6:13 AM
svenvh committed rL361382: [OpenCL] Support pipe keyword in C++ mode.
[OpenCL] Support pipe keyword in C++ mode
May 22 2019, 6:13 AM
svenvh closed D62181: [OpenCL] Support pipe keyword in C++ mode.
May 22 2019, 6:13 AM · Restricted Project

May 21 2019

svenvh created D62208: [OpenCL] Enable queue_t and clk_event_t comparisons in C++ mode.
May 21 2019, 10:07 AM · Restricted Project, Restricted Project
svenvh created D62181: [OpenCL] Support pipe keyword in C++ mode.
May 21 2019, 2:56 AM · Restricted Project

May 17 2019

svenvh committed rG151d4f88dc99: [NFC] Fix line endings in OpenCL tests (authored by svenvh).
[NFC] Fix line endings in OpenCL tests
May 17 2019, 2:24 AM
svenvh committed rL361004: [NFC] Fix line endings in OpenCL tests.
[NFC] Fix line endings in OpenCL tests
May 17 2019, 2:23 AM
svenvh committed rC361004: [NFC] Fix line endings in OpenCL tests.
[NFC] Fix line endings in OpenCL tests
May 17 2019, 2:23 AM

May 13 2019

svenvh added a comment to D53023: Prototype OpenCL BIFs using Tablegen.

LGTM! @joey, any idea when it will be landed?

May 13 2019, 7:00 AM

May 9 2019

svenvh added a comment to D59107: [Support] Add error handling to sys::Process::getPageSize()..

fwiw, I have updated two more uses of getPageSize() to fix LLVM_USE_PERF builds in r360322.

May 9 2019, 3:29 AM · Restricted Project
svenvh committed rGad9c7e0789eb: Fix LLVM_USE_PERF build after getPageSize change (authored by svenvh).
Fix LLVM_USE_PERF build after getPageSize change
May 9 2019, 3:10 AM
svenvh committed rL360322: Fix LLVM_USE_PERF build after getPageSize change.
Fix LLVM_USE_PERF build after getPageSize change
May 9 2019, 3:09 AM

Apr 26 2019

svenvh committed rG66f612601dc9: [InferAddressSpaces] Add AS parameter to the pass factory (authored by svenvh).
[InferAddressSpaces] Add AS parameter to the pass factory
Apr 26 2019, 2:21 AM
svenvh committed rL359290: [InferAddressSpaces] Add AS parameter to the pass factory.
[InferAddressSpaces] Add AS parameter to the pass factory
Apr 26 2019, 2:21 AM
svenvh closed D60602: [InferAddressSpaces] Add AS parameter to the pass factory.
Apr 26 2019, 2:21 AM · Restricted Project

Apr 17 2019

svenvh committed rGc9945cca0321: [libclang] Expose ext_vector_type (authored by svenvh).
[libclang] Expose ext_vector_type
Apr 17 2019, 2:07 AM
svenvh committed rC358566: [libclang] Expose ext_vector_type.
[libclang] Expose ext_vector_type
Apr 17 2019, 2:07 AM
svenvh committed rL358566: [libclang] Expose ext_vector_type.
[libclang] Expose ext_vector_type
Apr 17 2019, 2:07 AM
svenvh closed D60775: [libclang] Expose ext_vector_type.
Apr 17 2019, 2:07 AM · Restricted Project, Restricted Project

Apr 16 2019

svenvh created D60775: [libclang] Expose ext_vector_type.
Apr 16 2019, 7:17 AM · Restricted Project, Restricted Project

Feb 15 2019

svenvh accepted D58179: [OpenCL][PR40707] Allow OpenCL C types in C++ mode.

LGTM!

Feb 15 2019, 3:15 AM

Feb 11 2019

svenvh committed rGdc2c93017f8b: [libclang] Add attribute support for 'convergent'. (authored by svenvh).
[libclang] Add attribute support for 'convergent'.
Feb 11 2019, 3:01 AM
svenvh committed rL353690: [libclang] Add attribute support for 'convergent'..
[libclang] Add attribute support for 'convergent'.
Feb 11 2019, 3:01 AM
svenvh committed rC353690: [libclang] Add attribute support for 'convergent'..
[libclang] Add attribute support for 'convergent'.
Feb 11 2019, 3:01 AM

Feb 7 2019

svenvh accepted D57824: [OpenCL][PR40603] In C++ preserve backwards compatibility with OpenCL C v2.0.

Even nicer to have it only inside the extension logic indeed.

Feb 7 2019, 8:12 AM · Restricted Project
svenvh added inline comments to D57824: [OpenCL][PR40603] In C++ preserve backwards compatibility with OpenCL C v2.0.
Feb 7 2019, 2:58 AM · Restricted Project

Nov 14 2018

svenvh committed rL346844: Print newline after banner for ModulePass.
Print newline after banner for ModulePass
Nov 14 2018, 2:08 AM

Nov 1 2018

svenvh committed rL345825: Allow clk_event_t comparisons.
Allow clk_event_t comparisons
Nov 1 2018, 5:45 AM
svenvh committed rC345825: Allow clk_event_t comparisons.
Allow clk_event_t comparisons
Nov 1 2018, 5:45 AM
svenvh closed D53871: [OpenCL] Allow clk_event_t comparisons.
Nov 1 2018, 5:45 AM

Oct 30 2018

svenvh created D53871: [OpenCL] Allow clk_event_t comparisons.
Oct 30 2018, 8:34 AM

Oct 29 2018

svenvh added a comment to D53705: [OpenCL] Postpone PSV address space diagnostic.

Unlikely, since address spaces are provided in a different way in OpenCL C++ vs OpenCL C.

Oct 29 2018, 10:41 AM · Restricted Project

Oct 25 2018

svenvh created D53705: [OpenCL] Postpone PSV address space diagnostic.
Oct 25 2018, 8:26 AM · Restricted Project

Oct 2 2018

svenvh added a comment to D43783: [OpenCL] Remove block invoke function from emitted block literal struct.

Reverted in r343582, test added in r343583.

Oct 2 2018, 6:06 AM
svenvh committed rL343583: [OpenCL] Add block argument CodeGen test.
[OpenCL] Add block argument CodeGen test
Oct 2 2018, 6:04 AM
svenvh committed rC343583: [OpenCL] Add block argument CodeGen test.
[OpenCL] Add block argument CodeGen test
Oct 2 2018, 6:04 AM
svenvh committed rC343582: Revert r326937 "[OpenCL] Remove block invoke function from emitted block….
Revert r326937 "[OpenCL] Remove block invoke function from emitted block…
Oct 2 2018, 6:04 AM
svenvh committed rL343582: Revert r326937 "[OpenCL] Remove block invoke function from emitted block….
Revert r326937 "[OpenCL] Remove block invoke function from emitted block…
Oct 2 2018, 6:04 AM

Sep 28 2018

svenvh committed rL343316: Fix and modernize StringMatcher comment; NFC.
Fix and modernize StringMatcher comment; NFC
Sep 28 2018, 6:33 AM