Page MenuHomePhabricator

svenvh (Sven van Haastregt)
GPU Compiler Engineer at ARM

Projects

User does not belong to any projects.

User Details

User Since
Sep 28 2016, 4:40 AM (155 w, 5 d)

Recent Activity

Thu, Sep 19

svenvh committed rGed69faa01bff: [OpenCL] Add version handling and add vector ld/st builtins (authored by svenvh).
[OpenCL] Add version handling and add vector ld/st builtins
Thu, Sep 19, 6:42 AM
svenvh committed rL372321: [OpenCL] Add version handling and add vector ld/st builtins.
[OpenCL] Add version handling and add vector ld/st builtins
Thu, Sep 19, 6:41 AM
svenvh closed D63504: [OpenCL] Add version handling and add vector ld/st builtins.
Thu, Sep 19, 6:41 AM · Restricted Project, Restricted Project

Wed, Sep 18

svenvh created D67714: [OpenCL] Add -Wconversion to fdeclare-opencl-builtins test.
Wed, Sep 18, 8:48 AM · Restricted Project
svenvh created D67713: [OpenCL] Add image query builtin functions.
Wed, Sep 18, 8:48 AM · Restricted Project
svenvh added inline comments to D63504: [OpenCL] Add version handling and add vector ld/st builtins.
Wed, Sep 18, 2:22 AM · Restricted Project, Restricted Project

Tue, Sep 17

svenvh committed rG47e95ff8133f: [OpenCL] Tidy up some comments; NFC (authored by svenvh).
[OpenCL] Tidy up some comments; NFC
Tue, Sep 17, 6:33 AM
svenvh committed rL372119: [OpenCL] Tidy up some comments; NFC.
[OpenCL] Tidy up some comments; NFC
Tue, Sep 17, 6:32 AM

Mon, Sep 9

svenvh committed rG783fc95f3eed: Merge note_ovl_builtin_candidate diagnostics; NFC (authored by svenvh).
Merge note_ovl_builtin_candidate diagnostics; NFC
Mon, Sep 9, 7:39 AM
svenvh committed rL371403: Merge note_ovl_builtin_candidate diagnostics; NFC.
Merge note_ovl_builtin_candidate diagnostics; NFC
Mon, Sep 9, 7:37 AM

Fri, Sep 6

svenvh updated the diff for D63504: [OpenCL] Add version handling and add vector ld/st builtins.

Rebasing and improving comments.

Fri, Sep 6, 10:27 AM · Restricted Project, Restricted Project
svenvh commandeered D63504: [OpenCL] Add version handling and add vector ld/st builtins.
Fri, Sep 6, 10:23 AM · Restricted Project, Restricted Project

Thu, Sep 5

svenvh committed rL371069: Fix capitalization and HTML list closure issues.
Fix capitalization and HTML list closure issues
Thu, Sep 5, 6:49 AM
svenvh committed rG988f1e3e32a9: [OpenCL] Add image type handling for builtins (authored by svenvh).
[OpenCL] Add image type handling for builtins
Thu, Sep 5, 3:02 AM
svenvh committed rL371046: [OpenCL] Add image type handling for builtins.
[OpenCL] Add image type handling for builtins
Thu, Sep 5, 3:00 AM
svenvh closed D63480: [OpenCL] Add image type handling for builtin functions.
Thu, Sep 5, 3:00 AM · Restricted Project, Restricted Project

Wed, Sep 4

svenvh added a comment to D64146: [Clang Interpreter] Initial patch for the constexpr interpreter.

Shared library builds seem to be broken indeed. I tried fixing by adding Support and clangAST as dependencies for clangInterp, but that creates a cyclic dependency between clangAST <-> clangInterp. Which makes me wonder whether clangInterp should be a separate library or be part of clangAST?

Wed, Sep 4, 3:40 AM · Restricted Project, Restricted Project

Tue, Sep 3

svenvh committed rG92b2be1e9232: [OpenCL] Drop spurious semicolon in generated file; NFC (authored by svenvh).
[OpenCL] Drop spurious semicolon in generated file; NFC
Tue, Sep 3, 4:23 AM
svenvh committed rL370744: [OpenCL] Drop spurious semicolon in generated file; NFC.
[OpenCL] Drop spurious semicolon in generated file; NFC
Tue, Sep 3, 4:22 AM
svenvh updated the diff for D63480: [OpenCL] Add image type handling for builtin functions.

Rebase, add other image read and write builtins, add some tests.

Tue, Sep 3, 3:30 AM · Restricted Project, Restricted Project
svenvh committed rL370713: Request commit access for svenvh.
Request commit access for svenvh
Tue, Sep 3, 2:06 AM

Mon, Sep 2

svenvh added inline comments to D63480: [OpenCL] Add image type handling for builtin functions.
Mon, Sep 2, 8:21 AM · Restricted Project, Restricted Project

Fri, Aug 30

svenvh committed rL370470: Fix some typos in devmtg/2019-10.
Fix some typos in devmtg/2019-10
Fri, Aug 30, 5:55 AM
svenvh committed rGfd66c8bf072d: vim: add `immarg` keyword (authored by svenvh).
vim: add `immarg` keyword
Fri, Aug 30, 1:56 AM
svenvh committed rL370443: vim: add `immarg` keyword.
vim: add `immarg` keyword
Fri, Aug 30, 1:56 AM

Thu, Aug 29

svenvh committed rGa280b63ead9e: [OpenCL] Fix diagnosing enqueue_kernel call with too few args (authored by svenvh).
[OpenCL] Fix diagnosing enqueue_kernel call with too few args
Thu, Aug 29, 3:22 AM
svenvh committed rL370322: [OpenCL] Fix diagnosing enqueue_kernel call with too few args.
[OpenCL] Fix diagnosing enqueue_kernel call with too few args
Thu, Aug 29, 3:20 AM
svenvh closed D66883: PR42045: Fix diagnosing enqueue_kernel call with too few args.
Thu, Aug 29, 3:19 AM · Restricted Project, Restricted Project

Wed, Aug 28

svenvh created D66883: PR42045: Fix diagnosing enqueue_kernel call with too few args.
Wed, Aug 28, 7:18 AM · Restricted Project, Restricted Project

Aug 21 2019

svenvh updated the diff for D63480: [OpenCL] Add image type handling for builtin functions.
  • Use StringSwitch in some places
  • Improve comments
  • clang-format
  • Use an enum instead of an unsigned to represent qualifiers.
Aug 21 2019, 2:13 PM · Restricted Project, Restricted Project
svenvh commandeered D63480: [OpenCL] Add image type handling for builtin functions.
Aug 21 2019, 2:05 PM · Restricted Project, Restricted Project

Aug 20 2019

svenvh committed rGcc0ba28cf07f: [OpenCL] Add const, volatile and pointer builtin handling (authored by svenvh).
[OpenCL] Add const, volatile and pointer builtin handling
Aug 20 2019, 5:21 AM
svenvh committed rL369373: [OpenCL] Add const, volatile and pointer builtin handling.
[OpenCL] Add const, volatile and pointer builtin handling
Aug 20 2019, 5:21 AM
svenvh closed D63442: [OpenCL] Add const, volatile and pointer handling for builtin functions.
Aug 20 2019, 5:21 AM · Restricted Project, Restricted Project

Aug 19 2019

svenvh accepted D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode.

LGTM!

Aug 19 2019, 9:37 AM · Restricted Project
svenvh added inline comments to D63442: [OpenCL] Add const, volatile and pointer handling for builtin functions.
Aug 19 2019, 8:54 AM · Restricted Project, Restricted Project
svenvh updated the diff for D63442: [OpenCL] Add const, volatile and pointer handling for builtin functions.

Rebased onto latest master.

Aug 19 2019, 7:12 AM · Restricted Project, Restricted Project
svenvh committed rGb21a3654f0b9: [OpenCL] Add generic type handling for builtin functions (authored by svenvh).
[OpenCL] Add generic type handling for builtin functions
Aug 19 2019, 4:56 AM
svenvh committed rL369253: [OpenCL] Add generic type handling for builtin functions.
[OpenCL] Add generic type handling for builtin functions
Aug 19 2019, 4:55 AM
svenvh closed D65456: [OpenCL] Add generic type handling for builtin functions.
Aug 19 2019, 4:55 AM · Restricted Project, Restricted Project
svenvh accepted D66137: [OpenCL][PR42385] Improve addr space deduction for pointers/references to arrays.

LGTM, but please clang-format your patch before committing (esp. spacing around binary operators).

Aug 19 2019, 2:17 AM · Restricted Project

Aug 15 2019

svenvh added inline comments to D66294: [Docs][OpenCL] Release 9.0 notes for OpenCL.
Aug 15 2019, 8:51 AM · Restricted Project
svenvh added inline comments to D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode.
Aug 15 2019, 5:22 AM · Restricted Project
svenvh committed rG0096d1938ef7: [Support] Fix Wundef warning (authored by svenvh).
[Support] Fix Wundef warning
Aug 15 2019, 3:08 AM
svenvh committed rL368984: [Support] Fix Wundef warning.
[Support] Fix Wundef warning
Aug 15 2019, 3:04 AM

Aug 14 2019

svenvh added inline comments to D65456: [OpenCL] Add generic type handling for builtin functions.
Aug 14 2019, 5:17 AM · Restricted Project, Restricted Project
svenvh updated the diff for D65456: [OpenCL] Add generic type handling for builtin functions.
  • Update comments as per review comments.
  • Rename iterator List to VecSizes in OpenCLBuiltins.td
  • Format GenericType definition.
Aug 14 2019, 5:17 AM · Restricted Project, Restricted Project
svenvh committed rG15e26d1fe945: Fix _WIN32 / _WIN64 Wundef warnings (authored by svenvh).
Fix _WIN32 / _WIN64 Wundef warnings
Aug 14 2019, 3:30 AM
svenvh committed rL368822: Fix _WIN32 / _WIN64 Wundef warnings.
Fix _WIN32 / _WIN64 Wundef warnings
Aug 14 2019, 3:29 AM

Aug 12 2019

svenvh committed rG06385d013d08: [OpenCL] Ignore parentheses for sampler initialization (authored by svenvh).
[OpenCL] Ignore parentheses for sampler initialization
Aug 12 2019, 5:47 AM
svenvh committed rL368561: [OpenCL] Ignore parentheses for sampler initialization.
[OpenCL] Ignore parentheses for sampler initialization
Aug 12 2019, 5:44 AM
svenvh closed D66080: [OpenCL] Ignore parentheses for sampler initialization.
Aug 12 2019, 5:43 AM · Restricted Project, Restricted Project
svenvh created D66080: [OpenCL] Ignore parentheses for sampler initialization.
Aug 12 2019, 4:43 AM · Restricted Project, Restricted Project

Aug 8 2019

svenvh added inline comments to D65456: [OpenCL] Add generic type handling for builtin functions.
Aug 8 2019, 9:17 AM · Restricted Project, Restricted Project
svenvh updated the diff for D65456: [OpenCL] Add generic type handling for builtin functions.
  • Move checking of GenType compatibility from SemaLookup to TableGen emitter.
  • Provide more elaborate explanation about combining GenTypes in a declaration.
  • Add max/min definitions to cover "sgentype" behavior and add test for max.
  • Minor scattered comment improvements.
Aug 8 2019, 9:09 AM · Restricted Project, Restricted Project
svenvh accepted D65941: [OpenCL] Fix lang mode predefined macros for C++ mode.

LGTM!

Aug 8 2019, 5:06 AM · Restricted Project

Aug 7 2019

svenvh updated the diff for D65456: [OpenCL] Add generic type handling for builtin functions.

Addressing review comments.

Aug 7 2019, 8:21 AM · Restricted Project, Restricted Project
svenvh updated subscribers of D65456: [OpenCL] Add generic type handling for builtin functions.
Aug 7 2019, 8:20 AM · Restricted Project, Restricted Project

Aug 1 2019

svenvh abandoned D63434: [OpenCL] Add generic type handling for builtin functions.
Aug 1 2019, 1:45 AM · Restricted Project, Restricted Project
svenvh commandeered D63434: [OpenCL] Add generic type handling for builtin functions.
Aug 1 2019, 1:45 AM · Restricted Project, Restricted Project

Jul 31 2019

svenvh updated the diff for D63442: [OpenCL] Add const, volatile and pointer handling for builtin functions.
  • Factor out .td def renames into separate patch (already pushed).
  • Add definitions for some atomic and asynchronous builtins to make use of the new functionality.
  • Fix formatting.
Jul 31 2019, 7:45 AM · Restricted Project, Restricted Project
svenvh commandeered D63442: [OpenCL] Add const, volatile and pointer handling for builtin functions.
Jul 31 2019, 7:45 AM · Restricted Project, Restricted Project

Jul 30 2019

svenvh added a comment to D65456: [OpenCL] Add generic type handling for builtin functions.

Main changes since D63434:

  • Rename List* to Vec*.
  • Rename TLnn -> TLAll, TLInt, TLFloat.
  • Apply clang-format.
  • Improve/update documentation.
  • Factor out renaming of base types into separate commit.
  • Change return type of OCL2Qual.
  • Remove default case from OCL2Qual switch statement: it should be fully covering the enum.
Jul 30 2019, 9:45 AM · Restricted Project, Restricted Project
svenvh added a comment to D63434: [OpenCL] Add generic type handling for builtin functions.

Continuing in https://reviews.llvm.org/D65456

Jul 30 2019, 9:33 AM · Restricted Project, Restricted Project
svenvh created D65456: [OpenCL] Add generic type handling for builtin functions.
Jul 30 2019, 9:30 AM · Restricted Project, Restricted Project

Jul 29 2019

svenvh committed rG89fb9e8ce151: [OpenCL] Rename builtin definition classes (authored by svenvh).
[OpenCL] Rename builtin definition classes
Jul 29 2019, 7:57 AM
svenvh committed rL367229: [OpenCL] Rename builtin definition classes.
[OpenCL] Rename builtin definition classes
Jul 29 2019, 7:56 AM

Jul 24 2019

svenvh accepted D65102: [OpenCL] Rename lang mode flag for C++ mode.

LGTM!

Jul 24 2019, 3:09 AM · Restricted Project

Jul 19 2019

svenvh committed rGe9e59ad79ffd: [OpenCL] Define CLK_NULL_EVENT without cast (authored by svenvh).
[OpenCL] Define CLK_NULL_EVENT without cast
Jul 19 2019, 2:14 AM
svenvh committed rL366546: [OpenCL] Define CLK_NULL_EVENT without cast.
[OpenCL] Define CLK_NULL_EVENT without cast
Jul 19 2019, 2:11 AM
svenvh closed D63876: [OpenCL] Define CLK_NULL_EVENT without cast.
Jul 19 2019, 2:11 AM · Restricted Project, Restricted Project

Jul 18 2019

svenvh added a comment to D63434: [OpenCL] Add generic type handling for builtin functions.

It seems Phabricator got a bit confused as the latest diff did not include full context (use git diff -U999999).

Jul 18 2019, 6:52 AM · Restricted Project, Restricted Project
svenvh accepted D64867: [OpenCL] Update comments/diagnostics to refer to C++ for OpenCL mode.

LGTM

Jul 18 2019, 1:42 AM · Restricted Project

Jul 17 2019

svenvh added a comment to D64867: [OpenCL] Update comments/diagnostics to refer to C++ for OpenCL mode.

It would be good if you could provide some motivation for this change in the description of this review.

Jul 17 2019, 10:33 AM · Restricted Project

Jul 3 2019

svenvh added a comment to D63876: [OpenCL] Define CLK_NULL_EVENT without cast.

btw, there seems to be the same issue with reserve_id_t?

Jul 3 2019, 3:33 AM · Restricted Project, Restricted Project
svenvh committed rG1bc2cccf18be: Remove some autoconf references from docs and comments (authored by svenvh).
Remove some autoconf references from docs and comments
Jul 3 2019, 3:04 AM
svenvh committed rL365013: Remove some autoconf references from docs and comments.
Remove some autoconf references from docs and comments
Jul 3 2019, 2:58 AM
svenvh closed D63608: Remove some autoconf references from docs and comments.
Jul 3 2019, 2:58 AM · Restricted Project

Jun 27 2019

svenvh created D63876: [OpenCL] Define CLK_NULL_EVENT without cast.
Jun 27 2019, 6:41 AM · Restricted Project, Restricted Project
svenvh updated the diff for D63608: Remove some autoconf references from docs and comments.

Dropping changes to Triple.h.

Jun 27 2019, 3:10 AM · Restricted Project

Jun 26 2019

svenvh committed rG1006a068c63f: [OpenCL] Improve diagnostic for placement new (authored by svenvh).
[OpenCL] Improve diagnostic for placement new
Jun 26 2019, 6:34 AM
svenvh committed rL364423: [OpenCL] Improve diagnostic for placement new.
[OpenCL] Improve diagnostic for placement new
Jun 26 2019, 6:33 AM
svenvh closed D63561: [OpenCL] Improve diagnostic for placement new.
Jun 26 2019, 6:33 AM · Restricted Project, Restricted Project

Jun 24 2019

svenvh added inline comments to D63256: [OpenCL] Split type and macro definitions into opencl-c-base.h.
Jun 24 2019, 3:10 AM · Restricted Project, Restricted Project
svenvh committed rGb502a44110ff: [OpenCL] Restore ATOMIC_VAR_INIT (authored by svenvh).
[OpenCL] Restore ATOMIC_VAR_INIT
Jun 24 2019, 3:08 AM
svenvh committed rG853dfab799f1: [OpenCL] Remove more duplicates from opencl-c.h (authored by svenvh).
[OpenCL] Remove more duplicates from opencl-c.h
Jun 24 2019, 3:07 AM
svenvh committed rL364174: [OpenCL] Restore ATOMIC_VAR_INIT.
[OpenCL] Restore ATOMIC_VAR_INIT
Jun 24 2019, 3:07 AM
svenvh committed rL364173: [OpenCL] Remove more duplicates from opencl-c.h.
[OpenCL] Remove more duplicates from opencl-c.h
Jun 24 2019, 3:07 AM

Jun 21 2019

svenvh added a comment to D59673: [Clang] Harmonize Split DWARF options with llc.

As a followup to r363496, I've added llvm-dwarfdump as a clang test dependency in r364021.

Jun 21 2019, 3:33 AM · Restricted Project, Restricted Project
svenvh committed rGe65fa21cf01c: [cmake] Add llvm-dwarfdump to clang test dependencies (authored by svenvh).
[cmake] Add llvm-dwarfdump to clang test dependencies
Jun 21 2019, 3:25 AM
svenvh committed rG772a7a7680df: [OpenCL] Remove duplicate read_image declarations (authored by svenvh).
[OpenCL] Remove duplicate read_image declarations
Jun 21 2019, 3:25 AM
svenvh committed rL364021: [cmake] Add llvm-dwarfdump to clang test dependencies.
[cmake] Add llvm-dwarfdump to clang test dependencies
Jun 21 2019, 3:25 AM
svenvh committed rL364020: [OpenCL] Remove duplicate read_image declarations.
[OpenCL] Remove duplicate read_image declarations
Jun 21 2019, 3:25 AM

Jun 20 2019

svenvh added inline comments to D63608: Remove some autoconf references from docs and comments.
Jun 20 2019, 9:47 AM · Restricted Project
svenvh created D63608: Remove some autoconf references from docs and comments.
Jun 20 2019, 9:30 AM · Restricted Project

Jun 19 2019

svenvh created D63561: [OpenCL] Improve diagnostic for placement new.
Jun 19 2019, 8:47 AM · Restricted Project, Restricted Project
svenvh committed rGaf1c230e70ae: [OpenCL] Split type and macro definitions into opencl-c-base.h (authored by svenvh).
[OpenCL] Split type and macro definitions into opencl-c-base.h
Jun 19 2019, 5:46 AM
svenvh committed rL363794: [OpenCL] Split type and macro definitions into opencl-c-base.h.
[OpenCL] Split type and macro definitions into opencl-c-base.h
Jun 19 2019, 5:45 AM
svenvh closed D63256: [OpenCL] Split type and macro definitions into opencl-c-base.h.
Jun 19 2019, 5:45 AM · Restricted Project, Restricted Project

Jun 17 2019

svenvh added a comment to D62849: Moving OpenCLBuiltins.td and remove unused include.

Recommitted in r363541.

Jun 17 2019, 3:06 AM · Restricted Project