Page MenuHomePhabricator

svenvh (Sven van Haastregt)
GPU Compiler Engineer at ARM

Projects

User does not belong to any projects.

User Details

User Since
Sep 28 2016, 4:40 AM (129 w, 2 d)

Recent Activity

Feb 15 2019

svenvh accepted D58179: [OpenCL][PR40707] Allow OpenCL C types in C++ mode.

LGTM!

Feb 15 2019, 3:15 AM

Feb 11 2019

svenvh committed rGdc2c93017f8b: [libclang] Add attribute support for 'convergent'. (authored by svenvh).
[libclang] Add attribute support for 'convergent'.
Feb 11 2019, 3:01 AM
svenvh committed rL353690: [libclang] Add attribute support for 'convergent'..
[libclang] Add attribute support for 'convergent'.
Feb 11 2019, 3:01 AM
svenvh committed rC353690: [libclang] Add attribute support for 'convergent'..
[libclang] Add attribute support for 'convergent'.
Feb 11 2019, 3:01 AM

Feb 7 2019

svenvh accepted D57824: [OpenCL][PR40603] In C++ preserve backwards compatibility with OpenCL C v2.0.

Even nicer to have it only inside the extension logic indeed.

Feb 7 2019, 8:12 AM · Restricted Project
svenvh added inline comments to D57824: [OpenCL][PR40603] In C++ preserve backwards compatibility with OpenCL C v2.0.
Feb 7 2019, 2:58 AM · Restricted Project

Nov 14 2018

svenvh committed rL346844: Print newline after banner for ModulePass.
Print newline after banner for ModulePass
Nov 14 2018, 2:08 AM

Nov 1 2018

svenvh committed rL345825: Allow clk_event_t comparisons.
Allow clk_event_t comparisons
Nov 1 2018, 5:45 AM
svenvh committed rC345825: Allow clk_event_t comparisons.
Allow clk_event_t comparisons
Nov 1 2018, 5:45 AM
svenvh closed D53871: [OpenCL] Allow clk_event_t comparisons.
Nov 1 2018, 5:45 AM

Oct 30 2018

svenvh created D53871: [OpenCL] Allow clk_event_t comparisons.
Oct 30 2018, 8:34 AM

Oct 29 2018

svenvh added a comment to D53705: [OpenCL] Postpone PSV address space diagnostic.

Unlikely, since address spaces are provided in a different way in OpenCL C++ vs OpenCL C.

Oct 29 2018, 10:41 AM · Restricted Project

Oct 25 2018

svenvh created D53705: [OpenCL] Postpone PSV address space diagnostic.
Oct 25 2018, 8:26 AM · Restricted Project

Oct 2 2018

svenvh added a comment to D43783: [OpenCL] Remove block invoke function from emitted block literal struct.

Reverted in r343582, test added in r343583.

Oct 2 2018, 6:06 AM
svenvh committed rL343583: [OpenCL] Add block argument CodeGen test.
[OpenCL] Add block argument CodeGen test
Oct 2 2018, 6:04 AM
svenvh committed rC343583: [OpenCL] Add block argument CodeGen test.
[OpenCL] Add block argument CodeGen test
Oct 2 2018, 6:04 AM
svenvh committed rC343582: Revert r326937 "[OpenCL] Remove block invoke function from emitted block….
Revert r326937 "[OpenCL] Remove block invoke function from emitted block…
Oct 2 2018, 6:04 AM
svenvh committed rL343582: Revert r326937 "[OpenCL] Remove block invoke function from emitted block….
Revert r326937 "[OpenCL] Remove block invoke function from emitted block…
Oct 2 2018, 6:04 AM

Sep 28 2018

svenvh committed rL343316: Fix and modernize StringMatcher comment; NFC.
Fix and modernize StringMatcher comment; NFC
Sep 28 2018, 6:33 AM

Sep 27 2018

svenvh committed rC343207: [OpenCL] Improve extension-version.cl and to_addr_builtin.cl tests.
[OpenCL] Improve extension-version.cl and to_addr_builtin.cl tests
Sep 27 2018, 6:23 AM
svenvh committed rL343207: [OpenCL] Improve extension-version.cl and to_addr_builtin.cl tests.
[OpenCL] Improve extension-version.cl and to_addr_builtin.cl tests
Sep 27 2018, 6:23 AM
svenvh closed D52020: [OpenCL] Improve extension-version.cl and to_addr_builtin.cl tests.
Sep 27 2018, 6:23 AM

Sep 26 2018

svenvh committed rL343088: [CMake] Avoid REVERSE on unset variable.
[CMake] Avoid REVERSE on unset variable
Sep 26 2018, 3:15 AM
svenvh closed D51799: [CMake] Avoid REVERSE on empty list.
Sep 26 2018, 3:15 AM

Sep 25 2018

svenvh committed rC342968: [OpenCL] Allow zero assignment and comparisons between queue_t type variables.
[OpenCL] Allow zero assignment and comparisons between queue_t type variables
Sep 25 2018, 6:04 AM
svenvh committed rL342968: [OpenCL] Allow zero assignment and comparisons between queue_t type variables.
[OpenCL] Allow zero assignment and comparisons between queue_t type variables
Sep 25 2018, 6:04 AM
svenvh closed D51727: [OpenCL] Allow zero assignment and comparisons between queue_t type variables.
Sep 25 2018, 6:04 AM
svenvh closed D51727: [OpenCL] Allow zero assignment and comparisons between queue_t type variables.
Sep 25 2018, 6:04 AM

Sep 24 2018

svenvh committed rL342876: Fix Wundef NDEBUG warning; NFC.
Fix Wundef NDEBUG warning; NFC
Sep 24 2018, 7:24 AM
svenvh committed rC342876: Fix Wundef NDEBUG warning; NFC.
Fix Wundef NDEBUG warning; NFC
Sep 24 2018, 7:22 AM

Sep 20 2018

svenvh committed rC342638: [OpenCL] Diagnose redundant address space conversion.
[OpenCL] Diagnose redundant address space conversion
Sep 20 2018, 3:09 AM
svenvh committed rL342638: [OpenCL] Diagnose redundant address space conversion.
[OpenCL] Diagnose redundant address space conversion
Sep 20 2018, 3:09 AM
svenvh closed D51411: [OpenCL] Improve diagnostic of argument in address space conversion builtins .
Sep 20 2018, 3:09 AM

Sep 10 2018

svenvh committed rL341796: Fix author list for first talk..
Fix author list for first talk.
Sep 10 2018, 2:40 AM

Sep 7 2018

svenvh created D51799: [CMake] Avoid REVERSE on empty list.
Sep 7 2018, 9:23 AM

Sep 6 2018

svenvh committed rL341536: Fix argument type in MachineInstr::hasPropertyInBundle.
Fix argument type in MachineInstr::hasPropertyInBundle
Sep 6 2018, 3:27 AM
svenvh closed D51596: Fix bug in MachineInstr::hasPropertyInBundle.
Sep 6 2018, 3:27 AM
svenvh added a comment to D51596: Fix bug in MachineInstr::hasPropertyInBundle.

Sure, I'll push it.

Sep 6 2018, 1:20 AM

Sep 4 2018

svenvh committed rL341364: Fix some Wundef warnings in Compiler.h.
Fix some Wundef warnings in Compiler.h
Sep 4 2018, 5:50 AM
svenvh closed D51171: Fix some Wundef warnings in Compiler.h.
Sep 4 2018, 5:50 AM
svenvh added inline comments to D51544: [OpenCL] Split opencl-c.h header.
Sep 4 2018, 3:05 AM

Aug 23 2018

svenvh created D51171: Fix some Wundef warnings in Compiler.h.
Aug 23 2018, 9:21 AM
svenvh added inline comments to D50738: Remove vestiges of configure buildsystem.
Aug 23 2018, 4:51 AM
svenvh committed rL340520: [Support] Fix some Wundef warnings.
[Support] Fix some Wundef warnings
Aug 23 2018, 2:43 AM
svenvh closed D51105: [Support] Fix some Wundef warnings.
Aug 23 2018, 2:43 AM

Aug 22 2018

svenvh added a reviewer for D51105: [Support] Fix some Wundef warnings: thakis.
Aug 22 2018, 8:32 AM
svenvh created D51105: [Support] Fix some Wundef warnings.
Aug 22 2018, 8:30 AM

Aug 17 2018

svenvh added a comment to D43783: [OpenCL] Remove block invoke function from emitted block literal struct.

Sorry for digging up an old commit...

Aug 17 2018, 9:26 AM

Aug 14 2018

svenvh committed rC339678: [OpenCL] Add test for constant sampler argument.
[OpenCL] Add test for constant sampler argument
Aug 14 2018, 6:57 AM
svenvh committed rL339678: [OpenCL] Add test for constant sampler argument.
[OpenCL] Add test for constant sampler argument
Aug 14 2018, 6:57 AM

Aug 2 2018

svenvh accepted D50104: [OpenCL] Always emit alloca in entry block for enqueue_kernel builtin.

LGTM, thanks!

Aug 2 2018, 1:34 AM

Aug 1 2018

svenvh added a comment to D50104: [OpenCL] Always emit alloca in entry block for enqueue_kernel builtin.

You'll probably also need to update test/CodeGenOpenCL/cl20-device-side-enqueue.cl; please verify with make/ninja check-clang.

Aug 1 2018, 10:16 AM

Jun 14 2018

svenvh committed rL334700: [OpenCL] Support new/delete in Sema.
[OpenCL] Support new/delete in Sema
Jun 14 2018, 2:56 AM
svenvh committed rC334700: [OpenCL] Support new/delete in Sema.
[OpenCL] Support new/delete in Sema
Jun 14 2018, 2:56 AM
svenvh closed D46651: [OpenCL] Support new/delete in Sema.
Jun 14 2018, 2:56 AM

Jun 11 2018

svenvh added inline comments to D46651: [OpenCL] Support new/delete in Sema.
Jun 11 2018, 10:37 AM
svenvh updated the diff for D46651: [OpenCL] Support new/delete in Sema.

Dropped 2 redundant uses of getTypePtr(); minor formatting changes.

Jun 11 2018, 10:31 AM

Jun 8 2018

svenvh updated the diff for D46651: [OpenCL] Support new/delete in Sema.

Relaxed the new/delete restrictions following the Khronos advice.

Jun 8 2018, 10:19 AM

May 11 2018

svenvh added inline comments to D46651: [OpenCL] Support new/delete in Sema.
May 11 2018, 10:41 AM
svenvh committed rL332087: [APFloat] Set losesInfo on no-op convert.
[APFloat] Set losesInfo on no-op convert
May 11 2018, 2:49 AM
svenvh closed D46645: [APFloat] Set losesInfo on no-op convert.
May 11 2018, 2:49 AM

May 9 2018

svenvh created D46651: [OpenCL] Support new/delete in Sema.
May 9 2018, 10:49 AM
svenvh created D46645: [APFloat] Set losesInfo on no-op convert.
May 9 2018, 9:27 AM
svenvh committed rL331874: [OpenCL] Restrict various keywords in OpenCL C++ mode.
[OpenCL] Restrict various keywords in OpenCL C++ mode
May 9 2018, 6:20 AM
svenvh committed rC331874: [OpenCL] Restrict various keywords in OpenCL C++ mode.
[OpenCL] Restrict various keywords in OpenCL C++ mode
May 9 2018, 6:20 AM
svenvh closed D46022: [OpenCL] Restrict various keywords in OpenCL C++ mode.
May 9 2018, 6:19 AM

May 8 2018

svenvh committed rC331766: [OpenCL] Factor out language version printing.
[OpenCL] Factor out language version printing
May 8 2018, 6:51 AM
svenvh committed rL331766: [OpenCL] Factor out language version printing.
[OpenCL] Factor out language version printing
May 8 2018, 6:51 AM
svenvh closed D46382: [OpenCL] Factor out language version printing.
May 8 2018, 6:51 AM

May 3 2018

svenvh created D46382: [OpenCL] Factor out language version printing.
May 3 2018, 3:10 AM

May 1 2018

svenvh updated the diff for D46022: [OpenCL] Restrict various keywords in OpenCL C++ mode.

Dropped the asm and goto restrictions from this patch for now until we have clarification from Khronos.

May 1 2018, 10:12 AM

Apr 30 2018

svenvh added inline comments to D46022: [OpenCL] Restrict various keywords in OpenCL C++ mode.
Apr 30 2018, 10:18 AM
svenvh updated the diff for D46022: [OpenCL] Restrict various keywords in OpenCL C++ mode.

Moved thread storage class specifier diagnosing to ActOnVariableDeclarator.

Apr 30 2018, 10:17 AM

Apr 27 2018

svenvh committed rC331026: [OpenCL] Add separate read_only and write_only pipe IR types.
[OpenCL] Add separate read_only and write_only pipe IR types
Apr 27 2018, 3:40 AM
svenvh committed rL331026: [OpenCL] Add separate read_only and write_only pipe IR types.
[OpenCL] Add separate read_only and write_only pipe IR types
Apr 27 2018, 3:40 AM
svenvh closed D46015: [OpenCL] Add separate read_only and write_only pipe IR types.
Apr 27 2018, 3:40 AM

Apr 26 2018

svenvh added inline comments to D46022: [OpenCL] Restrict various keywords in OpenCL C++ mode.
Apr 26 2018, 10:23 AM
svenvh updated the diff for D46022: [OpenCL] Restrict various keywords in OpenCL C++ mode.

Reject goto in Sema::ActOnIndirectGotoStmt too, and add a test for indirect goto.

Apr 26 2018, 9:30 AM
svenvh added inline comments to D46022: [OpenCL] Restrict various keywords in OpenCL C++ mode.
Apr 26 2018, 9:26 AM
svenvh added inline comments to D46022: [OpenCL] Restrict various keywords in OpenCL C++ mode.
Apr 26 2018, 4:42 AM
svenvh updated the diff for D46022: [OpenCL] Restrict various keywords in OpenCL C++ mode.

Updated patch to reject any thread storage class specifier, not just thread_local.

Apr 26 2018, 4:39 AM

Apr 25 2018

svenvh updated the diff for D46022: [OpenCL] Restrict various keywords in OpenCL C++ mode.

Implemented most of the restrictions as parser or Sema checks instead. This results in nicer diagnostics too, thanks for the suggestion!

Apr 25 2018, 10:21 AM
svenvh added inline comments to D46049: [OpenCL] Add constant address space to __func__ in AST.
Apr 25 2018, 3:34 AM

Apr 24 2018

svenvh created D46022: [OpenCL] Restrict various keywords in OpenCL C++ mode.
Apr 24 2018, 9:34 AM
svenvh committed rC330721: [OpenCL] Fix diagnostic of thread_local.
[OpenCL] Fix diagnostic of thread_local
Apr 24 2018, 7:51 AM
svenvh committed rL330721: [OpenCL] Fix diagnostic of thread_local.
[OpenCL] Fix diagnostic of thread_local
Apr 24 2018, 7:50 AM

Apr 23 2018

svenvh committed rL330579: [OpenCL] Reject virtual functions for OpenCL C++.
[OpenCL] Reject virtual functions for OpenCL C++
Apr 23 2018, 4:29 AM
svenvh committed rC330579: [OpenCL] Reject virtual functions for OpenCL C++.
[OpenCL] Reject virtual functions for OpenCL C++
Apr 23 2018, 4:29 AM
svenvh closed D45873: [OpenCL] Reject virtual functions for OpenCL C++.
Apr 23 2018, 4:29 AM

Apr 20 2018

svenvh updated the diff for D45873: [OpenCL] Reject virtual functions for OpenCL C++.

Added a template class test as requested.

Apr 20 2018, 9:33 AM
svenvh created D45873: [OpenCL] Reject virtual functions for OpenCL C++.
Apr 20 2018, 4:40 AM

Apr 4 2018

svenvh updated the diff for D33361: [InstCombine] Fix inbounds gep for addrspacecasts.

Updated patch to just bail out if address spaces don't match.

Apr 4 2018, 9:49 AM

Apr 3 2018

svenvh added a comment to D33361: [InstCombine] Fix inbounds gep for addrspacecasts.

Hello, I've recently come across the same problem as expressed by this revision.
Has there been any new discussions regarding this topic?

Apr 3 2018, 6:34 AM

Mar 27 2018

svenvh committed rL328626: Drop spurious break; NFC.
Drop spurious break; NFC
Mar 27 2018, 8:01 AM
svenvh committed rC328626: Drop spurious break; NFC.
Drop spurious break; NFC
Mar 27 2018, 8:01 AM

Mar 7 2018

svenvh committed rL326884: [LoadStoreVectorizer] Differentiate between <1 x T> and T.
[LoadStoreVectorizer] Differentiate between <1 x T> and T
Mar 7 2018, 2:31 AM
svenvh closed D44014: [LoadStoreVectorizer] Differentiate between <1 x T> and T.
Mar 7 2018, 2:31 AM

Mar 6 2018

svenvh updated the diff for D44014: [LoadStoreVectorizer] Differentiate between <1 x T> and T.

Updated test to use positive checks.

Mar 6 2018, 4:34 AM

Mar 2 2018

svenvh created D44014: [LoadStoreVectorizer] Differentiate between <1 x T> and T.
Mar 2 2018, 7:20 AM

Jan 24 2018

svenvh committed rL323312: [DAGCombiner] Bail out if vector size is not a multiple.
[DAGCombiner] Bail out if vector size is not a multiple
Jan 24 2018, 1:56 AM