Page MenuHomePhabricator

svenvh (Sven van Haastregt)
GPU Compiler Engineer at ARM

Projects

User does not belong to any projects.

User Details

User Since
Sep 28 2016, 4:40 AM (295 w, 3 d)

Recent Activity

Wed, May 25

svenvh committed rG0d7f8d42fd17: [OpenCL] Remove argument names from async copy builtins (authored by svenvh).
[OpenCL] Remove argument names from async copy builtins
Wed, May 25, 2:06 AM · Restricted Project, Restricted Project

Thu, May 19

svenvh accepted D124776: [SPIR-V] Allow setting SPIR-V version via target triple.

LGTM

Thu, May 19, 9:15 AM · Restricted Project, Restricted Project

Wed, May 18

svenvh committed rG21c29a8ae053: [OpenCL] Add cl_khr_subgroup_rotate builtins (authored by svenvh).
[OpenCL] Add cl_khr_subgroup_rotate builtins
Wed, May 18, 5:03 AM · Restricted Project, Restricted Project
svenvh closed D124256: [OpenCL] Add cl_khr_subgroup_rotate builtins.
Wed, May 18, 5:02 AM · Restricted Project, Restricted Project

Tue, May 17

svenvh committed rGb250cca11d59: [OpenCL] Do not guard vload/store_half builtins (authored by svenvh).
[OpenCL] Do not guard vload/store_half builtins
Tue, May 17, 2:58 AM · Restricted Project, Restricted Project
svenvh closed D125401: [OpenCL] Do not guard vload/store_half builtins.
Tue, May 17, 2:58 AM · Restricted Project, Restricted Project

Thu, May 12

svenvh updated the diff for D125401: [OpenCL] Do not guard vload/store_half builtins.

Add test case.

Thu, May 12, 8:24 AM · Restricted Project, Restricted Project
svenvh committed rG28a0b94d2221: Rename and fix ValueMap::resize to reserve (authored by PFerreira).
Rename and fix ValueMap::resize to reserve
Thu, May 12, 6:01 AM · Restricted Project, Restricted Project
svenvh closed D125387: Rename and fix ValueMap::resize to reserve.
Thu, May 12, 6:01 AM · Restricted Project, Restricted Project
svenvh accepted D125387: Rename and fix ValueMap::resize to reserve.

Please note that I do not have commit rights.

Thu, May 12, 5:48 AM · Restricted Project, Restricted Project

Wed, May 11

svenvh requested review of D125401: [OpenCL] Do not guard vload/store_half builtins.
Wed, May 11, 9:59 AM · Restricted Project, Restricted Project
svenvh added a comment to D124256: [OpenCL] Add cl_khr_subgroup_rotate builtins.

LGTM! I imagine tablegen side is being tested automatically?

Wed, May 11, 7:08 AM · Restricted Project, Restricted Project
svenvh updated the diff for D124256: [OpenCL] Add cl_khr_subgroup_rotate builtins.

Added macro and macro test. Added reference to Extension spec section.

Wed, May 11, 7:07 AM · Restricted Project, Restricted Project
svenvh accepted D125243: [OpenCL] Make -cl-ext a driver option.

LGTM; just a few minor suggestions that you can address at commit time.

Wed, May 11, 4:28 AM · Restricted Project, Restricted Project

Apr 22 2022

svenvh requested review of D124256: [OpenCL] Add cl_khr_subgroup_rotate builtins.
Apr 22 2022, 6:03 AM · Restricted Project, Restricted Project

Apr 21 2022

svenvh committed rG87a258366e5d: [OpenCL] Guard read_write images with TypeExtension (authored by svenvh).
[OpenCL] Guard read_write images with TypeExtension
Apr 21 2022, 2:53 AM · Restricted Project, Restricted Project

Apr 20 2022

svenvh committed rGe67b1b0ccf52: [OpenCL] Add missing __opencl_c_atomic_scope_device guards (authored by svenvh).
[OpenCL] Add missing __opencl_c_atomic_scope_device guards
Apr 20 2022, 3:03 AM · Restricted Project, Restricted Project

Apr 19 2022

svenvh committed rGf3ee0afc6739: [OpenCL] opencl-c.h: Add const to get_image_num_samples (authored by svenvh).
[OpenCL] opencl-c.h: Add const to get_image_num_samples
Apr 19 2022, 2:17 AM · Restricted Project, Restricted Project
svenvh closed D122728: [OpenCL] opencl-c.h: Add const to get_image_num_samples.
Apr 19 2022, 2:17 AM · Restricted Project, Restricted Project

Apr 11 2022

svenvh committed rGbb6f8d9a93ef: [OpenCL] Add device enqueue guards for DSE builtins (authored by svenvh).
[OpenCL] Add device enqueue guards for DSE builtins
Apr 11 2022, 3:28 AM · Restricted Project, Restricted Project

Apr 8 2022

svenvh committed rG1331ad22c31f: [OpenCL] Add generic addrspace guards for get_fence (authored by svenvh).
[OpenCL] Add generic addrspace guards for get_fence
Apr 8 2022, 4:09 AM · Restricted Project, Restricted Project

Apr 6 2022

svenvh committed rG77c74fd877b2: [OpenCL] Remove argument names from math builtins (authored by svenvh).
[OpenCL] Remove argument names from math builtins
Apr 6 2022, 3:44 AM · Restricted Project, Restricted Project

Mar 31 2022

svenvh added a comment to D120254: [OpenCL] Align subgroup builtin guards.

I've submitted the fix in 4dfec37037f5.

Mar 31 2022, 8:43 AM · Restricted Project, Restricted Project
svenvh committed rG4dfec37037f5: [OpenCL] Set MinVersion for sub_group_barrier with memory_scope (authored by svenvh).
[OpenCL] Set MinVersion for sub_group_barrier with memory_scope
Mar 31 2022, 8:42 AM · Restricted Project, Restricted Project
svenvh added a comment to D120254: [OpenCL] Align subgroup builtin guards.

This was worked around by modifying tests, but I believe this is a fundamental problem in this change and was able to reproduce the error with plain old clang:

$ cat test.cl
void sub_group_barrier();

$ bin/clang -cl-std=CL1.2 -S -o - test.cl
error: enum type memory_scope not found; include the base header with -finclude-default-header
1 error generated.

$ bin/clang --version
clang version 15.0.0 (git@github.com:llvm/llvm-project c204cee642ee794901d2e8a9819b52ac12f92bc9)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /home/harald/llvm-project/build/bin

The problem is that this change enables certain built-ins in OpenCL 1.2 that take a memory_scope argument, but the memory_scope type is not defined in OpenCL 1.2 mode. When we then process the function, sub_group_barrier in my example, things break when checking whether the declaration matches the built-in. I am not sure what the right fix here is. Can we just define the type if any extension is enabled that requires the type, or is that not allowed?

Mar 31 2022, 7:15 AM · Restricted Project, Restricted Project

Mar 30 2022

svenvh requested review of D122728: [OpenCL] opencl-c.h: Add const to get_image_num_samples.
Mar 30 2022, 7:24 AM · Restricted Project, Restricted Project

Mar 29 2022

svenvh committed rGde30408b3b0a: [OpenCL] opencl-c.h: remove a/b/c/i/p/n/v arg names (authored by svenvh).
[OpenCL] opencl-c.h: remove a/b/c/i/p/n/v arg names
Mar 29 2022, 2:17 AM · Restricted Project, Restricted Project

Mar 24 2022

svenvh committed rG677d0e749551: [OpenCL] opencl-c.h: remove x/y/z arg names (authored by svenvh).
[OpenCL] opencl-c.h: remove x/y/z arg names
Mar 24 2022, 6:56 AM · Restricted Project

Mar 23 2022

svenvh updated the diff for D104040: [OpenCL] Add TableGen emitter for OpenCL builtin header.

Rebased on latest main.

Mar 23 2022, 10:06 AM · Restricted Project, Restricted Project
svenvh committed rG22548032be76: [OpenCL] opencl-c.h: remove arg names for vload/vstore builtins (authored by svenvh).
[OpenCL] opencl-c.h: remove arg names for vload/vstore builtins
Mar 23 2022, 4:13 AM · Restricted Project

Mar 21 2022

svenvh committed rG73e1888e530a: [OpenCL] Guard write_only image3d_t with TypeExtension (authored by svenvh).
[OpenCL] Guard write_only image3d_t with TypeExtension
Mar 21 2022, 5:46 AM · Restricted Project

Feb 25 2022

svenvh committed rGb48e3c805c25: [OpenCL] opencl-c.h: Fix incorrect get_image_width guard (authored by svenvh).
[OpenCL] opencl-c.h: Fix incorrect get_image_width guard
Feb 25 2022, 3:06 AM

Feb 24 2022

svenvh committed rGba18c360b2f3: [clang-tidy] Remove opencl-c.h inclusion from tests (authored by svenvh).
[clang-tidy] Remove opencl-c.h inclusion from tests
Feb 24 2022, 8:29 AM
svenvh closed D120470: [clang-tidy] Update tests to include opencl-c-base.h.
Feb 24 2022, 8:29 AM · Restricted Project
svenvh added a comment to D120470: [clang-tidy] Update tests to include opencl-c-base.h.

Since this is a simple test update I'll commit this now (before code review), to get affected CI back to green. Please let me know if there are any post-commit concerns.

Feb 24 2022, 8:28 AM · Restricted Project
svenvh committed rG28cdcf8e3c8e: [OpenCL] Handle TypeExtensions in OpenCLBuiltinFileEmitter (authored by svenvh).
[OpenCL] Handle TypeExtensions in OpenCLBuiltinFileEmitter
Feb 24 2022, 7:18 AM
svenvh closed D120262: [OpenCL] Handle TypeExtensions in OpenCLBuiltinFileEmitter.
Feb 24 2022, 7:18 AM · Restricted Project
svenvh updated the diff for D120470: [clang-tidy] Update tests to include opencl-c-base.h.

After a bit of digging I realized we don't need the explicit include at all anymore.

Feb 24 2022, 6:22 AM · Restricted Project
svenvh committed rG88182e2dfde2: [OpenCL] opencl-c.h: remove arg names for image builtins (authored by svenvh).
[OpenCL] opencl-c.h: remove arg names for image builtins
Feb 24 2022, 3:53 AM
svenvh added a comment to D120254: [OpenCL] Align subgroup builtin guards.

Thanks, I could reproduce the problem with your cmake line. I have uploaded a fix for review in https://reviews.llvm.org/D120470

Feb 24 2022, 3:45 AM · Restricted Project, Restricted Project
svenvh requested review of D120470: [clang-tidy] Update tests to include opencl-c-base.h.
Feb 24 2022, 3:44 AM · Restricted Project
svenvh added a comment to D120254: [OpenCL] Align subgroup builtin guards.

Hi, our internal release build bots are showing failures in two clang-tidy tests that I bisected back to your commit, clang-tidy/checkers/altera-id-dependent-backward-branch.cpp and clang-tidy/checkers/altera-single-work-item-barrier.cpp. After this change, both are exhibiting this error:

Error while processing /home/dyung/src/upstream/aa9c2d19d9b73589d72114d6e0a4fb4ce42b922b-linux/tools/clang/tools/extra/test/clang-tidy/checkers/Output/altera-single-work-item-barrier.cpp.tmp.cpp.
error: enum type memory_scope not found; include the base header with -finclude-default-header [clang-diagnostic-error]

Oddly, this only fails in a release configuration. Can you take a look?

Feb 24 2022, 2:30 AM · Restricted Project, Restricted Project

Feb 23 2022

svenvh added inline comments to D120262: [OpenCL] Handle TypeExtensions in OpenCLBuiltinFileEmitter.
Feb 23 2022, 9:00 AM · Restricted Project
svenvh added inline comments to D120262: [OpenCL] Handle TypeExtensions in OpenCLBuiltinFileEmitter.
Feb 23 2022, 7:34 AM · Restricted Project
svenvh updated the diff for D120262: [OpenCL] Handle TypeExtensions in OpenCLBuiltinFileEmitter.

Use StringRef and extend comment.

Feb 23 2022, 7:33 AM · Restricted Project
svenvh committed rGaa9c2d19d9b7: [OpenCL] Align subgroup builtin guards (authored by svenvh).
[OpenCL] Align subgroup builtin guards
Feb 23 2022, 4:22 AM
svenvh closed D120254: [OpenCL] Align subgroup builtin guards.
Feb 23 2022, 4:22 AM · Restricted Project, Restricted Project
svenvh added inline comments to D120254: [OpenCL] Align subgroup builtin guards.
Feb 23 2022, 4:21 AM · Restricted Project, Restricted Project

Feb 22 2022

svenvh committed rGe7e17b30d02d: [OpenCL] opencl-c.h: use uint/ulong consistently (authored by svenvh).
[OpenCL] opencl-c.h: use uint/ulong consistently
Feb 22 2022, 2:16 AM
svenvh closed D120032: [OpenCL] opencl-c.h: use uint/ulong consistently.
Feb 22 2022, 2:15 AM · Restricted Project

Feb 21 2022

svenvh requested review of D120262: [OpenCL] Handle TypeExtensions in OpenCLBuiltinFileEmitter.
Feb 21 2022, 10:00 AM · Restricted Project
svenvh added inline comments to D120254: [OpenCL] Align subgroup builtin guards.
Feb 21 2022, 8:40 AM · Restricted Project, Restricted Project
svenvh requested review of D120254: [OpenCL] Align subgroup builtin guards.
Feb 21 2022, 8:39 AM · Restricted Project, Restricted Project
svenvh added a comment to D118692: [llvm-objcopy][COFF] Fix section name encoding.

Sorry about that - if you happen to have such a build available, does this diff help?

diff --git a/llvm/lib/ObjCopy/CMakeLists.txt b/llvm/lib/ObjCopy/CMakeLists.txt
index 1e516394c74a..ec1160e331c9 100644
--- a/llvm/lib/ObjCopy/CMakeLists.txt
+++ b/llvm/lib/ObjCopy/CMakeLists.txt
@@ -64,6 +64,7 @@ add_llvm_component_library(LLVMObjCopy
   intrinsics_gen

   LINK_COMPONENTS
+  BinaryFormat
   Object
   Support
   MC
Feb 21 2022, 6:03 AM · Restricted Project
svenvh committed rG14f143c9084f: Fix llvm-objcopy shared lib build (authored by svenvh).
Fix llvm-objcopy shared lib build
Feb 21 2022, 6:02 AM
svenvh committed rG52df8666158c: [OpenCL] opencl-c.h: remove arg names from atomics; NFC (authored by svenvh).
[OpenCL] opencl-c.h: remove arg names from atomics; NFC
Feb 21 2022, 3:29 AM
svenvh closed D119560: [OpenCL] opencl-c.h: remove arg names from atomics.
Feb 21 2022, 3:29 AM · Restricted Project

Feb 17 2022

svenvh requested review of D120032: [OpenCL] opencl-c.h: use uint/ulong consistently.
Feb 17 2022, 3:06 AM · Restricted Project
svenvh committed rG9798b33d1dc1: [OpenCL] Guard 64-bit atomic types (authored by svenvh).
[OpenCL] Guard 64-bit atomic types
Feb 17 2022, 2:59 AM
svenvh closed D119858: [OpenCL] Guard 64-bit atomic types.
Feb 17 2022, 2:59 AM · Restricted Project

Feb 16 2022

svenvh committed rG6690b7d3ac9a: [OpenCL] Ensure atomic_init is guarded with extension (authored by svenvh).
[OpenCL] Ensure atomic_init is guarded with extension
Feb 16 2022, 7:12 AM
svenvh committed rG477bc8e8b931: [OpenCL] Guard atomic_double with cl_khr_int64_* (authored by svenvh).
[OpenCL] Guard atomic_double with cl_khr_int64_*
Feb 16 2022, 2:08 AM
svenvh closed D119398: [OpenCL] Guard atomic_double with cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics.
Feb 16 2022, 2:07 AM · Restricted Project

Feb 15 2022

svenvh added a comment to D119858: [OpenCL] Guard 64-bit atomic types.

LGTM! Thanks!

I imagine this is another change to align with opencl-c.h?

Feb 15 2022, 10:09 AM · Restricted Project
svenvh requested review of D119858: [OpenCL] Guard 64-bit atomic types.
Feb 15 2022, 9:42 AM · Restricted Project
svenvh accepted D119719: [Docs][OpenCL] Update OpenCL 3.0 status.

LGTM, just suggesting a minor textual improvement that can be made at commit time.

Feb 15 2022, 5:44 AM · Restricted Project
svenvh accepted D119713: [Docs] Release 14 notes for SPIR-V in clang.

LGTM

Feb 15 2022, 5:37 AM
svenvh accepted D119710: [Docs][OpenCL] Release 14 notes .
Feb 15 2022, 5:36 AM
svenvh added a comment to D119560: [OpenCL] opencl-c.h: remove arg names from atomics.

also makes the header no longer "claim" the identifiers "success",
"failure", "desired", "value" (such that you can compile with -Dvalue=...
when including the header for example, which currently breaks parsing
of the header).

I don't get what you mean by this. :)

Feb 15 2022, 4:50 AM · Restricted Project
svenvh committed rG074451bd3352: [OpenCL] opencl-c.h: fix atomic_fetch_max with addrspace (authored by svenvh).
[OpenCL] opencl-c.h: fix atomic_fetch_max with addrspace
Feb 15 2022, 4:12 AM

Feb 14 2022

svenvh added inline comments to D119710: [Docs][OpenCL] Release 14 notes .
Feb 14 2022, 7:52 AM

Feb 11 2022

svenvh requested review of D119560: [OpenCL] opencl-c.h: remove arg names from atomics.
Feb 11 2022, 10:01 AM · Restricted Project
svenvh added a comment to D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0.

There are tests checking for this (e.g. clang/test/Frontend/opencl.cl), so we need this check to preserve the existing behavior indeed.

Thanks. The other test is SemaOpenCL/clang-builtin-version.cl.

But it might be worth asking someone outside of the OpenCL community whether it's desirable to use the LanguageID enum in this way.

I personally think this looks good now, for OpenCL in particularly, as it became version-agnostic (except for DSE). But we still are querying language options only, and we expect language options for generic AS, pipes and DSE to be immutable at this point.

Note that this LanguageID is intended for Builtins use because there are other LanguageIDs used elsewhere.

Feb 11 2022, 6:00 AM · Restricted Project
svenvh committed rG50f8abb9f40a: [OpenCL] Add OpenCL 3.0 atomics to -fdeclare-opencl-builtins (authored by svenvh).
[OpenCL] Add OpenCL 3.0 atomics to -fdeclare-opencl-builtins
Feb 11 2022, 2:14 AM
svenvh closed D119420: [OpenCL] Add OpenCL 3.0 atomics to -fdeclare-opencl-builtins.
Feb 11 2022, 2:14 AM · Restricted Project

Feb 10 2022

svenvh accepted D119398: [OpenCL] Guard atomic_double with cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics.

Thanks, LGTM! I'll try to followup with the .td changes soon.

Feb 10 2022, 6:20 AM · Restricted Project
svenvh added a comment to D119398: [OpenCL] Guard atomic_double with cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics.

This might interfere with https://reviews.llvm.org/D119420

Feb 10 2022, 4:51 AM · Restricted Project
svenvh requested review of D119420: [OpenCL] Add OpenCL 3.0 atomics to -fdeclare-opencl-builtins.
Feb 10 2022, 2:22 AM · Restricted Project
svenvh committed rG8d37043520f5: [OpenCL] Refactor cl_ext_float_atomics declarations; NFC (authored by svenvh).
[OpenCL] Refactor cl_ext_float_atomics declarations; NFC
Feb 10 2022, 1:44 AM

Feb 9 2022

svenvh committed rGa464444b2888: [OpenCL][Docs] Update OpenCL 3.0 status info (authored by svenvh).
[OpenCL][Docs] Update OpenCL 3.0 status info
Feb 9 2022, 7:13 AM
svenvh added inline comments to D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0.
Feb 9 2022, 6:37 AM · Restricted Project
svenvh committed rGfe690587bedb: [OpenCL] Fix atomic_fetch_add/sub with half type (authored by svenvh).
[OpenCL] Fix atomic_fetch_add/sub with half type
Feb 9 2022, 2:48 AM

Feb 8 2022

svenvh committed rG9b8a93e3b6d3: [OpenCL] opencl-c.h: remove arg names from arm_dot; NFC (authored by svenvh).
[OpenCL] opencl-c.h: remove arg names from arm_dot; NFC
Feb 8 2022, 5:44 AM

Feb 7 2022

svenvh committed rGc15782bcf5c9: [OpenCL] opencl-c.h: make attribute order consistent; NFC (authored by svenvh).
[OpenCL] opencl-c.h: make attribute order consistent; NFC
Feb 7 2022, 2:55 AM
svenvh accepted D119011: [clang] Cache OpenCL types.

LGTM, thanks!

Feb 7 2022, 2:28 AM · Restricted Project

Feb 4 2022

svenvh committed rG31fa3a4d4431: [OpenCL] Move OpenCL 2.0 atomics into multiclass; NFC (authored by svenvh).
[OpenCL] Move OpenCL 2.0 atomics into multiclass; NFC
Feb 4 2022, 2:18 AM

Feb 3 2022

svenvh committed rG9694332b81dd: [clang-format] Add missing newline in -style help (authored by svenvh).
[clang-format] Add missing newline in -style help
Feb 3 2022, 4:13 AM
svenvh committed rGd97a4dfea6c2: [OpenCL] Move most _explicit atomics into multiclass; NFC (authored by svenvh).
[OpenCL] Move most _explicit atomics into multiclass; NFC
Feb 3 2022, 3:10 AM

Feb 2 2022

svenvh committed rGe0e6f3a6a2e1: [OpenCL] Test -fdeclare-opencl-builtins with CL3 and CLC++2021 (authored by svenvh).
[OpenCL] Test -fdeclare-opencl-builtins with CL3 and CLC++2021
Feb 2 2022, 2:23 AM

Jan 31 2022

svenvh committed rG8e6099291dcb: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins (authored by svenvh).
[OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins
Jan 31 2022, 2:22 AM
svenvh closed D107769: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins.
Jan 31 2022, 2:21 AM · Restricted Project
svenvh added inline comments to D107769: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins.
Jan 31 2022, 2:11 AM · Restricted Project

Jan 28 2022

svenvh committed rGbfd8210f6f47: [OpenCL] opencl-c.h: refactor named addrspace builtins (authored by svenvh).
[OpenCL] opencl-c.h: refactor named addrspace builtins
Jan 28 2022, 2:25 AM
svenvh closed D118158: [OpenCL] opencl-c.h: refactor named addrspace builtins.
Jan 28 2022, 2:25 AM · Restricted Project

Jan 27 2022

svenvh updated the diff for D107769: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins.

Make use of the __opencl_c_named_address_space_builtins internal feature added by D118158. This should avoid affecting OpenCL 2.0.

Jan 27 2022, 9:48 AM · Restricted Project
svenvh committed rG35fff208cad6: [OpenCL] opencl-c.h: add missing read_write image guards (authored by svenvh).
[OpenCL] opencl-c.h: add missing read_write image guards
Jan 27 2022, 2:33 AM

Jan 25 2022

svenvh added a reviewer for D118158: [OpenCL] opencl-c.h: refactor named addrspace builtins: Anastasia.
Jan 25 2022, 9:03 AM · Restricted Project
svenvh requested review of D118158: [OpenCL] opencl-c.h: refactor named addrspace builtins.
Jan 25 2022, 9:02 AM · Restricted Project
svenvh committed rG91a0b464a853: [OpenCL] Make read_write images optional for -fdeclare-opencl-builtins (authored by svenvh).
[OpenCL] Make read_write images optional for -fdeclare-opencl-builtins
Jan 25 2022, 3:40 AM
svenvh closed D117899: [OpenCL] Make read_write images optional for -fdeclare-opencl-builtins.
Jan 25 2022, 3:40 AM · Restricted Project