Page MenuHomePhabricator

svenvh (Sven van Haastregt)
GPU Compiler Engineer at ARM

Projects

User does not belong to any projects.

User Details

User Since
Sep 28 2016, 4:40 AM (172 w, 3 d)

Recent Activity

Tue, Jan 14

svenvh accepted D72707: [clang][OpenCL] Fix covered switch warning.

Nice catch, LGTM. Thanks!

Tue, Jan 14, 8:21 AM · Restricted Project
svenvh committed rG92451f0904ce: [OpenCL] Add MSAA sharing extension builtin functions (authored by svenvh).
[OpenCL] Add MSAA sharing extension builtin functions
Tue, Jan 14, 6:47 AM

Thu, Jan 9

svenvh committed rG241f335b268d: [OpenCL][Docs] Rename C++ for OpenCL label (authored by svenvh).
[OpenCL][Docs] Rename C++ for OpenCL label
Thu, Jan 9, 8:40 AM

Mon, Jan 6

svenvh accepted D72255: Fix compiler extension example cmake integration.

LGTM (for what it's worth as I'm not an expert in this area), thanks!

Mon, Jan 6, 9:37 AM · Restricted Project
svenvh added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

This change seems to be causing a problem with the nightly packages from apt.llvm.org.

Mon, Jan 6, 1:49 AM · Restricted Project, Restricted Project
svenvh added inline comments to D69416: [Examples] Add IRTransformations directory to examples..
Mon, Jan 6, 1:49 AM · Restricted Project

Thu, Jan 2

svenvh accepted D72076: [OpenCL] Add link to C++ for OpenCL documentation.

LGTM

Thu, Jan 2, 4:27 AM · Restricted Project

Tue, Dec 31

svenvh committed rGff429c5eaf79: [OpenCL] Remove redundant foreach in OpenCLBuiltins.td; NFC (authored by svenvh).
[OpenCL] Remove redundant foreach in OpenCLBuiltins.td; NFC
Tue, Dec 31, 7:33 AM

Mon, Dec 30

svenvh committed rG4a188fdfa79b: [OpenCL] Add mipmap builtin functions (authored by svenvh).
[OpenCL] Add mipmap builtin functions
Mon, Dec 30, 2:50 AM

Mon, Dec 23

svenvh committed rGb714583fd096: [OpenCL] Add atomic builtin functions (authored by svenvh).
[OpenCL] Add atomic builtin functions
Mon, Dec 23, 4:40 AM

Dec 18 2019

svenvh committed rG308b8b76ceee: [OpenCL] Add builtin function extension handling (authored by svenvh).
[OpenCL] Add builtin function extension handling
Dec 18 2019, 2:17 AM
svenvh closed D71476: [OpenCL] Add builtin function extension handling.
Dec 18 2019, 2:16 AM · Restricted Project

Dec 17 2019

svenvh added inline comments to D71476: [OpenCL] Add builtin function extension handling.
Dec 17 2019, 5:04 AM · Restricted Project
svenvh committed rGdf5a905aa8a8: [OpenCL] Add ExtVectorElementExpr constant evaluation (PR42387) (authored by svenvh).
[OpenCL] Add ExtVectorElementExpr constant evaluation (PR42387)
Dec 17 2019, 3:19 AM
svenvh closed D71133: [OpenCL] Add ExtVectorElementExpr constant evaluation (PR42387).
Dec 17 2019, 3:19 AM · Restricted Project

Dec 13 2019

svenvh created D71476: [OpenCL] Add builtin function extension handling.
Dec 13 2019, 9:48 AM · Restricted Project

Dec 12 2019

svenvh accepted D71272: [OpenCL] Pretty print __private addr space.

LGTM.

Dec 12 2019, 10:32 AM · Restricted Project

Dec 11 2019

svenvh added inline comments to D71133: [OpenCL] Add ExtVectorElementExpr constant evaluation (PR42387).
Dec 11 2019, 2:13 AM · Restricted Project

Dec 9 2019

svenvh committed rGf3e6a6123264: [OpenCL] Handle address space conversions for constexpr (PR44177) (authored by svenvh).
[OpenCL] Handle address space conversions for constexpr (PR44177)
Dec 9 2019, 3:16 AM
svenvh closed D71015: [OpenCL] Handle address space conversions for constexpr (PR44177).
Dec 9 2019, 3:16 AM · Restricted Project

Dec 6 2019

svenvh created D71133: [OpenCL] Add ExtVectorElementExpr constant evaluation (PR42387).
Dec 6 2019, 10:41 AM · Restricted Project

Dec 4 2019

svenvh created D71015: [OpenCL] Handle address space conversions for constexpr (PR44177).
Dec 4 2019, 7:03 AM · Restricted Project

Dec 3 2019

svenvh committed rG6713670b1732: [OpenCL] Fix mangling of single-overload builtins (authored by svenvh).
[OpenCL] Fix mangling of single-overload builtins
Dec 3 2019, 3:18 AM

Dec 2 2019

svenvh committed rG62364965619b: [OpenCL] Fix address space for implicit conversion (PR43145) (authored by svenvh).
[OpenCL] Fix address space for implicit conversion (PR43145)
Dec 2 2019, 6:22 AM
svenvh closed D70605: [OpenCL] Fix address space for implicit conversion (PR43145).
Dec 2 2019, 6:21 AM · Restricted Project
svenvh added inline comments to rG9a8d477a0e00: [OpenCL] Add builtin function attribute handling.
Dec 2 2019, 4:30 AM

Nov 28 2019

svenvh updated the diff for D70605: [OpenCL] Fix address space for implicit conversion (PR43145).

Address comment from @rjmccall to preserve original ToType pointer type.

Nov 28 2019, 6:52 AM · Restricted Project

Nov 27 2019

svenvh updated the diff for D70605: [OpenCL] Fix address space for implicit conversion (PR43145).

Added test for references too.

Nov 27 2019, 9:32 AM · Restricted Project

Nov 26 2019

svenvh added a comment to D70605: [OpenCL] Fix address space for implicit conversion (PR43145).

Is there a similar problem with reference parameters?

Nov 26 2019, 7:30 AM · Restricted Project
svenvh committed rGe54c83ec4dd4: [OpenCL] Add work-group and miscellaneous vector builtin functions (authored by svenvh).
[OpenCL] Add work-group and miscellaneous vector builtin functions
Nov 26 2019, 2:53 AM

Nov 22 2019

svenvh created D70605: [OpenCL] Fix address space for implicit conversion (PR43145).
Nov 22 2019, 10:34 AM · Restricted Project

Nov 21 2019

svenvh committed rG35388dcbbc4c: [OpenCL] Fix address space for base method call (PR43145) (authored by svenvh).
[OpenCL] Fix address space for base method call (PR43145)
Nov 21 2019, 2:40 AM
svenvh closed D69810: [OpenCL] Fix address space for base method call (PR43145).
Nov 21 2019, 2:40 AM · Restricted Project

Nov 20 2019

svenvh updated the diff for D69810: [OpenCL] Fix address space for base method call (PR43145).

Incorporate suggestions from @rjmccall and add a test for the pointer case.

Nov 20 2019, 9:19 AM · Restricted Project

Nov 19 2019

svenvh updated the diff for D69810: [OpenCL] Fix address space for base method call (PR43145).

Rework fix to insert an addrspace conversion node into the AST instead of catching the addrspace cast in CGCall.

Nov 19 2019, 10:06 AM · Restricted Project
svenvh added inline comments to D69416: [Examples] Add IRTransformations directory to examples..
Nov 19 2019, 3:29 AM · Restricted Project
svenvh added inline comments to D69416: [Examples] Add IRTransformations directory to examples..
Nov 19 2019, 2:31 AM · Restricted Project
svenvh committed rGd56dd62a98eb: [kate] Add various missing keywords (authored by svenvh).
[kate] Add various missing keywords
Nov 19 2019, 1:56 AM

Nov 14 2019

svenvh accepted D70167: Fix use of add_llvm_tool in projects that build no targets.

LGTM!

Nov 14 2019, 2:43 AM · Restricted Project

Nov 13 2019

svenvh committed rG2fe674baa3f3: [OpenCL] Add remaining vector data builtin functions (authored by svenvh).
[OpenCL] Add remaining vector data builtin functions
Nov 13 2019, 2:24 AM

Nov 7 2019

svenvh committed rG0e70c350943f: [OpenCL] Add integer builtin functions (authored by svenvh).
[OpenCL] Add integer builtin functions
Nov 7 2019, 7:05 AM
svenvh committed rG3d30f2cff7a4: [OpenCL] Add geometric and relational builtin functions (authored by svenvh).
[OpenCL] Add geometric and relational builtin functions
Nov 7 2019, 7:05 AM
svenvh closed D69901: [OpenCL] Add integer functions to builtin functions.
Nov 7 2019, 7:04 AM · Restricted Project
svenvh closed D69908: [OpenCL] Add geometric and relational builtin functions.
Nov 7 2019, 7:04 AM · Restricted Project
svenvh committed rG6fc73f63660b: [OpenCL] Add math and common builtin functions (authored by svenvh).
[OpenCL] Add math and common builtin functions
Nov 7 2019, 5:23 AM
svenvh closed D69883: [OpenCL] Add math and common builtin functions.
Nov 7 2019, 5:23 AM · Restricted Project

Nov 6 2019

svenvh created D69908: [OpenCL] Add geometric and relational builtin functions.
Nov 6 2019, 10:09 AM · Restricted Project
svenvh created D69901: [OpenCL] Add integer functions to builtin functions.
Nov 6 2019, 9:13 AM · Restricted Project
svenvh added inline comments to D69810: [OpenCL] Fix address space for base method call (PR43145).
Nov 6 2019, 8:36 AM · Restricted Project
svenvh created D69883: [OpenCL] Add math and common builtin functions.
Nov 6 2019, 2:13 AM · Restricted Project

Nov 5 2019

svenvh committed rG0e56b0f94bfc: [OpenCL] Group builtin functions by prototype (authored by svenvh).
[OpenCL] Group builtin functions by prototype
Nov 5 2019, 2:30 AM
svenvh committed rG9a8d477a0e00: [OpenCL] Add builtin function attribute handling (authored by svenvh).
[OpenCL] Add builtin function attribute handling
Nov 5 2019, 2:30 AM
svenvh closed D63557: [OpenCL] Group builtin functions by prototype.
Nov 5 2019, 2:29 AM · Restricted Project, Restricted Project
svenvh closed D64319: [OpenCL] Add function attributes handling for builtin functions.
Nov 5 2019, 2:29 AM · Restricted Project, Restricted Project

Nov 4 2019

svenvh created D69810: [OpenCL] Fix address space for base method call (PR43145).
Nov 4 2019, 10:09 AM · Restricted Project
svenvh committed rG6c5827975cf9: [OpenCL] Fix FileCheck pattern (authored by svenvh).
[OpenCL] Fix FileCheck pattern
Nov 4 2019, 7:13 AM
svenvh committed rG82888b78d47e: [OpenCL] Fix address space for const method call from nonconst (PR43145) (authored by svenvh).
[OpenCL] Fix address space for const method call from nonconst (PR43145)
Nov 4 2019, 5:15 AM
svenvh closed D68781: [OpenCL] Fix address space for const method call from nonconst.
Nov 4 2019, 5:15 AM · Restricted Project
svenvh added inline comments to D63557: [OpenCL] Group builtin functions by prototype.
Nov 4 2019, 3:10 AM · Restricted Project, Restricted Project

Nov 1 2019

svenvh updated the diff for D68781: [OpenCL] Fix address space for const method call from nonconst.

Fix formatting, reduce use of auto, and add a test.

Nov 1 2019, 10:28 AM · Restricted Project
svenvh commandeered D68781: [OpenCL] Fix address space for const method call from nonconst.
Nov 1 2019, 10:28 AM · Restricted Project
svenvh committed rG0aed36d261d3: [OpenCL] Support -fdeclare-opencl-builtins in C++ mode (authored by svenvh).
[OpenCL] Support -fdeclare-opencl-builtins in C++ mode
Nov 1 2019, 6:57 AM
svenvh closed D69233: [OpenCL] Support -fdeclare-opencl-builtins in C++ mode.
Nov 1 2019, 6:57 AM · Restricted Project

Oct 20 2019

svenvh created D69233: [OpenCL] Support -fdeclare-opencl-builtins in C++ mode.
Oct 20 2019, 8:20 PM · Restricted Project

Oct 17 2019

svenvh committed rGaf6248cbb9e7: [OpenCL] Preserve addrspace in CGClass (PR43145) (authored by svenvh).
[OpenCL] Preserve addrspace in CGClass (PR43145)
Oct 17 2019, 7:12 AM
svenvh closed D68403: [OpenCL] PR43145: preserve addrspace for class accesses.
Oct 17 2019, 7:12 AM · Restricted Project
svenvh committed rL375118: [OpenCL] Preserve addrspace in CGClass (PR43145).
[OpenCL] Preserve addrspace in CGClass (PR43145)
Oct 17 2019, 7:12 AM
svenvh committed rG5e962e8d7dc7: [OpenCL] Add doc to describe OpenCL support (authored by svenvh).
[OpenCL] Add doc to describe OpenCL support
Oct 17 2019, 6:03 AM
svenvh closed D69072: [OpenCL] Added doc to describe OpenCL support.
Oct 17 2019, 6:03 AM · Restricted Project
svenvh committed rL375111: [OpenCL] Add doc to describe OpenCL support.
[OpenCL] Add doc to describe OpenCL support
Oct 17 2019, 5:54 AM

Oct 11 2019

svenvh committed rL374536: Add Clang tutorial abstract.
Add Clang tutorial abstract
Oct 11 2019, 4:51 AM

Oct 3 2019

svenvh created D68403: [OpenCL] PR43145: preserve addrspace for class accesses.
Oct 3 2019, 9:27 AM · Restricted Project

Sep 30 2019

svenvh added inline comments to D63557: [OpenCL] Group builtin functions by prototype.
Sep 30 2019, 9:07 AM · Restricted Project, Restricted Project
svenvh updated the diff for D63557: [OpenCL] Group builtin functions by prototype.
  • Improve variable names & comments.
  • Fix memory leaks.
  • Rebase on top of recent master, and move before https://reviews.llvm.org/D63555 as the generated code on master is growing in size; with this patch we save about 100kb in the binary.
  • Restucture SignatureListMap to make it easier to understand.
Sep 30 2019, 8:58 AM · Restricted Project, Restricted Project
svenvh commandeered D63557: [OpenCL] Group builtin functions by prototype.
Sep 30 2019, 8:56 AM · Restricted Project, Restricted Project

Sep 27 2019

svenvh updated the diff for D64319: [OpenCL] Add function attributes handling for builtin functions.
  • Rebase onto recent master.
  • Fix formatting.
  • Use predefined attribute sets like "Attr.Const" instead of bit lists.
Sep 27 2019, 10:30 AM · Restricted Project, Restricted Project
svenvh commandeered D64319: [OpenCL] Add function attributes handling for builtin functions.
Sep 27 2019, 10:30 AM · Restricted Project, Restricted Project
svenvh committed rG2319eb65473e: [OpenCL] Pass LangOptions as const ref (authored by svenvh).
[OpenCL] Pass LangOptions as const ref
Sep 27 2019, 6:31 AM
svenvh committed rL373088: [OpenCL] Pass LangOptions as const ref.
[OpenCL] Pass LangOptions as const ref
Sep 27 2019, 6:31 AM

Sep 26 2019

svenvh committed rG6c22eda1600c: [OpenCL] Add -Wconversion to fdeclare-opencl-builtins test (authored by svenvh).
[OpenCL] Add -Wconversion to fdeclare-opencl-builtins test
Sep 26 2019, 6:32 AM
svenvh committed rL372975: [OpenCL] Add -Wconversion to fdeclare-opencl-builtins test.
[OpenCL] Add -Wconversion to fdeclare-opencl-builtins test
Sep 26 2019, 6:31 AM
svenvh closed D67714: [OpenCL] Add -Wconversion to fdeclare-opencl-builtins test.
Sep 26 2019, 6:31 AM · Restricted Project, Restricted Project

Sep 25 2019

svenvh committed rG2a69ed0bc87b: [OpenCL] Add image query builtin functions (authored by svenvh).
[OpenCL] Add image query builtin functions
Sep 25 2019, 2:16 AM
svenvh committed rL372833: [OpenCL] Add image query builtin functions.
[OpenCL] Add image query builtin functions
Sep 25 2019, 2:11 AM
svenvh closed D67713: [OpenCL] Add image query builtin functions.
Sep 25 2019, 2:11 AM · Restricted Project, Restricted Project

Sep 24 2019

svenvh added inline comments to D67714: [OpenCL] Add -Wconversion to fdeclare-opencl-builtins test.
Sep 24 2019, 8:26 AM · Restricted Project, Restricted Project

Sep 23 2019

svenvh committed rGa0d84ffee853: [docs] Fix some typos in InternalsManual (authored by svenvh).
[docs] Fix some typos in InternalsManual
Sep 23 2019, 7:27 AM
svenvh committed rL372614: [docs] Fix some typos in InternalsManual.
[docs] Fix some typos in InternalsManual
Sep 23 2019, 7:23 AM

Sep 19 2019

svenvh committed rGed69faa01bff: [OpenCL] Add version handling and add vector ld/st builtins (authored by svenvh).
[OpenCL] Add version handling and add vector ld/st builtins
Sep 19 2019, 6:42 AM
svenvh committed rL372321: [OpenCL] Add version handling and add vector ld/st builtins.
[OpenCL] Add version handling and add vector ld/st builtins
Sep 19 2019, 6:41 AM
svenvh closed D63504: [OpenCL] Add version handling and add vector ld/st builtins.
Sep 19 2019, 6:41 AM · Restricted Project, Restricted Project

Sep 18 2019

svenvh created D67714: [OpenCL] Add -Wconversion to fdeclare-opencl-builtins test.
Sep 18 2019, 8:48 AM · Restricted Project, Restricted Project
svenvh created D67713: [OpenCL] Add image query builtin functions.
Sep 18 2019, 8:48 AM · Restricted Project, Restricted Project
svenvh added inline comments to D63504: [OpenCL] Add version handling and add vector ld/st builtins.
Sep 18 2019, 2:22 AM · Restricted Project, Restricted Project

Sep 17 2019

svenvh committed rG47e95ff8133f: [OpenCL] Tidy up some comments; NFC (authored by svenvh).
[OpenCL] Tidy up some comments; NFC
Sep 17 2019, 6:33 AM
svenvh committed rL372119: [OpenCL] Tidy up some comments; NFC.
[OpenCL] Tidy up some comments; NFC
Sep 17 2019, 6:32 AM

Sep 9 2019

svenvh committed rG783fc95f3eed: Merge note_ovl_builtin_candidate diagnostics; NFC (authored by svenvh).
Merge note_ovl_builtin_candidate diagnostics; NFC
Sep 9 2019, 7:39 AM
svenvh committed rL371403: Merge note_ovl_builtin_candidate diagnostics; NFC.
Merge note_ovl_builtin_candidate diagnostics; NFC
Sep 9 2019, 7:37 AM

Sep 6 2019

svenvh updated the diff for D63504: [OpenCL] Add version handling and add vector ld/st builtins.

Rebasing and improving comments.

Sep 6 2019, 10:27 AM · Restricted Project, Restricted Project
svenvh commandeered D63504: [OpenCL] Add version handling and add vector ld/st builtins.
Sep 6 2019, 10:23 AM · Restricted Project, Restricted Project