Page MenuHomePhabricator

azabaznov (Anton Zabaznov)
Compiler Engineer at Intel

Projects

User does not belong to any projects.

User Details

User Since
Sep 23 2020, 3:53 AM (92 w, 2 d)

Recent Activity

Feb 22 2022

azabaznov accepted D120254: [OpenCL] Align subgroup builtin guards.

LGTM! Thanks!

Feb 22 2022, 2:07 AM · Restricted Project, Restricted Project

Feb 16 2022

azabaznov accepted D119719: [Docs][OpenCL] Update OpenCL 3.0 status.

LGTM. Thanks!

Feb 16 2022, 2:03 AM · Restricted Project

Feb 15 2022

azabaznov added inline comments to D119719: [Docs][OpenCL] Update OpenCL 3.0 status.
Feb 15 2022, 1:36 AM · Restricted Project

Feb 11 2022

azabaznov committed rGbfb1a33bec7c: [OpenCL] Adjust diagnostic for subgroup support. (authored by azabaznov).
[OpenCL] Adjust diagnostic for subgroup support.
Feb 11 2022, 6:40 AM
azabaznov closed D118999: [OpenCL] Adjust diagnostic for subgroup support..
Feb 11 2022, 6:40 AM · Restricted Project
azabaznov updated the diff for D118999: [OpenCL] Adjust diagnostic for subgroup support..

Use existing diagnostics; add the comment that device can support extension but not the feature. Will follow up if we need explicit mention in the language spec.

Feb 11 2022, 5:52 AM · Restricted Project
azabaznov committed rGbee4bd70f769: [OpenCL] Add support of language builtins for OpenCL C 3.0 (authored by azabaznov).
[OpenCL] Add support of language builtins for OpenCL C 3.0
Feb 11 2022, 4:54 AM
azabaznov closed D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0.
Feb 11 2022, 4:54 AM · Restricted Project
azabaznov added a comment to D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0.

There are tests checking for this (e.g. clang/test/Frontend/opencl.cl), so we need this check to preserve the existing behavior indeed.

Feb 11 2022, 3:16 AM · Restricted Project
azabaznov updated the diff for D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0.

Rename language mode for device side enqueue builtins; add the comment that device side enqueue builtins are not supported until OpenCL 2.0.

Feb 11 2022, 3:08 AM · Restricted Project

Feb 9 2022

azabaznov added a comment to D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0.

@Anastasia @svenvh ping. Just a kind reminder.

Feb 9 2022, 1:32 AM · Restricted Project

Feb 7 2022

azabaznov added inline comments to D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0.
Feb 7 2022, 6:40 AM · Restricted Project
azabaznov updated the diff for D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0.

Check only against specific language option, remove unused LanguageIDs

Feb 7 2022, 6:38 AM · Restricted Project

Feb 4 2022

azabaznov added a comment to D118999: [OpenCL] Adjust diagnostic for subgroup support..

It seems hard to find a direct mention in the spec, but in the API spec:

Feb 4 2022, 8:16 AM · Restricted Project
azabaznov requested review of D118999: [OpenCL] Adjust diagnostic for subgroup support..
Feb 4 2022, 7:32 AM · Restricted Project
azabaznov updated the diff for D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0.

Reimplement with checking language options only.

Feb 4 2022, 4:25 AM · Restricted Project

Feb 2 2022

azabaznov added inline comments to D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0.
Feb 2 2022, 1:53 AM · Restricted Project

Feb 1 2022

azabaznov added inline comments to D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0.
Feb 1 2022, 5:52 AM · Restricted Project

Jan 31 2022

azabaznov updated the diff for D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0.

Remove no longer required comment in the test.

Jan 31 2022, 7:14 AM · Restricted Project
azabaznov requested review of D118605: [OpenCL] Add support of language builtins for OpenCL C 3.0.
Jan 31 2022, 7:12 AM · Restricted Project

Jan 27 2022

azabaznov committed rGa5de66c4c50b: [OpenCL] Add support of __opencl_c_device_enqueue feature macro. (authored by azabaznov).
[OpenCL] Add support of __opencl_c_device_enqueue feature macro.
Jan 27 2022, 3:26 AM
azabaznov closed D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro..
Jan 27 2022, 3:26 AM · Restricted Project

Jan 25 2022

azabaznov added inline comments to D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro..
Jan 25 2022, 5:40 AM · Restricted Project
azabaznov updated the diff for D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro..

Add expected-no-diagnostics, fix misprint in test.

Jan 25 2022, 5:39 AM · Restricted Project

Jan 12 2022

azabaznov updated the diff for D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro..

Rebase, remove extra 'verify'

Jan 12 2022, 2:19 AM · Restricted Project
azabaznov added inline comments to D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro..
Jan 12 2022, 2:18 AM · Restricted Project

Dec 20 2021

azabaznov added inline comments to D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro..
Dec 20 2021, 1:22 AM · Restricted Project
azabaznov updated the diff for D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro..

Simplified running lines in tests, use 'verify' when validating features, simplify condition in Sema

Dec 20 2021, 1:19 AM · Restricted Project

Dec 13 2021

azabaznov abandoned D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro..

Now program scope global variables are required by device enqueue in the spec, new patch for device enqueue support: https://reviews.llvm.org/D115640

Dec 13 2021, 7:50 AM · Restricted Project
azabaznov requested review of D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro..
Dec 13 2021, 7:46 AM · Restricted Project

Nov 11 2021

azabaznov added inline comments to D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro..
Nov 11 2021, 8:08 AM · Restricted Project
azabaznov added a comment to D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro..

How about we clarify with Khronos whether it would be sufficient to add a restriction like:

Program scope blocks are only supported when program scope variables feature is supported.

Nov 11 2021, 8:01 AM · Restricted Project

Nov 4 2021

azabaznov added inline comments to D108392: [OpenCL] Fix parsing of opencl-c.h in CL 3.0 with device-scope atomics enabled.
Nov 4 2021, 8:49 AM · Restricted Project

Oct 21 2021

azabaznov updated the summary of D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro..
Oct 21 2021, 11:20 AM · Restricted Project
azabaznov updated the summary of D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro..
Oct 21 2021, 9:09 AM · Restricted Project
azabaznov updated the summary of D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro..
Oct 21 2021, 9:06 AM · Restricted Project
azabaznov added a comment to D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro..

@Anastasia, @yaxunl, do you think it's possible to refactor code generation for blocks such that block literal for global blocks (with no captures) would be emitted in constant address space? Now it's emitted in global address space (for example @__block_literal_global in https://godbolt.org/z/4z8hGj7hz).

Oct 21 2021, 9:05 AM · Restricted Project
azabaznov requested review of D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro..
Oct 21 2021, 9:01 AM · Restricted Project

Sep 19 2021

azabaznov requested review of D110036: [TargetInfo][LangOpts] Refactor target info and language options adjustment..
Sep 19 2021, 7:02 AM · Restricted Project

Sep 7 2021

azabaznov accepted D109320: [OpenCL][Docs] Update OpenCL 3.0 implementation status..

LGTM, thanks!

Sep 7 2021, 5:21 AM · Restricted Project

Aug 3 2021

azabaznov added a comment to D107318: [OpenCL] allow generic address and non-generic defs for CL3.0.

Yeah, this looks good. Thanks! Please notify when this is ready to land.

Aug 3 2021, 2:28 AM · Restricted Project

Jul 30 2021

azabaznov committed rG4e124ff25681: [OpenCL] Replace test for pipe struct to test it with fixed triple (authored by azabaznov).
[OpenCL] Replace test for pipe struct to test it with fixed triple
Jul 30 2021, 11:49 AM
azabaznov closed D107176: [OpenCL] Replace test for pipe struct to test it with fixed triple.
Jul 30 2021, 11:49 AM · Restricted Project
azabaznov updated the diff for D107176: [OpenCL] Replace test for pipe struct to test it with fixed triple.

Restore original test name which was changed in D106748, use check-prefixes

Jul 30 2021, 11:02 AM · Restricted Project
azabaznov requested review of D107176: [OpenCL] Replace test for pipe struct to test it with fixed triple.
Jul 30 2021, 9:23 AM · Restricted Project
azabaznov committed rGacc58504952f: [OpenCL] Add support of __opencl_c_pipes feature macro. (authored by azabaznov).
[OpenCL] Add support of __opencl_c_pipes feature macro.
Jul 30 2021, 8:11 AM
azabaznov closed D107154: [OpenCL] Add support of __opencl_c_pipes feature macro..
Jul 30 2021, 8:10 AM · Restricted Project
azabaznov added a comment to D107154: [OpenCL] Add support of __opencl_c_pipes feature macro..

We might need to fix the target triple in clang/test/SemaOpenCL/invalid-pipes-cl2.0.cl to avoid surprises with testing but it has better coverage if we don't though...

Jul 30 2021, 6:25 AM · Restricted Project
azabaznov added a comment to D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics.

@airlied, can you please fix that to something like here https://godbolt.org/z/3Kbso8ca3? What currently we do have with your patch is that generic address space overload is always selected, but more strict overloading always exist in OpenCL C 3.0 (https://godbolt.org/z/vbMrdMxs1).

Jul 30 2021, 6:07 AM · Restricted Project
azabaznov updated the diff for D107154: [OpenCL] Add support of __opencl_c_pipes feature macro..

Fix doubling run lines, misprint

Jul 30 2021, 5:37 AM · Restricted Project
azabaznov requested review of D107154: [OpenCL] Add support of __opencl_c_pipes feature macro..
Jul 30 2021, 5:31 AM · Restricted Project

Jul 29 2021

azabaznov added a comment to D106748: [OpenCL] Add support of __opencl_c_pipes feature macro..

Reverted it due too suspicious failing:

error: 'error' diagnostics expected but not seen: 
  File /home/tcwg-buildslave/worker/clang-armv7-2stage/llvm/clang/test/SemaOpenCL/invalid-pipes-cl2.0.cl Line 8: type '__global write_only pipe int ({{(void)?}})' can only be used as a function parameter in OpenCL
error: 'error' diagnostics seen but not expected: 
  File /home/tcwg-buildslave/worker/clang-armv7-2stage/llvm/clang/test/SemaOpenCL/invalid-pipes-cl2.0.cl Line 8: type '__private write_only pipe int (void)' can only be used as a function parameter in OpenCL
2 errors generated.
Jul 29 2021, 8:39 PM · Restricted Project
azabaznov added a reverting change for rGd1e4b2575673: [OpenCL] Add support of __opencl_c_pipes feature macro.: rGda6626d12624: Revert "[OpenCL] Add support of __opencl_c_pipes feature macro.".
Jul 29 2021, 8:35 PM
azabaznov committed rGda6626d12624: Revert "[OpenCL] Add support of __opencl_c_pipes feature macro." (authored by azabaznov).
Revert "[OpenCL] Add support of __opencl_c_pipes feature macro."
Jul 29 2021, 8:35 PM
azabaznov added a reverting change for D106748: [OpenCL] Add support of __opencl_c_pipes feature macro.: rGda6626d12624: Revert "[OpenCL] Add support of __opencl_c_pipes feature macro.".
Jul 29 2021, 8:35 PM · Restricted Project
azabaznov added inline comments to D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics.
Jul 29 2021, 7:54 PM · Restricted Project
azabaznov committed rGd1e4b2575673: [OpenCL] Add support of __opencl_c_pipes feature macro. (authored by azabaznov).
[OpenCL] Add support of __opencl_c_pipes feature macro.
Jul 29 2021, 7:28 PM
azabaznov closed D106748: [OpenCL] Add support of __opencl_c_pipes feature macro..
Jul 29 2021, 7:28 PM · Restricted Project
azabaznov updated the diff for D106748: [OpenCL] Add support of __opencl_c_pipes feature macro..

Rebase

Jul 29 2021, 7:27 PM · Restricted Project
azabaznov committed rGf16a4fcbe510: [OpenCL] Add support of __opencl_c_3d_image_writes feature macro (authored by azabaznov).
[OpenCL] Add support of __opencl_c_3d_image_writes feature macro
Jul 29 2021, 6:54 PM
azabaznov closed D106260: [OpenCL] Add support of __opencl_c_3d_image_writes feature macro.
Jul 29 2021, 6:54 PM · Restricted Project

Jul 28 2021

azabaznov added inline comments to D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics.
Jul 28 2021, 3:02 AM · Restricted Project

Jul 27 2021

azabaznov updated the diff for D106748: [OpenCL] Add support of __opencl_c_pipes feature macro..

Preserve existing diagnostic with err_opencl_unknown_type_specifier, fix comments for language option

Jul 27 2021, 7:05 AM · Restricted Project

Jul 26 2021

azabaznov added inline comments to D106748: [OpenCL] Add support of __opencl_c_pipes feature macro..
Jul 26 2021, 7:30 AM · Restricted Project

Jul 24 2021

azabaznov requested review of D106748: [OpenCL] Add support of __opencl_c_pipes feature macro..
Jul 24 2021, 8:03 AM · Restricted Project

Jul 23 2021

azabaznov updated the diff for D106260: [OpenCL] Add support of __opencl_c_3d_image_writes feature macro.

Unify with err_opencl_requires_extension. Infrastructure for getting aliased extensions seems to messy and doesn't seem worth it yet since there are only two cases of such functionality (fp64 and 3d image writes) :(

Jul 23 2021, 4:25 AM · Restricted Project

Jul 22 2021

azabaznov added inline comments to D106504: [OpenCL] Change default standard version to CL1.2.
Jul 22 2021, 5:11 AM · Restricted Project

Jul 20 2021

azabaznov added a comment to D106111: opencl-c.h: add initial CL 3.0 conditionals for atomic operations..

You also need to guard memory_order_seq_cst enum entry. Note that memory_order_acq_rel is always defined as it can be used in atomic_work_item_fence() built-in function, AFAIR in all other cases if memory_order_acq_rel is used without __opencl_c_atomic_order_acq_rel feature it is undefined behavior.

Jul 20 2021, 2:59 AM · Restricted Project

Jul 19 2021

azabaznov updated the diff for D106260: [OpenCL] Add support of __opencl_c_3d_image_writes feature macro.

Change diagnostic output

Jul 19 2021, 3:51 AM · Restricted Project
azabaznov added inline comments to D106260: [OpenCL] Add support of __opencl_c_3d_image_writes feature macro.
Jul 19 2021, 3:26 AM · Restricted Project
azabaznov requested review of D106260: [OpenCL] Add support of __opencl_c_3d_image_writes feature macro.
Jul 19 2021, 3:23 AM · Restricted Project

Jul 15 2021

azabaznov committed rG05eb59e1d0ea: [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro (authored by azabaznov).
[OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro
Jul 15 2021, 7:21 AM
azabaznov closed D103191: [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro.
Jul 15 2021, 7:21 AM · Restricted Project
azabaznov updated the diff for D103191: [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro.

Restructured test a little

Jul 15 2021, 3:46 AM · Restricted Project

Jul 13 2021

azabaznov added inline comments to D105858: opencl-c.h: add 3.0 optional extension support for a few more bits.
Jul 13 2021, 9:13 AM · Restricted Project
azabaznov committed rG03d8fed34951: [OpenCL] Add verbosity when checking support of read_write images (authored by azabaznov).
[OpenCL] Add verbosity when checking support of read_write images
Jul 13 2021, 8:47 AM
azabaznov closed D105892: [OpenCL] Add verbosity when checking support of read_write images.
Jul 13 2021, 8:47 AM · Restricted Project
azabaznov retitled D105892: [OpenCL] Add verbosity when checking support of read_write images from [NFC] Silence build warning by placing parentheses around condition to [OpenCL] Add verbosity when checking support of read_write images.
Jul 13 2021, 7:49 AM · Restricted Project
azabaznov updated the diff for D105892: [OpenCL] Add verbosity when checking support of read_write images.

Add comment for C++ for OpenCL, add variable to check support for OpenCL C

Jul 13 2021, 7:48 AM · Restricted Project
azabaznov added inline comments to D104915: [OpenCL] Add support of __opencl_c_read_write_images feature macro.
Jul 13 2021, 6:54 AM · Restricted Project
azabaznov requested review of D105892: [OpenCL] Add verbosity when checking support of read_write images.
Jul 13 2021, 6:53 AM · Restricted Project
azabaznov committed rGab76101f40f8: [OpenCL] Add support of __opencl_c_read_write_images feature macro (authored by azabaznov).
[OpenCL] Add support of __opencl_c_read_write_images feature macro
Jul 13 2021, 5:38 AM
azabaznov closed D104915: [OpenCL] Add support of __opencl_c_read_write_images feature macro.
Jul 13 2021, 5:38 AM · Restricted Project
azabaznov updated the diff for D103191: [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro.

Update test after generic AS was merged

Jul 13 2021, 5:06 AM · Restricted Project
azabaznov committed rG78463ebde2f8: [OpenCL] Add support of __opencl_c_generic_address_space feature macro (authored by azabaznov).
[OpenCL] Add support of __opencl_c_generic_address_space feature macro
Jul 13 2021, 3:14 AM
azabaznov closed D103401: [OpenCL] Add support of __opencl_c_generic_address_space feature macro.
Jul 13 2021, 3:14 AM · Restricted Project

Jul 1 2021

azabaznov updated the diff for D104915: [OpenCL] Add support of __opencl_c_read_write_images feature macro.

Fixed naming of new methods, fixed comments, removed redundant comments from source file

Jul 1 2021, 8:13 AM · Restricted Project
azabaznov updated the diff for D103191: [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro.

Fixed latest comment about checking for == 300. Btw, there already exists a few places where >= 300 is checked. Should fix them as well.

Jul 1 2021, 8:02 AM · Restricted Project
azabaznov updated the diff for D103401: [OpenCL] Add support of __opencl_c_generic_address_space feature macro.

Added FIXME. Alternatively, we could add this language option only in ::adjust if there is still a worry about multiple places of definitions. Btw, there will some more language options which dependent on target settings for OpenCL C 3.0, such as pipes and blocks

Jul 1 2021, 7:24 AM · Restricted Project
azabaznov updated the diff for D104915: [OpenCL] Add support of __opencl_c_read_write_images feature macro.

Addressed latest review comments, also refactored the patch by putting diagnostics into OpenCLOptions

Jul 1 2021, 6:15 AM · Restricted Project

Jun 25 2021

azabaznov requested review of D104915: [OpenCL] Add support of __opencl_c_read_write_images feature macro.
Jun 25 2021, 7:04 AM · Restricted Project

Jun 21 2021

azabaznov committed rGa42739055835: [OpenCL] Add support of __opencl_c_images feature macro (authored by azabaznov).
[OpenCL] Add support of __opencl_c_images feature macro
Jun 21 2021, 8:24 AM
azabaznov closed D103911: [OpenCL] Add support of __opencl_c_images feature macro.
Jun 21 2021, 8:24 AM · Restricted Project

Jun 17 2021

azabaznov updated the diff for D103191: [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro.

Restructured test, added comments

Jun 17 2021, 7:44 AM · Restricted Project
azabaznov updated the diff for D103911: [OpenCL] Add support of __opencl_c_images feature macro.

Set SPIR target for added test

Jun 17 2021, 4:57 AM · Restricted Project
azabaznov accepted D104040: [OpenCL] Add TableGen emitter for OpenCL builtin header.

Thanks for working on this! That's cool, I managed to reproduce something similar to https://reviews.llvm.org/D99577.

Jun 17 2021, 4:11 AM · Restricted Project, Restricted Project

Jun 9 2021

azabaznov added inline comments to D103911: [OpenCL] Add support of __opencl_c_images feature macro.
Jun 9 2021, 5:12 AM · Restricted Project
azabaznov added a comment to D97869: [OpenCL] Add OpenCL builtin test generator.

@svenvh, are you going to add header-like output emitting?

Yes, I can add that if there is interest. I already have it on a local branch, so if there is interest (and it seems there is? :-)), then I will rebase that, tidy it up, and create a separate review.

Jun 9 2021, 4:31 AM · Restricted Project
azabaznov added a comment to D97869: [OpenCL] Add OpenCL builtin test generator.

@svenvh, are you going to add header-like output emitting?

Jun 9 2021, 4:12 AM · Restricted Project

Jun 8 2021

azabaznov requested review of D103911: [OpenCL] Add support of __opencl_c_images feature macro.
Jun 8 2021, 9:45 AM · Restricted Project