This is an archive of the discontinued LLVM Phabricator instance.

[clang] Change set type used for SourceLocation.

Authored by simon_tatham on Jul 6 2021, 9:27 AM.



This is part of a patch series working towards the ability to make
SourceLocation into a 64-bit type to handle larger translation units.

If clang is built for a 32-bit platform and SourceLocation is 64 bits
wide, then a SourceLocation will be larger than a pointer, so it won't
be possible to keep them in a SmallPtrSet any more. Switch to
SmallDenseSet instead.

Patch originally by Mikhail Maltsev.

Diff Detail

Event Timeline

simon_tatham created this revision.Jul 6 2021, 9:27 AM
simon_tatham requested review of this revision.Jul 6 2021, 9:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 6 2021, 9:27 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
miyuki added a subscriber: miyuki.Jul 6 2021, 10:11 AM
miyuki added inline comments.Jul 14 2021, 9:33 AM

Can this #include be removed?

tmatheson accepted this revision.Jul 19 2021, 4:06 AM
This revision is now accepted and ready to land.Jul 19 2021, 4:06 AM
This revision was automatically updated to reflect the committed changes.
simon_tatham marked an inline comment as done.