Page MenuHomePhabricator

akyrtzi (Argyrios Kyrtzidis)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 11 2014, 3:42 PM (475 w, 2 d)

Recent Activity

Mon, Mar 13

akyrtzi updated subscribers of D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..
Mon, Mar 13, 1:22 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Tue, Mar 7

akyrtzi committed rGb3283bf192c6: [test/ARCMT/verify.m] Add lit test for `5e035651fd3acbb2645abbe80cae332d90eac78… (authored by akyrtzi).
[test/ARCMT/verify.m] Add lit test for `5e035651fd3acbb2645abbe80cae332d90eac78…
Tue, Mar 7, 8:31 PM · Restricted Project, Restricted Project
akyrtzi closed D145473: [test/ARCMT/verify.m] Add lit test for `5e035651fd3acbb2645abbe80cae332d90eac78a` commit.
Tue, Mar 7, 8:30 PM · Restricted Project, Restricted Project

Mon, Mar 6

akyrtzi added a comment to D145256: [clang/Diagnostic] Use `optional` to disambiguate between a `StoredDiagMessage` that is not set vs set as empty string.

Is this observable from a clang command line tool? Be nice to have a lit test.

Mon, Mar 6, 10:59 PM · Restricted Project, Restricted Project
akyrtzi added a reviewer for D145473: [test/ARCMT/verify.m] Add lit test for `5e035651fd3acbb2645abbe80cae332d90eac78a` commit: dblaikie.
Mon, Mar 6, 10:58 PM · Restricted Project, Restricted Project
akyrtzi requested review of D145473: [test/ARCMT/verify.m] Add lit test for `5e035651fd3acbb2645abbe80cae332d90eac78a` commit.
Mon, Mar 6, 10:55 PM · Restricted Project, Restricted Project

Fri, Mar 3

akyrtzi committed rG5e035651fd3a: [clang/Diagnostic] Use `optional` to disambiguate between a `StoredDiagMessage`… (authored by akyrtzi).
[clang/Diagnostic] Use `optional` to disambiguate between a `StoredDiagMessage`…
Fri, Mar 3, 12:49 PM · Restricted Project, Restricted Project
akyrtzi closed D145256: [clang/Diagnostic] Use `optional` to disambiguate between a `StoredDiagMessage` that is not set vs set as empty string.
Fri, Mar 3, 12:49 PM · Restricted Project, Restricted Project
akyrtzi updated the diff for D145256: [clang/Diagnostic] Use `optional` to disambiguate between a `StoredDiagMessage` that is not set vs set as empty string.

Avoid passing a new IgnoringDiagConsumer for the test since it's unused.

Fri, Mar 3, 11:29 AM · Restricted Project, Restricted Project
akyrtzi added reviewers for D145256: [clang/Diagnostic] Use `optional` to disambiguate between a `StoredDiagMessage` that is not set vs set as empty string: benlangmuir, steven_wu, jansvoboda11.
Fri, Mar 3, 10:48 AM · Restricted Project, Restricted Project
akyrtzi requested review of D145256: [clang/Diagnostic] Use `optional` to disambiguate between a `StoredDiagMessage` that is not set vs set as empty string.
Fri, Mar 3, 10:48 AM · Restricted Project, Restricted Project

Feb 14 2023

akyrtzi accepted D143981: [Support/BLAKE3] Rename blake3_* -> llvm_blake3_* to avoid symbol collisions.

Thank you for the fix! 🙇🏻‍♂️

Feb 14 2023, 3:21 PM · Restricted Project, Restricted Project
akyrtzi added inline comments to D143981: [Support/BLAKE3] Rename blake3_* -> llvm_blake3_* to avoid symbol collisions.
Feb 14 2023, 1:58 PM · Restricted Project, Restricted Project
akyrtzi added a comment to D143981: [Support/BLAKE3] Rename blake3_* -> llvm_blake3_* to avoid symbol collisions.

The MSVC ".asm" files aren't preprocessed, though.

Feb 14 2023, 8:18 AM · Restricted Project, Restricted Project

Feb 13 2023

akyrtzi added a comment to D143981: [Support/BLAKE3] Rename blake3_* -> llvm_blake3_* to avoid symbol collisions.

.s files can use the preprocessor as well. I'd recommend to add a file that do the renames using #define, like in blake3_impl.h, and include it in all the .s files.
That way the changes to the original files is minimized, which is useful for pulling in future changes from the original repo.

Feb 13 2023, 11:36 PM · Restricted Project, Restricted Project

Feb 10 2023

akyrtzi committed rGd8e9a1a12557: [CMake] Use `LLVM_ENABLE_ASSERTIONS` to enable assertions in `libc++` (authored by akyrtzi).
[CMake] Use `LLVM_ENABLE_ASSERTIONS` to enable assertions in `libc++`
Feb 10 2023, 5:52 PM · Restricted Project, Restricted Project
akyrtzi closed D143612: [CMake] Use `LLVM_ENABLE_ASSERTIONS` to enable assertions in `libc++`.
Feb 10 2023, 5:51 PM · Restricted Project, Restricted Project

Feb 8 2023

akyrtzi added a comment to D143612: [CMake] Use `LLVM_ENABLE_ASSERTIONS` to enable assertions in `libc++`.

I think we should verify the performance impact to running tests is minimal before landing this, like they did with the _GLIBCXX_ASSERTIONS change.

Feb 8 2023, 3:48 PM · Restricted Project, Restricted Project
akyrtzi added reviewers for D143612: [CMake] Use `LLVM_ENABLE_ASSERTIONS` to enable assertions in `libc++`: benlangmuir, steven_wu, nikic.
Feb 8 2023, 3:39 PM · Restricted Project, Restricted Project
akyrtzi requested review of D143612: [CMake] Use `LLVM_ENABLE_ASSERTIONS` to enable assertions in `libc++`.
Feb 8 2023, 3:38 PM · Restricted Project, Restricted Project
akyrtzi added a comment to D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend.

@akyrtzi Thank you for your feedback. Can I land the patch?

Feb 8 2023, 8:23 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Feb 7 2023

akyrtzi added a comment to D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend.

Added changes in clang/lib/AST/CMakeLists.txt to address build issue reported by @akyrtzi .

I modified CMakeLists.txt so that it requires generation of missing Attributes.inc.

@akyrtzi Please let me know if it solves your issue

Feb 7 2023, 1:14 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
akyrtzi abandoned D143461: [ClangScanDeps] Fix data race in `clang-scan-deps` tool.
Feb 7 2023, 8:41 AM · Restricted Project, Restricted Project
akyrtzi accepted D143428: [clang][deps] Fix race condition.
Feb 7 2023, 8:39 AM · Restricted Project, Restricted Project

Feb 6 2023

akyrtzi added reviewers for D143461: [ClangScanDeps] Fix data race in `clang-scan-deps` tool: jansvoboda11, benlangmuir.
Feb 6 2023, 10:03 PM · Restricted Project, Restricted Project
akyrtzi requested review of D143461: [ClangScanDeps] Fix data race in `clang-scan-deps` tool.
Feb 6 2023, 10:03 PM · Restricted Project, Restricted Project

Feb 2 2023

akyrtzi added a comment to D141625: [DeclContext] Sort the Decls before adding into DeclContext.

would be great to test it more in a semantic way if possible

Feb 2 2023, 12:18 PM · Restricted Project, Restricted Project

Jan 31 2023

akyrtzi accepted D139052: [NFC][Profile] Access profile through VirtualFileSystem.
Jan 31 2023, 3:41 PM · Restricted Project, Restricted Project, Restricted Project
akyrtzi added a comment to D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend.

I've reverted this change from main branch, let me know if there's anything I can do to help with addressing the build issue.

Jan 31 2023, 12:14 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
akyrtzi added a reverting change for rGca446037af01: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend: rG4de51483ef5f: Revert "[OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend".
Jan 31 2023, 12:12 PM · Restricted Project, Restricted Project, Restricted Project
akyrtzi committed rG4de51483ef5f: Revert "[OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend" (authored by akyrtzi).
Revert "[OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend"
Jan 31 2023, 12:12 PM · Restricted Project, Restricted Project, Restricted Project
akyrtzi added a reverting change for D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend: rG4de51483ef5f: Revert "[OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend".
Jan 31 2023, 12:12 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 29 2023

akyrtzi added a comment to D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend.

Hi @domada, these changes break compilation of clang, with such build error:

FAILED: tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ASTContext.cpp.o 
<clang invocation>
In file included from /llvm-project/clang/lib/AST/ASTContext.cpp:81:
In file included from /llvm-project/llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:17:
In file included from /llvm-project/llvm/include/llvm/Analysis/MemorySSAUpdater.h:37:
In file included from /llvm-project/llvm/include/llvm/Analysis/MemorySSA.h:93:
In file included from /llvm-project/llvm/include/llvm/Analysis/AliasAnalysis.h:44:
In file included from /llvm-project/llvm/include/llvm/IR/PassManager.h:45:
In file included from /llvm-project/llvm/include/llvm/IR/Function.h:25:
In file included from /llvm-project/llvm/include/llvm/IR/Argument.h:17:
/llvm-project/llvm/include/llvm/IR/Attributes.h:90:14: fatal error: 'llvm/IR/Attributes.inc' file not found

Reproduction steps:

Jan 29 2023, 6:35 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 21 2023

akyrtzi committed rGa93cb9302c1a: [clang/driver] Make sure that `-gno-modules` by itself doesn't enable debug info (authored by akyrtzi).
[clang/driver] Make sure that `-gno-modules` by itself doesn't enable debug info
Jan 21 2023, 11:40 AM · Restricted Project, Restricted Project

Jan 20 2023

akyrtzi committed rGb2b078adc2d0: [clang/CodeGenActionTest] Use the platform's path separator for the… (authored by akyrtzi).
[clang/CodeGenActionTest] Use the platform's path separator for the…
Jan 20 2023, 1:21 PM · Restricted Project, Restricted Project
akyrtzi closed D142238: [clang/CodeGenActionTest] Use the platform's path separator for the `DebugInfoCWDCodeGen` test.
Jan 20 2023, 1:20 PM · Restricted Project, Restricted Project
akyrtzi committed rG1ff8a687ae15: [clang/driver] Add `-gno-modules` as the negative version of `-gmodules` (authored by akyrtzi).
[clang/driver] Add `-gno-modules` as the negative version of `-gmodules`
Jan 20 2023, 12:43 PM · Restricted Project, Restricted Project
akyrtzi closed D142236: [clang/driver] Add `-gno-modules` as the negative version of `-gmodules`.
Jan 20 2023, 12:43 PM · Restricted Project, Restricted Project
akyrtzi requested review of D142238: [clang/CodeGenActionTest] Use the platform's path separator for the `DebugInfoCWDCodeGen` test.
Jan 20 2023, 10:16 AM · Restricted Project, Restricted Project
akyrtzi added a reviewer for D142236: [clang/driver] Add `-gno-modules` as the negative version of `-gmodules`: aprantl.
Jan 20 2023, 10:06 AM · Restricted Project, Restricted Project
akyrtzi requested review of D142236: [clang/driver] Add `-gno-modules` as the negative version of `-gmodules`.
Jan 20 2023, 10:06 AM · Restricted Project, Restricted Project

Jan 19 2023

akyrtzi committed rGed6d09dd4ead: [Lex] For dependency directive lexing, angled includes in `__has_include`… (authored by akyrtzi).
[Lex] For dependency directive lexing, angled includes in `__has_include`…
Jan 19 2023, 3:25 PM · Restricted Project, Restricted Project
akyrtzi closed D142143: [Lex] For dependency directive lexing, angled includes in `__has_include` should be lexed as string literals.
Jan 19 2023, 3:24 PM · Restricted Project, Restricted Project
akyrtzi added inline comments to D142143: [Lex] For dependency directive lexing, angled includes in `__has_include` should be lexed as string literals.
Jan 19 2023, 12:20 PM · Restricted Project, Restricted Project
akyrtzi updated the diff for D142143: [Lex] For dependency directive lexing, angled includes in `__has_include` should be lexed as string literals.

Add test case for dependency directive lexing of ill-formed include inside __has_include

Jan 19 2023, 12:19 PM · Restricted Project, Restricted Project
akyrtzi added inline comments to D142143: [Lex] For dependency directive lexing, angled includes in `__has_include` should be lexed as string literals.
Jan 19 2023, 12:06 PM · Restricted Project, Restricted Project
akyrtzi added reviewers for D142143: [Lex] For dependency directive lexing, angled includes in `__has_include` should be lexed as string literals: jansvoboda11, benlangmuir.
Jan 19 2023, 10:42 AM · Restricted Project, Restricted Project
akyrtzi requested review of D142143: [Lex] For dependency directive lexing, angled includes in `__has_include` should be lexed as string literals.
Jan 19 2023, 10:42 AM · Restricted Project, Restricted Project

Jan 18 2023

akyrtzi added a comment to D142028: [clang] remove SUBMODULE_TOPHEADER.

This is useful for functionality, like in an IDE, to show the top headers of a module import for navigational purposes.
Is it reasonable to at least have an alternative implementation for it (e.g. from the module headers find the headers that were not included from other headers), not sure if it'd be straightforward or not.

Jan 18 2023, 10:00 AM · Restricted Project, Restricted Project

Jan 13 2023

akyrtzi accepted D141625: [DeclContext] Sort the Decls before adding into DeclContext.
Jan 13 2023, 5:28 PM · Restricted Project, Restricted Project
akyrtzi added a comment to D141625: [DeclContext] Sort the Decls before adding into DeclContext.

Yeah, you mainly need more than 32 decls to exceed the small storage of Scope::DeclSetTy.

Jan 13 2023, 3:04 PM · Restricted Project, Restricted Project
akyrtzi accepted D141625: [DeclContext] Sort the Decls before adding into DeclContext.

Is it impractical to add a test for this? Otherwise LGTM.

Jan 13 2023, 1:53 PM · Restricted Project, Restricted Project

Dec 18 2022

akyrtzi added a comment to D140266: [InlineAdvisor] Fix dependencies for InlineAdvisorPlugin.

Committed, thank you for the quick fix! 🙇🏻‍♂️

Dec 18 2022, 1:27 AM · Restricted Project, Restricted Project
akyrtzi committed rGc365fdd8d53c: [InlineAdvisor] Fix dependencies for InlineAdvisorPlugin (authored by IBricchi).
[InlineAdvisor] Fix dependencies for InlineAdvisorPlugin
Dec 18 2022, 1:26 AM · Restricted Project, Restricted Project
akyrtzi closed D140266: [InlineAdvisor] Fix dependencies for InlineAdvisorPlugin.
Dec 18 2022, 1:26 AM · Restricted Project, Restricted Project

Dec 17 2022

akyrtzi accepted D140266: [InlineAdvisor] Fix dependencies for InlineAdvisorPlugin.

Change LGTM, could you get this in soon? 🙏

Dec 17 2022, 4:06 PM · Restricted Project, Restricted Project
akyrtzi added a comment to D139644: [InlineAdvisor] Allow loading advisors as plugins.

Hi @IBricchi, the compiler error is still occurring (as of 1a9dec0dda0064cd0035d70b6534a65856b7a212).
To reproduce create a clean build directory (configure using ninja) and run ninja unittests/Analysis/CMakeFiles/InlineAdvisorPlugin.dir/InlineAdvisorPlugin.cpp.o.

Dec 17 2022, 1:50 PM · Restricted Project, Restricted Project

Dec 15 2022

akyrtzi committed rG59df56413bdc: [clang/Lexer] Enhance `Lexer::getImmediateMacroNameForDiagnostics` to return a… (authored by akyrtzi).
[clang/Lexer] Enhance `Lexer::getImmediateMacroNameForDiagnostics` to return a…
Dec 15 2022, 10:51 PM · Restricted Project, Restricted Project
akyrtzi closed D140164: [clang/Lexer] Enhance `Lexer::getImmediateMacroNameForDiagnostics` to return a result from non-file buffers.
Dec 15 2022, 10:51 PM · Restricted Project, Restricted Project
akyrtzi updated the diff for D140164: [clang/Lexer] Enhance `Lexer::getImmediateMacroNameForDiagnostics` to return a result from non-file buffers.

Adjust code comment.

Dec 15 2022, 3:31 PM · Restricted Project, Restricted Project
akyrtzi added reviewers for D140164: [clang/Lexer] Enhance `Lexer::getImmediateMacroNameForDiagnostics` to return a result from non-file buffers: jansvoboda11, steven_wu.
Dec 15 2022, 1:38 PM · Restricted Project, Restricted Project
akyrtzi requested review of D140164: [clang/Lexer] Enhance `Lexer::getImmediateMacroNameForDiagnostics` to return a result from non-file buffers.
Dec 15 2022, 1:37 PM · Restricted Project, Restricted Project

Dec 8 2022

akyrtzi added inline comments to D133716: [CAS] Add LLVMCAS library with InMemoryCAS implementation.
Dec 8 2022, 4:08 PM · Restricted Project, Restricted Project
akyrtzi added inline comments to D133716: [CAS] Add LLVMCAS library with InMemoryCAS implementation.
Dec 8 2022, 3:06 PM · Restricted Project, Restricted Project
akyrtzi added inline comments to D139052: [NFC][Profile] Access profile through VirtualFileSystem.
Dec 8 2022, 2:52 PM · Restricted Project, Restricted Project, Restricted Project
akyrtzi added inline comments to D133716: [CAS] Add LLVMCAS library with InMemoryCAS implementation.
Dec 8 2022, 1:48 PM · Restricted Project, Restricted Project
akyrtzi added inline comments to D139115: [clang][ExtractAPI] Add support for single symbol SGF.
Dec 8 2022, 1:43 PM · Restricted Project, Restricted Project
akyrtzi added inline comments to D133716: [CAS] Add LLVMCAS library with InMemoryCAS implementation.
Dec 8 2022, 1:00 PM · Restricted Project, Restricted Project
akyrtzi added inline comments to D133716: [CAS] Add LLVMCAS library with InMemoryCAS implementation.
Dec 8 2022, 11:25 AM · Restricted Project, Restricted Project

Dec 7 2022

akyrtzi added inline comments to D139052: [NFC][Profile] Access profile through VirtualFileSystem.
Dec 7 2022, 5:07 PM · Restricted Project, Restricted Project, Restricted Project
akyrtzi accepted D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file.
Dec 7 2022, 2:45 PM · Restricted Project, Restricted Project

Dec 5 2022

akyrtzi committed rG3ed6311b1b7d: [lldb] Make sure the value of `eSymbolContextVariable` is not conflicting with… (authored by akyrtzi).
[lldb] Make sure the value of `eSymbolContextVariable` is not conflicting with…
Dec 5 2022, 1:54 PM · Restricted Project
akyrtzi closed D139066: [lldb] Make sure the value of `eSymbolContextVariable` is not conflicting with `RESOLVED_FRAME_CODE_ADDR`.
Dec 5 2022, 1:54 PM · Restricted Project, Restricted Project
akyrtzi added a comment to D139066: [lldb] Make sure the value of `eSymbolContextVariable` is not conflicting with `RESOLVED_FRAME_CODE_ADDR`.

I prefer my original version because:

  • eSymbolContextLastItem is not an appropriate name for collection of bits, it should be named like eSymbolContextReallyEverything or something, which then makes things a bit confusing due to having multiple "everything" enums.
  • I like the code consistency and readability of all RESOLVED_* macros here being shifts by one of the previous bit. When I first read this code I had to stop and think about why RESOLVED_FRAME_CODE_ADDR is different than the rest; "eSymbolContextLastItem << 1" is clearer to understand IMO, particularly in the context of the other macros.
Dec 5 2022, 11:30 AM · Restricted Project, Restricted Project
akyrtzi added a comment to D139066: [lldb] Make sure the value of `eSymbolContextVariable` is not conflicting with `RESOLVED_FRAME_CODE_ADDR`.

FWIW I think the only change needed to the original patch is to keep using #define RESOLVED_FRAME_CODE_ADDR (uint32_t(eSymbolContextEverything + 1)) but switch to the new eSymbolContextLastItem that is defined. Possibly the comment about what this code is doing could be made a little clearer, because it is definitely not. :)

Thank you for the feedback, but it's unclear to me what you mean, are you saying leave the #define RESOLVED_FRAME_CODE_ADDR line unmodified? If yes, what does "switch to the new eSymbolContextLastItem" mean?

Dec 5 2022, 10:47 AM · Restricted Project, Restricted Project

Dec 2 2022

akyrtzi added inline comments to D139052: [NFC][Profile] Access profile through VirtualFileSystem.
Dec 2 2022, 3:34 PM · Restricted Project, Restricted Project, Restricted Project
akyrtzi committed rGa9e24afdc706: [lldb/unittests/CMakeLists.txt] Remove extra compiler flag `-include… (authored by akyrtzi).
[lldb/unittests/CMakeLists.txt] Remove extra compiler flag `-include…
Dec 2 2022, 10:46 AM · Restricted Project
akyrtzi closed D139058: [lldb/unittests/CMakeLists.txt] Remove extra compiler flag `-include gtest_common.h`, NFC.
Dec 2 2022, 10:46 AM · Restricted Project, Restricted Project
akyrtzi committed rG36bea8759d1f: [lldb] Fix the `dwarf` log descriptions (authored by akyrtzi).
[lldb] Fix the `dwarf` log descriptions
Dec 2 2022, 10:31 AM · Restricted Project
akyrtzi closed D139061: [lldb] Fix the `dwarf` log descriptions.
Dec 2 2022, 10:30 AM · Restricted Project, Restricted Project

Dec 1 2022

akyrtzi added a comment to D139066: [lldb] Make sure the value of `eSymbolContextVariable` is not conflicting with `RESOLVED_FRAME_CODE_ADDR`.

FWIW I think the only change needed to the original patch is to keep using #define RESOLVED_FRAME_CODE_ADDR (uint32_t(eSymbolContextEverything + 1)) but switch to the new eSymbolContextLastItem that is defined. Possibly the comment about what this code is doing could be made a little clearer, because it is definitely not. :)

Dec 1 2022, 11:13 AM · Restricted Project, Restricted Project

Nov 30 2022

akyrtzi added reviewers for D139066: [lldb] Make sure the value of `eSymbolContextVariable` is not conflicting with `RESOLVED_FRAME_CODE_ADDR`: aprantl, JDevlieghere.
Nov 30 2022, 5:12 PM · Restricted Project, Restricted Project
akyrtzi requested review of D139066: [lldb] Make sure the value of `eSymbolContextVariable` is not conflicting with `RESOLVED_FRAME_CODE_ADDR`.
Nov 30 2022, 5:11 PM · Restricted Project, Restricted Project
akyrtzi added reviewers for D139061: [lldb] Fix the `dwarf` log descriptions: aprantl, JDevlieghere.
Nov 30 2022, 4:38 PM · Restricted Project, Restricted Project
akyrtzi requested review of D139061: [lldb] Fix the `dwarf` log descriptions.
Nov 30 2022, 4:38 PM · Restricted Project, Restricted Project
akyrtzi added reviewers for D139058: [lldb/unittests/CMakeLists.txt] Remove extra compiler flag `-include gtest_common.h`, NFC: aprantl, JDevlieghere.
Nov 30 2022, 4:23 PM · Restricted Project, Restricted Project
akyrtzi requested review of D139058: [lldb/unittests/CMakeLists.txt] Remove extra compiler flag `-include gtest_common.h`, NFC.
Nov 30 2022, 4:23 PM · Restricted Project, Restricted Project

Nov 5 2022

akyrtzi committed rG05a165bf0434: [llvm/cmake/config-ix.cmake] If `LD64_EXECUTABLE` is already set, avoid the… (authored by akyrtzi).
[llvm/cmake/config-ix.cmake] If `LD64_EXECUTABLE` is already set, avoid the…
Nov 5 2022, 9:01 PM · Restricted Project, Restricted Project

Oct 31 2022

akyrtzi added a comment to D137101: [CodeView] Replace GHASH hasher by BLAKE3.

@akyrtzi , FYI, thanks again for adding blake3 support.

Oct 31 2022, 1:29 PM · Restricted Project, Restricted Project, Restricted Project

Oct 14 2022

akyrtzi committed rGd877e3fe7167: [Transforms/ObjCARC] Fix non-deterministic output of `ObjCARCOptPass` (authored by akyrtzi).
[Transforms/ObjCARC] Fix non-deterministic output of `ObjCARCOptPass`
Oct 14 2022, 12:27 PM · Restricted Project, Restricted Project
akyrtzi closed D135376: [Transforms/ObjCARC] Fix non-deterministic output of `ObjCARCOptPass`.
Oct 14 2022, 12:27 PM · Restricted Project, Restricted Project
akyrtzi added inline comments to D135376: [Transforms/ObjCARC] Fix non-deterministic output of `ObjCARCOptPass`.
Oct 14 2022, 10:41 AM · Restricted Project, Restricted Project

Oct 12 2022

akyrtzi updated the diff for D135376: [Transforms/ObjCARC] Fix non-deterministic output of `ObjCARCOptPass`.

Fix the patch.

Oct 12 2022, 2:01 PM · Restricted Project, Restricted Project
akyrtzi added inline comments to D135376: [Transforms/ObjCARC] Fix non-deterministic output of `ObjCARCOptPass`.
Oct 12 2022, 1:59 PM · Restricted Project, Restricted Project
akyrtzi updated the diff for D135376: [Transforms/ObjCARC] Fix non-deterministic output of `ObjCARCOptPass`.

ProvenanceAnalysis::relatedPHI: Return true only if both comparePHISources() calls return true

Oct 12 2022, 1:58 PM · Restricted Project, Restricted Project
akyrtzi added inline comments to D135376: [Transforms/ObjCARC] Fix non-deterministic output of `ObjCARCOptPass`.
Oct 12 2022, 8:19 AM · Restricted Project, Restricted Project

Oct 11 2022

akyrtzi added a comment to D135118: [clang/Sema] Fix non-deterministic order for certain kind of diagnostics.

@nikic, it seems to have recovered (http://llvm-compile-time-tracker.com/compare.php?from=c49cde6467f9bf200640db763152a9dc7f009520&to=0456acbfb942f127359a8defd1b4f1f44420df3e&stat=instructions) let me know if you have concerns.

Oct 11 2022, 4:00 PM · Restricted Project, Restricted Project
akyrtzi accepted D135634: [clang][modules] Serialize VFS overlay paths into PCMs.
Oct 11 2022, 3:47 PM · Restricted Project, Restricted Project, Restricted Project
akyrtzi committed rG0456acbfb942: [clang/Sema] Follow-up for fix of non-deterministic order of `-Wunused… (authored by akyrtzi).
[clang/Sema] Follow-up for fix of non-deterministic order of `-Wunused…
Oct 11 2022, 1:44 PM · Restricted Project, Restricted Project
akyrtzi closed D135490: [clang/Sema] Follow-up for fix of non-deterministic order of `-Wunused-variable` diagnostic.
Oct 11 2022, 1:43 PM · Restricted Project, Restricted Project