- User Since
- Feb 11 2014, 3:42 PM (437 w, 2 d)
Avoid changing the SourceManager::getFilename() implementation.
Update clang-tools-extra/test/pp-trace/pp-trace-include.cpp to accomodate for PrevFID getting a value and
preserve using getFileEntryForID() for the SourceManager::getFilename() implementation.
Pass a value for PrevFID for FileChanged() callback as well, for PPCallbacks::EnterFile reason.
Wed, Jun 29
Tue, Jun 28
Wed, Jun 22
Tue, Jun 21
Mon, Jun 20
Sat, Jun 18
Make sure to disable blake3 SIMD for i386 architecture.
Wed, Jun 15
Use target_include_directories() to add include search paths only for the targets the depend on gRPC
Mon, Jun 13
Add more comments about the use of SkippingExcludedConditionalBlock and move the new Preprocessor fields towards the top of the class.
Assert that SkipExcludedConditionalBlock() is not recursively called.
Fri, Jun 10
Remove // clang-format off annotation.
Thu, Jun 9
Wed, Jun 8
Tue, Jun 7
Disable clang-format checks for the test file.
Remove the parameter from documentation comment as well.
No need to add '#' for the fixit since we have the range of the directive identifier to fix.
May 31 2022
It's not clear to me what symbolizer/scripts/ar_to_bc.sh is doing exactly, will there not be an issue (e.g. linker error?) when it's trying to link the object files while the .s derived ones were excluded?
Should this patch also remove -DLLVM_DISABLE_ASSEMBLY_FILES=ON from symbolizer/scripts/build_symbolizer.sh?
May 28 2022
May 26 2022
The assertion was assuming "the expression doesn't need cleanups", have you considered adding a test that checks that the destructor of the temporary inside the asm statement is called, to ensure these temporaries are properly handled?
May 24 2022
Thank you @jansvoboda11 for reviewing and helping me qualify the changes! 🙇🏻♂️
May 23 2022
This has been superseded by the above set of patches.
Add documentation comments for a couple of fields of Scanner in DependencyDirectivesScanner.cpp
May 21 2022
Update due to source change in the previous patch (https://reviews.llvm.org/D125487)
Remove DependencyScanningFilesystem::disableDirectivesScanning() function.
Unlike source minimization which changes the source contents size and needed to be disabled in certain situations, directive lexing keeps the same contents size and does not need to be disabled.
May 16 2022
Make sure to enable line comments for dependency directive lexing.
May 15 2022
Fix issue where an empty '#' in a line was causing the immediately following preprocessor directive to be skipped.
May 12 2022
Rename the clang-scan-deps flag from "-preprocess-directives-scan" to "-preprocess-dependency-directives"
in PreprocessorOptions.h to accommodate the modules build.
I've split this in smaller patches:
May 5 2022
Since the issue is specific to enumerators I would recommend against increasing the size of DeclBase, which would increase the size of every single Decl in the AST.
May 4 2022
My recommendation is that indexing belongs to 'utility', as @stefanhaller mentioned the user is actively depending on functionality coming from the index.
That said, you may want to consider dynamically switching to background if running on laptop with battery, or other heuristics, but that could be a follow-up enhancement, I don't think always using 'background' is appropriate.
May 3 2022
May 2 2022
Apr 29 2022
Update documentation comments for Lexer::seek()
Apr 28 2022
@jansvoboda11 thanks for reviewing! I've changed APIs to use a reference instead of a pointer and removed the unnecessary check and heap allocations.
Change APIs to accept a reference of ExcludedPreprocessorDirectiveSkipMapping instead of a pointer, since it is required now.