Avoid changing the SourceManager::getFilename() implementation.

Update clang-tools-extra/test/pp-trace/pp-trace-include.cpp to accomodate for PrevFID getting a value and
preserve using getFileEntryForID() for the SourceManager::getFilename() implementation.

Pass a value for PrevFID for FileChanged() callback as well, for PPCallbacks::EnterFile reason.

Use Optional::value_or()

In D128132#3596682, @mstorsjo wrote:

This LGTM, it seems to build correctly for me in all my test environments!

Make sure to disable blake3 SIMD for i386 architecture.

Use target_include_directories() to add include search paths only for the targets the depend on gRPC

Add more comments about the use of SkippingExcludedConditionalBlock and move the new Preprocessor fields towards the top of the class.

Assert that SkipExcludedConditionalBlock() is not recursively called.

Remove // clang-format off annotation.

Disable clang-format checks for the test file.

Remove the parameter from documentation comment as well.

No need to add '#' for the fixit since we have the range of the directive identifier to fix.

It's not clear to me what symbolizer/scripts/ar_to_bc.sh is doing exactly, will there not be an issue (e.g. linker error?) when it's trying to link the object files while the .s derived ones were excluded?

Should this patch also remove -DLLVM_DISABLE_ASSEMBLY_FILES=ON from symbolizer/scripts/build_symbolizer.sh?

b4c83a13f664582015ea22924b9a0c6290d41f5b

b4c83a13f664582015ea22924b9a0c6290d41f5b

The assertion was assuming "the expression doesn't need cleanups", have you considered adding a test that checks that the destructor of the temporary inside the asm statement is called, to ensure these temporaries are properly handled?

Thank you @jansvoboda11 for reviewing and helping me qualify the changes! 🙇🏻‍♂️

This has been superseded by the above set of patches.

Add documentation comments for a couple of fields of Scanner in DependencyDirectivesScanner.cpp

Update due to source change in the previous patch (https://reviews.llvm.org/D125487)

Remove DependencyScanningFilesystem::disableDirectivesScanning() function.
Unlike source minimization which changes the source contents size and needed to be disabled in certain situations, directive lexing keeps the same contents size and does not need to be disabled.

Make sure to enable line comments for dependency directive lexing.

Fix issue where an empty '#' in a line was causing the immediately following preprocessor directive to be skipped.

In D125488#3510329, @dexonsmith wrote:

Seems unfortunate to have a temporary regression in the commit stack, since then you can't push incrementally (or bisect). Can the prior patch leave behind the feature in the DependencyFilesystem, and this patch delete it now that clang-scan-deps doesn't depend on it for performance? (Or ignore me if I'm still not understanding...)

In D125488#3510297, @dexonsmith wrote:

[To be clear, my question was because I don't see this patch deleting the code path that minimizes / saves-minimized sources. Can/should we delete the "minimize sources" code path?]

In D125488#3510214, @dexonsmith wrote:

Is there code in DepFS that can/should be deleted as part of this patch, or in a follow-up, or is it still around as an option?

Rename the clang-scan-deps flag from "-preprocess-directives-scan" to "-preprocess-dependency-directives"

Added

#include "clang/Basic/FileEntry.h"

in PreprocessorOptions.h to accommodate the modules build.

I've split this in smaller patches:

Since the issue is specific to enumerators I would recommend against increasing the size of DeclBase, which would increase the size of every single Decl in the AST.

In D124687#3486473, @akyrtzi wrote:

In D124687#3485710, @tschuett wrote:

Is there overhead in the non dependency scanning mode?

Good suggestion, I'll do some measurements and get back to you.

My recommendation is that indexing belongs to 'utility', as @stefanhaller mentioned the user is actively depending on functionality coming from the index.
That said, you may want to consider dynamically switching to background if running on laptop with battery, or other heuristics, but that could be a follow-up enhancement, I don't think always using 'background' is appropriate.

In D124687#3485710, @tschuett wrote:

Could you split this into smaller patches?

Update documentation comments for Lexer::seek()

@jansvoboda11 thanks for reviewing! I've changed APIs to use a reference instead of a pointer and removed the unnecessary check and heap allocations.

Change APIs to accept a reference of ExcludedPreprocessorDirectiveSkipMapping instead of a pointer, since it is required now.