- User Since
- Feb 11 2014, 3:42 PM (475 w, 2 d)
Mon, Mar 13
Tue, Mar 7
Mon, Mar 6
Is this observable from a clang command line tool? Be nice to have a lit test.
Fri, Mar 3
Avoid passing a new IgnoringDiagConsumer for the test since it's unused.
Feb 14 2023
Thank you for the fix! 🙇🏻♂️
Feb 13 2023
.s files can use the preprocessor as well. I'd recommend to add a file that do the renames using #define, like in blake3_impl.h, and include it in all the .s files.
That way the changes to the original files is minimized, which is useful for pulling in future changes from the original repo.
Feb 10 2023
Feb 8 2023
Feb 7 2023
Feb 6 2023
Feb 2 2023
would be great to test it more in a semantic way if possible
Jan 31 2023
I've reverted this change from main branch, let me know if there's anything I can do to help with addressing the build issue.
Jan 29 2023
Hi @domada, these changes break compilation of clang, with such build error:
FAILED: tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ASTContext.cpp.o <clang invocation> In file included from /llvm-project/clang/lib/AST/ASTContext.cpp:81: In file included from /llvm-project/llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:17: In file included from /llvm-project/llvm/include/llvm/Analysis/MemorySSAUpdater.h:37: In file included from /llvm-project/llvm/include/llvm/Analysis/MemorySSA.h:93: In file included from /llvm-project/llvm/include/llvm/Analysis/AliasAnalysis.h:44: In file included from /llvm-project/llvm/include/llvm/IR/PassManager.h:45: In file included from /llvm-project/llvm/include/llvm/IR/Function.h:25: In file included from /llvm-project/llvm/include/llvm/IR/Argument.h:17: /llvm-project/llvm/include/llvm/IR/Attributes.h:90:14: fatal error: 'llvm/IR/Attributes.inc' file not found
Jan 21 2023
Jan 20 2023
Jan 19 2023
Add test case for dependency directive lexing of ill-formed include inside __has_include
Jan 18 2023
This is useful for functionality, like in an IDE, to show the top headers of a module import for navigational purposes.
Is it reasonable to at least have an alternative implementation for it (e.g. from the module headers find the headers that were not included from other headers), not sure if it'd be straightforward or not.
Jan 13 2023
Yeah, you mainly need more than 32 decls to exceed the small storage of Scope::DeclSetTy.
Is it impractical to add a test for this? Otherwise LGTM.
Dec 18 2022
Committed, thank you for the quick fix! 🙇🏻♂️
Dec 17 2022
Change LGTM, could you get this in soon? 🙏
Hi @IBricchi, the compiler error is still occurring (as of 1a9dec0dda0064cd0035d70b6534a65856b7a212).
To reproduce create a clean build directory (configure using ninja) and run ninja unittests/Analysis/CMakeFiles/InlineAdvisorPlugin.dir/InlineAdvisorPlugin.cpp.o.
Dec 15 2022
Adjust code comment.
Dec 8 2022
Dec 7 2022
Dec 5 2022
I prefer my original version because:
- eSymbolContextLastItem is not an appropriate name for collection of bits, it should be named like eSymbolContextReallyEverything or something, which then makes things a bit confusing due to having multiple "everything" enums.
- I like the code consistency and readability of all RESOLVED_* macros here being shifts by one of the previous bit. When I first read this code I had to stop and think about why RESOLVED_FRAME_CODE_ADDR is different than the rest; "eSymbolContextLastItem << 1" is clearer to understand IMO, particularly in the context of the other macros.
Dec 2 2022
Dec 1 2022
Nov 30 2022
Nov 5 2022
Oct 31 2022
Oct 14 2022
Oct 12 2022
Fix the patch.
ProvenanceAnalysis::relatedPHI: Return true only if both comparePHISources() calls return true
Oct 11 2022
@nikic, it seems to have recovered (http://llvm-compile-time-tracker.com/compare.php?from=c49cde6467f9bf200640db763152a9dc7f009520&to=0456acbfb942f127359a8defd1b4f1f44420df3e&stat=instructions) let me know if you have concerns.