Page MenuHomePhabricator

akyrtzi (Argyrios Kyrtzidis)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 11 2014, 3:42 PM (437 w, 2 d)

Recent Activity

Today

akyrtzi updated the diff for D128947: [Lex] Introduce `PPCallbacks::LexedFileChanged()` preprocessor callback.

Avoid changing the SourceManager::getFilename() implementation.

Fri, Jul 1, 8:25 AM · Restricted Project, Restricted Project, Restricted Project

Yesterday

akyrtzi updated the diff for D128947: [Lex] Introduce `PPCallbacks::LexedFileChanged()` preprocessor callback.

Update clang-tools-extra/test/pp-trace/pp-trace-include.cpp to accomodate for PrevFID getting a value and
preserve using getFileEntryForID() for the SourceManager::getFilename() implementation.

Thu, Jun 30, 10:36 PM · Restricted Project, Restricted Project, Restricted Project
akyrtzi updated the diff for D128947: [Lex] Introduce `PPCallbacks::LexedFileChanged()` preprocessor callback.

Pass a value for PrevFID for FileChanged() callback as well, for PPCallbacks::EnterFile reason.

Thu, Jun 30, 4:56 PM · Restricted Project, Restricted Project, Restricted Project
akyrtzi updated the diff for D128947: [Lex] Introduce `PPCallbacks::LexedFileChanged()` preprocessor callback.

Use Optional::value_or()

Thu, Jun 30, 4:44 PM · Restricted Project, Restricted Project, Restricted Project
akyrtzi added inline comments to D128947: [Lex] Introduce `PPCallbacks::LexedFileChanged()` preprocessor callback.
Thu, Jun 30, 4:32 PM · Restricted Project, Restricted Project, Restricted Project
akyrtzi added reviewers for D128947: [Lex] Introduce `PPCallbacks::LexedFileChanged()` preprocessor callback: benlangmuir, jansvoboda11.
Thu, Jun 30, 2:29 PM · Restricted Project, Restricted Project, Restricted Project
akyrtzi requested review of D128947: [Lex] Introduce `PPCallbacks::LexedFileChanged()` preprocessor callback.
Thu, Jun 30, 2:29 PM · Restricted Project, Restricted Project, Restricted Project

Wed, Jun 29

akyrtzi committed rGc68b8c84eb17: [Lex] Make sure to notify `MultipleIncludeOpt` for "read tokens" during fast… (authored by akyrtzi).
[Lex] Make sure to notify `MultipleIncludeOpt` for "read tokens" during fast…
Wed, Jun 29, 3:51 PM · Restricted Project, Restricted Project
akyrtzi closed D128772: [Lex] Make sure to notify `MultipleIncludeOpt` for "read tokens" during fast dependency directive lexing.
Wed, Jun 29, 3:51 PM · Restricted Project, Restricted Project
akyrtzi added inline comments to D128772: [Lex] Make sure to notify `MultipleIncludeOpt` for "read tokens" during fast dependency directive lexing.
Wed, Jun 29, 3:29 PM · Restricted Project, Restricted Project

Tue, Jun 28

akyrtzi added a reviewer for D128772: [Lex] Make sure to notify `MultipleIncludeOpt` for "read tokens" during fast dependency directive lexing: benlangmuir.
Tue, Jun 28, 5:09 PM · Restricted Project, Restricted Project
akyrtzi added a reviewer for D128772: [Lex] Make sure to notify `MultipleIncludeOpt` for "read tokens" during fast dependency directive lexing: jansvoboda11.
Tue, Jun 28, 5:00 PM · Restricted Project, Restricted Project
akyrtzi requested review of D128772: [Lex] Make sure to notify `MultipleIncludeOpt` for "read tokens" during fast dependency directive lexing.
Tue, Jun 28, 4:59 PM · Restricted Project, Restricted Project

Wed, Jun 22

akyrtzi committed rG69d943747285: [Support/BLAKE3] Fix error in prior commit, apply `-mavx512vl` for… (authored by akyrtzi).
[Support/BLAKE3] Fix error in prior commit, apply `-mavx512vl` for…
Wed, Jun 22, 10:51 AM · Restricted Project, Restricted Project

Tue, Jun 21

akyrtzi committed rGacd64d8e85f6: [Support/BLAKE3] CMake: Check for `IS_X64` or `CMAKE_OSX_ARCHITECTURES` before… (authored by akyrtzi).
[Support/BLAKE3] CMake: Check for `IS_X64` or `CMAKE_OSX_ARCHITECTURES` before…
Tue, Jun 21, 9:48 AM · Restricted Project, Restricted Project

Mon, Jun 20

akyrtzi committed rGbb095880f87d: [Support/BLAKE3] Do a CMake check for the `-mavx512vl` flag before applying it (authored by akyrtzi).
[Support/BLAKE3] Do a CMake check for the `-mavx512vl` flag before applying it
Mon, Jun 20, 10:04 PM · Restricted Project, Restricted Project
akyrtzi committed rG34362f96d2c0: [Support/BLAKE3] Enable the SIMD implementations for macOS universal builds (authored by akyrtzi).
[Support/BLAKE3] Enable the SIMD implementations for macOS universal builds
Mon, Jun 20, 9:19 PM · Restricted Project, Restricted Project
akyrtzi closed D128132: [Support/BLAKE3] Enable the SIMD implementations for macOS universal builds.
Mon, Jun 20, 9:19 PM · Restricted Project, Restricted Project
akyrtzi added a comment to D128132: [Support/BLAKE3] Enable the SIMD implementations for macOS universal builds.

This LGTM, it seems to build correctly for me in all my test environments!

Mon, Jun 20, 9:16 PM · Restricted Project, Restricted Project

Sat, Jun 18

akyrtzi added a reviewer for D128132: [Support/BLAKE3] Enable the SIMD implementations for macOS universal builds: mstorsjo.
Sat, Jun 18, 11:05 PM · Restricted Project, Restricted Project
akyrtzi updated the diff for D128132: [Support/BLAKE3] Enable the SIMD implementations for macOS universal builds.

Make sure to disable blake3 SIMD for i386 architecture.

Sat, Jun 18, 11:04 PM · Restricted Project, Restricted Project
akyrtzi requested review of D128132: [Support/BLAKE3] Enable the SIMD implementations for macOS universal builds.
Sat, Jun 18, 10:43 PM · Restricted Project, Restricted Project

Wed, Jun 15

akyrtzi committed rG20d5a8613423: [CMake] Fix `FindGRPC.cmake` for setting up gRPC related libraries for… (authored by akyrtzi).
[CMake] Fix `FindGRPC.cmake` for setting up gRPC related libraries for…
Wed, Jun 15, 4:12 PM · Restricted Project, Restricted Project
akyrtzi closed D127893: [CMake] Fix `FindGRPC.cmake` for setting up gRPC related libraries for macOS+homebrew context.
Wed, Jun 15, 4:11 PM · Restricted Project, Restricted Project
akyrtzi added inline comments to D127893: [CMake] Fix `FindGRPC.cmake` for setting up gRPC related libraries for macOS+homebrew context.
Wed, Jun 15, 1:26 PM · Restricted Project, Restricted Project
akyrtzi updated the diff for D127893: [CMake] Fix `FindGRPC.cmake` for setting up gRPC related libraries for macOS+homebrew context.

Use target_include_directories() to add include search paths only for the targets the depend on gRPC

Wed, Jun 15, 1:24 PM · Restricted Project, Restricted Project
akyrtzi added inline comments to D127893: [CMake] Fix `FindGRPC.cmake` for setting up gRPC related libraries for macOS+homebrew context.
Wed, Jun 15, 1:05 PM · Restricted Project, Restricted Project
akyrtzi added a reviewer for D127893: [CMake] Fix `FindGRPC.cmake` for setting up gRPC related libraries for macOS+homebrew context: compnerd.
Wed, Jun 15, 12:12 PM · Restricted Project, Restricted Project
akyrtzi requested review of D127893: [CMake] Fix `FindGRPC.cmake` for setting up gRPC related libraries for macOS+homebrew context.
Wed, Jun 15, 12:12 PM · Restricted Project, Restricted Project

Mon, Jun 13

akyrtzi committed rGf7e19a592842: [Lex] Keep track of skipped preprocessor blocks and advance the lexer directly… (authored by akyrtzi).
[Lex] Keep track of skipped preprocessor blocks and advance the lexer directly…
Mon, Jun 13, 9:47 PM · Restricted Project, Restricted Project
akyrtzi closed D127379: [Lex] Keep track of skipped preprocessor blocks and advance the lexer directly if they are revisited.
Mon, Jun 13, 9:46 PM · Restricted Project, Restricted Project
akyrtzi updated the diff for D127379: [Lex] Keep track of skipped preprocessor blocks and advance the lexer directly if they are revisited.

Add more comments about the use of SkippingExcludedConditionalBlock and move the new Preprocessor fields towards the top of the class.

Mon, Jun 13, 6:18 PM · Restricted Project, Restricted Project
akyrtzi added inline comments to D127379: [Lex] Keep track of skipped preprocessor blocks and advance the lexer directly if they are revisited.
Mon, Jun 13, 1:56 PM · Restricted Project, Restricted Project
akyrtzi updated the diff for D127379: [Lex] Keep track of skipped preprocessor blocks and advance the lexer directly if they are revisited.

Assert that SkipExcludedConditionalBlock() is not recursively called.

Mon, Jun 13, 1:55 PM · Restricted Project, Restricted Project
akyrtzi added inline comments to D127379: [Lex] Keep track of skipped preprocessor blocks and advance the lexer directly if they are revisited.
Mon, Jun 13, 11:43 AM · Restricted Project, Restricted Project

Fri, Jun 10

akyrtzi committed rGfbaa8b9ae5f3: [Lex] Fix `fixits` for typo-corrections of preprocessing directives within… (authored by akyrtzi).
[Lex] Fix `fixits` for typo-corrections of preprocessing directives within…
Fri, Jun 10, 1:32 PM · Restricted Project, Restricted Project
akyrtzi closed D127251: [Lex] Fix `fixits` for typo-corrections of preprocessing directives within skipped blocks.
Fri, Jun 10, 1:32 PM · Restricted Project, Restricted Project
akyrtzi updated the diff for D127251: [Lex] Fix `fixits` for typo-corrections of preprocessing directives within skipped blocks.

Remove // clang-format off annotation.

Fri, Jun 10, 1:20 PM · Restricted Project, Restricted Project

Thu, Jun 9

akyrtzi added inline comments to D127251: [Lex] Fix `fixits` for typo-corrections of preprocessing directives within skipped blocks.
Thu, Jun 9, 2:20 PM · Restricted Project, Restricted Project
akyrtzi added inline comments to D127251: [Lex] Fix `fixits` for typo-corrections of preprocessing directives within skipped blocks.
Thu, Jun 9, 2:08 PM · Restricted Project, Restricted Project

Wed, Jun 8

akyrtzi added reviewers for D127379: [Lex] Keep track of skipped preprocessor blocks and advance the lexer directly if they are revisited: jansvoboda11, benlangmuir.
Wed, Jun 8, 10:33 PM · Restricted Project, Restricted Project
akyrtzi requested review of D127379: [Lex] Keep track of skipped preprocessor blocks and advance the lexer directly if they are revisited.
Wed, Jun 8, 10:32 PM · Restricted Project, Restricted Project
akyrtzi added a reviewer for D127251: [Lex] Fix `fixits` for typo-corrections of preprocessing directives within skipped blocks: jansvoboda11.
Wed, Jun 8, 10:31 PM · Restricted Project, Restricted Project

Tue, Jun 7

akyrtzi updated the diff for D127251: [Lex] Fix `fixits` for typo-corrections of preprocessing directives within skipped blocks.

Disable clang-format checks for the test file.

Tue, Jun 7, 3:58 PM · Restricted Project, Restricted Project
akyrtzi updated the diff for D127251: [Lex] Fix `fixits` for typo-corrections of preprocessing directives within skipped blocks.

Remove the parameter from documentation comment as well.

Tue, Jun 7, 2:28 PM · Restricted Project, Restricted Project
akyrtzi updated the diff for D127251: [Lex] Fix `fixits` for typo-corrections of preprocessing directives within skipped blocks.

No need to add '#' for the fixit since we have the range of the directive identifier to fix.

Tue, Jun 7, 1:51 PM · Restricted Project, Restricted Project
akyrtzi added reviewers for D127251: [Lex] Fix `fixits` for typo-corrections of preprocessing directives within skipped blocks: ken-matsui, aaron.ballman.
Tue, Jun 7, 1:42 PM · Restricted Project, Restricted Project
akyrtzi requested review of D127251: [Lex] Fix `fixits` for typo-corrections of preprocessing directives within skipped blocks.
Tue, Jun 7, 1:41 PM · Restricted Project, Restricted Project

May 31 2022

akyrtzi added a comment to D126728: ar_to_bc.sh: Ignore non-bitcode files in archives.

It's not clear to me what symbolizer/scripts/ar_to_bc.sh is doing exactly, will there not be an issue (e.g. linker error?) when it's trying to link the object files while the .s derived ones were excluded?

May 31 2022, 4:16 PM · Restricted Project, Restricted Project
akyrtzi accepted D126728: ar_to_bc.sh: Ignore non-bitcode files in archives.

Should this patch also remove -DLLVM_DISABLE_ASSEMBLY_FILES=ON from symbolizer/scripts/build_symbolizer.sh?

May 31 2022, 3:48 PM · Restricted Project, Restricted Project

May 28 2022

akyrtzi committed rGfad6e37995b4: [Lex] Fix crash during dependency scanning while skipping an unmatched `#if` (authored by akyrtzi).
[Lex] Fix crash during dependency scanning while skipping an unmatched `#if`
May 28 2022, 12:01 AM · Restricted Project, Restricted Project

May 26 2022

akyrtzi committed rGedcd06ba8b41: [test/ClangScanDeps] Add a target triple for `macro-expansions.cpp` (authored by akyrtzi).
[test/ClangScanDeps] Add a target triple for `macro-expansions.cpp`
May 26 2022, 5:22 PM · Restricted Project, Restricted Project
akyrtzi accepted D125936: [Sema] Relax an assertion in BuildStmtExpr.
May 26 2022, 3:16 PM · Restricted Project, Restricted Project
akyrtzi closed D125488: [Preprocessor] Make the special lexing for dependency scanning a first-class feature of the `Preprocessor` and `Lexer`.

b4c83a13f664582015ea22924b9a0c6290d41f5b

May 26 2022, 1:51 PM · Restricted Project, Restricted Project
akyrtzi closed D125487: [Tooling/DependencyScanning] Refactor dependency scanning to produce pre-lexed preprocessor directive tokens, instead of minimized sources.

b4c83a13f664582015ea22924b9a0c6290d41f5b

May 26 2022, 1:51 PM · Restricted Project, Restricted Project
akyrtzi committed rGb4c83a13f664: [Tooling/DependencyScanning & Preprocessor] Refactor dependency scanning to… (authored by akyrtzi).
[Tooling/DependencyScanning & Preprocessor] Refactor dependency scanning to…
May 26 2022, 1:01 PM · Restricted Project, Restricted Project
akyrtzi committed rGb58a420ff4f9: [Tooling/DependencyScanning] Rename refactorings towards transitioning… (authored by akyrtzi).
[Tooling/DependencyScanning] Rename refactorings towards transitioning…
May 26 2022, 1:01 PM · Restricted Project, Restricted Project
akyrtzi closed D125486: [Tooling/DependencyScanning] Remove `ExcludedPreprocessorDirectiveSkipMapping` and related functionality.
May 26 2022, 1:01 PM · Restricted Project, Restricted Project
akyrtzi closed D125484: [Tooling/DependencyScanning] Rename refactorings towards transitioning dependency scanning to use pre-lexed preprocessor directive tokens.
May 26 2022, 1:01 PM · Restricted Project, Restricted Project
akyrtzi added a comment to D125936: [Sema] Relax an assertion in BuildStmtExpr.

The assertion was assuming "the expression doesn't need cleanups", have you considered adding a test that checks that the destructor of the temporary inside the asm statement is called, to ensure these temporaries are properly handled?

May 26 2022, 11:07 AM · Restricted Project, Restricted Project

May 24 2022

akyrtzi added a comment to D125488: [Preprocessor] Make the special lexing for dependency scanning a first-class feature of the `Preprocessor` and `Lexer`.

Thank you @jansvoboda11 for reviewing and helping me qualify the changes! 🙇🏻‍♂️

May 24 2022, 9:58 AM · Restricted Project, Restricted Project

May 23 2022

akyrtzi abandoned D124687: [Tooling/DependencyScanning & Preprocessor] Refactor dependency scanning to record and use pre-lexed preprocessor directive tokens, instead of minimized sources.

This has been superseded by the above set of patches.

May 23 2022, 11:35 AM · Restricted Project, Restricted Project
akyrtzi added inline comments to D125487: [Tooling/DependencyScanning] Refactor dependency scanning to produce pre-lexed preprocessor directive tokens, instead of minimized sources.
May 23 2022, 11:02 AM · Restricted Project, Restricted Project
akyrtzi updated the diff for D125487: [Tooling/DependencyScanning] Refactor dependency scanning to produce pre-lexed preprocessor directive tokens, instead of minimized sources.

Add documentation comments for a couple of fields of Scanner in DependencyDirectivesScanner.cpp

May 23 2022, 11:00 AM · Restricted Project, Restricted Project

May 21 2022

akyrtzi added inline comments to D125487: [Tooling/DependencyScanning] Refactor dependency scanning to produce pre-lexed preprocessor directive tokens, instead of minimized sources.
May 21 2022, 12:06 PM · Restricted Project, Restricted Project
akyrtzi updated the diff for D125488: [Preprocessor] Make the special lexing for dependency scanning a first-class feature of the `Preprocessor` and `Lexer`.

Update due to source change in the previous patch (https://reviews.llvm.org/D125487)

May 21 2022, 10:54 AM · Restricted Project, Restricted Project
akyrtzi updated the diff for D125487: [Tooling/DependencyScanning] Refactor dependency scanning to produce pre-lexed preprocessor directive tokens, instead of minimized sources.

Remove DependencyScanningFilesystem::disableDirectivesScanning() function.
Unlike source minimization which changes the source contents size and needed to be disabled in certain situations, directive lexing keeps the same contents size and does not need to be disabled.

May 21 2022, 10:46 AM · Restricted Project, Restricted Project

May 16 2022

akyrtzi updated the diff for D125487: [Tooling/DependencyScanning] Refactor dependency scanning to produce pre-lexed preprocessor directive tokens, instead of minimized sources.

Make sure to enable line comments for dependency directive lexing.

May 16 2022, 10:27 AM · Restricted Project, Restricted Project

May 15 2022

akyrtzi updated the diff for D125487: [Tooling/DependencyScanning] Refactor dependency scanning to produce pre-lexed preprocessor directive tokens, instead of minimized sources.

Fix issue where an empty '#' in a line was causing the immediately following preprocessor directive to be skipped.

May 15 2022, 5:14 PM · Restricted Project, Restricted Project

May 12 2022

akyrtzi added a comment to D125488: [Preprocessor] Make the special lexing for dependency scanning a first-class feature of the `Preprocessor` and `Lexer`.

Seems unfortunate to have a temporary regression in the commit stack, since then you can't push incrementally (or bisect). Can the prior patch leave behind the feature in the DependencyFilesystem, and this patch delete it now that clang-scan-deps doesn't depend on it for performance? (Or ignore me if I'm still not understanding...)

May 12 2022, 4:51 PM · Restricted Project, Restricted Project
akyrtzi added a comment to D125488: [Preprocessor] Make the special lexing for dependency scanning a first-class feature of the `Preprocessor` and `Lexer`.

[To be clear, my question was because I don't see this patch deleting the code path that minimizes / saves-minimized sources. Can/should we delete the "minimize sources" code path?]

May 12 2022, 4:30 PM · Restricted Project, Restricted Project
akyrtzi added a comment to D125488: [Preprocessor] Make the special lexing for dependency scanning a first-class feature of the `Preprocessor` and `Lexer`.

Is there code in DepFS that can/should be deleted as part of this patch, or in a follow-up, or is it still around as an option?

May 12 2022, 4:07 PM · Restricted Project, Restricted Project
akyrtzi added inline comments to D125484: [Tooling/DependencyScanning] Rename refactorings towards transitioning dependency scanning to use pre-lexed preprocessor directive tokens.
May 12 2022, 3:31 PM · Restricted Project, Restricted Project
akyrtzi updated the diff for D125484: [Tooling/DependencyScanning] Rename refactorings towards transitioning dependency scanning to use pre-lexed preprocessor directive tokens.

Rename the clang-scan-deps flag from "-preprocess-directives-scan" to "-preprocess-dependency-directives"

May 12 2022, 3:30 PM · Restricted Project, Restricted Project
akyrtzi updated the diff for D125488: [Preprocessor] Make the special lexing for dependency scanning a first-class feature of the `Preprocessor` and `Lexer`.

Added

#include "clang/Basic/FileEntry.h"

in PreprocessorOptions.h to accommodate the modules build.

May 12 2022, 11:35 AM · Restricted Project, Restricted Project
akyrtzi added a comment to D124687: [Tooling/DependencyScanning & Preprocessor] Refactor dependency scanning to record and use pre-lexed preprocessor directive tokens, instead of minimized sources.

I've split this in smaller patches:

May 12 2022, 11:14 AM · Restricted Project, Restricted Project
akyrtzi added reviewers for D125488: [Preprocessor] Make the special lexing for dependency scanning a first-class feature of the `Preprocessor` and `Lexer`: tschuett, jansvoboda11, dexonsmith, Bigcheese, arphaman.
May 12 2022, 11:11 AM · Restricted Project, Restricted Project
akyrtzi added reviewers for D125487: [Tooling/DependencyScanning] Refactor dependency scanning to produce pre-lexed preprocessor directive tokens, instead of minimized sources: tschuett, jansvoboda11, dexonsmith, Bigcheese, arphaman.
May 12 2022, 11:10 AM · Restricted Project, Restricted Project
akyrtzi added reviewers for D125486: [Tooling/DependencyScanning] Remove `ExcludedPreprocessorDirectiveSkipMapping` and related functionality: tschuett, jansvoboda11, dexonsmith, Bigcheese, arphaman.
May 12 2022, 11:09 AM · Restricted Project, Restricted Project
akyrtzi added reviewers for D125484: [Tooling/DependencyScanning] Rename refactorings towards transitioning dependency scanning to use pre-lexed preprocessor directive tokens: tschuett, jansvoboda11, dexonsmith, Bigcheese, arphaman.
May 12 2022, 11:08 AM · Restricted Project, Restricted Project
akyrtzi requested review of D125488: [Preprocessor] Make the special lexing for dependency scanning a first-class feature of the `Preprocessor` and `Lexer`.
May 12 2022, 11:05 AM · Restricted Project, Restricted Project
akyrtzi requested review of D125487: [Tooling/DependencyScanning] Refactor dependency scanning to produce pre-lexed preprocessor directive tokens, instead of minimized sources.
May 12 2022, 11:03 AM · Restricted Project, Restricted Project
akyrtzi requested review of D125486: [Tooling/DependencyScanning] Remove `ExcludedPreprocessorDirectiveSkipMapping` and related functionality.
May 12 2022, 11:00 AM · Restricted Project, Restricted Project
akyrtzi requested review of D125484: [Tooling/DependencyScanning] Rename refactorings towards transitioning dependency scanning to use pre-lexed preprocessor directive tokens.
May 12 2022, 10:57 AM · Restricted Project, Restricted Project

May 5 2022

akyrtzi added a comment to D125061: [clang] A more robust way to attach comments.

Since the issue is specific to enumerators I would recommend against increasing the size of DeclBase, which would increase the size of every single Decl in the AST.

May 5 2022, 9:02 PM · Restricted Project, Restricted Project

May 4 2022

akyrtzi added a comment to D124687: [Tooling/DependencyScanning & Preprocessor] Refactor dependency scanning to record and use pre-lexed preprocessor directive tokens, instead of minimized sources.

Is there overhead in the non dependency scanning mode?

Good suggestion, I'll do some measurements and get back to you.

May 4 2022, 12:37 PM · Restricted Project, Restricted Project
akyrtzi added a comment to D124715: Add ThreadPriority::Low, and use QoS class Utility on Mac.

My recommendation is that indexing belongs to 'utility', as @stefanhaller mentioned the user is actively depending on functionality coming from the index.
That said, you may want to consider dynamically switching to background if running on laptop with battery, or other heuristics, but that could be a follow-up enhancement, I don't think always using 'background' is appropriate.

May 4 2022, 11:12 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 3 2022

akyrtzi added inline comments to D124571: Avoid strict aliasing violation on type punning inside llvm::PointerIntPair.
May 3 2022, 9:15 PM · Restricted Project, Restricted Project
akyrtzi accepted D124840: [RFC] Add and sort decl to maintain order instead of inserting in order.
May 3 2022, 8:51 AM · Restricted Project, Restricted Project

May 2 2022

akyrtzi added a comment to D124687: [Tooling/DependencyScanning & Preprocessor] Refactor dependency scanning to record and use pre-lexed preprocessor directive tokens, instead of minimized sources.

Could you split this into smaller patches?

May 2 2022, 12:26 PM · Restricted Project, Restricted Project
akyrtzi added inline comments to D124687: [Tooling/DependencyScanning & Preprocessor] Refactor dependency scanning to record and use pre-lexed preprocessor directive tokens, instead of minimized sources.
May 2 2022, 12:16 PM · Restricted Project, Restricted Project

Apr 29 2022

akyrtzi updated the diff for D124687: [Tooling/DependencyScanning & Preprocessor] Refactor dependency scanning to record and use pre-lexed preprocessor directive tokens, instead of minimized sources.

Update documentation comments for Lexer::seek()

Apr 29 2022, 10:40 AM · Restricted Project, Restricted Project
akyrtzi added reviewers for D124687: [Tooling/DependencyScanning & Preprocessor] Refactor dependency scanning to record and use pre-lexed preprocessor directive tokens, instead of minimized sources: jansvoboda11, dexonsmith, Bigcheese, arphaman.
Apr 29 2022, 10:35 AM · Restricted Project, Restricted Project
akyrtzi requested review of D124687: [Tooling/DependencyScanning & Preprocessor] Refactor dependency scanning to record and use pre-lexed preprocessor directive tokens, instead of minimized sources.
Apr 29 2022, 10:34 AM · Restricted Project, Restricted Project

Apr 28 2022

akyrtzi committed rG42823beb1d71: [Tooling/DependencyScanning] Make skipping excluded PP ranges during dependency… (authored by akyrtzi).
[Tooling/DependencyScanning] Make skipping excluded PP ranges during dependency…
Apr 28 2022, 3:23 PM · Restricted Project, Restricted Project
akyrtzi closed D124558: [Tooling/DependencyScanning] Make skipping excluded PP ranges during dependency scanning the default.
Apr 28 2022, 3:23 PM · Restricted Project, Restricted Project
akyrtzi added a comment to D124558: [Tooling/DependencyScanning] Make skipping excluded PP ranges during dependency scanning the default.

@jansvoboda11 thanks for reviewing! I've changed APIs to use a reference instead of a pointer and removed the unnecessary check and heap allocations.

Apr 28 2022, 10:31 AM · Restricted Project, Restricted Project
akyrtzi updated the diff for D124558: [Tooling/DependencyScanning] Make skipping excluded PP ranges during dependency scanning the default.

Change APIs to accept a reference of ExcludedPreprocessorDirectiveSkipMapping instead of a pointer, since it is required now.

Apr 28 2022, 10:27 AM · Restricted Project, Restricted Project
akyrtzi added inline comments to D124571: Avoid strict aliasing violation on type punning inside llvm::PointerIntPair.
Apr 28 2022, 10:09 AM · Restricted Project, Restricted Project
akyrtzi added inline comments to D124571: Avoid strict aliasing violation on type punning inside llvm::PointerIntPair.
Apr 28 2022, 9:17 AM · Restricted Project, Restricted Project