Page MenuHomePhabricator

akyrtzi (Argyrios Kyrtzidis)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 11 2014, 3:42 PM (320 w, 6 d)

Recent Activity

Tue, Mar 31

akyrtzi accepted D77180: Forward WrapperFrontendAction::shouldEraseOutputFiles().
Tue, Mar 31, 4:33 PM · Restricted Project
akyrtzi accepted D77159: [pch] Honour -fallow-pch-with-compiler-errors for overall compilation status.
Tue, Mar 31, 1:44 PM · Restricted Project

Sat, Mar 28

akyrtzi added a comment to rG37943e518c5a: [docs] Added solutions to slow build under common problems..

I agree it makes sense to disable CLANG_ENABLE_ARCMT if CLANG_ENABLE_STATIC_ANALYZER is also disabled.

Sat, Mar 28, 11:17 AM

Mar 7 2020

akyrtzi committed rG2b17438a92ea: [Index/USRGeneration] Make sure that ObjC properties in categories also get… (authored by akyrtzi).
[Index/USRGeneration] Make sure that ObjC properties in categories also get…
Mar 7 2020, 3:09 PM

Feb 11 2020

akyrtzi accepted D74385: [ARCMT][NFC] Reduce #include dependencies.
Feb 11 2020, 8:29 AM · Restricted Project

Dec 20 2019

akyrtzi removed a reviewer for D71758: [Lexer] Allow UCN for dollar symbol '\u0024' in identifiers when using -fdollars-in-identifiers flag.: akyrtzi.
Dec 20 2019, 10:29 AM · Restricted Project

Dec 16 2019

akyrtzi removed a reviewer for D71535: [clang][AST] Make 'getPartialSpecializations' const-qualified in DeclTemplate: akyrtzi.
Dec 16 2019, 10:16 AM · Restricted Project

Dec 12 2019

akyrtzi committed rG7d2bedeaf2a0: [CMake] Change `LLVM_DISABLE_INDEX_STORE` to be an option and remove 'FORCE'… (authored by akyrtzi).
[CMake] Change `LLVM_DISABLE_INDEX_STORE` to be an option and remove 'FORCE'…
Dec 12 2019, 1:55 PM
akyrtzi committed rG975f8f199173: [CMake] Enable '-index-store-path' compiler option on a Debug build, if the… (authored by akyrtzi).
[CMake] Enable '-index-store-path' compiler option on a Debug build, if the…
Dec 12 2019, 1:54 PM
GitHub <noreply@github.com> committed rG78775ce75a52: Merge pull request #157 from akyrtzi/cmake-index-store-flag (authored by akyrtzi).
Merge pull request #157 from akyrtzi/cmake-index-store-flag
Dec 12 2019, 1:54 PM
akyrtzi committed rG2bb27356b23a: [ASTDumper] Update to our 'upstream-with-swift'-only code to use new upstream… (authored by akyrtzi).
[ASTDumper] Update to our 'upstream-with-swift'-only code to use new upstream…
Dec 12 2019, 12:19 PM
akyrtzi committed rG2b5186e9329d: Fix compiler error due to our fork diverging from llvm.org because of the… (authored by akyrtzi).
Fix compiler error due to our fork diverging from llvm.org because of the…
Dec 12 2019, 12:18 PM
akyrtzi committed rGb2fe1b3718a1: [index/store] Put the USR validation checking logging behind an environment… (authored by akyrtzi).
[index/store] Put the USR validation checking logging behind an environment…
Dec 12 2019, 11:54 AM
akyrtzi committed rG9371ac6c2d0f: [indexstore] Enhancement for IndexStoreCXX.h's getUnitNameFromOutputPath (authored by akyrtzi).
[indexstore] Enhancement for IndexStoreCXX.h's getUnitNameFromOutputPath
Dec 12 2019, 11:53 AM
akyrtzi committed rGa7c300d2ef28: [indexstore] Fix crashing issue with indexstore_store_get_unit_name_from_output… (authored by akyrtzi).
[indexstore] Fix crashing issue with indexstore_store_get_unit_name_from_output…
Dec 12 2019, 11:53 AM
akyrtzi committed rG11ac34105082: [DirectoryWatcher] Add a linux-specific implementation using inotify (authored by akyrtzi).
[DirectoryWatcher] Add a linux-specific implementation using inotify
Dec 12 2019, 11:51 AM
GitHub <noreply@github.com> committed rG6ac75c4bceeb: Merge pull request #219 from akyrtzi/dir-watch-linux (authored by akyrtzi).
Merge pull request #219 from akyrtzi/dir-watch-linux
Dec 12 2019, 11:51 AM
akyrtzi committed rG1bd7215ddd58: [DirectoryWatcher] Move FSEvents implementation to a mac-platform specific… (authored by akyrtzi).
[DirectoryWatcher] Move FSEvents implementation to a mac-platform specific…
Dec 12 2019, 11:51 AM
akyrtzi committed rG11b8843679ab: [unittests] Add a unit test file for DirectoryWatcher library (authored by akyrtzi).
[unittests] Add a unit test file for DirectoryWatcher library
Dec 12 2019, 11:50 AM

Oct 29 2019

akyrtzi committed rG4fe1f93f74dc: [index/store] Changes to make libIndexStore available for linux (authored by akyrtzi).
[index/store] Changes to make libIndexStore available for linux
Oct 29 2019, 5:08 PM
akyrtzi committed rG3d14643f372a: [test/index/store] Remove or put 'XFAIL: linux' instances appropriately (authored by akyrtzi).
[test/index/store] Remove or put 'XFAIL: linux' instances appropriately
Oct 29 2019, 5:08 PM
akyrtzi committed rG6e57de226f06: [index] Some refactoring to simplify how DirectoryWatcher is used for index… (authored by akyrtzi).
[index] Some refactoring to simplify how DirectoryWatcher is used for index…
Oct 29 2019, 5:08 PM
akyrtzi committed rG4885e729c8fe: [DirectoryWatcher] Some enhancements to the DirectoryWatcher (authored by akyrtzi).
[DirectoryWatcher] Some enhancements to the DirectoryWatcher
Oct 29 2019, 5:00 PM
akyrtzi committed rGb4b9b63c1cd2: [index/store] Remove storing file size+mod time for dependencies (authored by akyrtzi).
[index/store] Remove storing file size+mod time for dependencies
Oct 29 2019, 5:00 PM
akyrtzi committed rGdaedbe5a073b: [index/store] Update to handle introduction of SymbolProperty::ProtocolInterface (authored by akyrtzi).
[index/store] Update to handle introduction of SymbolProperty::ProtocolInterface
Oct 29 2019, 4:59 PM
akyrtzi committed rG950964f68436: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by akyrtzi).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Oct 29 2019, 4:59 PM
akyrtzi committed rGdab5207354ee: [index/store] Improvements to make index store reading/writing more robust (authored by akyrtzi).
[index/store] Improvements to make index store reading/writing more robust
Oct 29 2019, 4:40 PM
akyrtzi committed rG6a19e7c8fc03: [index] Update in IndexingAction.cpp for upstream change (authored by akyrtzi).
[index] Update in IndexingAction.cpp for upstream change
Oct 29 2019, 4:05 PM
akyrtzi committed rG825f3f1489ca: [index/store] Make sure to ignore any decl occurrences from the predefines… (authored by akyrtzi).
[index/store] Make sure to ignore any decl occurrences from the predefines…
Oct 29 2019, 3:43 PM
akyrtzi committed rG47ee151b7b21: Fix Windows support for Driver and add support to Index (#127) (authored by troughton).
Fix Windows support for Driver and add support to Index (#127)
Oct 29 2019, 3:28 PM
akyrtzi committed rGa987013fcefe: [c-index-test] Fix compilation for linux (authored by akyrtzi).
[c-index-test] Fix compilation for linux
Oct 29 2019, 2:55 PM
akyrtzi committed rG6e7169a2d3ee: [index] Introduce 'CommentTag' symbol kind (authored by akyrtzi).
[index] Introduce 'CommentTag' symbol kind
Oct 29 2019, 2:40 PM
akyrtzi committed rG3549dfbba076: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by akyrtzi).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 2:40 PM
akyrtzi committed rGc90c273ab9d1: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by akyrtzi).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 2:23 PM
akyrtzi committed rG3c1a9d7bd860: [index] Remove SwiftAccessorGetter/Setter symbol subkinds. (authored by akyrtzi).
[index] Remove SwiftAccessorGetter/Setter symbol subkinds.
Oct 29 2019, 2:19 PM
akyrtzi committed rG9c1706450368: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by akyrtzi).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 2:19 PM
akyrtzi committed rGbca93adf92fe: [index] Add Swift symbol language and Swift-specific symbol subkinds. (authored by akyrtzi).
[index] Add Swift symbol language and Swift-specific symbol subkinds.
Oct 29 2019, 2:18 PM
akyrtzi committed rGc99d9494d31e: [APINotes] Fix build error with creating 'AvailabilityAttr', after upstream… (authored by akyrtzi).
[APINotes] Fix build error with creating 'AvailabilityAttr', after upstream…
Oct 29 2019, 1:01 PM
akyrtzi committed rG952605f25b1a: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by akyrtzi).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 12:56 PM
akyrtzi committed rGd2cbac0a9a43: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by akyrtzi).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 12:56 PM
akyrtzi committed rG97b46aab9b05: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by akyrtzi).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 12:56 PM
akyrtzi committed rG4f0e548493e7: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by akyrtzi).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 12:55 PM
akyrtzi committed rG2400d6de15e1: [SemaAPINotes] Fix compiler error after change of r261163. (authored by akyrtzi).
[SemaAPINotes] Fix compiler error after change of r261163.
Oct 29 2019, 12:51 PM

Oct 8 2019

ham999 awarded D17325: Introduce llvm/ADT/OptionSet.h utility class a Mountain of Wealth token.
Oct 8 2019, 5:15 PM

Aug 28 2019

akyrtzi accepted D66884: Removed dead code from clang/AST/NSAPI.h.
Aug 28 2019, 10:33 AM · Restricted Project, Restricted Project

Aug 24 2019

akyrtzi accepted D66694: [libclang][index][NFCi] Refactor machinery for skipping already parsed function bodies.
Aug 24 2019, 10:48 AM · Restricted Project

Aug 23 2019

akyrtzi added a comment to D66690: [libclang][index] Skip already indexed function bodies more aggressively.

Are you sure the difference is not random noise? It's not clear to me under which conditions you would encounter the same region in NewParsedRegions within the same TU. I assume this would be the case if the same file is parsed multiple times, but I'd expect this to be uncommon within the same TU.
I'd recommend to add some counters of when NewParsedRegions.count(region) is true and when ParsedRegions.count(region) is true, and print them at the end.

Aug 23 2019, 4:20 PM

Aug 13 2019

akyrtzi accepted D66156: Removed dead code from clang/tools/libclang/CXIndexDataConsumer.{cpp,h}.
Aug 13 2019, 3:38 PM · Restricted Project, Restricted Project

Aug 7 2019

akyrtzi added a comment to D65846: Improve error message from FrontendAction.

clang -fmodules -fmodules-cache-path=... is supposed to create the directory for the cache path, including the parent directories, AFAIK. If this doesn't happen it is a behavior change (and undesirable IMO).

Is c-index-test invoking clang or do we just have a similar interface? Perhaps it's not doing it right (haven't seen this problem happening directly while invoking clang). Should -fallow-pch-with-compiler-errors be considered somehow here?

Aug 7 2019, 2:29 PM · Restricted Project
akyrtzi added a comment to D65846: Improve error message from FrontendAction.
In D65846#1619645, @jfb wrote:

My current guess is that this part of the test:

c-index-test -write-pch %t.h.pch %s -fmodules -fmodules-cache-path=%t.mcp -Xclang -triple -Xclang x86_64-apple-darwin

Is expected to generate the unknown type name error, but when than happens it ignores -fmodules-cache-path=%t.mcp and doesn't create the directory. The next line expects the directory to exist, which is why it can't create the lock file (because the directory it's trying to create it in doesn't exist).

Aug 7 2019, 1:13 PM · Restricted Project
akyrtzi added a comment to D65846: Improve error message from FrontendAction.

Sorry, it's not clear to me what is the issue.

Aug 7 2019, 9:56 AM · Restricted Project

Jul 22 2019

akyrtzi added a comment to D64384: [WIP] Index-while-building.

For now I went with IndexWhileBuilding name but I'm open to discussion.

Jul 22 2019, 4:42 PM · Restricted Project

Jul 16 2019

akyrtzi added reviewers for D61466: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug: arphaman, jkorous.
Jul 16 2019, 9:45 AM · Restricted Project, Restricted Project

May 23 2019

akyrtzi added a reviewer for D48961: [Index] Add indexing support for MACROs.: jkorous.
May 23 2019, 10:00 AM · Restricted Project

May 10 2019

akyrtzi added a reviewer for D48116: [libclang] Allow skipping warnings from all included files: jkorous.
May 10 2019, 10:10 AM · Restricted Project, Restricted Project

Mar 6 2019

akyrtzi added inline comments to D39050: Add index-while-building support to Clang.
Mar 6 2019, 11:36 AM
akyrtzi added a reviewer for D39050: Add index-while-building support to Clang: jkorous.
Mar 6 2019, 10:08 AM

Mar 5 2019

akyrtzi accepted D58986: Fix typo in string returned from index::getSymbolKindString for SymbolKind::ConversionFunction.
Mar 5 2019, 11:28 AM · Restricted Project

Mar 1 2019

akyrtzi added a reviewer for D58814: [clang][Index] Mark references from Constructors and Destructors to class as NameReference : benlangmuir.
Mar 1 2019, 2:29 PM · Restricted Project

Feb 23 2019

akyrtzi added inline comments to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.
Feb 23 2019, 2:21 PM · Restricted Project, Restricted Project
akyrtzi added inline comments to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.
Feb 23 2019, 1:50 PM · Restricted Project, Restricted Project
akyrtzi added inline comments to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.
Feb 23 2019, 11:57 AM · Restricted Project, Restricted Project
akyrtzi added inline comments to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.
Feb 23 2019, 10:51 AM · Restricted Project, Restricted Project

Feb 8 2019

akyrtzi accepted D57949: [clang][Index] Add a knob to index function parameters in declarations.
Feb 8 2019, 8:40 AM · Restricted Project, Restricted Project

Dec 6 2018

akyrtzi added inline comments to D54862: [OpenCL] Add generic AS to 'this' pointer.
Dec 6 2018, 11:50 AM

Dec 5 2018

akyrtzi added inline comments to D54862: [OpenCL] Add generic AS to 'this' pointer.
Dec 5 2018, 8:17 AM

Nov 27 2018

akyrtzi added inline comments to D54826: [Support/FileSystem] Add sub-second precision for atime/mtime of sys::fs::file_status on unix platforms.
Nov 27 2018, 2:37 PM

Nov 25 2018

akyrtzi added a comment to D54826: [Support/FileSystem] Add sub-second precision for atime/mtime of sys::fs::file_status on unix platforms.

Thanks for reviewing Kristina & Aaron, much appreciated!

Nov 25 2018, 5:05 PM
akyrtzi updated the diff for D54826: [Support/FileSystem] Add sub-second precision for atime/mtime of sys::fs::file_status on unix platforms.
  • Change #cmakedefine01 to #cmakedefine for consistency.
  • Add comments to getLastAccessedTime()/ getLastModificationTime() APIs to make sure people are aware that time resolution can differ among file systems.
  • Improve commit summary.
Nov 25 2018, 2:02 PM
akyrtzi added inline comments to D54826: [Support/FileSystem] Add sub-second precision for atime/mtime of sys::fs::file_status on unix platforms.
Nov 25 2018, 1:52 PM
akyrtzi added inline comments to D54826: [Support/FileSystem] Add sub-second precision for atime/mtime of sys::fs::file_status on unix platforms.
Nov 25 2018, 1:21 PM
akyrtzi added a comment to D54826: [Support/FileSystem] Add sub-second precision for atime/mtime of sys::fs::file_status on unix platforms.

I think that should be documented on the public API part with a mention that the resolution is expected to differ depending on the file system and OS. WDYT?

That is a good idea, the way I consider file_status is that it provides a cross-platform way to get at the file properties. It provides times in nanoseconds but leaves the precision as implementation detail of the underlying file system, which makes sense, people should not expect anything more than that.
I'll add some comments.

Nov 25 2018, 1:10 PM
akyrtzi added a comment to D54826: [Support/FileSystem] Add sub-second precision for atime/mtime of sys::fs::file_status on unix platforms.

Is it going to be an issue that the Windows side of things has a more wild idea of file timestamp resolution? NTFS has a theoretical max precision of 100ns intervals, though according to MSDN, the access time on NTFS has a resolution of 1 hour, which is better than FAT file systems, where the resolution is 1 day. It seems odd to rely on ns resolution for access time, as that seems like it's going to be highly platform and filesystem dependent.

I can't speak for the Windows side of things but what you are pointing out is a general question about applications taking into account that file properties may differ across platforms. This is orthogonal to file_status itself reporting file properties accurately.
If current file_status has 1 hour resolution on NTFS for access time, this patch is not going to make it any better or worse, nor affect behavior of applications that are querying files from NTFS.

Nov 25 2018, 12:28 PM
akyrtzi added a comment to D54826: [Support/FileSystem] Add sub-second precision for atime/mtime of sys::fs::file_status on unix platforms.

I think this is the most important bit of information here. It should have been in the description of the differential.
If the current precision was 1ms (or even 1us), then yes, going all the way down to 1ns may not be important/worthwhile.
But 1 sec precision is clearly laughably not great, and should be improved.

Ah good point, I didn't consider that people are not broadly aware that current file_status has only 'up to second' precision.

Nov 25 2018, 12:12 PM
akyrtzi added a comment to D54826: [Support/FileSystem] Add sub-second precision for atime/mtime of sys::fs::file_status on unix platforms.

On second look, if you are concerned with adding additional fields in basic_file_status, I can replace:

time_t fs_st_atime = 0;
time_t fs_st_mtime = 0;

with uint64_t's which are adequate to include nanosecond precision, while these time_t's are 64bits as well but waste space in the structure.

Nov 25 2018, 12:04 PM
akyrtzi added a comment to D54826: [Support/FileSystem] Add sub-second precision for atime/mtime of sys::fs::file_status on unix platforms.

if there's no consumer for such API (pending review) there is no point in adding it.

To make sure it's clear, this is not a new API. getLastModificationTime() already reports a a timepoint in nanoseconds, but it is always in second intervals. This patch allows it to include the nanoseconds that are part of the underlying file status.

Nov 25 2018, 11:46 AM
akyrtzi added a comment to D54826: [Support/FileSystem] Add sub-second precision for atime/mtime of sys::fs::file_status on unix platforms.

The general changes to the support libraries are usually facilitated because of missing functionality that is required somewhere else and it being the most logical place to add it. If so please attach related revisions to this one (through "Edit Related Revisions") so it's more clear why this was added

There have been enhancements to file_status that added more info without the requirement you stated (attach related revisions to this one), like:
https://reviews.llvm.org/D31110
https://reviews.llvm.org/D18456

Nov 25 2018, 11:41 AM

Nov 22 2018

akyrtzi updated the diff for D54826: [Support/FileSystem] Add sub-second precision for atime/mtime of sys::fs::file_status on unix platforms.

Moved the toTimePoint conversion function to llvm/Support/Chrono.h so it can be broadly available.

Nov 22 2018, 10:32 AM

Nov 21 2018

akyrtzi created D54826: [Support/FileSystem] Add sub-second precision for atime/mtime of sys::fs::file_status on unix platforms.
Nov 21 2018, 11:45 PM

Nov 15 2018

akyrtzi accepted D53900: [CodeComplete] Penalize inherited ObjC properties for auto-completion.
Nov 15 2018, 10:12 AM

Aug 28 2018

akyrtzi accepted D51295: Allow resetting of NumCreatedFIDsForFileID.
Aug 28 2018, 5:18 PM

Aug 1 2018

akyrtzi accepted D50160: [c-index-test] Use correct executable path to discover resource directory..

LGTM!

Aug 1 2018, 5:32 PM
akyrtzi added inline comments to D50160: [c-index-test] Use correct executable path to discover resource directory..
Aug 1 2018, 3:49 PM

Jul 19 2018

akyrtzi accepted D49476: [Index] Set OrigD before D is changed..

Good enough, thanks for looking into this!

Jul 19 2018, 2:55 PM
akyrtzi added a comment to D49476: [Index] Set OrigD before D is changed..

CXIndexDataConsumer.cpp uses ASTNode.OrigD, that code is exercised when you run c-index-test -index-file <...>. I'd recommend to at least check if that command would produce a different output for the test case that you detected originally.

Jul 19 2018, 11:52 AM

Jul 18 2018

akyrtzi added a comment to D49476: [Index] Set OrigD before D is changed..

Is it possible to add a regression test case ? I assume this is fixing some issue, we should make sure we don't regress again.

Jul 18 2018, 3:28 PM

Jun 1 2018

akyrtzi added a comment to D47445: [ASTImporter] Corrected diagnostic client handling in tests..

We could leave disableSourceFileDiagnostics off until someone finds a use case for it.

Jun 1 2018, 11:04 AM

May 31 2018

akyrtzi added a comment to D47445: [ASTImporter] Corrected diagnostic client handling in tests..

Thanks for the explanation. Please do add documentation comments for the new method so people using ASTUnit in their own code have an idea when and why they would need to call this. Something like "if you intend to emit additional diagnostics after the ASTUnit is created [...]".
Also consider making the naming more clear to match the intended purpose, like enableEmittingAdditionalDiagnostics() or something similar.
Otherwise LGTM.

May 31 2018, 12:08 PM

May 30 2018

akyrtzi added a comment to D47445: [ASTImporter] Corrected diagnostic client handling in tests..

It's not clear to me what kind of issue you are addressing, for example is the unit test hitting an assertion hit without your changes ? Or is there something else ?
Also it would be good to add some documentation comments to clarify what's the use case and when ASTUnit::beginSourceFile() should be getting called.

May 30 2018, 11:46 AM

Mar 16 2018

akyrtzi added a comment to D39050: Add index-while-building support to Clang.

That would be good. How would one go about asking Clang to generate this extra information? Would a Clang Plugin be suitable for this?

That's an interesting idea that we could explore, but I don't have much experience with that mechanism to comment on.

Mar 16 2018, 12:59 PM

Mar 14 2018

akyrtzi added a comment to D39050: Add index-while-building support to Clang.

Hey Marc,

Mar 14 2018, 1:44 PM

Jan 26 2018

akyrtzi created D42588: [index] Fix crash when indexing a C++14 PCH/module related to TemplateTemplateParmDecls of alias templates.
Jan 26 2018, 10:48 AM

Jan 10 2018

akyrtzi added a reviewer for D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface: arphaman.
Jan 10 2018, 10:12 AM · Restricted Project

Jan 8 2018

akyrtzi added a comment to D41575: [index] Return when DC is null in handleReference.

Ah, sorry I mislead you. To test this try using c-index-test -index-file /path/to/file, see other examples in test/Index, e.g. test/Index/index-file.cpp

Jan 8 2018, 3:43 PM
akyrtzi added a comment to D41575: [index] Return when DC is null in handleReference.

Could you add a test case for this change ? See examples in test/Index/Core.
Also for the test case code: template <template <typename> class Actor = actor>, is the actor reference in this code reported ?
See the test examples on how to print out and test how the source symbols are indexed.

Jan 8 2018, 10:04 AM

Dec 23 2017

akyrtzi accepted D41514: [Index] Reduce size of SymbolInfo struct..

LGTM!

Dec 23 2017, 9:51 AM

Dec 21 2017

akyrtzi added a comment to D41514: [Index] Reduce size of SymbolInfo struct..

Nice one! One minor change I'd suggest is to change SymbolProperty to enum class SymbolProperty : SymbolPropertySet, so that if it needs to increase we only change the type in one place.

Dec 21 2017, 3:05 PM

Dec 7 2017

akyrtzi added a comment to D39050: Add index-while-building support to Clang.

@malaperle, to clarify we are not suggesting that you write your own parser, the suggestion is to use clang in 'fast-scan' mode to get the structure of the declarations of a single file, see CXTranslationUnit_SingleFileParse (along with enabling skipping of bodies). We have found clang is super fast when you only try to get the structure of a file like this. We can make convenient APIs to provide the syntactic structure of declarations based on their location.

Dec 7 2017, 10:50 AM

Nov 16 2017

akyrtzi added a comment to D39050: Add index-while-building support to Clang.

To be honest, I want this functionality to get in as much as you do, and I'm more than happy to prioritize the code review for it :) But the current patch size makes the reviewing really hard (e.g. I would never have caught the BLOCK issues hadn't I tried running the original patch myself). I'm not sure if it's really a common practice to check in a big chunk of code without careful code review and leave potential improvements as followups. I'm sure @klimek would have thoughts about this.

Nov 16 2017, 3:35 PM

Nov 10 2017

akyrtzi added a comment to D39050: Add index-while-building support to Clang.

Hey Eric,

Nov 10 2017, 5:46 PM