Page MenuHomePhabricator

tmatheson (Tomas Matheson)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 10 2020, 4:17 AM (80 w, 3 d)

Recent Activity

Apr 21 2022

tmatheson accepted D124090: [ARM] add Armv9 build attribute.
Apr 21 2022, 4:44 AM · Restricted Project, Restricted Project
tmatheson abandoned D123196: [AArch64] Refactor shouldExpandAtomicRMWInIR [NFC].

Sorry I forgot to follow this up sooner. Looking at it again I think you are right so will drop this patch.

Apr 21 2022, 12:15 AM · Restricted Project, Restricted Project

Apr 20 2022

tmatheson added inline comments to D124090: [ARM] add Armv9 build attribute.
Apr 20 2022, 7:48 AM · Restricted Project, Restricted Project

Apr 14 2022

tmatheson accepted D123797: [lit] Keep stdout/stderr when using GoogleTest.

LGTM

Apr 14 2022, 8:25 AM · Restricted Project, Restricted Project

Apr 13 2022

Herald added a project to D112921: [clang] Enable sized deallocation by default in C++14 onwards: Restricted Project.
Apr 13 2022, 11:24 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 11 2022

tmatheson accepted D123296: [llvm][AArch64] Generate getExtensionFeatures from the list of extensions.
Apr 11 2022, 5:34 AM · Restricted Project, Restricted Project, Restricted Project

Apr 6 2022

tmatheson added reviewers for D123196: [AArch64] Refactor shouldExpandAtomicRMWInIR [NFC]: lenary, LemonBoy, efriedma.
Apr 6 2022, 2:35 AM · Restricted Project, Restricted Project
tmatheson requested review of D123196: [AArch64] Refactor shouldExpandAtomicRMWInIR [NFC].
Apr 6 2022, 2:31 AM · Restricted Project, Restricted Project

Mar 28 2022

tmatheson accepted D122274: [AArch64] Fix AArch64TargetParser.def to match AArch64.td..

LGTM, just some comments/notes on what changes for others looking at this.

Mar 28 2022, 4:53 AM · Restricted Project, Restricted Project

Mar 18 2022

tmatheson committed rG831ab35b2fc7: [ARM][AArch64] generate subtarget feature flags (authored by tmatheson).
[ARM][AArch64] generate subtarget feature flags
Mar 18 2022, 9:09 AM · Restricted Project
tmatheson added a reverting change for rGdd8b0fecb95d: [ARM][AArch64] generate subtarget feature flags: rG62c481542e63: Revert "[ARM][AArch64] generate subtarget feature flags".
Mar 18 2022, 4:59 AM · Restricted Project
tmatheson committed rG62c481542e63: Revert "[ARM][AArch64] generate subtarget feature flags" (authored by tmatheson).
Revert "[ARM][AArch64] generate subtarget feature flags"
Mar 18 2022, 4:59 AM · Restricted Project
tmatheson added a reverting change for D120906: [ARM][AArch64] generate subtarget feature flags [NFC]: rG62c481542e63: Revert "[ARM][AArch64] generate subtarget feature flags".
Mar 18 2022, 4:58 AM · Restricted Project, Restricted Project
tmatheson committed rGdd8b0fecb95d: [ARM][AArch64] generate subtarget feature flags (authored by tmatheson).
[ARM][AArch64] generate subtarget feature flags
Mar 18 2022, 4:48 AM · Restricted Project
tmatheson closed D120906: [ARM][AArch64] generate subtarget feature flags [NFC].
Mar 18 2022, 4:48 AM · Restricted Project, Restricted Project
tmatheson added a comment to D120906: [ARM][AArch64] generate subtarget feature flags [NFC].

I'm going to submit this, since it has been approved for a while and covers a decent subset of the features without invasive changes. We can keep discussing any future alterations in D121768.

Mar 18 2022, 3:53 AM · Restricted Project, Restricted Project
tmatheson added a comment to D121768: [X86][tablgen] Auto-generate trivial fields and trivial interfaces for target features.

Your method can not get rid of non-trivial feature like useAA, which has an virtual interface.

Mar 18 2022, 3:32 AM · Restricted Project, Restricted Project
tmatheson added a comment to D121768: [X86][tablgen] Auto-generate trivial fields and trivial interfaces for target features.

Then I think it's important to have the flexibility to customize the interface, at least for now.

Mar 18 2022, 2:18 AM · Restricted Project, Restricted Project

Mar 17 2022

tmatheson added inline comments to D120906: [ARM][AArch64] generate subtarget feature flags [NFC].
Mar 17 2022, 6:13 AM · Restricted Project, Restricted Project
tmatheson added a comment to D121768: [X86][tablgen] Auto-generate trivial fields and trivial interfaces for target features.

This patch makes a distinction between trivial/nontrivial members & interface b/c some targets has some tricky interfaces, e.g

bool hasCMov() const { return HasCMov || X86SSELevel >= SSE1 || is64Bit(); }
bool useAA() const override { return UseAA; }
bool hasLAHFSAHF() const { return HasLAHFSAHF64 || !is64Bit(); }

It seems that you patch handle them incorrectly by now.

Mar 17 2022, 5:39 AM · Restricted Project, Restricted Project
tmatheson added inline comments to D120906: [ARM][AArch64] generate subtarget feature flags [NFC].
Mar 17 2022, 3:42 AM · Restricted Project, Restricted Project
tmatheson updated the diff for D120906: [ARM][AArch64] generate subtarget feature flags [NFC].

Address review comments

Mar 17 2022, 3:40 AM · Restricted Project, Restricted Project
tmatheson added a comment to D121768: [X86][tablgen] Auto-generate trivial fields and trivial interfaces for target features.

This looks remarkably similar to an ARM/AArch64 patch I've had up for a couple of weeks: D120906

Mar 17 2022, 2:50 AM · Restricted Project, Restricted Project

Mar 14 2022

tmatheson accepted D121479: [ARM] Fix Decode of tsb csync.

LGTM

Mar 14 2022, 3:34 AM · Restricted Project, Restricted Project

Mar 11 2022

tmatheson edited reviewers for D120906: [ARM][AArch64] generate subtarget feature flags [NFC], added: dmgreen; removed: greened.
Mar 11 2022, 5:23 AM · Restricted Project, Restricted Project
tmatheson added a comment to D120906: [ARM][AArch64] generate subtarget feature flags [NFC].

Ping. Anyone have thoughts on this approach?

Mar 11 2022, 5:21 AM · Restricted Project, Restricted Project

Mar 7 2022

tmatheson added a comment to D121093: [Driver][AArch64] Split up aarch64-cpus.c test further.

LGTM

Mar 7 2022, 5:22 AM · Restricted Project, Restricted Project
tmatheson accepted D120864: [AArch64] Avoid scanning feature list for target parsing.
Mar 7 2022, 3:53 AM · Restricted Project, Restricted Project
tmatheson accepted D121093: [Driver][AArch64] Split up aarch64-cpus.c test further.

Thanks for picking this up, LGTM

Mar 7 2022, 3:36 AM · Restricted Project, Restricted Project

Mar 3 2022

tmatheson accepted D120665: [AArch64] Fix the TuneExynosM4 entry in lib/Target/AArch64/AArch64.td.
Mar 3 2022, 7:41 AM · Restricted Project, Restricted Project
tmatheson added reviewers for D120906: [ARM][AArch64] generate subtarget feature flags [NFC]: tyb0807, lenary, chill, t.p.northover, david-arm, greened, kristof.beyls, eli.friedman, MaskRay.
Mar 3 2022, 7:09 AM · Restricted Project, Restricted Project
tmatheson retitled D120906: [ARM][AArch64] generate subtarget feature flags [NFC] from [ARM][AArch64] generate subtarget feature flags to [ARM][AArch64] generate subtarget feature flags [NFC].
Mar 3 2022, 6:56 AM · Restricted Project, Restricted Project
tmatheson requested review of D120906: [ARM][AArch64] generate subtarget feature flags [NFC].
Mar 3 2022, 6:55 AM · Restricted Project, Restricted Project

Mar 1 2022

tmatheson added inline comments to D120593: [Support] Allow the ability to change WithColor's auto detection function.
Mar 1 2022, 5:40 AM · Restricted Project, Restricted Project
tmatheson accepted D120111: [AArch64] Default HBC/MOPS features in clang.

LGTM, please give @nickdesaulniers some time to respond though. I do agree that iterating over the features repeatedly is less than ideal, but also that this patch is probably not the place to try to fix it.

Mar 1 2022, 4:32 AM · Restricted Project, Restricted Project

Feb 25 2022

tmatheson requested changes to D120111: [AArch64] Default HBC/MOPS features in clang.
Feb 25 2022, 6:54 AM · Restricted Project, Restricted Project

Feb 24 2022

tmatheson accepted D117740: [NFC][clang] Simplify `isOneOf` function.
Feb 24 2022, 2:52 AM · Restricted Project

Feb 21 2022

tmatheson added inline comments to D111551: [AArch64] Split out processor/tuning features.
Feb 21 2022, 9:49 AM · Restricted Project

Jan 5 2022

tmatheson accepted D116655: [AArch64] Rename CPY to DUP. NFC.

LGTM

Jan 5 2022, 10:03 AM · Restricted Project
tmatheson added a comment to D116655: [AArch64] Rename CPY to DUP. NFC.

This renames the following instructions that were captured by the scheduler regex: CPYi8, CPYi16, CPYi32, CPYi64.

Jan 5 2022, 6:51 AM · Restricted Project
tmatheson committed rGe35a3f188f6a: [AArch64] Adding "armv8.8-a" memcpy/memset support. (authored by simon_tatham).
[AArch64] Adding "armv8.8-a" memcpy/memset support.
Jan 5 2022, 6:45 AM
tmatheson closed D116157: [AArch64] Adding "armv8.8-a" memcpy/memset support..
Jan 5 2022, 6:45 AM · Restricted Project
tmatheson added a comment to D116157: [AArch64] Adding "armv8.8-a" memcpy/memset support..

Should they be setting or using NZCV though?

Jan 5 2022, 6:43 AM · Restricted Project
tmatheson updated the diff for D116157: [AArch64] Adding "armv8.8-a" memcpy/memset support..

Use Sched<[]> rather than hasNoSchedulingInfo. This requried updating the regexes used by various scheduling models to apply InstRW to CPY* instructions so that they do not capture the new MOPS instructions.

Jan 5 2022, 4:41 AM · Restricted Project
tmatheson updated the diff for D116157: [AArch64] Adding "armv8.8-a" memcpy/memset support..

SET->CPY

Jan 5 2022, 2:27 AM · Restricted Project

Jan 4 2022

tmatheson committed rG8aea5d5951dc: [Arm] Remove duplicate CPU tests (authored by tmatheson).
[Arm] Remove duplicate CPU tests
Jan 4 2022, 7:22 AM
tmatheson closed D116415: [Arm] Remove duplicate CPU tests.
Jan 4 2022, 7:22 AM · Restricted Project
tmatheson planned changes to D116154: [ARM] Adding macros for coprocessor intrinsics as per ACLE.
Jan 4 2022, 5:20 AM · Restricted Project
tmatheson added a reviewer for D116154: [ARM] Adding macros for coprocessor intrinsics as per ACLE: vhscampos.
Jan 4 2022, 4:02 AM · Restricted Project

Jan 3 2022

tmatheson updated the diff for D116154: [ARM] Adding macros for coprocessor intrinsics as per ACLE.

Combine V8 and V9 macros

Jan 3 2022, 12:56 PM · Restricted Project
tmatheson updated the diff for D116154: [ARM] Adding macros for coprocessor intrinsics as per ACLE.

Add 8.8 and 9.3; patches adding these were merged first in the end.

Jan 3 2022, 8:39 AM · Restricted Project
tmatheson committed rG4435d1819efe: [ARM][AArch64] clang support for Armv9.3-A (authored by tmatheson).
[ARM][AArch64] clang support for Armv9.3-A
Jan 3 2022, 8:03 AM
tmatheson closed D116159: [ARM][AArch64] clang support for Armv9.3-A.
Jan 3 2022, 8:03 AM · Restricted Project
tmatheson added inline comments to D116157: [AArch64] Adding "armv8.8-a" memcpy/memset support..
Jan 3 2022, 8:01 AM · Restricted Project
tmatheson updated the diff for D116157: [AArch64] Adding "armv8.8-a" memcpy/memset support..

Add mayLoad/mayStore/hasSideEffects

Jan 3 2022, 7:58 AM · Restricted Project
tmatheson updated the diff for D116159: [ARM][AArch64] clang support for Armv9.3-A.

Rebase

Jan 3 2022, 4:44 AM · Restricted Project
tmatheson committed rGcd7f621a0aa4: [ARM][AArch64] Introduce Armv9.3-A (authored by pratlucas).
[ARM][AArch64] Introduce Armv9.3-A
Jan 3 2022, 4:42 AM
tmatheson closed D116158: [ARM][AArch64] Introduce Armv9.3-A.
Jan 3 2022, 4:41 AM · Restricted Project
tmatheson committed rG8c1e520c903e: [AArch64] Adding "armv8.8-a" BC instruction. (authored by simon_tatham).
[AArch64] Adding "armv8.8-a" BC instruction.
Jan 3 2022, 4:34 AM
tmatheson closed D116156: [AArch64] Adding "armv8.8-a" BC instruction..
Jan 3 2022, 4:34 AM · Restricted Project

Dec 31 2021

tmatheson committed rGd50072f74e3e: [ARM] Introduce an empty "armv8.8-a" architecture. (authored by simon_tatham).
[ARM] Introduce an empty "armv8.8-a" architecture.
Dec 31 2021, 8:44 AM
tmatheson closed D115694: [ARM] Introduce an empty "armv8.8-a" architecture..
Dec 31 2021, 8:44 AM · Restricted Project, Restricted Project
tmatheson updated the diff for D115694: [ARM] Introduce an empty "armv8.8-a" architecture..

Minor fix after rebase

Dec 31 2021, 5:38 AM · Restricted Project, Restricted Project
tmatheson updated the diff for D115694: [ARM] Introduce an empty "armv8.8-a" architecture..

Rebase

Dec 31 2021, 5:35 AM · Restricted Project, Restricted Project
tmatheson added reviewers for D115694: [ARM] Introduce an empty "armv8.8-a" architecture.: dmgreen, SjoerdMeijer, pratlucas, chill.
Dec 31 2021, 1:22 AM · Restricted Project, Restricted Project
tmatheson added reviewers for D116415: [Arm] Remove duplicate CPU tests: lenary, dmgreen, cpirker, olista01, vsukharev, SjoerdMeijer.

Thanks for the review @nickdesaulniers. Adding a few more reviewers just to check that I'm not missing something.

Dec 31 2021, 1:03 AM · Restricted Project
tmatheson added inline comments to D116415: [Arm] Remove duplicate CPU tests.
Dec 31 2021, 1:00 AM · Restricted Project

Dec 30 2021

tmatheson added a comment to D116157: [AArch64] Adding "armv8.8-a" memcpy/memset support..

I've updated the description with documentation.

Dec 30 2021, 9:36 AM · Restricted Project
tmatheson added inline comments to D116159: [ARM][AArch64] clang support for Armv9.3-A.
Dec 30 2021, 8:41 AM · Restricted Project
tmatheson requested review of D116415: [Arm] Remove duplicate CPU tests.
Dec 30 2021, 8:38 AM · Restricted Project
tmatheson updated the diff for D116159: [ARM][AArch64] clang support for Armv9.3-A.

Remove redundancies in arm tests

Dec 30 2021, 8:32 AM · Restricted Project
tmatheson updated the diff for D116158: [ARM][AArch64] Introduce Armv9.3-A.

Remove crypto extensions and add SVE2 for AArch64, as per D109517

Dec 30 2021, 1:08 AM · Restricted Project
tmatheson updated the summary of D116157: [AArch64] Adding "armv8.8-a" memcpy/memset support..
Dec 30 2021, 12:03 AM · Restricted Project

Dec 29 2021

tmatheson added a comment to D116156: [AArch64] Adding "armv8.8-a" BC instruction..

Thanks for the comments

Dec 29 2021, 11:28 PM · Restricted Project
tmatheson updated the diff for D116156: [AArch64] Adding "armv8.8-a" BC instruction..

Use pipe in second test

Dec 29 2021, 11:27 PM · Restricted Project
tmatheson added inline comments to D116156: [AArch64] Adding "armv8.8-a" BC instruction..
Dec 29 2021, 1:23 PM · Restricted Project
tmatheson updated the diff for D116156: [AArch64] Adding "armv8.8-a" BC instruction..

Tweak description and test case.

Dec 29 2021, 1:21 PM · Restricted Project
tmatheson updated the summary of D116156: [AArch64] Adding "armv8.8-a" BC instruction..
Dec 29 2021, 11:24 AM · Restricted Project

Dec 27 2021

tmatheson updated the summary of D116154: [ARM] Adding macros for coprocessor intrinsics as per ACLE.
Dec 27 2021, 10:06 AM · Restricted Project
tmatheson added reviewers for D116154: [ARM] Adding macros for coprocessor intrinsics as per ACLE: rs, tyb0807, dmgreen, SjoerdMeijer, olista01.
Dec 27 2021, 10:06 AM · Restricted Project
tmatheson added reviewers for D116157: [AArch64] Adding "armv8.8-a" memcpy/memset support.: lenary, vhscampos.
Dec 27 2021, 10:05 AM · Restricted Project
tmatheson added reviewers for D116157: [AArch64] Adding "armv8.8-a" memcpy/memset support.: simon_tatham, nickdesaulniers, t.p.northover, SjoerdMeijer, dmgreen, olista01, chill, pratlucas.
Dec 27 2021, 10:05 AM · Restricted Project
tmatheson added reviewers for D116156: [AArch64] Adding "armv8.8-a" BC instruction.: nickdesaulniers, t.p.northover.
Dec 27 2021, 10:03 AM · Restricted Project
tmatheson added reviewers for D116159: [ARM][AArch64] clang support for Armv9.3-A: pratlucas, dmgreen, SjoerdMeijer, ostannard, chill, nickdesaulniers, t.p.northover.
Dec 27 2021, 10:03 AM · Restricted Project
tmatheson added reviewers for D116158: [ARM][AArch64] Introduce Armv9.3-A: pratlucas, tyb0807, dmgreen, SjoerdMeijer, olista01, chill, nickdesaulniers, t.p.northover.
Dec 27 2021, 10:01 AM · Restricted Project
tmatheson added reviewers for D116156: [AArch64] Adding "armv8.8-a" BC instruction.: simon_tatham, SjoerdMeijer, dmgreen, tyb0807, chill.
Dec 27 2021, 9:48 AM · Restricted Project

Dec 22 2021

tmatheson requested review of D116160: [AArch64] ACLE feature macro for Armv8.8-A MOPS.
Dec 22 2021, 3:29 AM · Restricted Project, Restricted Project
tmatheson requested review of D116159: [ARM][AArch64] clang support for Armv9.3-A.
Dec 22 2021, 3:26 AM · Restricted Project
tmatheson requested review of D116158: [ARM][AArch64] Introduce Armv9.3-A.
Dec 22 2021, 3:24 AM · Restricted Project
tmatheson requested review of D116157: [AArch64] Adding "armv8.8-a" memcpy/memset support..
Dec 22 2021, 3:22 AM · Restricted Project
tmatheson requested review of D116156: [AArch64] Adding "armv8.8-a" BC instruction..
Dec 22 2021, 3:20 AM · Restricted Project
tmatheson requested review of D116154: [ARM] Adding macros for coprocessor intrinsics as per ACLE.
Dec 22 2021, 3:13 AM · Restricted Project
tmatheson requested review of D116153: [ARM][AArch64] Add missing v8.x checks.
Dec 22 2021, 3:07 AM · Restricted Project

Dec 16 2021

tmatheson abandoned D99091: [locale][num_get] Improve Stage 2 of string to float conversion.
Dec 16 2021, 6:17 AM · Restricted Project
tmatheson accepted D115694: [ARM] Introduce an empty "armv8.8-a" architecture..

LGTM

Dec 16 2021, 6:16 AM · Restricted Project, Restricted Project

Nov 30 2021

tmatheson accepted D114703: [AArch64] Use Feature for A53 Erratum 835769 Fix.

Makes sense to me

Nov 30 2021, 1:51 AM · Restricted Project, Restricted Project

Oct 15 2021

tmatheson committed rG096ace55804d: [AArch64] Fix failing test target-invalid-cpu-note.c (authored by tmatheson).
[AArch64] Fix failing test target-invalid-cpu-note.c
Oct 15 2021, 8:13 AM

Oct 1 2021

tmatheson added inline comments to D110065: [AArch64] Add support for the 'R' architecture profile..
Oct 1 2021, 2:52 AM · Restricted Project, Restricted Project
tmatheson added inline comments to D110065: [AArch64] Add support for the 'R' architecture profile..
Oct 1 2021, 2:50 AM · Restricted Project, Restricted Project

Aug 9 2021

tmatheson added a comment to D107747: [ELF] Don't emit SHF_GNU_RETAIN on Solaris.

According to D95749, the rationale for allowing ELFOSABI_NONE with SHF_GNU_RETAIN is to keep consistent behaviour with STT_GNU_IFUNC and STB_GNU_UNIQUE, which are permitted under ELFOSABI_NONE. @MaskRay Should we perhaps revisit that decision?

Aug 9 2021, 9:56 AM · Restricted Project