Page MenuHomePhabricator

tmatheson (Tomas Matheson)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 10 2020, 4:17 AM (28 w, 15 h)

Recent Activity

Sat, Jun 19

tmatheson committed rG1bcfa84ae908: Allow building for release with EXPENSIVE_CHECKS (authored by tmatheson).
Allow building for release with EXPENSIVE_CHECKS
Sat, Jun 19, 9:02 AM
tmatheson closed D104514: Allow building for release with EXPENSIVE_CHECKS.
Sat, Jun 19, 9:02 AM · Restricted Project
tmatheson committed rG18dbe6897857: [ARM][NFC] Tidy up subtarget frame pointer routines (authored by tmatheson).
[ARM][NFC] Tidy up subtarget frame pointer routines
Sat, Jun 19, 9:01 AM
tmatheson closed D104476: [ARM][NFC] Tidy up subtarget frame pointer routines.
Sat, Jun 19, 9:01 AM · Restricted Project

Fri, Jun 18

tmatheson requested review of D104514: Allow building for release with EXPENSIVE_CHECKS.
Fri, Jun 18, 3:03 AM · Restricted Project
tmatheson updated the diff for D104476: [ARM][NFC] Tidy up subtarget frame pointer routines.

Fix clang-tidy: warning: do not use 'else' after 'return'

Fri, Jun 18, 2:13 AM · Restricted Project
tmatheson updated the diff for D104476: [ARM][NFC] Tidy up subtarget frame pointer routines.

clang-format everything for CI

Fri, Jun 18, 1:36 AM · Restricted Project

Thu, Jun 17

tmatheson added a reviewer for D104476: [ARM][NFC] Tidy up subtarget frame pointer routines: mstorsjo.
Thu, Jun 17, 12:32 PM · Restricted Project
tmatheson added reviewers for D104476: [ARM][NFC] Tidy up subtarget frame pointer routines: chill, pratlucas, carwil, dmgreen, kristof.beyls, MarkMurrayARM.
Thu, Jun 17, 11:28 AM · Restricted Project
tmatheson updated the diff for D104476: [ARM][NFC] Tidy up subtarget frame pointer routines.

clang-format (ignoring indentation change ARMAsmPrinter.cpp in match rest of file)

Thu, Jun 17, 11:22 AM · Restricted Project
tmatheson requested review of D104476: [ARM][NFC] Tidy up subtarget frame pointer routines.
Thu, Jun 17, 11:16 AM · Restricted Project

Fri, Jun 11

tmatheson committed rG773771ba382b: [CodeGen][regalloc] Don't align stack slots if the stack can't be realigned (authored by tmatheson).
[CodeGen][regalloc] Don't align stack slots if the stack can't be realigned
Fri, Jun 11, 8:57 AM
tmatheson closed D103602: [regalloc] Don't align stack slots if the stack can't be realigned.
Fri, Jun 11, 8:57 AM · Restricted Project
tmatheson updated the diff for D103602: [regalloc] Don't align stack slots if the stack can't be realigned.

Rebase and update tests

Fri, Jun 11, 7:47 AM · Restricted Project

Thu, Jun 3

tmatheson retitled D103602: [regalloc] Don't align stack slots if the stack can't be realigned from [CodeGen][regalloc] Don't align stack slots if the stack can't be realigned to [regalloc] Don't align stack slots if the stack can't be realigned.
Thu, Jun 3, 2:41 AM · Restricted Project
tmatheson requested review of D103602: [regalloc] Don't align stack slots if the stack can't be realigned.
Thu, Jun 3, 2:41 AM · Restricted Project

Fri, May 28

tmatheson added a comment to D99091: [locale][num_get] Improve Stage 2 of string to float conversion.

Ping. @ldionne? It doesn't seem like there is a lot of interest in this fix, since it's been up for over 2 months now in more or less the same form. I'm happy to keep making the suggested changes if it has a chance of landing, otherwise please let me know and I will just close it.

Fri, May 28, 8:07 AM · Restricted Project

Wed, May 26

tmatheson accepted D103005: [AArch64] Support llvm-mc/llvm-objdump -M no-aliases.

LGTM, I will leave it to the RISC-V people to approve the predecessor

Wed, May 26, 4:35 AM · Restricted Project
tmatheson committed rGab8c44112c48: [MC] Move elf-unique-sections-by-flags.ll to X86/ (authored by tmatheson).
[MC] Move elf-unique-sections-by-flags.ll to X86/
Wed, May 26, 4:29 AM
tmatheson committed rG165321b3d27d: [MC][ELF] Emit unique sections for different flags (authored by tmatheson).
[MC][ELF] Emit unique sections for different flags
Wed, May 26, 3:52 AM
tmatheson committed rGe79e8041c5ff: [MC][NFCI] Factor out ELF section unique ID calculation (authored by tmatheson).
[MC][NFCI] Factor out ELF section unique ID calculation
Wed, May 26, 3:52 AM
tmatheson closed D100944: [MC][ELF] Emit separate unique sections for different flags.
Wed, May 26, 3:52 AM · Restricted Project
tmatheson closed D102336: [MC][NFCI] Factor out ELF section unique ID calculation.
Wed, May 26, 3:52 AM · Restricted Project

May 25 2021

tmatheson added a comment to D103004: [llvm-mc] Add -M to replace -riscv-no-aliases and -riscv-arch-reg-names.

If we are just keeping -riscv-no-aliases to avoid changing many tests it might be better to just remove it now. Otherwise it will likely stay forever. Maybe it is used externally though, I don't know.

May 25 2021, 7:20 AM · Restricted Project

May 21 2021

tmatheson added inline comments to D100944: [MC][ELF] Emit separate unique sections for different flags.
May 21 2021, 2:57 AM · Restricted Project
tmatheson updated the diff for D100944: [MC][ELF] Emit separate unique sections for different flags.

Thanks everyone for the comments.

May 21 2021, 2:53 AM · Restricted Project

May 18 2021

tmatheson added a comment to D102690: [test-suite] [SingleSource] Add aarch64_neon_intrinsics reference output.

It was disabled here: https://github.com/llvm/llvm-test-suite/commit/87d67af9d8565d068b6706c081b7ae07addcb882

May 18 2021, 8:34 AM

May 17 2021

tmatheson added a comment to D99091: [locale][num_get] Improve Stage 2 of string to float conversion.

Thanks @Quuxplusone. If @ldionne can't be tempted into taking a look is there anyone else appropriate?

May 17 2021, 11:27 AM · Restricted Project
tmatheson added a comment to D99091: [locale][num_get] Improve Stage 2 of string to float conversion.

Ping @Quuxplusone

May 17 2021, 1:32 AM · Restricted Project

May 15 2021

tmatheson added a reviewer for D100944: [MC][ELF] Emit separate unique sections for different flags: lhames.

From the history it seems like @lhames might be best suited to comment on the test change

May 15 2021, 3:29 AM · Restricted Project

May 14 2021

tmatheson added a comment to D100944: [MC][ELF] Emit separate unique sections for different flags.

Ping

May 14 2021, 8:30 AM · Restricted Project
tmatheson added reviewers for D102336: [MC][NFCI] Factor out ELF section unique ID calculation: MaskRay, bd1976llvm, snehasish, rahmanl.
May 14 2021, 8:29 AM · Restricted Project
tmatheson retitled D100944: [MC][ELF] Emit separate unique sections for different flags from [CodeGen][ELF] Emit separate unique sections for different flags to [MC][ELF] Emit separate unique sections for different flags.
May 14 2021, 8:29 AM · Restricted Project
tmatheson added reviewers for D100944: [MC][ELF] Emit separate unique sections for different flags: snehasish, rahmanl.
May 14 2021, 8:28 AM · Restricted Project
tmatheson updated the summary of D102336: [MC][NFCI] Factor out ELF section unique ID calculation.
May 14 2021, 8:20 AM · Restricted Project
tmatheson updated the diff for D100944: [MC][ELF] Emit separate unique sections for different flags.

Rebase

May 14 2021, 8:18 AM · Restricted Project
tmatheson updated the diff for D100944: [MC][ELF] Emit separate unique sections for different flags.

Rewrite the patch after the changes in D101311 went in.

May 14 2021, 8:11 AM · Restricted Project

May 12 2021

tmatheson requested review of D102336: [MC][NFCI] Factor out ELF section unique ID calculation.
May 12 2021, 10:20 AM · Restricted Project
tmatheson committed rGedf9d8826637: [ARM] Precommit test for D101898 (authored by tmatheson).
[ARM] Precommit test for D101898
May 12 2021, 1:44 AM
tmatheson committed rG34c098b780a2: [ARM] Prevent spilling between ldrex/strex pairs (authored by tmatheson).
[ARM] Prevent spilling between ldrex/strex pairs
May 12 2021, 1:44 AM
tmatheson closed D101898: [ARM] Prevent spilling between ldrex/strex pairs.
May 12 2021, 1:43 AM · Restricted Project
tmatheson closed D101912: [ARM] Precommit test for D101898.
May 12 2021, 1:43 AM · Restricted Project

May 11 2021

tmatheson added a comment to D101898: [ARM] Prevent spilling between ldrex/strex pairs.

Thanks for the feedback!

May 11 2021, 12:07 PM · Restricted Project
tmatheson updated the diff for D101898: [ARM] Prevent spilling between ldrex/strex pairs.

Remove dead code paths and fix assert string

May 11 2021, 11:46 AM · Restricted Project
tmatheson updated the diff for D101898: [ARM] Prevent spilling between ldrex/strex pairs.
  • Add tests for v8m.baseline
  • Add two new pseudo instructions tCMP_SWAP_8 and tCMP_SWAP_16 to limit register for UXT instruction
  • Add some asserts in ExpandCMP_SWAP
May 11 2021, 10:21 AM · Restricted Project
tmatheson updated the diff for D101912: [ARM] Precommit test for D101898.

Add tests for v8m.baseline

May 11 2021, 10:19 AM · Restricted Project

May 10 2021

tmatheson added a comment to D99091: [locale][num_get] Improve Stage 2 of string to float conversion.

Yes the additional argument changes the ABI and should be an opt-in for the user. This can be done by adding a new define in include/__config in the block #if defined(_LIBCPP_ABI_UNSTABLE) || _LIBCPP_ABI_VERSION >= 2.

May 10 2021, 8:37 AM · Restricted Project
tmatheson updated the diff for D99091: [locale][num_get] Improve Stage 2 of string to float conversion.

Place breaking ABI change behind a macro

May 10 2021, 8:33 AM · Restricted Project

May 7 2021

tmatheson updated the diff for D101898: [ARM] Prevent spilling between ldrex/strex pairs.

Minimize the CHECK lines in the test

May 7 2021, 10:05 AM · Restricted Project
tmatheson updated the diff for D101912: [ARM] Precommit test for D101898.

Minimize the CHECK lines in the test

May 7 2021, 10:03 AM · Restricted Project
tmatheson added a comment to D99091: [locale][num_get] Improve Stage 2 of string to float conversion.

Ping

May 7 2021, 3:05 AM · Restricted Project

May 5 2021

tmatheson abandoned D93948: [MC] Merge section flags for user defined sections.

Closing in favour of D100944

May 5 2021, 10:21 AM · Restricted Project
tmatheson updated the diff for D101898: [ARM] Prevent spilling between ldrex/strex pairs.

Minor change to trigger rebuild

May 5 2021, 8:57 AM · Restricted Project
tmatheson added inline comments to D101898: [ARM] Prevent spilling between ldrex/strex pairs.
May 5 2021, 8:28 AM · Restricted Project
tmatheson updated the summary of D101898: [ARM] Prevent spilling between ldrex/strex pairs.
May 5 2021, 8:24 AM · Restricted Project
tmatheson updated the diff for D101898: [ARM] Prevent spilling between ldrex/strex pairs.
  • At more triples to the test (Thumb1/Thumb2)
  • Remove tests for floating point atomics. They tend to be bitcast to ints by the frontend and the support for them is patchy across architecture versions.
  • Rebase on top of pre-commit test in D101912
May 5 2021, 8:20 AM · Restricted Project
tmatheson requested review of D101912: [ARM] Precommit test for D101898.
May 5 2021, 8:13 AM · Restricted Project
tmatheson added reviewers for D101898: [ARM] Prevent spilling between ldrex/strex pairs: lenary, LemonBoy, chill, efriedma, tschuett, labrinea.
May 5 2021, 5:19 AM · Restricted Project
tmatheson requested review of D101898: [ARM] Prevent spilling between ldrex/strex pairs.
May 5 2021, 5:15 AM · Restricted Project

May 3 2021

tmatheson added a reverting change for rG753185031d93: [CodeGen][ARM] Implement atomicrmw as pseudo operations at -O0: rG9d86095ff83b: Revert "[CodeGen][ARM] Implement atomicrmw as pseudo operations at -O0".
May 3 2021, 1:49 PM
tmatheson committed rG9d86095ff83b: Revert "[CodeGen][ARM] Implement atomicrmw as pseudo operations at -O0" (authored by tmatheson).
Revert "[CodeGen][ARM] Implement atomicrmw as pseudo operations at -O0"
May 3 2021, 1:49 PM
tmatheson added a reverting change for D101164: [CodeGen][ARM] Implement atomicrmw as pseudo operations at -O0: rG9d86095ff83b: Revert "[CodeGen][ARM] Implement atomicrmw as pseudo operations at -O0".
May 3 2021, 1:49 PM · Restricted Project
tmatheson committed rG753185031d93: [CodeGen][ARM] Implement atomicrmw as pseudo operations at -O0 (authored by tmatheson).
[CodeGen][ARM] Implement atomicrmw as pseudo operations at -O0
May 3 2021, 12:27 PM

Apr 30 2021

tmatheson added a reverting change for rG3338290c187b: [CodeGen][ARM] Implement atomicrmw as pseudo operations at -O0: rGc7df6b1223d8: Revert "[CodeGen][ARM] Implement atomicrmw as pseudo operations at -O0".
Apr 30 2021, 8:54 AM
tmatheson committed rGc7df6b1223d8: Revert "[CodeGen][ARM] Implement atomicrmw as pseudo operations at -O0" (authored by tmatheson).
Revert "[CodeGen][ARM] Implement atomicrmw as pseudo operations at -O0"
Apr 30 2021, 8:54 AM
tmatheson added a reverting change for D101164: [CodeGen][ARM] Implement atomicrmw as pseudo operations at -O0: rGc7df6b1223d8: Revert "[CodeGen][ARM] Implement atomicrmw as pseudo operations at -O0".
Apr 30 2021, 8:54 AM · Restricted Project
tmatheson committed rG3338290c187b: [CodeGen][ARM] Implement atomicrmw as pseudo operations at -O0 (authored by tmatheson).
[CodeGen][ARM] Implement atomicrmw as pseudo operations at -O0
Apr 30 2021, 8:41 AM
tmatheson closed D101164: [CodeGen][ARM] Implement atomicrmw as pseudo operations at -O0.
Apr 30 2021, 8:41 AM · Restricted Project
tmatheson updated the diff for D101164: [CodeGen][ARM] Implement atomicrmw as pseudo operations at -O0.

Rebase to try to get CI to pass

Apr 30 2021, 6:20 AM · Restricted Project
tmatheson committed rGb14a6f06cc87: [ARM][MVE] vcreateq lane ordering for big endian (authored by tmatheson).
[ARM][MVE] vcreateq lane ordering for big endian
Apr 30 2021, 5:50 AM
tmatheson closed D101606: [ARM][MVE] vcreateq lane ordering for big endian.
Apr 30 2021, 5:49 AM · Restricted Project
tmatheson added a comment to D101606: [ARM][MVE] vcreateq lane ordering for big endian.

Sounds good to me.

Whilst we are here, are any of the other uses of bitcast in arm_mve.td potentially a problem? I took a quick look and because they both converting the inputs and the outputs, I believe they will be OK. (Two wrongs make a right, if you will).

Apr 30 2021, 3:00 AM · Restricted Project
tmatheson updated the diff for D101606: [ARM][MVE] vcreateq lane ordering for big endian.

Use --check-prefixes=CHECK,CHECK-BE etc to combine common blocks.
Sorry for the churn.

Apr 30 2021, 2:56 AM · Restricted Project
tmatheson updated the diff for D101606: [ARM][MVE] vcreateq lane ordering for big endian.

remove old check lines that were not automatically removed

Apr 30 2021, 2:48 AM · Restricted Project
tmatheson updated the diff for D101606: [ARM][MVE] vcreateq lane ordering for big endian.

Use update_cc_test_checks

Apr 30 2021, 2:43 AM · Restricted Project
tmatheson added inline comments to D101606: [ARM][MVE] vcreateq lane ordering for big endian.
Apr 30 2021, 2:35 AM · Restricted Project
tmatheson retitled D101606: [ARM][MVE] vcreateq lane ordering for big endian from [ARM] vcreateq lane ordering for big endian to [ARM][MVE] vcreateq lane ordering for big endian.
Apr 30 2021, 1:55 AM · Restricted Project
tmatheson edited reviewers for D101606: [ARM][MVE] vcreateq lane ordering for big endian, added: dmgreen; removed: greened.
Apr 30 2021, 1:40 AM · Restricted Project
tmatheson added a comment to D101164: [CodeGen][ARM] Implement atomicrmw as pseudo operations at -O0.

I will merge this today

Apr 30 2021, 1:38 AM · Restricted Project
tmatheson added reviewers for D101606: [ARM][MVE] vcreateq lane ordering for big endian: MarkMurrayARM, greened, john.brawn, simon_tatham.
Apr 30 2021, 1:37 AM · Restricted Project
tmatheson requested review of D101606: [ARM][MVE] vcreateq lane ordering for big endian.
Apr 30 2021, 1:36 AM · Restricted Project

Apr 29 2021

tmatheson added a comment to D99091: [locale][num_get] Improve Stage 2 of string to float conversion.

Friendly ping

Apr 29 2021, 1:26 AM · Restricted Project

Apr 26 2021

tmatheson updated the summary of D100944: [MC][ELF] Emit separate unique sections for different flags.
Apr 26 2021, 11:29 AM · Restricted Project
tmatheson added reviewers for D100944: [MC][ELF] Emit separate unique sections for different flags: simon_tatham, amilendra.
Apr 26 2021, 11:23 AM · Restricted Project
tmatheson updated the diff for D101164: [CodeGen][ARM] Implement atomicrmw as pseudo operations at -O0.

Fix bad merge

Apr 26 2021, 2:33 AM · Restricted Project
tmatheson added reviewers for D101164: [CodeGen][ARM] Implement atomicrmw as pseudo operations at -O0: labrinea, LemonBoy, tschuett, lenary.
Apr 26 2021, 2:30 AM · Restricted Project
tmatheson updated the diff for D101164: [CodeGen][ARM] Implement atomicrmw as pseudo operations at -O0.

Fix bad merge

Apr 26 2021, 2:02 AM · Restricted Project

Apr 23 2021

tmatheson added a comment to D101163: [AArch64] Prevent spilling between ldxr/stxr pairs.

The same problem exists in the ARM backend, which I fixed internally by implementing new pseudos for the atomicrmw instructions, but hadn't got round to upstreaming it yet. Here it is for comparison: D101164.

Apr 23 2021, 7:44 AM · Restricted Project
tmatheson requested review of D101164: [CodeGen][ARM] Implement atomicrmw as pseudo operations at -O0.
Apr 23 2021, 7:25 AM · Restricted Project
tmatheson updated the diff for D100944: [MC][ELF] Emit separate unique sections for different flags.

clang-format

Apr 23 2021, 4:45 AM · Restricted Project
tmatheson updated the summary of D100944: [MC][ELF] Emit separate unique sections for different flags.
Apr 23 2021, 4:42 AM · Restricted Project
tmatheson updated the diff for D100944: [MC][ELF] Emit separate unique sections for different flags.
  • [NFCI] Factor out ELF section unique ID calculation into function
  • [CodeGen][ELF] Create unique sections for different flags
Apr 23 2021, 2:41 AM · Restricted Project

Apr 21 2021

tmatheson added a comment to D100944: [MC][ELF] Emit separate unique sections for different flags.

Hi @bd1976llvm, I was planning to update the description, add reviewers and close the other review once the CI was passing. I'll also update the patch taking your comments into consideration.

Apr 21 2021, 9:27 AM · Restricted Project
tmatheson requested review of D100944: [MC][ELF] Emit separate unique sections for different flags.
Apr 21 2021, 4:41 AM · Restricted Project
tmatheson added a comment to D99091: [locale][num_get] Improve Stage 2 of string to float conversion.

Ping. @Quuxplusone were there any outstanding issues you wanted me to address?

Apr 21 2021, 2:22 AM · Restricted Project

Apr 14 2021

tmatheson updated the diff for D99091: [locale][num_get] Improve Stage 2 of string to float conversion.

Update abilist for MacOS C++20

Apr 14 2021, 3:50 AM · Restricted Project
tmatheson added a comment to D99091: [locale][num_get] Improve Stage 2 of string to float conversion.

Ping

Apr 14 2021, 2:59 AM · Restricted Project

Apr 7 2021

tmatheson added inline comments to D99091: [locale][num_get] Improve Stage 2 of string to float conversion.
Apr 7 2021, 12:42 PM · Restricted Project
tmatheson updated the diff for D99091: [locale][num_get] Improve Stage 2 of string to float conversion.

Update formatting to match the rest of the file

Apr 7 2021, 12:36 PM · Restricted Project
tmatheson added inline comments to D99091: [locale][num_get] Improve Stage 2 of string to float conversion.
Apr 7 2021, 10:16 AM · Restricted Project