Page MenuHomePhabricator

tmatheson (Tomas Matheson)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 10 2020, 4:17 AM (120 w, 2 d)

Recent Activity

Thu, Mar 30

tmatheson accepted D142135: [AArch64] Basic target("+crypto") handling.
Thu, Mar 30, 6:02 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Mar 27

tmatheson accepted D146962: [AArch64] Add v8.9a/v9.4a FEAT_ATS1A.
Mon, Mar 27, 8:02 AM · Restricted Project, Restricted Project
tmatheson added a comment to D146242: [ARM] Fixing ABI mismatch for packed structs and fields.

LGTM, but I'm not that familiar with the code that selects the alignment so it would be good to get a second opinion.

Mon, Mar 27, 2:46 AM · Restricted Project, Restricted Project

Fri, Mar 24

tmatheson committed rG3884f07a55ab: [extract_symbols.py] Export unique symbols (authored by tmatheson).
[extract_symbols.py] Export unique symbols
Fri, Mar 24, 9:39 AM · Restricted Project, Restricted Project
tmatheson closed D146731: [extract_symbols.py] Export unique symbols.
Fri, Mar 24, 9:38 AM · Restricted Project, Restricted Project
tmatheson added a reviewer for D146731: [extract_symbols.py] Export unique symbols: ttheodor.
Fri, Mar 24, 7:33 AM · Restricted Project, Restricted Project

Thu, Mar 23

tmatheson requested review of D146731: [extract_symbols.py] Export unique symbols.
Thu, Mar 23, 9:15 AM · Restricted Project, Restricted Project
tmatheson added a comment to D140637: [InlineOrder] Plugin Inline Order.

This test fails when I build and run with the following:

cmake ../llvm -GNinja -DCMAKE_BUILD_TYPE=Release -DLLVM_EXPORT_SYMBOLS_FOR_PLUGINS=ON -DLLVM_ENABLE_PLUGINS=ON -DBUILD_SHARED_LIBS=OFF -DLLVM_ENABLE_PROJECTS=clang
ninja unittests/Analysis/AnalysisTests
./unittests/Analysis/AnalysisTests --gtest_filter=PluginInlineOrderTest.NoInlineFoo

I get the following failure:

$ ./unittests/Analysis/AnalysisTests --gtest_filter=PluginInlineOrderTest.NoInlineFoo
Note: Google Test filter = PluginInlineOrderTest.NoInlineFoo
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from PluginInlineOrderTest
[ RUN      ] PluginInlineOrderTest.NoInlineFoo
/ssd/upstream/llvm/unittests/Analysis/PluginInlineOrderAnalysisTest.cpp:48: Failure
Value of: !!Plugin
  Actual: false
Expected: true
Plugin path: /ssd/upstream/build2/unittests/Analysis/InlineOrderPlugin.so
[  FAILED  ] PluginInlineOrderTest.NoInlineFoo (4 ms)
[----------] 1 test from PluginInlineOrderTest (4 ms total)
Thu, Mar 23, 6:59 AM · Restricted Project, Restricted Project
tmatheson accepted D146630: [AArch64] Add Missing Custom Target Operands.

LGTM

Thu, Mar 23, 3:38 AM · Restricted Project, Restricted Project

Tue, Mar 21

tmatheson added a comment to D146242: [ARM] Fixing ABI mismatch for packed structs and fields.

Looks sensible but I don't fully understand the context of the change. Please could you explain more what is wrong with the current behaviour, and which parts of the AAPCS you are referring to.

Tue, Mar 21, 10:19 AM · Restricted Project, Restricted Project

Fri, Mar 17

tmatheson updated subscribers of D141429: [AArch64] Codegen for FEAT_LRCPC3.
Fri, Mar 17, 6:33 AM · Restricted Project, Restricted Project
tmatheson added reviewers for D146242: [ARM] Fixing ABI mismatch for packed structs and fields: tmatheson, pratlucas.
Fri, Mar 17, 6:11 AM · Restricted Project, Restricted Project

Mon, Mar 13

tmatheson accepted D145781: [AArch64] Don't #define __ARM_FP when there's no FPU..

LGTM

Mon, Mar 13, 9:10 AM · Restricted Project, Restricted Project

Wed, Mar 8

tmatheson accepted D145538: [NFC][AArch64] Document and improve FMV code..

LGTM, thanks for making these changes.

Wed, Mar 8, 5:32 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Mar 7

tmatheson accepted D145249: [TargetParser] Disallow Global Constructors.
Tue, Mar 7, 2:45 AM · Restricted Project, Restricted Project
tmatheson committed rG0fcd4177063a: [AArch64TargetParser] reinstate assert for optional (authored by tmatheson).
[AArch64TargetParser] reinstate assert for optional
Tue, Mar 7, 2:43 AM · Restricted Project, Restricted Project
tmatheson closed D145371: [AArch64TargetParser] reinstate assert for optional.
Tue, Mar 7, 2:43 AM · Restricted Project, Restricted Project

Mon, Mar 6

tmatheson added a comment to D145206: [NFC] Properly handle optional minor value for ArchInfo::Version.

For anyone reading, there's more context here about std::optional::value(): https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716

Mon, Mar 6, 5:04 AM · Restricted Project, Restricted Project
tmatheson requested review of D145371: [AArch64TargetParser] reinstate assert for optional.
Mon, Mar 6, 5:02 AM · Restricted Project, Restricted Project

Fri, Mar 3

tmatheson added a comment to D145249: [TargetParser] Disallow Global Constructors.

@mehdi_amini can you explain what the original reasoning behind this restriction was for Support, and whether we need to make the same restriction for TargetParser now that it's split out?

Fri, Mar 3, 9:13 AM · Restricted Project, Restricted Project
tmatheson added a comment to D145206: [NFC] Properly handle optional minor value for ArchInfo::Version.

I'm not sure that this is the right fix. The exception indicates that this is being called with ArchInfo objects with invalid VersionTuples, how is that happening? Also could you explain what the issue is with bad_optional_access on older macOS?

Fri, Mar 3, 7:11 AM · Restricted Project, Restricted Project

Feb 14 2023

tmatheson planned changes to D141431: [AArch64] FEAT_LRCPC3 load/store optimisations.
Feb 14 2023, 8:40 AM · Restricted Project, Restricted Project

Feb 13 2023

tmatheson committed rG9e3010ad992d: [AArch64] Fix LSE2/LSE128/RCPC3 precedence (authored by tmatheson).
[AArch64] Fix LSE2/LSE128/RCPC3 precedence
Feb 13 2023, 4:32 AM · Restricted Project, Restricted Project
tmatheson closed D143506: [AArch64] Fix LSE2/LSE128/RCPC3 precedence.
Feb 13 2023, 4:32 AM · Restricted Project, Restricted Project

Feb 8 2023

tmatheson added inline comments to D141429: [AArch64] Codegen for FEAT_LRCPC3.
Feb 8 2023, 2:01 AM · Restricted Project, Restricted Project

Feb 7 2023

tmatheson updated the diff for D143506: [AArch64] Fix LSE2/LSE128/RCPC3 precedence.

Use LSE2 for unordered/monotonic

Feb 7 2023, 10:42 AM · Restricted Project, Restricted Project
tmatheson requested review of D143506: [AArch64] Fix LSE2/LSE128/RCPC3 precedence.
Feb 7 2023, 8:36 AM · Restricted Project, Restricted Project

Feb 1 2023

tmatheson added a comment to D142963: [AArch64] Handle negative architecture features.

Speaking as the one who filed the motivating bug report, all of the above behaviors are fine. The motivating use case is explicitly specifying a full set of enabled/disabled features, leaving nothing changed by LLVM's own dependency resolution. In this use case, LLVM would never see any of these three scenarios as input.

Feb 1 2023, 3:40 AM · Restricted Project, Restricted Project

Jan 31 2023

tmatheson added a comment to D142135: [AArch64] Basic target("+crypto") handling.

By the way I don't really have any more to add, and I've lost track of what the status of +crypto is after all the recent changes, so don't let me block this. From what you've said aligning with GCC sounds sensible, but an intermediate stage where -march does one thing and the target attribute does another seems less ideal.

Jan 31 2023, 8:00 AM · Restricted Project, Restricted Project, Restricted Project
tmatheson added a comment to D142963: [AArch64] Handle negative architecture features.

It looks like this has these odd behaviours:

  • -target-feature +v9.3a -target-feature -v9.2a will remove v9.2a but add all the dependent features of both v9.3a and v9.2a. It also doesn't remove v9.3a which implies v9.2a.
  • -target-feature -v9.2a -target-feature +v9.3a will add the v9.2a back, and also add all the dependent features of both v9.3a and v9.2a.
  • -target-feature +v9.3a -target-feature -v9.3a will remove v9.3a but add all the dependent features of v9.3a.
Jan 31 2023, 2:42 AM · Restricted Project, Restricted Project

Jan 30 2023

tmatheson committed rG5a9cb377228b: [AArch64] Add atomics tests for lse2+lse128 (authored by tmatheson).
[AArch64] Add atomics tests for lse2+lse128
Jan 30 2023, 3:40 AM · Restricted Project, Restricted Project
tmatheson closed D142712: [AArch64] Add atomics tests for lse2+lse128.
Jan 30 2023, 3:40 AM · Restricted Project, Restricted Project

Jan 27 2023

tmatheson added a comment to D141406: [AArch64] Codegen for FEAT_LSE128.

@efriedma D142712 Like this?

Jan 27 2023, 5:54 AM · Restricted Project, Restricted Project
tmatheson requested review of D142712: [AArch64] Add atomics tests for lse2+lse128.
Jan 27 2023, 5:53 AM · Restricted Project, Restricted Project
tmatheson accepted D142541: [NFC][AArch64] Get extension strings directly from ArchInfo in target parser.
Jan 27 2023, 5:08 AM · Restricted Project, Restricted Project, Restricted Project
tmatheson added a comment to D127812: [AArch64] FMV support and necessary target features dependencies..

This patch has made it considerably harder to understand what is going on in the TargetParser. If you get a chance, please could you add some clarifying comments and tidy-ups. I appreciate that a lot of this is following the lead of the pre-existing TargetParser code, but lets try to improve it as we go.

Jan 27 2023, 3:51 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 26 2023

tmatheson accepted D142539: [NFC][AArch64] Use optional returns in target parser instead of 'invalid' objects.
Jan 26 2023, 6:58 AM · Restricted Project, Restricted Project, Restricted Project
tmatheson accepted D142540: [NFC][AArch64] Get default features directly from ArchInfo and CpuInfo objects.

Looks great, thanks

Jan 26 2023, 6:57 AM · Restricted Project, Restricted Project, Restricted Project
tmatheson added a comment to D138905: [AArch64] add missing Armv8.9-A -> Armv9.4-A equivalence test.

Yes this case is tested for implies(): EXPECT_TRUE(AArch64::ARMV9_4A.implies(AArch64::ARMV8_9A));

Jan 26 2023, 6:20 AM · Restricted Project, Restricted Project
tmatheson added inline comments to D142539: [NFC][AArch64] Use optional returns in target parser instead of 'invalid' objects.
Jan 26 2023, 5:49 AM · Restricted Project, Restricted Project, Restricted Project
tmatheson added a comment to D141406: [AArch64] Codegen for FEAT_LSE128.

No, FEAT_LSE128 only implies FEAT_LSE, not FEAT_LSE2.

Jan 26 2023, 5:28 AM · Restricted Project, Restricted Project

Jan 25 2023

tmatheson committed rG7c84f94eb9f9: [AArch64] Codegen for FEAT_LRCPC3 (authored by tmatheson).
[AArch64] Codegen for FEAT_LRCPC3
Jan 25 2023, 4:29 AM · Restricted Project, Restricted Project
tmatheson closed D141429: [AArch64] Codegen for FEAT_LRCPC3.
Jan 25 2023, 4:28 AM · Restricted Project, Restricted Project
tmatheson committed rGf1f583347d00: [AArch64] Codegen for FEAT_LSE128 (authored by tmatheson).
[AArch64] Codegen for FEAT_LSE128
Jan 25 2023, 4:03 AM · Restricted Project, Restricted Project
tmatheson closed D141406: [AArch64] Codegen for FEAT_LSE128.
Jan 25 2023, 4:02 AM · Restricted Project, Restricted Project

Jan 24 2023

tmatheson updated the diff for D141429: [AArch64] Codegen for FEAT_LRCPC3.

Require LSE2

Jan 24 2023, 7:28 AM · Restricted Project, Restricted Project

Jan 23 2023

tmatheson accepted D141404: [AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver.
Jan 23 2023, 8:11 AM · Restricted Project, Restricted Project, Restricted Project
tmatheson added inline comments to D141404: [AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver.
Jan 23 2023, 8:07 AM · Restricted Project, Restricted Project, Restricted Project
tmatheson updated the summary of D141406: [AArch64] Codegen for FEAT_LSE128.
Jan 23 2023, 7:34 AM · Restricted Project, Restricted Project
tmatheson abandoned D142366: [AArch64] Codegen for FEAT_LSE128.

D141406

Jan 23 2023, 7:33 AM · Restricted Project, Restricted Project
tmatheson updated the diff for D141406: [AArch64] Codegen for FEAT_LSE128.

Add comments clarifying asserts

Jan 23 2023, 7:33 AM · Restricted Project, Restricted Project
tmatheson requested review of D142366: [AArch64] Codegen for FEAT_LSE128.
Jan 23 2023, 7:31 AM · Restricted Project, Restricted Project

Jan 20 2023

tmatheson added a comment to D142135: [AArch64] Basic target("+crypto") handling.

I'm concerned that the +crypto situation is already confusing, and adding another different meaning for it in the context of the target(...) attribute exacerbates it. Is the plan for this to eventually match the behaviour of -march=...+crypto?

Jan 20 2023, 12:07 AM · Restricted Project, Restricted Project, Restricted Project

Jan 19 2023

tmatheson accepted D142087: [AArch64] Armv9-A implies FP16.

LGTM

Jan 19 2023, 1:45 AM · Restricted Project, Restricted Project, Restricted Project

Jan 14 2023

tmatheson closed D139102: [AArch64] Inline AArch64TargetParser.def.

Landed as part of f4225d325c19ae0e5dbe39faa900d81e24559da0

Jan 14 2023, 6:45 AM · Restricted Project, Restricted Project, Restricted Project
tmatheson closed D139278: [AArch64] Use string comparison for ArchInfo equality.

Landed as part of f4225d325c19ae0e5dbe39faa900d81e24559da0

Jan 14 2023, 6:45 AM · Restricted Project, Restricted Project
tmatheson committed rGf4225d325c19: [AArch64] Reland "Improve TargetParser API" (authored by tmatheson).
[AArch64] Reland "Improve TargetParser API"
Jan 14 2023, 6:45 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
tmatheson closed D138792: [AArch64] Improve TargetParser API.
Jan 14 2023, 6:44 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
tmatheson updated the diff for D138792: [AArch64] Improve TargetParser API.

Address comments and fix flang test

Jan 14 2023, 3:47 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 13 2023

tmatheson added inline comments to D138792: [AArch64] Improve TargetParser API.
Jan 13 2023, 8:35 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
tmatheson added a comment to D138792: [AArch64] Improve TargetParser API.

Worth noting that this had to be reworked because both D127812 and D137838 went in since this was reverted.

Jan 13 2023, 6:31 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
tmatheson added a comment to D138792: [AArch64] Improve TargetParser API.

The most recent versions of this patch contains squashed changes from these reviews:

  • D139278 "[AArch64] Use string comparison for ArchInfo equality." This fixes the test failures with shared libraries, which were caused by each shared library ending up with it's own copy of the ArchInfo instances and hence breaking the equality-by-address.
  • D139102 "[AArch64] Inline AArch64TargetParser.def"
Jan 13 2023, 6:25 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
tmatheson updated the diff for D138792: [AArch64] Improve TargetParser API.

Fix clang/test/Sema/attr-target-clones-aarch64.c

Jan 13 2023, 4:34 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 12 2023

tmatheson updated the diff for D138792: [AArch64] Improve TargetParser API.

Reworked after several other major changes to the TargetParser since
this was reverted. Combined with several other approved changes.

Jan 12 2023, 2:11 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
tmatheson added a comment to D141064: [AArch64] Comprehensive tests for atomic operations.

It does, I need to check that the old tests are definitely replicated here before removing them.

Jan 12 2023, 6:36 AM · Restricted Project, Restricted Project
tmatheson added a comment to D141404: [AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver.

I agree the approach in D141518 makes more sense

Jan 12 2023, 6:35 AM · Restricted Project, Restricted Project, Restricted Project
tmatheson accepted D141518: [AArch64] Move default extensions from clang Driver to TargetParser.
Jan 12 2023, 6:34 AM · Restricted Project, Restricted Project, Restricted Project
tmatheson added a comment to D141518: [AArch64] Move default extensions from clang Driver to TargetParser.

LGTM, makes sense to move into TP, D141404 should do the same it it makes sense.

Jan 12 2023, 6:33 AM · Restricted Project, Restricted Project, Restricted Project

Jan 10 2023

tmatheson requested review of D141431: [AArch64] FEAT_LRCPC3 load/store optimisations.
Jan 10 2023, 2:01 PM · Restricted Project, Restricted Project
tmatheson requested review of D141429: [AArch64] Codegen for FEAT_LRCPC3.
Jan 10 2023, 2:00 PM · Restricted Project, Restricted Project
tmatheson added inline comments to D141406: [AArch64] Codegen for FEAT_LSE128.
Jan 10 2023, 11:43 AM · Restricted Project, Restricted Project
tmatheson accepted D141404: [AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver.
Jan 10 2023, 9:23 AM · Restricted Project, Restricted Project, Restricted Project
tmatheson accepted D141403: [AArch64] Add command line support for v9.4-A's Instrumentation Extension.
Jan 10 2023, 9:22 AM · Restricted Project, Restricted Project, Restricted Project
tmatheson accepted D141402: [AArch64] Support v8.9-A/v9.4-A in .arch_extension directive.
Jan 10 2023, 9:21 AM · Restricted Project, Restricted Project
tmatheson accepted D141400: [AArch64] Add missing system register for v8.9-A/v9.4-A Permission Indirection Extension.
Jan 10 2023, 9:20 AM · Restricted Project, Restricted Project
tmatheson requested review of D141406: [AArch64] Codegen for FEAT_LSE128.
Jan 10 2023, 9:16 AM · Restricted Project, Restricted Project
tmatheson committed rGf3fb973924a9: [AArch64] Comprehensive tests for atomic operations (authored by tmatheson).
[AArch64] Comprehensive tests for atomic operations
Jan 10 2023, 6:03 AM · Restricted Project, Restricted Project
tmatheson closed D141064: [AArch64] Comprehensive tests for atomic operations.
Jan 10 2023, 6:02 AM · Restricted Project, Restricted Project

Jan 5 2023

tmatheson added reviewers for D141064: [AArch64] Comprehensive tests for atomic operations: lenary, efriedma, t.p.northover.
Jan 5 2023, 8:05 AM · Restricted Project, Restricted Project
tmatheson requested review of D141064: [AArch64] Comprehensive tests for atomic operations.
Jan 5 2023, 7:54 AM · Restricted Project, Restricted Project

Dec 23 2022

tmatheson added a comment to D139644: [InlineAdvisor] Allow loading advisors as plugins.

I am still seeing this linking error when building with LLVM_EXPORT_SYMBOLS_FOR_PLUGINS: /unittests/Analysis/InlineAdvisorPlugin.so: undefined symbol: _ZN4llvm13AllAnalysesOnINS_6ModuleEE6SetKeyEStack.

Dec 23 2022, 3:04 AM · Restricted Project, Restricted Project

Dec 20 2022

tmatheson accepted D140222: [AArch64] Check 128-bit Sysreg Builtins.

Couple of nits, since you will be updating this anyway after dropping D140221, otherwise LGTM.

Dec 20 2022, 4:45 AM · Restricted Project, Restricted Project
tmatheson added a comment to D140221: [Support] Add StringSwitch::AsOptional.

I'm not convinced this gives us much over using InnerT=optional directly; arguably it just obfuscates the type. There are no examples in the codebase for StringSwitch<std::optional>, but there are about 80 of StringSwitch<llvm::Optional>, and they typically look like this:

auto Level = llvm::StringSwitch<Optional<Driver::ReproLevel>>(A->getValue())
                 .Case("off", Driver::ReproLevel::Off)
                 .Case("crash", Driver::ReproLevel::OnCrash)
                 .Case("error", Driver::ReproLevel::OnError)
                 .Case("always", Driver::ReproLevel::Always)
                 .Default(None);

The std::optional equivalent can be written pretty much the same. In your before example, you don't need explicit std::optional constructor calls, you can use auto because they type is obvious from the RHS, and you can use the default constructor for std::optional (debatable whether that is preferable to std::nullopt):

auto Foo = llvm::StringSwitch<std::optional<InnerT>>(str)
    .Case("foo", InnerT(...))
    .Default({});
Dec 20 2022, 3:28 AM · Restricted Project, Restricted Project

Dec 16 2022

tmatheson accepted D140216: [AArch64] Add missing v8.8a Non-maskable Interrupts feature.
Dec 16 2022, 7:02 AM · Restricted Project, Restricted Project

Dec 5 2022

tmatheson added a comment to D138792: [AArch64] Improve TargetParser API.

@MaskRay I reverted that commit because it broke important functionality (comparison by address) to fix an issue in an unsupported C++ version, it wasn't reviewed, and it was not clear from the commit message what it was fixing. I explained this in a comment on the original commit but forgot to add it to the message for the revert, sorry.

Dec 5 2022, 3:48 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
tmatheson added a reverting change for rGe83f1502f1be: [AArch64] Improve TargetParser API: rG541a1371c05d: Revert "[AArch64] Improve TargetParser API".
Dec 5 2022, 3:10 AM · Restricted Project, Restricted Project, Restricted Project
tmatheson committed rG541a1371c05d: Revert "[AArch64] Improve TargetParser API" (authored by tmatheson).
Revert "[AArch64] Improve TargetParser API"
Dec 5 2022, 3:10 AM · Restricted Project, Restricted Project, Restricted Project
tmatheson added a reverting change for D138792: [AArch64] Improve TargetParser API: rG541a1371c05d: Revert "[AArch64] Improve TargetParser API".
Dec 5 2022, 3:10 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Dec 4 2022

tmatheson added inline comments to D138792: [AArch64] Improve TargetParser API.
Dec 4 2022, 1:08 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
tmatheson added a comment to D138792: [AArch64] Improve TargetParser API.

Yes I will look into it and address the other comments when I have more time tomorrow or later this week. However I'm starting to think that the comparison by address is too easy to subtly break, and not immediately obvious to debug, and is therefore not worth it in this case. The performance of the comparison is not especially critical here afaik.

Dec 4 2022, 12:52 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
tmatheson added a comment to D138792: [AArch64] Improve TargetParser API.

@Hahnfeld, @mgorny I was able to reproduce the failures with LLVM_LINK_LLVM_DYLIB, and they are failing because the comparison is failing because copies are being created. I don't fully understand how but presumably we are still ending up with one object per shared library. I tried adding a constructor as @bkramer suggested but this did not solve the issue. Please see D139278 for a fix.

Dec 4 2022, 12:38 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
tmatheson requested review of D139278: [AArch64] Use string comparison for ArchInfo equality.
Dec 4 2022, 12:32 PM · Restricted Project, Restricted Project
tmatheson added a reverting change for rG6272f87ba061: [AArch64] Make ArchInfo copyable again: rG8be0d8fb83aa: Revert "[AArch64] Make ArchInfo copyable again".
Dec 4 2022, 3:01 AM · Restricted Project, Restricted Project
tmatheson committed rG8be0d8fb83aa: Revert "[AArch64] Make ArchInfo copyable again" (authored by tmatheson).
Revert "[AArch64] Make ArchInfo copyable again"
Dec 4 2022, 3:00 AM · Restricted Project, Restricted Project
tmatheson added a comment to rG6272f87ba061: [AArch64] Make ArchInfo copyable again.

I don't see the point of disallowing copying an aggregate,

Dec 4 2022, 2:59 AM · Restricted Project, Restricted Project

Dec 2 2022

tmatheson added a comment to D138792: [AArch64] Improve TargetParser API.

Hi, I bisected this change to lead to a couple of test failures when building with LLVM_LINK_LLVM_DYLIB. In the past, this had to do with global variable initialization order, but nothing immediately jumps to my eye in this patch. Is AARCH64_ARCH used to define global variables?

Dec 2 2022, 11:33 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
tmatheson added a comment to D139102: [AArch64] Inline AArch64TargetParser.def.

And this is the file that was being generated: https://github.com/ziglang/zig/blob/c86589a738e5053a26b2be7d156bcfee1565f00b/lib/std/target/aarch64.zig

Dec 2 2022, 4:39 AM · Restricted Project, Restricted Project, Restricted Project
tmatheson updated the diff for D139102: [AArch64] Inline AArch64TargetParser.def.

Update lldb test

Dec 2 2022, 4:35 AM · Restricted Project, Restricted Project, Restricted Project
tmatheson committed rGc4edeb838519: [NFC] clang-format AArch64TargetParser (authored by tmatheson).
[NFC] clang-format AArch64TargetParser
Dec 2 2022, 3:00 AM · Restricted Project, Restricted Project

Dec 1 2022

tmatheson committed rGf3c322332d83: [AArch64] Add missing #include (authored by tmatheson).
[AArch64] Add missing #include
Dec 1 2022, 7:55 AM · Restricted Project, Restricted Project