This is an archive of the discontinued LLVM Phabricator instance.

[AIX] Add _AIX73 version macro
ClosedPublic

Authored by Jake-Egan on Jun 30 2021, 5:23 AM.

Details

Summary

This patch defines _AIX73 version macro for AIX 7.3.

It extends the following patch https://reviews.llvm.org/D61530.

Diff Detail

Event Timeline

Jake-Egan created this revision.Jun 30 2021, 5:23 AM
Jake-Egan requested review of this revision.Jun 30 2021, 5:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 30 2021, 5:23 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Jake-Egan retitled this revision from Add _AIX73 macro to [AIX] Add _AIX73 version macro.Jun 30 2021, 5:29 AM
Jake-Egan edited the summary of this revision. (Show Details)
xgupta accepted this revision.Jun 30 2021, 5:56 AM
xgupta added a subscriber: xgupta.

LGTM

clang/lib/Basic/Targets/OSTargets.h
704

Seems this line need formatting?

This revision is now accepted and ready to land.Jun 30 2021, 5:56 AM
Jake-Egan added inline comments.Jun 30 2021, 6:08 AM
clang/lib/Basic/Targets/OSTargets.h
704

I originally had it matching the format of the other _AIX macro definitions, but clang-format modified it to this.

xgupta added inline comments.Jun 30 2021, 6:22 AM
clang/lib/Basic/Targets/OSTargets.h
704

I think clang-format is there to maintain consistency in the codebase. You can ignore it if it is doing the opposite.

Jake-Egan added inline comments.Jun 30 2021, 6:58 AM
clang/lib/Basic/Targets/OSTargets.h
704

Do you suggest that I revise the formatting then?

xgupta added inline comments.Jun 30 2021, 7:52 AM
clang/lib/Basic/Targets/OSTargets.h
704

Yeah, I think so, neglect clang-format. But you can wait for other reviewer's comments.

Fixed formatting to be consistent with the other macro definitions.

Jake-Egan marked 3 inline comments as done.Jun 30 2021, 10:17 AM
This revision was landed with ongoing or failed builds.Jul 5 2021, 1:29 PM
Closed by commit rG52f34673ead3: [AIX] Add _AIX73 version macro (authored by Jake-Egan, committed by stevewan). · Explain Why
This revision was automatically updated to reflect the committed changes.