Page MenuHomePhabricator

stevewan (Steven Wan)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 26 2019, 10:57 AM (10 w, 6 d)

Recent Activity

Mon, Dec 2

stevewan updated the diff for D69620: Add AIX assembler support.

State in the comment the expectation to driver in handling assembler source input when invoking as(1).

Mon, Dec 2, 7:55 AM · Restricted Project

Fri, Nov 29

stevewan added inline comments to D69620: Add AIX assembler support.
Fri, Nov 29, 5:56 PM · Restricted Project
stevewan updated the diff for D69620: Add AIX assembler support.

Add more input file handling

Fri, Nov 29, 5:02 PM · Restricted Project
stevewan updated the summary of D69620: Add AIX assembler support.
Fri, Nov 29, 9:05 AM · Restricted Project
stevewan updated the diff for D69620: Add AIX assembler support.

Correct a typo in a comment.

Fri, Nov 29, 9:05 AM · Restricted Project

Mon, Nov 25

stevewan added inline comments to D69620: Add AIX assembler support.
Mon, Nov 25, 8:11 PM · Restricted Project
stevewan updated the diff for D69620: Add AIX assembler support.

Remove claimNoWarnArgs, limit the number of input files, and add more comments.

Mon, Nov 25, 7:39 PM · Restricted Project

Wed, Nov 20

stevewan added inline comments to D69620: Add AIX assembler support.
Wed, Nov 20, 6:34 PM · Restricted Project
stevewan updated the diff for D69620: Add AIX assembler support.

Add "-u" to accept undefined symbol as extern.

Wed, Nov 20, 6:25 PM · Restricted Project
stevewan added inline comments to D69620: Add AIX assembler support.
Wed, Nov 20, 5:58 PM · Restricted Project

Tue, Nov 19

stevewan added inline comments to D69620: Add AIX assembler support.
Tue, Nov 19, 10:52 AM · Restricted Project

Fri, Nov 15

stevewan added inline comments to D69620: Add AIX assembler support.
Fri, Nov 15, 10:50 AM · Restricted Project

Oct 31 2019

stevewan added a reviewer for D69620: Add AIX assembler support: dlj.
Oct 31 2019, 2:24 PM · Restricted Project

Oct 30 2019

stevewan updated the summary of D69620: Add AIX assembler support.
Oct 30 2019, 9:14 AM · Restricted Project
stevewan created D69620: Add AIX assembler support.
Oct 30 2019, 9:12 AM · Restricted Project

Oct 24 2019

stevewan added a comment to D68340: Add AIX toolchain and basic linker functionality.
Oct 24 2019, 2:26 PM · Restricted Project
stevewan accepted D69356: [NFC] Rename LLVM_NO_DEAD_STRIP.

LGTM

Oct 24 2019, 1:38 PM · Restricted Project, Restricted Project
stevewan added inline comments to D68340: Add AIX toolchain and basic linker functionality.
Oct 24 2019, 11:32 AM · Restricted Project
stevewan updated the diff for D68340: Add AIX toolchain and basic linker functionality.

Capture local variable IsArch32Bit by value.

Oct 24 2019, 11:20 AM · Restricted Project
stevewan added a comment to D69356: [NFC] Rename LLVM_NO_DEAD_STRIP.

The variable LLVM_NO_DEAD_STRIP also existed in the following clang code, do we also need to rename those?

./clang/tools//driver/CMakeLists.txt:23:# LLVM_NO_DEAD_STRIP.
./clang/tools//driver/CMakeLists.txt:25:  set(LLVM_NO_DEAD_STRIP 1)
Oct 24 2019, 8:35 AM · Restricted Project, Restricted Project

Oct 23 2019

stevewan accepted D69004: Use portable flag with nm in extract_symbols.py.

LGTM

Oct 23 2019, 1:41 PM · Restricted Project
stevewan updated the diff for D68340: Add AIX toolchain and basic linker functionality.

Avoid blank else block when assertion is off

Oct 23 2019, 12:42 PM · Restricted Project
stevewan added inline comments to D69004: Use portable flag with nm in extract_symbols.py.
Oct 23 2019, 12:06 PM · Restricted Project
stevewan added inline comments to D68340: Add AIX toolchain and basic linker functionality.
Oct 23 2019, 11:46 AM · Restricted Project
stevewan added reviewers for D69342: Fix non-portable GNU diff option: daltenty, hubert.reinterpretcast.
Oct 23 2019, 8:07 AM · Restricted Project
stevewan created D69342: Fix non-portable GNU diff option.
Oct 23 2019, 8:07 AM · Restricted Project

Oct 21 2019

stevewan updated the diff for D68340: Add AIX toolchain and basic linker functionality.

Tidy code with lambda expression

Oct 21 2019, 11:15 AM · Restricted Project
stevewan added inline comments to D68340: Add AIX toolchain and basic linker functionality.
Oct 21 2019, 11:15 AM · Restricted Project
stevewan abandoned D69271: Add AIX toolchain and basic linker functionality.
Oct 21 2019, 10:55 AM · Restricted Project
stevewan created D69271: Add AIX toolchain and basic linker functionality.
Oct 21 2019, 10:55 AM · Restricted Project

Oct 18 2019

stevewan updated the diff for D68340: Add AIX toolchain and basic linker functionality.

Fix periods at the end of comments

Oct 18 2019, 8:10 AM · Restricted Project

Oct 17 2019

stevewan updated the diff for D68340: Add AIX toolchain and basic linker functionality.

Address comments

Oct 17 2019, 2:27 PM · Restricted Project

Oct 10 2019

stevewan added a comment to D68529: [lit] Move argument parsing/validation to separate file.

The disappeared --threads is causing LIT failures in our internal build bots. Can you please take a look? Thanks!

Oct 10 2019, 12:28 PM · Restricted Project

Oct 9 2019

stevewan added a comment to D68604: [tsan] Don't delay SIGTRAP handler.

This is causing LIT failures in clang-s390x-linux. Can you please take a look? Thanks!

Oct 9 2019, 8:17 AM · Restricted Project, Restricted Project
stevewan added a comment to D68603: [sanitizer] Print SIGTRAP for corresponding signal.

This is causing LIT failures in clang-s390x-linux. Can you please take a look? Thanks!

Oct 9 2019, 8:17 AM · Restricted Project, Restricted Project

Oct 8 2019

stevewan added a comment to D67148: [LoopVectorize][PowerPC] Estimate int and float register pressure separately in loop-vectorize.

This is breaking our internal benchmarks, could you please take a look? Thanks!

Oct 8 2019, 8:54 AM · Restricted Project

Oct 5 2019

stevewan added a comment to rL373160: Fix checking for permitted results of constant expressions..

It appears that this commit caused assertion failures in our internal bots. The reproducer looks as follows. Please take a look. Thanks!

Oct 5 2019, 10:28 AM

Oct 4 2019

stevewan added a comment to D67968: [TableGen] Introduce a generic automaton (DFA) backend.

This is breaking our internal build bots with gcc version 5.4.0. Sample error is as follows,

Oct 4 2019, 12:23 PM · Restricted Project

Oct 2 2019

stevewan added reviewers for D68340: Add AIX toolchain and basic linker functionality: daltenty, hubert.reinterpretcast.
Oct 2 2019, 8:04 AM · Restricted Project
stevewan created D68340: Add AIX toolchain and basic linker functionality.
Oct 2 2019, 8:00 AM · Restricted Project