Page MenuHomePhabricator

stevewan (Steven Wan)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 26 2019, 10:57 AM (80 w, 6 d)

A hardwired bot that knows only how to emit "LGTM".

Recent Activity

Thu, Apr 8

stevewan added inline comments to D100071: Add csum fallback to HashProgramOutput.sh.
Thu, Apr 8, 1:31 PM
stevewan accepted D100071: Add csum fallback to HashProgramOutput.sh.

LGTM with minor nit.

Thu, Apr 8, 1:27 PM
stevewan retitled D99752: [AIX][test-suite] Fix 32-bit test-suite build on AIX from Fix 32-bit test-suite build on AIX to [AIX][test-suite] Fix 32-bit test-suite build on AIX.
Thu, Apr 8, 9:31 AM
stevewan committed rTaac78c5b8e4e: Fix 32-bit test-suite build on AIX (authored by stevewan).
Fix 32-bit test-suite build on AIX
Thu, Apr 8, 9:30 AM
stevewan closed D99752: [AIX][test-suite] Fix 32-bit test-suite build on AIX.
Thu, Apr 8, 9:30 AM

Thu, Apr 1

stevewan updated the summary of D99752: [AIX][test-suite] Fix 32-bit test-suite build on AIX.
Thu, Apr 1, 11:07 AM
stevewan requested review of D99752: [AIX][test-suite] Fix 32-bit test-suite build on AIX.
Thu, Apr 1, 11:06 AM

Mar 3 2021

stevewan committed rG0b274ed49960: [AIX] Update default arch on AIX (authored by stevewan).
[AIX] Update default arch on AIX
Mar 3 2021, 4:09 PM
stevewan closed D97823: [AIX] Update default arch on AIX.
Mar 3 2021, 4:08 PM · Restricted Project
stevewan retitled D97823: [AIX] Update default arch on AIX from Update default arch on AIX to [AIX] Update default arch on AIX.
Mar 3 2021, 9:55 AM · Restricted Project
stevewan updated the diff for D97823: [AIX] Update default arch on AIX.

Reflect varible is unused in its name.

Mar 3 2021, 9:34 AM · Restricted Project
stevewan added inline comments to D97823: [AIX] Update default arch on AIX.
Mar 3 2021, 8:37 AM · Restricted Project
stevewan updated the diff for D97823: [AIX] Update default arch on AIX.

Improve handling different AIX versions.

Mar 3 2021, 8:05 AM · Restricted Project
stevewan updated the diff for D97823: [AIX] Update default arch on AIX.

Address comments with regard to handling older AIX versions.

Mar 3 2021, 7:47 AM · Restricted Project
stevewan added inline comments to D97823: [AIX] Update default arch on AIX.
Mar 3 2021, 7:34 AM · Restricted Project

Mar 2 2021

stevewan updated the summary of D97823: [AIX] Update default arch on AIX.
Mar 2 2021, 5:44 PM · Restricted Project
stevewan added reviewers for D97823: [AIX] Update default arch on AIX: cebowleratibm, hubert.reinterpretcast, daltenty, jsji.
Mar 2 2021, 5:44 PM · Restricted Project
stevewan requested review of D97823: [AIX] Update default arch on AIX.
Mar 2 2021, 5:42 PM · Restricted Project

Feb 18 2021

stevewan added inline comments to D96282: [CMake][AIX] Adjust plugin library externsion used on AIX.
Feb 18 2021, 8:21 AM · Restricted Project

Feb 9 2021

stevewan added inline comments to D95966: [AIX][llvm][support] Implement getHostCPUName.
Feb 9 2021, 2:40 PM · Restricted Project
stevewan added inline comments to D95966: [AIX][llvm][support] Implement getHostCPUName.
Feb 9 2021, 9:17 AM · Restricted Project

Feb 4 2021

stevewan added inline comments to D95966: [AIX][llvm][support] Implement getHostCPUName.
Feb 4 2021, 12:00 PM · Restricted Project

Nov 4 2020

stevewan closed D90779: [benchmark] [PowerPC] Rename mftbl to mftb.

Committed in https://github.com/llvm/llvm-test-suite/commit/4af296ef47a0a9314a9c3ca65bf3c5d4c7020451.

Nov 4 2020, 2:53 PM
stevewan committed rG09f2c92e5b34: Add info about the cherry-picked commit and contributor (authored by stevewan).
Add info about the cherry-picked commit and contributor
Nov 4 2020, 11:24 AM
stevewan committed rG296c2f31f0c5: [PowerPC] Rename mftbl to mftb (authored by stevewan).
[PowerPC] Rename mftbl to mftb
Nov 4 2020, 11:24 AM
stevewan closed D89506: [benchmark][PowerPC] Rename mftbl to mftb.
Nov 4 2020, 11:24 AM · Restricted Project, Restricted Project
stevewan removed a reviewer for D90779: [benchmark] [PowerPC] Rename mftbl to mftb: Restricted Project.
Nov 4 2020, 11:21 AM
stevewan added a comment to D89506: [benchmark][PowerPC] Rename mftbl to mftb.

Thank you, please feel free to land this.
There's another copy in test-suite, which is not in the monorepo, might be good to also update it too.

Nov 4 2020, 11:20 AM · Restricted Project, Restricted Project
stevewan retitled D90779: [benchmark] [PowerPC] Rename mftbl to mftb from Rename mftbl to mftb to [benchmark] [PowerPC] Rename mftbl to mftb.
Nov 4 2020, 11:18 AM
stevewan requested review of D90779: [benchmark] [PowerPC] Rename mftbl to mftb.
Nov 4 2020, 11:13 AM
stevewan updated the diff for D89506: [benchmark][PowerPC] Rename mftbl to mftb.

Recover overwritten commits.

Nov 4 2020, 10:56 AM · Restricted Project, Restricted Project
stevewan updated the diff for D89506: [benchmark][PowerPC] Rename mftbl to mftb.

Add information about the cherry-picked commit and contributor.

Nov 4 2020, 10:47 AM · Restricted Project, Restricted Project

Nov 3 2020

stevewan added a comment to D89506: [benchmark][PowerPC] Rename mftbl to mftb.

Kindly ping.

Nov 3 2020, 12:38 PM · Restricted Project, Restricted Project

Nov 2 2020

stevewan added a comment to D89506: [benchmark][PowerPC] Rename mftbl to mftb.

Please can you submit this upstream first, so it doesn't get lost?

Nov 2 2020, 8:43 AM · Restricted Project, Restricted Project

Oct 20 2020

stevewan updated the summary of D89506: [benchmark][PowerPC] Rename mftbl to mftb.
Oct 20 2020, 12:49 PM · Restricted Project, Restricted Project

Oct 15 2020

stevewan updated the summary of D89506: [benchmark][PowerPC] Rename mftbl to mftb.
Oct 15 2020, 3:28 PM · Restricted Project, Restricted Project
stevewan added reviewers for D89506: [benchmark][PowerPC] Rename mftbl to mftb: hubert.reinterpretcast, daltenty.
Oct 15 2020, 3:25 PM · Restricted Project, Restricted Project
stevewan requested review of D89506: [benchmark][PowerPC] Rename mftbl to mftb.
Oct 15 2020, 3:24 PM · Restricted Project, Restricted Project

Sep 25 2020

stevewan accepted D88310: [CMake][AIX] Limit tools in external project build.

LGTM thanks. Let's give other reviewers some time to have a look.

Sep 25 2020, 2:15 PM · Restricted Project
stevewan added inline comments to D88310: [CMake][AIX] Limit tools in external project build.
Sep 25 2020, 11:04 AM · Restricted Project

Sep 23 2020

stevewan accepted D88157: [CMake] Make sure _cmake_system_name has a default.

This is consistent with the CMAKE default behaviour. LGTM. Let's see if other reviewers have further input about the updated comment.

Sep 23 2020, 3:04 PM · Restricted Project

Jul 13 2020

stevewan committed rGa7e9c5a39fbc: [llvm-ar][test][AIX] Unsupport error-opening-directory.test on AIX (authored by stevewan).
[llvm-ar][test][AIX] Unsupport error-opening-directory.test on AIX
Jul 13 2020, 9:00 AM
stevewan closed D83579: [llvm-ar][test][AIX] Unsupport error-opening-directory.test on AIX.
Jul 13 2020, 9:00 AM · Restricted Project
stevewan accepted D83055: [clang][Driver] Fix tool path priority test failures.

This LGTM, but since I'm not most familiar with the type 1 failure in description, let's see if other reviewers have further comments.

Jul 13 2020, 8:46 AM · Restricted Project

Jul 10 2020

stevewan added a comment to D83579: [llvm-ar][test][AIX] Unsupport error-opening-directory.test on AIX.

FYI @sameerarora101, we on AIX are experiencing the exact same failure as what has been fixed in D82786 for FreeBSD. This patch adds AIX to the unsupported list as well.

Jul 10 2020, 11:38 AM · Restricted Project
stevewan added reviewers for D83579: [llvm-ar][test][AIX] Unsupport error-opening-directory.test on AIX: sameerarora101, daltenty, ShuhongL, hubert.reinterpretcast.
Jul 10 2020, 11:35 AM · Restricted Project
Herald added a project to D83579: [llvm-ar][test][AIX] Unsupport error-opening-directory.test on AIX: Restricted Project.
Jul 10 2020, 11:34 AM · Restricted Project
stevewan added inline comments to D83055: [clang][Driver] Fix tool path priority test failures.
Jul 10 2020, 11:19 AM · Restricted Project

Jul 9 2020

stevewan added inline comments to D83055: [clang][Driver] Fix tool path priority test failures.
Jul 9 2020, 4:14 PM · Restricted Project
stevewan closed D83342: [test-suite][AIX] Fix C++ benchmark compatibility issues on AIX.

Committed in https://github.com/llvm/llvm-test-suite/commit/f0caeccfb893344d73474e9d8f6c034ae7f451f9.

Jul 9 2020, 10:45 AM

Jul 8 2020

stevewan updated the summary of D83342: [test-suite][AIX] Fix C++ benchmark compatibility issues on AIX.
Jul 8 2020, 3:30 PM
stevewan added inline comments to D83342: [test-suite][AIX] Fix C++ benchmark compatibility issues on AIX.
Jul 8 2020, 3:17 PM
stevewan updated the diff for D83342: [test-suite][AIX] Fix C++ benchmark compatibility issues on AIX.

Take a different path in the application to avoid using 'timezone'.

Jul 8 2020, 3:16 PM
stevewan added inline comments to D83342: [test-suite][AIX] Fix C++ benchmark compatibility issues on AIX.
Jul 8 2020, 2:43 PM
stevewan added a comment to D79842: [clang][Driver] Correct tool search path priority.

Right, I see the issue.

The code that gets the default triple name (https://reviews.llvm.org/D13340?id=36227#inline-108606) looks up the one you have in cmake, not the actual default which you get in --version. We could "fix" this by doing so when we make the tool name as well, but this breaks whatever mips toolchain was using that. (their tools won't be mips-unknown-elf-<whatever>)

So yes it looks up powerpc64le-linux-gnu but shows powerpc64le-unknown-linux-gnu. Can't go back to using cmake's value because on Mac OS, cmake has x86_64-darwin, clang has x86_64-darwin<version>. Writing to both is a short term option so I will try that and fold it into https://reviews.llvm.org/D83055. (will add you on review once I update it)

(this whole default triple lookup should probably go but I'd really like to do that in its own commit)

Jul 8 2020, 2:06 PM · Restricted Project
stevewan added inline comments to D83342: [test-suite][AIX] Fix C++ benchmark compatibility issues on AIX.
Jul 8 2020, 11:35 AM
stevewan added inline comments to D83342: [test-suite][AIX] Fix C++ benchmark compatibility issues on AIX.
Jul 8 2020, 11:05 AM

Jul 7 2020

stevewan added reviewers for D83342: [test-suite][AIX] Fix C++ benchmark compatibility issues on AIX: hubert.reinterpretcast, daltenty, ShuhongL.
Jul 7 2020, 1:15 PM
stevewan created D83342: [test-suite][AIX] Fix C++ benchmark compatibility issues on AIX.
Jul 7 2020, 1:14 PM
stevewan added a comment to D79842: [clang][Driver] Correct tool search path priority.

Yes, this issue was hit with the reland applied. When given a <arch>-<sys>-<abi> format LLVM_DEFAULT_TARGET_TRIPLE, Clang would expand the target triple to <arch>-<vendor>-<sys>-<abi>, and therefore causes the name mismatch between what the driver searches for and what the test case creates as the dummy tool.

Jul 7 2020, 11:02 AM · Restricted Project

Jul 6 2020

stevewan added a comment to D82321: [AIX] [test-suite] Enable standard compatable mode on AIX.

This is failing on Darwin. Looks like for the C++ test too, the flag should be added only if it is AIX.

MultiSource/Benchmarks/DOE-ProxyApps-C++/miniFE/mytimer.cpp:116:19: error: variable has incomplete type 'struct timezone'

Refer to http://green.lab.llvm.org/green/job/test-suite-verify-machineinstrs-aarch64-O0-g/7783/consoleFull.

Jul 6 2020, 5:11 PM
stevewan added a comment to D82321: [AIX] [test-suite] Enable standard compatable mode on AIX.

This is failing on Darwin. Looks like for the C++ test too, the flag should be added only if it is AIX.

MultiSource/Benchmarks/DOE-ProxyApps-C++/miniFE/mytimer.cpp:116:19: error: variable has incomplete type 'struct timezone'

Refer to http://green.lab.llvm.org/green/job/test-suite-verify-machineinstrs-aarch64-O0-g/7783/consoleFull.

Jul 6 2020, 2:23 PM
stevewan added a comment to D82321: [AIX] [test-suite] Enable standard compatable mode on AIX.

This is failing on Darwin. Looks like for the C++ test too, the flag should be added only if it is AIX.

MultiSource/Benchmarks/DOE-ProxyApps-C++/miniFE/mytimer.cpp:116:19: error: variable has incomplete type 'struct timezone'

Refer to http://green.lab.llvm.org/green/job/test-suite-verify-machineinstrs-aarch64-O0-g/7783/consoleFull.

Jul 6 2020, 1:32 PM
stevewan added a comment to D79842: [clang][Driver] Correct tool search path priority.

The test was failing on Linux if I set LLVM_DEFAULT_TARGET_TRIPLE. For example if I set it to`powerpc64le-linux-gnu` clang actually uses "powerpc64le-unknown-linux-gnu".

Jul 6 2020, 12:31 PM · Restricted Project

Jul 3 2020

stevewan accepted D82677: [Clang] Handle AIX Include management in the driver.

LGTM with minor nit.

Jul 3 2020, 11:52 AM · Restricted Project

Jun 26 2020

stevewan added inline comments to D82677: [Clang] Handle AIX Include management in the driver.
Jun 26 2020, 3:18 PM · Restricted Project
stevewan added inline comments to D82677: [Clang] Handle AIX Include management in the driver.
Jun 26 2020, 1:41 PM · Restricted Project

Jun 24 2020

stevewan closed D82321: [AIX] [test-suite] Enable standard compatable mode on AIX.

Committed in https://github.com/llvm/llvm-test-suite/commit/000c7b8d78b12b5cc70ad4e69a4cdb1bab23f74d.

Jun 24 2020, 5:24 PM
stevewan updated the diff for D82321: [AIX] [test-suite] Enable standard compatable mode on AIX.

Add comment based on review.

Jun 24 2020, 11:21 AM

Jun 22 2020

stevewan retitled D82321: [AIX] [test-suite] Enable standard compatable mode on AIX from [AIX] Enable standard compatable mode by default on AIX to [AIX] [test-suite] Enable standard compatable mode on AIX.
Jun 22 2020, 12:21 PM
stevewan updated the summary of D82321: [AIX] [test-suite] Enable standard compatable mode on AIX.
Jun 22 2020, 12:21 PM
stevewan created D82321: [AIX] [test-suite] Enable standard compatable mode on AIX.
Jun 22 2020, 11:49 AM

Jun 19 2020

stevewan closed D82052: Remove unsupported case "AtomicOps" from AIX test list..

Committed in https://github.com/llvm/llvm-test-suite/commit/e4c53876d55063d459790218958c0fe03f0c6e1b.

Jun 19 2020, 12:31 PM

Jun 18 2020

stevewan updated the summary of D82052: Remove unsupported case "AtomicOps" from AIX test list..
Jun 18 2020, 10:18 AM

Jun 17 2020

stevewan created D82052: Remove unsupported case "AtomicOps" from AIX test list..
Jun 17 2020, 1:29 PM
stevewan added reviewers for D82052: Remove unsupported case "AtomicOps" from AIX test list.: hubert.reinterpretcast, daltenty.
Jun 17 2020, 1:29 PM
stevewan updated the summary of D82052: Remove unsupported case "AtomicOps" from AIX test list..
Jun 17 2020, 1:29 PM

Jun 5 2020

stevewan committed rG61cd264068ee: [PowerPC] Do not special case Darwin on PowerPC in target cpu handling (authored by stevewan).
[PowerPC] Do not special case Darwin on PowerPC in target cpu handling
Jun 5 2020, 5:22 PM
stevewan closed D81115: [PowerPC] Do not special case Darwin on PowerPC in target cpu handling.
Jun 5 2020, 5:22 PM · Restricted Project
stevewan added a comment to D81115: [PowerPC] Do not special case Darwin on PowerPC in target cpu handling.

The unit test failure (instrprof-gcov-multithread_fork.test) in pre merge checks is caused by another commit. See http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2205.

Jun 5 2020, 5:21 PM · Restricted Project
stevewan added a comment to D80966: [codeview] Put !heapallocsite on calls to operator new.

Looks like this has broken the build bot? (see http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2205)

Jun 5 2020, 5:21 PM · Restricted Project

Jun 4 2020

stevewan updated the diff for D81115: [PowerPC] Do not special case Darwin on PowerPC in target cpu handling.

Reduce the nested 'if' and reorder it to prefer the more likely case.

Jun 4 2020, 2:23 PM · Restricted Project
stevewan retitled D81115: [PowerPC] Do not special case Darwin on PowerPC in target cpu handling from [PowerPC] Do not check for non-Darwin in PowerPC target cpu handling to [PowerPC] Do not special case Darwin on PowerPC in target cpu handling.
Jun 4 2020, 2:23 PM · Restricted Project

Jun 3 2020

stevewan added inline comments to D80835: [AIX] Change the default target CPU to power4 for AIX on Power.
Jun 3 2020, 1:11 PM · Restricted Project
stevewan added reviewers for D81115: [PowerPC] Do not special case Darwin on PowerPC in target cpu handling: hubert.reinterpretcast, daltenty.
Jun 3 2020, 1:11 PM · Restricted Project
stevewan created D81115: [PowerPC] Do not special case Darwin on PowerPC in target cpu handling.
Jun 3 2020, 1:11 PM · Restricted Project
stevewan committed rGba4afe6f7a84: [AIX] Change the default target CPU to power4 for AIX on Power (authored by stevewan).
[AIX] Change the default target CPU to power4 for AIX on Power
Jun 3 2020, 11:00 AM
stevewan closed D80835: [AIX] Change the default target CPU to power4 for AIX on Power.
Jun 3 2020, 10:59 AM · Restricted Project

May 29 2020

stevewan added reviewers for D80835: [AIX] Change the default target CPU to power4 for AIX on Power: hubert.reinterpretcast, cebowleratibm, daltenty.
May 29 2020, 1:06 PM · Restricted Project
stevewan created D80835: [AIX] Change the default target CPU to power4 for AIX on Power.
May 29 2020, 1:06 PM · Restricted Project

May 26 2020

stevewan committed rGa924dac44f31: [NFC] Fix formatting for the 'aix-ld.c' test case. (authored by stevewan).
[NFC] Fix formatting for the 'aix-ld.c' test case.
May 26 2020, 3:18 PM
stevewan closed D80532: [NFC] Fix formatting for the 'aix-ld.c' test case..
May 26 2020, 3:18 PM · Restricted Project
stevewan updated the diff for D80532: [NFC] Fix formatting for the 'aix-ld.c' test case..

Add the two-space indent before continuations on a pipeine.

May 26 2020, 10:49 AM · Restricted Project

May 25 2020

stevewan updated the diff for D80532: [NFC] Fix formatting for the 'aix-ld.c' test case..

Pass 'clang-format' checking.

May 25 2020, 3:01 PM · Restricted Project
stevewan updated the diff for D80532: [NFC] Fix formatting for the 'aix-ld.c' test case..

Fix misalignment caused by tab.

May 25 2020, 1:56 PM · Restricted Project
stevewan added reviewers for D80532: [NFC] Fix formatting for the 'aix-ld.c' test case.: ZarkoCA, hubert.reinterpretcast, daltenty.
May 25 2020, 1:24 PM · Restricted Project
stevewan created D80532: [NFC] Fix formatting for the 'aix-ld.c' test case..
May 25 2020, 1:24 PM · Restricted Project
stevewan updated the summary of D80532: [NFC] Fix formatting for the 'aix-ld.c' test case..
May 25 2020, 1:24 PM · Restricted Project
stevewan committed rG5bf2409a4e4d: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions (authored by stevewan).
[AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions
May 25 2020, 11:15 AM
stevewan closed D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions.
May 25 2020, 11:15 AM · Restricted Project