Page MenuHomePhabricator

stevewan (Steven Wan)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 26 2019, 10:57 AM (139 w, 1 d)

A hardwired bot that echos "LGTM".

Recent Activity

Wed, May 4

stevewan added inline comments to D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and .
Wed, May 4, 12:30 PM · Restricted Project, Restricted Project

Tue, May 3

stevewan accepted D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and .

LGTM other than some nits.

Tue, May 3, 10:06 AM · Restricted Project, Restricted Project
stevewan updated the summary of D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and .
Tue, May 3, 9:54 AM · Restricted Project, Restricted Project

Apr 27 2022

stevewan updated the summary of D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and .
Apr 27 2022, 12:05 PM · Restricted Project, Restricted Project

Apr 19 2022

stevewan added a comment to D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and .

I don't think the redirect files portion of this patch is well-described, could you please add it to the description?

Apr 19 2022, 10:59 AM · Restricted Project, Restricted Project

Feb 1 2022

stevewan committed rG245b8e5691ed: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX (authored by stevewan).
[NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX
Feb 1 2022, 8:50 AM
stevewan closed D118670: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX.
Feb 1 2022, 8:50 AM · Restricted Project
stevewan updated the diff for D118670: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX.

Add the flag to all

Feb 1 2022, 8:46 AM · Restricted Project
stevewan updated the summary of D118670: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX.
Feb 1 2022, 8:30 AM · Restricted Project
stevewan updated the diff for D118670: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX.

Use "-Wno-aix-compat" so that we don't lose coverage on AIX

Feb 1 2022, 8:29 AM · Restricted Project

Jan 31 2022

stevewan added reviewers for D118670: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX: ZarkoCA, daltenty, Jake-Egan, hubert.reinterpretcast, sfertile.
Jan 31 2022, 5:30 PM · Restricted Project
stevewan requested review of D118670: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX.
Jan 31 2022, 5:29 PM · Restricted Project
stevewan committed rTd52a93a891cd: Reland "Disable benchmarks that require _ALL_SOURCE on AIX" (authored by stevewan).
Reland "Disable benchmarks that require _ALL_SOURCE on AIX"
Jan 31 2022, 3:43 PM
stevewan updated the summary of D118660: [AIX][test-suite]Workaround other benchmarks affected by the _ALL_SOURCE issue on AIX.
Jan 31 2022, 3:18 PM
stevewan retitled D118660: [AIX][test-suite]Workaround other benchmarks affected by the _ALL_SOURCE issue on AIX from Workaround other benchmarks affected by the _ALL_SOURCE issue on AIX to [AIX][test-suite]Workaround other benchmarks affected by the _ALL_SOURCE issue on AIX.
Jan 31 2022, 3:18 PM
stevewan requested review of D118660: [AIX][test-suite]Workaround other benchmarks affected by the _ALL_SOURCE issue on AIX.
Jan 31 2022, 3:13 PM
stevewan added a reverting change for rT6cce747d7824: Disable benchmarks that require _ALL_SOURCE on AIX: rT220719ef572e: Revert "Disable benchmarks that require _ALL_SOURCE on AIX".
Jan 31 2022, 2:35 PM
stevewan committed rT220719ef572e: Revert "Disable benchmarks that require _ALL_SOURCE on AIX" (authored by stevewan).
Revert "Disable benchmarks that require _ALL_SOURCE on AIX"
Jan 31 2022, 2:35 PM
stevewan added a reverting change for D118639: Disable benchmarks that require _ALL_SOURCE on AIX: rT220719ef572e: Revert "Disable benchmarks that require _ALL_SOURCE on AIX".
Jan 31 2022, 2:35 PM
stevewan committed rT6cce747d7824: Disable benchmarks that require _ALL_SOURCE on AIX (authored by stevewan).
Disable benchmarks that require _ALL_SOURCE on AIX
Jan 31 2022, 1:21 PM
stevewan closed D118639: Disable benchmarks that require _ALL_SOURCE on AIX.
Jan 31 2022, 1:21 PM
stevewan added inline comments to D118639: Disable benchmarks that require _ALL_SOURCE on AIX.
Jan 31 2022, 12:54 PM
stevewan updated the diff for D118639: Disable benchmarks that require _ALL_SOURCE on AIX.

DeMorganize conditions and quote expansions per review comments

Jan 31 2022, 12:50 PM
stevewan closed D118622: Workaround _ALL_SOURCE issue on AIX.
Jan 31 2022, 12:35 PM
stevewan committed rT506c8f9b18ef: Workaround _ALL_SOURCE issue on AIX (authored by stevewan).
Workaround _ALL_SOURCE issue on AIX
Jan 31 2022, 12:35 PM
stevewan updated the diff for D118622: Workaround _ALL_SOURCE issue on AIX.

Address comments regarding assessing macro value

Jan 31 2022, 12:30 PM
stevewan updated the summary of D118639: Disable benchmarks that require _ALL_SOURCE on AIX.
Jan 31 2022, 11:48 AM
stevewan requested review of D118639: Disable benchmarks that require _ALL_SOURCE on AIX.
Jan 31 2022, 11:46 AM
stevewan added reviewers for D118622: Workaround _ALL_SOURCE issue on AIX: daltenty, amyk, hubert.reinterpretcast.
Jan 31 2022, 8:51 AM
stevewan requested review of D118622: Workaround _ALL_SOURCE issue on AIX.
Jan 31 2022, 8:51 AM

Jan 28 2022

stevewan committed rG760e69223d83: [NFC][AIX]Disable new pcm tests on AIX (authored by stevewan).
[NFC][AIX]Disable new pcm tests on AIX
Jan 28 2022, 9:39 AM
stevewan closed D118477: [NFC][AIX]Disable new pcm tests on AIX.
Jan 28 2022, 9:39 AM · Restricted Project
stevewan added a comment to D118474: [NFC][AIX][clang] un-XFAIL gcc profile flag compat test.

Extra coverage for LTO doesn't hurt. LGTM. Thanks.

Jan 28 2022, 8:05 AM · Restricted Project
stevewan added reviewers for D118477: [NFC][AIX]Disable new pcm tests on AIX: Jake-Egan, daltenty, sfertile.
Jan 28 2022, 7:56 AM · Restricted Project
stevewan requested review of D118477: [NFC][AIX]Disable new pcm tests on AIX.
Jan 28 2022, 7:55 AM · Restricted Project

Jan 27 2022

stevewan added inline comments to D118152: [clang][deps] Adapt test to be compatible when the assembler is called by default.
Jan 27 2022, 11:49 AM · Restricted Project
stevewan accepted D118310: [compiler-rt][profile][AIX] pass export list for test with shared library.

get_filename_from_DSO is the only symbol to be exported from the shared obj. LGTM. Thanks.

Jan 27 2022, 11:24 AM · Restricted Project

Jan 25 2022

stevewan committed rG575c5d2a99ea: Disable Go binding test on AIX (authored by stevewan).
Disable Go binding test on AIX
Jan 25 2022, 9:39 AM
stevewan closed D117505: Disable Go binding test on AIX.
Jan 25 2022, 9:39 AM · Restricted Project

Jan 17 2022

stevewan added reviewers for D117505: Disable Go binding test on AIX: daltenty, ZarkoCA.
Jan 17 2022, 10:23 AM · Restricted Project
stevewan requested review of D117505: Disable Go binding test on AIX.
Jan 17 2022, 10:23 AM · Restricted Project

Jan 6 2022

stevewan added a comment to D115349: [analyzer][NFC] Re-enable skipped SValTests by relaxing expectations.

Thanks @steakhal for the clarification. Yes my question is answered.

Jan 6 2022, 8:17 AM · Restricted Project

Jan 5 2022

stevewan accepted D115349: [analyzer][NFC] Re-enable skipped SValTests by relaxing expectations.

As emphasized in the description, we can't get the exact type of the SVal, and I agree that checking for the same signedness and bitwidth is our best bet. LGTM given that my question is addressed. Thanks.

Jan 5 2022, 10:55 AM · Restricted Project
stevewan added inline comments to D115349: [analyzer][NFC] Re-enable skipped SValTests by relaxing expectations.
Jan 5 2022, 10:50 AM · Restricted Project

Dec 2 2021

stevewan committed rG9c4d194f44c4: [analyzer]Skip unstable CSA tests failing on several platforms (authored by stevewan).
[analyzer]Skip unstable CSA tests failing on several platforms
Dec 2 2021, 3:31 PM
stevewan closed D114454: [analyzer]Skip unstable CSA tests failing on several platforms.
Dec 2 2021, 3:30 PM · Restricted Project
stevewan retitled D114454: [analyzer]Skip unstable CSA tests failing on several platforms from [CSA]Skip unstable CSA tests failing on several platforms to [analyzer]Skip unstable CSA tests failing on several platforms.
Dec 2 2021, 3:28 PM · Restricted Project
stevewan updated the summary of D114454: [analyzer]Skip unstable CSA tests failing on several platforms.
Dec 2 2021, 12:31 PM · Restricted Project
stevewan retitled D114454: [analyzer]Skip unstable CSA tests failing on several platforms from [NFC][AIX]Disable unstable CSA tests failing on AIX to [CSA]Skip unstable CSA tests failing on several platforms.
Dec 2 2021, 12:27 PM · Restricted Project

Dec 1 2021

stevewan added a reverting change for rGbf18253b0ee5: [sanitizer] Add compress_stack_depot flag: rGf9d585d0dd57: Revert "[sanitizer] Add compress_stack_depot flag".
Dec 1 2021, 5:23 PM
stevewan committed rGf9d585d0dd57: Revert "[sanitizer] Add compress_stack_depot flag" (authored by stevewan).
Revert "[sanitizer] Add compress_stack_depot flag"
Dec 1 2021, 5:23 PM
stevewan added a reverting change for D114495: [sanitizer] Add compress_stack_depot flag: rGf9d585d0dd57: Revert "[sanitizer] Add compress_stack_depot flag".
Dec 1 2021, 5:23 PM · Restricted Project
stevewan added a comment to D114454: [analyzer]Skip unstable CSA tests failing on several platforms.

but we could pick a couple of esoteric targets where integrals differ significantly from what we have on x86_64

Dec 1 2021, 1:14 PM · Restricted Project
stevewan updated the diff for D114454: [analyzer]Skip unstable CSA tests failing on several platforms.

Add targets we are interested in testing

Dec 1 2021, 1:11 PM · Restricted Project
stevewan added a comment to D114495: [sanitizer] Add compress_stack_depot flag.

This is failing on clang-s390x-linux, https://lab.llvm.org/buildbot/#/builders/94/builds/6748, can you please take a look?

Dec 1 2021, 1:04 PM · Restricted Project

Nov 30 2021

stevewan added a comment to D114454: [analyzer]Skip unstable CSA tests failing on several platforms.

Finally had some time to get back to this. Thanks @steakhal for your suggestion, the sample code in ASTMatchersNodeTest.cpp was helpful. I was actually looking for a good way of querying the target triple as I do agree that it is an better way of fixing this. Hopefully I understood what you had suggested correctly.

Nov 30 2021, 1:17 PM · Restricted Project
stevewan updated the diff for D114454: [analyzer]Skip unstable CSA tests failing on several platforms.

Pin target triple before analysis

Nov 30 2021, 12:52 PM · Restricted Project

Nov 29 2021

stevewan committed rG3c32c568844c: [NFC][clang]Increase the number of driver diagnostics (authored by stevewan).
[NFC][clang]Increase the number of driver diagnostics
Nov 29 2021, 11:12 AM
stevewan closed D114615: [NFC][clang]Increase the number of driver diagnostics.
Nov 29 2021, 11:12 AM · Restricted Project
stevewan committed rG23dc88622630: [NFC][AIX]Disable unsupported hip test on AIX (authored by stevewan).
[NFC][AIX]Disable unsupported hip test on AIX
Nov 29 2021, 10:26 AM
stevewan closed D114484: [NFC][AIX]Disable unsupported hip test on AIX.
Nov 29 2021, 10:26 AM · Restricted Project

Nov 25 2021

stevewan retitled D114615: [NFC][clang]Increase the number of driver diagnostics from Increase the number of driver diagnostics to [NFC][clang]Increase the number of driver diagnostics.
Nov 25 2021, 3:53 PM · Restricted Project
stevewan requested review of D114615: [NFC][clang]Increase the number of driver diagnostics.
Nov 25 2021, 3:49 PM · Restricted Project

Nov 24 2021

stevewan committed rG06d4a76309cd: [NFC][AIX]Disable precompiled module file tests on AIX (authored by stevewan).
[NFC][AIX]Disable precompiled module file tests on AIX
Nov 24 2021, 10:23 AM
stevewan closed D114481: [NFC][AIX]Disable precompiled module file tests on AIX.
Nov 24 2021, 10:22 AM · Restricted Project
stevewan updated the diff for D114481: [NFC][AIX]Disable precompiled module file tests on AIX.

Explain the rationale

Nov 24 2021, 10:21 AM · Restricted Project

Nov 23 2021

stevewan added reviewers for D114484: [NFC][AIX]Disable unsupported hip test on AIX: daltenty, Jake-Egan.
Nov 23 2021, 3:08 PM · Restricted Project
stevewan requested review of D114484: [NFC][AIX]Disable unsupported hip test on AIX.
Nov 23 2021, 3:08 PM · Restricted Project
stevewan added reviewers for D114481: [NFC][AIX]Disable precompiled module file tests on AIX: Jake-Egan, daltenty, xingxue.
Nov 23 2021, 2:58 PM · Restricted Project
stevewan requested review of D114481: [NFC][AIX]Disable precompiled module file tests on AIX.
Nov 23 2021, 2:57 PM · Restricted Project
stevewan added reviewers for D114454: [analyzer]Skip unstable CSA tests failing on several platforms: daltenty, xingxue.
Nov 23 2021, 1:23 PM · Restricted Project
stevewan planned changes to D114454: [analyzer]Skip unstable CSA tests failing on several platforms.
Nov 23 2021, 1:21 PM · Restricted Project
stevewan updated the summary of D114454: [analyzer]Skip unstable CSA tests failing on several platforms.
Nov 23 2021, 9:50 AM · Restricted Project
stevewan requested review of D114454: [analyzer]Skip unstable CSA tests failing on several platforms.
Nov 23 2021, 9:44 AM · Restricted Project

Nov 22 2021

stevewan accepted D114381: [AIX] Disable unsupported offloading gpu tests.
Nov 22 2021, 4:22 PM · Restricted Project
stevewan added a comment to D114381: [AIX] Disable unsupported offloading gpu tests.

LGTM. Thanks.

Nov 22 2021, 4:22 PM · Restricted Project
stevewan added a comment to D114110: [AIX] Bump DWARF versions to 3 because XCOFF64 requires DWARF64.

Dumb question, where is the dwarf version specified?

Nov 22 2021, 4:21 PM · Restricted Project
stevewan added a comment to D112603: tsan: new runtime (v3).

Hi, it seems that this is causing failures on ppc64le-rhel, https://lab.llvm.org/buildbot/#/builders/57/builds/12365.

Nov 22 2021, 8:54 AM · Restricted Project

Nov 18 2021

stevewan added a comment to D104550: [analyzer] Implement getType for SVal.

@vsavchenko One of the added tests is failing on our 32 bit Armv7 Thumb bot: https://lab.llvm.org/buildbot/#/builders/170/builds/61

/home/tcwg-buildslave/worker/clang-thumbv7-full-2stage/llvm/clang/unittests/StaticAnalyzer/SValTest.cpp:169: Failure
Expected equality of these values:
  Context.UnsignedLongTy
    Which is: unsigned long
  A.getType(Context)
    Which is: unsigned int
[  FAILED  ] SValTest.GetLocAsIntType (22 ms)
[----------] 1 test from SValTest (22 ms total)

A 32/64 bit issue?

Hi @DavidSpickett , thanks for looking into this!
This patch was almost instantly followed by https://github.com/llvm/llvm-project/commit/b2842298cebf420ecb3750bf309021a7f37870c1 which fixed the issue. Please, let me know, if you still see it after that commit!

Sorry for posting to this slightly aged thread. I'm seeing a similar error of this on 32 bit AIX PPC, where getUIntPtrType() returns unsigned long, so the aforementioned follow-on patch no longer applies. The results from getIntTypeForBitwidth() seem unreliable in certain cases (e.g. int vs long in ILP32), and I couldn't think of a good way around it. Have you had any future plans on mitigating such problems?

Hi there, what is the exact target triple?
I wonder if it would be possible to create a new unit test case where we pass somehow the target triple to runCheckerOnCode?

Nov 18 2021, 9:28 AM · Restricted Project

Nov 17 2021

stevewan added a comment to D104550: [analyzer] Implement getType for SVal.

@vsavchenko One of the added tests is failing on our 32 bit Armv7 Thumb bot: https://lab.llvm.org/buildbot/#/builders/170/builds/61

/home/tcwg-buildslave/worker/clang-thumbv7-full-2stage/llvm/clang/unittests/StaticAnalyzer/SValTest.cpp:169: Failure
Expected equality of these values:
  Context.UnsignedLongTy
    Which is: unsigned long
  A.getType(Context)
    Which is: unsigned int
[  FAILED  ] SValTest.GetLocAsIntType (22 ms)
[----------] 1 test from SValTest (22 ms total)

A 32/64 bit issue?

Hi @DavidSpickett , thanks for looking into this!
This patch was almost instantly followed by https://github.com/llvm/llvm-project/commit/b2842298cebf420ecb3750bf309021a7f37870c1 which fixed the issue. Please, let me know, if you still see it after that commit!

Nov 17 2021, 7:48 PM · Restricted Project

Nov 15 2021

stevewan committed rG351870720fcb: [AIX][llvm-go] AIX linker does not recognize `-rpath` (authored by stevewan).
[AIX][llvm-go] AIX linker does not recognize `-rpath`
Nov 15 2021, 10:13 AM
stevewan closed D113704: [AIX][llvm-go] AIX linker does not recognize `-rpath`.
Nov 15 2021, 10:13 AM · Restricted Project
stevewan updated the diff for D113704: [AIX][llvm-go] AIX linker does not recognize `-rpath`.

Fix formatting

Nov 15 2021, 10:10 AM · Restricted Project
stevewan updated the diff for D113704: [AIX][llvm-go] AIX linker does not recognize `-rpath`.

Flatten nested if

Nov 15 2021, 9:56 AM · Restricted Project

Nov 11 2021

stevewan added reviewers for D113704: [AIX][llvm-go] AIX linker does not recognize `-rpath`: hubert.reinterpretcast, daltenty.
Nov 11 2021, 11:43 AM · Restricted Project
stevewan requested review of D113704: [AIX][llvm-go] AIX linker does not recognize `-rpath`.
Nov 11 2021, 11:43 AM · Restricted Project
stevewan committed rG42102bce98e5: [AIX][NFC] Disable clang-repl tests failing due to lack of 64-bit XCOFF support. (authored by stevewan).
[AIX][NFC] Disable clang-repl tests failing due to lack of 64-bit XCOFF support.
Nov 11 2021, 11:11 AM
stevewan closed D113614: [AIX][NFC] Disable clang-repl tests failing due to lack of 64-bit XCOFF support..
Nov 11 2021, 11:11 AM · Restricted Project
stevewan retitled D113614: [AIX][NFC] Disable clang-repl tests failing due to lack of 64-bit XCOFF support. from Disable clang-repl tests failing due to lack of 64-bit XCOFF support. to [AIX][NFC] Disable clang-repl tests failing due to lack of 64-bit XCOFF support..
Nov 11 2021, 11:09 AM · Restricted Project

Nov 10 2021

stevewan updated the summary of D113614: [AIX][NFC] Disable clang-repl tests failing due to lack of 64-bit XCOFF support..
Nov 10 2021, 2:18 PM · Restricted Project
stevewan requested review of D113614: [AIX][NFC] Disable clang-repl tests failing due to lack of 64-bit XCOFF support..
Nov 10 2021, 2:16 PM · Restricted Project

Oct 29 2021

stevewan committed rG57cb84f5a232: Point replay file to non-existent dummy (authored by stevewan).
Point replay file to non-existent dummy
Oct 29 2021, 8:59 AM
stevewan closed D112745: Point replay file to non-existent dummy.
Oct 29 2021, 8:58 AM · Restricted Project

Oct 28 2021

stevewan added a comment to D112745: Point replay file to non-existent dummy.

Thanks, I'll make sure to avoid pointing at directories to validate these things in the future.

Oct 28 2021, 12:44 PM · Restricted Project
stevewan updated the summary of D112745: Point replay file to non-existent dummy.
Oct 28 2021, 12:13 PM · Restricted Project
stevewan requested review of D112745: Point replay file to non-existent dummy.
Oct 28 2021, 12:10 PM · Restricted Project

Oct 22 2021

stevewan committed rG28ef8052d228: [AIX] Enable rtl for plugins test (authored by stevewan).
[AIX] Enable rtl for plugins test
Oct 22 2021, 9:09 AM
stevewan closed D112275: [AIX] Enable rtl for plugins test.
Oct 22 2021, 9:08 AM · Restricted Project

Oct 21 2021

stevewan added a reviewer for D112275: [AIX] Enable rtl for plugins test: daltenty.
Oct 21 2021, 3:12 PM · Restricted Project
stevewan requested review of D112275: [AIX] Enable rtl for plugins test.
Oct 21 2021, 3:12 PM · Restricted Project