This is an archive of the discontinued LLVM Phabricator instance.

[ValueTypes] Define MVTs for v3i64/v3f64 to complement v6i32/v6f32
ClosedPublic

Authored by critson on Jun 21 2021, 1:13 AM.

Details

Summary

Having type symmetry with these is somewhat necessary when implementing support for 192-bit values.

Diff Detail

Event Timeline

critson created this revision.Jun 21 2021, 1:13 AM
critson requested review of this revision.Jun 21 2021, 1:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 21 2021, 1:13 AM
craig.topper added inline comments.Jun 22 2021, 3:06 PM
llvm/include/llvm/Support/MachineValueType.h
967

Aren't these usuallly sorted by integer/FP and then by increasing element size? So it should be v6i32, v3i64, v6f32, v3f64 I think.

critson updated this revision to Diff 353834.Jun 22 2021, 5:59 PM
critson marked an inline comment as done.
  • Address reviewer comments.
llvm/include/llvm/Support/MachineValueType.h
967

Agreed, that does seem to be the pattern.

This revision is now accepted and ready to land.Jun 22 2021, 6:58 PM
This revision was landed with ongoing or failed builds.Jun 23 2021, 8:41 PM
This revision was automatically updated to reflect the committed changes.