Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
The change looks fine to me, just have a nit for the test.
llvm/test/CodeGen/AArch64/sve-trunc.ll | ||
---|---|---|
196 | nit: instead of using undef, can you add an extra argument to the function, i16 * %ptr? That way the test is more stable, since it always has to use x0 because of the ABI rules on parameter passing. For undef, the compiler is free to choose any value/register. |
Comment Actions
Yes for both llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp and llvm/test/CodeGen/AArch64/sve-trunc.ll.
nit: instead of using undef, can you add an extra argument to the function, i16 * %ptr? That way the test is more stable, since it always has to use x0 because of the ABI rules on parameter passing. For undef, the compiler is free to choose any value/register.