Page MenuHomePhabricator

[SVE] Fix PromoteIntRes_TRUNCATE not to call getVectorNumElements
ClosedPublic

Authored by DylanFleming-arm on Jun 11 2021, 6:06 AM.

Diff Detail

Event Timeline

DylanFleming-arm requested review of this revision.Jun 11 2021, 6:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 11 2021, 6:06 AM

The change looks fine to me, just have a nit for the test.

llvm/test/CodeGen/AArch64/sve-trunc.ll
196

nit: instead of using undef, can you add an extra argument to the function, i16 * %ptr? That way the test is more stable, since it always has to use x0 because of the ABI rules on parameter passing. For undef, the compiler is free to choose any value/register.

Matt added a subscriber: Matt.Jun 11 2021, 12:31 PM
This revision is now accepted and ready to land.Jun 14 2021, 7:08 AM

Hey, is anyone else seeing:
Context not available.
In the files?

Matt added a comment.Jun 15 2021, 6:55 AM

Hey, is anyone else seeing:
Context not available.
In the files?

Yes for both llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp and llvm/test/CodeGen/AArch64/sve-trunc.ll.

DylanFleming-arm marked an inline comment as done.
This revision was landed with ongoing or failed builds.Jun 16 2021, 5:11 AM
This revision was automatically updated to reflect the committed changes.