Page MenuHomePhabricator

DylanFleming-arm (Dylan Fleming)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 11 2021, 5:40 AM (7 w, 5 d)

Recent Activity

Today

DylanFleming-arm updated the diff for D107453: [SVE] Add folds for truncation of vscale.

Added check for MaxVScale > 0

Wed, Aug 4, 7:52 AM · Restricted Project
DylanFleming-arm added reviewers for D107453: [SVE] Add folds for truncation of vscale: sdesmalen, david-arm.
Wed, Aug 4, 5:51 AM · Restricted Project
DylanFleming-arm requested review of D107453: [SVE] Add folds for truncation of vscale.
Wed, Aug 4, 5:49 AM · Restricted Project

Yesterday

DylanFleming-arm committed rG3943a74666cb: [InstCombine] Fixed select + masked load fold failure (authored by DylanFleming-arm).
[InstCombine] Fixed select + masked load fold failure
Tue, Aug 3, 11:07 AM
DylanFleming-arm closed D107372: [InstCombine] Fixed select + masked load fold failure.
Tue, Aug 3, 11:07 AM · Restricted Project
DylanFleming-arm added a comment to D107372: [InstCombine] Fixed select + masked load fold failure.

Yeah, I think it definitely makes sense to have it put into the LLVM13 release

Tue, Aug 3, 10:38 AM · Restricted Project
DylanFleming-arm added reviewers for D107372: [InstCombine] Fixed select + masked load fold failure: sdesmalen, srj, ebrevnov.
Tue, Aug 3, 10:06 AM · Restricted Project
DylanFleming-arm requested review of D107372: [InstCombine] Fixed select + masked load fold failure.
Tue, Aug 3, 10:01 AM · Restricted Project
DylanFleming-arm added a comment to D106376: [SVE] Add support for folding for select + masked loads.

I'm looking into it now, hopefully I'll have a fix for it soon.

Tue, Aug 3, 4:07 AM · Restricted Project

Mon, Aug 2

DylanFleming-arm added a comment to D106376: [SVE] Add support for folding for select + masked loads.

I did recently encounter a bug from binop matching here https://reviews.llvm.org/D105978 I don't think these cases are related, but it might be worth having a quick check just to rule it out for definite?

Mon, Aug 2, 4:55 PM · Restricted Project

Fri, Jul 30

DylanFleming-arm committed rGa7a39ec886a0: [SVE] Add folds for sign and zero extends of vscale (authored by DylanFleming-arm).
[SVE] Add folds for sign and zero extends of vscale
Fri, Jul 30, 8:04 AM
DylanFleming-arm closed D105994: [SVE] Add folds for sign and zero extends of vscale.
Fri, Jul 30, 8:03 AM · Restricted Project

Tue, Jul 27

DylanFleming-arm updated the diff for D106277: [SVE] Remove the interface for getMaxVScale in favour of the IR attributes.

Rebased onto main, updated newly added AArch64 getMaxVScale usages to use IR attribute instead

Tue, Jul 27, 7:08 AM · Restricted Project, Restricted Project

Mon, Jul 26

DylanFleming-arm updated the diff for D105994: [SVE] Add folds for sign and zero extends of vscale.

Changed bitshift to Log2_32

Mon, Jul 26, 9:37 AM · Restricted Project
DylanFleming-arm updated the diff for D106277: [SVE] Remove the interface for getMaxVScale in favour of the IR attributes.

Added getVScaleRange interface to TargetInfo and removed related AArch64 specific code from CodeGenFunction.cpp

Mon, Jul 26, 8:35 AM · Restricted Project, Restricted Project
DylanFleming-arm committed rG20b0fa91c9ee: [SVE] Add support for folding for select + masked loads (authored by DylanFleming-arm).
[SVE] Add support for folding for select + masked loads
Mon, Jul 26, 3:59 AM
DylanFleming-arm closed D106376: [SVE] Add support for folding for select + masked loads.
Mon, Jul 26, 3:59 AM · Restricted Project

Fri, Jul 23

DylanFleming-arm updated the diff for D106376: [SVE] Add support for folding for select + masked loads.

I forgot to check this patch with all targets before putting it for review
Two none AARch64 tests were affected, I've updated them to work now and the output seems to be as expected

Fri, Jul 23, 9:47 AM · Restricted Project
DylanFleming-arm committed rG80e0bd149661: [SVE][IR] Fix Binary op matching in PatternMatch::m_VScale (authored by DylanFleming-arm).
[SVE][IR] Fix Binary op matching in PatternMatch::m_VScale
Fri, Jul 23, 3:40 AM
DylanFleming-arm closed D105978: [SVE][IR] Fix Binary op matching in PatternMatch::m_VScale.
Fri, Jul 23, 3:40 AM · Restricted Project

Thu, Jul 22

DylanFleming-arm updated the diff for D106277: [SVE] Remove the interface for getMaxVScale in favour of the IR attributes.

Removed changes to RiscV code
Added check that target isAArch64 before adding default value vscale_range attribute

Thu, Jul 22, 10:44 AM · Restricted Project, Restricted Project
DylanFleming-arm updated the diff for D106376: [SVE] Add support for folding for select + masked loads.

Fixed lint issues
Added comment stating that not checking for one use is intentional

Thu, Jul 22, 6:39 AM · Restricted Project

Wed, Jul 21

DylanFleming-arm updated the diff for D105994: [SVE] Add folds for sign and zero extends of vscale.

Added check for vscale_range attribute before optimisation
If the attribute isn't present, or if the maximum value exceeds the bitwidth of the original instrinsic, the optimization is skipped

Wed, Jul 21, 11:59 AM · Restricted Project
DylanFleming-arm updated the summary of D106376: [SVE] Add support for folding for select + masked loads.
Wed, Jul 21, 3:33 AM · Restricted Project

Tue, Jul 20

DylanFleming-arm added reviewers for D106376: [SVE] Add support for folding for select + masked loads: sdesmalen, david-arm.
Tue, Jul 20, 9:21 AM · Restricted Project
DylanFleming-arm requested review of D106376: [SVE] Add support for folding for select + masked loads.
Tue, Jul 20, 9:20 AM · Restricted Project

Mon, Jul 19

DylanFleming-arm retitled D106277: [SVE] Remove the interface for getMaxVScale in favour of the IR attributes from [SVE] Remove the interface for in favour of the IR attributes to [SVE] Remove the interface for getMaxVScale in favour of the IR attributes.
Mon, Jul 19, 7:30 AM · Restricted Project, Restricted Project
DylanFleming-arm added reviewers for D106277: [SVE] Remove the interface for getMaxVScale in favour of the IR attributes: sdesmalen, bsmith.
Mon, Jul 19, 7:28 AM · Restricted Project, Restricted Project
DylanFleming-arm requested review of D106277: [SVE] Remove the interface for getMaxVScale in favour of the IR attributes.
Mon, Jul 19, 7:26 AM · Restricted Project, Restricted Project
DylanFleming-arm abandoned D105119: [SVE] Fix incorrect codegen when inserting vector elements into widened scalable vectors.
Mon, Jul 19, 2:04 AM · Restricted Project

Thu, Jul 15

DylanFleming-arm added a comment to D105994: [SVE] Add folds for sign and zero extends of vscale.

There's instances where max-vscale won't be known at compile time, but this route should allow for the optimizations wherever possible.

Thu, Jul 15, 1:48 PM · Restricted Project
DylanFleming-arm added a comment to D105994: [SVE] Add folds for sign and zero extends of vscale.

We could use the max-vscale attribute to determine if the runtime value fits the type. If this cannot be determined, the optimization would be skipped, otherwise we change the type of llvm.vscale to the extended type.
Would that be a suitable approach?

Thu, Jul 15, 9:45 AM · Restricted Project

Wed, Jul 14

DylanFleming-arm updated the diff for D105978: [SVE][IR] Fix Binary op matching in PatternMatch::m_VScale.

Restructured if statment

Wed, Jul 14, 9:39 AM · Restricted Project
DylanFleming-arm added reviewers for D105994: [SVE] Add folds for sign and zero extends of vscale: sdesmalen, david-arm.
Wed, Jul 14, 8:51 AM · Restricted Project
DylanFleming-arm requested review of D105994: [SVE] Add folds for sign and zero extends of vscale.
Wed, Jul 14, 8:50 AM · Restricted Project
DylanFleming-arm retitled D105978: [SVE][IR] Fix Binary op matching in PatternMatch::m_VScale from [IR] Fix Binary op matching in PatternMatch::m_VScale to [SVE][IR] Fix Binary op matching in PatternMatch::m_VScale.
Wed, Jul 14, 6:49 AM · Restricted Project
DylanFleming-arm requested review of D105978: [SVE][IR] Fix Binary op matching in PatternMatch::m_VScale.
Wed, Jul 14, 6:47 AM · Restricted Project

Wed, Jul 7

DylanFleming-arm committed rG7215dcfe3688: [SVE] Fix ShuffleVector cast<FixedVectorType> in truncateToMinimalBitwidths (authored by DylanFleming-arm).
[SVE] Fix ShuffleVector cast<FixedVectorType> in truncateToMinimalBitwidths
Wed, Jul 7, 7:31 AM
DylanFleming-arm closed D105341: [SVE] Fix ShuffleVector cast<FixedVectorType> in truncateToMinimalBitwidths.
Wed, Jul 7, 7:30 AM · Restricted Project
DylanFleming-arm committed rG8ae9ab43dd9e: [SVE] Fixed cast<FixedVectorType> on scalable vector in SelectionDAGBuilder… (authored by DylanFleming-arm).
[SVE] Fixed cast<FixedVectorType> on scalable vector in SelectionDAGBuilder…
Wed, Jul 7, 2:50 AM
DylanFleming-arm closed D105350: [SVE] Fixed cast<FixedVectorType> on scalable vector in SelectionDAGBuilder::getUniformBase.
Wed, Jul 7, 2:49 AM · Restricted Project
DylanFleming-arm committed rG7586b47fb63d: [SVE] Fix cast<FixedVectorType> in truncateToMinimalBitwidths (authored by DylanFleming-arm).
[SVE] Fix cast<FixedVectorType> in truncateToMinimalBitwidths
Wed, Jul 7, 2:00 AM
DylanFleming-arm closed D104239: [SVE] Fix cast<FixedVectorType> in truncateToMinimalBitwidths.
Wed, Jul 7, 2:00 AM · Restricted Project

Tue, Jul 6

DylanFleming-arm updated the diff for D105341: [SVE] Fix ShuffleVector cast<FixedVectorType> in truncateToMinimalBitwidths.

Removed excess LLVMIR from test

Tue, Jul 6, 1:52 AM · Restricted Project

Jul 5 2021

DylanFleming-arm updated the diff for D104239: [SVE] Fix cast<FixedVectorType> in truncateToMinimalBitwidths.

Updated parameter names to make more sense
Made i16* %hptr into noalias

Jul 5 2021, 6:14 AM · Restricted Project
DylanFleming-arm updated the diff for D105350: [SVE] Fixed cast<FixedVectorType> on scalable vector in SelectionDAGBuilder::getUniformBase.

Renamed test function
Cleaned up control flow

Jul 5 2021, 6:01 AM · Restricted Project
DylanFleming-arm updated the diff for D105341: [SVE] Fix ShuffleVector cast<FixedVectorType> in truncateToMinimalBitwidths.

Cleaned up CHECK lines
Added autogenerated line

Jul 5 2021, 4:42 AM · Restricted Project

Jul 2 2021

DylanFleming-arm added reviewers for D105350: [SVE] Fixed cast<FixedVectorType> on scalable vector in SelectionDAGBuilder::getUniformBase: sdesmalen, craig.topper.
Jul 2 2021, 7:58 AM · Restricted Project
DylanFleming-arm requested review of D105350: [SVE] Fixed cast<FixedVectorType> on scalable vector in SelectionDAGBuilder::getUniformBase.
Jul 2 2021, 7:54 AM · Restricted Project
DylanFleming-arm added reviewers for D105341: [SVE] Fix ShuffleVector cast<FixedVectorType> in truncateToMinimalBitwidths: david-arm, sdesmalen.
Jul 2 2021, 3:39 AM · Restricted Project
DylanFleming-arm requested review of D105341: [SVE] Fix ShuffleVector cast<FixedVectorType> in truncateToMinimalBitwidths.
Jul 2 2021, 3:35 AM · Restricted Project

Jul 1 2021

DylanFleming-arm updated the diff for D105119: [SVE] Fix incorrect codegen when inserting vector elements into widened scalable vectors.

Removed unneeded parentheses
Changed index type to be variable based on the target system

Jul 1 2021, 5:22 AM · Restricted Project
DylanFleming-arm updated the diff for D104239: [SVE] Fix cast<FixedVectorType> in truncateToMinimalBitwidths.

Fixed issue where loop wasn't correctly vectorized with scalable vectors

Jul 1 2021, 4:22 AM · Restricted Project

Jun 30 2021

DylanFleming-arm updated the diff for D105119: [SVE] Fix incorrect codegen when inserting vector elements into widened scalable vectors.

Added asserts to check scalable vectors are valid
Reordered control flow to be cleaner

Jun 30 2021, 7:51 AM · Restricted Project

Jun 29 2021

DylanFleming-arm added a reviewer for D105119: [SVE] Fix incorrect codegen when inserting vector elements into widened scalable vectors: david-arm.
Jun 29 2021, 7:41 AM · Restricted Project
DylanFleming-arm added reviewers for D105119: [SVE] Fix incorrect codegen when inserting vector elements into widened scalable vectors: sdesmalen, delena.
Jun 29 2021, 7:34 AM · Restricted Project
DylanFleming-arm requested review of D105119: [SVE] Fix incorrect codegen when inserting vector elements into widened scalable vectors.
Jun 29 2021, 7:31 AM · Restricted Project
DylanFleming-arm committed rGc3d3defd11a7: [SVE] Added CodeGen support for inserting an element into a predicate vector (authored by DylanFleming-arm).
[SVE] Added CodeGen support for inserting an element into a predicate vector
Jun 29 2021, 6:57 AM
DylanFleming-arm closed D104722: [SVE] Added CodeGen support for inserting an element into a predicate vector.
Jun 29 2021, 6:57 AM · Restricted Project

Jun 25 2021

DylanFleming-arm updated the diff for D104239: [SVE] Fix cast<FixedVectorType> in truncateToMinimalBitwidths.
Jun 25 2021, 9:22 AM · Restricted Project
DylanFleming-arm updated the diff for D104239: [SVE] Fix cast<FixedVectorType> in truncateToMinimalBitwidths.
Jun 25 2021, 8:30 AM · Restricted Project
DylanFleming-arm updated the diff for D104722: [SVE] Added CodeGen support for inserting an element into a predicate vector.

Corrected code formatting

Jun 25 2021, 8:15 AM · Restricted Project
DylanFleming-arm updated the diff for D104722: [SVE] Added CodeGen support for inserting an element into a predicate vector.

Changed logic for deciding ExtendValue's size

Jun 25 2021, 7:08 AM · Restricted Project

Jun 24 2021

DylanFleming-arm updated the diff for D104722: [SVE] Added CodeGen support for inserting an element into a predicate vector.

Added extra test cases for constant index/insert values

Jun 24 2021, 4:59 AM · Restricted Project

Jun 22 2021

DylanFleming-arm added reviewers for D104722: [SVE] Added CodeGen support for inserting an element into a predicate vector: sdesmalen, t.p.northover.
Jun 22 2021, 9:53 AM · Restricted Project
DylanFleming-arm requested review of D104722: [SVE] Added CodeGen support for inserting an element into a predicate vector.
Jun 22 2021, 9:42 AM · Restricted Project

Jun 16 2021

DylanFleming-arm updated the diff for D104239: [SVE] Fix cast<FixedVectorType> in truncateToMinimalBitwidths.
Jun 16 2021, 9:12 AM · Restricted Project
DylanFleming-arm committed rG2a936be38864: [SVE] Selection failure with scalable insertelements (authored by DylanFleming-arm).
[SVE] Selection failure with scalable insertelements
Jun 16 2021, 7:55 AM
DylanFleming-arm closed D104244: [SVE] Selection failure with scalable insertelements.
Jun 16 2021, 7:55 AM · Restricted Project
DylanFleming-arm committed rGdab05335a642: [SVE] Fix PromoteIntRes_TRUNCATE not to call getVectorNumElements (authored by DylanFleming-arm).
[SVE] Fix PromoteIntRes_TRUNCATE not to call getVectorNumElements
Jun 16 2021, 5:11 AM
DylanFleming-arm closed D104115: [SVE] Fix PromoteIntRes_TRUNCATE not to call getVectorNumElements.
Jun 16 2021, 5:11 AM · Restricted Project
DylanFleming-arm updated the diff for D104115: [SVE] Fix PromoteIntRes_TRUNCATE not to call getVectorNumElements.
Jun 16 2021, 4:49 AM · Restricted Project
DylanFleming-arm updated the diff for D104244: [SVE] Selection failure with scalable insertelements.

Changed tests to include all nxv data types, not just 2f16, 4f16, and 2f32.

Jun 16 2021, 3:56 AM · Restricted Project

Jun 15 2021

DylanFleming-arm updated the diff for D104244: [SVE] Selection failure with scalable insertelements.

Changed predicate instructions to use the correct bitwidths

Jun 15 2021, 8:16 AM · Restricted Project
DylanFleming-arm updated the diff for D104239: [SVE] Fix cast<FixedVectorType> in truncateToMinimalBitwidths.
Jun 15 2021, 6:51 AM · Restricted Project
DylanFleming-arm updated the diff for D104239: [SVE] Fix cast<FixedVectorType> in truncateToMinimalBitwidths.
Jun 15 2021, 6:12 AM · Restricted Project

Jun 14 2021

DylanFleming-arm added reviewers for D104244: [SVE] Selection failure with scalable insertelements: sdesmalen, david-arm.
Jun 14 2021, 10:55 AM · Restricted Project
DylanFleming-arm requested review of D104244: [SVE] Selection failure with scalable insertelements.
Jun 14 2021, 10:49 AM · Restricted Project
DylanFleming-arm updated the diff for D104239: [SVE] Fix cast<FixedVectorType> in truncateToMinimalBitwidths.
Jun 14 2021, 9:54 AM · Restricted Project
DylanFleming-arm requested review of D104239: [SVE] Fix cast<FixedVectorType> in truncateToMinimalBitwidths.
Jun 14 2021, 9:52 AM · Restricted Project
DylanFleming-arm updated the diff for D104115: [SVE] Fix PromoteIntRes_TRUNCATE not to call getVectorNumElements.
Jun 14 2021, 3:32 AM · Restricted Project

Jun 11 2021

DylanFleming-arm added reviewers for D104115: [SVE] Fix PromoteIntRes_TRUNCATE not to call getVectorNumElements: sdesmalen, david-arm, kmclaughlin, nadav.
Jun 11 2021, 6:10 AM · Restricted Project
DylanFleming-arm requested review of D104115: [SVE] Fix PromoteIntRes_TRUNCATE not to call getVectorNumElements.
Jun 11 2021, 6:06 AM · Restricted Project