Page MenuHomePhabricator

DylanFleming-arm (Dylan Fleming)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 11 2021, 5:40 AM (67 w, 6 d)

Recent Activity

Fri, Sep 9

DylanFleming-arm updated the diff for D133442: [WIP][Flang][OpenMP] Add support for logical eqv in worksharing-loop.

Now appears to produce functionally correct code.

Fri, Sep 9, 10:53 AM · Restricted Project, Restricted Project, Restricted Project
DylanFleming-arm committed rGddc0465369a3: [Flang][OpenMP] Add support for logical and reduction in worksharing-loop (authored by DylanFleming-arm).
[Flang][OpenMP] Add support for logical and reduction in worksharing-loop
Fri, Sep 9, 10:30 AM · Restricted Project, Restricted Project
DylanFleming-arm closed D132228: [Flang][OpenMP] Add support for logical and reduction in worksharing-loop.
Fri, Sep 9, 10:30 AM · Restricted Project, Restricted Project
DylanFleming-arm abandoned D131679: [WIP][Flang][OpenMP] Add support for integer subtraction reduction in worksharing-loop.

Feature fully deprecated in D132060

Fri, Sep 9, 9:20 AM · Restricted Project, Restricted Project

Wed, Sep 7

DylanFleming-arm added a reviewer for D133442: [WIP][Flang][OpenMP] Add support for logical eqv in worksharing-loop: kiranchandramohan.
Wed, Sep 7, 11:38 AM · Restricted Project, Restricted Project, Restricted Project
DylanFleming-arm requested review of D133442: [WIP][Flang][OpenMP] Add support for logical eqv in worksharing-loop.
Wed, Sep 7, 11:37 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Sep 5

DylanFleming-arm updated the diff for D132228: [Flang][OpenMP] Add support for logical and reduction in worksharing-loop.

rebased onto main

Mon, Sep 5, 8:54 AM · Restricted Project, Restricted Project

Fri, Sep 2

DylanFleming-arm updated the diff for D132228: [Flang][OpenMP] Add support for logical and reduction in worksharing-loop.

Combined overloads for both updateReduction and getReductionInChain into two singlular functions with optional parameters

Fri, Sep 2, 6:24 AM · Restricted Project, Restricted Project

Thu, Sep 1

DylanFleming-arm committed rGe5caa0f2292d: [Flang][OpenMP] Add support for real typed reductions in worksharing-loop (authored by DylanFleming-arm).
[Flang][OpenMP] Add support for real typed reductions in worksharing-loop
Thu, Sep 1, 4:17 AM · Restricted Project, Restricted Project
DylanFleming-arm closed D132459: [Flang][OpenMP] Add support for real typed reductions in worksharing-loop.
Thu, Sep 1, 4:17 AM · Restricted Project, Restricted Project

Aug 25 2022

DylanFleming-arm updated the diff for D132459: [Flang][OpenMP] Add support for real typed reductions in worksharing-loop.

Added test for kind=8

Aug 25 2022, 3:52 AM · Restricted Project, Restricted Project

Aug 24 2022

DylanFleming-arm updated the diff for D132228: [Flang][OpenMP] Add support for logical and reduction in worksharing-loop.

Addressed Nits.

Aug 24 2022, 3:41 AM · Restricted Project, Restricted Project

Aug 23 2022

DylanFleming-arm added reviewers for D132459: [Flang][OpenMP] Add support for real typed reductions in worksharing-loop: awarzynski, kiranchandramohan, Leporacanthicus.
Aug 23 2022, 4:12 AM · Restricted Project, Restricted Project
DylanFleming-arm requested review of D132459: [Flang][OpenMP] Add support for real typed reductions in worksharing-loop.
Aug 23 2022, 4:11 AM · Restricted Project, Restricted Project

Aug 19 2022

DylanFleming-arm updated the diff for D132228: [Flang][OpenMP] Add support for logical and reduction in worksharing-loop.

rebased onto more recent base.

Aug 19 2022, 7:57 AM · Restricted Project, Restricted Project
DylanFleming-arm added reviewers for D132228: [Flang][OpenMP] Add support for logical and reduction in worksharing-loop: kiranchandramohan, Leporacanthicus, peixin, shraiysh.
Aug 19 2022, 6:27 AM · Restricted Project, Restricted Project
DylanFleming-arm requested review of D132228: [Flang][OpenMP] Add support for logical and reduction in worksharing-loop.
Aug 19 2022, 6:23 AM · Restricted Project, Restricted Project

Aug 11 2022

DylanFleming-arm requested review of D131679: [WIP][Flang][OpenMP] Add support for integer subtraction reduction in worksharing-loop.
Aug 11 2022, 7:25 AM · Restricted Project, Restricted Project

Aug 9 2022

DylanFleming-arm committed rG9893b26dfa75: [Flang][OpenMP] Add support for integer multiplication reduction in worksharing… (authored by DylanFleming-arm).
[Flang][OpenMP] Add support for integer multiplication reduction in worksharing…
Aug 9 2022, 12:32 PM · Restricted Project, Restricted Project
DylanFleming-arm closed D130767: [Flang][OpenMP] Add support for integer multiplication reduction in worksharing-loop.
Aug 9 2022, 12:31 PM · Restricted Project, Restricted Project
DylanFleming-arm updated the diff for D130767: [Flang][OpenMP] Add support for integer multiplication reduction in worksharing-loop.

I've re-ran clang-format on OpenMP.cpp, hopefully that fixes the problem!

Aug 9 2022, 7:56 AM · Restricted Project, Restricted Project

Aug 8 2022

DylanFleming-arm committed rG5784199dd1c1: [NFC][Flang][OpenMP] Refactor OpenMP.cpp::genOpenMPReduction (authored by DylanFleming-arm).
[NFC][Flang][OpenMP] Refactor OpenMP.cpp::genOpenMPReduction
Aug 8 2022, 7:28 AM · Restricted Project, Restricted Project
DylanFleming-arm closed D131161: [NFC][Flang][OpenMP] Refactor OpenMP.cpp::genOpenMPReduction.
Aug 8 2022, 7:27 AM · Restricted Project, Restricted Project

Aug 5 2022

DylanFleming-arm updated the diff for D130767: [Flang][OpenMP] Add support for integer multiplication reduction in worksharing-loop.

Added comment to getOperationIdentity() to explain it's usage.
Renamed "name" to "reductionOpName" for clarity.

Aug 5 2022, 6:21 AM · Restricted Project, Restricted Project

Aug 4 2022

DylanFleming-arm updated the diff for D131161: [NFC][Flang][OpenMP] Refactor OpenMP.cpp::genOpenMPReduction.

Added comment explaining getReductionInChain, renamed obscure/incorrect variables

Aug 4 2022, 9:17 AM · Restricted Project, Restricted Project
DylanFleming-arm updated the diff for D130767: [Flang][OpenMP] Add support for integer multiplication reduction in worksharing-loop.

rebased onto D131161

Aug 4 2022, 7:08 AM · Restricted Project, Restricted Project
DylanFleming-arm added reviewers for D131161: [NFC][Flang][OpenMP] Refactor OpenMP.cpp::genOpenMPReduction: awarzynski, shraiysh, peixin, Leporacanthicus, sscalpone.
Aug 4 2022, 5:56 AM · Restricted Project, Restricted Project
DylanFleming-arm added a comment to D130767: [Flang][OpenMP] Add support for integer multiplication reduction in worksharing-loop.

It would make much more sense to check for a chain first (in genOpenMPReduction, perhaps in a dedicated method to make the implementation cleaner) and only once that condition is satisfied, have this method to update things unconditionally. Could you try that?

Aug 4 2022, 5:55 AM · Restricted Project, Restricted Project
DylanFleming-arm requested review of D131161: [NFC][Flang][OpenMP] Refactor OpenMP.cpp::genOpenMPReduction.
Aug 4 2022, 5:46 AM · Restricted Project, Restricted Project

Aug 1 2022

DylanFleming-arm updated the diff for D130767: [Flang][OpenMP] Add support for integer multiplication reduction in worksharing-loop.

Created getReductionInitValue(), and made getOperationIdentity static

Aug 1 2022, 2:26 AM · Restricted Project, Restricted Project

Jul 29 2022

DylanFleming-arm updated the diff for D130767: [Flang][OpenMP] Add support for integer multiplication reduction in worksharing-loop.

I moved the code for getting the identity to a seperate function as suggested.

Jul 29 2022, 12:31 PM · Restricted Project, Restricted Project
DylanFleming-arm added a reviewer for D130767: [Flang][OpenMP] Add support for integer multiplication reduction in worksharing-loop: awarzynski.
Jul 29 2022, 5:53 AM · Restricted Project, Restricted Project
DylanFleming-arm requested review of D130767: [Flang][OpenMP] Add support for integer multiplication reduction in worksharing-loop.
Jul 29 2022, 5:53 AM · Restricted Project, Restricted Project

Jul 27 2022

DylanFleming-arm accepted D130558: [flang][docs][nfc] Refine FlangOptionsDocs.td.

LGTM!

Jul 27 2022, 9:18 AM · Restricted Project, Restricted Project

Jul 26 2022

DylanFleming-arm added inline comments to D130558: [flang][docs][nfc] Refine FlangOptionsDocs.td.
Jul 26 2022, 7:52 AM · Restricted Project, Restricted Project

Jul 22 2022

DylanFleming-arm committed rG846439dd97d4: [Flang] Generate documentation for compiler flags (authored by DylanFleming-arm).
[Flang] Generate documentation for compiler flags
Jul 22 2022, 10:06 AM · Restricted Project, Restricted Project, Restricted Project
DylanFleming-arm closed D129864: [Flang] Generate documentation for compiler flags.
Jul 22 2022, 10:05 AM · Restricted Project, Restricted Project, Restricted Project
DylanFleming-arm updated the summary of D129864: [Flang] Generate documentation for compiler flags.
Jul 22 2022, 8:33 AM · Restricted Project, Restricted Project, Restricted Project
DylanFleming-arm updated the diff for D129864: [Flang] Generate documentation for compiler flags.

After pushing to main, this patch cause a buildbot failure as CLANG_TABLEGEN_EXE could not be found.

Jul 22 2022, 8:03 AM · Restricted Project, Restricted Project, Restricted Project

Jul 21 2022

DylanFleming-arm committed rG396e944d82f3: [Flang] Generate documentation for compiler flags (authored by DylanFleming-arm).
[Flang] Generate documentation for compiler flags
Jul 21 2022, 4:34 AM · Restricted Project, Restricted Project, Restricted Project
DylanFleming-arm closed D129864: [Flang] Generate documentation for compiler flags.
Jul 21 2022, 4:34 AM · Restricted Project, Restricted Project, Restricted Project

Jul 20 2022

DylanFleming-arm updated the summary of D129864: [Flang] Generate documentation for compiler flags.
Jul 20 2022, 2:31 AM · Restricted Project, Restricted Project, Restricted Project

Jul 19 2022

DylanFleming-arm updated the diff for D129864: [Flang] Generate documentation for compiler flags.

Edited summary to be more clear.

Jul 19 2022, 10:30 AM · Restricted Project, Restricted Project, Restricted Project

Jul 15 2022

DylanFleming-arm added reviewers for D129864: [Flang] Generate documentation for compiler flags: serge-sans-paille, MaskRay, aaron.ballman.
Jul 15 2022, 8:49 AM · Restricted Project, Restricted Project, Restricted Project
DylanFleming-arm added reviewers for D129864: [Flang] Generate documentation for compiler flags: kiranchandramohan, awarzynski.
Jul 15 2022, 8:34 AM · Restricted Project, Restricted Project, Restricted Project
DylanFleming-arm requested review of D129864: [Flang] Generate documentation for compiler flags.
Jul 15 2022, 8:33 AM · Restricted Project, Restricted Project, Restricted Project

Jul 13 2022

DylanFleming-arm committed rGd5fa11c4aa6a: [Flang] Fix path strings in CreateFIRLangRef.py (authored by DylanFleming-arm).
[Flang] Fix path strings in CreateFIRLangRef.py
Jul 13 2022, 8:29 AM · Restricted Project, Restricted Project
DylanFleming-arm closed D129644: [Flang] Fix path strings in CreateFIRLangRef.py.
Jul 13 2022, 8:29 AM · Restricted Project, Restricted Project
DylanFleming-arm updated the diff for D129644: [Flang] Fix path strings in CreateFIRLangRef.py.

Fixed typo 'exectued' to 'executed'

Jul 13 2022, 8:21 AM · Restricted Project, Restricted Project
DylanFleming-arm updated the diff for D129644: [Flang] Fix path strings in CreateFIRLangRef.py.

Updated comment to better explain where the paths are relative to.

Jul 13 2022, 8:04 AM · Restricted Project, Restricted Project
DylanFleming-arm updated the diff for D129644: [Flang] Fix path strings in CreateFIRLangRef.py.

Ah, I meant it as from the binary working directory, as this file exists in both src and bin, and is copied over at build time, before being ran.
The comment itself is probably not needed, but without it, 'Dialect/FIRLangref.md' might seem like a non-existant file.

Jul 13 2022, 7:54 AM · Restricted Project, Restricted Project
DylanFleming-arm added a reviewer for D129644: [Flang] Fix path strings in CreateFIRLangRef.py: Leporacanthicus.
Jul 13 2022, 7:34 AM · Restricted Project, Restricted Project
DylanFleming-arm requested review of D129644: [Flang] Fix path strings in CreateFIRLangRef.py.
Jul 13 2022, 7:32 AM · Restricted Project, Restricted Project

Jul 11 2022

DylanFleming-arm committed rGe7f05f2ad3d7: [Flang] Fix formatting for FIRLangRef.html (authored by DylanFleming-arm).
[Flang] Fix formatting for FIRLangRef.html
Jul 11 2022, 11:49 AM · Restricted Project, Restricted Project
DylanFleming-arm closed D129186: [Flang] Fix formatting for FIRLangRef.html.
Jul 11 2022, 11:48 AM · Restricted Project, Restricted Project
DylanFleming-arm updated the diff for D129186: [Flang] Fix formatting for FIRLangRef.html.

Rebased onto main.

Jul 11 2022, 11:22 AM · Restricted Project, Restricted Project
DylanFleming-arm committed rGb9f8a1ea84a8: [Flang] Add a link from the docs html page to the FIR html page (authored by DylanFleming-arm).
[Flang] Add a link from the docs html page to the FIR html page
Jul 11 2022, 11:06 AM · Restricted Project, Restricted Project
DylanFleming-arm closed D128650: [Flang] Add a link from the docs html page to the FIR html page.
Jul 11 2022, 11:06 AM · Restricted Project, Restricted Project
DylanFleming-arm updated the diff for D129186: [Flang] Fix formatting for FIRLangRef.html.

I don't believe the path needs to be at the top here? I may be wrong but I think they're mainly for manual execution, This script should only realistically be ran as part of the HTML auto-generation process.
I've added a comment to the top of the file to explain it's purpose at least, I think that should be sufficient in this case.

Jul 11 2022, 8:03 AM · Restricted Project, Restricted Project
DylanFleming-arm updated the diff for D128650: [Flang] Add a link from the docs html page to the FIR html page.

I've moved the dependency inside the custom_target declaration, it should resolve the issue of dependency ordering.

Jul 11 2022, 7:55 AM · Restricted Project, Restricted Project
DylanFleming-arm updated the diff for D128650: [Flang] Add a link from the docs html page to the FIR html page.

Ah, I must've forgotten about that problem,

Jul 11 2022, 3:40 AM · Restricted Project, Restricted Project

Jul 8 2022

DylanFleming-arm updated the diff for D129186: [Flang] Fix formatting for FIRLangRef.html.

Reworked CreateFIRLangRef.py to better fit pythons standards based upon internal review.

Jul 8 2022, 6:31 AM · Restricted Project, Restricted Project

Jul 6 2022

DylanFleming-arm added reviewers for D129186: [Flang] Fix formatting for FIRLangRef.html: kiranchandramohan, awarzynski.
Jul 6 2022, 4:11 AM · Restricted Project, Restricted Project
DylanFleming-arm requested review of D129186: [Flang] Fix formatting for FIRLangRef.html.
Jul 6 2022, 4:10 AM · Restricted Project, Restricted Project

Jul 1 2022

DylanFleming-arm updated the diff for D128650: [Flang] Add a link from the docs html page to the FIR html page.

Expanded comments around copying files.

Jul 1 2022, 9:40 AM · Restricted Project, Restricted Project

Jun 29 2022

DylanFleming-arm updated the diff for D128650: [Flang] Add a link from the docs html page to the FIR html page.

Changed summary to include problem with incorrect formatting.
Removed copying of FIRLangRef to source.

Jun 29 2022, 4:05 AM · Restricted Project, Restricted Project

Jun 27 2022

DylanFleming-arm added reviewers for D128650: [Flang] Add a link from the docs html page to the FIR html page: awarzynski, kiranchandramohan.
Jun 27 2022, 7:45 AM · Restricted Project, Restricted Project
DylanFleming-arm requested review of D128650: [Flang] Add a link from the docs html page to the FIR html page.
Jun 27 2022, 7:44 AM · Restricted Project, Restricted Project

Aug 17 2021

DylanFleming-arm retitled D106277: [SVE] Remove usage of getMaxVScale for AArch64, in favour of IR Attribute from [SVE] Remove the interface for getMaxVScale in favour of the IR attributes to [SVE] Remove usage of getMaxVScale for AArch64, in favour of IR Attribute.
Aug 17 2021, 6:45 AM · Restricted Project, Restricted Project
DylanFleming-arm committed rGef198cd99e6b: [SVE] Remove usage of getMaxVScale for AArch64, in favour of IR Attribute (authored by DylanFleming-arm).
[SVE] Remove usage of getMaxVScale for AArch64, in favour of IR Attribute
Aug 17 2021, 6:43 AM
DylanFleming-arm closed D106277: [SVE] Remove usage of getMaxVScale for AArch64, in favour of IR Attribute.
Aug 17 2021, 6:43 AM · Restricted Project, Restricted Project

Aug 13 2021

DylanFleming-arm committed rG4be7fb976228: [SVE] Add folds for truncation of vscale (authored by DylanFleming-arm).
[SVE] Add folds for truncation of vscale
Aug 13 2021, 2:18 AM
DylanFleming-arm closed D107453: [SVE] Add folds for truncation of vscale.
Aug 13 2021, 2:18 AM · Restricted Project

Aug 12 2021

DylanFleming-arm updated the diff for D106277: [SVE] Remove usage of getMaxVScale for AArch64, in favour of IR Attribute.

Added checks for MaxVScale > 0
Changed getMaxNumElemenets() to take Function* instead of Instruction*
Fixed clang-tidy warning

Aug 12 2021, 8:20 AM · Restricted Project, Restricted Project

Aug 4 2021

DylanFleming-arm updated the diff for D107453: [SVE] Add folds for truncation of vscale.

Added check for MaxVScale > 0

Aug 4 2021, 7:52 AM · Restricted Project
DylanFleming-arm added reviewers for D107453: [SVE] Add folds for truncation of vscale: sdesmalen, david-arm.
Aug 4 2021, 5:51 AM · Restricted Project
DylanFleming-arm requested review of D107453: [SVE] Add folds for truncation of vscale.
Aug 4 2021, 5:49 AM · Restricted Project

Aug 3 2021

DylanFleming-arm committed rG3943a74666cb: [InstCombine] Fixed select + masked load fold failure (authored by DylanFleming-arm).
[InstCombine] Fixed select + masked load fold failure
Aug 3 2021, 11:07 AM
DylanFleming-arm closed D107372: [InstCombine] Fixed select + masked load fold failure.
Aug 3 2021, 11:07 AM · Restricted Project
DylanFleming-arm added a comment to D107372: [InstCombine] Fixed select + masked load fold failure.

Yeah, I think it definitely makes sense to have it put into the LLVM13 release

Aug 3 2021, 10:38 AM · Restricted Project
DylanFleming-arm added reviewers for D107372: [InstCombine] Fixed select + masked load fold failure: sdesmalen, srj, ebrevnov.
Aug 3 2021, 10:06 AM · Restricted Project
DylanFleming-arm requested review of D107372: [InstCombine] Fixed select + masked load fold failure.
Aug 3 2021, 10:01 AM · Restricted Project
DylanFleming-arm added a comment to D106376: [SVE] Add support for folding for select + masked loads.

I'm looking into it now, hopefully I'll have a fix for it soon.

Aug 3 2021, 4:07 AM · Restricted Project

Aug 2 2021

DylanFleming-arm added a comment to D106376: [SVE] Add support for folding for select + masked loads.

I did recently encounter a bug from binop matching here https://reviews.llvm.org/D105978 I don't think these cases are related, but it might be worth having a quick check just to rule it out for definite?

Aug 2 2021, 4:55 PM · Restricted Project

Jul 30 2021

DylanFleming-arm committed rGa7a39ec886a0: [SVE] Add folds for sign and zero extends of vscale (authored by DylanFleming-arm).
[SVE] Add folds for sign and zero extends of vscale
Jul 30 2021, 8:04 AM
DylanFleming-arm closed D105994: [SVE] Add folds for sign and zero extends of vscale.
Jul 30 2021, 8:03 AM · Restricted Project

Jul 27 2021

DylanFleming-arm updated the diff for D106277: [SVE] Remove usage of getMaxVScale for AArch64, in favour of IR Attribute.

Rebased onto main, updated newly added AArch64 getMaxVScale usages to use IR attribute instead

Jul 27 2021, 7:08 AM · Restricted Project, Restricted Project

Jul 26 2021

DylanFleming-arm updated the diff for D105994: [SVE] Add folds for sign and zero extends of vscale.

Changed bitshift to Log2_32

Jul 26 2021, 9:37 AM · Restricted Project
DylanFleming-arm updated the diff for D106277: [SVE] Remove usage of getMaxVScale for AArch64, in favour of IR Attribute.

Added getVScaleRange interface to TargetInfo and removed related AArch64 specific code from CodeGenFunction.cpp

Jul 26 2021, 8:35 AM · Restricted Project, Restricted Project
DylanFleming-arm committed rG20b0fa91c9ee: [SVE] Add support for folding for select + masked loads (authored by DylanFleming-arm).
[SVE] Add support for folding for select + masked loads
Jul 26 2021, 3:59 AM
DylanFleming-arm closed D106376: [SVE] Add support for folding for select + masked loads.
Jul 26 2021, 3:59 AM · Restricted Project

Jul 23 2021

DylanFleming-arm updated the diff for D106376: [SVE] Add support for folding for select + masked loads.

I forgot to check this patch with all targets before putting it for review
Two none AARch64 tests were affected, I've updated them to work now and the output seems to be as expected

Jul 23 2021, 9:47 AM · Restricted Project
DylanFleming-arm committed rG80e0bd149661: [SVE][IR] Fix Binary op matching in PatternMatch::m_VScale (authored by DylanFleming-arm).
[SVE][IR] Fix Binary op matching in PatternMatch::m_VScale
Jul 23 2021, 3:40 AM
DylanFleming-arm closed D105978: [SVE][IR] Fix Binary op matching in PatternMatch::m_VScale.
Jul 23 2021, 3:40 AM · Restricted Project

Jul 22 2021

DylanFleming-arm updated the diff for D106277: [SVE] Remove usage of getMaxVScale for AArch64, in favour of IR Attribute.

Removed changes to RiscV code
Added check that target isAArch64 before adding default value vscale_range attribute

Jul 22 2021, 10:44 AM · Restricted Project, Restricted Project
DylanFleming-arm updated the diff for D106376: [SVE] Add support for folding for select + masked loads.

Fixed lint issues
Added comment stating that not checking for one use is intentional

Jul 22 2021, 6:39 AM · Restricted Project

Jul 21 2021

DylanFleming-arm updated the diff for D105994: [SVE] Add folds for sign and zero extends of vscale.

Added check for vscale_range attribute before optimisation
If the attribute isn't present, or if the maximum value exceeds the bitwidth of the original instrinsic, the optimization is skipped

Jul 21 2021, 11:59 AM · Restricted Project
DylanFleming-arm updated the summary of D106376: [SVE] Add support for folding for select + masked loads.
Jul 21 2021, 3:33 AM · Restricted Project

Jul 20 2021

DylanFleming-arm added reviewers for D106376: [SVE] Add support for folding for select + masked loads: sdesmalen, david-arm.
Jul 20 2021, 9:21 AM · Restricted Project
DylanFleming-arm requested review of D106376: [SVE] Add support for folding for select + masked loads.
Jul 20 2021, 9:20 AM · Restricted Project