Page MenuHomePhabricator

[Analysis] Pass RecurrenceDescriptor as const reference. NFCI.
ClosedPublic

Authored by RKSimon on Jun 10 2021, 7:13 AM.

Details

Summary

We were passing the RecurrenceDescriptor by value to most of the reduction analysis methods, despite it being rather bulky with TrackingVH members (that can be costly to copy). In all these cases we're only using the RecurrenceDescriptor for rather basic purposes (access to types/kinds etc.).

Diff Detail

Event Timeline

RKSimon created this revision.Jun 10 2021, 7:13 AM
RKSimon requested review of this revision.Jun 10 2021, 7:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2021, 7:13 AM
Herald added a subscriber: MaskRay. · View Herald Transcript
This revision is now accepted and ready to land.Jun 10 2021, 7:17 AM
sdesmalen accepted this revision.Jun 10 2021, 7:18 AM
sdesmalen added a subscriber: sdesmalen.

Passing by const reference seems sensible, it avoids passing the whole thing by value and none of the functions need to modify it.

This revision was landed with ongoing or failed builds.Jun 11 2021, 2:24 AM
This revision was automatically updated to reflect the committed changes.