Page MenuHomePhabricator

Rename MachineMemOperand::getOrdering -> getSuccessOrdering.
ClosedPublic

Authored by efriedma on May 28 2021, 1:24 PM.

Details

Summary

Since this method can apply to cmpxchg operations, make sure it's clear what value we're actually retrieving. This will help ensure we don't accidentally ignore the failure ordering of cmpxchg in the future.

We could potentially introduce a getOrdering() method on AtomicSDNode that asserts the operation isn't cmpxchg, but not sure that's worthwhile.

Diff Detail

Event Timeline

efriedma created this revision.May 28 2021, 1:24 PM
efriedma requested review of this revision.May 28 2021, 1:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 28 2021, 1:24 PM
jyknight accepted this revision.Jun 9 2021, 4:03 PM
This revision is now accepted and ready to land.Jun 9 2021, 4:03 PM