Page MenuHomePhabricator

[AArch64][GlobalISel] Support truncstorei8/i16 w/ combine to form truncating G_STOREs.
ClosedPublic

Authored by aemerson on May 10 2021, 5:49 PM.

Details

Summary

This needs some tablegen changes so that we can actually import the patterns properly.

Diff Detail

Event Timeline

aemerson created this revision.May 10 2021, 5:49 PM
aemerson requested review of this revision.May 10 2021, 5:49 PM
arsenm added inline comments.May 10 2021, 6:03 PM
llvm/utils/TableGen/GlobalISelEmitter.cpp
3783–3785

Where does this actually come up? Are there really patterns using i1 memory types?

aemerson added inline comments.May 10 2021, 8:10 PM
llvm/utils/TableGen/GlobalISelEmitter.cpp
3783–3785

I’m not sure, this was just a refactoring of existing code.

paquette added inline comments.May 11 2021, 9:29 AM
llvm/utils/TableGen/GlobalISelEmitter.cpp
3660

should probably be a doxygen comment

3784

This comment is kind of confusing?

aemerson updated this revision to Diff 344473.May 11 2021, 10:35 AM
This revision is now accepted and ready to land.May 11 2021, 10:37 AM
This revision was landed with ongoing or failed builds.May 11 2021, 11:33 AM
This revision was automatically updated to reflect the committed changes.