Page MenuHomePhabricator

[flang] Remove `%f18` from LIT configuration files
ClosedPublic

Authored by awarzynski on Apr 26 2021, 2:41 AM.

Details

Summary

%f18 was originally introduced to represent the old Flang driver,
f18. With the introduction of the new driver, flang-new, we have
been switching to %flang (compiler driver) and %flang_fc1 (frontend
driver) as more generic alternatives.

As most tests have been portend to use the new LIT variables instead of
%f18, this is good time to remove it from lit.cfg.py. There's only one
test left that requires the old driver to run. It's updated with:

! REQUIRES: old-flang-driver

This way we preserve its semantics while reducing the number of
variables in LIT configuration.

Diff Detail

Event Timeline

awarzynski created this revision.Apr 26 2021, 2:41 AM
awarzynski requested review of this revision.Apr 26 2021, 2:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 26 2021, 2:41 AM
arnamoy10 added inline comments.Apr 27 2021, 6:35 AM
flang/test/lit.cfg.py
67

Can we remove this variable or we envision some future uses of this?

awarzynski added inline comments.Apr 27 2021, 7:35 AM
flang/test/lit.cfg.py
67

Not really, tool is used on lines 79 and 81.

LGTM

flang/test/lit.cfg.py
67

I see, thanks!

This revision is now accepted and ready to land.May 6 2021, 1:40 AM
This revision was automatically updated to reflect the committed changes.