This is an archive of the discontinued LLVM Phabricator instance.

[OpenCL] Allow pipe as a valid identifier prior to OpenCL 2.0
ClosedPublic

Authored by Anastasia on Apr 22 2021, 5:20 AM.

Details

Summary

pipe has not been a reserved keyword in the earlier OpenCL standards
https://www.khronos.org/registry/OpenCL/specs/opencl-1.2.pdf
however we failed to allow its use as an identifier in the original implememntation.

This patch fixes the issue and improves testing.

Btw I feel we have a spec issue in the unified spec https://www.khronos.org/registry/OpenCL/specs/3.0-unified/html/OpenCL_C.html#keywords because it doesn't say that the pipe is reserved only from OpenCL 2.0?
I have created this for clarifications: https://github.com/KhronosGroup/OpenCL-Docs/issues/601

Diff Detail

Event Timeline

Anastasia created this revision.Apr 22 2021, 5:20 AM
Anastasia requested review of this revision.Apr 22 2021, 5:20 AM
Anastasia edited the summary of this revision. (Show Details)Apr 22 2021, 5:25 AM
svenvh accepted this revision.Apr 22 2021, 5:55 AM

LGTM

This revision is now accepted and ready to land.Apr 22 2021, 5:55 AM
Anastasia retitled this revision from [OpenCL] allow pipe as a valid identifier prior to OpenCL 2.0 to [OpenCL] Allow pipe as a valid identifier prior to OpenCL 2.0.Apr 22 2021, 9:52 AM
This revision was landed with ongoing or failed builds.May 4 2021, 6:31 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 4 2021, 6:31 AM
Herald added a subscriber: ldrumm. · View Herald Transcript