Page MenuHomePhabricator

[llvm-readobj] Remove GNU_PROPERTY_X86_ISA_1_{NEEDED,USED}
AbandonedPublic

Authored by MaskRay on Mar 17 2021, 2:51 PM.

Details

Summary

This reverts D58175 (commit 91ab9bf32cc5d20919bcc1989bde3eca1a3c1764).

https://sourceware.org/bugzilla/show_bug.cgi?id=26703 deprecated the
previous GNU_PROPERTY_X86_ISA_1_{CMOV,SSE,*} values (renamed to COMPAT).
Since the values are not used by compilers, having dumping support in
llvm-readobj is unnecessary. So just drop the feature.

Diff Detail

Event Timeline

MaskRay created this revision.Mar 17 2021, 2:51 PM
MaskRay requested review of this revision.Mar 17 2021, 2:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 17 2021, 2:51 PM

Won't this make newer llvm-readobj instances unable to interpret older objects? I'm not sure that's particularly desirable, at least until the objects in question could be considered very old (if I understand it correctly, the compiler change is only very recent).

Won't this make newer llvm-readobj instances unable to interpret older objects? I'm not sure that's particularly desirable, at least until the objects in question could be considered very old (if I understand it correctly, the compiler change is only very recent).

As I understand it, 0xc0008000 and 0xc0010000 are never used. There is no non-testsuite object with the notes.

jhenderson accepted this revision.Mar 19 2021, 1:53 AM

Okay, LGTM to the removal, though I'm wondering whether it would make more sense to merge D98818 and this patch together, so that the llvm-readobj changes are more minimal (just replacing the DumpBit listing).

I don't mind either way, so if you prefer to keep them separate, please go ahead.

This revision is now accepted and ready to land.Mar 19 2021, 1:53 AM
MaskRay abandoned this revision.Mar 19 2021, 2:32 PM

Merged into D98818