[llvm-objcopy][llvm-strip][test] Improve testing

[jhenderson]

Summary

This patch adds a number of new test cases that cover various llvm-objcopy and llvm-strip features that had missing test coverage of various descriptions:

• --add-section - checked the shdr properties, not just the content.
• Dedicated test case for --add-symbol when there are many sections.
• Show that --change-start accepts negative values without overflow. This was previously present but got lost between review versions.
• --dump-section - show that multiple sections can be dumped simultaneously to different files, and that an error is reported when a section cannot be found.
• --globalize-symbol(s) - show that symbols that are not mentioned are not globalized, if they would otherwise be, and that missing symbols from the list do not cause problems.
• --keep-global-symbol - show that the --regex option can be used in conjunction with this option.
• --keep-symbol - show that the --regex option can be used in conjunction with this option.
• --localize-symbol(s) - show that symbols that are not mentioned are not localized, if they would otherwise be, and that missing symbols from the list do not cause problems.
• --prefix-alloc-sections - show the behaviour of an empty string argument and multiple arguments.
• --prefix-symbols - show the behaviour of an empty string argument and multiple arguments. Also show the option applies to undefined symbols.
• --redefine-symbol - show that symbols with no name can be renamed, that it is not an error if a symbol is not specified, and that the option doesn't chain (i.e. --redefine-sym a=b --redefine-sym b=c does not redefine a as c).
• --rename-section - show that all section flags are preserved if none are specified. Also show that the option does not chain.
• --set-section-alignment - show that only specified sections have their alignments changed.
• --set-section-flags - show which section flags are preserved when this option is used. Also show that unspecified sections are not affected.
• --preserve-dates - show that -p is an alias of --preserve-dates.
• --strip-symbol - show that --regex works with this option for llvm-objcopy as well as llvm-strip.
• --strip-unneeded-symbol(s) - show more clearly that needed symbols are not stripped even if requested by this option.
• --allow-broken-links - show the sh_link of a symbol table is set to 0 when its string table has been removed when this option is specified.
• --weaken-symbol(s) - show that symbols that are not mentioned are not weakened, if they would otherwise be, and that missing symbols from the list do not cause problems.
• --wildcard - show the wildcard behaviour for several options that were previously unchecked.

Depends on D97661.

llvm/test/tools/llvm-objcopy/ELF/add-section.test

- Name:            .test2
     Content:        "DEADBEEF"
   - Name:            .test3
     Type:            SHT_PROGBITS
     Flags:           [ SHF_ALLOC ]
     Content:        "32323232"
 
 # CHECK: SectionHeaderCount: 6
 
-# CHECK: Name: .test1
-# CHECK: Name: .test3
-# CHECK: Name: .strtab
-# CHECK: Name: .shstrtab
-# CHECK: Name: .test2
-# CHECK: SectionData (
+# CHECK:      Name: .test1
+# CHECK:      Name: .test3
+# CHECK:      Name: .strtab
+# CHECK:      Name: .shstrtab
+# CHECK:      Offset: 0x[[#%x,OFFSET:]]
+# CHECK:      Size: [[#%u,SIZE:]]
+# CHECK:      Name: .test2
+# CHECK-NEXT: Type: SHT_PROGBITS
+# CHECK-NEXT: Flags [ (0x0)
+# CHECK-NEXT: ]
+# CHECK-NEXT: Address: 0x0
+# CHECK-NEXT: Offset: 0x[[#%x,OFFSET+SIZE]]
+# CHECK-NEXT: Size: 4
+# CHECK-NEXT: Link: 0
+# CHECK-NEXT: Info: 0
+# CHECK-NEXT: AddressAlignment: 1
+# CHECK-NEXT: EntrySize: 0
+# CHECK-NEXT: SectionData (
 # CHECK-NEXT:   0000: DEADBEEF
 # CHECK-NEXT: )
 
 ## Test that llvm-objcopy produces an error if the file with section contents
 ## to be added does not exist.
 # RUN: not llvm-objcopy --add-section=.section.name=%t.missing %t %t.out 2>&1 | FileCheck -DFILE1=%t -DFILE2=%t.missing -DMSG=%errc_ENOENT %s --check-prefixes=ERR1
 
 # ERR1: error: '[[FILE1]]': '[[FILE2]]': [[MSG]]

llvm/test/tools/llvm-objcopy/ELF/add-symbol-many-sections.test

+## Show that when adding a symbol defined in a section with section index >=
+## SHN_LORESERVE, the symbol's st_shndx value is set correctly, and the
+## SHT_SYMTAB_SHNDX is properly updated.
+## We don't bother to check the actual details of SHT_SYMTAB_SHNDX, because
+## llvm-readobj wouldn't be able to produce the right section indexes if it were
+## incorrect.
+
+## newsym1 = is in a section with index < SHN_LORESERVE.
+## newsym2 = is in a section with index == SHN_LORESERVE.
+## newsym3 = is in a section with index == SHN_ABS.
+## newsym4 = is in a section with index == SHN_COMMON.
+## newsym5 = is in a section with index == SHN_XINDEX.
+## newsym6 = is in a section with index > SHN_XINDEX.
+
+# RUN: %python %p/../Inputs/ungzip.py %p/Inputs/many-sections.o.gz > %t
+# RUN: llvm-objcopy %t %t2 --add-symbol=newsym1=s1:0 --add-symbol=newsym2=s65280:0 \
+# RUN:                     --add-symbol=newsym3=s65521:0 --add-symbol=newsym4=s65522:0 \
+# RUN:                     --add-symbol=newsym5=s65535:0 --add-symbol=newsym6=s65536:0
+# RUN: llvm-readobj --symbols %t2 | FileCheck %s
+
+# CHECK:         Name: newsym1
+# CHECK-NEXT:    Value: 0x0
+# CHECK-NEXT:    Size: 0
+# CHECK-NEXT:    Binding: Global (0x1)
+# CHECK-NEXT:    Type: None (0x0)
+# CHECK-NEXT:    Other: 0
+# CHECK-NEXT:    Section: s1 (0x1)
+# CHECK-NEXT:  }
+# CHECK-NEXT:  Symbol {
+# CHECK-NEXT:    Name: newsym2
+# CHECK-NEXT:    Value: 0x0
+# CHECK-NEXT:    Size: 0
+# CHECK-NEXT:    Binding: Global (0x1)
+# CHECK-NEXT:    Type: None (0x0)
+# CHECK-NEXT:    Other: 0
+# CHECK-NEXT:    Section: s65280 (0xFF00)
+# CHECK-NEXT:  }
+# CHECK-NEXT:  Symbol {
+# CHECK-NEXT:    Name: newsym3
+# CHECK-NEXT:    Value: 0x0
+# CHECK-NEXT:    Size: 0
+# CHECK-NEXT:    Binding: Global (0x1)
+# CHECK-NEXT:    Type: None (0x0)
+# CHECK-NEXT:    Other: 0
+# CHECK-NEXT:    Section: s65521 (0xFFF1)
+# CHECK-NEXT:  }
+# CHECK-NEXT:  Symbol {
+# CHECK-NEXT:    Name: newsym4
+# CHECK-NEXT:    Value: 0x0
+# CHECK-NEXT:    Size: 0
+# CHECK-NEXT:    Binding: Global (0x1)
+# CHECK-NEXT:    Type: None (0x0)
+# CHECK-NEXT:    Other: 0
+# CHECK-NEXT:    Section: s65522 (0xFFF2)
+# CHECK-NEXT:  }
+# CHECK-NEXT:  Symbol {
+# CHECK-NEXT:    Name: newsym5
+# CHECK-NEXT:    Value: 0x0
+# CHECK-NEXT:    Size: 0
+# CHECK-NEXT:    Binding: Global (0x1)
+# CHECK-NEXT:    Type: None (0x0)
+# CHECK-NEXT:    Other: 0
+# CHECK-NEXT:    Section: s65535 (0xFFFF)
+# CHECK-NEXT:  }
+# CHECK-NEXT:  Symbol {
+# CHECK-NEXT:    Name: newsym6
+# CHECK-NEXT:    Value: 0x0
+# CHECK-NEXT:    Size: 0
+# CHECK-NEXT:    Binding: Global (0x1)
+# CHECK-NEXT:    Type: None (0x0)
+# CHECK-NEXT:    Other: 0
+# CHECK-NEXT:    Section: s65536 (0x10000)
+# CHECK-NEXT:  }

llvm/test/tools/llvm-objcopy/ELF/change-entry-point.test

 # RUN: yaml2obj %s -o %t
 
 # Test --set-start.
 # RUN: llvm-objcopy --set-start 0x1000 %t %t2
 # RUN: llvm-readobj --file-headers %t2 | FileCheck %s --check-prefix=SET
 # RUN: llvm-objcopy --set-start 4096 %t %t3
 # RUN: cmp %t2 %t3
 # RUN: llvm-objcopy --set-start 0x100000000 %t %t4
 # RUN: llvm-readobj --file-headers %t4 | FileCheck %s --check-prefix=SET-LARGE
 # RUN: not llvm-objcopy --set-start -123 %t %t5 2>&1 | FileCheck %s --check-prefix=SET-ERR
 
 # Test --change-start.
 # RUN: llvm-objcopy --change-start 0x50 %t %t6
 # RUN: llvm-readobj --file-headers %t6 | FileCheck %s --check-prefix=ADD
 # RUN: llvm-objcopy --change-start 0x100000000 %t %t7
 # RUN: llvm-readobj --file-headers %t7 | FileCheck %s --check-prefix=ADD-LARGE
-# RUN: llvm-objcopy --change-start -4353 %t %t8
-# RUN: llvm-readobj --file-headers %t8 | FileCheck %s --check-prefix=ADD-UNDERFLOW
-# RUN: llvm-objcopy --change-start -0x1101 %t %t9
-# RUN: cmp %t8 %t9
-# RUN: not llvm-objcopy --change-start -xyz %t %t10 2>&1 | FileCheck %s --check-prefix=ADD-ERR
+# RUN: llvm-objcopy --change-start -128 %t %t8
+# RUN: llvm-readobj --file-headers %t8 | FileCheck %s --check-prefix=SUB
+# RUN: llvm-objcopy --change-start -4353 %t %t9
+# RUN: llvm-readobj --file-headers %t9 | FileCheck %s --check-prefix=ADD-UNDERFLOW
+# RUN: llvm-objcopy --change-start -0x1101 %t %t10
+# RUN: cmp %t9 %t10
+# RUN: not llvm-objcopy --change-start -xyz %t %t11 2>&1 | FileCheck %s --check-prefix=ADD-ERR
 
 # Test --change-start after --set-start. Result should be 0x1150.
-# RUN: llvm-objcopy --set-start 0x1000 --change-start 0x100 --change-start 0x50 %t %t11
-# RUN: cmp %t6 %t11
+# RUN: llvm-objcopy --set-start 0x1000 --change-start 0x100 --change-start 0x50 %t %t12
+# RUN: cmp %t6 %t12
 
 # If --set-start is after --change-start then --change-start has no effect.
-# RUN: llvm-objcopy --change-start 0x150 --set-start 0x1000 %t %t12
-# RUN: cmp %t2 %t12
+# RUN: llvm-objcopy --change-start 0x150 --set-start 0x1000 %t %t13
+# RUN: cmp %t2 %t13
 
 # --adjust-start is an alias for --change-start.
-# RUN: llvm-objcopy --adjust-start -0x1101 %t %t13
-# RUN: cmp %t9 %t13
+# RUN: llvm-objcopy --adjust-start -0x1101 %t %t14
+# RUN: cmp %t10 %t14
 
 !ELF
 FileHeader:
   Class:           ELFCLASS64
   Data:            ELFDATA2LSB
   Type:            ET_EXEC
   Machine:         EM_X86_64
   Entry:           0x1100

llvm/test/tools/llvm-objcopy/ELF/dump-section.test

 # RUN: yaml2obj %s -o %t
 # RUN: llvm-objcopy -O binary -j .text %t %t2
 # RUN: llvm-objcopy -O binary --only-section .text %t %t3
 # RUN: llvm-objcopy --dump-section .text=%t4 %t %t5
 # RUN: llvm-objcopy --dump-section .foo=%t6 %t %t7
 # RUN: not llvm-objcopy --dump-section .bar=%t8 %t %t9 2>&1 | FileCheck %s --check-prefix=NOBITS -DINPUT=%t
+# RUN: llvm-objcopy --dump-section .text=%t10 --dump-section .foo=%t11 %t /dev/null
 # RUN: llvm-objcopy --dump-section .empty=%t.empty %t /dev/null
 # RUN: od -t x1 %t2 | FileCheck %s --ignore-case
 # RUN: od -t x1 %t6 | FileCheck %s --ignore-case --check-prefix=NON-ALLOC
 # RUN: wc -c %t2 | FileCheck %s --check-prefix=SIZE
 # RUN: wc -c %t.empty | FileCheck %s --check-prefix=EMPTY
 # RUN: diff %t2 %t3
 # RUN: diff %t4 %t3
+# RUN: diff %t10 %t3
+# RUN: diff %t11 %t6
 
 !ELF
 FileHeader:
   Class:           ELFCLASS64
   Data:            ELFDATA2LSB
   Type:            ET_EXEC
   Machine:         EM_X86_64
 Sections:

 
 # NON-ALLOC: 0000000 ca fe
 
 # SIZE: 4
 
 # NOBITS: error: '[[INPUT]]': cannot dump section '.bar': it has no contents
 
 # EMPTY: 0
+
+# RUN: not llvm-objcopy --dump-section =/dev/null %t /dev/null 2>&1 | \
+# RUN:   FileCheck %s --check-prefix=ERR -DFILE=%t "-DSECTION="
+# RUN: not llvm-objcopy --dump-section .missing=/dev/null %t /dev/null 2>&1 | \
+# RUN:   FileCheck %s --check-prefix=ERR -DFILE=%t -DSECTION=.missing
+
+# ERR: error: '[[FILE]]': section '[[SECTION]]' not found

llvm/test/tools/llvm-objcopy/ELF/globalize.test

 # RUN: yaml2obj %s -o %t
 # RUN: llvm-objcopy --globalize-symbol Global \
 # RUN:   --globalize-symbol Local \
 # RUN:   --globalize-symbol Weak \
-# RUN:   --globalize-symbol WeakUndef %t %t2
+# RUN:   --globalize-symbol WeakUndef \
+# RUN:   --globalize-symbol Missing %t %t2
 # RUN: llvm-readobj --symbols %t2 | FileCheck %s
-# RUN: llvm-objcopy --regex --globalize-symbol='.*' %t %t3
+# RUN: llvm-objcopy --regex --globalize-symbol='[GLW].*' %t %t3
 # RUN: cmp %t2 %t3
 # RUN: echo " Global # global" > %t-list.txt
 # RUN: echo "Local" >> %t-list.txt
 # RUN: echo "Weak" >> %t-list.txt
 # RUN: echo "WeakUndef" >> %t-list.txt
+# RUN: echo "Missing" >> %t-list.txt
 # RUN: echo " # comment " >> %t-list.txt
 # RUN: llvm-objcopy --globalize-symbols %t-list.txt %t %t4
 # RUN: cmp %t2 %t4
-# RUN: echo ".+ # .+ " > %t-list2.txt
+# RUN: echo "[GLW].+ # .+ " > %t-list2.txt
 # RUN: llvm-objcopy --regex --globalize-symbols %t-list2.txt %t %t5
 # RUN: cmp %t2 %t5
 
 !ELF
 FileHeader:
   Class:           ELFCLASS64
   Data:            ELFDATA2LSB
   Type:            ET_REL
Symbols:
   - Name:     Weak
     Type:     STT_FUNC
     Size:     8
     Section:  .text
     Value:    0x1008
     Binding:  STB_WEAK
   - Name:     WeakUndef
     Binding:  STB_WEAK
+  - Name:     Unspecified
+    Section:  .text
+    Binding:  STB_WEAK
 
 #CHECK: Symbols [
 #CHECK-NEXT:  Symbol {
 #CHECK-NEXT:    Name:
 #CHECK-NEXT:    Value: 0x0
 #CHECK-NEXT:    Size: 0
 #CHECK-NEXT:    Binding: Local
 #CHECK-NEXT:    Type: None

 #CHECK-NEXT:    Name: WeakUndef
 #CHECK-NEXT:    Value: 0x0
 #CHECK-NEXT:    Size: 0
 #CHECK-NEXT:    Binding: Weak
 #CHECK-NEXT:    Type: None
 #CHECK-NEXT:    Other: 0
 #CHECK-NEXT:    Section: Undefined
 #CHECK-NEXT:  }
+#CHECK-NEXT:  Symbol {
+#CHECK-NEXT:    Name: Unspecified
+#CHECK-NEXT:    Value: 0x0
+#CHECK-NEXT:    Size: 0
+#CHECK-NEXT:    Binding: Weak
+#CHECK-NEXT:    Type: None
+#CHECK-NEXT:    Other: 0
+#CHECK-NEXT:    Section: .text
+#CHECK-NEXT:  }
 #CHECK-NEXT:]

llvm/test/tools/llvm-objcopy/ELF/keep-global-symbols.test

 # RUN:   -G Weak1 \
 # RUN:   --globalize-symbol Weak2 \
 # RUN:   %t.o %t.2.o
 # RUN: llvm-readelf --symbols %t.2.o | FileCheck %s
 
 # RUN: llvm-objcopy  --regex --keep-global-symbols %t-globals-regexp.txt %t.o %t.3.o
 # RUN: llvm-readelf --symbols %t.3.o | FileCheck %s --check-prefix=REGEXP
 
+# RUN: llvm-objcopy --regex --keep-global-symbol='^Global[0-9]+([[:space:]]Global6)*$' %t.o %t.4.o
+# RUN: cmp %t.3.o %t.4.o
+
 !ELF
 FileHeader:
   Class:           ELFCLASS64
   Data:            ELFDATA2LSB
   Type:            ET_REL
   Machine:         EM_X86_64
 Sections:
   - Name:          .text

llvm/test/tools/llvm-objcopy/ELF/keep-symbol.test

 # RUN: yaml2obj %s -o %t
 # RUN: llvm-objcopy --discard-all -K foo --keep-symbol bar %t %t2
 # RUN: llvm-objcopy -K foo -N foo -N bar --keep-symbol bar -N baz %t %t3
 # RUN: llvm-objcopy --discard-all --regex -K '^ba.*' %t %t4
 # RUN: llvm-readobj --symbols %t2 | FileCheck %s
 # RUN: llvm-readobj --symbols %t3 | FileCheck %s
 # RUN: llvm-readobj --symbols %t4 | FileCheck %s --check-prefix=REGEX
 
 # RUN: echo 'foo' > %t.symbols
 # RUN: echo 'bar' >> %t.symbols
+# RUN: echo '.* # no regex without --regex' >> %t.symbols
 # RUN: llvm-objcopy --discard-all --keep-symbols %t.symbols %t %t5
 # RUN: llvm-objcopy -K foo -N foo -N bar --keep-symbols %t.symbols -N baz %t %t6
 # RUN: llvm-readobj --symbols %t5 | FileCheck %s
 # RUN: llvm-readobj --symbols %t6 | FileCheck %s
 
+# RUN: echo 'f.*' > %t.symbols.regex
+# RUN: echo '.*ar' >> %t.symbols.regex
+# RUN: llvm-objcopy --discard-all --keep-symbols %t.symbols.regex --regex %t %t7
+# RUN: cmp %t6 %t7
+
 !ELF
 FileHeader:
   Class:           ELFCLASS64
   Data:            ELFDATA2LSB
   Type:            ET_REL
   Machine:         EM_X86_64
 Sections:
   - Name:            .text

llvm/test/tools/llvm-objcopy/ELF/localize.test

 # RUN: yaml2obj %s -o %t
 # RUN: llvm-objcopy \
 # RUN:     --localize-symbol Global \
 # RUN:     -L GlobalUndef \
 # RUN:     -L Local \
 # RUN:     -L Weak \
 # RUN:     -L GlobalCommon \
+# RUN:     -L Missing \
 # RUN:     %t %t2
 # RUN: llvm-readobj --symbols %t2 | FileCheck %s
-# RUN: llvm-objcopy --regex --localize-symbol='.*' %t %t3
+# RUN: llvm-objcopy --regex --localize-symbol='[GLW].*' %t %t3
 # RUN: cmp %t2 %t3
 # RUN: echo "  Global # comment  " > %t-list.txt
 # RUN: echo "GlobalUndef" >> %t-list.txt
 # RUN: echo "Local" >> %t-list.txt
 # RUN: echo "Weak" >> %t-list.txt
 # RUN: echo "GlobalCommon" >> %t-list.txt
+# RUN: echo "Missing" >> %t-list.txt
 # RUN: echo " # comment " >> %t-list.txt
 # RUN: llvm-objcopy --localize-symbols %t-list.txt %t %t4
 # RUN: cmp %t2 %t4
 # RUN: echo "  .*al.* # Global + Local + GlobalCommon " > %t-list2.txt
 # RUN: echo "Weak" >> %t-list2.txt
 # RUN: llvm-objcopy --regex --localize-symbols %t-list2.txt %t %t5
 # RUN: cmp %t2 %t5
 
- Name:     GlobalCommon
     Size:     2
     Binding:  STB_GLOBAL
   - Name:     Weak
     Type:     STT_FUNC
     Size:     8
     Section:  .text
     Value:    0x1008
     Binding:  STB_WEAK
+  - Name:     Unmentioned
+    Section:  .text
+    Binding:  STB_GLOBAL
 
 #CHECK: Symbols [
 #CHECK-NEXT:  Symbol {
 #CHECK-NEXT:    Name:
 #CHECK-NEXT:    Value: 0x0
 #CHECK-NEXT:    Size: 0
 #CHECK-NEXT:    Binding: Local
 #CHECK-NEXT:    Type: None

 #CHECK-NEXT:  }
 #CHECK-NEXT:  Symbol {
 #CHECK-NEXT:    Name: GlobalCommon
 #CHECK-NEXT:    Value: 0x2006
 #CHECK-NEXT:    Size: 2
 #CHECK-NEXT:    Binding: Global
 #CHECK-NEXT:    Type: Object
 #CHECK-NEXT:    Other: 0
-#CHECK-NEXT:    Section: Common (0xF
+#CHECK-NEXT:    Section: Common
+#CHECK-NEXT:  }
+#CHECK-NEXT:  Symbol {
+#CHECK-NEXT:    Name: Unmentioned
+#CHECK-NEXT:    Value:
+#CHECK-NEXT:    Size:
+#CHECK-NEXT:    Binding: Global
+#CHECK-NEXT:    Type:
+#CHECK-NEXT:    Other:
+#CHECK-NEXT:    Section: .text
 #CHECK-NEXT:  }
 #CHECK-NEXT:]

llvm/test/tools/llvm-objcopy/ELF/prefix-alloc-sections.test

 # RUN: yaml2obj %s -o %t
 # RUN: llvm-objcopy --prefix-alloc-sections=.prefix %t %t2
 # RUN: llvm-readobj --sections %t2 | FileCheck %s
 
+## Show that an empty string is permitted as the argument to
+## --prefix-alloc-sections.
+# RUN: llvm-objcopy --prefix-alloc-sections= %t2 %t3
+# RUN: cmp %t2 %t3
+
+## Show that only the last prefix is applied.
+# RUN: llvm-objcopy --prefix-alloc-sections=.bar --prefix-alloc-sections=.prefix %t %t4
+# RUN: cmp %t2 %t4
+
 !ELF
 FileHeader:
   Class:           ELFCLASS64
   Data:            ELFDATA2LSB
   Type:            ET_REL
   Machine:         EM_X86_64
 Sections:
   - Name:            .foo

llvm/test/tools/llvm-objcopy/ELF/prefix-symbols.test

 # RUN: yaml2obj %s -o %t
 # RUN: llvm-objcopy --prefix-symbols prefix %t %t2
 # RUN: llvm-readobj --symbols %t2 | FileCheck %s --check-prefixes=COMMON,BASIC
 # RUN: llvm-objcopy --redefine-sym bar=baz --prefix-symbols prefix %t %t3
 # RUN: llvm-readobj --symbols %t3 | FileCheck %s --check-prefixes=COMMON,REDEF
 
+## Show that an empty string is permitted as the argument to
+## --prefix-symbols.
+# RUN: llvm-objcopy --prefix-symbols= %t2 %t4
+# RUN: cmp %t2 %t4
+
+## Show that the last prefix wins.
+# RUN: llvm-objcopy --prefix-symbols foo --prefix-symbols prefix %t %t5
+# RUN: cmp %t2 %t5
+
 !ELF
 FileHeader:
   Class:           ELFCLASS64
   Data:            ELFDATA2LSB
   Type:            ET_REL
   Machine:         EM_X86_64
 Sections:
   - Name:            .text
     Type:            SHT_PROGBITS
     Flags:           [ SHF_ALLOC, SHF_EXECINSTR ]
     Address:         0x1000
     AddressAlign:    0x0000000000000010
     Size:            64
 Symbols:
   - Name:     foo
     Type:     STT_SECTION
     Section:  .text
   - Name:     bar
     Type:     STT_FILE
     Section:  .text
   - Name:     foobar
     Type:     STT_FUNC
     Section:  .text
     Binding:  STB_GLOBAL
+  - Name:     undef
+    Binding:  STB_GLOBAL
 
 # COMMON: Symbols [
 # COMMON-NEXT:  Symbol {
 # COMMON-NEXT:    Name:
 # COMMON-NEXT:    Value: 0x0
 # COMMON-NEXT:    Size: 0
 # COMMON-NEXT:    Binding: Local
 # COMMON-NEXT:    Type: None

 # COMMON-NEXT:    Name: prefixfoobar
 # COMMON-NEXT:    Value: 0x0
 # COMMON-NEXT:    Size: 0
 # COMMON-NEXT:    Binding: Global
 # COMMON-NEXT:    Type: Function
 # COMMON-NEXT:    Other: 0
 # COMMON-NEXT:    Section: .text
 # COMMON-NEXT:  }
+# COMMON-NEXT:  Symbol {
+# COMMON-NEXT:    Name: prefixundef
+# COMMON-NEXT:    Value: 0x0
+# COMMON-NEXT:    Size: 0
+# COMMON-NEXT:    Binding: Global
+# COMMON-NEXT:    Type: None
+# COMMON-NEXT:    Other: 0
+# COMMON-NEXT:    Section: Undefined
+# COMMON-NEXT:  }
 # COMMON-NEXT:]

llvm/test/tools/llvm-objcopy/ELF/redefine-symbol.test

 # RUN: yaml2obj %s -o %t
-# RUN: llvm-objcopy --redefine-sym foo=oof --redefine-sym empty= %t %t2
+# RUN: llvm-objcopy --redefine-sym foo=oof --redefine-sym =wasempty --redefine-sym empty= %t %t2
 # RUN: llvm-readobj --symbols %t2 | FileCheck %s
 # RUN: echo "  bar   rab #rename bar  " > %t.rename1.txt
 # RUN: echo "foo oof #rename foo  " > %t.rename2.txt
 # RUN: echo "  empty   ytpme #rename empty  " >> %t.rename2.txt
 # RUN: llvm-objcopy --redefine-syms %t.rename1.txt --redefine-syms %t.rename2.txt %t %t4
 # RUN: llvm-readobj --symbols %t4 | FileCheck %s --check-prefix=MULTIPLE-FILES
 
 !ELF
- Name:     bar
     Value:    0x2000
     Size:     4
     Binding:  STB_GLOBAL
   - Name:     empty
     Type:     STT_FUNC
     Section:  .text
     Value:    0x1008
     Binding:  STB_GLOBAL
+  - Type:     STT_OBJECT
+    Section:  .data
+    Value:    0x2008
+    Binding:  STB_GLOBAL
 
 #CHECK: Symbols [
 #CHECK-NEXT:  Symbol {
 #CHECK-NEXT:    Name:
 #CHECK-NEXT:    Value: 0x0
 #CHECK-NEXT:    Size: 0
 #CHECK-NEXT:    Binding: Local
 #CHECK-NEXT:    Type: None

 #CHECK-NEXT:    Value: 0x2000
 #CHECK-NEXT:    Size: 4
 #CHECK-NEXT:    Binding: Global
 #CHECK-NEXT:    Type: Object
 #CHECK-NEXT:    Other: 0
 #CHECK-NEXT:    Section: .data
 #CHECK-NEXT:  }
 #CHECK-NEXT:  Symbol {
-#CHECK-NEXT:    Name: 
+#CHECK-NEXT:    Name: (0)
 #CHECK-NEXT:    Value: 0x1008
 #CHECK-NEXT:    Size: 0
 #CHECK-NEXT:    Binding: Global
 #CHECK-NEXT:    Type: Function
 #CHECK-NEXT:    Other: 0
 #CHECK-NEXT:    Section: .text
 #CHECK-NEXT:  }
+#CHECK-NEXT:  Symbol {
+#CHECK-NEXT:    Name: wasempty
+#CHECK-NEXT:    Value: 0x2008
+#CHECK-NEXT:    Size: 0
+#CHECK-NEXT:    Binding: Global
+#CHECK-NEXT:    Type: Object
+#CHECK-NEXT:    Other: 0
+#CHECK-NEXT:    Section: .data
+#CHECK-NEXT:  }
 
 #MULTIPLE-FILES:        Name: oof
 #MULTIPLE-FILES-NEXT:   Value: 0x1004
 #MULTIPLE-FILES:        Name: rab
 #MULTIPLE-FILES-NEXT:   Value: 0x2000
 #MULTIPLE-FILES:        Name: ytpme
 #MULTIPLE-FILES-NEXT:   Value: 0x1008
+
+## Show that it is not an error if a specified symbol is not present.
+# RUN: llvm-objcopy %t2 %t5 --redefine-sym missing=blah
+# RUN: cmp %t2 %t5
+
+## Show that --redefine-sym doesn't chain together.
+# RUN: llvm-objcopy %t2 %t6 --redefine-sym oof=bob --redefine-sym bob=baz
+# RUN: llvm-readobj %t6 --syms | FileCheck %s --check-prefix=CHAIN --implicit-check-not="Name: baz"
+
+# CHAIN: Name: bob

llvm/test/tools/llvm-objcopy/ELF/rename-section-flag-preserved.test

 # RUN: llvm-readobj --sections %t.merge | FileCheck %s --check-prefixes=CHECK,MERGE,WRITE
 # RUN: llvm-objcopy --rename-section=.foo=.bar,strings %t %t.strings
 # RUN: llvm-readobj --sections %t.strings | FileCheck %s --check-prefixes=CHECK,STRINGS,WRITE
 # RUN: llvm-objcopy --rename-section=.foo=.bar,share %t %t.share
 # RUN: llvm-readobj --sections %t.share | FileCheck %s --check-prefixes=CHECK,WRITE
 # RUN: llvm-objcopy --rename-section=.foo=.bar,exclude %t %t.exclude
 # RUN: llvm-readobj --sections %t.exclude | FileCheck %s --check-prefixes=CHECK,WRITE,EXCLUDE
 
+## Show that if no flags are specified, all existing flags are preserved.
+## Note: GNU objcopy does not preserve the SHF_OS_NONCONFORMING flag.
+# RUN: llvm-objcopy --rename-section=.foo=.bar %t %t.none
+# RUN: llvm-readobj --sections %t.none | FileCheck %s --check-prefixes=CHECK,ALLOC,EXCLUDE,EXEC,MERGE,NONCONFORMING,STRINGS,WRITE
+
 !ELF
 FileHeader:
   Class:           ELFCLASS64
   Data:            ELFDATA2LSB
   Type:            ET_REL
   Machine:         EM_X86_64
 Sections:
   - Name:            .infolink
- Name:            .foo
     Flags:           [ SHF_ALLOC, SHF_COMPRESSED, SHF_EXCLUDE, SHF_EXECINSTR,
                        SHF_GROUP, SHF_INFO_LINK, SHF_LINK_ORDER, SHF_MERGE,
                        SHF_OS_NONCONFORMING, SHF_STRINGS, SHF_TLS, SHF_WRITE ]
     Content:        "a4a4a4a4"
 Symbols:
   - Name:            dummy
     Section:         .group
 
-# CHECK:        Name: .bar
-# CHECK-NEXT:   Type: SHT_PROGBITS
-# CHECK-NEXT:   Flags [
-# ALLOC-NEXT:     SHF_ALLOC (0x2)
-# CHECK-NEXT:     SHF_COMPRESSED (0x800)
-# EXCLUDE-NEXT:   SHF_EXCLUDE (0x80000000)
-# EXEC-NEXT:      SHF_EXECINSTR (0x4)
-# CHECK-NEXT:     SHF_GROUP (0x200)
-# CHECK-NEXT:     SHF_INFO_LINK (0x40)
-# CHECK-NEXT:     SHF_LINK_ORDER (0x80)
-# MERGE-NEXT:     SHF_MERGE (0x10)
-# STRINGS-NEXT:   SHF_STRINGS (0x20)
-# CHECK-NEXT:     SHF_TLS (0x400)
-# WRITE-NEXT:     SHF_WRITE (0x1)
-# CHECK-NEXT:   ]
+# CHECK:              Name: .bar
+# CHECK-NEXT:         Type: SHT_PROGBITS
+# CHECK-NEXT:         Flags [
+# ALLOC-NEXT:           SHF_ALLOC (0x2)
+# CHECK-NEXT:           SHF_COMPRESSED (0x800)
+# EXCLUDE-NEXT:         SHF_EXCLUDE (0x80000000)
+# EXEC-NEXT:            SHF_EXECINSTR (0x4)
+# CHECK-NEXT:           SHF_GROUP (0x200)
+# CHECK-NEXT:           SHF_INFO_LINK (0x40)
+# CHECK-NEXT:           SHF_LINK_ORDER (0x80)
+# MERGE-NEXT:           SHF_MERGE (0x10)
+# NONCONFORMING-NEXT:   SHF_OS_NONCONFORMING (0x100)
+# STRINGS-NEXT:         SHF_STRINGS (0x20)
+# CHECK-NEXT:           SHF_TLS (0x400)
+# WRITE-NEXT:           SHF_WRITE (0x1)
+# CHECK-NEXT:         ]

llvm/test/tools/llvm-objcopy/ELF/rename-section.test

 # RUN: yaml2obj %s -o %t
 # RUN: llvm-objcopy --rename-section=.foo=.bar %t %t2
 # RUN: llvm-readobj --file-headers --sections --section-data %t2 | FileCheck %s
 # RUN: not llvm-objcopy --rename-section=.foo.bar --rename-section=.foo=.other %t %t2 2>&1 | FileCheck %s --check-prefix=BAD-FORMAT
 # RUN: not llvm-objcopy --rename-section=.foo=.bar --rename-section=.foo=.other %t %t2 2>&1 | FileCheck %s --check-prefix=MULTIPLE-RENAMES
 
+## Section renames don't chain:
+# RUN: llvm-objcopy --rename-section=.foo=.bar --rename-section=.bar=.baz %t %t3
+# RUN: cmp %t2 %t3
+
 !ELF
 FileHeader:
   Class:           ELFCLASS64
   Data:            ELFDATA2LSB
   Type:            ET_REL
   Machine:         EM_X86_64
 Sections:
   - Name:            .foo

llvm/test/tools/llvm-objcopy/ELF/set-section-alignment.test

 # CHECK:      Name: .bar
 # CHECK:      AddressAlignment:
 # CHECK-SAME:                   5{{$}}
 # CHECK:      Name: .baz
 # CHECK:      AddressAlignment:
 # CHECK-SAME:                   0{{$}}
 
 ## If a section is specified multiple times, the last wins.
+## Also incidentally show that unmentioned sections are not impacted.
 # RUN: llvm-objcopy --set-section-alignment .foo=4 --set-section-alignment=.foo=7 %t %t.3
 # RUN: llvm-readobj --sections %t.3 | FileCheck --check-prefix=MULTI %s
 
 # MULTI:      Name: .foo
 # MULTI:      AddressAlignment:
 # MULTI-SAME:                   7{{$}}
+# MULTI:      Name: .bar
+# MULTI:      AddressAlignment:
+# MULTI-SAME:                   0{{$}}
+# MULTI:      Name: .baz
+# MULTI:      AddressAlignment:
+# MULTI-SAME:                   4{{$}}
 
 ## Ignore the option if the section does not exist.
 # RUN: llvm-objcopy --set-section-alignment .not_exist=4 %t.3 %t.4
 # RUN: cmp %t.3 %t.4
 
 # RUN: not llvm-objcopy --set-section-alignment=.foo %t /dev/null 2>&1 | \
 # RUN:   FileCheck --check-prefix=MISSING-EQUAL %s
 # MISSING-EQUAL:   error: bad format for --set-section-alignment: missing '='

llvm/test/tools/llvm-objcopy/ELF/set-section-flags-preserved.test

 # RUN: yaml2obj %s -o %t
 
-# Single flags on a section with all flags:
-# RUN: llvm-objcopy --rename-section=.foo=.bar,alloc %t %t.alloc
+## Show which flags are preserved when setting other section flags.
+# RUN: llvm-objcopy --set-section-flags=.foo=alloc %t %t.alloc
 # RUN: llvm-readobj --sections %t.alloc | FileCheck %s --check-prefixes=CHECK,ALLOC,WRITE
-# RUN: llvm-objcopy --rename-section=.foo=.bar,load %t %t.load
+# RUN: llvm-objcopy --set-section-flags=.foo=load %t %t.load
 # RUN: llvm-readobj --sections %t.load | FileCheck %s --check-prefixes=CHECK,WRITE
-# RUN: llvm-objcopy --rename-section=.foo=.bar,noload %t %t.noload
+# RUN: llvm-objcopy --set-section-flags=.foo=noload %t %t.noload
 # RUN: llvm-readobj --sections %t.noload | FileCheck %s --check-prefixes=CHECK,WRITE
-# RUN: llvm-objcopy --rename-section=.foo=.bar,readonly %t %t.readonly
+# RUN: llvm-objcopy --set-section-flags=.foo=readonly %t %t.readonly
 # RUN: llvm-readobj --sections %t.readonly | FileCheck %s --check-prefixes=CHECK
-# RUN: llvm-objcopy --rename-section=.foo=.bar,debug %t %t.debug
+# RUN: llvm-objcopy --set-section-flags=.foo=debug %t %t.debug
 # RUN: llvm-readobj --sections %t.debug | FileCheck %s --check-prefixes=CHECK,WRITE
-# RUN: llvm-objcopy --rename-section=.foo=.bar,code %t %t.code
+# RUN: llvm-objcopy --set-section-flags=.foo=code %t %t.code
 # RUN: llvm-readobj --sections %t.code | FileCheck %s --check-prefixes=CHECK,EXEC,WRITE
-# RUN: llvm-objcopy --rename-section=.foo=.bar,data %t %t.data
+# RUN: llvm-objcopy --set-section-flags=.foo=data %t %t.data
 # RUN: llvm-readobj --sections %t.data | FileCheck %s --check-prefixes=CHECK,WRITE
-# RUN: llvm-objcopy --rename-section=.foo=.bar,rom %t %t.rom
+# RUN: llvm-objcopy --set-section-flags=.foo=rom %t %t.rom
 # RUN: llvm-readobj --sections %t.rom | FileCheck %s --check-prefixes=CHECK,WRITE
-# RUN: llvm-objcopy --rename-section=.foo=.bar,contents %t %t.contents
+# RUN: llvm-objcopy --set-section-flags=.foo=contents %t %t.contents
 # RUN: llvm-readobj --sections %t.contents | FileCheck %s --check-prefixes=CHECK,WRITE
-# RUN: llvm-objcopy --rename-section=.foo=.bar,merge %t %t.merge
+# RUN: llvm-objcopy --set-section-flags=.foo=merge %t %t.merge
 # RUN: llvm-readobj --sections %t.merge | FileCheck %s --check-prefixes=CHECK,MERGE,WRITE
-# RUN: llvm-objcopy --rename-section=.foo=.bar,strings %t %t.strings
+# RUN: llvm-objcopy --set-section-flags=.foo=strings %t %t.strings
 # RUN: llvm-readobj --sections %t.strings | FileCheck %s --check-prefixes=CHECK,STRINGS,WRITE
-# RUN: llvm-objcopy --rename-section=.foo=.bar,share %t %t.share
+# RUN: llvm-objcopy --set-section-flags=.foo=share %t %t.share
 # RUN: llvm-readobj --sections %t.share | FileCheck %s --check-prefixes=CHECK,WRITE
-# RUN: llvm-objcopy --rename-section=.foo=.bar,exclude %t %t.exclude
+# RUN: llvm-objcopy --set-section-flags=.foo=exclude %t %t.exclude
 # RUN: llvm-readobj --sections %t.exclude | FileCheck %s --check-prefixes=CHECK,WRITE,EXCLUDE
 
 !ELF
 FileHeader:
   Class:           ELFCLASS64
   Data:            ELFDATA2LSB
   Type:            ET_REL
   Machine:         EM_X86_64
- Name:            .foo
     Flags:           [ SHF_ALLOC, SHF_COMPRESSED, SHF_EXCLUDE, SHF_EXECINSTR,
                        SHF_GROUP, SHF_INFO_LINK, SHF_LINK_ORDER, SHF_MERGE,
                        SHF_OS_NONCONFORMING, SHF_STRINGS, SHF_TLS, SHF_WRITE ]
     Content:        "a4a4a4a4"
 Symbols:
   - Name:            dummy
     Section:         .group
 
-# CHECK:        Name: .bar
-# CHECK-NEXT:   Type: SHT_PROGBITS
-# CHECK-NEXT:   Flags [
-# ALLOC-NEXT:     SHF_ALLOC (0x2)
-# CHECK-NEXT:     SHF_COMPRESSED (0x800)
-# EXCLUDE-NEXT:   SHF_EXCLUDE (0x80000000)
-# EXEC-NEXT:      SHF_EXECINSTR (0x4)
-# CHECK-NEXT:     SHF_GROUP (0x200)
-# CHECK-NEXT:     SHF_INFO_LINK (0x40)
-# CHECK-NEXT:     SHF_LINK_ORDER (0x80)
-# MERGE-NEXT:     SHF_MERGE (0x10)
-# STRINGS-NEXT:   SHF_STRINGS (0x20)
-# CHECK-NEXT:     SHF_TLS (0x400)
-# WRITE-NEXT:     SHF_WRITE (0x1)
-# CHECK-NEXT:   ]
+# CHECK:              Name: .foo
+# CHECK-NEXT:         Type: SHT_PROGBITS
+# CHECK-NEXT:         Flags [
+# ALLOC-NEXT:           SHF_ALLOC (0x2)
+# CHECK-NEXT:           SHF_COMPRESSED (0x800)
+# EXCLUDE-NEXT:         SHF_EXCLUDE (0x80000000)
+# EXEC-NEXT:            SHF_EXECINSTR (0x4)
+# CHECK-NEXT:           SHF_GROUP (0x200)
+# CHECK-NEXT:           SHF_INFO_LINK (0x40)
+# CHECK-NEXT:           SHF_LINK_ORDER (0x80)
+# MERGE-NEXT:           SHF_MERGE (0x10)
+# STRINGS-NEXT:         SHF_STRINGS (0x20)
+# CHECK-NEXT:           SHF_TLS (0x400)
+# WRITE-NEXT:           SHF_WRITE (0x1)
+# CHECK-NEXT:         ]

llvm/test/tools/llvm-objcopy/ELF/set-section-flags.test

 # RUN: llvm-readobj --sections %t.upper | FileCheck %s --check-prefixes=CHECK,PROGBITS,ALLOC,EXEC,MERGE,STRINGS
 
 # Mixed-case flags:
 # RUN: llvm-objcopy --set-section-flags=.foo=aLlOc,LoAd,NoLoad,rEAdONly,Debug,codE,DaTa,rOm,CoNtEnTs,mErGe,sTRINGs,SharE \
 # RUN:   --set-section-flags=.baz=aLlOc,LoAd,NoLoad,rEAdONly,Debug,codE,DaTa,rOm,CoNtEnTs,mErGe,sTRINGs,SharE \
 # RUN:   --set-section-flags=.rela.baz=aLlOc,LoAd,NoLoad,rEAdONly,Debug,codE,DaTa,rOm,CoNtEnTs,mErGe,sTRINGs,SharE %t %t.mixed
 # RUN: llvm-readobj --sections %t.mixed | FileCheck %s --check-prefixes=CHECK,PROGBITS,ALLOC,EXEC,MERGE,STRINGS
 
+## Unspecified sections are not affected:
+# RUN: llvm-objcopy --set-section-flags=.foo=alloc %t %t.unspecified
+# RUN: llvm-readobj --sections %t.unspecified | FileCheck %s --check-prefixes=UNSPECIFIED
+
 !ELF
 FileHeader:
   Class:           ELFCLASS64
   Data:            ELFDATA2LSB
   Type:            ET_REL
   Machine:         EM_X86_64
 Sections:
   - Name:            .foo

 # EXCLUDE-NEXT:    SHF_EXCLUDE (0x80000000)
 # WRITE-NEXT:      SHF_WRITE (0x1)
 # CHECK-NEXT:    ]
 
 # BAD-FORMAT: bad format for --set-section-flags: missing '='
 # MULTIPLE-SETS: --set-section-flags set multiple times for section '.foo'
 
 # BAD-FLAG: unrecognized section flag 'xyzzy'. Flags supported for GNU compatibility: alloc, load, noload, readonly, exclude, debug, code, data, rom, share, contents, merge, strings
+
+# UNSPECIFIED:      Name: .foo
+# UNSPECIFIED-NEXT: Type: SHT_PROGBITS
+# UNSPECIFIED-NEXT: Flags [
+# UNSPECIFIED-NEXT:   SHF_ALLOC (0x2)
+# UNSPECIFIED-NEXT:   SHF_WRITE (0x1)
+# UNSPECIFIED-NEXT: ]
+
+# UNSPECIFIED:      Name: .baz
+# UNSPECIFIED-NEXT: Type: SHT_NOBITS
+# UNSPECIFIED-NEXT: Flags [ (0x0)
+# UNSPECIFIED-NEXT: ]
+
+# UNSPECIFIED:      Name: .rela.baz
+# UNSPECIFIED-NEXT: Type: SHT_RELA
+# UNSPECIFIED-NEXT: Flags [ (0x0)
+# UNSPECIFIED-NEXT: ]

llvm/test/tools/llvm-objcopy/ELF/strip-preserve-mtime.test

-# Note: ls -l prints the modified timestamp
+## Note: ls -l prints the modified timestamp
 
-# Preserve dates when stripping to an output file.
+## Preserve dates when stripping to an output file.
 # RUN: yaml2obj %s -o %t.1.o
 # RUN: touch -m -t 199705050555.55 %t.1.o
 # RUN: llvm-strip -p %t.1.o -o %t-preserved.1.o
 # RUN: ls -l %t-preserved.1.o | FileCheck %s --check-prefix=CHECK-PRESERVE-MTIME
 # Check that the stripped output is in fact a valid object file.
 # RUN: llvm-readobj %t-preserved.1.o
 
-# Preserve dates available via objcopy interface as well.
+## Preserve dates available via objcopy interface as well.
 # RUN: yaml2obj %s -o %t.2.o
 # RUN: touch -m -t 199705050555.55 %t.2.o
 # RUN: llvm-objcopy -p %t.2.o %t-preserved.2.o
 # RUN: ls -l %t-preserved.2.o | FileCheck %s --check-prefix=CHECK-PRESERVE-MTIME
 # RUN: llvm-readobj %t-preserved.2.o
 
-# Preserve dates when stripping in place.
+## Preserve dates when stripping in place.
 # RUN: yaml2obj %s -o %t.3.o
 # RUN: touch -m -t 199705050555.55 %t.3.o
 # RUN: llvm-strip -p %t.3.o
 # RUN: ls -l %t.3.o | FileCheck %s --check-prefix=CHECK-PRESERVE-MTIME
 # RUN: llvm-readobj %t.3.o
 
-# Without -p set, don't preserve dates.
+## Without -p set, don't preserve dates.
 # RUN: yaml2obj %s -o %t.4.o
 # RUN: touch -m -t 199705050555.55 %t.4.o
 # RUN: llvm-strip %t.4.o
 # RUN: ls -l %t.4.o | FileCheck %s --check-prefix=CHECK-NO-PRESERVE-MTIME
 # RUN: llvm-readobj %t.4.o
 
-# Preserve dates in archives.
+## Preserve dates in archives.
 # RUN: yaml2obj %s -o %t.5.o
 # RUN: rm -f %t.a
 # RUN: llvm-ar cr %t.a %t.5.o
 # RUN: touch -m -t 199705050555.55 %t.a
 # RUN: llvm-strip -p %t.a
 # RUN: ls -l %t.a | FileCheck %s --check-prefix=CHECK-PRESERVE-MTIME
 # RUN: llvm-readobj %t.a
 
-# Preserve dates in split DWO files.
+## Preserve dates in split DWO files.
 # RUN: cp %p/Inputs/dwarf.dwo %t-input.dwo
 # RUN: touch -m -t 199705050555.55 %t-input.dwo
 # RUN: llvm-objcopy -p --split-dwo=%t-dwo %t-input.dwo %t-nondwo
 # RUN: ls -l %t-dwo | FileCheck %s --check-prefix=CHECK-PRESERVE-MTIME
 # RUN: llvm-readobj %t-dwo
 # RUN: ls -l %t-nondwo | FileCheck %s --check-prefix=CHECK-PRESERVE-MTIME
 # RUN: llvm-readobj %t-nondwo
 
+## --preserve-dates and -p are aliases.
+# RUN: llvm-strip --preserve-dates %t.1.o -o %t-preserved.1.alias.o
+# RUN: ls -l %t-preserved.1.alias.o | FileCheck %s --check-prefix=CHECK-PRESERVE-MTIME
+# RUN: cmp %t-preserved.1.alias.o %t-preserved.1.o
+# RUN: llvm-objcopy --preserve-dates %t.2.o %t-preserved.2.alias.o
+# RUN: ls -l %t-preserved.2.alias.o | FileCheck %s --check-prefix=CHECK-PRESERVE-MTIME
+# RUN: cmp %t-preserved.2.o %t-preserved.2.alias.o
+
 # CHECK-PRESERVE-MTIME:        {{[[:space:]]1997}}
 # CHECK-NO-PRESERVE-MTIME-NOT: {{[[:space:]]1997}}
 
 !ELF
 FileHeader:
   Class:           ELFCLASS64
   Data:            ELFDATA2LSB
   Type:            ET_REL
   Machine:         EM_X86_64
 Sections:
   - Name:            .text
     Type:            SHT_PROGBITS
     Flags:           [ SHF_ALLOC, SHF_EXECINSTR ]

llvm/test/tools/llvm-objcopy/ELF/strip-symbol.test

 # RUN: yaml2obj %s -o %t
 # RUN: llvm-objcopy --strip-symbol baz -N bar %t %t2
 # RUN: llvm-readobj --symbols --sections %t2 | FileCheck %s
 # RUN: llvm-strip --strip-symbol baz -N bar %t -o %t3
 # RUN: cmp %t2 %t3
-# RUN: llvm-strip --regex --strip-symbol '^b.*' -N bar %t -o %t4
-# RUN: cmp %t3 %t4
+# RUN: llvm-objcopy --regex --strip-symbol '^b.*' -N bar %t %t4
+# RUN: cmp %t2 %t4
+# RUN: llvm-strip --regex --strip-symbol '^b.*' -N bar %t -o %t5
+# RUN: cmp %t3 %t5
 # RUN: echo " bar # bar" > %t-list.txt
 # RUN: echo " baz # baz" >> %t-list.txt
 # RUN: echo " # no symbol" >> %t-list.txt
-# RUN: llvm-objcopy --strip-symbols %t-list.txt %t %t5
-# RUN: cmp %t3 %t5
-# RUN: echo "b.* # bar & baz" > %t-list2.txt
-# RUN: llvm-objcopy --regex --strip-symbols %t-list2.txt %t %t6
+# RUN: llvm-objcopy --strip-symbols %t-list.txt %t %t6
 # RUN: cmp %t3 %t6
+# RUN: echo "b.* # bar & baz" > %t-list2.txt
+# RUN: llvm-objcopy --regex --strip-symbols %t-list2.txt %t %t7
+# RUN: cmp %t3 %t7
 
 !ELF
 FileHeader:
   Class:           ELFCLASS64
   Data:            ELFDATA2LSB
   Type:            ET_REL
   Machine:         EM_X86_64
 Sections:

llvm/test/tools/llvm-objcopy/ELF/strip-unneeded.test

 # RUN: yaml2obj %s -o %t
 # RUN: cp %t %t1
 # RUN: llvm-objcopy --strip-unneeded %t %t2
-# Verify that llvm-objcopy has not modified the input.
+## Verify that llvm-objcopy has not modified the input.
 # RUN: cmp %t %t1
 # RUN: llvm-readobj --symbols %t2 | FileCheck %s
 
-# Verify that --keep-file-symbols works together with --strip-unneeded
+## Verify that --keep-file-symbols works together with --strip-unneeded
 # RUN: llvm-objcopy --keep-file-symbols --strip-unneeded %t %t2b
-# RUN: llvm-readobj --symbols %t2b | FileCheck %s --check-prefix=FILESYM
+# RUN: llvm-readobj --symbols %t2b | FileCheck %s --check-prefixes=CHECK,FILESYM
 
 # RUN: llvm-objcopy --strip-unneeded-symbol=bar \
 # RUN:              %t %t3
 # RUN: llvm-readobj --symbols %t3 | FileCheck %s --check-prefixes=STRIP-BAR,REMAIN
 
 # RUN: llvm-objcopy --regex --strip-unneeded-symbol='.*' %t %t4
 # RUN: cmp %t2 %t4
 
+## Verify that --strip-unneeded-symbols removes all unneeded symbols listed in
+## the file, but not those that aren't.
+## In this case, fileSymbol isn't mentioned (so isn't removed), barbaz is
+## mentioned, but isn't removed (because it is needed) and bar, foobar and
+## foobaz are mentioned and removed.
 # RUN: echo " bar # bar " > %t.list.txt
 # RUN: echo "foobar" >> %t.list.txt
 # RUN: echo "foobaz" >> %t.list.txt
 # RUN: echo " # comment " >> %t.list.txt
+# RUN: echo "barbaz" >> %t.list.txt
 # RUN: llvm-objcopy --strip-unneeded-symbols %t.list.txt %t %t5
 # RUN: cmp %t2b %t5
 
 # RUN: echo " .* # * - remove all " > %t.list2.txt
 # RUN: llvm-objcopy --regex --strip-unneeded-symbols %t.list2.txt %t %t6
 # RUN: cmp %t2 %t6
 
-# Verify that llvm-strip modifies the symbol table the same way.
+## Verify that llvm-strip modifies the symbol table the same way.
 # RUN: llvm-strip --strip-unneeded %t
 # RUN: cmp %t %t2
 
 !ELF
 FileHeader:
   Class:           ELFCLASS64
   Data:            ELFDATA2LSB
   Type:            ET_REL
- Name:     bar
     Value:    0x1008
   - Name:     barfoo
     Type:     STT_FUNC
     Size:     8
     Section:  .text
     Value:    0x1010
   - Name:     fileSymbol
     Type:     STT_FILE
+    Index:    SHN_ABS
   - Name:     sectionSymbol
     Type:     STT_SECTION
   - Name:     foobar
     Type:     STT_FUNC
     Binding:  STB_GLOBAL
   - Name:     barbaz
     Type:     STT_FUNC
     Size:     8

 #CHECK-NEXT:    Name: barfoo
 #CHECK-NEXT:    Value: 0x1010
 #CHECK-NEXT:    Size: 8
 #CHECK-NEXT:    Binding: Local
 #CHECK-NEXT:    Type: Function
 #CHECK-NEXT:    Other: 0
 #CHECK-NEXT:    Section: .text
 #CHECK-NEXT:  }
+#FILESYM-NEXT:Symbol {
+#FILESYM-NEXT:  Name: fileSymbol
+#FILESYM-NEXT:  Value: 0x0
+#FILESYM-NEXT:  Size: 0
+#FILESYM-NEXT:  Binding: Local
+#FILESYM-NEXT:  Type: File
+#FILESYM-NEXT:  Other: 0
+#FILESYM-NEXT:  Section: Absolute
+#FILESYM-NEXT:}
 #CHECK-NEXT:  Symbol {
 #CHECK-NEXT:    Name: sectionSymbol
 #CHECK-NEXT:    Value: 0x0
 #CHECK-NEXT:    Size: 0
 #CHECK-NEXT:    Binding: Local
 #CHECK-NEXT:    Type: Section
 #CHECK-NEXT:    Other: 0
 #CHECK-NEXT:    Section: Undefined

 #CHECK-NEXT:    Size: 8
 #CHECK-NEXT:    Binding: Weak
 #CHECK-NEXT:    Type: Function
 #CHECK-NEXT:    Other: 0
 #CHECK-NEXT:    Section: .text
 #CHECK-NEXT:  }
 #CHECK-NEXT:]
 
-#FILESYM:       Name: fileSymbol
-#FILESYM-NEXT:  Value: 0x0
 
 #STRIP-BAR-NOT: Name: bar ({{.*}})
 #REMAIN: Name: foobar
 #REMAIN: Name: foobaz

llvm/test/tools/llvm-objcopy/ELF/symtab-error-on-remove-strtab.test

FileHeader:
   Type:            ET_REL
   Machine:         EM_X86_64
 Symbols: []
 
 # ERR1: error: '[[INPUT]]': string table '.strtab' cannot be removed because it is referenced by the symbol table '.symtab'
 # ERR2: error: '[[INPUT]]': string table '.strtab' cannot be removed because it is referenced by the symbol table '.symtab'
 
 # RUN: llvm-objcopy --allow-broken-links -R .strtab %t %t4
-# RUN: llvm-objdump --section-headers %t4 | FileCheck %s --check-prefix=SECTIONS --implicit-check-not=.strtab
+# RUN: llvm-readobj --section-headers %t4 | FileCheck %s --check-prefix=SECTIONS --implicit-check-not=.strtab
 # RUN: cp %t %t5
 # RUN: llvm-strip --no-strip-all --allow-broken-links -R .strtab %t %t5
-# RUN: llvm-objdump --section-headers %t5 | FileCheck %s --check-prefix=SECTIONS --implicit-check-not=.strtab
+# RUN: llvm-readobj --section-headers %t5 | FileCheck %s --check-prefix=SECTIONS --implicit-check-not=.strtab
 
-# SECTIONS: .symtab
+# SECTIONS:      Name: .symtab
+# SECTIONS:      Link
+# SECTIONS-SAME:     : 0

llvm/test/tools/llvm-objcopy/ELF/weaken.test

 # RUN: yaml2obj %s -o %t
-# RUN: llvm-objcopy --weaken-symbol Global -W Local -W Weak %t %t2
+# RUN: llvm-objcopy --weaken-symbol Global -W Local -W Weak -W Missing %t %t2
 # RUN: llvm-readobj --symbols %t2 | FileCheck %s
-# RUN: llvm-objcopy --regex --weaken-symbol='.*' %t %t3
+# RUN: llvm-objcopy --regex --weaken-symbol='[LGW].*' %t %t3
 # RUN: cmp %t2 %t3
 # RUN: echo "  Global  # comment" > %t-list.txt
 # RUN: echo "Local" >> %t-list.txt
 # RUN: echo "Weak" >> %t-list.txt
+# RUN: echo "Missing" >> %t-list.txt
 # RUN: echo " # comment" >> %t-list.txt
 # RUN: llvm-objcopy --weaken-symbols %t-list.txt %t %t4
 # RUN: cmp %t2 %t4
 # RUN: echo ".*al # Global + Local == .*al" > %t-list2.txt
 # RUN: echo "Weak # weak" >> %t-list2.txt
 # RUN: llvm-objcopy --regex --weaken-symbols %t-list2.txt %t %t5
 # RUN: cmp %t2 %t5
 
- Name:     Global
     Value:    0x1010
     Binding:  STB_GLOBAL
   - Name:     Weak
     Type:     STT_FUNC
     Size:     8
     Section:  .text
     Value:    0x1008
     Binding:  STB_WEAK
+  - Name:     Unspecified
+    Section:  .text
+    Binding:  STB_GLOBAL
 
 #CHECK: Symbols [
 #CHECK-NEXT:  Symbol {
 #CHECK-NEXT:    Name:
 #CHECK-NEXT:    Value: 0x0
 #CHECK-NEXT:    Size: 0
 #CHECK-NEXT:    Binding: Local
 #CHECK-NEXT:    Type: None

 #CHECK-NEXT:    Name: Weak
 #CHECK-NEXT:    Value: 0x1008
 #CHECK-NEXT:    Size: 8
 #CHECK-NEXT:    Binding: Weak
 #CHECK-NEXT:    Type: Function
 #CHECK-NEXT:    Other: 0
 #CHECK-NEXT:    Section: .text
 #CHECK-NEXT:  }
+#CHECK-NEXT:  Symbol {
+#CHECK-NEXT:    Name: Unspecified
+#CHECK-NEXT:    Value: 0x0
+#CHECK-NEXT:    Size: 0
+#CHECK-NEXT:    Binding: Global
+#CHECK-NEXT:    Type: None
+#CHECK-NEXT:    Other: 0
+#CHECK-NEXT:    Section: .text
+#CHECK-NEXT:  }
 #CHECK-NEXT:]

llvm/test/tools/llvm-objcopy/ELF/wildcard-flags.test

 # RUN: cmp %t.ksym.1.o %t.ksym.2.o
 
 # RUN: llvm-objcopy --discard-all -w --keep-symbol='f*' %t.o %t.ksym.3.o
 # RUN: llvm-readobj --symbols %t.ksym.3.o \
 # RUN:   | FileCheck %s --implicit-check-not=Name: --check-prefixes=CHECK,FOO-SYM
 # RUN: llvm-strip --discard-all -w --keep-symbol='f*' %t.o -o %t.ksym.4.o
 # RUN: cmp %t.ksym.3.o %t.ksym.4.o
 
+## --keep-symbols:
+# RUN: echo 'f*' > %t-fstar.txt
+# RUN: llvm-objcopy --discard-all --keep-symbols=%t-fstar.txt %t.o %t.ksym.5.o
+# RUN: cmp %t.ksym.5.o %t.ksym.1.o
+
+# RUN: llvm-objcopy --discard-all -w --keep-symbols=%t-fstar.txt %t.o %t.ksym.6.o
+# RUN: cmp %t.ksym.6.o %t.ksym.3.o
+
 ## --localize-symbol:
 ## Note: Use %t.globsym.2.o instead of %t.o since those symbols are global.
 # RUN: llvm-objcopy --localize-symbol='*' %t.globsym.2.o %t.localsym.1.o
 # RUN: llvm-readobj --symbols %t.localsym.1.o \
 # RUN:   | FileCheck %s --implicit-check-not=Name: \
 # RUN:       --check-prefixes=CHECK,GLOBAL,FOO-SYM,BAR-SYM
 
 # RUN: llvm-objcopy -w --localize-symbol='*' %t.globsym.2.o %t.localsym.2.o
 # RUN: llvm-readobj --symbols %t.localsym.2.o \
 # RUN:   | FileCheck %s --implicit-check-not=Name: \
 # RUN:       --check-prefixes=CHECK,LOCAL,FOO-SYM,BAR-SYM
 
+## --localize-symbols:
+# RUN: echo '*' > %t-star.txt
+# RUN: llvm-objcopy --localize-symbols=%t-star.txt %t.globsym.2.o %t.localsym.3.o
+# RUN: cmp %t.localsym.3.o %t.localsym.1.o
+
+# RUN: llvm-objcopy -w --localize-symbols=%t-star.txt %t.globsym.2.o %t.localsym.4.o
+# RUN: cmp %t.localsym.4.o %t.localsym.2.o
+
 ## --strip-symbol:
 # RUN: llvm-objcopy --strip-symbol='f*' %t.o %t.stripsym.1.o
 # RUN: llvm-readobj --symbols %t.stripsym.1.o \
 # RUN:   | FileCheck %s --implicit-check-not=Name: --check-prefixes=CHECK,FOO-SYM,BAR-SYM
 # RUN: llvm-strip --strip-symbol='f*' %t.o -o %t.stripsym.2.o
 # RUN: cmp %t.stripsym.1.o %t.stripsym.2.o
 
 # RUN: llvm-objcopy -w --strip-symbol='f*' %t.o %t.stripsym.3.o
 # RUN: llvm-readobj --symbols %t.stripsym.3.o \
 # RUN:   | FileCheck %s --implicit-check-not=Name: --check-prefixes=CHECK,BAR-SYM
 # RUN: llvm-strip -w --strip-symbol='f*' %t.o -o %t.stripsym.4.o
 # RUN: cmp %t.stripsym.3.o %t.stripsym.4.o
 
+## --strip-symbols:
+# RUN: llvm-objcopy --strip-symbols=%t-fstar.txt %t.o %t.stripsym.5.o
+# RUN: cmp %t.stripsym.5.o %t.stripsym.1.o
+
+# RUN: llvm-objcopy -w --strip-symbols=%t-fstar.txt %t.o %t.stripsym.6.o
+# RUN: cmp %t.stripsym.6.o %t.stripsym.3.o
+
 ## --strip-unneeded-symbol:
 # RUN: llvm-objcopy --strip-unneeded-symbol='f*' %t.o %t.stripunsym.1.o
 # RUN: llvm-readobj --symbols %t.stripunsym.1.o \
 # RUN:   | FileCheck %s --implicit-check-not=Name: --check-prefixes=CHECK,FOO-SYM,BAR-SYM
 
 # RUN: llvm-objcopy -w --strip-unneeded-symbol='f*' %t.o %t.stripunsym.2.o
 # RUN: llvm-readobj --symbols %t.stripunsym.2.o \
 # RUN:   | FileCheck %s --implicit-check-not=Name: --check-prefixes=CHECK,BAR-SYM
 
+## --strip-unneded-symbols:
+# RUN: llvm-objcopy --strip-unneeded-symbols=%t-fstar.txt %t.o %t.stripunsym.3.o
+# RUN: cmp %t.stripunsym.3.o %t.stripunsym.1.o
+
+# RUN: llvm-objcopy -w --strip-unneeded-symbols=%t-fstar.txt %t.o %t.stripunsym.4.o
+# RUN: cmp %t.stripunsym.4.o %t.stripunsym.2.o
+
 ## --weaken-symbol:
 ## Note: Use %t.globsym.2.o instead of %t.o since those symbols are global.
 # RUN: llvm-objcopy --weaken-symbol='*' %t.globsym.2.o %t.weaksym.1.o
 # RUN: llvm-readobj --symbols %t.weaksym.1.o \
 # RUN:   | FileCheck %s --implicit-check-not=Name: \
 # RUN:       --check-prefixes=CHECK,GLOBAL,FOO-SYM,BAR-SYM
 
 # RUN: llvm-objcopy -w --weaken-symbol='*' %t.globsym.2.o %t.weaksym.2.o
 # RUN: llvm-readobj --symbols %t.weaksym.2.o \
 # RUN:   | FileCheck %s --implicit-check-not=Name: \
 # RUN:       --check-prefixes=CHECK,WEAK,FOO-SYM,BAR-SYM
 
+## --weaken-symbols:
+# RUN: llvm-objcopy --weaken-symbols=%t-star.txt %t.globsym.2.o %t.weaksym.3.o
+# RUN: cmp %t.weaksym.3.o %t.weaksym.1.o
+
+# RUN: llvm-objcopy -w --weaken-symbols=%t-star.txt %t.globsym.2.o %t.weaksym.4.o
+# RUN: cmp %t.weaksym.4.o %t.weaksym.2.o
+
 ## --keep-global-symbol:
 ## Note: Use %t.globsym.2.o instead of %t.o since those symbols are global.
 # RUN: llvm-objcopy --keep-global-symbol='*' %t.globsym.2.o %t.keepgsym.1.o
 # RUN: llvm-readobj --symbols %t.keepgsym.1.o \
 # RUN:   | FileCheck %s --implicit-check-not=Name: \
 # RUN:       --check-prefixes=CHECK,LOCAL,FOO-SYM,BAR-SYM
 
 # RUN: llvm-objcopy -w --keep-global-symbol='*' %t.globsym.2.o %t.keepgsym.2.o
 # RUN: llvm-readobj --symbols %t.keepgsym.2.o \
 # RUN:   | FileCheck %s --implicit-check-not=Name: \
 # RUN:       --check-prefixes=CHECK,GLOBAL,FOO-SYM,BAR-SYM
 
+## --keep-global-symbols:
+# RUN: llvm-objcopy --keep-global-symbols=%t-star.txt %t.globsym.2.o %t.keepgsym.3.o
+# RUN: cmp %t.keepgsym.3.o %t.keepgsym.1.o
+
+# RUN: llvm-objcopy -w --keep-global-symbols=%t-star.txt %t.globsym.2.o %t.keepgsym.4.o
+# RUN: cmp %t.keepgsym.4.o %t.keepgsym.2.o
+
 ## Check that -w is accepted as an alias for --wildcard.
-# RUN: llvm-objcopy --wildcard --keep-global-symbol='*' %t.globsym.2.o %t.keepgsym.3.o
-# RUN: cmp %t.keepgsym.2.o %t.keepgsym.3.o
+# RUN: llvm-objcopy --wildcard --keep-global-symbol='*' %t.globsym.2.o %t.keepgsym.5.o
+# RUN: cmp %t.keepgsym.2.o %t.keepgsym.5.o
 
 # CHECK:   LoadName:
 # CHECK:   Name: (0)
 
 # FOO-SEC: Name: .foo
 
 # FOO-SYM: Name: foo
 # GLOBAL:  Binding: Global