Page MenuHomePhabricator

edd (Edd Dawson)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 27 2017, 9:36 AM (216 w, 2 d)

Recent Activity

Jan 25 2021

edd added a comment to rG8aa3ee241d52: [CSSPGO] LTO option for pseudo probe.

Hi there,

Jan 25 2021, 9:25 AM

Nov 4 2020

edd committed rG1f78ab0ae63c: [lld][ELF][test] test LTO-removed symbols are not in symtab (authored by edd).
[lld][ELF][test] test LTO-removed symbols are not in symtab
Nov 4 2020, 12:09 PM
edd closed D90680: [lld][ELF][test] test LTO-removed symbols are not in symtab.
Nov 4 2020, 12:09 PM · Restricted Project
edd updated the diff for D90680: [lld][ELF][test] test LTO-removed symbols are not in symtab.

I have moved the checks to the suggested location - thanks.

Nov 4 2020, 2:04 AM · Restricted Project

Nov 3 2020

edd requested review of D90680: [lld][ELF][test] test LTO-removed symbols are not in symtab.
Nov 3 2020, 5:41 AM · Restricted Project

Oct 21 2020

edd added a comment to D89789: [LLD][ELF] Add --force-tls-variant2 option.

I work with Andrew.

Oct 21 2020, 7:45 AM

Oct 7 2020

edd added a comment to D88986: [test][MC] Use %python in llvm/test/MC/COFF/bigobj.py.

Thanks!

Oct 7 2020, 12:18 PM · Restricted Project
edd added a comment to D88986: [test][MC] Use %python in llvm/test/MC/COFF/bigobj.py.

I don't yet have commit access - will request after this. Could I please trouble you to do the honors on my behalf?

Oct 7 2020, 10:41 AM · Restricted Project
edd requested review of D88986: [test][MC] Use %python in llvm/test/MC/COFF/bigobj.py.
Oct 7 2020, 10:27 AM · Restricted Project

Sep 21 2020

edd added a comment to D88023: [LLD][ELF][test] Fix CHECKs in map-file test.

I need the name and email you'd like to use to set patch author info.
E.g:

Name Surname <namesurname@mail.com>
Sep 21 2020, 8:00 AM · Restricted Project
edd added a comment to D88023: [LLD][ELF][test] Fix CHECKs in map-file test.

Thanks for the review. I don't have commit access. Would you be willing to commit on my behalf?

Sep 21 2020, 7:48 AM · Restricted Project
edd requested review of D88023: [LLD][ELF][test] Fix CHECKs in map-file test.
Sep 21 2020, 7:38 AM · Restricted Project

Aug 24 2020

edd added a comment to D85867: [ELF] Assign file offsets of non-SHF_ALLOC after SHF_ALLOC and set sh_addr=0 to non-SHF_ALLOC.

Apologies for not keeping on top of this while I was off work. FTR, looks good. Thanks for taking the time to look at it.

Aug 24 2020, 6:45 AM · Restricted Project

Oct 2 2019

edd added a comment to D68033: [llvm-ar] Make paths case insensitive when on windows.

NTFS and the layers above it don't normalize filenames (in the Unicode sense) and I believe that path names are stored as sequences of 16bit integers, without any guarantee of being well-formed UCS-2/UTF_16. So I don't think that a comparison via locale-aware case folding would be correct for paths. I don't have sources for this, it's just what I recall from having done experiments some time ago.

Oct 2 2019, 3:20 AM · Restricted Project

Aug 22 2019

edd added a comment to D66426: [lld] Enable a watermark of loadable sections to be generated and placed in a note section.

Hi all,

Aug 22 2019, 8:53 AM · Restricted Project