User Details
- User Since
- Mar 2 2017, 6:37 AM (203 w, 4 d)
Fri, Jan 22
Apart from the nits already pointed out by @jhenderson, LGTM.
Thu, Jan 21
This change broke one of our downstream tests and the issue can be reproduced with the following test:
# REQUIRES: x86
Oct 26 2020
Oct 22 2020
Update to clarify the purpose of the initial call to writeSymbolTableHeader.
Updated to address review comments and updated to add better testing. Whilst adding this testing, found another bug in the detection code; it was also not accounting for the size of the file signature!
Oct 21 2020
Oct 20 2020
Oct 15 2020
Oct 14 2020
Oct 13 2020
Ping.
Oct 8 2020
Oct 6 2020
Address review comments.
Oct 5 2020
Abandoning due to lack of interest and in favour of D88830 which requires these changes.
Sep 23 2020
I may be missing something about how the ICF code works, but whilst looking at a separate ICF performance issue, I noticed these oddities in the code. I haven't actually seen any issues myself but reading through the code, it feels like there could be issues. Although I suspect they would be highly unlikely or perhaps not possible in actual practice.
Sep 16 2020
Sep 15 2020
Update for review suggestion.
Update for review comments.
Update to address review comments.
Sep 11 2020
Update to address review comments and suggestions.
Updated to address review comments and suggestions.
Sep 10 2020
This change requires D87468.
This is a prerequisite of D87469.
Sep 8 2020
Address review comments.
Sep 7 2020
Aug 27 2020
Aug 26 2020
LGTM with that last one change.
Jul 29 2020
Jul 28 2020
Jul 15 2020
Jul 13 2020
Jul 9 2020
That test is for widenPath and it does cover a similar situation (I know because I wrote it). The code you have changed relates to directory_iterator_construct which does not have coverage of the situation where the UTF16 length is less than the UTF8 length, i.e. the issue that you are fixing.
Jul 8 2020
The usual practice is to include the entire context in the diff. However, the change itself LGTM.
Apr 14 2020
Apr 9 2020
Apr 8 2020
Add comment to explain the Windows deficiencies (one of many)...
Apr 7 2020
Updated to address review comments.
Updated to address review comments.
Apr 6 2020
Apr 3 2020
The following patch fixes my issues on Windows, but I haven't tested that it doesn't break anything else:
Mar 23 2020
Mar 21 2020
Mar 19 2020
Mar 16 2020
Ping.
Mar 9 2020
Ping.
Mar 2 2020
Updated to address review comments and suggestions.