Page MenuHomePhabricator

andrewng (Andrew Ng)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 2 2017, 6:37 AM (278 w, 1 d)

Recent Activity

Today

andrewng requested review of D129004: [Support] Fix Windows dump file hang with multi-threaded crashes.
Fri, Jul 1, 9:53 AM · Restricted Project, Restricted Project
andrewng committed rGc0ef1ffc9e2f: [Build][NFC] Fixes for building on Windows with libc++ (authored by andrewng).
[Build][NFC] Fixes for building on Windows with libc++
Fri, Jul 1, 7:42 AM · Restricted Project, Restricted Project
andrewng closed D128514: [Build][NFC] Fixes for building on Windows with libc++.
Fri, Jul 1, 7:42 AM · Restricted Project, Restricted Project

Fri, Jun 24

andrewng requested review of D128514: [Build][NFC] Fixes for building on Windows with libc++.
Fri, Jun 24, 3:48 AM · Restricted Project, Restricted Project

Wed, Jun 8

andrewng committed rG3d6fcdf945f4: [CMake] Improve support for ASAN on Windows with MSVC cl & clang-cl (authored by andrewng).
[CMake] Improve support for ASAN on Windows with MSVC cl & clang-cl
Wed, Jun 8, 3:18 AM · Restricted Project, Restricted Project
andrewng closed D126706: [CMake] Improve support for ASAN on Windows with MSVC cl & clang-cl.
Wed, Jun 8, 3:18 AM · Restricted Project, Restricted Project

Jun 1 2022

andrewng updated the diff for D126706: [CMake] Improve support for ASAN on Windows with MSVC cl & clang-cl.

I've added support for x86_32/i686.

Jun 1 2022, 7:01 AM · Restricted Project, Restricted Project
andrewng added inline comments to D126706: [CMake] Improve support for ASAN on Windows with MSVC cl & clang-cl.
Jun 1 2022, 5:24 AM · Restricted Project, Restricted Project
andrewng committed rGe06a81d81029: [LSAN] Fix up LSAN weak symbols for Windows (authored by andrewng).
[LSAN] Fix up LSAN weak symbols for Windows
Jun 1 2022, 2:19 AM · Restricted Project, Restricted Project
andrewng closed D126703: [LSAN] Fix up LSAN weak symbols for Windows.
Jun 1 2022, 2:19 AM · Restricted Project, Restricted Project

May 31 2022

andrewng added inline comments to D126706: [CMake] Improve support for ASAN on Windows with MSVC cl & clang-cl.
May 31 2022, 4:44 PM · Restricted Project, Restricted Project
andrewng requested review of D126706: [CMake] Improve support for ASAN on Windows with MSVC cl & clang-cl.
May 31 2022, 8:32 AM · Restricted Project, Restricted Project
andrewng added a reviewer for D126703: [LSAN] Fix up LSAN weak symbols for Windows: vitalybuka.
May 31 2022, 8:03 AM · Restricted Project, Restricted Project
andrewng requested review of D126703: [LSAN] Fix up LSAN weak symbols for Windows.
May 31 2022, 8:02 AM · Restricted Project, Restricted Project

May 27 2022

andrewng added a comment to D126484: [LLD][ELF] Drop the string null terminator from the hash in splitStrings.

Looks like this breaks tests: http://45.33.8.238/linux/77072/step_11.txt

Please take a look and revert for now if it takes a while to fix.

May 27 2022, 4:18 AM · Restricted Project, Restricted Project
andrewng committed rGa94d454390c6: [LLD][test] Update `zlib` tests for LLD commit c78c00dc16 (authored by andrewng).
[LLD][test] Update `zlib` tests for LLD commit c78c00dc16
May 27 2022, 4:10 AM · Restricted Project
andrewng added a comment to D126484: [LLD][ELF] Drop the string null terminator from the hash in splitStrings.

Sorry, but I've missed some updates for LLD tests requiring zlib. Working on the fix now.

May 27 2022, 3:16 AM · Restricted Project, Restricted Project
andrewng committed rGc78c00dc16bb: [LLD][ELF] Drop the string null terminator from the hash in splitStrings (authored by andrewng).
[LLD][ELF] Drop the string null terminator from the hash in splitStrings
May 27 2022, 2:55 AM · Restricted Project
andrewng closed D126484: [LLD][ELF] Drop the string null terminator from the hash in splitStrings.
May 27 2022, 2:55 AM · Restricted Project, Restricted Project
andrewng committed rG4290ef54e18a: [Support] Reduce allocations in parallelForEach with move (authored by andrewng).
[Support] Reduce allocations in parallelForEach with move
May 27 2022, 2:31 AM · Restricted Project, Restricted Project
andrewng closed D126458: [Support] Reduce allocations in parallelForEach with move.
May 27 2022, 2:31 AM · Restricted Project, Restricted Project

May 26 2022

andrewng requested review of D126484: [LLD][ELF] Drop the string null terminator from the hash in splitStrings.
May 26 2022, 9:06 AM · Restricted Project, Restricted Project
andrewng requested review of D126458: [Support] Reduce allocations in parallelForEach with move.
May 26 2022, 4:47 AM · Restricted Project, Restricted Project

May 1 2022

andrewng committed rG57c55165ebe8: [analyzer] Fix return of llvm::StringRef to destroyed std::string (authored by andrewng).
[analyzer] Fix return of llvm::StringRef to destroyed std::string
May 1 2022, 4:37 AM · Restricted Project, Restricted Project
andrewng closed D124683: [analyzer] Fix return of llvm::StringRef to destroyed std::string.
May 1 2022, 4:36 AM · Restricted Project, Restricted Project

Apr 29 2022

andrewng requested review of D124683: [analyzer] Fix return of llvm::StringRef to destroyed std::string.
Apr 29 2022, 9:41 AM · Restricted Project, Restricted Project

Apr 8 2022

andrewng added a comment to D120327: compiler-rt: Add udivmodei5 to builtins and add bitint library.

@mgehre-amd this has broken our Linux GCC And Windows MSVC builds. Both complain that:

.../compiler-rt/lib/builtins/udivmodei5.c:27:32: error: initializer element is not constant
 static const su_int WORD_MSB = (su_int)1 << (WORD_SIZE_IN_BITS - 1);

Also __attribute__((weak)) is not supported for MSVC.

Apr 8 2022, 8:03 AM · Restricted Project, Restricted Project

Jan 31 2022

andrewng added inline comments to D118530: [ELF] Update flag propagation rule to ignore discarded output sections.
Jan 31 2022, 8:03 AM · Restricted Project

Jan 6 2022

andrewng committed rGd4d9de362b6a: [CMake] Support passing arguments to build tool for external projects (authored by andrewng).
[CMake] Support passing arguments to build tool for external projects
Jan 6 2022, 3:11 AM
andrewng closed D115815: [CMake] Support passing arguments to build tool for external projects.
Jan 6 2022, 3:10 AM · Restricted Project

Jan 5 2022

andrewng added inline comments to D115815: [CMake] Support passing arguments to build tool for external projects.
Jan 5 2022, 10:25 AM · Restricted Project
andrewng updated the diff for D115815: [CMake] Support passing arguments to build tool for external projects.

Address review comments.

Jan 5 2022, 10:23 AM · Restricted Project
andrewng added a comment to D115815: [CMake] Support passing arguments to build tool for external projects.

Ping.

Jan 5 2022, 9:25 AM · Restricted Project

Dec 16 2021

andrewng added a reviewer for D115815: [CMake] Support passing arguments to build tool for external projects: chandlerc.
Dec 16 2021, 10:39 AM · Restricted Project

Dec 15 2021

andrewng added a reviewer for D115815: [CMake] Support passing arguments to build tool for external projects: MaskRay.
Dec 15 2021, 11:39 AM · Restricted Project
andrewng requested review of D115815: [CMake] Support passing arguments to build tool for external projects.
Dec 15 2021, 11:34 AM · Restricted Project

Nov 19 2021

andrewng abandoned D114103: [ELF] Ensure output section is also not empty in addStartEndSymbols().

Abandoned in favour of D114179.

Nov 19 2021, 3:48 AM
andrewng committed rG47eb3f155f9e: [ELF] Ensure output section is not discarded in addStartEndSymbols() (authored by andrewng).
[ELF] Ensure output section is not discarded in addStartEndSymbols()
Nov 19 2021, 3:47 AM
andrewng closed D114179: [ELF] Ensure output section is not discarded in addStartEndSymbols().
Nov 19 2021, 3:47 AM · Restricted Project

Nov 18 2021

andrewng added a comment to D114179: [ELF] Ensure output section is not discarded in addStartEndSymbols().

This is potentially a "better" alternative to D114103.

Nov 18 2021, 11:13 AM · Restricted Project
andrewng updated the diff for D114103: [ELF] Ensure output section is also not empty in addStartEndSymbols().

Updated to address review comments.

Nov 18 2021, 11:07 AM
andrewng requested review of D114179: [ELF] Ensure output section is not discarded in addStartEndSymbols().
Nov 18 2021, 10:56 AM · Restricted Project

Nov 17 2021

andrewng requested review of D114103: [ELF] Ensure output section is also not empty in addStartEndSymbols().
Nov 17 2021, 9:51 AM

Nov 10 2021

andrewng added a comment to D109914: [Support] Attempt to fix deadlock in ThreadGroup.

Managed to end up here after looking at the query on D70447. Should this patch be cherry picked to the llvm-13 release branch?

Nov 10 2021, 8:48 AM · Restricted Project

Oct 12 2021

andrewng committed rG649cc160e38b: [ELF][test] Add testing for dynamic TLS relocations in .debug_info (authored by andrewng).
[ELF][test] Add testing for dynamic TLS relocations in .debug_info
Oct 12 2021, 2:56 AM
andrewng closed D111436: [ELF][test] Add testing for dynamic TLS relocations in .debug_info.
Oct 12 2021, 2:55 AM · Restricted Project

Oct 11 2021

andrewng updated the diff for D111436: [ELF][test] Add testing for dynamic TLS relocations in .debug_info.

Address review comments and moved testing to x86-64-tls-ld-local.s.

Oct 11 2021, 4:23 AM · Restricted Project

Oct 9 2021

andrewng added a comment to D111436: [ELF][test] Add testing for dynamic TLS relocations in .debug_info.

Please place this in one of the x86-64-tls-ld*.s files. For ppc64 we use ppc64-dtprel.s

Oct 9 2021, 9:16 AM · Restricted Project

Oct 8 2021

andrewng requested review of D111436: [ELF][test] Add testing for dynamic TLS relocations in .debug_info.
Oct 8 2021, 9:22 AM · Restricted Project

Oct 5 2021

andrewng committed rG3334b9d70bc8: [ELF][test] Enhance relative dynamic relocation tests (authored by andrewng).
[ELF][test] Enhance relative dynamic relocation tests
Oct 5 2021, 3:36 AM
andrewng closed D111071: [ELF][test] Enhance relative dynamic relocation tests.
Oct 5 2021, 3:35 AM · Restricted Project

Oct 4 2021

andrewng requested review of D111071: [ELF][test] Enhance relative dynamic relocation tests.
Oct 4 2021, 9:30 AM · Restricted Project
andrewng committed rG39f3f7c08fb6: [ELF][test] Fix several LLD ICF tests (authored by andrewng).
[ELF][test] Fix several LLD ICF tests
Oct 4 2021, 3:11 AM
andrewng closed D110353: [ELF][test] Fix several LLD ICF tests.
Oct 4 2021, 3:11 AM · Restricted Project

Sep 30 2021

andrewng updated the diff for D110353: [ELF][test] Fix several LLD ICF tests.

Replaced negative checks with checking that there is no output from --print-icf-sections using count.

Sep 30 2021, 2:23 AM · Restricted Project

Sep 29 2021

andrewng added a comment to D110353: [ELF][test] Fix several LLD ICF tests.

Looking at some of the other ICF tests, another approach to checking for no merging is: ... --print-icf-sections | count 0. Would this be preferable to using CHECK-NOT: patterns?

Sep 29 2021, 6:22 AM · Restricted Project

Sep 27 2021

andrewng added inline comments to D110353: [ELF][test] Fix several LLD ICF tests.
Sep 27 2021, 5:16 AM · Restricted Project
andrewng updated the diff for D110353: [ELF][test] Fix several LLD ICF tests.

Added comments to tests.

Sep 27 2021, 5:11 AM · Restricted Project

Sep 23 2021

andrewng requested review of D110353: [ELF][test] Fix several LLD ICF tests.
Sep 23 2021, 11:00 AM · Restricted Project

Sep 22 2021

andrewng committed rG05b130342143: [ELF][test] Restore important part of ICF alignment test (authored by andrewng).
[ELF][test] Restore important part of ICF alignment test
Sep 22 2021, 6:16 AM
andrewng closed D110090: [ELF][test] Restore important part of ICF alignment test.
Sep 22 2021, 6:16 AM · Restricted Project

Sep 21 2021

andrewng updated the diff for D110090: [ELF][test] Restore important part of ICF alignment test.

Added comment to test as suggested off-line by @jhenderson.

Sep 21 2021, 2:25 AM · Restricted Project
andrewng retitled D110090: [ELF][test] Restore important part of ICF alignment test from [LLD][ELF] Restore important part of ICF alignment test to [ELF][test] Restore important part of ICF alignment test.
Sep 21 2021, 2:22 AM · Restricted Project

Sep 20 2021

andrewng requested review of D110090: [ELF][test] Restore important part of ICF alignment test.
Sep 20 2021, 11:27 AM · Restricted Project

Jun 17 2021

andrewng committed rGd02bf362dcf8: [llvm-symbolizer][docs] Update example for --verbose in the guide (authored by andrewng).
[llvm-symbolizer][docs] Update example for --verbose in the guide
Jun 17 2021, 11:13 AM
andrewng closed D104128: [llvm-symbolizer][docs] Update example for --verbose in the guide.
Jun 17 2021, 11:13 AM · Restricted Project

Jun 16 2021

andrewng added a reviewer for D104128: [llvm-symbolizer][docs] Update example for --verbose in the guide: jhenderson.
Jun 16 2021, 2:40 AM · Restricted Project

Jun 11 2021

andrewng added reviewers for D104128: [llvm-symbolizer][docs] Update example for --verbose in the guide: dblaikie, aorlov.
Jun 11 2021, 9:14 AM · Restricted Project
andrewng requested review of D104128: [llvm-symbolizer][docs] Update example for --verbose in the guide.
Jun 11 2021, 9:07 AM · Restricted Project

May 21 2021

andrewng added a comment to D102684: [LLD] Allow disabling the early exit codepath as a build configuration.

I looked into this in some detail back in the day and am mainly responsible for how this thread pool currently functions. I primarily focused on static linking with the MSVC static runtime, as that's what we use downstream and were seeing issues with, but also included MinGW, GNU and libc++. To be honest, I can't remember if I tried LLVM_LINK_LLVM_DYLIB, there are just too many possible configurations! The various compilers/runtimes have changed since I last looked at this code, so it's not surprising that there may be issues depending on your configuration.

May 21 2021, 3:37 AM · Restricted Project

Feb 2 2021

andrewng committed rG94fedd266125: [X86] Fix disassembly of x86-64 GDTLS code sequence (authored by andrewng).
[X86] Fix disassembly of x86-64 GDTLS code sequence
Feb 2 2021, 3:35 AM
andrewng closed D95682: [X86] Fix disassembly of x86-64 GDTLS code sequence.
Feb 2 2021, 3:35 AM · Restricted Project

Feb 1 2021

andrewng updated the diff for D95682: [X86] Fix disassembly of x86-64 GDTLS code sequence.

Updated to address review comments.

Feb 1 2021, 6:25 AM · Restricted Project

Jan 29 2021

andrewng added a reviewer for D95682: [X86] Fix disassembly of x86-64 GDTLS code sequence: pengfei.
Jan 29 2021, 10:57 AM · Restricted Project
andrewng requested review of D95682: [X86] Fix disassembly of x86-64 GDTLS code sequence.
Jan 29 2021, 7:14 AM · Restricted Project

Jan 22 2021

andrewng accepted D95152: [ELF] --wrap: retain __wrap_foo if foo is defined in an object/bitcode file.

Apart from the nits already pointed out by @jhenderson, LGTM.

Jan 22 2021, 1:56 AM · Restricted Project

Jan 21 2021

andrewng added a comment to rGf96ff3c0f8eb: [ELF] --wrap: Produce a dynamic symbol for undefined __wrap_.

This change broke one of our downstream tests and the issue can be reproduced with the following test:

# REQUIRES: x86
Jan 21 2021, 4:18 AM

Oct 26 2020

andrewng committed rG2add7c5cf3eb: [llvm-ar][Object] Fix detection of need for 64-bit archive symbol tables (authored by andrewng).
[llvm-ar][Object] Fix detection of need for 64-bit archive symbol tables
Oct 26 2020, 5:41 AM
andrewng closed D89891: [llvm-ar][Object] Fix detection of need for 64-bit archive symbol tables.
Oct 26 2020, 5:41 AM · Restricted Project

Oct 22 2020

andrewng abandoned D89789: [LLD][ELF] Add --force-tls-variant2 option.
Oct 22 2020, 10:23 AM
andrewng updated the diff for D89891: [llvm-ar][Object] Fix detection of need for 64-bit archive symbol tables.

Update to clarify the purpose of the initial call to writeSymbolTableHeader.

Oct 22 2020, 9:14 AM · Restricted Project
andrewng added inline comments to D89891: [llvm-ar][Object] Fix detection of need for 64-bit archive symbol tables.
Oct 22 2020, 6:49 AM · Restricted Project
andrewng added inline comments to D89891: [llvm-ar][Object] Fix detection of need for 64-bit archive symbol tables.
Oct 22 2020, 6:42 AM · Restricted Project
andrewng added a comment to D89789: [LLD][ELF] Add --force-tls-variant2 option.

Putting together, I think this option cannot be accepted.
On the good side, the place you modify is very stable and you usually will not get merge conflict.

Oct 22 2020, 6:19 AM
andrewng added inline comments to D89891: [llvm-ar][Object] Fix detection of need for 64-bit archive symbol tables.
Oct 22 2020, 6:07 AM · Restricted Project
andrewng added a comment to D89891: [llvm-ar][Object] Fix detection of need for 64-bit archive symbol tables.

I understand that a test may be problematic because it requires 4+GiB output. Do you have a script to craft such a test case so that people working on llvm-ar can run it on demand? The test can have UNSUPPORTED: *.

Oct 22 2020, 5:08 AM · Restricted Project
andrewng updated the diff for D89891: [llvm-ar][Object] Fix detection of need for 64-bit archive symbol tables.

Updated to address review comments and updated to add better testing. Whilst adding this testing, found another bug in the detection code; it was also not accounting for the size of the file signature!

Oct 22 2020, 5:02 AM · Restricted Project

Oct 21 2020

andrewng requested review of D89891: [llvm-ar][Object] Fix detection of need for 64-bit archive symbol tables.
Oct 21 2020, 8:58 AM · Restricted Project

Oct 20 2020

andrewng requested review of D89789: [LLD][ELF] Add --force-tls-variant2 option.
Oct 20 2020, 6:29 AM

Oct 15 2020

andrewng committed rG88ce27c39c5e: [LLD][ELF] Improve ICF for relocations to ineligible sections via "aliases" (authored by andrewng).
[LLD][ELF] Improve ICF for relocations to ineligible sections via "aliases"
Oct 15 2020, 4:49 AM
andrewng closed D88830: [LLD][ELF] Improve ICF for relocations to ineligible sections via "aliases".
Oct 15 2020, 4:48 AM · Restricted Project

Oct 14 2020

andrewng added inline comments to D88830: [LLD][ELF] Improve ICF for relocations to ineligible sections via "aliases".
Oct 14 2020, 1:56 AM · Restricted Project

Oct 13 2020

andrewng added inline comments to D88830: [LLD][ELF] Improve ICF for relocations to ineligible sections via "aliases".
Oct 13 2020, 3:26 PM · Restricted Project
andrewng added a comment to D88830: [LLD][ELF] Improve ICF for relocations to ineligible sections via "aliases".

Ping.

Oct 13 2020, 5:53 AM · Restricted Project

Oct 8 2020

andrewng added inline comments to D88830: [LLD][ELF] Improve ICF for relocations to ineligible sections via "aliases".
Oct 8 2020, 1:40 AM · Restricted Project

Oct 6 2020

andrewng added a comment to D88830: [LLD][ELF] Improve ICF for relocations to ineligible sections via "aliases".

The description can be shortened a bit. The important part is that variableEq returns false if two relocations reference a pair of aliased symbols in an ineligible section.

Oct 6 2020, 3:05 AM · Restricted Project
andrewng added inline comments to D88830: [LLD][ELF] Improve ICF for relocations to ineligible sections via "aliases".
Oct 6 2020, 2:54 AM · Restricted Project
andrewng updated the diff for D88830: [LLD][ELF] Improve ICF for relocations to ineligible sections via "aliases".

Address review comments.

Oct 6 2020, 2:53 AM · Restricted Project

Oct 5 2020

andrewng abandoned D88151: [LLD][ELF] Fix inconsistencies with ICF equality class.

Abandoning due to lack of interest and in favour of D88830 which requires these changes.

Oct 5 2020, 6:12 AM
andrewng requested review of D88830: [LLD][ELF] Improve ICF for relocations to ineligible sections via "aliases".
Oct 5 2020, 6:10 AM · Restricted Project