Page MenuHomePhabricator

andrewng (Andrew Ng)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 2 2017, 6:37 AM (317 w, 2 d)

Recent Activity

Yesterday

andrewng requested review of D147340: [Support] Improve Windows performance of buffered raw_ostream.
Fri, Mar 31, 10:15 AM · Restricted Project, Restricted Project

Mar 2 2023

andrewng added a comment to D144734: [libcxx] Enable support for static and debug Windows runtimes.

I assumed that any patch would also need to pass all the testing but perhaps my Windows libc++ configuration is not quite "right".

Any patch does indeed need to pass all the testing, but that's primarily defined by the CI configurations; those must keep passing. Ideally, the tests should pass in all possible build configurations, but reality isn't quite there.

Mar 2 2023, 2:06 AM · Restricted Project, Restricted Project

Feb 27 2023

andrewng added a comment to D144734: [libcxx] Enable support for static and debug Windows runtimes.

I tested my patch locally in all 6 combinations, i.e. including release and debug runtimes. However, it's already clear that the configuration that I've been using does not match CI. Now that there are CI failures, I should hopefully be able to find out the differences in configuration.

Feb 27 2023, 9:40 AM · Restricted Project, Restricted Project
andrewng added a comment to D144734: [libcxx] Enable support for static and debug Windows runtimes.

Hi @mstorsjo, thanks for your comments.

Feb 27 2023, 7:48 AM · Restricted Project, Restricted Project

Feb 24 2023

andrewng requested review of D144734: [libcxx] Enable support for static and debug Windows runtimes.
Feb 24 2023, 7:08 AM · Restricted Project, Restricted Project

Feb 9 2023

andrewng committed rG0b704d9db7e1: [Support] Emulate SIGPIPE handling in raw_fd_ostream write for Windows (authored by andrewng).
[Support] Emulate SIGPIPE handling in raw_fd_ostream write for Windows
Feb 9 2023, 2:40 AM · Restricted Project, Restricted Project, Restricted Project
andrewng closed D142224: [Support] Emulate SIGPIPE handling in raw_fd_ostream write for Windows.
Feb 9 2023, 2:39 AM · Restricted Project, Restricted Project, Restricted Project

Feb 8 2023

andrewng updated the diff for D142224: [Support] Emulate SIGPIPE handling in raw_fd_ostream write for Windows.

Updated to add comment regarding the strange looking use of 0xE0000000.

Feb 8 2023, 8:52 AM · Restricted Project, Restricted Project, Restricted Project
andrewng added inline comments to D142224: [Support] Emulate SIGPIPE handling in raw_fd_ostream write for Windows.
Feb 8 2023, 7:57 AM · Restricted Project, Restricted Project, Restricted Project

Feb 3 2023

andrewng updated the diff for D142224: [Support] Emulate SIGPIPE handling in raw_fd_ostream write for Windows.

I did a bit more digging on the unix side, and https://github.com/llvm/llvm-project/issues/59037 and https://reviews.llvm.org/D138244 fixed the issue for clang -E on the unix side. Is there something that we could do about the default handler here, not specific to raw_ostream?

Feb 3 2023, 6:05 AM · Restricted Project, Restricted Project, Restricted Project

Feb 2 2023

andrewng updated the diff for D142224: [Support] Emulate SIGPIPE handling in raw_fd_ostream write for Windows.

Updated for review suggestions.

Feb 2 2023, 7:21 AM · Restricted Project, Restricted Project, Restricted Project
andrewng added a comment to D142224: [Support] Emulate SIGPIPE handling in raw_fd_ostream write for Windows.

Also, while I kinda see what this does in a code level, can you describe what this changes from a user point of view - does some usecase behave differently?

Half relatedly - I remember seeing some other discussion (I don’t have a reference handy right now) about changes to sigpipe handling; right now, if doing e.g. clang -E | less, you get a rather ugly crash for the clang process, if exiting less before the end of the clang output. (I remember seeing wishes to not treat this like a regular crash.)

Feb 2 2023, 2:56 AM · Restricted Project, Restricted Project, Restricted Project
andrewng added a comment to D142224: [Support] Emulate SIGPIPE handling in raw_fd_ostream write for Windows.
Feb 2 2023, 2:53 AM · Restricted Project, Restricted Project, Restricted Project

Jan 31 2023

andrewng added a reviewer for D142224: [Support] Emulate SIGPIPE handling in raw_fd_ostream write for Windows: mstorsjo.
Jan 31 2023, 6:28 AM · Restricted Project, Restricted Project, Restricted Project

Jan 30 2023

andrewng added a comment to D142224: [Support] Emulate SIGPIPE handling in raw_fd_ostream write for Windows.

Ping.

Jan 30 2023, 3:41 AM · Restricted Project, Restricted Project, Restricted Project
andrewng committed rG2493a7016416: [clangd] Disable tests that are incompatible with Windows (authored by andrewng).
[clangd] Disable tests that are incompatible with Windows
Jan 30 2023, 2:48 AM · Restricted Project, Restricted Project
andrewng closed D142228: [clangd] Disable tests that are incompatible with Windows.
Jan 30 2023, 2:48 AM · Restricted Project, Restricted Project
andrewng committed rG3133030446cb: [memprof] Change test output redirection to enable it to run on Windows (authored by andrewng).
[memprof] Change test output redirection to enable it to run on Windows
Jan 30 2023, 2:43 AM · Restricted Project, Restricted Project
andrewng closed D142225: [memprof] Change test output redirection to enable it to run on Windows.
Jan 30 2023, 2:43 AM · Restricted Project, Restricted Project

Jan 27 2023

andrewng added a comment to D142225: [memprof] Change test output redirection to enable it to run on Windows.

While the change itself looks good to me, this test is for linux (REQUIRES: x86_64-linux). Is there some motivation for this change?

Jan 27 2023, 1:55 AM · Restricted Project, Restricted Project

Jan 26 2023

andrewng added a comment to D142317: [Support] Avoid using main thread for llvm::parallelFor()..

@avl, could you please get this fix cherry picked to the 16.x release branch. The instructions for doing so are here: Backporting Fixes to the Release Branches and the GitHub milestone is here: LLVM 16.0.0 Release. Thanks.

Jan 26 2023, 10:31 AM · Restricted Project, Restricted Project
andrewng added inline comments to D139552: [NFC] Optimize vector usage in lld.
Jan 26 2023, 5:10 AM · Restricted Project, Restricted Project, Restricted Project, lld

Jan 25 2023

andrewng added a comment to D142317: [Support] Avoid using main thread for llvm::parallelFor()..

I'm not sure of the latest procedure regarding release branches but this patch should be cherry picked to the latest 16.x branch.

Jan 25 2023, 1:54 AM · Restricted Project, Restricted Project

Jan 24 2023

andrewng accepted D142317: [Support] Avoid using main thread for llvm::parallelFor()..

I think you need to be a bit careful with terminology because IIUC it's not actually "thread-safe" but a "per thread" allocator. I think this could be useful in some situations but perhaps a better overall approach would be to use a low-level thread aware memory allocator. I think some toolchains/runtimes already have such an allocator and there are other options such as rpmalloc and mimalloc. This way, the benefit is more widespread and doesn't require any extra effort (although some allocator libraries have some limitations on certain platforms).

Other than limitations on certain platforms, AFAICT, these libraries do not have a notion of memory pools - allocating data in "one big chunk"(To avoid memory fragmentation and to have a possibility to free resources fast). Thus if someone need a thread aware memory pool using rpmalloc and mimalloc would be not enough.

Jan 24 2023, 8:25 AM · Restricted Project, Restricted Project
andrewng added a comment to D142317: [Support] Avoid using main thread for llvm::parallelFor()..

I also have a connected question not related directly. What do you think about allocator from D142318 and following design for such allocator:

class ThreadPoolAllocator {
  void *Allocate(size_t size, size_t alignment);
};

class ThreadPool {
  std::unique_ptr<ThreadPoolAllocator> getAllocator ();
};

class ThreadPoolExecutor {
  std::unique_ptr<ThreadPoolAllocator> getAllocator ();
};

The idea is to have thread-safe allocator connected with its execution context.

Jan 24 2023, 3:51 AM · Restricted Project, Restricted Project

Jan 23 2023

andrewng added inline comments to D142317: [Support] Avoid using main thread for llvm::parallelFor()..
Jan 23 2023, 11:33 AM · Restricted Project, Restricted Project
andrewng added a comment to D142317: [Support] Avoid using main thread for llvm::parallelFor()..

I did not find direct specification of that behavior(thread_local variables are zero initialized) thus created a patch which initializes it.

Jan 23 2023, 9:15 AM · Restricted Project, Restricted Project
andrewng added a comment to D142317: [Support] Avoid using main thread for llvm::parallelFor()..

Perhaps I'm missing something here, but I thought that thread_local variables are zero initialized. Therefore, the threadIndex for the main thread should already be 0. However, what is definitely of concern is that parallelFor could create contention between the main thread and thread pool thread "0" because they share the index 0. I definitely missed this in the original review that introduced this change. I spotted the potential for the issue within LLD itself but completely forgot that the parallel support code also makes use of the main thread!

Jan 23 2023, 6:42 AM · Restricted Project, Restricted Project
andrewng added inline comments to D142317: [Support] Avoid using main thread for llvm::parallelFor()..
Jan 23 2023, 4:30 AM · Restricted Project, Restricted Project

Jan 20 2023

andrewng requested review of D142228: [clangd] Disable tests that are incompatible with Windows.
Jan 20 2023, 8:49 AM · Restricted Project, Restricted Project
andrewng requested review of D142225: [memprof] Change test output redirection to enable it to run on Windows.
Jan 20 2023, 8:30 AM · Restricted Project, Restricted Project
andrewng added a reviewer for D142224: [Support] Emulate SIGPIPE handling in raw_fd_ostream write for Windows: rnk.
Jan 20 2023, 8:20 AM · Restricted Project, Restricted Project, Restricted Project
andrewng requested review of D142224: [Support] Emulate SIGPIPE handling in raw_fd_ostream write for Windows.
Jan 20 2023, 8:19 AM · Restricted Project, Restricted Project, Restricted Project

Jan 10 2023

andrewng added a comment to D110450: [LLD] Remove global state in lld/COFF.

This broke tests on Windows: http://45.33.8.238/win/73025/step_10.txt

Please take a look and revert for now if it takes a while to fix.

Jan 10 2023, 6:25 AM · Restricted Project, Restricted Project
andrewng committed rG85a2f29fd485: [lld][COFF] Fix bug causing assertion in Chunk::setAlignment (authored by andrewng).
[lld][COFF] Fix bug causing assertion in Chunk::setAlignment
Jan 10 2023, 6:21 AM · Restricted Project

Dec 6 2022

andrewng added a comment to D136605: [libc++] Fixes for static libc++ on Windows using VCRuntime ABI.

However, the libc++ static test configuration does appear to be a mix of static and dynamic but that's another issue.

It's not necessarily a case when _every_ library is linked statically - it's a case where libc++ itself is linked statically. Whether each of libc++, msvcp, vcruntime or UCRT are linked statically or dynamically are orthogonal distribution choices.

Dec 6 2022, 4:18 AM · Restricted Project

Dec 5 2022

andrewng abandoned D136605: [libc++] Fixes for static libc++ on Windows using VCRuntime ABI.

These changes are not required. Ensuring that libc++.lib appears before msvcprt.lib solves the problem. Therefore, relying on the #pragma comment(lib, "libc++.lib") in the libc++ config doesn't really work for this Windows configuration. The libc++ testing also explicitly lists the link libraries with libc++.lib before msvcprt.lib which is why no problems are seen. However, the libc++ static test configuration does appear to be a mix of static and dynamic but that's another issue.

Dec 5 2022, 8:51 AM · Restricted Project

Nov 22 2022

andrewng added a comment to D136605: [libc++] Fixes for static libc++ on Windows using VCRuntime ABI.

Also, one reason why this slept for so long is that the libc++ review group is not on this review. Did you follow the steps in https://libcxx.llvm.org/Contributing.html#contributing-to-libc to upload the patch (in particular arc diff)?

Nov 22 2022, 8:37 AM · Restricted Project

Nov 8 2022

andrewng accepted D137611: cmake: Inline the add_llvm_symbol_exports.py script.

LGTM.

Nov 8 2022, 3:14 AM · Restricted Project, Restricted Project

Nov 7 2022

andrewng added a comment to D136605: [libc++] Fixes for static libc++ on Windows using VCRuntime ABI.

Ping.

Nov 7 2022, 6:11 AM · Restricted Project
andrewng added a reviewer for D136605: [libc++] Fixes for static libc++ on Windows using VCRuntime ABI: smeenai.
Nov 7 2022, 6:11 AM · Restricted Project

Nov 4 2022

andrewng added a comment to D136605: [libc++] Fixes for static libc++ on Windows using VCRuntime ABI.

Ping or any suggestions for other reviewers?

Nov 4 2022, 6:12 AM · Restricted Project

Oct 31 2022

andrewng added a comment to D136605: [libc++] Fixes for static libc++ on Windows using VCRuntime ABI.

Ping.

Oct 31 2022, 8:38 AM · Restricted Project

Oct 24 2022

andrewng requested review of D136605: [libc++] Fixes for static libc++ on Windows using VCRuntime ABI.
Oct 24 2022, 7:47 AM · Restricted Project

Oct 18 2022

andrewng committed rG1e2976631420: [CMake] Add Python script to generate version script symbol exports (authored by andrewng).
[CMake] Add Python script to generate version script symbol exports
Oct 18 2022, 5:48 AM · Restricted Project, Restricted Project
andrewng closed D136092: [CMake] Add Python script to generate version script symbol exports.
Oct 18 2022, 5:48 AM · Restricted Project, Restricted Project
andrewng committed rGe7fc7540daa9: [CMake] Fix Findzstd module for shared DLL on Windows (authored by andrewng).
[CMake] Fix Findzstd module for shared DLL on Windows
Oct 18 2022, 4:39 AM · Restricted Project, Restricted Project
andrewng closed D136065: [CMake] Fix Findzstd module for shared DLL on Windows.
Oct 18 2022, 4:39 AM · Restricted Project, Restricted Project
andrewng added inline comments to D136092: [CMake] Add Python script to generate version script symbol exports.
Oct 18 2022, 4:31 AM · Restricted Project, Restricted Project
andrewng updated the diff for D136092: [CMake] Add Python script to generate version script symbol exports.

Update for review comments.

Oct 18 2022, 4:27 AM · Restricted Project, Restricted Project

Oct 17 2022

andrewng updated the diff for D136065: [CMake] Fix Findzstd module for shared DLL on Windows.

Update for review comment.

Oct 17 2022, 10:50 AM · Restricted Project, Restricted Project
andrewng requested review of D136092: [CMake] Add Python script to generate version script symbol exports.
Oct 17 2022, 10:01 AM · Restricted Project, Restricted Project
andrewng requested review of D136065: [CMake] Fix Findzstd module for shared DLL on Windows.
Oct 17 2022, 3:25 AM · Restricted Project, Restricted Project

Sep 21 2022

andrewng accepted D133679: [ELF] Parallelize --compress-debug-sections=zstd.

LGTM and performance benefit is good on Windows too.

Sep 21 2022, 7:40 AM · Restricted Project, Restricted Project

Sep 13 2022

andrewng accepted D133759: [Support] Access threadIndex via a wrapper function.

LGTM, although might want to wait to see what @MaskRay thinks.

Sep 13 2022, 9:52 AM · Restricted Project, Restricted Project
andrewng added a comment to D133759: [Support] Access threadIndex via a wrapper function.

A couple of suggestions in response to the comment on D133003 regarding no TLS support.

Sep 13 2022, 7:57 AM · Restricted Project, Restricted Project
andrewng added a comment to D133759: [Support] Access threadIndex via a wrapper function.

I think this looks fine to unblock the MinGW dylib build but I wonder if we could reduce the number of calls to getThreadIndex() by storing the index in the RelocationScanner? Although this would require quite a few changes to the existing interfaces.

Sep 13 2022, 5:11 AM · Restricted Project, Restricted Project

Sep 12 2022

andrewng accepted D133003: [ELF] Parallelize relocation scanning.

This LGTM now, but I think it would be good to get another opinion too.

Sep 12 2022, 1:46 AM · Restricted Project, Restricted Project

Sep 11 2022

andrewng added inline comments to D133003: [ELF] Parallelize relocation scanning.
Sep 11 2022, 6:10 AM · Restricted Project, Restricted Project

Sep 10 2022

andrewng added inline comments to D133003: [ELF] Parallelize relocation scanning.
Sep 10 2022, 11:23 AM · Restricted Project, Restricted Project

Sep 9 2022

andrewng added a comment to D133003: [ELF] Parallelize relocation scanning.

Performance on Windows looks good! Every test case I've tried has shown an improvement.

Sep 9 2022, 9:17 AM · Restricted Project, Restricted Project
andrewng abandoned D133431: [WIP][ELF] Parallelize relocation scanning.

Far better approach now in D133003 that removes the lock contention.

Sep 9 2022, 8:59 AM · Restricted Project
andrewng added a comment to D133003: [ELF] Parallelize relocation scanning.

If the NEEDS_* change looks good, I'll pre-commit it (without using std::atomic) to reduce diff for future updates.

Sep 9 2022, 5:03 AM · Restricted Project, Restricted Project

Sep 7 2022

andrewng added a comment to D133003: [ELF] Parallelize relocation scanning.

I've created D133431 which is the result of my experimentation thus far. In my testing, it does slightly improve performance in the test cases that regressed in performance. In other test cases, it's around the same or slightly lower performance increase. However, I can't help but feel there should be a "better" solution. Although, I guess you've always got to balance that with complexity/maintainability. The hard coded concurrency limit of 8 tasks in D133431 also doesn't feel great.

Sep 7 2022, 9:34 AM · Restricted Project, Restricted Project
andrewng requested review of D133431: [WIP][ELF] Parallelize relocation scanning.
Sep 7 2022, 9:15 AM · Restricted Project

Sep 6 2022

andrewng added a comment to D133003: [ELF] Parallelize relocation scanning.

Don't yet know the reason for the slow down but I suspect it will be related to the "size" of the tasks being spawned in parallel.

Sep 6 2022, 10:11 AM · Restricted Project, Restricted Project

Sep 5 2022

andrewng added a comment to D133003: [ELF] Parallelize relocation scanning.

Sorry, I've been busy, so have only just had some time to look at this patch. Looks promising but unfortunately there are performance regressions on Windows for both chrome (~3%) and mozilla (~5%) from lld-speed-test.tar.xz. Don't yet know the reason for the slow down but I suspect it will be related to the "size" of the tasks being spawned in parallel.

Sep 5 2022, 9:02 AM · Restricted Project, Restricted Project

Aug 24 2022

andrewng abandoned D132025: [ELF][WIP] Parallelize writes of different OutputSections.

Approach adopted in D131247.

Aug 24 2022, 10:20 AM · Restricted Project, Restricted Project
andrewng added a comment to D131247: [ELF] Parallelize writes of different OutputSections.

Thanks. Do you think a smaller task size like 1MiB / 2MiB work fine?

@MaskRay, I did briefly experiment with smaller task sizes and both 1MiB & 2MiB showed similar results on my 2 test PCs with Windows. The performance related issue on Windows occurred when the "task size" was too large and 4MiB appeared to be the "sweet spot" in my testing. If 1MiB or 2MiB can be shown to be beneficial for other platforms, then it should be fine for Windows too (at least in my testing).

Aug 24 2022, 7:54 AM · Restricted Project, Restricted Project

Aug 23 2022

andrewng added a comment to D131247: [ELF] Parallelize writes of different OutputSections.

LGTM but I think it would be good to get some other reviewers to take a look (and perhaps test) before approval.

Aug 23 2022, 9:11 AM · Restricted Project, Restricted Project

Aug 22 2022

andrewng added a comment to D131247: [ELF] Parallelize writes of different OutputSections.

I've tested this latest patch applied to our downstream port on Windows and it improves linking performance in all our test cases that I've managed to test so far.

Aug 22 2022, 10:23 AM · Restricted Project, Restricted Project
andrewng resigned from D131665: [CMake] Support passing arguments to build tool (bootstrap)..

Resign as reviewer as I also work with Carlos and helped to author this patch.

Aug 22 2022, 4:09 AM · Restricted Project, Restricted Project, Restricted Project

Aug 17 2022

andrewng added a comment to D131247: [ELF] Parallelize writes of different OutputSections.

Instead of approximating the taskSize based on a 4MB size limit, I've prototyped a patch in https://reviews.llvm.org/D132025 that does it a bit better. This prototype patch has only been briefly tested in the same configurations as I've already tested this patch. However, I have also been able to reproduce the performance degradation on a different Windows PC.

Aug 17 2022, 5:34 AM · Restricted Project, Restricted Project
andrewng requested review of D132025: [ELF][WIP] Parallelize writes of different OutputSections.
Aug 17 2022, 5:26 AM · Restricted Project, Restricted Project

Aug 15 2022

andrewng added a comment to D131247: [ELF] Parallelize writes of different OutputSections.

I've looked a bit more at the Windows performance degradation and have come up with the following code for taskSize and asyncParallelFor:

size_t tasks = size / (4 * 1024 * 1024);
size_t taskSize = tasks ? sections.size() / tasks : sections.size();
asyncParallelFor(tg, std::max<size_t>(1, taskSize), 0, sections.size(), fn);

The 4MB is somewhat arbitrary but this appears to work OK on my Windows PC and mostly eliminates the performance degradation that I've seen so far. In fact there's a ~3% improvement for mozilla from lld-speed-test.tar.xz.

Aug 15 2022, 10:06 AM · Restricted Project, Restricted Project

Aug 12 2022

andrewng added a comment to D131247: [ELF] Parallelize writes of different OutputSections.

Some parallel* in SyntheticSections.cpp (e.g. MergeNoTailSection::writeTo) is now serial due to limitation of llvm/Support/Parallel.h, e.g. GdbIndexSection::writeTo, MergeNoTailSection::writeTo. Sometimes (in all workloads I have tested) overlapping their write with other output sections seems better than spending all threads in parallelizing them and writing output sections serially.

Aug 12 2022, 6:45 AM · Restricted Project, Restricted Project

Aug 11 2022

andrewng added inline comments to D131247: [ELF] Parallelize writes of different OutputSections.
Aug 11 2022, 11:16 AM · Restricted Project, Restricted Project
andrewng added a comment to D131247: [ELF] Parallelize writes of different OutputSections.

I've managed to get some time to test this change on Windows and the results do not look good. Testing chrome from lld-speed-test.tar.xz, I get a ~1% improvement, so that's the good news. However, testing mozilla, I get a ~23% increase in link time and testing scylla, I get a ~140% increase in link time. Testing an Unreal Engine 4 based link, gives ~21% increase in link time. This is running on a Windows 10 PC with AMD Ryzen 3900X 12C/24T 64GB RAM with Samsung 970 EVO NVMe SSDs. Haven't had a chance to dig deeper into why this is having such a negative impact.

Aug 11 2022, 6:58 AM · Restricted Project, Restricted Project

Aug 10 2022

andrewng added a comment to D118996: [clang-tidy] Support C++14 in bugprone-signal-handler..

@balazske This is failing on https://lab.llvm.org/buildbot/#/builders/139/builds/26335 - do you have a fix in progress or should I revert?

Fix is not in progress, it may take some days.

Aug 10 2022, 7:47 AM · Restricted Project, Restricted Project

Aug 9 2022

andrewng added a comment to D131247: [ELF] Parallelize writes of different OutputSections.

I assume that the performance figures are based on running on Linux. Do you have any idea what the performance impact is on Windows?

Aug 9 2022, 2:55 AM · Restricted Project, Restricted Project

Jul 8 2022

andrewng committed rG86a2f2e2db2a: [Support] Fix Windows dump file hang with multi-threaded crashes (authored by andrewng).
[Support] Fix Windows dump file hang with multi-threaded crashes
Jul 8 2022, 2:32 AM · Restricted Project, Restricted Project
andrewng closed D129004: [Support] Fix Windows dump file hang with multi-threaded crashes.
Jul 8 2022, 2:32 AM · Restricted Project, Restricted Project

Jul 7 2022

andrewng updated the diff for D129004: [Support] Fix Windows dump file hang with multi-threaded crashes.

Address review comment and removed the unit test.

Jul 7 2022, 10:51 AM · Restricted Project, Restricted Project
andrewng added inline comments to D129004: [Support] Fix Windows dump file hang with multi-threaded crashes.
Jul 7 2022, 9:23 AM · Restricted Project, Restricted Project

Jul 1 2022

andrewng requested review of D129004: [Support] Fix Windows dump file hang with multi-threaded crashes.
Jul 1 2022, 9:53 AM · Restricted Project, Restricted Project
andrewng committed rGc0ef1ffc9e2f: [Build][NFC] Fixes for building on Windows with libc++ (authored by andrewng).
[Build][NFC] Fixes for building on Windows with libc++
Jul 1 2022, 7:42 AM · Restricted Project, Restricted Project
andrewng closed D128514: [Build][NFC] Fixes for building on Windows with libc++.
Jul 1 2022, 7:42 AM · Restricted Project, Restricted Project

Jun 24 2022

andrewng requested review of D128514: [Build][NFC] Fixes for building on Windows with libc++.
Jun 24 2022, 3:48 AM · Restricted Project, Restricted Project

Jun 8 2022

andrewng committed rG3d6fcdf945f4: [CMake] Improve support for ASAN on Windows with MSVC cl & clang-cl (authored by andrewng).
[CMake] Improve support for ASAN on Windows with MSVC cl & clang-cl
Jun 8 2022, 3:18 AM · Restricted Project, Restricted Project
andrewng closed D126706: [CMake] Improve support for ASAN on Windows with MSVC cl & clang-cl.
Jun 8 2022, 3:18 AM · Restricted Project, Restricted Project

Jun 1 2022

andrewng updated the diff for D126706: [CMake] Improve support for ASAN on Windows with MSVC cl & clang-cl.

I've added support for x86_32/i686.

Jun 1 2022, 7:01 AM · Restricted Project, Restricted Project
andrewng added inline comments to D126706: [CMake] Improve support for ASAN on Windows with MSVC cl & clang-cl.
Jun 1 2022, 5:24 AM · Restricted Project, Restricted Project
andrewng committed rGe06a81d81029: [LSAN] Fix up LSAN weak symbols for Windows (authored by andrewng).
[LSAN] Fix up LSAN weak symbols for Windows
Jun 1 2022, 2:19 AM · Restricted Project, Restricted Project
andrewng closed D126703: [LSAN] Fix up LSAN weak symbols for Windows.
Jun 1 2022, 2:19 AM · Restricted Project, Restricted Project

May 31 2022

andrewng added inline comments to D126706: [CMake] Improve support for ASAN on Windows with MSVC cl & clang-cl.
May 31 2022, 4:44 PM · Restricted Project, Restricted Project
andrewng requested review of D126706: [CMake] Improve support for ASAN on Windows with MSVC cl & clang-cl.
May 31 2022, 8:32 AM · Restricted Project, Restricted Project
andrewng added a reviewer for D126703: [LSAN] Fix up LSAN weak symbols for Windows: vitalybuka.
May 31 2022, 8:03 AM · Restricted Project, Restricted Project
andrewng requested review of D126703: [LSAN] Fix up LSAN weak symbols for Windows.
May 31 2022, 8:02 AM · Restricted Project, Restricted Project

May 27 2022

andrewng added a comment to D126484: [LLD][ELF] Drop the string null terminator from the hash in splitStrings.

Looks like this breaks tests: http://45.33.8.238/linux/77072/step_11.txt

Please take a look and revert for now if it takes a while to fix.

May 27 2022, 4:18 AM · Restricted Project, Restricted Project
andrewng committed rGa94d454390c6: [LLD][test] Update `zlib` tests for LLD commit c78c00dc16 (authored by andrewng).
[LLD][test] Update `zlib` tests for LLD commit c78c00dc16
May 27 2022, 4:10 AM · Restricted Project