Page MenuHomePhabricator

gbreynoo (Owen Reynolds)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 19 2017, 6:04 AM (139 w, 23 h)

Recent Activity

Today

gbreynoo committed rG25040f8dec2e: Reapply [llvm-ar] Include a line number when failing to parse an MRI script (authored by gbreynoo).
Reapply [llvm-ar] Include a line number when failing to parse an MRI script
Fri, Sep 20, 1:14 AM
gbreynoo committed rL372374: Reapply [llvm-ar] Include a line number when failing to parse an MRI script.
Reapply [llvm-ar] Include a line number when failing to parse an MRI script
Fri, Sep 20, 1:09 AM

Yesterday

gbreynoo committed rGaa03c14827fa: Revert [llvm-ar] Include a line number when failing to parse an MRI script (authored by gbreynoo).
Revert [llvm-ar] Include a line number when failing to parse an MRI script
Thu, Sep 19, 4:23 AM
gbreynoo committed rL372311: Revert [llvm-ar] Include a line number when failing to parse an MRI script.
Revert [llvm-ar] Include a line number when failing to parse an MRI script
Thu, Sep 19, 4:23 AM
gbreynoo committed rG04398c729b20: [llvm-ar] Include a line number when failing to parse an MRI script (authored by gbreynoo).
[llvm-ar] Include a line number when failing to parse an MRI script
Thu, Sep 19, 3:55 AM
gbreynoo committed rL372309: [llvm-ar] Include a line number when failing to parse an MRI script.
[llvm-ar] Include a line number when failing to parse an MRI script
Thu, Sep 19, 3:55 AM
gbreynoo closed D67449: [llvm-ar] Include a line number when failing to parse an MRI script.
Thu, Sep 19, 3:55 AM · Restricted Project

Wed, Sep 18

gbreynoo added a comment to D67449: [llvm-ar] Include a line number when failing to parse an MRI script.

Thanks for all the feedback. Regarding an error handler I think the introduction of an error handler could be left for another time.

Wed, Sep 18, 6:16 AM · Restricted Project
gbreynoo updated the diff for D67449: [llvm-ar] Include a line number when failing to parse an MRI script.

Updated the test in line with suggested changes.

Wed, Sep 18, 6:08 AM · Restricted Project

Mon, Sep 16

gbreynoo committed rL372003: Request github commit access for gbreynoo.
Request github commit access for gbreynoo
Mon, Sep 16, 8:27 AM

Wed, Sep 11

gbreynoo created D67449: [llvm-ar] Include a line number when failing to parse an MRI script.
Wed, Sep 11, 8:12 AM · Restricted Project

Aug 12 2019

gbreynoo added a comment to D65743: [llvm-ar] Accept file paths with windows format slashes.

I think it'd be good to also write a test that verifies the internal representation is always forward slashes on windows by running FileCheck directly on the thin archive instead of using llvm-ar t to look at it (e.g. see thin-archive.test). Or do we already have a test for that?

Aug 12 2019, 7:02 AM · Restricted Project
gbreynoo committed rG47298393d2e4: [llvm-ar] Accept file paths with windows format slashes (authored by gbreynoo).
[llvm-ar] Accept file paths with windows format slashes
Aug 12 2019, 7:01 AM
gbreynoo committed rL368573: [llvm-ar] Accept file paths with windows format slashes.
[llvm-ar] Accept file paths with windows format slashes
Aug 12 2019, 6:59 AM
gbreynoo closed D65743: [llvm-ar] Accept file paths with windows format slashes.
Aug 12 2019, 6:59 AM · Restricted Project
gbreynoo committed rG20b2cd3c0bfe: [llvm-ar][test] Correct tests marked as expected fails (authored by gbreynoo).
[llvm-ar][test] Correct tests marked as expected fails
Aug 12 2019, 6:04 AM
gbreynoo committed rL368564: [llvm-ar][test] Correct tests marked as expected fails.
[llvm-ar][test] Correct tests marked as expected fails
Aug 12 2019, 6:04 AM
gbreynoo closed D65745: [llvm-ar][test] Correct tests marked as expected fails.
Aug 12 2019, 6:04 AM · Restricted Project

Aug 7 2019

gbreynoo added inline comments to D65743: [llvm-ar] Accept file paths with windows format slashes.
Aug 7 2019, 8:03 AM · Restricted Project
gbreynoo updated the diff for D65743: [llvm-ar] Accept file paths with windows format slashes.
Aug 7 2019, 8:01 AM · Restricted Project
gbreynoo added inline comments to rG629273ec0982: [llvm-ar][test] Add tests failing on Darwin.
Aug 7 2019, 7:14 AM

Aug 5 2019

gbreynoo created D65745: [llvm-ar][test] Correct tests marked as expected fails.
Aug 5 2019, 6:58 AM · Restricted Project
gbreynoo created D65743: [llvm-ar] Accept file paths with windows format slashes.
Aug 5 2019, 6:18 AM · Restricted Project

Jul 26 2019

gbreynoo added a comment to D64802: [llvm-ar][test] Add tests failing on Darwin.

Hi James,

Jul 26 2019, 9:44 AM · Restricted Project

Jul 24 2019

gbreynoo committed rG18c267135225: [llvm-ar][test] Fix move operation tests (authored by gbreynoo).
[llvm-ar][test] Fix move operation tests
Jul 24 2019, 7:27 AM
gbreynoo committed rL366908: [llvm-ar][test] Fix move operation tests.
[llvm-ar][test] Fix move operation tests
Jul 24 2019, 7:25 AM

Jul 23 2019

gbreynoo committed rG24f3e102a678: [llvm-ar] Fix support for archives with members larger than 4GB (authored by gbreynoo).
[llvm-ar] Fix support for archives with members larger than 4GB
Jul 23 2019, 7:47 AM
gbreynoo committed rL366813: [llvm-ar] Fix support for archives with members larger than 4GB.
[llvm-ar] Fix support for archives with members larger than 4GB
Jul 23 2019, 7:44 AM
gbreynoo closed D65093: [llvm-ar] Fix support for archives with members larger than 4GB.
Jul 23 2019, 7:44 AM · Restricted Project
gbreynoo added a comment to D65093: [llvm-ar] Fix support for archives with members larger than 4GB.

Thanks rupprecht, I'll fix my clone before committing.

Jul 23 2019, 4:09 AM · Restricted Project

Jul 22 2019

gbreynoo added inline comments to D65093: [llvm-ar] Fix support for archives with members larger than 4GB.
Jul 22 2019, 8:10 AM · Restricted Project
gbreynoo added a comment to D65093: [llvm-ar] Fix support for archives with members larger than 4GB.

I have not included a test for this change due to how large the test files would need to be.

Jul 22 2019, 7:57 AM · Restricted Project
gbreynoo created D65093: [llvm-ar] Fix support for archives with members larger than 4GB.
Jul 22 2019, 7:26 AM · Restricted Project

Jul 17 2019

gbreynoo committed rG629273ec0982: [llvm-ar][test] Add tests failing on Darwin (authored by gbreynoo).
[llvm-ar][test] Add tests failing on Darwin
Jul 17 2019, 8:12 AM
gbreynoo committed rL366334: [llvm-ar][test] Add tests failing on Darwin.
[llvm-ar][test] Add tests failing on Darwin
Jul 17 2019, 8:09 AM
gbreynoo closed D64802: [llvm-ar][test] Add tests failing on Darwin.
Jul 17 2019, 8:09 AM · Restricted Project
gbreynoo added inline comments to D64802: [llvm-ar][test] Add tests failing on Darwin.
Jul 17 2019, 8:04 AM · Restricted Project
gbreynoo committed rG247add6f3a37: [llvm-ar][test] Add coverage for replace and update key letters (authored by gbreynoo).
[llvm-ar][test] Add coverage for replace and update key letters
Jul 17 2019, 3:20 AM
gbreynoo committed rL366309: [llvm-ar][test] Add coverage for replace and update key letters.
[llvm-ar][test] Add coverage for replace and update key letters
Jul 17 2019, 3:20 AM
gbreynoo closed D64803: [llvm-ar][test] Add coverage for replace and update key letters.
Jul 17 2019, 3:20 AM · Restricted Project

Jul 16 2019

gbreynoo created D64803: [llvm-ar][test] Add coverage for replace and update key letters.
Jul 16 2019, 9:03 AM · Restricted Project
gbreynoo created D64802: [llvm-ar][test] Add tests failing on Darwin.
Jul 16 2019, 8:58 AM · Restricted Project
gbreynoo committed rG8e482eb5cbb8: [llvm-ar][test] Add to llvm-ar test coverage (authored by gbreynoo).
[llvm-ar][test] Add to llvm-ar test coverage
Jul 16 2019, 7:29 AM
gbreynoo committed rL366209: [llvm-ar][test] Add to llvm-ar test coverage.
[llvm-ar][test] Add to llvm-ar test coverage
Jul 16 2019, 7:29 AM
gbreynoo closed D64330: [llvm-ar][test] Add to llvm-ar test coverage .
Jul 16 2019, 7:29 AM · Restricted Project
gbreynoo committed rG3a6aaa4391f0: Reapply [llvm-ar][test] Increase llvm-ar test coverage (authored by gbreynoo).
Reapply [llvm-ar][test] Increase llvm-ar test coverage
Jul 16 2019, 5:57 AM
gbreynoo committed rL366206: Reapply [llvm-ar][test] Increase llvm-ar test coverage.
Reapply [llvm-ar][test] Increase llvm-ar test coverage
Jul 16 2019, 5:56 AM
gbreynoo committed rG971ac4ca2cb8: Reapply [llvm-ar][test] Add to MRI test coverage (authored by gbreynoo).
Reapply [llvm-ar][test] Add to MRI test coverage
Jul 16 2019, 4:03 AM
gbreynoo committed rL366201: Reapply [llvm-ar][test] Add to MRI test coverage.
Reapply [llvm-ar][test] Add to MRI test coverage
Jul 16 2019, 4:01 AM

Jul 10 2019

gbreynoo updated the diff for D64330: [llvm-ar][test] Add to llvm-ar test coverage .
Jul 10 2019, 8:37 AM · Restricted Project
gbreynoo added a comment to D63935: [llvm-ar][test] Increase llvm-ar test coverage.

Simmilarly to D63197, I'm not sure if it's preferable to make this test XFAIL: darwin or explicitly call llvm-ar with --format=gnu. What do you think jfb?

Jul 10 2019, 7:37 AM · Restricted Project
gbreynoo added a comment to D63197: [llvm-ar][test] Add to MRI test coverage .

I believe the test failure is based on an issue with output, specific to the darwin format:

Jul 10 2019, 7:34 AM · Restricted Project

Jul 9 2019

gbreynoo retitled D64330: [llvm-ar][test] Add to llvm-ar test coverage from [llvm-ar][test] Add to MRI test coverage to [llvm-ar][test] Add to llvm-ar test coverage .
Jul 9 2019, 11:03 AM · Restricted Project
gbreynoo added a comment to D63935: [llvm-ar][test] Increase llvm-ar test coverage.

Thanks phosek and jfb, I will investigate this macOS issue.

Jul 9 2019, 3:34 AM · Restricted Project
gbreynoo added a comment to D59491: Fix relative thin archive path handling.

Fixed a reapplied:
rG5d5078e341f5: [llvm-ar] Reapply Fix relative thin archive path handling

Jul 9 2019, 3:27 AM · Restricted Project

Jul 8 2019

gbreynoo created D64330: [llvm-ar][test] Add to llvm-ar test coverage .
Jul 8 2019, 6:49 AM · Restricted Project
gbreynoo committed rG1159fe3f6e0d: Reapply [llvm-ar][test] Increase llvm-ar test coverage (authored by gbreynoo).
Reapply [llvm-ar][test] Increase llvm-ar test coverage
Jul 8 2019, 6:43 AM
gbreynoo committed rL365318: Reapply [llvm-ar][test] Increase llvm-ar test coverage.
Reapply [llvm-ar][test] Increase llvm-ar test coverage
Jul 8 2019, 6:42 AM
gbreynoo committed rG0c5fe7a440a2: Revert [llvm-ar][test] Increase llvm-ar test coverage (authored by gbreynoo).
Revert [llvm-ar][test] Increase llvm-ar test coverage
Jul 8 2019, 6:13 AM
gbreynoo committed rL365317: Revert [llvm-ar][test] Increase llvm-ar test coverage.
Revert [llvm-ar][test] Increase llvm-ar test coverage
Jul 8 2019, 6:12 AM
gbreynoo committed rG870d9c61b062: [llvm-ar][test] Increase llvm-ar test coverage (authored by gbreynoo).
[llvm-ar][test] Increase llvm-ar test coverage
Jul 8 2019, 5:58 AM
gbreynoo committed rL365316: [llvm-ar][test] Increase llvm-ar test coverage.
[llvm-ar][test] Increase llvm-ar test coverage
Jul 8 2019, 5:58 AM
gbreynoo closed D63935: [llvm-ar][test] Increase llvm-ar test coverage.
Jul 8 2019, 5:58 AM · Restricted Project

Jul 5 2019

gbreynoo updated the diff for D63935: [llvm-ar][test] Increase llvm-ar test coverage.
Jul 5 2019, 12:37 AM · Restricted Project

Jul 4 2019

gbreynoo added inline comments to D63935: [llvm-ar][test] Increase llvm-ar test coverage.
Jul 4 2019, 8:26 AM · Restricted Project
gbreynoo updated the diff for D63935: [llvm-ar][test] Increase llvm-ar test coverage.

Thanks for the comments MaskRay, I have updated the revision.

Jul 4 2019, 8:22 AM · Restricted Project

Jul 3 2019

gbreynoo committed rG250015bacf7f: [llvm-ar][test] Add to MRI test coverage (authored by gbreynoo).
[llvm-ar][test] Add to MRI test coverage
Jul 3 2019, 6:50 AM
gbreynoo committed rL365039: [llvm-ar][test] Add to MRI test coverage.
[llvm-ar][test] Add to MRI test coverage
Jul 3 2019, 6:50 AM

Jul 1 2019

gbreynoo added a comment to D63935: [llvm-ar][test] Increase llvm-ar test coverage.

After MaskRay's suggestion I have removed all use of rm -f %t-*

Jul 1 2019, 9:15 AM · Restricted Project
gbreynoo updated the diff for D63935: [llvm-ar][test] Increase llvm-ar test coverage.
Jul 1 2019, 9:06 AM · Restricted Project

Jun 28 2019

gbreynoo created D63935: [llvm-ar][test] Increase llvm-ar test coverage.
Jun 28 2019, 8:28 AM · Restricted Project

Jun 13 2019

gbreynoo committed rG8d59f5370d46: Revert [llvm-ar][test] Add to MRI test coverage (authored by gbreynoo).
Revert [llvm-ar][test] Add to MRI test coverage
Jun 13 2019, 2:02 AM
gbreynoo added a reverting change for rL363232: [llvm-ar][test] Add to MRI test coverage: rL363239: Revert [llvm-ar][test] Add to MRI test coverage.
Jun 13 2019, 2:02 AM
gbreynoo committed rL363239: Revert [llvm-ar][test] Add to MRI test coverage.
Revert [llvm-ar][test] Add to MRI test coverage
Jun 13 2019, 2:02 AM
gbreynoo added a comment to D63197: [llvm-ar][test] Add to MRI test coverage .

Reverted in 363239 due to buildbot test failure

Jun 13 2019, 2:02 AM · Restricted Project
gbreynoo committed rG02eac87ba3e6: [llvm-ar][test] Add to MRI test coverage (authored by gbreynoo).
[llvm-ar][test] Add to MRI test coverage
Jun 13 2019, 12:43 AM
gbreynoo committed rL363232: [llvm-ar][test] Add to MRI test coverage.
[llvm-ar][test] Add to MRI test coverage
Jun 13 2019, 12:43 AM
gbreynoo closed D63197: [llvm-ar][test] Add to MRI test coverage .
Jun 13 2019, 12:43 AM · Restricted Project

Jun 12 2019

gbreynoo created D63197: [llvm-ar][test] Add to MRI test coverage .
Jun 12 2019, 6:11 AM · Restricted Project
gbreynoo accepted D62930: [llvm-ar][test] Relax lit directory assumptions in thin-archive.test.

LGTM

Jun 12 2019, 6:02 AM · Restricted Project

Jun 6 2019

gbreynoo committed rGbf5bca5bea5b: [llvm-ar] Create thin archives with MRI scripts (authored by gbreynoo).
[llvm-ar] Create thin archives with MRI scripts
Jun 6 2019, 6:19 AM
gbreynoo committed rL362704: [llvm-ar] Create thin archives with MRI scripts.
[llvm-ar] Create thin archives with MRI scripts
Jun 6 2019, 6:18 AM
gbreynoo closed D62919: [llvm-ar] Create thin archives with MRI scripts.
Jun 6 2019, 6:18 AM · Restricted Project
gbreynoo added inline comments to D62919: [llvm-ar] Create thin archives with MRI scripts.
Jun 6 2019, 4:21 AM · Restricted Project
gbreynoo updated the diff for D62919: [llvm-ar] Create thin archives with MRI scripts.

Changes after rupprecht's comments.

Jun 6 2019, 3:55 AM · Restricted Project

Jun 5 2019

gbreynoo created D62919: [llvm-ar] Create thin archives with MRI scripts.
Jun 5 2019, 10:44 AM · Restricted Project

Jun 4 2019

gbreynoo committed rG5d5078e341f5: [llvm-ar] Reapply Fix relative thin archive path handling (authored by gbreynoo).
[llvm-ar] Reapply Fix relative thin archive path handling
Jun 4 2019, 3:11 AM
gbreynoo committed rL362484: [llvm-ar] Reapply Fix relative thin archive path handling.
[llvm-ar] Reapply Fix relative thin archive path handling
Jun 4 2019, 3:10 AM

Jun 3 2019

gbreynoo added a comment to D59491: Fix relative thin archive path handling.

Thanks hintonda and gribozavr, I will look into that build issue before I recommit.

Jun 3 2019, 9:32 AM · Restricted Project
gbreynoo committed rGfade9cbed763: [llvm-ar] Fix relative thin archive path handling (authored by gbreynoo).
[llvm-ar] Fix relative thin archive path handling
Jun 3 2019, 8:26 AM
gbreynoo committed rL362407: [llvm-ar] Fix relative thin archive path handling.
[llvm-ar] Fix relative thin archive path handling
Jun 3 2019, 8:26 AM
gbreynoo closed D59491: Fix relative thin archive path handling.
Jun 3 2019, 8:26 AM · Restricted Project

May 24 2019

gbreynoo updated the diff for D59491: Fix relative thin archive path handling.

I've attempted to make "computeArchiveRelativePath" clearer and errors are now propagated to the caller to deal with rather than just returning the "To" argument.

May 24 2019, 4:04 AM · Restricted Project

Apr 26 2019

gbreynoo added a comment to D59491: Fix relative thin archive path handling.

Hi Rui, thanks for the feedback. I'm unsure what changes would better fit what we have outlined in past comments:

Apr 26 2019, 11:06 AM · Restricted Project

Apr 17 2019

gbreynoo added a comment to D59491: Fix relative thin archive path handling.

If the reasons for these changes are unclear I'll be happy to clarify.

Apr 17 2019, 5:34 AM · Restricted Project

Mar 20 2019

gbreynoo added a comment to D59491: Fix relative thin archive path handling.

The problem with working out the paths is if either are in the form foo/../bar/. I don't believe your above suggestion would work for paths with internal ../.

Mar 20 2019, 10:54 AM · Restricted Project
gbreynoo updated the diff for D59491: Fix relative thin archive path handling.
Mar 20 2019, 10:31 AM · Restricted Project
gbreynoo added a comment to D59491: Fix relative thin archive path handling.

In response to rupprecht:

Mar 20 2019, 8:02 AM · Restricted Project
gbreynoo updated the diff for D59491: Fix relative thin archive path handling.

Update after Rui's comment.

Mar 20 2019, 7:33 AM · Restricted Project

Mar 18 2019

gbreynoo created D59491: Fix relative thin archive path handling.
Mar 18 2019, 7:46 AM · Restricted Project