- User Since
- Jan 19 2017, 6:04 AM (139 w, 23 h)
Wed, Sep 18
Thanks for all the feedback. Regarding an error handler I think the introduction of an error handler could be left for another time.
Updated the test in line with suggested changes.
Mon, Sep 16
Wed, Sep 11
Aug 12 2019
Aug 7 2019
Aug 5 2019
Jul 26 2019
Jul 24 2019
Jul 23 2019
Thanks rupprecht, I'll fix my clone before committing.
Jul 22 2019
I have not included a test for this change due to how large the test files would need to be.
Jul 17 2019
Jul 16 2019
Jul 10 2019
Simmilarly to D63197, I'm not sure if it's preferable to make this test XFAIL: darwin or explicitly call llvm-ar with --format=gnu. What do you think jfb?
I believe the test failure is based on an issue with output, specific to the darwin format:
Jul 9 2019
Thanks phosek and jfb, I will investigate this macOS issue.
Fixed a reapplied:
rG5d5078e341f5: [llvm-ar] Reapply Fix relative thin archive path handling
Jul 8 2019
Jul 5 2019
Jul 4 2019
Thanks for the comments MaskRay, I have updated the revision.
Jul 3 2019
Jul 1 2019
After MaskRay's suggestion I have removed all use of rm -f %t-*
Jun 28 2019
Jun 13 2019
Reverted in 363239 due to buildbot test failure
Jun 12 2019
Jun 6 2019
Changes after rupprecht's comments.
Jun 5 2019
Jun 4 2019
Jun 3 2019
Thanks hintonda and gribozavr, I will look into that build issue before I recommit.
May 24 2019
I've attempted to make "computeArchiveRelativePath" clearer and errors are now propagated to the caller to deal with rather than just returning the "To" argument.
Apr 26 2019
Hi Rui, thanks for the feedback. I'm unsure what changes would better fit what we have outlined in past comments:
Apr 17 2019
If the reasons for these changes are unclear I'll be happy to clarify.
Mar 20 2019
The problem with working out the paths is if either are in the form foo/../bar/. I don't believe your above suggestion would work for paths with internal ../.
In response to rupprecht:
Update after Rui's comment.