- User Since
- Jan 19 2017, 6:04 AM (167 w, 5 d)
Thu, Mar 26
Wed, Mar 25
Apologies James, this fixes the case issues.
Mon, Mar 23
Changes made in response to James' comments
Thu, Mar 19
After Paul's comment, a custom message can now be used to replace the generic one.
Wed, Mar 11
Removed Clangs use of the same message.
Mar 4 2020
Hi sbc100, thanks for highlighting this inconsistency, I think wasm-ld and clang need updating too. Would it be worth the effort to have some kind of shared implementation for this?
Mar 3 2020
Mar 2 2020
Feb 24 2020
- Removed unused function removeHyphens
- Fixed matchFlagWithArg so 3 hyphens are no longer excepted before an argument
- getRspQuoting now uses ArraryRef instead of SmallVector
Feb 21 2020
Feb 18 2020
I agree with mstorsjo, matching what what LLVM is documented to require seems best.
Feb 14 2020
Thanks Maskray for your comment regarding marking comments as "done", I'll look out for that in future.
Inlined removeHyphens function
Feb 13 2020
Feb 10 2020
Jan 24 2020
Jan 16 2020
The use of python in the test response.test was failing on my Windows machine with Python 3. This patch fixes the issue.
- Use single quotes in tests
- Clarify use of echo in response.test
Jan 10 2020
Jan 2 2020
- Removed --rsp-quoting=default
- Reverted rename of Options
- Removed use of using
Dec 12 2019
Dec 4 2019
- Redundant pair of braces
- space after ,
- indent the continuation lines
Dec 3 2019
- Use using instead of typedef
- removeHyphens is now called from matchFlagWithArg
- Removed Argv reference argument from getRspQuoting
- Fix response.test that failed on linux
Nov 22 2019
- Pulled out the MatchFlagWithArg lambda expression into static function, and done the same with some code that handles hyphen removal.
- Added test cases to response.test.
- Removed the python call in response-utf8.test. I would prefer the file comparison but it should be sufficient to show the archive is functioning properly.
Nov 13 2019
Added rsp-quoting switch as thopre requested.
Nov 4 2019
Oct 31 2019
Oct 25 2019
This looks good to me, although with llvm-ar there is a balance between adding useful functionality and keeping command compatibility with other archivers. I've added Rui as a reviewer in case.
Oct 24 2019
Rui makes good points that I struggle to argue with. I'll abandon this review as their is no interest.
Oct 23 2019
Oct 21 2019
Oct 17 2019
Fixed two format issues.
Renamed "Long Options" to "Other" and moved it below the other options, removed bad link to gnu-ar and updated with changes from D69087.
Oct 16 2019
Fix nits, add missing options, remove old limitation and add information regarding deterministic archives.
Oct 15 2019
Updated llvm-ar doc to clarify non-windows behaviour and why windows is not Unicode compliant.
Oct 11 2019
Due to updating the command guide I have not added the case insensitivity details to the llvm-ar help text. Would it be preferred to have these details in both?
Update llvm-ar command guide with case insensitivity details, and include a test for archived files with paths for names.
Oct 10 2019
I added the XFAIL to 3 llvm-ar tests I added earlier in the year, due to them failing on Darwin systems. See below:
Oct 8 2019
This functions on Windows fine.
Removed unneeded const, swapped use of ifndef and added comment to comparePaths function.
Oct 4 2019
I reverted this change due to the clang-x64-windows-msvc build bot failure.
You are correct that the locale is required to pass on linux. I had some trouble with this test as the behaviour of python in this area differs between linux / windows and python 2 / python 3. For example this fix appears to be fine for linux, however Windows with python 2 fails:
Oct 3 2019
Updated after Edd and Ruiu's suggestion.
Oct 1 2019
Updated after rupprecht's suggestion.
Sep 30 2019
My understanding is that although NTFS is case sensitive, the windows API makes file operations case insensitive by default.
This is failing on the sphinx build bot:
Sep 27 2019
Sep 26 2019
Sep 25 2019
There are many tests in this area that use llvm-ar to test the underlying library. It may be better for these also to be in the llvm-ar test directory and have unit tests for specifically testing ArchiveWriter?