Page MenuHomePhabricator

gbreynoo (Owen Reynolds)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 19 2017, 6:04 AM (278 w, 4 d)

Recent Activity

Thu, May 12

gbreynoo added a comment to D125439: Ensure that the MRI CREATE/CREATETHIN commands overwrite the output file appropriately.

Thanks for fixing this Ben, once James' suggestions are fixed it LGTM.

Thu, May 12, 5:26 AM · Restricted Project, Restricted Project

Thu, Apr 28

gbreynoo committed rG5420834aadbd: [demangler] Fix demangling a template argument which happens to be a null… (authored by gbreynoo).
[demangler] Fix demangling a template argument which happens to be a null…
Thu, Apr 28, 8:00 AM · Restricted Project, Restricted Project
gbreynoo closed D124010: [llvm-cxxfilt] Unable to demangle a template argument which happens to be a null pointer.
Thu, Apr 28, 8:00 AM · Restricted Project, Restricted Project, Restricted Project
gbreynoo added a comment to D124010: [llvm-cxxfilt] Unable to demangle a template argument which happens to be a null pointer.

@urnathan I've created the ticket https://github.com/llvm/llvm-project/issues/55171 regarding the mangling issue. Just to note here, above I mentioned that I thought the mangled output matched GCC but this is not the case.

Thu, Apr 28, 7:51 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Apr 27

gbreynoo updated the diff for D124010: [llvm-cxxfilt] Unable to demangle a template argument which happens to be a null pointer.

Updated with urnathan's suggestion.

Wed, Apr 27, 10:17 AM · Restricted Project, Restricted Project, Restricted Project
gbreynoo added a comment to D124010: [llvm-cxxfilt] Unable to demangle a template argument which happens to be a null pointer.

I now see what you mean @dblaikie . I believe the mangling is functioning correctly and it's output matches GCC, it is the demangling that is the issue. By following @urnathan's code suggestion the demangled output will differ but I don't think this should be a problem as they are equivalent?

Wed, Apr 27, 9:43 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Apr 26

gbreynoo added a comment to D124445: [llvm-ar] Modify usage printouts to use the correct toolname.

This looks like a good change to me, just needs that ranlib test fixing.

Tue, Apr 26, 9:38 AM · Restricted Project, Restricted Project
gbreynoo added inline comments to D124010: [llvm-cxxfilt] Unable to demangle a template argument which happens to be a null pointer.
Tue, Apr 26, 9:20 AM · Restricted Project, Restricted Project, Restricted Project
gbreynoo added a comment to D124010: [llvm-cxxfilt] Unable to demangle a template argument which happens to be a null pointer.

Apologies for the delay in response and thank you for your input @dblaikie and @urnathan.

Tue, Apr 26, 9:17 AM · Restricted Project, Restricted Project, Restricted Project
gbreynoo updated the diff for D124010: [llvm-cxxfilt] Unable to demangle a template argument which happens to be a null pointer.

Move testing to area suggested by @urnathan.

Tue, Apr 26, 9:11 AM · Restricted Project, Restricted Project, Restricted Project

Apr 21 2022

gbreynoo committed rG1f71b5a38605: [llvm-ar] Fix thin archive being wrongly converted to a full archive (authored by gbreynoo).
[llvm-ar] Fix thin archive being wrongly converted to a full archive
Apr 21 2022, 7:49 AM · Restricted Project, Restricted Project
gbreynoo closed D123142: [llvm-ar] Fix thin archive being wrongly converted to a full archive.
Apr 21 2022, 7:49 AM · Restricted Project, Restricted Project

Apr 20 2022

gbreynoo updated the diff for D123142: [llvm-ar] Fix thin archive being wrongly converted to a full archive.

Fixed failing test and @jhenderson's other points.

Apr 20 2022, 8:23 AM · Restricted Project, Restricted Project

Apr 19 2022

gbreynoo added a comment to D124010: [llvm-cxxfilt] Unable to demangle a template argument which happens to be a null pointer.

I am not so familiar with this part of LLVM, I think this testing may belong elsewhere but I am unsure where that would be.

Apr 19 2022, 9:06 AM · Restricted Project, Restricted Project, Restricted Project
gbreynoo requested review of D124010: [llvm-cxxfilt] Unable to demangle a template argument which happens to be a null pointer.
Apr 19 2022, 9:05 AM · Restricted Project, Restricted Project, Restricted Project
gbreynoo added inline comments to D123142: [llvm-ar] Fix thin archive being wrongly converted to a full archive.
Apr 19 2022, 8:37 AM · Restricted Project, Restricted Project
gbreynoo updated the diff for D123142: [llvm-ar] Fix thin archive being wrongly converted to a full archive.

Updated after https://reviews.llvm.org/D123778 was accepted and committed.

Apr 19 2022, 8:36 AM · Restricted Project, Restricted Project
gbreynoo committed rG42865819b224: [llvm-ar][test] Rename two tests and use correct thin command (authored by gbreynoo).
[llvm-ar][test] Rename two tests and use correct thin command
Apr 19 2022, 7:14 AM · Restricted Project, Restricted Project
gbreynoo closed D123778: [llvm-ar][test] Rename two tests and use correct thin command.
Apr 19 2022, 7:14 AM · Restricted Project, Restricted Project

Apr 14 2022

gbreynoo added a comment to D123142: [llvm-ar] Fix thin archive being wrongly converted to a full archive.

Good idea @MaskRay, I've split that into https://reviews.llvm.org/D123778 and will update this one when D123778 is complete.

Apr 14 2022, 3:39 AM · Restricted Project, Restricted Project
gbreynoo requested review of D123778: [llvm-ar][test] Rename two tests and use correct thin command.
Apr 14 2022, 3:37 AM · Restricted Project, Restricted Project

Apr 13 2022

gbreynoo added inline comments to D123142: [llvm-ar] Fix thin archive being wrongly converted to a full archive.
Apr 13 2022, 9:14 AM · Restricted Project, Restricted Project
gbreynoo updated the diff for D123142: [llvm-ar] Fix thin archive being wrongly converted to a full archive.

Corrected comments including replacing use of "full archive" with "regular archive" as suggested. To remain consistent two tests have been renamed to use the term "regular". The checks for "thinness" in llvm-ar.cpp now only applies for write commands.

Apr 13 2022, 9:03 AM · Restricted Project, Restricted Project

Apr 5 2022

gbreynoo added a comment to D123142: [llvm-ar] Fix thin archive being wrongly converted to a full archive.

The following tests have been modified:

  • flatten-thin-archive.test now explicitly checks that %t.a is thin after the other archives have been added.
  • full-to-thin-archive.test uses Inputs/a.txt as an input rather than itself as spurious passes could have occurred when looking for strings contained in the archive file. Corrected a comment, added a test case for an existing archive and a case attempting to convert an existing archive.
  • thin-to-full-archive.test now tests the contents to ensure the thin archives member have been added and not the archive itself. Added a test case for an existing archive and a case attempting to convert an existing archive.
Apr 5 2022, 9:47 AM · Restricted Project, Restricted Project
gbreynoo requested review of D123142: [llvm-ar] Fix thin archive being wrongly converted to a full archive.
Apr 5 2022, 9:45 AM · Restricted Project, Restricted Project

Apr 4 2022

gbreynoo committed rG3ad6f535024c: [llvm-objcopy][docs] Update --update-section description (authored by gbreynoo).
[llvm-objcopy][docs] Update --update-section description
Apr 4 2022, 8:23 AM · Restricted Project, Restricted Project
gbreynoo closed D122907: [llvm-objcopy][docs] Add --update-section to objcopy command guide.
Apr 4 2022, 8:23 AM · Restricted Project, Restricted Project

Apr 1 2022

gbreynoo added inline comments to D122907: [llvm-objcopy][docs] Add --update-section to objcopy command guide.
Apr 1 2022, 9:17 AM · Restricted Project, Restricted Project
gbreynoo updated the diff for D122907: [llvm-objcopy][docs] Add --update-section to objcopy command guide.

Fixed the description after abrachet's comment and updated the help output to mirror the change.

Apr 1 2022, 9:16 AM · Restricted Project, Restricted Project
gbreynoo requested review of D122907: [llvm-objcopy][docs] Add --update-section to objcopy command guide.
Apr 1 2022, 7:59 AM · Restricted Project, Restricted Project

Mar 17 2022

gbreynoo accepted D121902: Fix llvm-strip --only-keep-debug documentation for ELF.

LGTM

Mar 17 2022, 8:02 AM · Restricted Project, Restricted Project

Feb 28 2022

gbreynoo added a comment to D120660: [llvm-symbolizer] Add --approximate-missing-line-numbers Command Line Option.

To be clear this new output is an approximation for cases in which the canonical line number is 0 and so not too helpful to the user. I wanted to suggest this functionality as we have seen cases in which this new option would be useful to a user. Suggestions for a better name than --approximate-missing-line-numbers would also be appreciated.

Feb 28 2022, 6:57 AM · Restricted Project, Restricted Project
gbreynoo requested review of D120660: [llvm-symbolizer] Add --approximate-missing-line-numbers Command Line Option.
Feb 28 2022, 6:56 AM · Restricted Project, Restricted Project

Feb 3 2022

gbreynoo committed rGd17c54d17de2: [llvm-ar] Prevent automatic conversion from thin to full archive (authored by gbreynoo).
[llvm-ar] Prevent automatic conversion from thin to full archive
Feb 3 2022, 3:46 AM
gbreynoo closed D118693: [llvm-ar] Prevent automatic conversion from thin to full archive.
Feb 3 2022, 3:46 AM · Restricted Project

Feb 2 2022

gbreynoo added a comment to D116979: [llvm-ar] Add --thin for creating a thin archive.

@MaskRay Thanks for clarifying.

Feb 2 2022, 3:48 AM · Restricted Project

Feb 1 2022

gbreynoo accepted D117443: [llvm-ar] -s: don't convert a thin archive to a regular one.
Feb 1 2022, 3:58 AM · Restricted Project
gbreynoo added a comment to D117443: [llvm-ar] -s: don't convert a thin archive to a regular one.

Hi @MaskRay, apologies for the wait in this review. The change LGTM. Regarding the implicit conversion from thin to full archives I think there is a problem there, I've created https://reviews.llvm.org/D118693 to discuss it further.

Feb 1 2022, 3:58 AM · Restricted Project
gbreynoo added a comment to D118693: [llvm-ar] Prevent automatic conversion from thin to full archive.

I believe Gnu-ar commands without T on thin archives do not auto convert to "full" archives:

Feb 1 2022, 3:57 AM · Restricted Project
gbreynoo requested review of D118693: [llvm-ar] Prevent automatic conversion from thin to full archive.
Feb 1 2022, 3:56 AM · Restricted Project
gbreynoo added a comment to D116979: [llvm-ar] Add --thin for creating a thin archive.

Hi @MaskRay, apologies for the wait in this review. I think James brought up a good point regarding gnu ar still using T. I realise that when moving towards consistency someone has to go first, but it maybe worth us waiting until they make the change so we maintain compatibility. Do we know if they have plans to move over to --thin?

Feb 1 2022, 3:36 AM · Restricted Project

Jan 17 2022

gbreynoo abandoned D117208: [X86][LLD] Fix warning from updated data layout in LLD tests.

This issue was resolved.

Jan 17 2022, 2:48 AM · Restricted Project

Jan 13 2022

gbreynoo added a comment to D117208: [X86][LLD] Fix warning from updated data layout in LLD tests.

Due to a private patch we were seeing this warning cause a test failure, hence this diff.

Jan 13 2022, 3:49 AM · Restricted Project
gbreynoo requested review of D117208: [X86][LLD] Fix warning from updated data layout in LLD tests.
Jan 13 2022, 3:48 AM · Restricted Project

Jan 11 2022

gbreynoo added a comment to D116977: [llvm-ar] Enforce one-dash form for long options.

LGTM but I will hold of accepting this revision until James has seen the responses.

Jan 11 2022, 9:06 AM · Restricted Project
gbreynoo added a comment to D116979: [llvm-ar] Add --thin for creating a thin archive.

I understand your hesitation @jhenderson regarding the loss of the short option, maybe a replacement short option could be found?

Jan 11 2022, 8:59 AM · Restricted Project

Jan 5 2022

gbreynoo committed rGb30a18f445ea: [llvm-strings] Remove use of hard coded executable name (authored by gbreynoo).
[llvm-strings] Remove use of hard coded executable name
Jan 5 2022, 6:43 AM
gbreynoo closed D116604: [llvm-strings] Remove use of hard coded executable name.
Jan 5 2022, 6:42 AM · Restricted Project

Jan 4 2022

gbreynoo requested review of D116604: [llvm-strings] Remove use of hard coded executable name.
Jan 4 2022, 8:59 AM · Restricted Project

Dec 7 2021

gbreynoo committed rG9094a2285bfc: [llvm-symbolizer][docs] Update --output-style=JSON example (authored by gbreynoo).
[llvm-symbolizer][docs] Update --output-style=JSON example
Dec 7 2021, 6:22 AM
gbreynoo closed D115164: [llvm-symbolizer][docs] Update --output-style=JSON example.
Dec 7 2021, 6:21 AM · Restricted Project

Dec 6 2021

gbreynoo requested review of D115164: [llvm-symbolizer][docs] Update --output-style=JSON example.
Dec 6 2021, 8:59 AM · Restricted Project

Dec 1 2021

gbreynoo added a comment to D114380: [ARM] Teach getIntImmCostInst about the cost of saturating fp converts.

Hi @dmgreen, I think this change is the cause of CodeGen/ARM/fpclamptosat.ll failing on the clang-x64-windows-msvc build bot.

Dec 1 2021, 6:21 AM · Restricted Project

Nov 4 2021

gbreynoo committed rGced9287c2dff: [llvm-objdump] Fix the Assertion failure when providing invalid --debug-vars or… (authored by gbreynoo).
[llvm-objdump] Fix the Assertion failure when providing invalid --debug-vars or…
Nov 4 2021, 4:04 AM
gbreynoo closed D112183: [llvm-objdump] Fix the Assertion failure when providing invalid --debug-vars or --dwarf values.
Nov 4 2021, 4:04 AM · Restricted Project

Nov 3 2021

gbreynoo updated the diff for D112183: [llvm-objdump] Fix the Assertion failure when providing invalid --debug-vars or --dwarf values.

Fixed James' Nit and reduced the multiple identical calls to llvm-mc

Nov 3 2021, 8:59 AM · Restricted Project

Nov 2 2021

gbreynoo added a comment to D112183: [llvm-objdump] Fix the Assertion failure when providing invalid --debug-vars or --dwarf values.

I have also removed the successful test case from dwarf_invalid.yaml.

Nov 2 2021, 4:10 AM · Restricted Project
gbreynoo updated the diff for D112183: [llvm-objdump] Fix the Assertion failure when providing invalid --debug-vars or --dwarf values.

Fixed comment and added input to llvm-objdump call as suggested by James.

Nov 2 2021, 4:08 AM · Restricted Project

Nov 1 2021

gbreynoo committed rG2b841e4cb9f2: [llvm-dwarfdump] Improve testing of --summarize-types (authored by gbreynoo).
[llvm-dwarfdump] Improve testing of --summarize-types
Nov 1 2021, 4:07 AM
gbreynoo closed D112151: [llvm-dwarfdump] Add a test for --summarize-types.
Nov 1 2021, 4:07 AM · Restricted Project

Oct 29 2021

gbreynoo updated the diff for D112151: [llvm-dwarfdump] Add a test for --summarize-types.

As suggested by dblaikie, now the call with summarize-types dumps -debug-types and not the other sections. To keep the useful check of the type_signature value it has been changed to the LONG prefix check.

Oct 29 2021, 8:28 AM · Restricted Project

Oct 25 2021

gbreynoo added a comment to D112151: [llvm-dwarfdump] Add a test for --summarize-types.

Using -implicit-check-not=DW_TAG fails due to finding the string output in other sections, I think the explicit check might be required.

Oct 25 2021, 9:24 AM · Restricted Project

Oct 22 2021

gbreynoo updated the diff for D112183: [llvm-objdump] Fix the Assertion failure when providing invalid --debug-vars or --dwarf values.

Updated after James' comments and fixed the format issue.

Oct 22 2021, 7:33 AM · Restricted Project
gbreynoo updated the diff for D112151: [llvm-dwarfdump] Add a test for --summarize-types.

Good catch dblaikie, I missed that test and it covers almost all I was testing here. This updated revision adds a check that I think was missing from the existing test.

Oct 22 2021, 6:23 AM · Restricted Project

Oct 20 2021

gbreynoo requested review of D112183: [llvm-objdump] Fix the Assertion failure when providing invalid --debug-vars or --dwarf values.
Oct 20 2021, 2:17 PM · Restricted Project
gbreynoo added a comment to D112151: [llvm-dwarfdump] Add a test for --summarize-types.

I was looking to do this in YAML but I don't think there is support for debug_types?

Oct 20 2021, 9:22 AM · Restricted Project
gbreynoo requested review of D112151: [llvm-dwarfdump] Add a test for --summarize-types.
Oct 20 2021, 9:21 AM · Restricted Project

Oct 18 2021

gbreynoo committed rGf2c144fc1866: [LLD][TEST] Add testing for negative addends for R_X86_64_32 and R_X86_64_PC32… (authored by gbreynoo).
[LLD][TEST] Add testing for negative addends for R_X86_64_32 and R_X86_64_PC32…
Oct 18 2021, 8:39 AM
gbreynoo closed D111803: [LLD][TEST] Add a test case for negative addends for R_X86_64_PC32 relocations.
Oct 18 2021, 8:39 AM · Restricted Project

Oct 15 2021

gbreynoo committed rGa64e6ecfe13f: [llvm-readelf] Make -W an alias of --wide (authored by gbreynoo).
[llvm-readelf] Make -W an alias of --wide
Oct 15 2021, 8:28 AM
gbreynoo closed D111731: [llvm-readelf] Make -W an alias of --wide.
Oct 15 2021, 8:28 AM · Restricted Project
gbreynoo updated the diff for D111803: [LLD][TEST] Add a test case for negative addends for R_X86_64_PC32 relocations.

As suggested by Maskray I have renamed x86-64-reloc-32-fpic.s and added a R_X86_64_32 equivalent of the test. To be consistent x86-64-reloc-pc32-fpic.s was also renamed and the new test case added.
Note that git doesn't appear to detect the renames, it may be best for me to commit the code change and rename separately?

Oct 15 2021, 7:32 AM · Restricted Project

Oct 14 2021

gbreynoo requested review of D111803: [LLD][TEST] Add a test case for negative addends for R_X86_64_PC32 relocations.
Oct 14 2021, 6:53 AM · Restricted Project
gbreynoo added a comment to D111731: [llvm-readelf] Make -W an alias of --wide.

Just to confirm, this does not change the help output.

Oct 14 2021, 2:37 AM · Restricted Project

Oct 13 2021

gbreynoo requested review of D111731: [llvm-readelf] Make -W an alias of --wide.
Oct 13 2021, 8:33 AM · Restricted Project

Oct 7 2021

gbreynoo committed rG14d76a376a41: [llvm-readelf][docs] Add missing options and details to the help output and the… (authored by gbreynoo).
[llvm-readelf][docs] Add missing options and details to the help output and the…
Oct 7 2021, 9:12 AM
gbreynoo closed D111240: [llvm-readelf][docs] Add missing options and details to the help output and the command guide.
Oct 7 2021, 9:11 AM · Restricted Project
gbreynoo added a comment to D110633: [llvm-objdump][docs] Add details to the help output and command guide.

No problem MaskRay, thanks for the review.

Oct 7 2021, 8:33 AM · Restricted Project
gbreynoo committed rG3a5aa57c9b1c: [llvm-objdump][docs] Add details to the help output and command guide (authored by gbreynoo).
[llvm-objdump][docs] Add details to the help output and command guide
Oct 7 2021, 8:31 AM
gbreynoo closed D110633: [llvm-objdump][docs] Add details to the help output and command guide.
Oct 7 2021, 8:31 AM · Restricted Project
gbreynoo committed rG9072183cb634: [llvm-objdump] Fix --prefix and --prefix-strip (authored by gbreynoo).
[llvm-objdump] Fix --prefix and --prefix-strip
Oct 7 2021, 7:54 AM
gbreynoo closed D110551: [llvm-objdump] Fix --prefix and --prefix-strip.
Oct 7 2021, 7:54 AM · Restricted Project

Oct 6 2021

gbreynoo requested review of D111240: [llvm-readelf][docs] Add missing options and details to the help output and the command guide.
Oct 6 2021, 9:29 AM · Restricted Project

Sep 30 2021

gbreynoo updated the diff for D110551: [llvm-objdump] Fix --prefix and --prefix-strip.

Updated after Maskray's comment.

Sep 30 2021, 8:54 AM · Restricted Project
gbreynoo updated the diff for D110633: [llvm-objdump][docs] Add details to the help output and command guide.

Thanks James, updated with your comments.

Sep 30 2021, 7:07 AM · Restricted Project

Sep 28 2021

gbreynoo requested review of D110633: [llvm-objdump][docs] Add details to the help output and command guide.
Sep 28 2021, 8:33 AM · Restricted Project
gbreynoo updated the diff for D110551: [llvm-objdump] Fix --prefix and --prefix-strip.

Updated after Maskray's comment.

Sep 28 2021, 4:30 AM · Restricted Project

Sep 27 2021

gbreynoo added a comment to D110551: [llvm-objdump] Fix --prefix and --prefix-strip.

Looking at the GNU docs its` --prefix=prefix`.

Sep 27 2021, 8:32 AM · Restricted Project
gbreynoo updated the diff for D110551: [llvm-objdump] Fix --prefix and --prefix-strip.

Fixed non windows test.

Sep 27 2021, 8:31 AM · Restricted Project
gbreynoo added a comment to D110551: [llvm-objdump] Fix --prefix and --prefix-strip.

Looking at the other options in llvm-objdump, --option=<value> seems to be the consistent format. For this reason I changed the command line option rather than the user guide, if people disagree I'm happy to change the command guide instead.

Sep 27 2021, 7:33 AM · Restricted Project
gbreynoo requested review of D110551: [llvm-objdump] Fix --prefix and --prefix-strip.
Sep 27 2021, 7:32 AM · Restricted Project
gbreynoo closed D110417: [llvm-dwarfdump][docs] Add missing options to the help output and the command guide.

This was committed in 05b1c7aebfff8cc08a620d01e739f343ed01db6d but I forgot to add the Differential Revision URL. As stated in the Code Reviews with Phabricator User Guide I will close this revision. Apologies for the noise.

Sep 27 2021, 6:41 AM · Restricted Project
gbreynoo added a comment to D110417: [llvm-dwarfdump][docs] Add missing options to the help output and the command guide.
Sep 27 2021, 6:37 AM · Restricted Project
gbreynoo added inline comments to D110417: [llvm-dwarfdump][docs] Add missing options to the help output and the command guide.
Sep 27 2021, 6:31 AM · Restricted Project
gbreynoo committed rG05b1c7aebfff: [llvm-dwarfdump][docs] Add missing options to the help output and the command… (authored by gbreynoo).
[llvm-dwarfdump][docs] Add missing options to the help output and the command…
Sep 27 2021, 6:30 AM

Sep 24 2021

gbreynoo requested review of D110417: [llvm-dwarfdump][docs] Add missing options to the help output and the command guide.
Sep 24 2021, 7:04 AM · Restricted Project
gbreynoo committed rG3bad9616aa52: [llvm-objcopy][docs] Add missing options to the help output and the command… (authored by gbreynoo).
[llvm-objcopy][docs] Add missing options to the help output and the command…
Sep 24 2021, 1:45 AM
gbreynoo closed D110340: [llvm-objcopy][docs] Add missing options to the help output and the command guide.
Sep 24 2021, 1:45 AM · Restricted Project

Sep 23 2021

gbreynoo requested review of D110340: [llvm-objcopy][docs] Add missing options to the help output and the command guide.
Sep 23 2021, 9:17 AM · Restricted Project

Sep 3 2021

gbreynoo added a comment to D108770: [OptTable] Improve error message output for grouped short options.

Thanks for the revert @kda, I've reapplied with a fix.

Sep 3 2021, 3:17 AM · Restricted Project