User Details
- User Since
- Jan 19 2017, 6:04 AM (322 w, 5 d)
Nov 18 2022
Nov 17 2022
Oct 25 2022
Apologies @jdenny, the failure was occurring on a private build job and has no public access. The test failure can be found below:
Oct 24 2022
Updated after jdenny's suggested regex change.
Oct 21 2022
Intermittent error below:
[09:50:05] : [Step 3/3] next:10'0 X error: no match found [09:50:05] : [Step 3/3] 11: "elapsed": 7.295608520507812e-05,
Jul 21 2022
Thanks that LGTM.
Jul 19 2022
I think my comment got eaten. Sorry for the delay @jhenderson. I've had a look, particularly at the section highlighted, and I this is the best place for this check. The best I can suggest is the use of a lambda or new function to tidy the IA_AddNewMember and IA_MoveNewMember cases. Something like:
auto handleNewMembers = [&](auto Members, auto MemberI, auto Child) { NewArchiveMember NM = getArchiveMember(*MemberI); if (isValidInBitMode(NM)) addMember(Members, NM); else { // If a new member is not a valid object for the bit mode, add the old // member back. warnInvalidObjectForFileMode(*MemberI); addChildMember(Members, Child, /*FlattenArchive=*/Thin); } };
Jul 18 2022
The issue stemmed from the output of sort differing between OS, removing it's use should fix things.
Jul 15 2022
Currently testing on other machines.
Jul 14 2022
Thanks, reverting
Jul 6 2022
Removed missed use of %t.
Combined tests into one file, added us of --implicit-check-not, supressed archive creation warnings and fixed comments.
Jul 4 2022
Jun 30 2022
Fixed whitespace, comments and use of empty mri script.
Jun 29 2022
Jun 27 2022
Jun 24 2022
Updated error message check.
Updated with use of --match-full-lines.
Jun 23 2022
Fixed whitespace, added UNSUPPORTED: system-aix, placed rm, split-file, mkdir on one line, added explicit prefix and improved error message.
Fixed comments, added use of errc_NOENT and COUNT-2, added missing coverage of SAVE between calls to CREATE and improved error message.
Jun 17 2022
Jun 14 2022
Jun 13 2022
May 12 2022
Thanks for fixing this Ben, once James' suggestions are fixed it LGTM.
Apr 28 2022
@urnathan I've created the ticket https://github.com/llvm/llvm-project/issues/55171 regarding the mangling issue. Just to note here, above I mentioned that I thought the mangled output matched GCC but this is not the case.
Apr 27 2022
Updated with urnathan's suggestion.
Apr 26 2022
This looks like a good change to me, just needs that ranlib test fixing.
Move testing to area suggested by @urnathan.
Apr 21 2022
Apr 20 2022
Fixed failing test and @jhenderson's other points.
Apr 19 2022
I am not so familiar with this part of LLVM, I think this testing may belong elsewhere but I am unsure where that would be.
Updated after https://reviews.llvm.org/D123778 was accepted and committed.
Apr 14 2022
Good idea @MaskRay, I've split that into https://reviews.llvm.org/D123778 and will update this one when D123778 is complete.
Apr 13 2022
Corrected comments including replacing use of "full archive" with "regular archive" as suggested. To remain consistent two tests have been renamed to use the term "regular". The checks for "thinness" in llvm-ar.cpp now only applies for write commands.
Apr 5 2022
The following tests have been modified:
- flatten-thin-archive.test now explicitly checks that %t.a is thin after the other archives have been added.
- full-to-thin-archive.test uses Inputs/a.txt as an input rather than itself as spurious passes could have occurred when looking for strings contained in the archive file. Corrected a comment, added a test case for an existing archive and a case attempting to convert an existing archive.
- thin-to-full-archive.test now tests the contents to ensure the thin archives member have been added and not the archive itself. Added a test case for an existing archive and a case attempting to convert an existing archive.
Apr 4 2022
Apr 1 2022
Fixed the description after abrachet's comment and updated the help output to mirror the change.
Mar 17 2022
LGTM
Feb 28 2022
To be clear this new output is an approximation for cases in which the canonical line number is 0 and so not too helpful to the user. I wanted to suggest this functionality as we have seen cases in which this new option would be useful to a user. Suggestions for a better name than --approximate-missing-line-numbers would also be appreciated.
Feb 3 2022
Feb 2 2022
@MaskRay Thanks for clarifying.
Feb 1 2022
Hi @MaskRay, apologies for the wait in this review. The change LGTM. Regarding the implicit conversion from thin to full archives I think there is a problem there, I've created https://reviews.llvm.org/D118693 to discuss it further.
I believe Gnu-ar commands without T on thin archives do not auto convert to "full" archives:
Hi @MaskRay, apologies for the wait in this review. I think James brought up a good point regarding gnu ar still using T. I realise that when moving towards consistency someone has to go first, but it maybe worth us waiting until they make the change so we maintain compatibility. Do we know if they have plans to move over to --thin?
Jan 17 2022
This issue was resolved.
Jan 13 2022
Due to a private patch we were seeing this warning cause a test failure, hence this diff.
Jan 11 2022
LGTM but I will hold of accepting this revision until James has seen the responses.
I understand your hesitation @jhenderson regarding the loss of the short option, maybe a replacement short option could be found?