Page MenuHomePhabricator

gbreynoo (Owen Reynolds)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 19 2017, 6:04 AM (167 w, 5 d)

Recent Activity

Thu, Mar 26

gbreynoo committed rGa945037e8fd0: Tools emit the bug report URL on crash (authored by gbreynoo).
Tools emit the bug report URL on crash
Thu, Mar 26, 3:45 AM
gbreynoo closed D74324: Tools emit the bug report URL on crash.
Thu, Mar 26, 3:45 AM · Restricted Project, Restricted Project

Wed, Mar 25

gbreynoo updated the diff for D74324: Tools emit the bug report URL on crash.

Apologies James, this fixes the case issues.

Wed, Mar 25, 4:50 AM · Restricted Project, Restricted Project

Mon, Mar 23

gbreynoo updated the diff for D74324: Tools emit the bug report URL on crash.

Changes made in response to James' comments

Mon, Mar 23, 12:00 PM · Restricted Project, Restricted Project
gbreynoo added inline comments to D74324: Tools emit the bug report URL on crash.
Mon, Mar 23, 12:00 PM · Restricted Project, Restricted Project

Thu, Mar 19

gbreynoo added a comment to D74324: Tools emit the bug report URL on crash.

Thanks Paul.

Thu, Mar 19, 8:40 AM · Restricted Project, Restricted Project
gbreynoo updated the diff for D74324: Tools emit the bug report URL on crash.

After Paul's comment, a custom message can now be used to replace the generic one.

Thu, Mar 19, 8:37 AM · Restricted Project, Restricted Project

Wed, Mar 11

gbreynoo added reviewers for D74324: Tools emit the bug report URL on crash: bogner, bruno.

Hi James,

Wed, Mar 11, 8:31 AM · Restricted Project, Restricted Project
gbreynoo updated the diff for D74324: Tools emit the bug report URL on crash.

Removed Clangs use of the same message.

Wed, Mar 11, 8:31 AM · Restricted Project, Restricted Project

Mar 4 2020

gbreynoo committed rG5e0f9d5d3c6b: [llvm-ar][test] Add to llvm-ar test coverage (authored by gbreynoo).
[llvm-ar][test] Add to llvm-ar test coverage
Mar 4 2020, 3:28 AM
gbreynoo closed D73333: [llvm-ar][test] Add to llvm-ar test coverage .
Mar 4 2020, 3:27 AM · Restricted Project
gbreynoo added a comment to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.

Hi sbc100, thanks for highlighting this inconsistency, I think wasm-ld and clang need updating too. Would it be worth the effort to have some kind of shared implementation for this?

Mar 4 2020, 1:13 AM · Restricted Project

Mar 3 2020

gbreynoo committed rG62fa3332c9c1: [llvm-ar] Fix llvm-ar response file reading on Windows (authored by gbreynoo).
[llvm-ar] Fix llvm-ar response file reading on Windows
Mar 3 2020, 5:46 AM
gbreynoo closed D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.
Mar 3 2020, 5:45 AM · Restricted Project

Mar 2 2020

gbreynoo added a reviewer for D74324: Tools emit the bug report URL on crash: jhenderson.
Mar 2 2020, 8:29 AM · Restricted Project, Restricted Project
gbreynoo added a comment to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.

ping

Mar 2 2020, 5:29 AM · Restricted Project

Feb 24 2020

gbreynoo added inline comments to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.
Feb 24 2020, 7:53 AM · Restricted Project
gbreynoo updated the diff for D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.
  • Removed unused function removeHyphens
  • Fixed matchFlagWithArg so 3 hyphens are no longer excepted before an argument
  • getRspQuoting now uses ArraryRef instead of SmallVector
Feb 24 2020, 7:53 AM · Restricted Project

Feb 21 2020

gbreynoo added a comment to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.

ping

Feb 21 2020, 6:51 AM · Restricted Project
gbreynoo added a comment to D74324: Tools emit the bug report URL on crash.

ping

Feb 21 2020, 4:17 AM · Restricted Project, Restricted Project
gbreynoo added a reviewer for D74324: Tools emit the bug report URL on crash: dsanders.
Feb 21 2020, 4:17 AM · Restricted Project, Restricted Project

Feb 18 2020

gbreynoo added a comment to D74599: llvm-ar: Fix MinGW compilation.

I agree with mstorsjo, matching what what LLVM is documented to require seems best.
LGTM

Feb 18 2020, 7:39 AM · Restricted Project

Feb 14 2020

gbreynoo added a comment to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.

Thanks Maskray for your comment regarding marking comments as "done", I'll look out for that in future.

Feb 14 2020, 5:46 AM · Restricted Project
gbreynoo updated the diff for D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.

Inlined removeHyphens function

Feb 14 2020, 5:46 AM · Restricted Project
gbreynoo added inline comments to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.
Feb 14 2020, 5:38 AM · Restricted Project

Feb 13 2020

gbreynoo added a reviewer for D74324: Tools emit the bug report URL on crash: chandlerc.
Feb 13 2020, 5:41 AM · Restricted Project, Restricted Project

Feb 10 2020

gbreynoo created D74324: Tools emit the bug report URL on crash.
Feb 10 2020, 6:44 AM · Restricted Project, Restricted Project
gbreynoo added a comment to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.

ping

Feb 10 2020, 6:05 AM · Restricted Project

Jan 24 2020

gbreynoo added a comment to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.

ping

Jan 24 2020, 1:00 AM · Restricted Project
gbreynoo created D73333: [llvm-ar][test] Add to llvm-ar test coverage .
Jan 24 2020, 1:00 AM · Restricted Project
gbreynoo added a child revision for D69665: [llvm-ar] Fix llvm-ar response file reading on Windows: D73333: [llvm-ar][test] Add to llvm-ar test coverage .
Jan 24 2020, 1:00 AM · Restricted Project

Jan 16 2020

gbreynoo updated the diff for D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.

The use of python in the test response.test was failing on my Windows machine with Python 3. This patch fixes the issue.

Jan 16 2020, 9:44 AM · Restricted Project
gbreynoo added inline comments to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.
Jan 16 2020, 9:44 AM · Restricted Project
gbreynoo updated the diff for D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.
  • Use single quotes in tests
  • Clarify use of echo in response.test
Jan 16 2020, 9:34 AM · Restricted Project

Jan 10 2020

gbreynoo added a comment to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.

ping

Jan 10 2020, 5:47 AM · Restricted Project

Jan 2 2020

gbreynoo added inline comments to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.
Jan 2 2020, 9:19 AM · Restricted Project
gbreynoo updated the diff for D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.
  • Removed --rsp-quoting=default
    • Reverted rename of Options
    • Removed use of using
Jan 2 2020, 9:10 AM · Restricted Project

Dec 12 2019

gbreynoo added a comment to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.

ping

Dec 12 2019, 8:23 AM · Restricted Project

Dec 4 2019

gbreynoo added inline comments to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.
Dec 4 2019, 10:59 AM · Restricted Project
gbreynoo updated the diff for D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.

Fixed:

  • Redundant pair of braces
  • space after ,
  • indent the continuation lines
Dec 4 2019, 10:19 AM · Restricted Project
gbreynoo committed rG8c1e1d148273: [llvm-ar][test] Add to thin archive test coverage (authored by gbreynoo).
[llvm-ar][test] Add to thin archive test coverage
Dec 4 2019, 8:27 AM
gbreynoo closed D70969: [llvm-ar][test] Add to thin archive test coverage .
Dec 4 2019, 8:27 AM · Restricted Project

Dec 3 2019

gbreynoo created D70969: [llvm-ar][test] Add to thin archive test coverage .
Dec 3 2019, 10:05 AM · Restricted Project
gbreynoo added inline comments to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.
Dec 3 2019, 9:28 AM · Restricted Project
gbreynoo updated the diff for D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.
  • Use using instead of typedef
  • removeHyphens is now called from matchFlagWithArg
  • Removed Argv reference argument from getRspQuoting
  • Fix response.test that failed on linux
Dec 3 2019, 8:50 AM · Restricted Project

Nov 22 2019

gbreynoo updated the diff for D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.
  • Pulled out the MatchFlagWithArg lambda expression into static function, and done the same with some code that handles hyphen removal.
  • Added test cases to response.test.
  • Removed the python call in response-utf8.test. I would prefer the file comparison but it should be sufficient to show the archive is functioning properly.
Nov 22 2019, 9:31 AM · Restricted Project

Nov 13 2019

gbreynoo updated the diff for D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.

Added rsp-quoting switch as thopre requested.

Nov 13 2019, 3:38 AM · Restricted Project

Nov 4 2019

gbreynoo added inline comments to D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.
Nov 4 2019, 6:00 AM · Restricted Project

Oct 31 2019

gbreynoo created D69665: [llvm-ar] Fix llvm-ar response file reading on Windows.
Oct 31 2019, 9:05 AM · Restricted Project
gbreynoo set the repository for D69665: [llvm-ar] Fix llvm-ar response file reading on Windows to rL LLVM.
Oct 31 2019, 9:05 AM · Restricted Project

Oct 25 2019

gbreynoo added a reviewer for D69418: [llvm-ar] Add output option for extract operation: ruiu.

This looks good to me, although with llvm-ar there is a balance between adding useful functionality and keeping command compatibility with other archivers. I've added Rui as a reviewer in case.

Oct 25 2019, 3:15 AM · Restricted Project

Oct 24 2019

gbreynoo abandoned D69343: [llvm-ar] Allow MRI scripts to be passed via command line argument .

Rui makes good points that I struggle to argue with. I'll abandon this review as their is no interest.

Oct 24 2019, 5:53 AM · Restricted Project

Oct 23 2019

gbreynoo created D69343: [llvm-ar] Allow MRI scripts to be passed via command line argument .
Oct 23 2019, 8:42 AM · Restricted Project

Oct 21 2019

gbreynoo committed rGfe263c4f0f8b: [docs][llvm-ar] Update llvm-ar command guide (authored by gbreynoo).
[docs][llvm-ar] Update llvm-ar command guide
Oct 21 2019, 6:16 AM
gbreynoo committed rL375412: [docs][llvm-ar] Update llvm-ar command guide.
[docs][llvm-ar] Update llvm-ar command guide
Oct 21 2019, 6:16 AM
gbreynoo closed D68998: [docs][llvm-ar] Update llvm-ar command guide.
Oct 21 2019, 6:16 AM · Restricted Project

Oct 17 2019

gbreynoo updated the diff for D68998: [docs][llvm-ar] Update llvm-ar command guide.

Fixed two format issues.

Oct 17 2019, 7:58 AM · Restricted Project
gbreynoo added inline comments to D68998: [docs][llvm-ar] Update llvm-ar command guide.
Oct 17 2019, 7:49 AM · Restricted Project
gbreynoo updated the diff for D68998: [docs][llvm-ar] Update llvm-ar command guide.

Renamed "Long Options" to "Other" and moved it below the other options, removed bad link to gnu-ar and updated with changes from D69087.

Oct 17 2019, 7:39 AM · Restricted Project
gbreynoo accepted D69087: [llvm-ar] Implement the O modifier: display member offsets inside the archive.

LGTM

Oct 17 2019, 4:01 AM · Restricted Project

Oct 16 2019

gbreynoo added inline comments to D68998: [docs][llvm-ar] Update llvm-ar command guide.
Oct 16 2019, 9:04 AM · Restricted Project
gbreynoo updated the diff for D68998: [docs][llvm-ar] Update llvm-ar command guide.

Fix nits, add missing options, remove old limitation and add information regarding deterministic archives.

Oct 16 2019, 8:55 AM · Restricted Project
gbreynoo committed rG28a3b2aeb48f: [llvm-ar] Make paths case insensitive when on windows (authored by gbreynoo).
[llvm-ar] Make paths case insensitive when on windows
Oct 16 2019, 7:11 AM
gbreynoo closed D68033: [llvm-ar] Make paths case insensitive when on windows.
Oct 16 2019, 7:11 AM · Restricted Project
gbreynoo committed rL375002: [llvm-ar] Make paths case insensitive when on windows.
[llvm-ar] Make paths case insensitive when on windows
Oct 16 2019, 7:11 AM
gbreynoo accepted D69007: [llvm-ar] Implement the V modifier as an alias for --version.

LGTM

Oct 16 2019, 4:06 AM · Restricted Project

Oct 15 2019

gbreynoo created D68998: [docs][llvm-ar] Update llvm-ar command guide.
Oct 15 2019, 10:11 AM · Restricted Project
gbreynoo added inline comments to D68033: [llvm-ar] Make paths case insensitive when on windows.
Oct 15 2019, 9:33 AM · Restricted Project
gbreynoo updated the diff for D68033: [llvm-ar] Make paths case insensitive when on windows.

Updated llvm-ar doc to clarify non-windows behaviour and why windows is not Unicode compliant.

Oct 15 2019, 8:47 AM · Restricted Project

Oct 11 2019

gbreynoo added inline comments to D68033: [llvm-ar] Make paths case insensitive when on windows.
Oct 11 2019, 9:56 AM · Restricted Project
gbreynoo added a comment to D68033: [llvm-ar] Make paths case insensitive when on windows.

Due to updating the command guide I have not added the case insensitivity details to the llvm-ar help text. Would it be preferred to have these details in both?

Oct 11 2019, 9:56 AM · Restricted Project
gbreynoo updated the diff for D68033: [llvm-ar] Make paths case insensitive when on windows.

Update llvm-ar command guide with case insensitivity details, and include a test for archived files with paths for names.

Oct 11 2019, 9:56 AM · Restricted Project

Oct 10 2019

gbreynoo added a comment to D68472: [test] Use system locale for mri-utf8.test.

I added the XFAIL to 3 llvm-ar tests I added earlier in the year, due to them failing on Darwin systems. See below:

Oct 10 2019, 7:44 AM · Restricted Project

Oct 8 2019

gbreynoo added a comment to D68472: [test] Use system locale for mri-utf8.test.

Thanks for adding the BOM. With the BOM, would it make sense to leave mri-utf8.test as the name of the file?

I think the testfile name should reflect what is being tested since that's the test identifier (ie. when a test fails lit prints the relative filepath) so the fact that the file is encoded in UTF-8 is irrelevant. Here the test is about llvm-ar handling non ascii filename, as the first comment explains it. How is the <pound sign>.txt file encoded would make a bit more sense as a name but then as I mentioned AFAIK the filename is encoded in UTF-16 on Windows anywat. In summary, I think the renaming is warranted.

Oct 8 2019, 8:45 AM · Restricted Project
gbreynoo added a comment to D68472: [test] Use system locale for mri-utf8.test.

This functions on Windows fine.

Oct 8 2019, 8:35 AM · Restricted Project
gbreynoo added inline comments to D68472: [test] Use system locale for mri-utf8.test.
Oct 8 2019, 8:35 AM · Restricted Project
gbreynoo added inline comments to D68033: [llvm-ar] Make paths case insensitive when on windows.
Oct 8 2019, 7:19 AM · Restricted Project
gbreynoo updated the diff for D68033: [llvm-ar] Make paths case insensitive when on windows.

Removed unneeded const, swapped use of ifndef and added comment to comparePaths function.

Oct 8 2019, 6:42 AM · Restricted Project

Oct 4 2019

gbreynoo committed rGe64369e76ea4: [llvm-ar][test] Clarified comment (authored by gbreynoo).
[llvm-ar][test] Clarified comment
Oct 4 2019, 5:26 AM
gbreynoo committed rL373737: [llvm-ar][test] Clarified comment.
[llvm-ar][test] Clarified comment
Oct 4 2019, 5:24 AM
gbreynoo added a comment to D68418: [test] Remove locale dependency for mri-utf8.test.

I reverted this change due to the clang-x64-windows-msvc build bot failure.

Oct 4 2019, 4:13 AM · Restricted Project
gbreynoo committed rG4682b9c46b27: Revert [test] Remove locale dependency for mri-utf8.test (authored by gbreynoo).
Revert [test] Remove locale dependency for mri-utf8.test
Oct 4 2019, 4:13 AM
gbreynoo committed rL373728: Revert [test] Remove locale dependency for mri-utf8.test.
Revert [test] Remove locale dependency for mri-utf8.test
Oct 4 2019, 4:11 AM
gbreynoo added a comment to D68418: [test] Remove locale dependency for mri-utf8.test.

You are correct that the locale is required to pass on linux. I had some trouble with this test as the behaviour of python in this area differs between linux / windows and python 2 / python 3. For example this fix appears to be fine for linux, however Windows with python 2 fails:

Oct 4 2019, 3:43 AM · Restricted Project

Oct 3 2019

gbreynoo updated the diff for D68033: [llvm-ar] Make paths case insensitive when on windows.

Updated after Edd and Ruiu's suggestion.

Oct 3 2019, 8:41 AM · Restricted Project

Oct 1 2019

gbreynoo added inline comments to D68033: [llvm-ar] Make paths case insensitive when on windows.
Oct 1 2019, 11:09 AM · Restricted Project
gbreynoo added a comment to D68033: [llvm-ar] Make paths case insensitive when on windows.

I asked because I want to make sure this patch is put up for practical use, not for a compatibility corner case that may rarely matter. I think most people may realize case insensitiveness on file systems is a bad idea. If my understanding is correct, llvm-lib used by Windows. llvm-ar is an ELF tool and it should match a generic ELF platform as close as possible and such platform disparity should be as little as possible.

Oct 1 2019, 11:08 AM · Restricted Project
gbreynoo updated the diff for D68033: [llvm-ar] Make paths case insensitive when on windows.

Updated after rupprecht's suggestion.

Oct 1 2019, 10:43 AM · Restricted Project

Sep 30 2019

gbreynoo added a comment to D68033: [llvm-ar] Make paths case insensitive when on windows.

My understanding is that although NTFS is case sensitive, the windows API makes file operations case insensitive by default.

Sep 30 2019, 7:31 AM · Restricted Project
gbreynoo added a comment to D67839: [FPEnv] Document requirement of function attributes with constrained floating point.

This is failing on the sphinx build bot:
lab.llvm.org:8011/builders/llvm-sphinx-docs

Sep 30 2019, 6:33 AM · Restricted Project

Sep 27 2019

gbreynoo added inline comments to D68033: [llvm-ar] Make paths case insensitive when on windows.
Sep 27 2019, 11:13 AM · Restricted Project
gbreynoo updated the diff for D68033: [llvm-ar] Make paths case insensitive when on windows.
Sep 27 2019, 11:05 AM · Restricted Project

Sep 26 2019

gbreynoo committed rGb4e2d471f762: [llvm-ar][test] Move MRI tests from "llvm/test/Object/" (authored by gbreynoo).
[llvm-ar][test] Move MRI tests from "llvm/test/Object/"
Sep 26 2019, 5:32 AM
gbreynoo committed rL372973: [llvm-ar][test] Move MRI tests from "llvm/test/Object/".
[llvm-ar][test] Move MRI tests from "llvm/test/Object/"
Sep 26 2019, 5:30 AM
gbreynoo closed D68038: [llvm-ar][test] Move MRI tests from "llvm/test/Object/".
Sep 26 2019, 5:30 AM · Restricted Project

Sep 25 2019

gbreynoo added a comment to D68038: [llvm-ar][test] Move MRI tests from "llvm/test/Object/".

There are many tests in this area that use llvm-ar to test the underlying library. It may be better for these also to be in the llvm-ar test directory and have unit tests for specifically testing ArchiveWriter?

Sep 25 2019, 10:36 AM · Restricted Project
gbreynoo created D68038: [llvm-ar][test] Move MRI tests from "llvm/test/Object/".
Sep 25 2019, 10:30 AM · Restricted Project
gbreynoo created D68033: [llvm-ar] Make paths case insensitive when on windows.
Sep 25 2019, 9:15 AM · Restricted Project
gbreynoo closed D47324: Add llvm-bcanalyzer as an LLD test dependency.
Sep 25 2019, 5:44 AM · Restricted Project
gbreynoo abandoned D43942: [lld] Fix handling of output section selection for unmerged mergeable inputs and relocatable output.
Sep 25 2019, 5:39 AM