Page MenuHomePhabricator

gbreynoo (Owen Reynolds)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 19 2017, 6:04 AM (322 w, 5 d)

Recent Activity

Nov 18 2022

gbreynoo added inline comments to D138218: [llvm-ar] Fix when llvm-ar fails to replace existing members when updating a thin archive.
Nov 18 2022, 6:45 AM · Restricted Project, Restricted Project
gbreynoo committed rGdcbf61b3520e: [llvm-ar] Fix when llvm-ar fails to replace existing members when updating a… (authored by gbreynoo).
[llvm-ar] Fix when llvm-ar fails to replace existing members when updating a…
Nov 18 2022, 6:43 AM · Restricted Project, Restricted Project
gbreynoo closed D138218: [llvm-ar] Fix when llvm-ar fails to replace existing members when updating a thin archive.
Nov 18 2022, 6:43 AM · Restricted Project, Restricted Project

Nov 17 2022

gbreynoo requested review of D138218: [llvm-ar] Fix when llvm-ar fails to replace existing members when updating a thin archive.
Nov 17 2022, 8:50 AM · Restricted Project, Restricted Project

Oct 25 2022

gbreynoo added a comment to D136469: [llvm-lit][test] Fix regex to capture scientific notation.

Apologies @jdenny, the failure was occurring on a private build job and has no public access. The test failure can be found below:

Oct 25 2022, 8:22 AM · Restricted Project, Restricted Project
gbreynoo committed rG33601f425540: [llvm-lit][test] Fix regex to capture scientific notation (authored by gbreynoo).
[llvm-lit][test] Fix regex to capture scientific notation
Oct 25 2022, 8:06 AM · Restricted Project, Restricted Project
gbreynoo closed D136469: [llvm-lit][test] Fix regex to capture scientific notation.
Oct 25 2022, 8:05 AM · Restricted Project, Restricted Project

Oct 24 2022

gbreynoo added inline comments to D136469: [llvm-lit][test] Fix regex to capture scientific notation.
Oct 24 2022, 7:44 AM · Restricted Project, Restricted Project
gbreynoo updated the diff for D136469: [llvm-lit][test] Fix regex to capture scientific notation.

Updated after jdenny's suggested regex change.

Oct 24 2022, 7:38 AM · Restricted Project, Restricted Project

Oct 21 2022

gbreynoo added a comment to D136469: [llvm-lit][test] Fix regex to capture scientific notation.

Intermittent error below:

[09:50:05] :	 [Step 3/3] next:10'0                     X error: no match found
[09:50:05] :	 [Step 3/3]           11:  "elapsed": 7.295608520507812e-05,
Oct 21 2022, 10:26 AM · Restricted Project, Restricted Project
gbreynoo requested review of D136469: [llvm-lit][test] Fix regex to capture scientific notation.
Oct 21 2022, 10:24 AM · Restricted Project, Restricted Project

Jul 21 2022

gbreynoo added a comment to D127864: [llvm-ar] Add object mode option -X for AIX.

Thanks that LGTM.

Jul 21 2022, 7:10 AM · Restricted Project, Restricted Project

Jul 19 2022

gbreynoo added a comment to D127864: [llvm-ar] Add object mode option -X for AIX.

I think my comment got eaten. Sorry for the delay @jhenderson. I've had a look, particularly at the section highlighted, and I this is the best place for this check. The best I can suggest is the use of a lambda or new function to tidy the IA_AddNewMember and IA_MoveNewMember cases. Something like:

auto handleNewMembers = [&](auto Members, auto MemberI, auto Child) {
  NewArchiveMember NM = getArchiveMember(*MemberI);
  if (isValidInBitMode(NM))
    addMember(Members, NM);
  else {
    // If a new member is not a valid object for the bit mode, add the old
    // member back.
    warnInvalidObjectForFileMode(*MemberI);
    addChildMember(Members, Child,
                   /*FlattenArchive=*/Thin);
  }
};
Jul 19 2022, 4:14 AM · Restricted Project, Restricted Project
gbreynoo added inline comments to D127864: [llvm-ar] Add object mode option -X for AIX.
Jul 19 2022, 4:08 AM · Restricted Project, Restricted Project

Jul 18 2022

gbreynoo committed rG55b556e60c06: [llvm-size] Fix hang waiting for input on invalid short commandline option (authored by gbreynoo).
[llvm-size] Fix hang waiting for input on invalid short commandline option
Jul 18 2022, 7:02 AM · Restricted Project, Restricted Project
gbreynoo closed D129866: [llvm-size] Fix hang on invalid short commandline option.
Jul 18 2022, 7:02 AM · Restricted Project, Restricted Project
gbreynoo added a comment to D129088: [llvm-ar][test] Add testing for bitcode file handling.

The issue stemmed from the output of sort differing between OS, removing it's use should fix things.

Jul 18 2022, 6:49 AM · Restricted Project, Restricted Project
gbreynoo committed rGe97a6f6104cc: [llvm-ar][test] Add testing for bitcode file handling (authored by gbreynoo).
[llvm-ar][test] Add testing for bitcode file handling
Jul 18 2022, 6:47 AM · Restricted Project, Restricted Project

Jul 15 2022

gbreynoo added a comment to D129088: [llvm-ar][test] Add testing for bitcode file handling.

Currently testing on other machines.

Jul 15 2022, 8:58 AM · Restricted Project, Restricted Project
gbreynoo requested review of D129866: [llvm-size] Fix hang on invalid short commandline option.
Jul 15 2022, 8:41 AM · Restricted Project, Restricted Project

Jul 14 2022

gbreynoo added a reverting change for rG264b9a4885e6: [llvm-ar][test] Add testing for bitcode file handling: rG8564b2ab4932: Revert "[llvm-ar][test] Add testing for bitcode file handling".
Jul 14 2022, 4:06 AM · Restricted Project, Restricted Project
gbreynoo committed rG8564b2ab4932: Revert "[llvm-ar][test] Add testing for bitcode file handling" (authored by gbreynoo).
Revert "[llvm-ar][test] Add testing for bitcode file handling"
Jul 14 2022, 4:06 AM · Restricted Project, Restricted Project
gbreynoo added a reverting change for D129088: [llvm-ar][test] Add testing for bitcode file handling: rG8564b2ab4932: Revert "[llvm-ar][test] Add testing for bitcode file handling".
Jul 14 2022, 4:06 AM · Restricted Project, Restricted Project
gbreynoo added a comment to D129088: [llvm-ar][test] Add testing for bitcode file handling.

Thanks, reverting

Jul 14 2022, 4:03 AM · Restricted Project, Restricted Project
gbreynoo committed rG264b9a4885e6: [llvm-ar][test] Add testing for bitcode file handling (authored by gbreynoo).
[llvm-ar][test] Add testing for bitcode file handling
Jul 14 2022, 2:56 AM · Restricted Project, Restricted Project
gbreynoo closed D129088: [llvm-ar][test] Add testing for bitcode file handling.
Jul 14 2022, 2:56 AM · Restricted Project, Restricted Project

Jul 6 2022

gbreynoo updated the diff for D129088: [llvm-ar][test] Add testing for bitcode file handling.

Removed missed use of %t.

Jul 6 2022, 9:35 AM · Restricted Project, Restricted Project
gbreynoo added inline comments to D129088: [llvm-ar][test] Add testing for bitcode file handling.
Jul 6 2022, 9:31 AM · Restricted Project, Restricted Project
gbreynoo updated the diff for D129088: [llvm-ar][test] Add testing for bitcode file handling.

Combined tests into one file, added us of --implicit-check-not, supressed archive creation warnings and fixed comments.

Jul 6 2022, 9:26 AM · Restricted Project, Restricted Project

Jul 4 2022

gbreynoo requested review of D129088: [llvm-ar][test] Add testing for bitcode file handling.
Jul 4 2022, 9:00 AM · Restricted Project, Restricted Project
gbreynoo committed rG2ab260eecfab: [llvm-ar][test] Add additional MRI script testing (authored by gbreynoo).
[llvm-ar][test] Add additional MRI script testing
Jul 4 2022, 6:25 AM · Restricted Project, Restricted Project
gbreynoo closed D128838: [llvm-ar][test] Add additional MRI script testing.
Jul 4 2022, 6:24 AM · Restricted Project, Restricted Project

Jun 30 2022

gbreynoo updated the diff for D128838: [llvm-ar][test] Add additional MRI script testing.

Fixed whitespace, comments and use of empty mri script.

Jun 30 2022, 8:57 AM · Restricted Project, Restricted Project

Jun 29 2022

gbreynoo added inline comments to D128838: [llvm-ar][test] Add additional MRI script testing.
Jun 29 2022, 10:22 AM · Restricted Project, Restricted Project
gbreynoo requested review of D128838: [llvm-ar][test] Add additional MRI script testing.
Jun 29 2022, 10:22 AM · Restricted Project, Restricted Project

Jun 27 2022

gbreynoo committed rG6a1e5f5a7111: [llvm-ar] Fix MRI ADDLIB command when used with thin archives (authored by gbreynoo).
[llvm-ar] Fix MRI ADDLIB command when used with thin archives
Jun 27 2022, 9:11 AM · Restricted Project, Restricted Project
gbreynoo closed D128067: [llvm-ar] Fix MRI ADDLIB command when used with thin archives.
Jun 27 2022, 9:11 AM · Restricted Project, Restricted Project
gbreynoo committed rG7de277d684fd: [llvm-ar] Improve MRI script CREATE command handling (authored by gbreynoo).
[llvm-ar] Improve MRI script CREATE command handling
Jun 27 2022, 3:12 AM · Restricted Project, Restricted Project
gbreynoo closed D128055: [llvm-ar] Improve MRI script CREATE command handling.
Jun 27 2022, 3:11 AM · Restricted Project, Restricted Project
gbreynoo added inline comments to D128626: [llvm-ar] Add --output to specify output directory.
Jun 27 2022, 2:40 AM · Restricted Project, Restricted Project

Jun 24 2022

gbreynoo added inline comments to D128055: [llvm-ar] Improve MRI script CREATE command handling.
Jun 24 2022, 9:59 AM · Restricted Project, Restricted Project
gbreynoo updated the diff for D128055: [llvm-ar] Improve MRI script CREATE command handling.

Updated error message check.

Jun 24 2022, 9:59 AM · Restricted Project, Restricted Project
gbreynoo updated the diff for D128067: [llvm-ar] Fix MRI ADDLIB command when used with thin archives.

Updated with use of --match-full-lines.

Jun 24 2022, 9:45 AM · Restricted Project, Restricted Project

Jun 23 2022

gbreynoo added inline comments to D128067: [llvm-ar] Fix MRI ADDLIB command when used with thin archives.
Jun 23 2022, 10:10 AM · Restricted Project, Restricted Project
gbreynoo updated the diff for D128067: [llvm-ar] Fix MRI ADDLIB command when used with thin archives.

Fixed whitespace, added UNSUPPORTED: system-aix, placed rm, split-file, mkdir on one line, added explicit prefix and improved error message.

Jun 23 2022, 10:08 AM · Restricted Project, Restricted Project
gbreynoo added inline comments to D128055: [llvm-ar] Improve MRI script CREATE command handling.
Jun 23 2022, 10:04 AM · Restricted Project, Restricted Project
gbreynoo updated the diff for D128055: [llvm-ar] Improve MRI script CREATE command handling.

Fixed comments, added use of errc_NOENT and COUNT-2, added missing coverage of SAVE between calls to CREATE and improved error message.

Jun 23 2022, 10:02 AM · Restricted Project, Restricted Project

Jun 17 2022

gbreynoo requested review of D128067: [llvm-ar] Fix MRI ADDLIB command when used with thin archives.
Jun 17 2022, 9:07 AM · Restricted Project, Restricted Project
gbreynoo requested review of D128055: [llvm-ar] Improve MRI script CREATE command handling.
Jun 17 2022, 6:53 AM · Restricted Project, Restricted Project

Jun 14 2022

gbreynoo committed rGc4a35c78aab2: [llvm-cxxfilt] Add description for --types in help text (authored by gbreynoo).
[llvm-cxxfilt] Add description for --types in help text
Jun 14 2022, 2:34 AM · Restricted Project, Restricted Project
gbreynoo closed D127656: [llvm-cxxfilt] Add description for --types in help text.
Jun 14 2022, 2:34 AM · Restricted Project, Restricted Project

Jun 13 2022

gbreynoo requested review of D127656: [llvm-cxxfilt] Add description for --types in help text.
Jun 13 2022, 8:34 AM · Restricted Project, Restricted Project

May 12 2022

gbreynoo added a comment to D125439: Ensure that the MRI CREATE/CREATETHIN commands overwrite the output file appropriately.

Thanks for fixing this Ben, once James' suggestions are fixed it LGTM.

May 12 2022, 5:26 AM · Restricted Project, Restricted Project

Apr 28 2022

gbreynoo committed rG5420834aadbd: [demangler] Fix demangling a template argument which happens to be a null… (authored by gbreynoo).
[demangler] Fix demangling a template argument which happens to be a null…
Apr 28 2022, 8:00 AM · Restricted Project, Restricted Project
gbreynoo closed D124010: [llvm-cxxfilt] Unable to demangle a template argument which happens to be a null pointer.
Apr 28 2022, 8:00 AM · Restricted Project, Restricted Project, Restricted Project
gbreynoo added a comment to D124010: [llvm-cxxfilt] Unable to demangle a template argument which happens to be a null pointer.

@urnathan I've created the ticket https://github.com/llvm/llvm-project/issues/55171 regarding the mangling issue. Just to note here, above I mentioned that I thought the mangled output matched GCC but this is not the case.

Apr 28 2022, 7:51 AM · Restricted Project, Restricted Project, Restricted Project

Apr 27 2022

gbreynoo updated the diff for D124010: [llvm-cxxfilt] Unable to demangle a template argument which happens to be a null pointer.

Updated with urnathan's suggestion.

Apr 27 2022, 10:17 AM · Restricted Project, Restricted Project, Restricted Project
gbreynoo added a comment to D124010: [llvm-cxxfilt] Unable to demangle a template argument which happens to be a null pointer.

I now see what you mean @dblaikie . I believe the mangling is functioning correctly and it's output matches GCC, it is the demangling that is the issue. By following @urnathan's code suggestion the demangled output will differ but I don't think this should be a problem as they are equivalent?

Apr 27 2022, 9:43 AM · Restricted Project, Restricted Project, Restricted Project

Apr 26 2022

gbreynoo added a comment to D124445: [llvm-ar] Modify usage printouts to use the correct toolname.

This looks like a good change to me, just needs that ranlib test fixing.

Apr 26 2022, 9:38 AM · Restricted Project, Restricted Project
gbreynoo added inline comments to D124010: [llvm-cxxfilt] Unable to demangle a template argument which happens to be a null pointer.
Apr 26 2022, 9:20 AM · Restricted Project, Restricted Project, Restricted Project
gbreynoo added a comment to D124010: [llvm-cxxfilt] Unable to demangle a template argument which happens to be a null pointer.

Apologies for the delay in response and thank you for your input @dblaikie and @urnathan.

Apr 26 2022, 9:17 AM · Restricted Project, Restricted Project, Restricted Project
gbreynoo updated the diff for D124010: [llvm-cxxfilt] Unable to demangle a template argument which happens to be a null pointer.

Move testing to area suggested by @urnathan.

Apr 26 2022, 9:11 AM · Restricted Project, Restricted Project, Restricted Project

Apr 21 2022

gbreynoo committed rG1f71b5a38605: [llvm-ar] Fix thin archive being wrongly converted to a full archive (authored by gbreynoo).
[llvm-ar] Fix thin archive being wrongly converted to a full archive
Apr 21 2022, 7:49 AM · Restricted Project, Restricted Project
gbreynoo closed D123142: [llvm-ar] Fix thin archive being wrongly converted to a full archive.
Apr 21 2022, 7:49 AM · Restricted Project, Restricted Project

Apr 20 2022

gbreynoo updated the diff for D123142: [llvm-ar] Fix thin archive being wrongly converted to a full archive.

Fixed failing test and @jhenderson's other points.

Apr 20 2022, 8:23 AM · Restricted Project, Restricted Project

Apr 19 2022

gbreynoo added a comment to D124010: [llvm-cxxfilt] Unable to demangle a template argument which happens to be a null pointer.

I am not so familiar with this part of LLVM, I think this testing may belong elsewhere but I am unsure where that would be.

Apr 19 2022, 9:06 AM · Restricted Project, Restricted Project, Restricted Project
gbreynoo requested review of D124010: [llvm-cxxfilt] Unable to demangle a template argument which happens to be a null pointer.
Apr 19 2022, 9:05 AM · Restricted Project, Restricted Project, Restricted Project
gbreynoo added inline comments to D123142: [llvm-ar] Fix thin archive being wrongly converted to a full archive.
Apr 19 2022, 8:37 AM · Restricted Project, Restricted Project
gbreynoo updated the diff for D123142: [llvm-ar] Fix thin archive being wrongly converted to a full archive.

Updated after https://reviews.llvm.org/D123778 was accepted and committed.

Apr 19 2022, 8:36 AM · Restricted Project, Restricted Project
gbreynoo committed rG42865819b224: [llvm-ar][test] Rename two tests and use correct thin command (authored by gbreynoo).
[llvm-ar][test] Rename two tests and use correct thin command
Apr 19 2022, 7:14 AM · Restricted Project, Restricted Project
gbreynoo closed D123778: [llvm-ar][test] Rename two tests and use correct thin command.
Apr 19 2022, 7:14 AM · Restricted Project, Restricted Project

Apr 14 2022

gbreynoo added a comment to D123142: [llvm-ar] Fix thin archive being wrongly converted to a full archive.

Good idea @MaskRay, I've split that into https://reviews.llvm.org/D123778 and will update this one when D123778 is complete.

Apr 14 2022, 3:39 AM · Restricted Project, Restricted Project
gbreynoo requested review of D123778: [llvm-ar][test] Rename two tests and use correct thin command.
Apr 14 2022, 3:37 AM · Restricted Project, Restricted Project

Apr 13 2022

gbreynoo added inline comments to D123142: [llvm-ar] Fix thin archive being wrongly converted to a full archive.
Apr 13 2022, 9:14 AM · Restricted Project, Restricted Project
gbreynoo updated the diff for D123142: [llvm-ar] Fix thin archive being wrongly converted to a full archive.

Corrected comments including replacing use of "full archive" with "regular archive" as suggested. To remain consistent two tests have been renamed to use the term "regular". The checks for "thinness" in llvm-ar.cpp now only applies for write commands.

Apr 13 2022, 9:03 AM · Restricted Project, Restricted Project

Apr 5 2022

gbreynoo added a comment to D123142: [llvm-ar] Fix thin archive being wrongly converted to a full archive.

The following tests have been modified:

  • flatten-thin-archive.test now explicitly checks that %t.a is thin after the other archives have been added.
  • full-to-thin-archive.test uses Inputs/a.txt as an input rather than itself as spurious passes could have occurred when looking for strings contained in the archive file. Corrected a comment, added a test case for an existing archive and a case attempting to convert an existing archive.
  • thin-to-full-archive.test now tests the contents to ensure the thin archives member have been added and not the archive itself. Added a test case for an existing archive and a case attempting to convert an existing archive.
Apr 5 2022, 9:47 AM · Restricted Project, Restricted Project
gbreynoo requested review of D123142: [llvm-ar] Fix thin archive being wrongly converted to a full archive.
Apr 5 2022, 9:45 AM · Restricted Project, Restricted Project

Apr 4 2022

gbreynoo committed rG3ad6f535024c: [llvm-objcopy][docs] Update --update-section description (authored by gbreynoo).
[llvm-objcopy][docs] Update --update-section description
Apr 4 2022, 8:23 AM · Restricted Project, Restricted Project
gbreynoo closed D122907: [llvm-objcopy][docs] Add --update-section to objcopy command guide.
Apr 4 2022, 8:23 AM · Restricted Project, Restricted Project

Apr 1 2022

gbreynoo added inline comments to D122907: [llvm-objcopy][docs] Add --update-section to objcopy command guide.
Apr 1 2022, 9:17 AM · Restricted Project, Restricted Project
gbreynoo updated the diff for D122907: [llvm-objcopy][docs] Add --update-section to objcopy command guide.

Fixed the description after abrachet's comment and updated the help output to mirror the change.

Apr 1 2022, 9:16 AM · Restricted Project, Restricted Project
gbreynoo requested review of D122907: [llvm-objcopy][docs] Add --update-section to objcopy command guide.
Apr 1 2022, 7:59 AM · Restricted Project, Restricted Project

Mar 17 2022

gbreynoo accepted D121902: Fix llvm-strip --only-keep-debug documentation for ELF.

LGTM

Mar 17 2022, 8:02 AM · Restricted Project, Restricted Project

Feb 28 2022

gbreynoo added a comment to D120660: [llvm-symbolizer] Add --approximate-missing-line-numbers Command Line Option.

To be clear this new output is an approximation for cases in which the canonical line number is 0 and so not too helpful to the user. I wanted to suggest this functionality as we have seen cases in which this new option would be useful to a user. Suggestions for a better name than --approximate-missing-line-numbers would also be appreciated.

Feb 28 2022, 6:57 AM · Restricted Project, Restricted Project
gbreynoo requested review of D120660: [llvm-symbolizer] Add --approximate-missing-line-numbers Command Line Option.
Feb 28 2022, 6:56 AM · Restricted Project, Restricted Project

Feb 3 2022

gbreynoo committed rGd17c54d17de2: [llvm-ar] Prevent automatic conversion from thin to full archive (authored by gbreynoo).
[llvm-ar] Prevent automatic conversion from thin to full archive
Feb 3 2022, 3:46 AM
gbreynoo closed D118693: [llvm-ar] Prevent automatic conversion from thin to full archive.
Feb 3 2022, 3:46 AM · Restricted Project

Feb 2 2022

gbreynoo added a comment to D116979: [llvm-ar] Add --thin for creating a thin archive.

@MaskRay Thanks for clarifying.

Feb 2 2022, 3:48 AM · Restricted Project

Feb 1 2022

gbreynoo accepted D117443: [llvm-ar] -s: don't convert a thin archive to a regular one.
Feb 1 2022, 3:58 AM · Restricted Project
gbreynoo added a comment to D117443: [llvm-ar] -s: don't convert a thin archive to a regular one.

Hi @MaskRay, apologies for the wait in this review. The change LGTM. Regarding the implicit conversion from thin to full archives I think there is a problem there, I've created https://reviews.llvm.org/D118693 to discuss it further.

Feb 1 2022, 3:58 AM · Restricted Project
gbreynoo added a comment to D118693: [llvm-ar] Prevent automatic conversion from thin to full archive.

I believe Gnu-ar commands without T on thin archives do not auto convert to "full" archives:

Feb 1 2022, 3:57 AM · Restricted Project
gbreynoo requested review of D118693: [llvm-ar] Prevent automatic conversion from thin to full archive.
Feb 1 2022, 3:56 AM · Restricted Project
gbreynoo added a comment to D116979: [llvm-ar] Add --thin for creating a thin archive.

Hi @MaskRay, apologies for the wait in this review. I think James brought up a good point regarding gnu ar still using T. I realise that when moving towards consistency someone has to go first, but it maybe worth us waiting until they make the change so we maintain compatibility. Do we know if they have plans to move over to --thin?

Feb 1 2022, 3:36 AM · Restricted Project

Jan 17 2022

gbreynoo abandoned D117208: [X86][LLD] Fix warning from updated data layout in LLD tests.

This issue was resolved.

Jan 17 2022, 2:48 AM · Restricted Project

Jan 13 2022

gbreynoo added a comment to D117208: [X86][LLD] Fix warning from updated data layout in LLD tests.

Due to a private patch we were seeing this warning cause a test failure, hence this diff.

Jan 13 2022, 3:49 AM · Restricted Project
gbreynoo requested review of D117208: [X86][LLD] Fix warning from updated data layout in LLD tests.
Jan 13 2022, 3:48 AM · Restricted Project

Jan 11 2022

gbreynoo added a comment to D116977: [llvm-ar] Enforce one-dash form for long options.

LGTM but I will hold of accepting this revision until James has seen the responses.

Jan 11 2022, 9:06 AM · Restricted Project
gbreynoo added a comment to D116979: [llvm-ar] Add --thin for creating a thin archive.

I understand your hesitation @jhenderson regarding the loss of the short option, maybe a replacement short option could be found?

Jan 11 2022, 8:59 AM · Restricted Project

Jan 5 2022

gbreynoo committed rGb30a18f445ea: [llvm-strings] Remove use of hard coded executable name (authored by gbreynoo).
[llvm-strings] Remove use of hard coded executable name
Jan 5 2022, 6:43 AM
gbreynoo closed D116604: [llvm-strings] Remove use of hard coded executable name.
Jan 5 2022, 6:42 AM · Restricted Project