Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/test/CodeGen/AMDGPU/dag-divergence-atomic.ll | ||
---|---|---|
28 | Can you add exhaustive tests for all of these instructions (plus make sure llvm.amdgcn.atomic* work) |
llvm/test/CodeGen/AMDGPU/dag-divergence-atomic.ll | ||
---|---|---|
28 | done, please check whether there are still missing ones. |
llvm/lib/Target/AMDGPU/SIISelLowering.cpp | ||
---|---|---|
11841 | always |
llvm/lib/Target/AMDGPU/SIISelLowering.cpp | ||
---|---|---|
11808 | I didn't know about this one |
llvm/lib/Target/AMDGPU/SIISelLowering.cpp | ||
---|---|---|
11808 | Only AArch64 uses that. Just add that conservatively. |
llvm/lib/Target/AMDGPU/SIISelLowering.cpp | ||
---|---|---|
11802 | Would it make sense to handle these generic nodes in a new TargetLowering::isSDNodeSourceOfDivergence so that we don't have to maintain this list in every target that cares about divergence? |
llvm/lib/Target/AMDGPU/SIISelLowering.cpp | ||
---|---|---|
11802 | We don't really have a generic definition of divergence. For CPU targets the answer would still be no |
llvm/lib/Target/AMDGPU/SIISelLowering.cpp | ||
---|---|---|
11802 | I was hoping CPU targets wouldn't care what we put in TargetLowering::isSDNodeSourceOfDivergence because they never consume the computed divergence information. |
llvm/lib/Target/AMDGPU/SIISelLowering.cpp | ||
---|---|---|
11802 | Another idea to avoid maintaining this list of opcodes: could you return true for any MemSDNode that isAtomic() ? |
llvm/lib/Target/AMDGPU/SIISelLowering.cpp | ||
---|---|---|
11802 | That should work |
Would it make sense to handle these generic nodes in a new TargetLowering::isSDNodeSourceOfDivergence so that we don't have to maintain this list in every target that cares about divergence?