Adding support for intrinsics of AMX-BF16.
This patch alse fix a bug that AMX-INT8 instructions will be selected with wrong
predicate.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang/lib/Headers/amxintrin.h | ||
---|---|---|
283 | Is there much value to differentiate the type? We are using the same AMX type in the builtins. What do you think? @LuoYuanke |
clang/lib/Headers/amxintrin.h | ||
---|---|---|
283 | My first though is that we can reuse __tile1024i for bf16 tile for 2 reasons.
|
clang/lib/Headers/amxintrin.h | ||
---|---|---|
283 | Does this means that user need to do explicitly type conversion? |
clang/lib/Headers/amxintrin.h | ||
---|---|---|
283 | We don't allow user to use the tile in the structure. User should always use load/store intrinsic to pass there own data. |
I don't know why pre-merge-checks failed. I can check-all successfully locally in redhat8. I don't have debian mainchine to reproduce this problem.
clang/lib/Headers/amxintrin.h | ||
---|---|---|
340 | Should we align this with "tile_dpbssd" by renaming it wth "tile_dpbf16ps"? |
+1 first, didn't see key problems.
clang/lib/Headers/amxintrin.h | ||
---|---|---|
340 | Yes, "t" already means "tile" |
clang-tidy: error: "Never use <amxintrin.h> directly; include <immintrin.h> instead." [clang-diagnostic-error]
not useful