Page MenuHomePhabricator

xiangzhangllvm (Xiang Zhang)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 25 2018, 11:14 PM (221 w, 4 d)

Recent Activity

Thu, Mar 23

xiangzhangllvm committed rGcc86e6b0a88b: [BugFix] Fix VSELECT ISel fail (authored by xiangzhangllvm).
[BugFix] Fix VSELECT ISel fail
Thu, Mar 23, 10:14 PM · Restricted Project, Restricted Project
xiangzhangllvm closed D146683: [DAG] Conservatively check the VSELECT Operation Action in tryToFoldExtendSelectLoad.
Thu, Mar 23, 10:14 PM · Restricted Project, Restricted Project
xiangzhangllvm updated the diff for D146683: [DAG] Conservatively check the VSELECT Operation Action in tryToFoldExtendSelectLoad.
Thu, Mar 23, 8:02 PM · Restricted Project, Restricted Project
xiangzhangllvm added inline comments to D146683: [DAG] Conservatively check the VSELECT Operation Action in tryToFoldExtendSelectLoad.
Thu, Mar 23, 7:20 PM · Restricted Project, Restricted Project
xiangzhangllvm updated the diff for D146683: [DAG] Conservatively check the VSELECT Operation Action in tryToFoldExtendSelectLoad.
Thu, Mar 23, 7:11 PM · Restricted Project, Restricted Project
xiangzhangllvm added inline comments to D146683: [DAG] Conservatively check the VSELECT Operation Action in tryToFoldExtendSelectLoad.
Thu, Mar 23, 6:12 PM · Restricted Project, Restricted Project

Wed, Mar 22

xiangzhangllvm updated the diff for D146683: [DAG] Conservatively check the VSELECT Operation Action in tryToFoldExtendSelectLoad.
Wed, Mar 22, 10:16 PM · Restricted Project, Restricted Project
xiangzhangllvm requested review of D146683: [DAG] Conservatively check the VSELECT Operation Action in tryToFoldExtendSelectLoad.
Wed, Mar 22, 8:17 PM · Restricted Project, Restricted Project

Mon, Mar 13

xiangzhangllvm added a comment to D139254: Enhance stack protector.

Are there possible optimizations which can be implemented to reduce the code-size impact of this change? I'm wondering if this patch adds the checks conservatively to all instances where stack check could potentially, but not necessarily, be missed/useful?

Mon, Mar 13, 5:46 PM · Restricted Project, Restricted Project

Thu, Mar 9

xiangzhangllvm added inline comments to D143637: StackProtector: add unwind cleanup paths for instrumentation..
Thu, Mar 9, 6:15 PM · Restricted Project, Restricted Project
xiangzhangllvm accepted D143637: StackProtector: add unwind cleanup paths for instrumentation..
Thu, Mar 9, 5:42 PM · Restricted Project, Restricted Project

Tue, Mar 7

xiangzhangllvm committed rGeed31bbb3721: [NFC] Remove dead code in ExtAddrMode::print checked by coverty tool (authored by xiangzhangllvm).
[NFC] Remove dead code in ExtAddrMode::print checked by coverty tool
Tue, Mar 7, 11:03 PM · Restricted Project, Restricted Project

Sat, Feb 25

xiangzhangllvm added inline comments to D143637: StackProtector: add unwind cleanup paths for instrumentation..
Sat, Feb 25, 11:54 PM · Restricted Project, Restricted Project

Feb 21 2023

xiangzhangllvm added a comment to D143637: StackProtector: add unwind cleanup paths for instrumentation..

I took a quick look, Seems we can't reproduce the report for test in https://bugs.chromium.org/p/llvm/issues/detail?id=30 in latest llvm.

Feb 21 2023, 10:19 PM · Restricted Project, Restricted Project

Feb 15 2023

xiangzhangllvm committed rG96df79af029b: [X86] Support load/store for bf16 in avx (authored by xiangzhangllvm).
[X86] Support load/store for bf16 in avx
Feb 15 2023, 10:40 PM · Restricted Project, Restricted Project
xiangzhangllvm closed D144163: [X86] Support load/store for bf16 vector in avx.
Feb 15 2023, 10:39 PM · Restricted Project, Restricted Project
xiangzhangllvm requested review of D144163: [X86] Support load/store for bf16 vector in avx.
Feb 15 2023, 9:54 PM · Restricted Project, Restricted Project

Feb 9 2023

xiangzhangllvm committed rGf25c7751ceed: [NFC][TableGen] Refine the check in Decoder (authored by xiangzhangllvm).
[NFC][TableGen] Refine the check in Decoder
Feb 9 2023, 12:15 AM · Restricted Project, Restricted Project

Jan 12 2023

xiangzhangllvm committed rG593e17648eb2: Add -disable-check-noreturn-call for stack protect (authored by xiangzhangllvm).
Add -disable-check-noreturn-call for stack protect
Jan 12 2023, 4:32 PM · Restricted Project, Restricted Project
xiangzhangllvm closed D141556: Disable check noreturn call in stack protector.
Jan 12 2023, 4:32 PM · Restricted Project, Restricted Project

Jan 11 2023

xiangzhangllvm added a comment to D139254: Enhance stack protector.

! In D139254#4036649, @smeenai wrote:
I'm going on an extended leave soon, and I won't have time to implement it before then. I've asked some coworkers to take a look, but if you have the time to add the option it'd be hugely appreciated :)

Jan 11 2023, 5:24 PM · Restricted Project, Restricted Project
xiangzhangllvm requested review of D141556: Disable check noreturn call in stack protector.
Jan 11 2023, 5:20 PM · Restricted Project, Restricted Project

Jan 9 2023

xiangzhangllvm added a comment to D139254: Enhance stack protector.

Hi @smeenai , do you have plan to implement it ? If not, I will do it, but may some days later (due to some other jobs in my hands).

I'm going on an extended leave soon, and I won't have time to implement it before then. I've asked some coworkers to take a look, but if you have the time to add the option it'd be hugely appreciated :)

Jan 9 2023, 4:52 PM · Restricted Project, Restricted Project

Jan 8 2023

xiangzhangllvm added a comment to D139254: Enhance stack protector.

Hi @smeenai , do you have plan to implement it ? If not, I will do it, but may some days later (due to some other jobs in my hands).

Jan 8 2023, 4:52 PM · Restricted Project, Restricted Project

Jan 5 2023

xiangzhangllvm added a comment to D139254: Enhance stack protector.

Would there be any objections to adding a flag to restore the previous behavior? This is a fairly hefty size increase for us, and we don't think the additional checking is worth the size increase in our case. We also intend to look into the size increases more to determine how much is from guarding calls to e.g. __cxa_throw, where you will reuse the stack frame, vs. calls to e.g. abort or _Unwind_Resume, where the stack frame should never be reused and checking the stack cookie doesn't seem worthwhile (if my logic is sound, which I'm not 100% sure of).

Jan 5 2023, 5:58 PM · Restricted Project, Restricted Project

Jan 2 2023

xiangzhangllvm added a comment to D139254: Enhance stack protector.

This diff is a ~0.5% size regression under -Oz when building with -fstack-protector. Is this reasonably expected? And one that should be expected given that it's considered to be a correctness fix? cc @smeenai

I think the size increasement is expected because it inserts more stack corruption checks. Do you find any unexpected check?

Jan 2 2023, 4:36 PM · Restricted Project, Restricted Project

Dec 11 2022

xiangzhangllvm added inline comments to D139682: [DAG] Stop replace masked compressstore with normal masked store.
Dec 11 2022, 7:25 PM · Restricted Project, Restricted Project
xiangzhangllvm committed rG7557d94bd8d9: [NFC] Update comment for TRUNC followed by a masked store (authored by xiangzhangllvm).
[NFC] Update comment for TRUNC followed by a masked store
Dec 11 2022, 7:25 PM · Restricted Project, Restricted Project
xiangzhangllvm committed rG9c88ccf9a9bf: [DAG] Stop combine for masked compressstore (authored by xiangzhangllvm).
[DAG] Stop combine for masked compressstore
Dec 11 2022, 6:41 PM · Restricted Project, Restricted Project
xiangzhangllvm closed D139682: [DAG] Stop replace masked compressstore with normal masked store.
Dec 11 2022, 6:41 PM · Restricted Project, Restricted Project
xiangzhangllvm added a comment to D139682: [DAG] Stop replace masked compressstore with normal masked store.

LGTM.

Dec 11 2022, 6:36 PM · Restricted Project, Restricted Project
xiangzhangllvm added inline comments to D139682: [DAG] Stop replace masked compressstore with normal masked store.
Dec 11 2022, 6:04 PM · Restricted Project, Restricted Project
xiangzhangllvm committed rGd656ae280957: Enhance stack protector (authored by xiangzhangllvm).
Enhance stack protector
Dec 11 2022, 4:44 PM · Restricted Project, Restricted Project
xiangzhangllvm closed D139254: Enhance stack protector.
Dec 11 2022, 4:44 PM · Restricted Project, Restricted Project

Dec 9 2022

xiangzhangllvm added inline comments to D139254: Enhance stack protector.
Dec 9 2022, 3:43 AM · Restricted Project, Restricted Project
xiangzhangllvm updated the diff for D139254: Enhance stack protector.
Dec 9 2022, 3:38 AM · Restricted Project, Restricted Project
xiangzhangllvm added inline comments to D139682: [DAG] Stop replace masked compressstore with normal masked store.
Dec 9 2022, 3:25 AM · Restricted Project, Restricted Project

Dec 8 2022

xiangzhangllvm requested review of D139682: [DAG] Stop replace masked compressstore with normal masked store.
Dec 8 2022, 4:53 PM · Restricted Project, Restricted Project
xiangzhangllvm added inline comments to D139254: Enhance stack protector.
Dec 8 2022, 1:31 AM · Restricted Project, Restricted Project
xiangzhangllvm added a comment to D139254: Enhance stack protector.

Could you add a test case for recursively handling __stack_chk_fail?

Dec 8 2022, 12:40 AM · Restricted Project, Restricted Project
xiangzhangllvm updated the diff for D139254: Enhance stack protector.

Add test stack-protector-recursively.ll to check stack protector auto generated function (__stack_chk_fail).

Dec 8 2022, 12:39 AM · Restricted Project, Restricted Project

Dec 7 2022

xiangzhangllvm committed rGacd8af115c93: [X86] Add test masked_compressstore_isel.ll (authored by xiangzhangllvm).
[X86] Add test masked_compressstore_isel.ll
Dec 7 2022, 10:44 PM · Restricted Project, Restricted Project
xiangzhangllvm added a comment to D139254: Enhance stack protector.

ping, thanks

Dec 7 2022, 5:26 PM · Restricted Project, Restricted Project

Dec 6 2022

xiangzhangllvm added inline comments to D139254: Enhance stack protector.
Dec 6 2022, 10:53 PM · Restricted Project, Restricted Project
xiangzhangllvm added a comment to D139254: Enhance stack protector.

There's a problem in the previous iteration of this patch (https://reviews.llvm.org/D138774). It made clang hang while compiling the following short snippet reduced from an open-source library (compiled on x86-64, linux):

$ cat q.c
char *texsubexpr(char *expression, char *subexpr) {
  char *texchar();
  if (*expression) return texchar(expression, subexpr);
}

void __stack_chk_fail (void) {
  __builtin_trap ();
}

$ clang -O1  -w -fstack-protector-all   -c q.c  -o q.o

Please ensure this is solved here.

Dec 6 2022, 10:46 PM · Restricted Project, Restricted Project
xiangzhangllvm updated the diff for D139254: Enhance stack protector.
Dec 6 2022, 10:45 PM · Restricted Project, Restricted Project
xiangzhangllvm added a comment to D139254: Enhance stack protector.

There's a problem in the previous iteration of this patch (https://reviews.llvm.org/D138774). It made clang hang while compiling the following short snippet reduced from an open-source library (compiled on x86-64, linux):

I check it, the clang still hang, let me check and fix it. Thanks very much!

Dec 6 2022, 6:12 PM · Restricted Project, Restricted Project
xiangzhangllvm added a reviewer for D139254: Enhance stack protector: alexfh.
Dec 6 2022, 6:01 PM · Restricted Project, Restricted Project
xiangzhangllvm added a comment to D139254: Enhance stack protector.

There's a problem in the previous iteration of this patch (https://reviews.llvm.org/D138774). It made clang hang while compiling the following short snippet reduced from an open-source library (compiled on x86-64, linux):

Dec 6 2022, 5:40 PM · Restricted Project, Restricted Project

Dec 4 2022

xiangzhangllvm updated the diff for D139254: Enhance stack protector.
Dec 4 2022, 9:28 PM · Restricted Project, Restricted Project

Dec 3 2022

xiangzhangllvm added a comment to D138774: Enhance stack protector.

Update to https://reviews.llvm.org/D139254

Dec 3 2022, 3:12 AM · Restricted Project, Restricted Project
xiangzhangllvm requested review of D139254: Enhance stack protector.
Dec 3 2022, 3:11 AM · Restricted Project, Restricted Project
xiangzhangllvm updated the diff for D138774: Enhance stack protector.

Fix Dominate Tree problems

Dec 3 2022, 3:09 AM · Restricted Project, Restricted Project

Dec 2 2022

xiangzhangllvm added a comment to D138774: Enhance stack protector.

This is causing some bots with EXPENSIVE_CHECKS enabled to fail so I reverted the patch to get the bots back to green: https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-expensive/24249/testReport/junit/LLVM/CodeGen_X86/stack_protector_no_return_ll/

It looks like the StackProtector pass claims to preserve the DT, but with this patch it probably runs into a case where it is not preserved properly, hence the verification failure.

Dec 2 2022, 11:57 PM · Restricted Project, Restricted Project
xiangzhangllvm added a comment to D138774: Enhance stack protector.

Seems not the patch problem, I find the stack protector is strange, it can't be independently print by -print-after-all, and just show in "Module Verifier".
Let me me take a deep look.
thanks very much!

Dec 2 2022, 1:04 AM · Restricted Project, Restricted Project

Nov 30 2022

xiangzhangllvm committed rG416e8c6ad529: Enhance stack protector for calling no return function (authored by xiangzhangllvm).
Enhance stack protector for calling no return function
Nov 30 2022, 9:25 PM · Restricted Project, Restricted Project
xiangzhangllvm closed D138774: Enhance stack protector.
Nov 30 2022, 9:25 PM · Restricted Project, Restricted Project
xiangzhangllvm added a comment to D138774: Enhance stack protector.

Done. @lebedev.ri, clear now, thanks again for explain.

Nov 30 2022, 7:31 PM · Restricted Project, Restricted Project
xiangzhangllvm updated the diff for D138774: Enhance stack protector.
Nov 30 2022, 7:29 PM · Restricted Project, Restricted Project
xiangzhangllvm added a comment to D138774: Enhance stack protector.

Did i not literally answer that question in my original comment?
That being said, i'm not actually able to find any IR-producing tests for this pass, which is worrying.

Nov 30 2022, 5:31 PM · Restricted Project, Restricted Project
xiangzhangllvm requested review of D138987: [AMX] Support AMX-FP16 new intrinsic interface.
Nov 30 2022, 12:52 AM · Restricted Project, Restricted Project, Restricted Project

Nov 29 2022

xiangzhangllvm added a comment to D138774: Enhance stack protector.

This pass operates on IR, so it should have IR-based tests (it should be fine to also have codegen tests, since that is a early-codegen ir based pass)

Nov 29 2022, 9:31 PM · Restricted Project, Restricted Project
xiangzhangllvm added a comment to D138774: Enhance stack protector.

I check the following pull request https://reviews.llvm.org/D138778
it has same
Failed Tests (1):

LLVM :: Examples/OrcV2Examples/lljit-with-thinlto-summaries.test
Nov 29 2022, 4:53 PM · Restricted Project, Restricted Project

Nov 28 2022

xiangzhangllvm updated the diff for D138774: Enhance stack protector.
Nov 28 2022, 10:43 PM · Restricted Project, Restricted Project
xiangzhangllvm added a comment to D138774: Enhance stack protector.

I reproduce according to https://buildkite.com/llvm-project/premerge-checks/builds/123514#0184bd1c-b61e-4f3f-b814-f4698f5d7b1b guide

Nov 28 2022, 9:09 PM · Restricted Project, Restricted Project

Nov 27 2022

xiangzhangllvm requested review of D138774: Enhance stack protector.
Nov 27 2022, 11:19 PM · Restricted Project, Restricted Project

Nov 23 2022

xiangzhangllvm accepted D138547: [X86][AMX] Fix typo of the headerfile..

LGTM, thanks

Nov 23 2022, 4:47 PM · Restricted Project, Restricted Project
xiangzhangllvm accepted D136949: [Debugify] Accumulate the number of variables in debugify metadata.

LGTM, thanks for your contribution!

Nov 23 2022, 4:46 PM · Restricted Project, Restricted Project
xiangzhangllvm added a comment to D136949: [Debugify] Accumulate the number of variables in debugify metadata.

Auto gen is unneccesary.
Try use CHECK-NOT: "assert message" ?

Nov 23 2022, 12:41 AM · Restricted Project, Restricted Project

Nov 22 2022

xiangzhangllvm added a comment to D136949: [Debugify] Accumulate the number of variables in debugify metadata.

Yes, We use XFAIL to mark a test as an expected failure. An XFAIL test will be successful if its execution fails, and will be a failure if its execution succeeds.
But now we are not expected failure. it is strange to test a test case by check nothing (only expect it not go to assert). I am not much sure about it.
@dsanders any suggestions ?

Nov 22 2022, 9:36 PM · Restricted Project, Restricted Project
xiangzhangllvm added inline comments to D136949: [Debugify] Accumulate the number of variables in debugify metadata.
Nov 22 2022, 12:33 AM · Restricted Project, Restricted Project

Nov 21 2022

xiangzhangllvm accepted D138417: [Debugify] Strip llvm.mir.debugify metadata.

Let me accept it first, pls wait a little days to see if other reviewers has different opinions

Nov 21 2022, 5:39 PM · Restricted Project, Restricted Project
xiangzhangllvm added a comment to D138417: [Debugify] Strip llvm.mir.debugify metadata.

LGTM (Seems we never directly run debugify twice before)

Nov 21 2022, 5:36 PM · Restricted Project, Restricted Project
xiangzhangllvm added inline comments to D136949: [Debugify] Accumulate the number of variables in debugify metadata.
Nov 21 2022, 5:22 PM · Restricted Project, Restricted Project

Nov 17 2022

xiangzhangllvm added inline comments to D136949: [Debugify] Accumulate the number of variables in debugify metadata.
Nov 17 2022, 10:06 PM · Restricted Project, Restricted Project
xiangzhangllvm added a comment to D136949: [Debugify] Accumulate the number of variables in debugify metadata.

could you add a small test case here ?

Nov 17 2022, 9:56 PM · Restricted Project, Restricted Project

Nov 15 2022

xiangzhangllvm accepted D137923: [X86][AMX] Fix the shape dependency issue..
Nov 15 2022, 1:22 AM · Restricted Project, Restricted Project
xiangzhangllvm added a comment to D137923: [X86][AMX] Fix the shape dependency issue..

Make sense! LGTM

Nov 15 2022, 1:22 AM · Restricted Project, Restricted Project
xiangzhangllvm added a comment to D137923: [X86][AMX] Fix the shape dependency issue..

How about merge the " load + cast" to the cast position not load.
for example generate the tileload for line 95 105 to line 105:

Nov 15 2022, 12:54 AM · Restricted Project, Restricted Project

Nov 14 2022

xiangzhangllvm added a comment to D137923: [X86][AMX] Fix the shape dependency issue..
static __inline__ void __tile_dpbsud(__tile1024i *dst, __tile1024i src0,
                                     __tile1024i src1) {
  short m = src0.row;
  short n = src1.col;
  short k = src0.col;
  func_use(m, n, k, ...);  // set it as a scheduler boundary and emit nothing for this special variable parameter func. ?
  dst->tile = _tile_dpbsud_internal(m, n, k, dst->tile,
                                    src0.tile, src1.tile);
}
Nov 14 2022, 4:34 PM · Restricted Project, Restricted Project

Nov 13 2022

xiangzhangllvm added a comment to D137923: [X86][AMX] Fix the shape dependency issue..

Maybe it is time to re-review the previous way for implement "let share define before use".
e.g if let frond end do same "make sure" is more beautiful.

Nov 13 2022, 8:57 PM · Restricted Project, Restricted Project

Oct 21 2022

xiangzhangllvm committed rG661881d43633: [X86] Add AMX-FP16 instructions. (authored by xiangzhangllvm).
[X86] Add AMX-FP16 instructions.
Oct 21 2022, 5:06 PM · Restricted Project, Restricted Project, Restricted Project
xiangzhangllvm closed D135941: [X86] Support AMX-FP16.
Oct 21 2022, 5:06 PM · Restricted Project, Restricted Project, Restricted Project
xiangzhangllvm added a comment to D135941: [X86] Support AMX-FP16.

Hi @RKSimon , I sync with Freddy who also use this tool, we decide to merge the disassembler tests. thanks : )

Oct 21 2022, 3:56 PM · Restricted Project, Restricted Project, Restricted Project
xiangzhangllvm added inline comments to D135941: [X86] Support AMX-FP16.
Oct 21 2022, 1:43 AM · Restricted Project, Restricted Project, Restricted Project
xiangzhangllvm updated the diff for D135941: [X86] Support AMX-FP16.

merge disassembler tests

Oct 21 2022, 1:17 AM · Restricted Project, Restricted Project, Restricted Project
xiangzhangllvm updated the diff for D135941: [X86] Support AMX-FP16.
Oct 21 2022, 12:45 AM · Restricted Project, Restricted Project, Restricted Project
xiangzhangllvm added a comment to D135941: [X86] Support AMX-FP16.

yes, so the *.s must be split with intel and att.
So let make same way for disassemble.
Let me first move them into AMX directory.

Oct 21 2022, 12:38 AM · Restricted Project, Restricted Project, Restricted Project

Oct 20 2022

xiangzhangllvm added inline comments to D135941: [X86] Support AMX-FP16.
Oct 20 2022, 6:58 PM · Restricted Project, Restricted Project, Restricted Project
xiangzhangllvm added inline comments to D135941: [X86] Support AMX-FP16.
Oct 20 2022, 5:12 PM · Restricted Project, Restricted Project, Restricted Project
xiangzhangllvm added inline comments to D135941: [X86] Support AMX-FP16.
Oct 20 2022, 5:11 PM · Restricted Project, Restricted Project, Restricted Project

Oct 17 2022

xiangzhangllvm updated the diff for D135941: [X86] Support AMX-FP16.
Oct 17 2022, 10:47 PM · Restricted Project, Restricted Project, Restricted Project
xiangzhangllvm added inline comments to D135941: [X86] Support AMX-FP16.
Oct 17 2022, 10:33 PM · Restricted Project, Restricted Project, Restricted Project
xiangzhangllvm updated the diff for D135941: [X86] Support AMX-FP16.
Oct 17 2022, 1:24 AM · Restricted Project, Restricted Project, Restricted Project
xiangzhangllvm added inline comments to D135941: [X86] Support AMX-FP16.
Oct 17 2022, 12:57 AM · Restricted Project, Restricted Project, Restricted Project
xiangzhangllvm added inline comments to D135941: [X86] Support AMX-FP16.
Oct 17 2022, 12:16 AM · Restricted Project, Restricted Project, Restricted Project
xiangzhangllvm updated the diff for D135941: [X86] Support AMX-FP16.
Oct 17 2022, 12:14 AM · Restricted Project, Restricted Project, Restricted Project

Oct 16 2022

xiangzhangllvm updated the diff for D135941: [X86] Support AMX-FP16.
Oct 16 2022, 11:56 PM · Restricted Project, Restricted Project, Restricted Project
xiangzhangllvm added inline comments to D135941: [X86] Support AMX-FP16.
Oct 16 2022, 11:47 PM · Restricted Project, Restricted Project, Restricted Project
xiangzhangllvm added inline comments to D133914: [InlineAsm][bugfix] Correct function addressing in inline asm.
Oct 16 2022, 10:37 PM · Restricted Project, Restricted Project