Page MenuHomePhabricator

xiangzhangllvm (Xiang Zhang)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 25 2018, 11:14 PM (129 w, 1 d)

Recent Activity

Thu, Jun 3

xiangzhangllvm added inline comments to D102901: [HWASan] Add basic stack tagging support for LAM..
Thu, Jun 3, 8:42 PM · Restricted Project, Unknown Object (Project), Restricted Project
xiangzhangllvm added inline comments to D102901: [HWASan] Add basic stack tagging support for LAM..
Thu, Jun 3, 12:44 AM · Restricted Project, Unknown Object (Project), Restricted Project

Wed, Jun 2

xiangzhangllvm added inline comments to D102901: [HWASan] Add basic stack tagging support for LAM..
Wed, Jun 2, 5:45 PM · Restricted Project, Unknown Object (Project), Restricted Project

Tue, Jun 1

xiangzhangllvm added a comment to D102901: [HWASan] Add basic stack tagging support for LAM..

Sorry for late update, a little busy in these 2 month : )

Tue, Jun 1, 6:57 PM · Restricted Project, Unknown Object (Project), Restricted Project
xiangzhangllvm updated the diff for D102901: [HWASan] Add basic stack tagging support for LAM..
Tue, Jun 1, 6:54 PM · Restricted Project, Unknown Object (Project), Restricted Project
xiangzhangllvm updated the diff for D102901: [HWASan] Add basic stack tagging support for LAM..
Tue, Jun 1, 6:46 PM · Restricted Project, Unknown Object (Project), Restricted Project
xiangzhangllvm committed rG5fc9653faaf9: Remove x86 test amx-fast-tile-config.mir (by its author) (authored by xiangzhangllvm).
Remove x86 test amx-fast-tile-config.mir (by its author)
Tue, Jun 1, 5:39 PM

Wed, May 26

xiangzhangllvm added a comment to D102901: [HWASan] Add basic stack tagging support for LAM..

NO problem, Thanks!

Wed, May 26, 12:15 AM · Restricted Project, Unknown Object (Project), Restricted Project

Tue, May 25

xiangzhangllvm added a comment to D102901: [HWASan] Add basic stack tagging support for LAM..

Hello @morehouse, thanks very much for your careful review, I'll fix all your comments, just for "ClUntagPointer", I feel it very useful in my develop.

Tue, May 25, 12:26 AM · Restricted Project, Unknown Object (Project), Restricted Project

Thu, May 20

xiangzhangllvm added a comment to D102472: [HWASAN] Update the tag info for X86_64.

Hello, @morehouse, I first spilt the change of compiler to https://reviews.llvm.org/D102901
I'll update this link after that small patch in.

Thu, May 20, 11:45 PM · Unknown Object (Project), Restricted Project
xiangzhangllvm requested review of D102901: [HWASan] Add basic stack tagging support for LAM..
Thu, May 20, 11:43 PM · Restricted Project, Unknown Object (Project), Restricted Project
xiangzhangllvm committed rG5684851cb015: [HWASAN] No code changed, Only clang-format for HWAddressSanitizer.cpp (authored by xiangzhangllvm).
[HWASAN] No code changed, Only clang-format for HWAddressSanitizer.cpp
Thu, May 20, 11:01 PM
xiangzhangllvm added a comment to D102472: [HWASAN] Update the tag info for X86_64.

Hello @morehouse, thanks for your work too:
1 OK, I'll break it up into 2 patches, one focus on changes in compiler, the other focus on changes in compiler-rt.

Thu, May 20, 6:08 PM · Unknown Object (Project), Restricted Project
xiangzhangllvm added a project to D102472: [HWASAN] Update the tag info for X86_64: Unknown Object (Project).
Thu, May 20, 2:58 AM · Unknown Object (Project), Restricted Project
xiangzhangllvm updated the diff for D102472: [HWASAN] Update the tag info for X86_64.
Thu, May 20, 2:55 AM · Unknown Object (Project), Restricted Project

Wed, May 19

xiangzhangllvm requested review of D102472: [HWASAN] Update the tag info for X86_64.
Wed, May 19, 10:25 PM · Unknown Object (Project), Restricted Project
xiangzhangllvm added a comment to D102472: [HWASAN] Update the tag info for X86_64.

Hello @eugenis @vitalybuka @morehouse I see you change the related code at compiler-rt, Could you help review this patch? This patch just limited the tag for x86_64.

Wed, May 19, 10:24 PM · Unknown Object (Project), Restricted Project
xiangzhangllvm added a comment to D102472: [HWASAN] Update the tag info for X86_64.

It doesn't look like this was reviewed by anyone. Could you revert this please until it gets reviewed?

Wed, May 19, 10:21 PM · Unknown Object (Project), Restricted Project
xiangzhangllvm added a reverting change for rG81c18ce03cd8: [HWASAN] Update the tag info for X86_64.: rG02f2d739e074: Revert "[HWASAN] Update the tag info for X86_64.".
Wed, May 19, 10:13 PM
xiangzhangllvm committed rG02f2d739e074: Revert "[HWASAN] Update the tag info for X86_64." (authored by xiangzhangllvm).
Revert "[HWASAN] Update the tag info for X86_64."
Wed, May 19, 10:13 PM
xiangzhangllvm added a reverting change for D102472: [HWASAN] Update the tag info for X86_64: rG02f2d739e074: Revert "[HWASAN] Update the tag info for X86_64.".
Wed, May 19, 10:13 PM · Unknown Object (Project), Restricted Project
xiangzhangllvm committed rG81c18ce03cd8: [HWASAN] Update the tag info for X86_64. (authored by xiangzhangllvm).
[HWASAN] Update the tag info for X86_64.
Wed, May 19, 8:23 PM
xiangzhangllvm closed D102472: [HWASAN] Update the tag info for X86_64.
Wed, May 19, 8:22 PM · Unknown Object (Project), Restricted Project
xiangzhangllvm accepted D102472: [HWASAN] Update the tag info for X86_64.
Wed, May 19, 7:34 PM · Unknown Object (Project), Restricted Project

Tue, May 18

xiangzhangllvm updated the diff for D102472: [HWASAN] Update the tag info for X86_64.

Update clang-format

Tue, May 18, 7:31 PM · Unknown Object (Project), Restricted Project

May 14 2021

xiangzhangllvm added inline comments to D102472: [HWASAN] Update the tag info for X86_64.
May 14 2021, 1:49 AM · Unknown Object (Project), Restricted Project
xiangzhangllvm requested review of D102472: [HWASAN] Update the tag info for X86_64.
May 14 2021, 1:05 AM · Unknown Object (Project), Restricted Project

May 11 2021

xiangzhangllvm added inline comments to D102288: [HWASan] Add aliasing flag and enable HWASan to use it..
May 11 2021, 11:00 PM · Unknown Object (Project), Restricted Project
xiangzhangllvm added inline comments to D102286: [HWASan] Build separate LAM runtime on x86_64..
May 11 2021, 10:42 PM · Restricted Project, Unknown Object (Project)

May 8 2021

xiangzhangllvm added inline comments to D102000: [libomptarget] Add support for target memory allocators to cuda RTL.
May 8 2021, 2:03 AM · Restricted Project

May 7 2021

xiangzhangllvm committed rGd4bdeca5765a: [X86] Support AMX fast register allocation (authored by xiangzhangllvm).
[X86] Support AMX fast register allocation
May 7 2021, 11:21 PM
xiangzhangllvm added a reverting change for rG77e2e5e07d01: [X86] Support AMX fast register allocation: rGbebafe01a746: Revert "[X86] Support AMX fast register allocation".
May 7 2021, 10:44 PM
xiangzhangllvm committed rGbebafe01a746: Revert "[X86] Support AMX fast register allocation" (authored by xiangzhangllvm).
Revert "[X86] Support AMX fast register allocation"
May 7 2021, 10:44 PM
xiangzhangllvm committed rG77e2e5e07d01: [X86] Support AMX fast register allocation (authored by xiangzhangllvm).
[X86] Support AMX fast register allocation
May 7 2021, 10:30 PM
xiangzhangllvm updated the diff for D100026: [X86] Support AMX fast register allocation.

refine, compatible with old AMX API

May 7 2021, 9:06 PM · Restricted Project
xiangzhangllvm updated the diff for D100026: [X86] Support AMX fast register allocation.

Fix bkramer's multithread problem.

May 7 2021, 1:07 AM · Restricted Project

Apr 27 2021

xiangzhangllvm added a comment to D101059: [X86][AMX] Add description for AMX new interface..

+1

Apr 27 2021, 1:09 AM · Restricted Project

Apr 26 2021

xiangzhangllvm accepted D101067: [X86][AMX] Try to hoist AMX shapes' def.
Apr 26 2021, 6:48 PM · Restricted Project

Apr 25 2021

xiangzhangllvm added a comment to D100446: [Transforms][Debugify] Fix "Missing line" false alarm on PHI nodes.

So this patch will remove reporting warnings of missing debug loc to PHIs completely, right?

Yes

Can we at least introduce an option to keep checking the PHIs, because there are cases it can be a real issue detected by debugify.

Of course we can. But this warning just for pass generate PHI, we usually ignore warnings if they are make sense. I think the reason @Nuullll write this patch is just that "PHI existed in too many passes, but very few pass generate PHI"

Apr 25 2021, 6:50 PM · Restricted Project

Apr 24 2021

xiangzhangllvm committed rGc3f95e919764: [X86] Refine AMX fast register allocation (authored by xiangzhangllvm).
[X86] Refine AMX fast register allocation
Apr 24 2021, 11:22 PM
xiangzhangllvm committed rG3b8ec86fd576: [X86] Support AMX fast register allocation (authored by xiangzhangllvm).
[X86] Support AMX fast register allocation
Apr 24 2021, 6:48 PM
xiangzhangllvm closed D100026: [X86] Support AMX fast register allocation.
Apr 24 2021, 6:48 PM · Restricted Project
xiangzhangllvm added inline comments to D100026: [X86] Support AMX fast register allocation.
Apr 24 2021, 6:41 PM · Restricted Project
xiangzhangllvm updated the diff for D100026: [X86] Support AMX fast register allocation.

Use clang-format refine.
And add Fixme: at LowAMXType

Apr 24 2021, 6:40 PM · Restricted Project

Apr 23 2021

xiangzhangllvm accepted D100446: [Transforms][Debugify] Fix "Missing line" false alarm on PHI nodes.
Apr 23 2021, 1:24 AM · Restricted Project
xiangzhangllvm added inline comments to D98875: [HWASan] Use page aliasing on x86_64..
Apr 23 2021, 12:33 AM · Restricted Project, Unknown Object (Project)
xiangzhangllvm updated the diff for D100026: [X86] Support AMX fast register allocation.

rebase

Apr 23 2021, 12:21 AM · Restricted Project

Apr 22 2021

xiangzhangllvm added a comment to D101067: [X86][AMX] Try to hoist AMX shapes' def.

+1 first

Apr 22 2021, 8:35 PM · Restricted Project
xiangzhangllvm added inline comments to D101067: [X86][AMX] Try to hoist AMX shapes' def.
Apr 22 2021, 7:13 PM · Restricted Project
xiangzhangllvm added inline comments to D101067: [X86][AMX] Try to hoist AMX shapes' def.
Apr 22 2021, 6:40 PM · Restricted Project
xiangzhangllvm added a comment to D100446: [Transforms][Debugify] Fix "Missing line" false alarm on PHI nodes.

Thanks for your detailed explanation, In my eyes, D75242 eliminated uncommon "warnings" (only pass generate PHI node), but generate common "warnings" (all pass with PHI node ).
Let me first +1 for this patch if no other reviewers object.
LGTM

Apr 22 2021, 6:04 PM · Restricted Project
xiangzhangllvm added a comment to D100446: [Transforms][Debugify] Fix "Missing line" false alarm on PHI nodes.

@vks, do you know why we set PHI with debug_loc but not check it before?

Apr 22 2021, 2:07 AM · Restricted Project
xiangzhangllvm added inline comments to D100446: [Transforms][Debugify] Fix "Missing line" false alarm on PHI nodes.
Apr 22 2021, 2:06 AM · Restricted Project
xiangzhangllvm added inline comments to D98875: [HWASan] Use page aliasing on x86_64..
Apr 22 2021, 12:28 AM · Restricted Project, Unknown Object (Project)

Apr 20 2021

xiangzhangllvm added a comment to D100026: [X86] Support AMX fast register allocation.

Thanks for your reviewing!

Apr 20 2021, 8:24 PM · Restricted Project
xiangzhangllvm accepted D100919: [AArch64] Support customizing stack protector guard.

I didn't find any problem in the main context of the patch, +1 first.

Apr 20 2021, 7:36 PM · Restricted Project, Restricted Project
xiangzhangllvm added inline comments to D100026: [X86] Support AMX fast register allocation.
Apr 20 2021, 7:09 PM · Restricted Project
xiangzhangllvm updated the diff for D100026: [X86] Support AMX fast register allocation.
Apr 20 2021, 7:05 PM · Restricted Project
xiangzhangllvm added inline comments to D100026: [X86] Support AMX fast register allocation.
Apr 20 2021, 1:49 AM · Restricted Project
xiangzhangllvm added a comment to D100026: [X86] Support AMX fast register allocation.

Refined: No new warning in Release build.

Apr 20 2021, 12:44 AM · Restricted Project
xiangzhangllvm updated the diff for D100026: [X86] Support AMX fast register allocation.
Apr 20 2021, 12:40 AM · Restricted Project

Apr 19 2021

xiangzhangllvm added a comment to D100026: [X86] Support AMX fast register allocation.

I'll try build it in release, make sure it no warnings, thanks!

Apr 19 2021, 11:03 PM · Restricted Project
xiangzhangllvm added inline comments to D100026: [X86] Support AMX fast register allocation.
Apr 19 2021, 8:18 PM · Restricted Project
xiangzhangllvm updated the diff for D100026: [X86] Support AMX fast register allocation.

Refine Shape info:
In AMX intrinsics we let Shape = {Row, Col (Bytes) }, but the RealCol = Col / ElementSize. We may use the RealCol as a new Row for other new created AMX intrinsics.

Apr 19 2021, 8:00 PM · Restricted Project

Apr 16 2021

xiangzhangllvm added a comment to D100026: [X86] Support AMX fast register allocation.

The patch is big, thanks for Pengfei's review!

Apr 16 2021, 1:11 AM · Restricted Project
xiangzhangllvm updated the diff for D100026: [X86] Support AMX fast register allocation.
Apr 16 2021, 1:00 AM · Restricted Project

Apr 15 2021

xiangzhangllvm added inline comments to D100026: [X86] Support AMX fast register allocation.
Apr 15 2021, 5:44 PM · Restricted Project
xiangzhangllvm added a comment to D100026: [X86] Support AMX fast register allocation.

Address pengfei's comments:

Apr 15 2021, 5:41 PM · Restricted Project
xiangzhangllvm added inline comments to D100026: [X86] Support AMX fast register allocation.
Apr 15 2021, 4:40 AM · Restricted Project
xiangzhangllvm updated the diff for D100026: [X86] Support AMX fast register allocation.
Apr 15 2021, 4:35 AM · Restricted Project

Apr 14 2021

xiangzhangllvm added a comment to D100026: [X86] Support AMX fast register allocation.

We didn't cover this case currently, also O0 + greedy is not support.

Apr 14 2021, 4:50 PM · Restricted Project
xiangzhangllvm added a comment to D100026: [X86] Support AMX fast register allocation.

Address Pengfei's comments:

Apr 14 2021, 1:00 AM · Restricted Project

Apr 13 2021

xiangzhangllvm abandoned D98757: [AMX] Not fold constant bitcast into amx intrisic.
Apr 13 2021, 5:15 PM · Restricted Project, Restricted Project
xiangzhangllvm accepted D99966: [X86][AMX] Refactor for PostRA ldtilecfg pass..

LGTM, (spill will only happen in the same shape tile register.)

Apr 13 2021, 12:38 AM · Restricted Project

Apr 12 2021

xiangzhangllvm added inline comments to D99966: [X86][AMX] Refactor for PostRA ldtilecfg pass..
Apr 12 2021, 11:48 PM · Restricted Project
xiangzhangllvm updated the summary of D100026: [X86] Support AMX fast register allocation.
Apr 12 2021, 11:05 PM · Restricted Project

Apr 11 2021

xiangzhangllvm added inline comments to D99010: [X86][AMX] Hoist ldtilecfg.
Apr 11 2021, 6:23 PM · Restricted Project
xiangzhangllvm added inline comments to D99966: [X86][AMX] Refactor for PostRA ldtilecfg pass..
Apr 11 2021, 6:02 PM · Restricted Project

Apr 7 2021

xiangzhangllvm added inline comments to D99010: [X86][AMX] Hoist ldtilecfg.
Apr 7 2021, 11:28 PM · Restricted Project
xiangzhangllvm added inline comments to D99010: [X86][AMX] Hoist ldtilecfg.
Apr 7 2021, 10:56 PM · Restricted Project
xiangzhangllvm added inline comments to D99010: [X86][AMX] Hoist ldtilecfg.
Apr 7 2021, 8:47 PM · Restricted Project
xiangzhangllvm added inline comments to D99010: [X86][AMX] Hoist ldtilecfg.
Apr 7 2021, 7:38 PM · Restricted Project
xiangzhangllvm updated the summary of D100026: [X86] Support AMX fast register allocation.
Apr 7 2021, 2:00 AM · Restricted Project
xiangzhangllvm requested review of D100026: [X86] Support AMX fast register allocation.
Apr 7 2021, 1:59 AM · Restricted Project

Apr 6 2021

xiangzhangllvm added inline comments to D99952: [X86] Initialize TargetOptions::StackProtectorGuardOffset member to its default value.
Apr 6 2021, 4:50 PM · Restricted Project

Mar 17 2021

xiangzhangllvm added a comment to D98757: [AMX] Not fold constant bitcast into amx intrisic.

The ongoing special-casing of X86_AMXTy through the llvm due to the inability of the existing backend passes to handle certain llvm ir constructs.

Mar 17 2021, 6:01 PM · Restricted Project, Restricted Project
xiangzhangllvm added a comment to D98757: [AMX] Not fold constant bitcast into amx intrisic.

Once again, i suggest to bring this up on llvm-dev.

Mar 17 2021, 1:49 AM · Restricted Project, Restricted Project
xiangzhangllvm added a comment to D98757: [AMX] Not fold constant bitcast into amx intrisic.

I think that is a traditional backend problem that the pass will just have to be updated to deal with.

Mar 17 2021, 1:09 AM · Restricted Project, Restricted Project
xiangzhangllvm added a comment to D98757: [AMX] Not fold constant bitcast into amx intrisic.

I strongly suggest you bring up this ongoing creep of if (DestTy->isX86_AMXTy()) return false; on llvm-dev.
I strongly supsect you are covering up bugs in you backend/pass with them.

Mar 17 2021, 12:34 AM · Restricted Project, Restricted Project

Mar 16 2021

xiangzhangllvm added inline comments to D98757: [AMX] Not fold constant bitcast into amx intrisic.
Mar 16 2021, 10:59 PM · Restricted Project, Restricted Project
xiangzhangllvm added a comment to D98757: [AMX] Not fold constant bitcast into amx intrisic.

Probably we need a .ll test case to for constant folding.

Fold constant is done in CSE and SCCP which are both passes run in Clang (O2)

Mar 16 2021, 10:22 PM · Restricted Project, Restricted Project
xiangzhangllvm added a comment to D98757: [AMX] Not fold constant bitcast into amx intrisic.

Would you add a test case for it?

Mar 16 2021, 8:41 PM · Restricted Project, Restricted Project
xiangzhangllvm added inline comments to D98757: [AMX] Not fold constant bitcast into amx intrisic.
Mar 16 2021, 8:35 PM · Restricted Project, Restricted Project
xiangzhangllvm added a reviewer for D98757: [AMX] Not fold constant bitcast into amx intrisic: clin1.
Mar 16 2021, 8:24 PM · Restricted Project, Restricted Project
xiangzhangllvm requested review of D98757: [AMX] Not fold constant bitcast into amx intrisic.
Mar 16 2021, 8:12 PM · Restricted Project, Restricted Project
xiangzhangllvm added a comment to D97358: [X86] Support amx-bf16 intrinsic..

+1 first, didn't see key problems.

Mar 16 2021, 5:14 PM · Restricted Project, Restricted Project

Feb 9 2021

xiangzhangllvm added inline comments to D93594: [X86] Pass to transform amx intrinsics to scalar operation..
Feb 9 2021, 4:45 PM · Restricted Project, Restricted Project
xiangzhangllvm added inline comments to D93594: [X86] Pass to transform amx intrinsics to scalar operation..
Feb 9 2021, 1:12 AM · Restricted Project, Restricted Project

Jan 30 2021

xiangzhangllvm added a comment to D95508: [X86] Fix tile config register spill issue for AMX.

Just for interest to improve ReloadTileConfig, now Abandoned this patch

Jan 30 2021, 11:19 PM · Restricted Project
xiangzhangllvm abandoned D95508: [X86] Fix tile config register spill issue for AMX.
Jan 30 2021, 11:17 PM · Restricted Project