Page MenuHomePhabricator

yubing (Bing Yu)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 22 2019, 5:40 PM (46 w, 13 h)

Recent Activity

Wed, Jul 8

yubing added a comment to D81791: [X86][SSE] Add SimplifyDemandedVectorEltsForTargetShuffle to handle target shuffle variable masks..

@yubing @pengfei @craig.topper Please can you confirm the regressions have now been addressed?

Wed, Jul 8, 7:06 PM · Restricted Project
yubing added inline comments to D81791: [X86][SSE] Add SimplifyDemandedVectorEltsForTargetShuffle to handle target shuffle variable masks..
Wed, Jul 8, 12:53 AM · Restricted Project

Jun 1 2020

yubing abandoned D79987: [DAG] SimplifyDemandedVectorElts Bug fix for rG7cb5a51f386d.
Jun 1 2020, 1:33 AM · Restricted Project
yubing added a comment to D79987: [DAG] SimplifyDemandedVectorElts Bug fix for rG7cb5a51f386d.

@yubing I think my fixes for PR45974 have addressed this now - please can you confirm?

Jun 1 2020, 1:33 AM · Restricted Project

May 31 2020

yubing abandoned D80906: [DAG] SimplifyDemandedVectorElts Bugfix for X86ISD::VBROADCAST calculating wrong DemandedElts for its Operand.
May 31 2020, 9:50 PM · Restricted Project
yubing added a comment to D80906: [DAG] SimplifyDemandedVectorElts Bugfix for X86ISD::VBROADCAST calculating wrong DemandedElts for its Operand.

Broadcast should only demand the lowest element. The recursive call to SimplifyDemandedVectorElts call is supposed to ignore the incoming DemandedElts if the SDValue has more than one use.

May 31 2020, 9:32 PM · Restricted Project
yubing updated the summary of D80906: [DAG] SimplifyDemandedVectorElts Bugfix for X86ISD::VBROADCAST calculating wrong DemandedElts for its Operand.
May 31 2020, 8:14 PM · Restricted Project
yubing created D80906: [DAG] SimplifyDemandedVectorElts Bugfix for X86ISD::VBROADCAST calculating wrong DemandedElts for its Operand.
May 31 2020, 8:14 PM · Restricted Project

May 25 2020

yubing added a comment to D79987: [DAG] SimplifyDemandedVectorElts Bug fix for rG7cb5a51f386d.

I'm still looking at fixing getFauxShuffleMask (PR45974) but that might take a while, so this sort of approach is probably necessary.

Did you investigate replacing getTargetShuffleInputs with getTargetShuffleAndZeroables in the SimplifyDemandedBitsForTargetNode/SimplifyDemandedVectorEltsForTargetNode?

May 25 2020, 12:29 AM · Restricted Project

May 24 2020

yubing updated the diff for D79987: [DAG] SimplifyDemandedVectorElts Bug fix for rG7cb5a51f386d.
May 24 2020, 10:23 PM · Restricted Project

May 17 2020

yubing added a comment to rG4580b0f5b65c: [X86] getFauxShuffle - remove (unused) ISD::TRUNCATE shuffle decoding..
May 17 2020, 7:41 PM
yubing added a comment to D79987: [DAG] SimplifyDemandedVectorElts Bug fix for rG7cb5a51f386d.

PING @RKSimon

May 17 2020, 7:41 PM · Restricted Project

May 15 2020

yubing updated the diff for D79987: [DAG] SimplifyDemandedVectorElts Bug fix for rG7cb5a51f386d.
May 15 2020, 10:18 AM · Restricted Project
yubing added a comment to D79987: [DAG] SimplifyDemandedVectorElts Bug fix for rG7cb5a51f386d.

Really we need to stop creating nodes inside getFauxShuffle - I'm going to see if we can do this without too many regressions.

May 15 2020, 10:18 AM · Restricted Project
yubing created D79987: [DAG] SimplifyDemandedVectorElts Bug fix for rG7cb5a51f386d.
May 15 2020, 2:19 AM · Restricted Project

Apr 2 2020

yubing committed rGfe8ac0fe51aa: [x86] Fix Intel OpenCL builtin CalleeSavedRegs on skx (authored by wenju).
[x86] Fix Intel OpenCL builtin CalleeSavedRegs on skx
Apr 2 2020, 8:37 PM
yubing closed D77032: [x86] Fix Intel OpenCL builtin CalleeSavedRegs on skx.
Apr 2 2020, 8:36 PM · Restricted Project

Jan 12 2020

yubing abandoned D72491: [X86] Bugfix for rL146415.

@RKSimon , you're right. After checking https://reviews.llvm.org/rL146415, I found the makefile has disable this testcase for i386.

Jan 12 2020, 7:09 PM · Restricted Project

Jan 9 2020

yubing created D72491: [X86] Bugfix for rL146415.
Jan 9 2020, 7:03 PM · Restricted Project

Dec 4 2019

yubing closed D69986: [X86] Bugfix for rL349334.

Committed in https://github.com/llvm/llvm-test-suite/commit/16265f5a73211d7497e41af43e895eb230c13b89

Dec 4 2019, 6:42 PM · Restricted Project

Nov 11 2019

yubing updated the diff for D69986: [X86] Bugfix for rL349334.
Nov 11 2019, 5:41 PM · Restricted Project

Nov 7 2019

yubing created D69986: [X86] Bugfix for rL349334.
Nov 7 2019, 10:17 PM · Restricted Project

Sep 23 2019

yubing updated the diff for D67212: [x86] Adding support for some missing intrinsics: _castf32_u32, _castf64_u64, _castu32_f32, _castu64_f64.
Sep 23 2019, 11:57 PM · Restricted Project

Sep 22 2019

yubing updated the diff for D67212: [x86] Adding support for some missing intrinsics: _castf32_u32, _castf64_u64, _castu32_f32, _castu64_f64.
Sep 22 2019, 8:37 PM · Restricted Project

Sep 18 2019

yubing added inline comments to D50231: [llvm-exegesis] Renaming classes and functions..
Sep 18 2019, 10:54 PM · Restricted Project
yubing added inline comments to D50231: [llvm-exegesis] Renaming classes and functions..
Sep 18 2019, 7:55 PM · Restricted Project

Sep 17 2019

Herald added a project to D50231: [llvm-exegesis] Renaming classes and functions.: Restricted Project.
Sep 17 2019, 2:07 AM · Restricted Project

Sep 5 2019

yubing abandoned D67210: [x86] bug fix for https://reviews.llvm.org/D64551.
Sep 5 2019, 7:24 PM · Restricted Project
yubing added inline comments to D64551: [X86] EltsFromConsecutiveLoads - support common source loads.
Sep 5 2019, 7:05 PM · Restricted Project
yubing added inline comments to D64551: [X86] EltsFromConsecutiveLoads - support common source loads.
Sep 5 2019, 9:54 AM · Restricted Project
yubing added a comment to D67210: [x86] bug fix for https://reviews.llvm.org/D64551.

Please abandon this, it isn't a valid solution to the issue (raised at PR43227). I have a WIP fix that will address this correctly.

Sep 5 2019, 7:39 AM · Restricted Project
yubing created D67212: [x86] Adding support for some missing intrinsics: _castf32_u32, _castf64_u64, _castu32_f32, _castu64_f64.
Sep 5 2019, 12:11 AM · Restricted Project

Sep 4 2019

yubing added a comment to D64551: [X86] EltsFromConsecutiveLoads - support common source loads.

I've submit a patch to solve the bug which I commented yesterday.
https://reviews.llvm.org/D67210

Sep 4 2019, 11:02 PM · Restricted Project
yubing updated the summary of D67210: [x86] bug fix for https://reviews.llvm.org/D64551.
Sep 4 2019, 10:18 PM · Restricted Project
yubing created D67210: [x86] bug fix for https://reviews.llvm.org/D64551.
Sep 4 2019, 10:15 PM · Restricted Project
yubing added a comment to D64551: [X86] EltsFromConsecutiveLoads - support common source loads.

Hi, Simon. This patch has produced a bug in llvm:

the attached t.ll can reproduce this bug:
For t.ll, llvm without this patch produces the correct asm while llvm with this patch produces bad asm:
llvm with this patch:

Sep 4 2019, 7:56 AM · Restricted Project

Sep 2 2019

yubing updated the diff for D66786: [x86] Fix bugs of some intrinsic functions in CLANG : _mm512_stream_ps, _mm512_stream_pd, _mm512_stream_si512.
Sep 2 2019, 12:34 AM · Restricted Project
yubing updated the diff for D66786: [x86] Fix bugs of some intrinsic functions in CLANG : _mm512_stream_ps, _mm512_stream_pd, _mm512_stream_si512.
Sep 2 2019, 12:06 AM · Restricted Project

Aug 28 2019

yubing updated the diff for D66785: [x86] Adding support for some missing intrinsics: _mm512_cvtsi512_si32.
Aug 28 2019, 10:02 PM · Restricted Project
yubing updated the diff for D66785: [x86] Adding support for some missing intrinsics: _mm512_cvtsi512_si32.
Aug 28 2019, 8:16 PM · Restricted Project
yubing added inline comments to D66785: [x86] Adding support for some missing intrinsics: _mm512_cvtsi512_si32.
Aug 28 2019, 8:01 PM · Restricted Project

Aug 26 2019

yubing retitled D66786: [x86] Fix bugs of some intrinsic functions in CLANG : _mm512_stream_ps, _mm512_stream_pd, _mm512_stream_si512 from [x86] Make some intrinsic functions in CLANG aligned with SPEC: _mm512_stream_ps, _mm512_stream_pd, _mm512_stream_si512 to [x86] Fix bugs of some intrinsic functions in CLANG : _mm512_stream_ps, _mm512_stream_pd, _mm512_stream_si512.
Aug 26 2019, 11:34 PM · Restricted Project
yubing created D66786: [x86] Fix bugs of some intrinsic functions in CLANG : _mm512_stream_ps, _mm512_stream_pd, _mm512_stream_si512.
Aug 26 2019, 11:33 PM · Restricted Project
yubing created D66785: [x86] Adding support for some missing intrinsics: _mm512_cvtsi512_si32.
Aug 26 2019, 11:25 PM · Restricted Project