Work in progress diff, to start a conversation how to fix address/location apis for debug fission.
It's not clear to me how/what this API does - "Unit" is a DWO CU and "this" is the DWARFContext for the executable file (as opposed to for the DWO or DWP file)? Or the other way around?
The "this" DWARFContext is tied to DWO CU. The Unit is for the CU from the binary, the Skeleton CU.
So for example in this user code:
When getNonSkeletonUnitDIE is invoked, it invokes:
We then call:
So in this case "this" is the DwarfUnit from earlier in user code.